chrome-devtools-frontend 1.0.1548870 → 1.0.1549484

package/front_end/core/sdk/SourceMapCache.ts

@@ -9,6 +9,11 @@ export class SourceMapCache {
   static readonly #INSTANCE = new SourceMapCache('devtools-source-map-cache');
 
   static instance(): SourceMapCache {
+    if (typeof window === 'undefined') {
+      // TODO(crbug.com/451502260): Move this behind a `HostRuntime` interface.
+      return IN_MEMORY_INSTANCE as unknown as
+          SourceMapCache;  // TS doesn't like that our in-memory class doesn't have the same private fields.
+    }
     return this.#INSTANCE;
   }
 
@@ -52,3 +57,19 @@ export class SourceMapCache {
     await window.caches.delete(this.#name);
   }
 }
+
+const IN_MEMORY_INSTANCE = new (class implements Pick<SourceMapCache, 'get'|'set'|'disposeForTest'> {
+  readonly #cache = new Map<DebugId, SourceMapV3>();
+
+  async set(debugId: DebugId, sourceMap: SourceMapV3): Promise<void> {
+    this.#cache.set(debugId, sourceMap);
+  }
+
+  async get(debugId: DebugId): Promise<SourceMapV3|null> {
+    return this.#cache.get(debugId) ?? null;
+  }
+
+  async disposeForTest(): Promise<void> {
+    // Do nothing.
+  }
+})();

package/front_end/core/sdk/SourceMapManager.ts

@@ -113,7 +113,7 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
           this.#attachingClient = null;
           const initiator = client.createPageResourceLoadInitiator();
           clientData.sourceMapPromise =
-              loadSourceMap(sourceMapURL, client.debugId(), initiator)
+              loadSourceMap(PageResourceLoader.instance(), sourceMapURL, client.debugId(), initiator)
                   .then(
                       payload => {
                         const sourceMap = this.#factory(sourceURL, sourceMapURL, payload, client);
@@ -180,8 +180,8 @@ export class SourceMapManager<T extends FrameAssociated> extends Common.ObjectWr
   }
 }
 
-export async function loadSourceMap(
-    url: Platform.DevToolsPath.UrlString, debugId: DebugId|null,
+async function loadSourceMap(
+    pageResourceLoader: PageResourceLoader, url: Platform.DevToolsPath.UrlString, debugId: DebugId|null,
     initiator: PageResourceLoadInitiator): Promise<SourceMapV3> {
   try {
     if (debugId) {
@@ -191,7 +191,7 @@ export async function loadSourceMap(
       }
     }
 
-    const {content} = await PageResourceLoader.instance().loadResource(url, initiator);
+    const {content} = await pageResourceLoader.loadResource(url, initiator);
     const sourceMap = parseSourceMap(content);
     if ('debugId' in sourceMap && sourceMap.debugId) {
       // In case something goes wrong with updating the cache, we still want to use the source map.
@@ -204,9 +204,10 @@ export async function loadSourceMap(
 }
 
 export async function tryLoadSourceMap(
-    url: Platform.DevToolsPath.UrlString, initiator: PageResourceLoadInitiator): Promise<SourceMapV3|null> {
+    pageResourceLoader: PageResourceLoader, url: Platform.DevToolsPath.UrlString,
+    initiator: PageResourceLoadInitiator): Promise<SourceMapV3|null> {
   try {
-    return await loadSourceMap(url, null, initiator);
+    return await loadSourceMap(pageResourceLoader, url, null, initiator);
   } catch (cause) {
     console.error(cause);
     return null;

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -121,14 +121,18 @@ export class SourceMapScopesInfo {
       const canMapOriginalPosition = startEntry && endEntry && sourceIndex !== undefined &&
           startEntry.sourceIndex === endEntry.sourceIndex && startEntry.sourceIndex !== undefined && sourceIndex >= 0 &&
           sourceIndex < numSourceUrls;
-      const isStackFrame = node.kind === Formatter.FormatterWorkerPool.ScopeKind.FUNCTION;
+      const isStackFrame = node.kind === Formatter.FormatterWorkerPool.ScopeKind.FUNCTION ||
+          node.kind === Formatter.FormatterWorkerPool.ScopeKind.ARROW_FUNCTION;
+      // TODO(crbug.com/368222773): Instead of mapping `start`, we should report a number of candidates. e.g. for arrow functions we should
+      //     follow the spec and map the `=>` as the spec says that is where the original name (if any) for arrow functions can be found.
+      const name = node.kind === Formatter.FormatterWorkerPool.ScopeKind.FUNCTION ? startEntry?.name : undefined;
 
       let scope: ScopesCodec.OriginalScope|undefined;
       if (canMapOriginalPosition) {
         scope = {
           start: {line: startEntry.sourceLineNumber, column: startEntry.sourceColumnNumber},
           end: {line: endEntry.sourceLineNumber, column: endEntry.sourceColumnNumber},
-          name: startEntry.name,
+          name,
           isStackFrame,
           variables: [],
           children: [],

package/front_end/core/sdk/TargetManager.ts

@@ -14,6 +14,16 @@ import {type RegistrationInfo, SDKModel, type SDKModelConstructor} from './SDKMo
 import {Target, Type as TargetType} from './Target.js';
 
 export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
+  /**
+   * @deprecated
+   *
+   * Intended for {@link SDKModel} classes to be able to retrieve scoped singletons like
+   * the "PageResourceLoader" or the "FrameManager".
+   *
+   * This is only an intermediate step to migrate towards our "layering vision" where
+   * SDKModels don't require things from the next layer.
+   */
+  readonly context: Root.DevToolsContext.DevToolsContext;
   #targets: Set<Target>;
   readonly #observers: Set<Observer>;
   /* eslint-disable @typescript-eslint/no-explicit-any */
@@ -36,8 +46,9 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
   /**
    * @param overrideAutoStartModels If provided, then the `autostart` flag on {@link RegistrationInfo} will be ignored.
    */
-  constructor(overrideAutoStartModels?: Set<SDKModelConstructor>) {
+  constructor(context: Root.DevToolsContext.DevToolsContext, overrideAutoStartModels?: Set<SDKModelConstructor>) {
     super();
+    this.context = context;
     this.#targets = new Set();
     this.#observers = new Set();
     this.#modelListeners = new Platform.MapUtilities.Multimap();
@@ -55,7 +66,8 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
     forceNew: boolean,
   } = {forceNew: false}): TargetManager {
     if (!Root.DevToolsContext.globalInstance().has(TargetManager) || forceNew) {
-      Root.DevToolsContext.globalInstance().set(TargetManager, new TargetManager());
+      Root.DevToolsContext.globalInstance().set(
+          TargetManager, new TargetManager(Root.DevToolsContext.globalInstance()));
     }
 
     return Root.DevToolsContext.globalInstance().get(TargetManager);

package/front_end/core/sdk/sdk-meta.ts

@@ -387,6 +387,10 @@ const UIStrings = {
    * @description Title of a setting under the Sources category that can be invoked through the Command Menu
    */
   disableCssSourceMaps: 'Disable CSS source maps',
+  /**
+   * @description Title of a setting under the Console category in Settings
+   */
+  logXmlhttprequests: 'Log XMLHttpRequests',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -1194,3 +1198,12 @@ Common.Settings.registerSettingExtension({
     },
   ],
 });
+
+Common.Settings.registerSettingExtension({
+  category: Common.Settings.SettingCategory.CONSOLE,
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  title: i18nLazyString(UIStrings.logXmlhttprequests),
+  settingName: 'monitoring-xhr-enabled',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+});

package/front_end/entrypoints/formatter_worker/FormatterActions.ts

@@ -48,6 +48,7 @@ export const enum ScopeKind {
   BLOCK = 1,
   FUNCTION = 2,
   GLOBAL = 3,
+  ARROW_FUNCTION = 4,
 }
 
 export interface ScopeTreeNode {

package/front_end/entrypoints/formatter_worker/ScopeParser.ts

@@ -172,7 +172,7 @@ export class ScopeVariableAnalysis {
         node.elements.forEach(item => this.#processNode(item));
         break;
       case 'ArrowFunctionExpression': {
-        this.#pushScope(node.start, node.end, ScopeKind.FUNCTION);
+        this.#pushScope(node.start, node.end, ScopeKind.ARROW_FUNCTION);
         node.params.forEach(this.#processNodeAsDefinition.bind(this, DefinitionKind.VAR, false));
         if (node.body.type === 'BlockStatement') {
           // Include the body of the arrow function in the same scope as the arguments.

package/front_end/entrypoints/main/MainImpl.ts

@@ -132,6 +132,7 @@ let loadedPanelCommonModule: typeof PanelCommon|undefined;
 export class MainImpl {
   #readyForTestPromise = Promise.withResolvers<void>();
   #veStartPromise!: Promise<void>;
+  #universe!: Foundation.Universe.Universe;
 
   constructor() {
     MainImpl.instanceForTest = this;
@@ -175,8 +176,8 @@ export class MainImpl {
         runSettingsMigration: !Host.InspectorFrontendHost.isUnderTest(),
       },
     };
-    const universe = new Foundation.Universe.Universe(creationOptions);
-    Root.DevToolsContext.setGlobalInstance(universe.context);
+    this.#universe = new Foundation.Universe.Universe(creationOptions);
+    Root.DevToolsContext.setGlobalInstance(this.#universe.context);
 
     await this.requestAndRegisterLocaleData();
 
@@ -425,6 +426,7 @@ export class MainImpl {
         {forceNew: true, win: window, frontendHost: Host.InspectorFrontendHost.InspectorFrontendHostInstance});
     UI.ContextMenu.ContextMenu.initialize();
     UI.ContextMenu.ContextMenu.installHandler(document);
+    UI.ViewManager.ViewManager.instance({forceNew: true, universe: this.#universe});
 
     // These instances need to be created early so they don't miss any events about requests/issues/etc.
     Logs.NetworkLog.NetworkLog.instance();
@@ -445,6 +447,14 @@ export class MainImpl {
     targetManager.addEventListener(
         SDK.TargetManager.Events.SUSPEND_STATE_CHANGED, this.#onSuspendStateChanged.bind(this));
 
+    SDK.PageResourceLoader.PageResourceLoader.instance({
+      forceNew: true,
+      targetManager,
+      settings: Common.Settings.Settings.instance(),
+      userAgentProvider: SDK.NetworkManager.MultitargetNetworkManager.instance(),
+      loadOverride: null,
+    });
+
     Workspace.FileManager.FileManager.instance({forceNew: true});
 
     Bindings.NetworkProject.NetworkProjectManager.instance();
@@ -939,7 +949,7 @@ export class MainMenuItem implements UI.Toolbar.Provider {
     contextMenu.appendItemsAtLocation('mainMenu');
     const moreTools =
         contextMenu.defaultSection().appendSubMenuItem(i18nString(UIStrings.moreTools), false, 'more-tools');
-    const viewExtensions = UI.ViewManager.getRegisteredViewExtensions();
+    const viewExtensions = UI.ViewManager.ViewManager.instance().getRegisteredViewExtensions();
     viewExtensions.sort((extension1, extension2) => {
       const title1 = extension1.title();
       const title2 = extension2.title();

package/front_end/foundation/Universe.ts

@@ -24,7 +24,7 @@ export class Universe {
       ...options.settingsCreationOptions,
     });
 
-    const targetManager = new SDK.TargetManager.TargetManager(options.overrideAutoStartModels);
+    const targetManager = new SDK.TargetManager.TargetManager(this.context, options.overrideAutoStartModels);
     this.context.set(SDK.TargetManager.TargetManager, targetManager);
 
     const workspace = new Workspace.Workspace.WorkspaceImpl();

package/front_end/generated/Deprecation.ts

@@ -58,6 +58,10 @@ export const UIStrings = {
    * @description Warning displayed to developers when a data: URL is assigned to SVGUseElement to let them know that the support is deprecated.
    */
   DataUrlInSvgUse: "Support for data: URLs in SVGUseElement is deprecated and it will be removed in the future.",
+  /**
+   * @description Translation is not needed, this will never be exposed in production code.
+   */
+  ExampleBrowserProcessDeprecation: "This is an example for showing the code required for a browser process reported deprecation.",
   /**
    * @description A deprecation warning shown in the DevTools Issues tab. It's shown when one of the Protected Audience APIs like `navigator.joinAdInterestGroup`, `navigator.getInterestGroupAdAuctionData` or `navigator.runAdAuction` are called.
    */
@@ -174,10 +178,6 @@ export const UIStrings = {
    * @description Standard message when one web API is deprecated in favor of another.
    */
   PrefixedVideoSupportsFullscreen: "HTMLVideoElement.webkitSupportsFullscreen is deprecated. Please use Document.fullscreenEnabled instead.",
-  /**
-   * @description Warning displayed to developers that the API `chrome.privacy.websites.privacySandboxEnabled` is being deprecated in favour of three new more granular APIs: topicsEnabled, FledgeEnabled and adMeasurementEnabled. The `privacySandboxEnabled` API allowed extensions to control the homologous Chrome Setting. The existing Chrome Setting for Privacy Sandbox is also going away in favor of more granular settings that are matched by the new extensions APIs- topicsEnabled, FledgeEnabled and adMeasurementEnabled.
-   */
-  PrivacySandboxExtensionsAPI: "We're deprecating the API `chrome.privacy.websites.privacySandboxEnabled`, though it will remain active for backward compatibility until release M113. Instead, please use `chrome.privacy.websites.topicsEnabled`, `chrome.privacy.websites.fledgeEnabled` and `chrome.privacy.websites.adMeasurementEnabled`. See https://developer.chrome.com/docs/extensions/reference/privacy/#property-websites-privacySandboxEnabled.",
   /**
    * @description Standard message when one web API is deprecated in favor of another.
    */
@@ -210,6 +210,14 @@ export const UIStrings = {
    * @description A deprecation warning shown in the DevTools Issues tab. The placeholder is always the noun 'SharedArrayBuffer' which refers to a JavaScript construct.
    */
   SharedArrayBufferConstructedWithoutIsolation: "`SharedArrayBuffer` will require cross-origin isolation. See https://developer.chrome.com/blog/enabling-shared-array-buffer/ for more details.",
+  /**
+   * @description A deprecation warning shown in the DevTools Issues tab. It's shown when one of the Shared Storage APIs like `sharedStorage.set()`, `sharedStorage.worklet.addModule()`, `sharedStorage.selectURL()`, etc., along with `<img sharedstoragewritable>`, `<iframe sharedstoragewritable>`, or `fetch(url, {sharedStorageWritable: true})` are used.
+   */
+  SharedStorage: "The Shared Storage API is deprecated and will be removed in a future release.",
+  /**
+   * @description A deprecation warning shown in the DevTools Issues tab. It's shown when the `document.requestStorageAccessFor` API is called. The placeholder will always be the string `document.requestStorageAccessFor`.
+   */
+  StorageAccessAPI_requestStorageAccessFor_Method: "`document.requestStorageAccessFor` is deprecated and will be removed. See https://privacysandbox.com/news/update-on-plans-for-privacy-sandbox-technologies/ for more details.",
   /**
    * @description A deprecation warning shown in the DevTools Issues tab. It's shown when the speech synthesis API is called before the page receives a user activation.
    */
@@ -351,6 +359,12 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
   "SharedArrayBufferConstructedWithoutIsolation": {
     "milestone": 106
   },
+  "SharedStorage": {
+    "chromeStatusFeature": 5076349064708096
+  },
+  "StorageAccessAPI_requestStorageAccessFor_Method": {
+    "chromeStatusFeature": 5162221567082496
+  },
   "TextToSpeech_DisallowedByAutoplay": {
     "chromeStatusFeature": 5687444770914304,
     "milestone": 71