chrome-devtools-frontend 1.0.1547147 → 1.0.1548870

package/front_end/ui/legacy/ReportView.ts

@@ -50,7 +50,7 @@ export class ReportView extends VBox {
   }
 
   setSubtitle(subtitle: string): void {
-    if (this.subtitleElement && this.subtitleElement.textContent === subtitle) {
+    if (this.subtitleElement?.textContent === subtitle) {
       return;
     }
     if (!this.subtitleElement) {

package/front_end/ui/legacy/TabbedPane.ts

@@ -261,7 +261,7 @@ export class TabbedPane extends Common.ObjectWrapper.eventMixin<EventTypes, type
     if (userGesture && !tab.closeable) {
       return;
     }
-    if (this.currentTab && this.currentTab.id === id) {
+    if (this.currentTab?.id === id) {
       this.hideCurrentTab();
     }
 
@@ -335,7 +335,7 @@ export class TabbedPane extends Common.ObjectWrapper.eventMixin<EventTypes, type
       isUserGesture: userGesture,
     };
     this.dispatchEventToListeners(Events.TabInvoked, eventData);
-    if (this.currentTab && this.currentTab.id === id) {
+    if (this.currentTab?.id === id) {
       return true;
     }
 
@@ -474,7 +474,7 @@ export class TabbedPane extends Common.ObjectWrapper.eventMixin<EventTypes, type
     }
 
     this.suspendInvalidations();
-    const isSelected = this.currentTab && this.currentTab.id === id;
+    const isSelected = this.currentTab?.id === id;
     const shouldFocus = tab.view.hasFocus();
     if (isSelected) {
       this.hideTab(tab);

package/front_end/ui/legacy/Treeoutline.ts

@@ -1254,7 +1254,7 @@ export class TreeElement {
     ARIAUtils.clearSelected(this.listItemNode);
     this.setFocusable(false);
 
-    if (this.treeOutline && this.treeOutline.selectedTreeElement === this) {
+    if (this.treeOutline?.selectedTreeElement === this) {
       this.treeOutline.selectedTreeElement = null;
       this.treeOutline.updateFocusable();
       if (hadFocus) {

package/front_end/ui/legacy/components/color_picker/ContrastInfo.ts

@@ -37,7 +37,7 @@ export class ContrastInfo extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
     this.#contrastRatioAPCAThreshold =
         Common.ColorUtils.getAPCAThreshold(contrastInfo.computedFontSize, contrastInfo.computedFontWeight);
 
-    if (!contrastInfo.backgroundColors || contrastInfo.backgroundColors.length !== 1) {
+    if (contrastInfo.backgroundColors?.length !== 1) {
       return;
     }
     const bgColorText = contrastInfo.backgroundColors[0];

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -466,7 +466,8 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
       cell.createChild('div', 'sort-order-icon-container').appendChild(icon);
 
       if (column.title) {
-        UI.ARIAUtils.setLabel(cell, i18nString(UIStrings.sortableColumn));
+        const columnLabel = `${column.title} - ${i18nString(UIStrings.sortableColumn)}`;
+        UI.ARIAUtils.setLabel(cell, columnLabel);
       }
     }
   }
@@ -2341,7 +2342,7 @@ export class DataGridNode<T> {
   }
 
   deselect(supressDeselectedEvent?: boolean): void {
-    if (!this.dataGrid || this.dataGrid.selectedNode !== this || !this.selected) {
+    if (this.dataGrid?.selectedNode !== this || !this.selected) {
       return;
     }
 

package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts

@@ -49,6 +49,7 @@ import objectPropertiesSectionStyles from './objectPropertiesSection.css.js';
 import objectValueStyles from './objectValue.css.js';
 import {RemoteObjectPreviewFormatter, renderNodeTitle} from './RemoteObjectPreviewFormatter.js';
 
+const {widgetConfig} = UI.Widget;
 const {ref, repeat, ifDefined, classMap} = Directives;
 const UIStrings = {
   /**
@@ -135,7 +136,6 @@ const UIStrings = {
 } as const;
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/object_ui/ObjectPropertiesSection.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-const EXPANDABLE_MAX_LENGTH = 50;
 const EXPANDABLE_MAX_DEPTH = 100;
 
 const objectPropertiesSectionMap = new WeakMap<Element, ObjectPropertiesSection>();
@@ -639,13 +639,16 @@ export class ObjectPropertiesSection extends UI.TreeOutline.TreeOutlineInShadow
         const text = JSON.stringify(description);
         const tooLong = description.length > maxRenderableStringLength;
         return html`<span class="value object-value-string" title=${ifDefined(tooLong ? undefined : description)}>${
-            tooLong ? new ExpandableTextPropertyValue(text, EXPANDABLE_MAX_LENGTH).element : text}</span>`;
+            tooLong ? html`<devtools-widget .widgetConfig=${
+                          widgetConfig(ExpandableTextPropertyValue, {text})}></devtools-widget>` :
+                      text}</span>`;
       }
       if (type === 'object' && subtype === 'trustedtype') {
         const text = `${className} '${description}'`;
         const tooLong = text.length > maxRenderableStringLength;
         return html`<span class="value object-value-trustedtype" title=${ifDefined(tooLong ? undefined : text)}>${
-            tooLong ? new ExpandableTextPropertyValue(text, EXPANDABLE_MAX_LENGTH).element :
+            tooLong ? html`<devtools-widget .widgetConfig=${
+                          widgetConfig(ExpandableTextPropertyValue, {text})}></devtools-widget>` :
                       html`${className} <span class=object-value-string title=${description}>${
                           JSON.stringify(description)}</span>`}</span>`;
       }
@@ -663,8 +666,9 @@ export class ObjectPropertiesSection extends UI.TreeOutline.TreeOutlineInShadow
           >${renderNodeTitle(description)}</span>`;
       }
       if (description.length > maxRenderableStringLength) {
-        return html`<span class="value object-value-${subtype || type}" title=${description}>${
-            new ExpandableTextPropertyValue(description, EXPANDABLE_MAX_LENGTH).element}</span>`;
+        return html`<span class="value object-value-${subtype || type}" title=${description}><devtools-widget
+                  .widgetConfig=${
+            widgetConfig(ExpandableTextPropertyValue, {text: description})}></devtools-widget></span>`;
       }
       const hasPreview = value.preview && showPreview;
       return html`<span class="value object-value-${subtype || type}" title=${description}>${
@@ -992,7 +996,6 @@ export class ObjectPropertyTreeElement extends UI.TreeOutline.TreeElement {
   private linkifier: Components.Linkifier.Linkifier|undefined;
   private readonly maxNumPropertiesToShow: number;
   readOnly!: boolean;
-  private prompt!: ObjectPropertyPrompt|undefined;
   #editing = false;
   readonly #view: TreeElementView;
   #completions: string[] = [];
@@ -1107,39 +1110,6 @@ export class ObjectPropertyTreeElement extends UI.TreeOutline.TreeElement {
     treeNode.appendChild(infoElement);
   }
 
-  static createRemoteObjectAccessorPropertySpan(
-      object: SDK.RemoteObject.RemoteObject|null, propertyPath: string[],
-      callback: (arg0: SDK.RemoteObject.CallFunctionResult) => void): HTMLElement {
-    const rootElement = document.createElement('span');
-    const element = rootElement.createChild('span');
-    element.textContent = i18nString(UIStrings.dots);
-    if (!object) {
-      return rootElement;
-    }
-    element.classList.add('object-value-calculate-value-button');
-    UI.Tooltip.Tooltip.install(element, i18nString(UIStrings.invokePropertyGetter));
-    element.addEventListener('click', onInvokeGetterClick, false);
-
-    function onInvokeGetterClick(event: Event): void {
-      event.consume();
-      if (object) {
-        void object.callFunction(invokeGetter, [{value: JSON.stringify(propertyPath)}]).then(callback);
-      }
-    }
-
-    function invokeGetter(this: Object, arrayStr: string): Object {
-      let result: Object = this;
-      const properties = JSON.parse(arrayStr);
-      for (let i = 0, n = properties.length; i < n; ++i) {
-        // @ts-expect-error callFunction expects this to be a generic Object, so while this works we can't be more specific on types.
-        result = result[properties[i]];
-      }
-      return result;
-    }
-
-    return rootElement;
-  }
-
   get nameElement(): Element|undefined {
     return this.#nameElement;
   }
@@ -1623,13 +1593,6 @@ export class ArrayGroupingTreeElement extends UI.TreeOutline.TreeElement {
   static sparseIterationThreshold = 250000;
 }
 
-export class ObjectPropertyPrompt extends UI.TextPrompt.TextPrompt {
-  constructor() {
-    super();
-    this.initialize(TextEditor.JavaScript.completeInContext);
-  }
-}
-
 export class ObjectPropertiesSectionsTreeExpandController {
   static readonly #propertyPathCache = new WeakMap<UI.TreeOutline.TreeElement, string>();
   static readonly #sectionMap = new WeakMap<RootElement, string>();
@@ -1740,89 +1703,102 @@ export class Renderer implements UI.UIUtils.Renderer {
   }
 }
 
-export class ExpandableTextPropertyValue {
-  private readonly text: string;
-  private readonly maxLength: number;
-  private readonly maxDisplayableTextLength: number;
-  readonly #byteCount: number;
-  #expanded = false;
-  #element: DocumentFragment;
-
-  constructor(text: string, maxLength: number) {
-    this.#element = document.createDocumentFragment();
-    this.text = text;
-    this.maxLength = maxLength;
-    this.maxDisplayableTextLength = 10000000;
-    this.#byteCount = Platform.StringUtilities.countWtf8Bytes(text);
-    this.#render();
-  }
-
-  get element(): DocumentFragment {
-    return this.#element;
-  }
-
-  #render(): void {
-    const totalBytesText = i18n.ByteUtilities.bytesToString(this.#byteCount);
-    const onContextMenu = (e: Event): void => {
-      const {target} = e;
-      if (!(target instanceof Element)) {
-        return;
-      }
-      const listItem = target.closest('li');
-      const element = listItem && UI.TreeOutline.TreeElement.getTreeElementBylistItemNode(listItem);
-      if (!(element instanceof ObjectPropertyTreeElement)) {
-        return;
-      }
-      const contextMenu = element.getContextMenu(e);
-      if (this.text.length < this.maxDisplayableTextLength && !this.#expanded) {
-        contextMenu.clipboardSection().appendItem(
-            i18nString(UIStrings.showMoreS, {PH1: totalBytesText}), this.expandText.bind(this),
-            {jslogContext: 'show-more'});
-      }
+interface ExpandableTextViewInput {
+  copyText: () => void;
+  expandText: () => void;
+  expanded: boolean;
+  maxLength: number;
+  byteCount: number;
+  text: string;
+}
+type ExpandableTextView = (input: ExpandableTextViewInput, output: object, target: HTMLElement) => void;
+export const EXPANDABLE_TEXT_DEFAULT_VIEW: ExpandableTextView = (input, output, target) => {
+  const totalBytesText = i18n.ByteUtilities.bytesToString(input.byteCount);
+  const canExpand = input.text.length < ExpandableTextPropertyValue.MAX_DISPLAYABLE_TEXT_LENGTH;
+  const onContextMenu = (e: Event): void => {
+    const {target} = e;
+    if (!(target instanceof Element)) {
+      return;
+    }
+    const listItem = target.closest('li');
+    const element = listItem && UI.TreeOutline.TreeElement.getTreeElementBylistItemNode(listItem);
+    if (!(element instanceof ObjectPropertyTreeElement)) {
+      return;
+    }
+    const contextMenu = element.getContextMenu(e);
+    if (canExpand && !input.expanded) {
       contextMenu.clipboardSection().appendItem(
-          i18nString(UIStrings.copy), this.copyText.bind(this), {jslogContext: 'copy'});
-      void contextMenu.show();
-      e.consume(true);
-    };
+          i18nString(UIStrings.showMoreS, {PH1: totalBytesText}), input.expandText, {jslogContext: 'show-more'});
+    }
+    contextMenu.clipboardSection().appendItem(i18nString(UIStrings.copy), input.copyText, {jslogContext: 'copy'});
+    void contextMenu.show();
+    e.consume(true);
+  };
 
-    const croppedText = this.text.slice(0, this.maxLength);
+  const croppedText = input.text.slice(0, input.maxLength);
 
-    // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
-    render(
-        // clang-format off
+  render(
+      // clang-format off
         html`<span title=${croppedText + '…'} @contextmenu=${onContextMenu}>
-               ${this.#expanded ? this.text : croppedText}
+               ${input.expanded ? input.text : croppedText}
                <button
-                 ?hidden=${this.#expanded}
-                 @click=${this.#canExpand ? this.expandText.bind(this) : undefined}
-                 jslog=${ifDefined(this.#canExpand ? VisualLogging.action('expand').track({click: true}) : undefined)}
-                 class=${this.#canExpand ? 'expandable-inline-button' : 'undisplayable-text'}
-                 data-text=${this.#canExpand ? i18nString(UIStrings.showMoreS, {PH1: totalBytesText}) :
+                 ?hidden=${input.expanded}
+                 @click=${canExpand ? input.expandText : undefined}
+                 jslog=${ifDefined(canExpand ? VisualLogging.action('expand').track({click: true}) : undefined)}
+                 class=${canExpand ? 'expandable-inline-button' : 'undisplayable-text'}
+                 data-text=${canExpand ? i18nString(UIStrings.showMoreS, {PH1: totalBytesText}) :
                                            i18nString(UIStrings.longTextWasTruncatedS, {PH1: totalBytesText})}
                  ></button>
                <button
                  class=expandable-inline-button
-                 @click=${this.copyText.bind(this)}
+                 @click=${input.copyText}
                  data-text=${i18nString(UIStrings.copy)}
                  jslog=${VisualLogging.action('copy').track({click: true})}
                  ></button>
              </span>`,
-        // clang-format on
-        this.#element);
+      // clang-format on
+      target);
+};
+
+export class ExpandableTextPropertyValue extends UI.Widget.Widget {
+  static readonly MAX_DISPLAYABLE_TEXT_LENGTH = 10000000;
+  static readonly EXPANDABLE_MAX_LENGTH = 50;
+  #text = '';
+  #byteCount = 0;
+  #expanded = false;
+  #maxLength = ExpandableTextPropertyValue.EXPANDABLE_MAX_LENGTH;
+  readonly #view: ExpandableTextView;
+
+  constructor(target?: HTMLElement, view = EXPANDABLE_TEXT_DEFAULT_VIEW) {
+    super(target);
+    this.#view = view;
   }
 
-  get #canExpand(): boolean {
-    return this.text.length < this.maxDisplayableTextLength;
+  set text(text: string) {
+    this.#text = text;
+    this.#byteCount = Platform.StringUtilities.countWtf8Bytes(text);
+    this.requestUpdate();
   }
 
-  private expandText(): void {
-    if (!this.#expanded) {
-      this.#expanded = true;
-      this.#render();
-    }
+  set maxLength(maxLength: number) {
+    this.#maxLength = maxLength;
+    this.requestUpdate();
   }
 
-  private copyText(): void {
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(this.text);
+  override performUpdate(): void {
+    const input: ExpandableTextViewInput = {
+      copyText: () => Host.InspectorFrontendHost.InspectorFrontendHostInstance.copyText(this.#text),
+      expandText: () => {
+        if (!this.#expanded) {
+          this.#expanded = true;
+          this.requestUpdate();
+        }
+      },
+      expanded: this.#expanded,
+      byteCount: this.#byteCount,
+      maxLength: this.#maxLength,
+      text: this.#text,
+    };
+    this.#view(input, {}, this.contentElement);
   }
 }

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -1130,8 +1130,7 @@ const searchHighlighter = CodeMirror.ViewPlugin.fromClass(class {
             }
             if (match[0].length) {
               const start = pos + match.index, end = start + match[0].length;
-              const current =
-                  active.currentRange && active.currentRange.from === start && active.currentRange.to === end;
+              const current = active.currentRange?.from === start && active.currentRange.to === end;
               builder.add(start, end, current ? currentSearchMatchDeco : searchMatchDeco);
             } else {
               active.regexp.regex.lastIndex = match.index + 1;

package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -217,7 +217,7 @@ export function buildStackTraceRows(
 }
 
 function renderStackTraceTable(
-    container: Element, parent: Element,
+    container: Element, parent: Element, expandable: boolean,
     stackTraceRows: Array<StackTraceRegularRow|StackTraceAsyncRow>): HTMLElement[] {
   container.removeChildren();
   const links: HTMLElement[] = [];
@@ -225,20 +225,33 @@ function renderStackTraceTable(
   // The tableSection groups one or more synchronous call frames together.
   // Wherever there is an asynchronous call, a new section is created.
   let tableSection: Element|null = null;
+  let firstRow = true;
   for (const item of stackTraceRows) {
     if (!tableSection || 'asyncDescription' in item) {
       tableSection = container.createChild('tbody');
     }
 
     const row = tableSection.createChild('tr');
-    if ('asyncDescription' in item) {
+    if (firstRow && expandable) {
+      const button = row.createChild('td').createChild('button', 'arrow-icon-button');
+      button.createChild('span', 'arrow-icon');
+      parent.classList.add('expandable');
+      container.classList.add('expandable');
+      button.addEventListener('click', () => {
+        button.setAttribute('jslog', `${VisualLogging.expand().track({click: true})}`);
+        parent.classList.toggle('expanded');
+        container.classList.toggle('expanded');
+      });
+      firstRow = false;
+    } else {
       row.createChild('td').textContent = '\n';
+    }
+    if ('asyncDescription' in item) {
       row.createChild('td', 'stack-preview-async-description').textContent = item.asyncDescription;
       row.createChild('td');
       row.createChild('td');
       row.classList.add('stack-preview-async-row');
     } else {
-      row.createChild('td').textContent = '\n';
       row.createChild('td', 'function-name').textContent = item.functionName;
       row.createChild('td').textContent = ' @ ';
       if (item.link) {
@@ -284,13 +297,13 @@ function renderStackTraceTable(
 export interface Options {
   // TODO(crbug.com/456517732): remove when all usages of runtimeStackTrace are migrated.
   runtimeStackTrace?: Protocol.Runtime.StackTrace;
-  stackTrace?: StackTrace.StackTrace.StackTrace;
   tabStops?: boolean;
   // Whether the width of stack trace preview
   // is constrained to its container or whether
   // it can grow the container.
   widthConstrained?: boolean;
   showColumnNumber?: boolean;
+  expandable?: boolean;
 }
 
 export interface StackTraceRegularRow {
@@ -303,8 +316,10 @@ export interface StackTraceAsyncRow {
 }
 
 export class StackTracePreviewContent extends UI.Widget.Widget {
+  #stackTrace?: StackTrace.StackTrace.StackTrace;
   #target?: SDK.Target.Target;
   #linkifier?: Linkifier;
+  #ownedLinkifier?: Linkifier;
   #options: Options;
   #links: HTMLElement[] = [];
 
@@ -315,6 +330,10 @@ export class StackTracePreviewContent extends UI.Widget.Widget {
 
     this.#target = target;
     this.#linkifier = linkifier;
+    if (!this.#linkifier) {
+      this.#ownedLinkifier = new Linkifier();
+      this.#linkifier = this.#ownedLinkifier;
+    }
     this.#options = options || {
       widthConstrained: false,
     };
@@ -329,7 +348,7 @@ export class StackTracePreviewContent extends UI.Widget.Widget {
     this.#table = this.contentElement.createChild('table', 'stack-preview-container');
     this.#table.classList.toggle('width-constrained', this.#options.widthConstrained ?? false);
 
-    this.#options.stackTrace?.addEventListener(StackTrace.StackTrace.Events.UPDATED, this.performUpdate.bind(this));
+    this.#stackTrace?.addEventListener(StackTrace.StackTrace.Events.UPDATED, this.performUpdate.bind(this));
 
     this.performUpdate();
   }
@@ -339,21 +358,22 @@ export class StackTracePreviewContent extends UI.Widget.Widget {
       return;
     }
 
-    const {runtimeStackTrace, stackTrace, tabStops} = this.#options;
+    const {runtimeStackTrace, tabStops} = this.#options;
 
-    if (stackTrace) {
+    if (this.#stackTrace) {
       const stackTraceRows = buildStackTraceRows(
-          stackTrace, this.#target ?? null, this.#linkifier, tabStops, this.#options.showColumnNumber);
-      this.#links = renderStackTraceTable(this.#table, this.element, stackTraceRows);
+          this.#stackTrace, this.#target ?? null, this.#linkifier, tabStops, this.#options.showColumnNumber);
+      this.#links = renderStackTraceTable(this.#table, this.element, this.#options.expandable ?? false, stackTraceRows);
       return;
     }
 
     // TODO(crbug.com/456517732): remove when all usages of runtimeStackTrace are migrated.
-    const updateCallback = renderStackTraceTable.bind(null, this.#table, this.element);
+    const updateCallback =
+        renderStackTraceTable.bind(null, this.#table, this.element, this.#options.expandable ?? false);
     const stackTraceRows = buildStackTraceRowsForLegacyRuntimeStackTrace(
         runtimeStackTrace ?? {callFrames: []}, this.#target ?? null, this.#linkifier, tabStops, updateCallback,
         this.#options.showColumnNumber);
-    this.#links = renderStackTraceTable(this.#table, this.element, stackTraceRows);
+    this.#links = renderStackTraceTable(this.#table, this.element, this.#options.expandable ?? false, stackTraceRows);
   }
 
   get linkElements(): readonly HTMLElement[] {
@@ -374,4 +394,13 @@ export class StackTracePreviewContent extends UI.Widget.Widget {
     this.#options = options;
     this.requestUpdate();
   }
+
+  set stackTrace(stackTrace: StackTrace.StackTrace.StackTrace) {
+    this.#stackTrace = stackTrace;
+    this.requestUpdate();
+  }
+
+  override onDetach(): void {
+    this.#ownedLinkifier?.dispose();
+  }
 }

package/front_end/ui/legacy/components/utils/jsUtils.css

@@ -99,6 +99,34 @@
   &:not(.show-hidden-rows) > tfoot > tr.show-less-link {
     --display-toggle-link: none;
   }
+
+  .arrow-icon-button {
+    cursor: pointer;
+    padding: 1px 0;
+    border: none;
+    background: none;
+    margin-left: -4px;
+    margin-right: -2px;
+  }
+
+  .arrow-icon {
+    display: inline-block;
+    mask-image: var(--image-file-triangle-right);
+    background-color: var(--icon-default);
+    margin-top: 2px;
+    height: 14px;
+    width: 14px;
+    transition: transform 200ms;
+  }
+
+  &.expanded .arrow-icon{
+    transform: rotate(90deg);
+  }
+
+  &.expandable:not(.expanded) tbody:not(:first-of-type),
+  &.expandable:not(.expanded) tbody tr:not(:first-of-type) {
+    display: none;
+  }
 }
 
 /* The show more/less links aren't really a part of the content

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1753,6 +1753,7 @@ export const knownContextValues = new Set([
   'grid-column-start',
   'grid-gap',
   'grid-how',
+  'grid-lanes',
   'grid-overlays',
   'grid-row',
   'grid-row-end',

package/front_end/ui/visual_logging/LoggingConfig.ts

@@ -131,7 +131,8 @@ function checkContextValue(context: string|number|undefined): void {
   if (Root.Runtime.Runtime.queryParam('debugFrontend') || Host.InspectorFrontendHost.isUnderTest() ||
       localStorage.getItem('veDebugLoggingEnabled') === DebugLoggingFormat.TEST) {
     const stack = (new Error().stack || '').split('\n').slice(3).join('\n');
-    console.error(`Unknown VE context: ${context}${stack}`);
+    console.error(`Unknown VE context: '${context}'\n${
+        stack}\nPlease add it to front_end/ui/visual_logging/KnownContextValues.ts if you think that's a valid context value.`);
   }
   reportedUnknownVeContext.add(context);
 }

package/inspector_overlay/tool_window_controls.ts

@@ -38,7 +38,10 @@ export class WindowControlsOverlay extends Overlay {
   }
 
   override uninstall() {
-    this.document.body.innerHTML = '';
+    this.windowsToolBar.remove();
+    this.linuxToolBar.remove();
+    this.macToolbarRight.remove();
+    this.macToolbarLeft.remove();
     super.uninstall();
   }
 

package/mcp/mcp.ts

@@ -31,6 +31,6 @@ export {
   type EventTypes as IssuesManagerEventTypes,
   IssuesManager
 } from '../front_end/models/issues_manager/IssuesManager.js';
-export {findTitleFromMarkdownAst} from '../front_end/models/issues_manager/MarkdownIssueDescription.js';
+export * as MarkdownIssueDescription from '../front_end/models/issues_manager/MarkdownIssueDescription.js';
 export * as TraceEngine from '../front_end/models/trace/trace.js';
 export * as Marked from '../front_end/third_party/marked/marked.js';

package/package.json

@@ -21,11 +21,10 @@
     "build": "vpython3 third_party/node/node.py --output scripts/run_build.mjs",
     "check-external-links": "vpython3 third_party/node/node.py --output scripts/check_external_links.js",
     "collect-strings": "vpython3 third_party/node/node.py --output third_party/i18n/collect-strings.js front_end",
-    "components-server": "vpython3 third_party/node/node.py --output scripts/component_server/server.js",
     "debug-webtest": "vpython3 third_party/node/node.py --output scripts/npm_test.js --debug-devtools",
     "generate-protocol-resources": "vpython3 scripts/deps/generate_protocol_resources.py && git cl format --js",
     "install-deps": "vpython3 scripts/deps/manage_node_deps.py",
-    "lint": "vpython3 third_party/node/node.py --output --experimental-strip-types --no-warnings=ExperimentalWarning scripts/test/run_lint_check.mjs",
+    "lint": "vpython3 third_party/node/node.py --output scripts/test/run_lint_check.mjs",
     "prebuild": "gn gen out/Default",
     "rdb": "rdb stream -new -realm chromium:public --",
     "start": "vpython3 third_party/node/node.py --output scripts/run_start.mjs",
@@ -103,5 +102,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1547147"
+  "version": "1.0.1548870"
 }

package/front_end/core/common/Worker.ts

@@ -1,60 +0,0 @@
-// Copyright 2014 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-export class WorkerWrapper {
-  readonly #workerPromise: Promise<Worker>;
-  #disposed?: boolean;
-  #rejectWorkerPromise?: (error: Error) => void;
-
-  private constructor(workerLocation: URL) {
-    this.#workerPromise = new Promise((fulfill, reject) => {
-      this.#rejectWorkerPromise = reject;
-      const worker = new Worker(workerLocation, {type: 'module'});
-      worker.onerror = event => {
-        console.error(`Failed to load worker for ${workerLocation.href}:`, event);
-      };
-      worker.onmessage = (event: MessageEvent<unknown>) => {
-        console.assert(event.data === 'workerReady');
-        worker.onmessage = null;
-        fulfill(worker);
-      };
-    });
-  }
-
-  static fromURL(url: URL): WorkerWrapper {
-    return new WorkerWrapper(url);
-  }
-
-  postMessage(message: unknown, transfer?: Transferable[]): void {
-    void this.#workerPromise.then(worker => {
-      if (!this.#disposed) {
-        worker.postMessage(message, transfer ?? []);
-      }
-    });
-  }
-
-  dispose(): void {
-    this.#disposed = true;
-    void this.#workerPromise.then(worker => worker.terminate());
-  }
-
-  terminate(immediately = false): void {
-    if (immediately) {
-      this.#rejectWorkerPromise?.(new Error('Worker terminated'));
-    }
-    this.dispose();
-  }
-
-  set onmessage(listener: (event: MessageEvent) => void) {
-    void this.#workerPromise.then(worker => {
-      worker.onmessage = listener;
-    });
-  }
-
-  set onerror(listener: (event: Event) => void) {
-    void this.#workerPromise.then(worker => {
-      worker.onerror = listener;
-    });
-  }
-}