chrome-devtools-frontend 1.0.1544076 → 1.0.1547147

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -17,6 +17,7 @@ import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Workspace from '../../models/workspace/workspace.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as Snackbars from '../../ui/components/snackbars/snackbars.js';
+import * as UIHelpers from '../../ui/helpers/helpers.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
@@ -223,7 +224,7 @@ function selectedElementFilter(maybeNode: SDK.DOMModel.DOMNode|null): SDK.DOMMod
 
 async function getEmptyStateSuggestions(
     context: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null,
-    conversation?: AiAssistanceModel.AiHistoryStorage.Conversation):
+    conversation?: AiAssistanceModel.AiConversation.AiConversation):
     Promise<AiAssistanceModel.AiAgent.ConversationSuggestion[]> {
   if (context) {
     const specialSuggestions = await context.getSuggestions();
@@ -269,7 +270,7 @@ async function getEmptyStateSuggestions(
 
 function getMarkdownRenderer(
     context: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null,
-    conversation?: AiAssistanceModel.AiHistoryStorage.Conversation): MarkdownRendererWithCodeBlock {
+    conversation?: AiAssistanceModel.AiConversation.AiConversation): MarkdownRendererWithCodeBlock {
   if (context instanceof AiAssistanceModel.PerformanceAgent.PerformanceTraceContext) {
     if (!context.external) {
       const focus = context.getItem();
@@ -494,7 +495,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #mutex = new Common.Mutex.Mutex();
 
   #conversationAgent?: AiAssistanceModel.AiAgent.AiAgent<unknown>;
-  #conversation?: AiAssistanceModel.AiHistoryStorage.Conversation;
+  #conversation?: AiAssistanceModel.AiConversation.AiConversation;
 
   #selectedFile: AiAssistanceModel.FileAgent.FileContext|null = null;
   #selectedElement: AiAssistanceModel.StylingAgent.NodeContext|null = null;
@@ -719,7 +720,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
   #updateConversationState(opts?: {
     agent?: AiAssistanceModel.AiAgent.AiAgent<unknown>,
-    conversation?: AiAssistanceModel.AiHistoryStorage.Conversation,
+    conversation?: AiAssistanceModel.AiConversation.AiConversation,
   }): void {
     if (this.#conversationAgent !== opts?.agent) {
       // Cancel any previous conversation
@@ -732,7 +733,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       // If we get a new agent we need to
       // create a new conversation along side it
       if (opts?.agent) {
-        this.#conversation = new AiAssistanceModel.AiHistoryStorage.Conversation(
+        this.#conversation = new AiAssistanceModel.AiConversation.AiConversation(
             agentToConversationType(opts.agent),
             [],
             opts.agent.id,
@@ -957,7 +958,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       onDeleteClick: this.#onDeleteClicked.bind(this),
       onExportConversationClick: this.#onExportConversationClick.bind(this),
       onHelpClick: () => {
-        UI.UIUtils.openInNewTab(AI_ASSISTANCE_HELP);
+        UIHelpers.openInNewTab(AI_ASSISTANCE_HELP);
       },
       onSettingsClick: () => {
         void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
@@ -1211,7 +1212,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #populateHistoryMenu(contextMenu: UI.ContextMenu.ContextMenu): void {
     const historicalConversations = AiAssistanceModel.AiHistoryStorage.AiHistoryStorage.instance().getHistory().map(
         serializedConversation =>
-            AiAssistanceModel.AiHistoryStorage.Conversation.fromSerializedConversation(serializedConversation));
+            AiAssistanceModel.AiConversation.AiConversation.fromSerializedConversation(serializedConversation));
     for (const conversation of historicalConversations.reverse()) {
       if (conversation.isEmpty) {
         continue;
@@ -1280,7 +1281,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     Workspace.FileManager.FileManager.instance().close(filename);
   }
 
-  async #openHistoricConversation(conversation: AiAssistanceModel.AiHistoryStorage.Conversation): Promise<void> {
+  async #openHistoricConversation(conversation: AiAssistanceModel.AiConversation.AiConversation): Promise<void> {
     if (this.#conversation === conversation) {
       return;
     }
@@ -1420,7 +1421,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     this.#blockedByCrossOrigin = !this.#selectedContext.isOriginAllowed(this.#conversationAgent.origin);
   }
 
-  #getConversationContext(conversation?: AiAssistanceModel.AiHistoryStorage.Conversation):
+  #getConversationContext(conversation?: AiAssistanceModel.AiConversation.AiConversation):
       AiAssistanceModel.AiAgent.ConversationContext<unknown>|null {
     if (!conversation) {
       return null;
@@ -1655,7 +1656,7 @@ export function getResponseMarkdown(message: ModelChatMessage): string {
     }
     if (step.contextDetails) {
       contentParts.push(
-          AiAssistanceModel.AiHistoryStorage.Conversation.generateContextDetailsMarkdown(step.contextDetails));
+          AiAssistanceModel.AiConversation.AiConversation.generateContextDetailsMarkdown(step.contextDetails));
     }
     if (step.thought) {
       contentParts.push(step.thought);

package/front_end/panels/ai_assistance/ai_assistance-meta.ts

@@ -161,6 +161,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   featurePromotionId: 'ai-assistance',
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
@@ -176,6 +177,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -191,6 +193,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -206,6 +209,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -221,6 +225,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -236,6 +241,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -251,6 +257,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();
@@ -265,6 +272,7 @@ UI.ActionRegistration.registerActionExtension({
   },
   category: UI.ActionRegistration.ActionCategory.GLOBAL,
   title: titleForAiAssistanceActions,
+  configurableBindings: false,
   async loadActionDelegate() {
     const AiAssistance = await loadAiAssistanceModule();
     return new AiAssistance.ActionDelegate();

package/front_end/panels/ai_assistance/components/ChatView.ts

@@ -698,7 +698,7 @@ function renderStep({step, isLoading, markdownRenderer, isLast}: {
 }): Lit.LitTemplate {
   const stepClasses = Lit.Directives.classMap({
     step: true,
-    empty: !step.thought && !step.code && !step.contextDetails,
+    empty: !step.thought && !step.code && !step.contextDetails && !step.sideEffect,
     paused: Boolean(step.sideEffect),
     canceled: Boolean(step.canceled),
   });
@@ -884,7 +884,7 @@ function renderChatMessage({
 }
 
 function renderImageChatMessage(inlineData: Host.AidaClient.MediaBlob): Lit.LitTemplate {
-  if (inlineData.data === AiAssistanceModel.AiHistoryStorage.NOT_FOUND_IMAGE_DATA) {
+  if (inlineData.data === AiAssistanceModel.AiConversation.NOT_FOUND_IMAGE_DATA) {
     // clang-format off
     return html`<div class="unavailable-image" title=${UIStringsNotTranslate.imageUnavailable}>
       <devtools-icon name='file-image'></devtools-icon>

package/front_end/panels/ai_assistance/components/UserActionRow.ts

@@ -8,6 +8,7 @@ import * as i18n from '../../../core/i18n/i18n.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as Buttons from '../../../ui/components/buttons/buttons.js';
 import * as Input from '../../../ui/components/input/input.js';
+import * as UIHelpers from '../../../ui/helpers/helpers.js';
 import * as UI from '../../../ui/legacy/legacy.js';
 import * as Lit from '../../../ui/lit/lit.js';
 import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
@@ -321,7 +322,7 @@ export class UserActionRow extends UI.Widget.Widget implements UserActionRowWidg
         {
           onSuggestionClick: this.onSuggestionClick,
           onRatingClick: this.#handleRateClick.bind(this),
-          onReportClick: () => UI.UIUtils.openInNewTab(REPORT_URL),
+          onReportClick: () => UIHelpers.openInNewTab(REPORT_URL),
           onCopyResponseClick: this.onCopyResponseClick,
           scrollSuggestionsScrollContainer: this.#scrollSuggestionsScrollContainer.bind(this),
           onSuggestionsScrollOrResize: this.#handleSuggestionsScrollOrResize.bind(this),

package/front_end/panels/animation/AnimationTimeline.ts

@@ -508,14 +508,6 @@ export class AnimationTimeline extends UI.Widget.VBox implements
   }
 
   private setPlaybackRate(playbackRate: number): void {
-    if (playbackRate !== this.#playbackRate) {
-      Host.userMetrics.animationPlaybackRateChanged(
-          playbackRate === 0.1      ? Host.UserMetrics.AnimationsPlaybackRate.PERCENT_10 :
-              playbackRate === 0.25 ? Host.UserMetrics.AnimationsPlaybackRate.PERCENT_25 :
-              playbackRate === 1    ? Host.UserMetrics.AnimationsPlaybackRate.PERCENT_100 :
-                                      Host.UserMetrics.AnimationsPlaybackRate.OTHER);
-    }
-
     this.#playbackRate = playbackRate;
     for (const animationModel of SDK.TargetManager.TargetManager.instance().models(
              SDK.AnimationModel.AnimationModel, {scoped: true})) {

package/front_end/panels/application/ApplicationPanelSidebar.ts

@@ -51,13 +51,13 @@ import {BackForwardCacheTreeElement} from './BackForwardCacheTreeElement.js';
 import {BackgroundServiceModel} from './BackgroundServiceModel.js';
 import {BackgroundServiceView} from './BackgroundServiceView.js';
 import {BounceTrackingMitigationsTreeElement} from './BounceTrackingMitigationsTreeElement.js';
-import * as ApplicationComponents from './components/components.js';
 import {type DOMStorage, DOMStorageModel, Events as DOMStorageModelEvents} from './DOMStorageModel.js';
 import {
   Events as ExtensionStorageModelEvents,
   type ExtensionStorage,
   ExtensionStorageModel,
 } from './ExtensionStorageModel.js';
+import {FrameDetailsReportView} from './FrameDetailsView.js';
 import {
   type Database as IndexedDBModelDatabase,
   type DatabaseId,
@@ -2149,8 +2149,7 @@ export class FrameTreeElement extends ApplicationPanelTreeElement {
   private readonly treeElementForResource: Map<string, FrameResourceTreeElement>;
   private treeElementForWindow: Map<Protocol.Target.TargetID, FrameWindowTreeElement>;
   private treeElementForWorker: Map<Protocol.Target.TargetID, WorkerTreeElement>;
-  private view: LegacyWrapper.LegacyWrapper
-      .LegacyWrapper<UI.Widget.Widget, ApplicationComponents.FrameDetailsView.FrameDetailsReportView>|null;
+  private view: FrameDetailsReportView|null;
 
   constructor(section: ResourcesSection, frame: SDK.ResourceTreeModel.ResourceTreeFrame) {
     super(section.panel, '', false, 'frame');
@@ -2195,8 +2194,8 @@ export class FrameTreeElement extends ApplicationPanelTreeElement {
     this.treeElementForWorker.clear();
 
     if (this.selected) {
-      this.view = LegacyWrapper.LegacyWrapper.legacyWrapper(
-          UI.Widget.Widget, new ApplicationComponents.FrameDetailsView.FrameDetailsReportView(this.frame));
+      this.view = new FrameDetailsReportView();
+      this.view.frame = this.frame;
       this.showView(this.view);
     } else {
       this.view = null;
@@ -2233,8 +2232,8 @@ export class FrameTreeElement extends ApplicationPanelTreeElement {
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
     if (!this.view) {
-      this.view = LegacyWrapper.LegacyWrapper.legacyWrapper(
-          UI.Widget.Widget, new ApplicationComponents.FrameDetailsView.FrameDetailsReportView(this.frame));
+      this.view = new FrameDetailsReportView();
+      this.view.frame = this.frame;
     }
     Host.userMetrics.panelShown('frame-details');
     this.showView(this.view);