chrome-devtools-frontend 1.0.1542501 → 1.0.1543472

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -325,7 +325,6 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why the request has an IPP icon
    */
-  responseIsIpProtectedToolTip: 'This request was sent through IP Protection proxies.',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/network/NetworkDataGridNode.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -1175,12 +1174,6 @@ export class NetworkRequestNode extends NetworkNode {
       cell.addEventListener('focus', () => this.parentView().resetFocus());
 
       // render icons
-      if (this.requestInternal.isIpProtectionUsed()) {
-        const ippIcon = IconButton.Icon.create('shield', 'icon');
-        ippIcon.title = i18nString(UIStrings.responseIsIpProtectedToolTip);
-        ippIcon.style.color = 'var(--sys-color-on-surface-subtle);';
-        cell.appendChild(ippIcon);
-      }
 
       const iconElement = PanelUtils.getIconForNetworkRequest(this.requestInternal);
       // eslint-disable-next-line @devtools/no-lit-render-outside-of-view

package/front_end/panels/network/NetworkLogView.ts

@@ -128,14 +128,6 @@ const UIStrings = {
    * @description Tooltip for a filter in the Network panel
    */
   onlyShowThirdPartyRequests: 'Show only requests with origin different from page origin',
-  /**
-   * @description Label for a filter in the Network panel
-   */
-  ippRequests: 'IP Protected requests',
-  /**
-   * @description Tooltip for a filter in the Network panel
-   */
-  onlyShowIPProtectedRequests: 'Show only requests sent to IP Protection proxies. Has no effect in regular browsing.',
   /**
    * @description Text that appears when user drag and drop something (for example, a file) in Network Log View of the Network panel
    */
@@ -530,7 +522,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
   private readonly networkOnlyThirdPartySetting: Common.Settings.Setting<boolean>;
   private readonly networkResourceTypeFiltersSetting: Common.Settings.Setting<Record<string, boolean>>;
   private readonly networkShowOptionsToGenerateHarWithSensitiveData: Common.Settings.Setting<boolean>;
-  private readonly networkOnlyIPProtectedRequestsSetting: Common.Settings.Setting<boolean>;
   private readonly progressBarContainer: Element;
   private readonly networkLogLargeRowsSetting: Common.Settings.Setting<boolean>;
   private rowHeightInternal: number;
@@ -586,8 +577,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
         Common.Settings.Settings.instance().createSetting('network-only-blocked-requests', false);
     this.networkOnlyThirdPartySetting =
         Common.Settings.Settings.instance().createSetting('network-only-third-party-setting', false);
-    this.networkOnlyIPProtectedRequestsSetting =
-        Common.Settings.Settings.instance().createSetting('network-only-ip-protected-requests', false);
     this.networkResourceTypeFiltersSetting =
         Common.Settings.Settings.instance().createSetting('network-resource-type-filters', {});
     this.networkShowOptionsToGenerateHarWithSensitiveData = Common.Settings.Settings.instance().createSetting(
@@ -1603,7 +1592,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     this.networkOnlyBlockedRequestsSetting.set(false);
     this.networkOnlyThirdPartySetting.set(false);
     this.networkHideChromeExtensions.set(false);
-    this.networkOnlyIPProtectedRequestsSetting.set(false);
     this.resourceCategoryFilterUI.reset();
   }
 
@@ -2108,16 +2096,12 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     if (!this.resourceCategoryFilterUI.accept(categoryName)) {
       return false;
     }
-    const [hideDataURL, blockedCookies, blockedRequests, thirdParty, hideExtensionURL, ippRequests] = [
+    const [hideDataURL, blockedCookies, blockedRequests, thirdParty, hideExtensionURL] = [
       this.networkHideDataURLSetting.get(),
       this.networkShowBlockedCookiesOnlySetting.get(),
       this.networkOnlyBlockedRequestsSetting.get(),
       this.networkOnlyThirdPartySetting.get(),
       this.networkHideChromeExtensions.get(),
-      // TODO(crbug.com/425645896): Remove this guard once IP Protection is fully launched.
-      Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled ?
-          this.networkOnlyIPProtectedRequestsSetting.get() :
-          false,
     ];
 
     if (hideDataURL && (request.parsedURL.isDataURL() || request.parsedURL.isBlobURL())) {
@@ -2135,12 +2119,6 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     if (hideExtensionURL && request.scheme === 'chrome-extension') {
       return false;
     }
-    // TODO(crbug.com/425645896): Remove this guard once IP Protection is fully launched.
-    if (Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled) {
-      if (ippRequests && !request.isIpProtectionUsed()) {
-        return false;
-      }
-    }
     for (let i = 0; i < this.filters.length; ++i) {
       if (!this.filters[i](request)) {
         return false;
@@ -2756,7 +2734,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
   private networkShowBlockedCookiesOnlySetting: Common.Settings.Setting<boolean>;
   private networkOnlyBlockedRequestsSetting: Common.Settings.Setting<boolean>;
   private networkOnlyThirdPartySetting: Common.Settings.Setting<boolean>;
-  private networkOnlyIPProtectedRequestsSetting: Common.Settings.Setting<boolean>;
   private activeFiltersCount: HTMLElement;
   private activeFiltersCountAdorner: Adorners.Adorner.Adorner;
 
@@ -2772,8 +2749,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
         Common.Settings.Settings.instance().createSetting('network-only-blocked-requests', false);
     this.networkOnlyThirdPartySetting =
         Common.Settings.Settings.instance().createSetting('network-only-third-party-setting', false);
-    this.networkOnlyIPProtectedRequestsSetting =
-        Common.Settings.Settings.instance().createSetting('network-only-ip-protected-requests', false);
 
     this.filterElement = document.createElement('div');
     this.filterElement.setAttribute('aria-label', 'Show only/hide requests dropdown');
@@ -2810,10 +2785,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
     this.networkShowBlockedCookiesOnlySetting.addChangeListener(this.#onSettingChanged.bind(this));
     this.networkOnlyBlockedRequestsSetting.addChangeListener(this.#onSettingChanged.bind(this));
     this.networkOnlyThirdPartySetting.addChangeListener(this.#onSettingChanged.bind(this));
-    // TODO(crbug.com/425645896): Remove this guard once IP Protection is fully launched.
-    if (Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled) {
-      this.networkOnlyIPProtectedRequestsSetting.addChangeListener(this.#onSettingChanged.bind(this));
-    }
 
     contextMenu.defaultSection().appendCheckboxItem(
         i18nString(UIStrings.hideDataUrls),
@@ -2845,17 +2816,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
           tooltip: i18nString(UIStrings.onlyShowBlockedRequests),
           jslogContext: 'only-blocked-requests',
         });
-    // Disable this filter if in regular browsing, as IP Protection is only available in incognito mode.
-    // TODO(crbug.com/425645896): Remove this guard once IP Protection is fully launched.
-    if (Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled) {
-      contextMenu.defaultSection().appendCheckboxItem(
-          i18nString(UIStrings.ippRequests),
-          () => this.networkOnlyIPProtectedRequestsSetting.set(!this.networkOnlyIPProtectedRequestsSetting.get()), {
-            checked: this.networkOnlyIPProtectedRequestsSetting.get(),
-            tooltip: i18nString(UIStrings.onlyShowIPProtectedRequests),
-            jslogContext: 'only-ip-protected-requests',
-          });
-    }
     contextMenu.defaultSection().appendCheckboxItem(
         i18nString(UIStrings.thirdParty),
         () => this.networkOnlyThirdPartySetting.set(!this.networkOnlyThirdPartySetting.get()), {
@@ -2872,10 +2832,6 @@ export class MoreFiltersDropDownUI extends Common.ObjectWrapper.ObjectWrapper<UI
       ...this.networkShowBlockedCookiesOnlySetting.get() ? [i18nString(UIStrings.hasBlockedCookies)] : [],
       ...this.networkOnlyBlockedRequestsSetting.get() ? [i18nString(UIStrings.blockedRequests)] : [],
       ...this.networkOnlyThirdPartySetting.get() ? [i18nString(UIStrings.thirdParty)] : [],
-      ...Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled &&
-              this.networkOnlyIPProtectedRequestsSetting.get() ?
-          [i18nString(UIStrings.ippRequests)] :
-          [],
     ];
     return filters;
   }

package/front_end/panels/security/SecurityPanel.ts

@@ -17,7 +17,6 @@ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import {CookieControlsView} from './CookieControlsView.js';
 import {CookieReportView} from './CookieReportView.js';
-import {IPProtectionView} from './IPProtectionView.js';
 import lockIconStyles from './lockIcon.css.js';
 import mainViewStyles from './mainView.css.js';
 import {ShowOriginEvent} from './OriginTreeElement.js';
@@ -556,7 +555,6 @@ const DEFAULT_VIEW: View = (input: ViewInput, output: ViewOutput, target: HTMLEl
       <devtools-widget
         slot="sidebar"
         .widgetConfig=${widgetConfig(SecurityPanelSidebar)}
-        @showIPProtection=${() => output.setVisibleView(new IPProtectionView())}
         @showCookieReport=${()=>output.setVisibleView(new CookieReportView())}
         @showFlagControls=${() => output.setVisibleView(new CookieControlsView())}
         ${UI.Widget.widgetRef(SecurityPanelSidebar, e => {output.sidebar = e;})}>

package/front_end/panels/security/SecurityPanelSidebar.ts

@@ -13,7 +13,6 @@ import * as UI from '../../ui/legacy/legacy.js';
 
 import {CookieControlsTreeElement} from './CookieControlsTreeElement.js';
 import {CookieReportTreeElement} from './CookieReportTreeElement.js';
-import {IPProtectionTreeElement} from './IPProtectionTreeElement.js';
 import lockIconStyles from './lockIcon.css.js';
 import {OriginTreeElement} from './OriginTreeElement.js';
 import {
@@ -42,10 +41,6 @@ const UIStrings = {
    * @description Sidebar element text in the Security panel
    */
   flagControls: 'Controls',
-  /**
-   * @description Sidebar element text in the Security panel
-   */
-  ipProtection: 'IP Protection',
   /**
    * @description Text in Security Panel of the Security panel
    */
@@ -83,7 +78,6 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
   securityOverviewElement: OriginTreeElement;
   readonly #cookieControlsTreeElement: CookieControlsTreeElement|undefined;
   readonly cookieReportTreeElement: CookieReportTreeElement|undefined;
-  readonly ipProtectionTreeElement: IPProtectionTreeElement|undefined;
   readonly #elementsByOrigin: Map<string, OriginTreeElement>;
   readonly #mainViewReloadMessage: UI.TreeOutline.TreeElement;
   #mainOrigin: string|null;
@@ -108,11 +102,6 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
       this.cookieReportTreeElement = new CookieReportTreeElement(i18nString(UIStrings.cookieReport), 'cookie-report');
       privacyTreeSection.appendChild(this.cookieReportTreeElement);
 
-      if (Root.Runtime.hostConfig.devToolsIpProtectionPanelInDevTools?.enabled) {
-        this.ipProtectionTreeElement = new IPProtectionTreeElement(i18nString(UIStrings.ipProtection), 'ip-protection');
-        privacyTreeSection.appendChild(this.ipProtectionTreeElement);
-      }
-
       // If this if the first time this setting is set, go to the controls tool
       if (this.#securitySidebarLastItemSetting.get() === '') {
         this.#securitySidebarLastItemSetting.set(this.#cookieControlsTreeElement.elemId);
@@ -192,11 +181,6 @@ export class SecurityPanelSidebar extends UI.Widget.VBox {
         this.#securitySidebarLastItemSetting.get() === this.cookieReportTreeElement.elemId) {
       this.cookieReportTreeElement.select();
       this.cookieReportTreeElement.showElement();
-    } else if (
-        this.ipProtectionTreeElement &&
-        this.#securitySidebarLastItemSetting.get() === this.ipProtectionTreeElement.elemId) {
-      this.ipProtectionTreeElement.select();
-      this.ipProtectionTreeElement.showElement();
     } else {
       this.securityOverviewElement.select();
       this.securityOverviewElement.showElement();

package/front_end/panels/security/security.ts

@@ -4,14 +4,12 @@
 
 import * as CookieControlsView from './CookieControlsView.js';
 import * as CookieReportView from './CookieReportView.js';
-import * as IPProtectionView from './IPProtectionView.js';
 import * as SecurityModel from './SecurityModel.js';
 import * as SecurityPanel from './SecurityPanel.js';
 
 export {
   CookieControlsView,
   CookieReportView,
-  IPProtectionView,
   SecurityModel,
   SecurityPanel,
 };

package/front_end/panels/settings/SettingsScreen.ts

@@ -235,6 +235,7 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
         this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
 
     this.containerElement.classList.add('settings-multicolumn-card-container');
+    this.syncSection.markAsRoot();
 
     // AI, GRID, MOBILE, EMULATION, and RENDERING are intentionally excluded from this list.
     // AI settings are displayed in their own tab.
@@ -316,11 +317,7 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
         new Promise<Host.InspectorFrontendHostAPI.SyncInformation>(
             resolve => Host.InspectorFrontendHost.InspectorFrontendHostInstance.getSyncInformation(resolve))
             .then(syncInfo => {
-              this.syncSection.data = {
-                syncInfo,
-                syncSetting: Common.Settings.moduleSetting('sync-preferences') as Common.Settings.Setting<boolean>,
-                receiveBadgesSetting: Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges'),
-              };
+              this.syncSection.syncInfo = syncInfo;
               if (!syncInfo.isSyncActive || !syncInfo.arePreferencesSynced) {
                 this.#updateSyncSectionTimerId = window.setTimeout(this.updateSyncSection.bind(this), 500);
               }
@@ -342,7 +339,7 @@ export class GenericSettingsTab extends UI.Widget.VBox implements SettingsTab {
     } else if (category === Common.Settings.SettingCategory.ACCOUNT && settings.length > 0) {
       const syncCard = createSettingsCard(
           Common.SettingRegistration.getLocalizedSettingsCategory(Common.SettingRegistration.SettingCategory.ACCOUNT),
-          this.syncSection);
+          this.syncSection.element);
       this.containerElement.appendChild(syncCard);
     } else if (settings.length > 0) {
       this.createStandardSectionElement(category, settings);