chrome-devtools-frontend 1.0.1539972 → 1.0.1541552

package/front_end/{panels/issues → models/issues_manager}/IssueAggregator.ts

@@ -4,7 +4,29 @@
 
 import * as Common from '../../core/common/common.js';
 import type * as Protocol from '../../generated/protocol.js';
-import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
+
+import {AttributionReportingIssue} from './AttributionReportingIssue.js';
+import {ContentSecurityPolicyIssue} from './ContentSecurityPolicyIssue.js';
+import {CookieDeprecationMetadataIssue} from './CookieDeprecationMetadataIssue.js';
+import {CookieIssue} from './CookieIssue.js';
+import {CorsIssue} from './CorsIssue.js';
+import {DeprecationIssue} from './DeprecationIssue.js';
+import {ElementAccessibilityIssue} from './ElementAccessibilityIssue.js';
+import {GenericIssue} from './GenericIssue.js';
+import {HeavyAdIssue} from './HeavyAdIssue.js';
+import {Issue, IssueCategory, IssueKind, unionIssueKind} from './Issue.js';
+import type {EventTypes as IssuesManagerEventsTypes, IssueAddedEvent} from './IssuesManager.js';
+import {Events as IssuesManagerEvents} from './IssuesManagerEvents.js';
+import {LowTextContrastIssue} from './LowTextContrastIssue.js';
+import type {MarkdownIssueDescription} from './MarkdownIssueDescription.js';
+import {MixedContentIssue} from './MixedContentIssue.js';
+import {PartitioningBlobURLIssue} from './PartitioningBlobURLIssue.js';
+import {QuirksModeIssue} from './QuirksModeIssue.js';
+import {SharedArrayBufferIssue} from './SharedArrayBufferIssue.js';
+
+export interface IssuesProvider extends Common.EventTarget.EventTarget<IssuesManagerEventsTypes> {
+  issues(): Iterable<Issue>;
+}
 
 interface AggregationKeyTag {
   aggregationKeyTag: undefined;
@@ -24,7 +46,7 @@ export type AggregationKey = {
  * Currently only grouping by issue code, is supported. The class provides helpers to support displaying
  * of all resources that are affected by the aggregated issues.
  */
-export class AggregatedIssue extends IssuesManager.Issue.Issue {
+export class AggregatedIssue extends Issue {
   #affectedCookies = new Map<string, {
     cookie: Protocol.Audits.AffectedCookie,
     hasRequest: boolean,
@@ -33,24 +55,23 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
   #affectedRequests: Protocol.Audits.AffectedRequest[] = [];
   #affectedRequestIds = new Set<Protocol.Network.RequestId>();
   #affectedLocations = new Map<string, Protocol.Audits.SourceCodeLocation>();
-  #heavyAdIssues = new Set<IssuesManager.HeavyAdIssue.HeavyAdIssue>();
+  #heavyAdIssues = new Set<HeavyAdIssue>();
   #blockedByResponseDetails = new Map<string, Protocol.Audits.BlockedByResponseIssueDetails>();
   #bounceTrackingSites = new Set<string>();
-  #corsIssues = new Set<IssuesManager.CorsIssue.CorsIssue>();
-  #cspIssues = new Set<IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue>();
-  #deprecationIssues = new Set<IssuesManager.DeprecationIssue.DeprecationIssue>();
-  #issueKind = IssuesManager.Issue.IssueKind.IMPROVEMENT;
-  #lowContrastIssues = new Set<IssuesManager.LowTextContrastIssue.LowTextContrastIssue>();
-  #cookieDeprecationMetadataIssues =
-      new Set<IssuesManager.CookieDeprecationMetadataIssue.CookieDeprecationMetadataIssue>();
-  #mixedContentIssues = new Set<IssuesManager.MixedContentIssue.MixedContentIssue>();
-  #partitioningBlobURLIssues = new Set<IssuesManager.PartitioningBlobURLIssue.PartitioningBlobURLIssue>();
-  #sharedArrayBufferIssues = new Set<IssuesManager.SharedArrayBufferIssue.SharedArrayBufferIssue>();
-  #quirksModeIssues = new Set<IssuesManager.QuirksModeIssue.QuirksModeIssue>();
-  #attributionReportingIssues = new Set<IssuesManager.AttributionReportingIssue.AttributionReportingIssue>();
-  #genericIssues = new Set<IssuesManager.GenericIssue.GenericIssue>();
-  #elementAccessibilityIssues = new Set<IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue>();
-  #representative?: IssuesManager.Issue.Issue;
+  #corsIssues = new Set<CorsIssue>();
+  #cspIssues = new Set<ContentSecurityPolicyIssue>();
+  #deprecationIssues = new Set<DeprecationIssue>();
+  #issueKind = IssueKind.IMPROVEMENT;
+  #lowContrastIssues = new Set<LowTextContrastIssue>();
+  #cookieDeprecationMetadataIssues = new Set<CookieDeprecationMetadataIssue>();
+  #mixedContentIssues = new Set<MixedContentIssue>();
+  #partitioningBlobURLIssues = new Set<PartitioningBlobURLIssue>();
+  #sharedArrayBufferIssues = new Set<SharedArrayBufferIssue>();
+  #quirksModeIssues = new Set<QuirksModeIssue>();
+  #attributionReportingIssues = new Set<AttributionReportingIssue>();
+  #genericIssues = new Set<GenericIssue>();
+  #elementAccessibilityIssues = new Set<ElementAccessibilityIssue>();
+  #representative?: Issue;
   #aggregatedIssuesCount = 0;
   #key: AggregationKey;
 
@@ -94,32 +115,31 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
     return this.#affectedCookies.values();
   }
 
-  getHeavyAdIssues(): Iterable<IssuesManager.HeavyAdIssue.HeavyAdIssue> {
+  getHeavyAdIssues(): Iterable<HeavyAdIssue> {
     return this.#heavyAdIssues;
   }
 
-  getCookieDeprecationMetadataIssues():
-      Iterable<IssuesManager.CookieDeprecationMetadataIssue.CookieDeprecationMetadataIssue> {
+  getCookieDeprecationMetadataIssues(): Iterable<CookieDeprecationMetadataIssue> {
     return this.#cookieDeprecationMetadataIssues;
   }
 
-  getMixedContentIssues(): Iterable<IssuesManager.MixedContentIssue.MixedContentIssue> {
+  getMixedContentIssues(): Iterable<MixedContentIssue> {
     return this.#mixedContentIssues;
   }
 
-  getCorsIssues(): Set<IssuesManager.CorsIssue.CorsIssue> {
+  getCorsIssues(): Set<CorsIssue> {
     return this.#corsIssues;
   }
 
-  getCspIssues(): Iterable<IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue> {
+  getCspIssues(): Iterable<ContentSecurityPolicyIssue> {
     return this.#cspIssues;
   }
 
-  getDeprecationIssues(): Iterable<IssuesManager.DeprecationIssue.DeprecationIssue> {
+  getDeprecationIssues(): Iterable<DeprecationIssue> {
     return this.#deprecationIssues;
   }
 
-  getLowContrastIssues(): Iterable<IssuesManager.LowTextContrastIssue.LowTextContrastIssue> {
+  getLowContrastIssues(): Iterable<LowTextContrastIssue> {
     return this.#lowContrastIssues;
   }
 
@@ -127,45 +147,45 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
     return this.#affectedRequests.values();
   }
 
-  getSharedArrayBufferIssues(): Iterable<IssuesManager.SharedArrayBufferIssue.SharedArrayBufferIssue> {
+  getSharedArrayBufferIssues(): Iterable<SharedArrayBufferIssue> {
     return this.#sharedArrayBufferIssues;
   }
 
-  getQuirksModeIssues(): Iterable<IssuesManager.QuirksModeIssue.QuirksModeIssue> {
+  getQuirksModeIssues(): Iterable<QuirksModeIssue> {
     return this.#quirksModeIssues;
   }
 
-  getAttributionReportingIssues(): ReadonlySet<IssuesManager.AttributionReportingIssue.AttributionReportingIssue> {
+  getAttributionReportingIssues(): ReadonlySet<AttributionReportingIssue> {
     return this.#attributionReportingIssues;
   }
 
-  getGenericIssues(): ReadonlySet<IssuesManager.GenericIssue.GenericIssue> {
+  getGenericIssues(): ReadonlySet<GenericIssue> {
     return this.#genericIssues;
   }
 
-  getElementAccessibilityIssues(): Iterable<IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue> {
+  getElementAccessibilityIssues(): Iterable<ElementAccessibilityIssue> {
     return this.#elementAccessibilityIssues;
   }
 
-  getDescription(): IssuesManager.MarkdownIssueDescription.MarkdownIssueDescription|null {
+  getDescription(): MarkdownIssueDescription|null {
     if (this.#representative) {
       return this.#representative.getDescription();
     }
     return null;
   }
 
-  getCategory(): IssuesManager.Issue.IssueCategory {
+  getCategory(): IssueCategory {
     if (this.#representative) {
       return this.#representative.getCategory();
     }
-    return IssuesManager.Issue.IssueCategory.OTHER;
+    return IssueCategory.OTHER;
   }
 
   getAggregatedIssuesCount(): number {
     return this.#aggregatedIssuesCount;
   }
 
-  getPartitioningBlobURLIssues(): Iterable<IssuesManager.PartitioningBlobURLIssue.PartitioningBlobURLIssue> {
+  getPartitioningBlobURLIssues(): Iterable<PartitioningBlobURLIssue> {
     return this.#partitioningBlobURLIssues;
   }
 
@@ -178,12 +198,12 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
     return `${domain};${path};${name}`;
   }
 
-  addInstance(issue: IssuesManager.Issue.Issue): void {
+  addInstance(issue: Issue): void {
     this.#aggregatedIssuesCount++;
     if (!this.#representative) {
       this.#representative = issue;
     }
-    this.#issueKind = IssuesManager.Issue.unionIssueKind(this.#issueKind, issue.getKind());
+    this.#issueKind = unionIssueKind(this.#issueKind, issue.getKind());
     let hasRequest = false;
     for (const request of issue.requests()) {
       const {requestId} = request;
@@ -217,52 +237,52 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
         this.#affectedLocations.set(key, location);
       }
     }
-    if (issue instanceof IssuesManager.CookieDeprecationMetadataIssue.CookieDeprecationMetadataIssue) {
+    if (issue instanceof CookieDeprecationMetadataIssue) {
       this.#cookieDeprecationMetadataIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.MixedContentIssue.MixedContentIssue) {
+    if (issue instanceof MixedContentIssue) {
       this.#mixedContentIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.HeavyAdIssue.HeavyAdIssue) {
+    if (issue instanceof HeavyAdIssue) {
       this.#heavyAdIssues.add(issue);
     }
     for (const details of issue.getBlockedByResponseDetails()) {
       const key = JSON.stringify(details, ['parentFrame', 'blockedFrame', 'requestId', 'frameId', 'reason', 'request']);
       this.#blockedByResponseDetails.set(key, details);
     }
-    if (issue instanceof IssuesManager.ContentSecurityPolicyIssue.ContentSecurityPolicyIssue) {
+    if (issue instanceof ContentSecurityPolicyIssue) {
       this.#cspIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.DeprecationIssue.DeprecationIssue) {
+    if (issue instanceof DeprecationIssue) {
       this.#deprecationIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.SharedArrayBufferIssue.SharedArrayBufferIssue) {
+    if (issue instanceof SharedArrayBufferIssue) {
       this.#sharedArrayBufferIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.LowTextContrastIssue.LowTextContrastIssue) {
+    if (issue instanceof LowTextContrastIssue) {
       this.#lowContrastIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.CorsIssue.CorsIssue) {
+    if (issue instanceof CorsIssue) {
       this.#corsIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.QuirksModeIssue.QuirksModeIssue) {
+    if (issue instanceof QuirksModeIssue) {
       this.#quirksModeIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.AttributionReportingIssue.AttributionReportingIssue) {
+    if (issue instanceof AttributionReportingIssue) {
       this.#attributionReportingIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.GenericIssue.GenericIssue) {
+    if (issue instanceof GenericIssue) {
       this.#genericIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.ElementAccessibilityIssue.ElementAccessibilityIssue) {
+    if (issue instanceof ElementAccessibilityIssue) {
       this.#elementAccessibilityIssues.add(issue);
     }
-    if (issue instanceof IssuesManager.PartitioningBlobURLIssue.PartitioningBlobURLIssue) {
+    if (issue instanceof PartitioningBlobURLIssue) {
       this.#partitioningBlobURLIssues.add(issue);
     }
   }
 
-  getKind(): IssuesManager.Issue.IssueKind {
+  getKind(): IssueKind {
     return this.#issueKind;
   }
 
@@ -278,17 +298,16 @@ export class AggregatedIssue extends IssuesManager.Issue.Issue {
 export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   readonly #aggregatedIssuesByKey = new Map<AggregationKey, AggregatedIssue>();
   readonly #hiddenAggregatedIssuesByKey = new Map<AggregationKey, AggregatedIssue>();
-  constructor(private readonly issuesManager: IssuesManager.IssuesManager.IssuesManager) {
+  constructor(private readonly issuesManager: IssuesProvider) {
     super();
-    this.issuesManager.addEventListener(IssuesManager.IssuesManager.Events.ISSUE_ADDED, this.#onIssueAdded, this);
-    this.issuesManager.addEventListener(
-        IssuesManager.IssuesManager.Events.FULL_UPDATE_REQUIRED, this.#onFullUpdateRequired, this);
+    this.issuesManager.addEventListener(IssuesManagerEvents.ISSUE_ADDED, this.#onIssueAdded, this);
+    this.issuesManager.addEventListener(IssuesManagerEvents.FULL_UPDATE_REQUIRED, this.#onFullUpdateRequired, this);
     for (const issue of this.issuesManager.issues()) {
       this.#aggregateIssue(issue);
     }
   }
 
-  #onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssuesManager.IssuesManager.IssueAddedEvent>): void {
+  #onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssueAddedEvent>): void {
     this.#aggregateIssue(event.data.issue);
   }
 
@@ -301,8 +320,8 @@ export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.dispatchEventToListeners(Events.FULL_UPDATE_REQUIRED);
   }
 
-  #aggregateIssue(issue: IssuesManager.Issue.Issue): AggregatedIssue|undefined {
-    if (IssuesManager.CookieIssue.CookieIssue.isThirdPartyCookiePhaseoutRelatedIssue(issue)) {
+  #aggregateIssue(issue: Issue): AggregatedIssue|undefined {
+    if (CookieIssue.isThirdPartyCookiePhaseoutRelatedIssue(issue)) {
       return;
     }
 
@@ -312,8 +331,7 @@ export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     return aggregatedIssue;
   }
 
-  #aggregateIssueByStatus(aggregatedIssuesMap: Map<AggregationKey, AggregatedIssue>, issue: IssuesManager.Issue.Issue):
-      AggregatedIssue {
+  #aggregateIssueByStatus(aggregatedIssuesMap: Map<AggregationKey, AggregatedIssue>, issue: Issue): AggregatedIssue {
     const key = issue.code() as unknown as AggregationKey;
     let aggregatedIssue = aggregatedIssuesMap.get(key);
     if (!aggregatedIssue) {
@@ -332,16 +350,16 @@ export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     return new Set([...this.#aggregatedIssuesByKey.keys(), ...this.#hiddenAggregatedIssuesByKey.keys()]);
   }
 
-  aggregatedIssueCategories(): Set<IssuesManager.Issue.IssueCategory> {
-    const result = new Set<IssuesManager.Issue.IssueCategory>();
+  aggregatedIssueCategories(): Set<IssueCategory> {
+    const result = new Set<IssueCategory>();
     for (const issue of this.#aggregatedIssuesByKey.values()) {
       result.add(issue.getCategory());
     }
     return result;
   }
 
-  aggregatedIssueKinds(): Set<IssuesManager.Issue.IssueKind> {
-    const result = new Set<IssuesManager.Issue.IssueKind>();
+  aggregatedIssueKinds(): Set<IssueKind> {
+    const result = new Set<IssueKind>();
     for (const issue of this.#aggregatedIssuesByKey.values()) {
       result.add(issue.getKind());
     }
@@ -356,7 +374,7 @@ export class IssueAggregator extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     return this.#hiddenAggregatedIssuesByKey.size;
   }
 
-  keyForIssue(issue: IssuesManager.Issue.Issue<string>): AggregationKey {
+  keyForIssue(issue: Issue<string>): AggregationKey {
     return issue.code() as unknown as AggregationKey;
   }
 }

package/front_end/models/issues_manager/issues_manager.ts

@@ -17,6 +17,7 @@ import * as FederatedAuthUserInfoRequestIssue from './FederatedAuthUserInfoReque
 import * as GenericIssue from './GenericIssue.js';
 import * as HeavyAdIssue from './HeavyAdIssue.js';
 import * as Issue from './Issue.js';
+import * as IssueAggregator from './IssueAggregator.js';
 import * as IssueResolver from './IssueResolver.js';
 import * as IssuesManager from './IssuesManager.js';
 import * as LowTextContrastIssue from './LowTextContrastIssue.js';
@@ -49,6 +50,7 @@ export {
   GenericIssue,
   HeavyAdIssue,
   Issue,
+  IssueAggregator,
   IssueResolver,
   IssuesManager,
   LowTextContrastIssue,

package/front_end/models/trace/Processor.ts

@@ -431,9 +431,13 @@ export class TraceProcessor extends EventTarget {
   #computeInsightSet(data: Handlers.Types.HandlerData, context: Insights.Types.InsightSetContext): void {
     const logger = context.options.logger;
 
+    if (!this.#insights) {
+      this.#insights = new Map();
+    }
+
     let id, urlString, navigation;
     if (context.navigation) {
-      id = context.navigationId;
+      id = `NAVIGATION_${this.#insights.size}`;
       urlString = data.Meta.finalDisplayUrlByNavigationId.get(context.navigationId) ?? data.Meta.mainFrameURL;
       navigation = context.navigation;
     } else {
@@ -503,9 +507,6 @@ export class TraceProcessor extends EventTarget {
       bounds: context.bounds,
       model: insightSetModel,
     };
-    if (!this.#insights) {
-      this.#insights = new Map();
-    }
     this.#insights.set(insightSet.id, insightSet);
     this.sortInsightSet(insightSet, context.options.metadata ?? null);
   }

package/front_end/models/trace/insights/types.ts

@@ -110,7 +110,7 @@ export type PartialInsightModel<T> =
  * navigation (or the end of the trace).
  */
 export interface InsightSet {
-  /** If for a navigation, this is the navigationId. Else it is Trace.Types.Events.NO_NAVIGATION. */
+  /** If for a navigation, this is of the form "NAVIGATION_(index)". Else it is Trace.Types.Events.NO_NAVIGATION. */
   id: Types.Events.NavigationId;
   /** The URL to show in the accordion list. */
   url: URL;

package/front_end/models/trace/types/TraceEvents.ts

@@ -1001,7 +1001,7 @@ export const NO_NAVIGATION = 'NO_NAVIGATION';
  * portion of the trace for which we don't have any navigation event for (as it happeneded prior
  * to the trace start).
  */
-export type NavigationId = string|typeof NO_NAVIGATION;
+export type NavigationId = string;
 
 /**
  * This is a synthetic Layout shift cluster. The rawSourceEvent is the worst layout shift event

package/front_end/models/workspace/IgnoreListManager.ts

@@ -50,51 +50,49 @@ export interface IgnoreListGeneralRules {
 
 export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes> implements
     SDK.TargetManager.SDKModelObserver<SDK.DebuggerModel.DebuggerModel> {
-  readonly #listeners: Set<() => void>;
-  readonly #isIgnoreListedURLCache: Map<string, boolean>;
-  readonly #contentScriptExecutionContexts: Set<string>;
+  readonly #settings: Common.Settings.Settings;
+  readonly #targetManager: SDK.TargetManager.TargetManager;
 
-  private constructor() {
+  readonly #listeners = new Set<() => void>();
+  readonly #isIgnoreListedURLCache = new Map<string, boolean>();
+  readonly #contentScriptExecutionContexts = new Set<string>();
+
+  private constructor(settings: Common.Settings.Settings, targetManager: SDK.TargetManager.TargetManager) {
     super();
+    this.#settings = settings;
+    this.#targetManager = targetManager;
 
-    SDK.TargetManager.TargetManager.instance().addModelListener(
+    this.#targetManager.addModelListener(
         SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared,
         this.clearCacheIfNeeded.bind(this), this);
-    SDK.TargetManager.TargetManager.instance().addModelListener(
+    this.#targetManager.addModelListener(
         SDK.RuntimeModel.RuntimeModel, SDK.RuntimeModel.Events.ExecutionContextCreated, this.onExecutionContextCreated,
         this, {scoped: true});
-    SDK.TargetManager.TargetManager.instance().addModelListener(
+    this.#targetManager.addModelListener(
         SDK.RuntimeModel.RuntimeModel, SDK.RuntimeModel.Events.ExecutionContextDestroyed,
         this.onExecutionContextDestroyed, this, {scoped: true});
-    Common.Settings.Settings.instance()
-        .moduleSetting('skip-stack-frames-pattern')
-        .addChangeListener(this.patternChanged.bind(this));
-    Common.Settings.Settings.instance()
-        .moduleSetting('skip-content-scripts')
-        .addChangeListener(this.patternChanged.bind(this));
-    Common.Settings.Settings.instance()
-        .moduleSetting('automatically-ignore-list-known-third-party-scripts')
-        .addChangeListener(this.patternChanged.bind(this));
-    Common.Settings.Settings.instance()
-        .moduleSetting('enable-ignore-listing')
+    this.#settings.moduleSetting('skip-stack-frames-pattern').addChangeListener(this.patternChanged.bind(this));
+    this.#settings.moduleSetting('skip-content-scripts').addChangeListener(this.patternChanged.bind(this));
+    this.#settings.moduleSetting('automatically-ignore-list-known-third-party-scripts')
         .addChangeListener(this.patternChanged.bind(this));
-    Common.Settings.Settings.instance()
-        .moduleSetting('skip-anonymous-scripts')
-        .addChangeListener(this.patternChanged.bind(this));
-
-    this.#listeners = new Set();
-    this.#isIgnoreListedURLCache = new Map();
-    this.#contentScriptExecutionContexts = new Set();
+    this.#settings.moduleSetting('enable-ignore-listing').addChangeListener(this.patternChanged.bind(this));
+    this.#settings.moduleSetting('skip-anonymous-scripts').addChangeListener(this.patternChanged.bind(this));
 
-    SDK.TargetManager.TargetManager.instance().observeModels(SDK.DebuggerModel.DebuggerModel, this);
+    this.#targetManager.observeModels(SDK.DebuggerModel.DebuggerModel, this);
   }
 
   static instance(opts: {
     forceNew: boolean|null,
-  } = {forceNew: null}): IgnoreListManager {
+    settings?: Common.Settings.Settings,
+    targetManager?: SDK.TargetManager.TargetManager,
+  } = {
+    forceNew: null,
+  }): IgnoreListManager {
     const {forceNew} = opts;
     if (!ignoreListManagerInstance || forceNew) {
-      ignoreListManagerInstance = new IgnoreListManager();
+      ignoreListManagerInstance = new IgnoreListManager(
+          opts.settings ?? Common.Settings.Settings.instance(),
+          opts.targetManager ?? SDK.TargetManager.TargetManager.instance());
     }
 
     return ignoreListManagerInstance;
@@ -135,8 +133,7 @@ export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventT
     if (this.isContentScript(event.data)) {
       this.#contentScriptExecutionContexts.add(event.data.uniqueId);
       if (this.skipContentScripts) {
-        for (const debuggerModel of SDK.TargetManager.TargetManager.instance().models(
-                 SDK.DebuggerModel.DebuggerModel)) {
+        for (const debuggerModel of this.#targetManager.models(SDK.DebuggerModel.DebuggerModel)) {
           void this.updateIgnoredExecutionContexts(debuggerModel);
         }
       }
@@ -148,8 +145,7 @@ export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventT
     if (this.isContentScript(event.data)) {
       this.#contentScriptExecutionContexts.delete(event.data.uniqueId);
       if (this.skipContentScripts) {
-        for (const debuggerModel of SDK.TargetManager.TargetManager.instance().models(
-                 SDK.DebuggerModel.DebuggerModel)) {
+        for (const debuggerModel of this.#targetManager.models(SDK.DebuggerModel.DebuggerModel)) {
           void this.updateIgnoredExecutionContexts(debuggerModel);
         }
       }
@@ -163,8 +159,7 @@ export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventT
   }
 
   private getSkipStackFramesPatternSetting(): Common.Settings.RegExpSetting {
-    return Common.Settings.Settings.instance().moduleSetting('skip-stack-frames-pattern') as
-        Common.Settings.RegExpSetting;
+    return this.#settings.moduleSetting('skip-stack-frames-pattern') as Common.Settings.RegExpSetting;
   }
 
   private setIgnoreListPatterns(debuggerModel: SDK.DebuggerModel.DebuggerModel): Promise<boolean> {
@@ -327,58 +322,57 @@ export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventT
   }
 
   get enableIgnoreListing(): boolean {
-    return Common.Settings.Settings.instance().moduleSetting('enable-ignore-listing').get();
+    return this.#settings.moduleSetting('enable-ignore-listing').get();
   }
 
   set enableIgnoreListing(value: boolean) {
-    Common.Settings.Settings.instance().moduleSetting('enable-ignore-listing').set(value);
+    this.#settings.moduleSetting('enable-ignore-listing').set(value);
   }
 
   get skipContentScripts(): boolean {
-    return this.enableIgnoreListing && Common.Settings.Settings.instance().moduleSetting('skip-content-scripts').get();
+    return this.enableIgnoreListing && this.#settings.moduleSetting('skip-content-scripts').get();
   }
 
   get skipAnonymousScripts(): boolean {
-    return this.enableIgnoreListing &&
-        Common.Settings.Settings.instance().moduleSetting('skip-anonymous-scripts').get();
+    return this.enableIgnoreListing && this.#settings.moduleSetting('skip-anonymous-scripts').get();
   }
 
   get automaticallyIgnoreListKnownThirdPartyScripts(): boolean {
     return this.enableIgnoreListing &&
-        Common.Settings.Settings.instance().moduleSetting('automatically-ignore-list-known-third-party-scripts').get();
+        this.#settings.moduleSetting('automatically-ignore-list-known-third-party-scripts').get();
   }
 
   ignoreListContentScripts(): void {
     if (!this.enableIgnoreListing) {
       this.enableIgnoreListing = true;
     }
-    Common.Settings.Settings.instance().moduleSetting('skip-content-scripts').set(true);
+    this.#settings.moduleSetting('skip-content-scripts').set(true);
   }
 
   unIgnoreListContentScripts(): void {
-    Common.Settings.Settings.instance().moduleSetting('skip-content-scripts').set(false);
+    this.#settings.moduleSetting('skip-content-scripts').set(false);
   }
 
   ignoreListAnonymousScripts(): void {
     if (!this.enableIgnoreListing) {
       this.enableIgnoreListing = true;
     }
-    Common.Settings.Settings.instance().moduleSetting('skip-anonymous-scripts').set(true);
+    this.#settings.moduleSetting('skip-anonymous-scripts').set(true);
   }
 
   unIgnoreListAnonymousScripts(): void {
-    Common.Settings.Settings.instance().moduleSetting('skip-anonymous-scripts').set(false);
+    this.#settings.moduleSetting('skip-anonymous-scripts').set(false);
   }
 
   ignoreListThirdParty(): void {
     if (!this.enableIgnoreListing) {
       this.enableIgnoreListing = true;
     }
-    Common.Settings.Settings.instance().moduleSetting('automatically-ignore-list-known-third-party-scripts').set(true);
+    this.#settings.moduleSetting('automatically-ignore-list-known-third-party-scripts').set(true);
   }
 
   unIgnoreListThirdParty(): void {
-    Common.Settings.Settings.instance().moduleSetting('automatically-ignore-list-known-third-party-scripts').set(false);
+    this.#settings.moduleSetting('automatically-ignore-list-known-third-party-scripts').set(false);
   }
 
   ignoreListURL(url: Platform.DevToolsPath.UrlString): void {
@@ -467,7 +461,7 @@ export class IgnoreListManager extends Common.ObjectWrapper.ObjectWrapper<EventT
     this.#isIgnoreListedURLCache.clear();
 
     const promises: Array<Promise<unknown>> = [];
-    for (const debuggerModel of SDK.TargetManager.TargetManager.instance().models(SDK.DebuggerModel.DebuggerModel)) {
+    for (const debuggerModel of this.#targetManager.models(SDK.DebuggerModel.DebuggerModel)) {
       promises.push(this.setIgnoreListPatterns(debuggerModel));
       const sourceMapManager = debuggerModel.sourceMapManager();
       for (const script of debuggerModel.scripts()) {

package/front_end/models/workspace/workspace-meta.ts

@@ -0,0 +1,40 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as Common from '../../core/common/common.js';
+
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  settingName: 'skip-stack-frames-pattern',
+  settingType: Common.Settings.SettingType.REGEX,
+  defaultValue: '/node_modules/|^node:',
+});
+
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  settingName: 'skip-content-scripts',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+});
+
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  settingName: 'automatically-ignore-list-known-third-party-scripts',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+});
+
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  settingName: 'skip-anonymous-scripts',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: false,
+});
+
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.SYNCED,
+  settingName: 'enable-ignore-listing',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+});

package/front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.ts

@@ -19,7 +19,7 @@ import type * as Lit from '../../../ui/lit/lit.js';
  * ```
  **/
 export class MarkdownRendererWithCodeBlock extends MarkdownView.MarkdownView.MarkdownInsightRenderer {
-  override templateForToken(token: Marked.Marked.MarkedToken): Lit.TemplateResult|null {
+  override templateForToken(token: Marked.Marked.MarkedToken): Lit.LitTemplate|null {
     if (token.type === 'code') {
       const lines = (token.text).split('\n');
       if (lines[0]?.trim() === 'css') {

package/front_end/panels/ai_assistance/components/PerformanceAgentMarkdownRenderer.ts

@@ -21,7 +21,7 @@ export class PerformanceAgentMarkdownRenderer extends MarkdownRendererWithCodeBl
     super();
   }
 
-  override templateForToken(token: Marked.Marked.MarkedToken): Lit.TemplateResult|null {
+  override templateForToken(token: Marked.Marked.MarkedToken): Lit.LitTemplate|null {
     if (token.type === 'link' && token.href.startsWith('#')) {
       if (token.href.startsWith('#node-')) {
         const nodeId = Number(token.href.replace('#node-', '')) as Protocol.DOM.BackendNodeId;