chrome-devtools-frontend 1.0.1538523 → 1.0.1539972

package/front_end/core/sdk/Target.ts

@@ -39,10 +39,8 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
   constructor(
       targetManager: TargetManager, id: Protocol.Target.TargetID|'main', name: string, type: Type,
       parentTarget: Target|null, sessionId: string, suspended: boolean,
-      connection: ProtocolClient.ConnectionTransport.ConnectionTransport|null,
-      targetInfo?: Protocol.Target.TargetInfo) {
-    const needsNodeJSPatching = type === Type.NODE;
-    super(needsNodeJSPatching, parentTarget, sessionId, connection);
+      connection: ProtocolClient.CDPConnection.CDPConnection|null, targetInfo?: Protocol.Target.TargetInfo) {
+    super(parentTarget, sessionId, connection);
     this.#targetManager = targetManager;
     this.#name = name;
     this.#capabilitiesMask = 0;
@@ -151,8 +149,7 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
     return this.#type;
   }
 
-  override markAsNodeJSForTest(): void {
-    super.markAsNodeJSForTest();
+  markAsNodeJSForTest(): void {
     this.#type = Type.NODE;
   }
 

package/front_end/core/sdk/TargetManager.ts

@@ -209,8 +209,7 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
 
   createTarget(
       id: Protocol.Target.TargetID|'main', name: string, type: TargetType, parentTarget: Target|null,
-      sessionId?: string, waitForDebuggerInPage?: boolean,
-      connection?: ProtocolClient.ConnectionTransport.ConnectionTransport,
+      sessionId?: string, waitForDebuggerInPage?: boolean, connection?: ProtocolClient.CDPConnection.CDPConnection,
       targetInfo?: Protocol.Target.TargetInfo): Target {
     const target = new Target(
         this, id, name, type, parentTarget, sessionId || '', this.#isSuspended, connection || null, targetInfo);

package/front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as ProtocolClient from '../../core/protocol_client/protocol_client.js';
 import * as Root from '../../core/root/root.js';
-import type * as SDK from '../../core/sdk/sdk.js';
 import * as PuppeteerService from '../../services/puppeteer/puppeteer.js';
 import * as ThirdPartyWeb from '../../third_party/third-party-web/third-party-web.js';
 
@@ -12,19 +12,12 @@ function disableLoggingForTest(): void {
 }
 
 /**
- * ConnectionProxy is a SDK interface, but the implementation has no knowledge it's a parallelConnection.
- * The CDP traffic is smuggled back and forth by the system described in LighthouseProtocolService
+ * WorkerConnectionTransport is a DevTools `ConnectionTransport` implementation that talks
+ * CDP via web worker postMessage. The system is described in LighthouseProtocolService.
  */
-class ConnectionProxy implements SDK.Connections.ParallelConnectionInterface {
-  sessionId: string;
-  onMessage: ((arg0: Object) => void)|null;
-  onDisconnect: ((arg0: string) => void)|null;
-
-  constructor(sessionId: string) {
-    this.sessionId = sessionId;
-    this.onMessage = null;
-    this.onDisconnect = null;
-  }
+class WorkerConnectionTransport implements ProtocolClient.ConnectionTransport.ConnectionTransport {
+  onMessage: ((arg0: Object) => void)|null = null;
+  onDisconnect: ((arg0: string) => void)|null = null;
 
   setOnMessage(onMessage: (arg0: Object|string) => void): void {
     this.onMessage = onMessage;
@@ -34,14 +27,6 @@ class ConnectionProxy implements SDK.Connections.ParallelConnectionInterface {
     this.onDisconnect = onDisconnect;
   }
 
-  getOnDisconnect(): (((arg0: string) => void)|null) {
-    return this.onDisconnect;
-  }
-
-  getSessionId(): string {
-    return this.sessionId;
-  }
-
   sendRawMessage(message: string): void {
     notifyFrontendViaWorkerMessage('sendProtocolMessage', {message});
   }
@@ -53,7 +38,7 @@ class ConnectionProxy implements SDK.Connections.ParallelConnectionInterface {
   }
 }
 
-let cdpConnection: ConnectionProxy|undefined;
+let cdpTransport: WorkerConnectionTransport|undefined;
 let endTimespan: (() => unknown)|undefined;
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -98,11 +83,13 @@ async function invokeLH(action: string, args: any): Promise<unknown> {
     self.thirdPartyWeb.provideThirdPartyWeb(ThirdPartyWeb.ThirdPartyWeb);
 
     const {rootTargetId, mainSessionId} = args;
-    cdpConnection = new ConnectionProxy(mainSessionId);
+    cdpTransport = new WorkerConnectionTransport();
+    const connection = new ProtocolClient.DevToolsCDPConnection.DevToolsCDPConnection(cdpTransport);
     puppeteerHandle =
         await PuppeteerService.PuppeteerConnection.PuppeteerConnectionHelper.connectPuppeteerToConnectionViaTab({
-          connection: cdpConnection,
-          rootTargetId,
+          connection,
+          targetId: rootTargetId,
+          sessionId: mainSessionId,
           // Lighthouse can only audit normal pages.
           isPageTargetCallback: targetInfo => targetInfo.type === 'page',
         });
@@ -212,7 +199,7 @@ async function onFrontendMessage(event: MessageEvent): Promise<void> {
       break;
     }
     case 'dispatchProtocolMessage': {
-      cdpConnection?.onMessage?.(messageFromFrontend.args.message);
+      cdpTransport?.onMessage?.(messageFromFrontend.args.message);
       break;
     }
     default: {

package/front_end/entrypoints/node_app/{NodeConnectionsPanel.ts → app/NodeConnectionsPanel.ts}

@@ -3,12 +3,12 @@
 // found in the LICENSE file.
 /* eslint-disable @devtools/no-imperative-dom-api */
 
-import type * as Common from '../../core/common/common.js';
-import * as Host from '../../core/host/host.js';
-import * as i18n from '../../core/i18n/i18n.js';
-import * as Buttons from '../../ui/components/buttons/buttons.js';
-import * as uiI18n from '../../ui/i18n/i18n.js';
-import * as UI from '../../ui/legacy/legacy.js';
+import type * as Common from '../../../core/common/common.js';
+import * as Host from '../../../core/host/host.js';
+import * as i18n from '../../../core/i18n/i18n.js';
+import * as Buttons from '../../../ui/components/buttons/buttons.js';
+import * as uiI18n from '../../../ui/i18n/i18n.js';
+import * as UI from '../../../ui/legacy/legacy.js';
 
 import nodeConnectionsPanelStyles from './nodeConnectionsPanel.css.js';
 
@@ -36,10 +36,10 @@ const UIStrings = {
    */
   networkAddressEgLocalhost: 'Network address (e.g. localhost:9229)',
 } as const;
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeConnectionsPanel.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/app/NodeConnectionsPanel.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-const nodejsIconUrl = new URL('../../Images/node-stack-icon.svg', import.meta.url).toString();
+const nodejsIconUrl = new URL('../../../Images/node-stack-icon.svg', import.meta.url).toString();
 
 export class NodeConnectionsPanel extends UI.Panel.Panel {
   #config!: Adb.Config;

package/front_end/entrypoints/node_app/{NodeMain.ts → app/NodeMain.ts}

@@ -2,15 +2,15 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as Common from '../../core/common/common.js';
-import * as Host from '../../core/host/host.js';
-import * as i18n from '../../core/i18n/i18n.js';
-import type * as Platform from '../../core/platform/platform.js';
-import type * as ProtocolClient from '../../core/protocol_client/protocol_client.js';
-import * as SDK from '../../core/sdk/sdk.js';
-import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
-import type * as Protocol from '../../generated/protocol.js';
-import * as Components from '../../ui/legacy/components/utils/utils.js';
+import type * as Common from '../../../core/common/common.js';
+import * as Host from '../../../core/host/host.js';
+import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
+import * as ProtocolClient from '../../../core/protocol_client/protocol_client.js';
+import * as SDK from '../../../core/sdk/sdk.js';
+import type * as ProtocolProxyApi from '../../../generated/protocol-proxy-api.js';
+import type * as Protocol from '../../../generated/protocol.js';
+import * as Components from '../../../ui/legacy/components/utils/utils.js';
 
 const UIStrings = {
   /**
@@ -28,7 +28,7 @@ const UIStrings = {
    */
   NodejsTitleS: 'DevTools - Node.js: {PH1}',
 } as const;
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeMain.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/app/NodeMain.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let nodeMainImplInstance: NodeMainImpl;
 
@@ -119,7 +119,8 @@ export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implemen
       const connection = new NodeConnection(this.#targetAgent, sessionId);
       this.#childConnections.set(sessionId, connection);
       target = this.#targetManager.createTarget(
-          targetInfo.targetId, name, SDK.Target.Type.NODE, this.#parentTarget, undefined, undefined, connection);
+          targetInfo.targetId, name, SDK.Target.Type.NODE, null, undefined, undefined,
+          new ProtocolClient.DevToolsCDPConnection.DevToolsCDPConnection(connection));
     }
     this.#childTargets.set(sessionId, target);
     void target.runtimeAgent().invoke_runIfWaitingForDebugger();

package/front_end/entrypoints/node_app/app/app.ts

@@ -0,0 +1,6 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+export * as NodeConnectionsPanel from './NodeConnectionsPanel.js';
+export * as NodeMain from './NodeMain.js';

package/front_end/entrypoints/node_app/node_app.ts

@@ -13,8 +13,10 @@ import type * as Sources from '../../panels/sources/sources.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Main from '../main/main.js';
 
-import {NodeConnectionsPanel} from './NodeConnectionsPanel.js';  // eslint-disable-line @devtools/es-modules-import
-import {NodeMainImpl} from './NodeMain.js';                      // eslint-disable-line @devtools/es-modules-import
+import * as App from './app/app.js';
+
+const {NodeConnectionsPanel} = App.NodeConnectionsPanel;
+const {NodeMainImpl} = App.NodeMain;
 
 const UIStrings = {
   /**

package/front_end/generated/Deprecation.ts

@@ -230,6 +230,10 @@ export const UIStrings = {
    * @description Warning displayed to developers. It is shown when the `XMLHttpRequest` API is used in a way that it slows down the page load of the next page. The `main thread` refers to an operating systems thread used to run most of the processing of HTML documents, so please use a consistent wording.
    */
   XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload: "Synchronous `XMLHttpRequest` on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.",
+  /**
+   * @description Warning displayed to developers that they are using either the XSLTProcessor API, or XSLT processing instructions, both of which have been deprecated and are scheduled to be removed.
+   */
+  XSLT: "XSLTProcessor and XSLT Processing Instructions have been deprecated by all browsers. These features will be removed from this browser soon.",
 } as const;
 
 export interface DeprecationDescriptor {
@@ -350,5 +354,9 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
   },
   "XHRJSONEncodingDetection": {
     "milestone": 93
+  },
+  "XSLT": {
+    "chromeStatusFeature": 4709671889534976,
+    "milestone": 143
   }
 };

package/front_end/generated/{InspectorBackendCommands.js → InspectorBackendCommands.ts}

@@ -3,41 +3,23 @@
 // found in the LICENSE file.
 // File is generated by scripts/build/code_generator_frontend.py
 
-/**
- * @typedef {{
- *  registerCommand: function(
- *      string&any,
- *      !Array.<!{
- *          name: string,
- *          type: string,
- *          optional: boolean,
- *          description: string,
- *          typeRef: string | null
- *      }>,
- *      !Array.<string>,
- *      string
- *  ): void,
- *  registerEnum: function(string&any, !Object<string, string>): void,
- *  registerEvent: function(string&any, !Array<string>): void,
- *  registerType: function(
- *      string&any,
- *      !Array.<!{
- *          name: string,
- *          type: string,
- *          optional: boolean,
- *          description: string,
- *          typeRef: string | null
- *      }>
- *  ): void,
- * }}
- */
-// @ts-expect-error typedef
-export let InspectorBackendAPI;
 
-/**
- * @param {!InspectorBackendAPI} inspectorBackend
- */
-export function registerCommands(inspectorBackend) {
+export interface CommandParameter {
+  name: string;
+  type: string;
+  optional: boolean;
+  description: string;
+  typeRef: string|null;
+}
+
+export interface InspectorBackendAPI {
+  registerCommand(command: string, parameters: CommandParameter[], replayArgs: string[], description: string): void;
+  registerEnum(type: string, values: Record<string, string>): void;
+  registerEvent(event: string, params: string[]): void;
+  registerType(type: string, parameters: CommandParameter[]): void;
+}
+
+export function registerCommands(inspectorBackend: InspectorBackendAPI): void {
 
 
 // Accessibility.
@@ -354,7 +336,7 @@ inspectorBackend.registerCommand("Cast.stopCasting", [{"name": "sinkName", "type
 inspectorBackend.registerType("Cast.Sink", [{"name": "name", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "id", "type": "string", "optional": false, "description": "", "typeRef": null}, {"name": "session", "type": "string", "optional": true, "description": "Text describing the current session. Present only if there is an active session on the sink.", "typeRef": null}]);
 
 // DOM.
-inspectorBackend.registerEnum("DOM.PseudoType", {FirstLine: "first-line", FirstLetter: "first-letter", Checkmark: "checkmark", Before: "before", After: "after", PickerIcon: "picker-icon", InterestHint: "interest-hint", Marker: "marker", Backdrop: "backdrop", Column: "column", Selection: "selection", SearchText: "search-text", TargetText: "target-text", SpellingError: "spelling-error", GrammarError: "grammar-error", Highlight: "highlight", FirstLineInherited: "first-line-inherited", ScrollMarker: "scroll-marker", ScrollMarkerGroup: "scroll-marker-group", ScrollButton: "scroll-button", Scrollbar: "scrollbar", ScrollbarThumb: "scrollbar-thumb", ScrollbarButton: "scrollbar-button", ScrollbarTrack: "scrollbar-track", ScrollbarTrackPiece: "scrollbar-track-piece", ScrollbarCorner: "scrollbar-corner", Resizer: "resizer", InputListButton: "input-list-button", ViewTransition: "view-transition", ViewTransitionGroup: "view-transition-group", ViewTransitionImagePair: "view-transition-image-pair", ViewTransitionGroupChildren: "view-transition-group-children", ViewTransitionOld: "view-transition-old", ViewTransitionNew: "view-transition-new", Placeholder: "placeholder", FileSelectorButton: "file-selector-button", DetailsContent: "details-content", Picker: "picker", PermissionIcon: "permission-icon"});
+inspectorBackend.registerEnum("DOM.PseudoType", {FirstLine: "first-line", FirstLetter: "first-letter", Checkmark: "checkmark", Before: "before", After: "after", PickerIcon: "picker-icon", InterestHint: "interest-hint", Marker: "marker", Backdrop: "backdrop", Column: "column", Selection: "selection", SearchText: "search-text", TargetText: "target-text", SpellingError: "spelling-error", GrammarError: "grammar-error", Highlight: "highlight", FirstLineInherited: "first-line-inherited", ScrollMarker: "scroll-marker", ScrollMarkerGroup: "scroll-marker-group", ScrollButton: "scroll-button", Scrollbar: "scrollbar", ScrollbarThumb: "scrollbar-thumb", ScrollbarButton: "scrollbar-button", ScrollbarTrack: "scrollbar-track", ScrollbarTrackPiece: "scrollbar-track-piece", ScrollbarCorner: "scrollbar-corner", Resizer: "resizer", InputListButton: "input-list-button", ViewTransition: "view-transition", ViewTransitionGroup: "view-transition-group", ViewTransitionImagePair: "view-transition-image-pair", ViewTransitionGroupChildren: "view-transition-group-children", ViewTransitionOld: "view-transition-old", ViewTransitionNew: "view-transition-new", Placeholder: "placeholder", FileSelectorButton: "file-selector-button", DetailsContent: "details-content", Picker: "picker", PermissionIcon: "permission-icon", OverscrollAreaParent: "overscroll-area-parent", OverscrollClientArea: "overscroll-client-area"});
 inspectorBackend.registerEnum("DOM.ShadowRootType", {UserAgent: "user-agent", Open: "open", Closed: "closed"});
 inspectorBackend.registerEnum("DOM.CompatibilityMode", {QuirksMode: "QuirksMode", LimitedQuirksMode: "LimitedQuirksMode", NoQuirksMode: "NoQuirksMode"});
 inspectorBackend.registerEnum("DOM.PhysicalAxes", {Horizontal: "Horizontal", Vertical: "Vertical", Both: "Both"});
@@ -795,7 +777,7 @@ inspectorBackend.registerEnum("Network.InterceptionStage", {Request: "Request",
 inspectorBackend.registerEnum("Network.SignedExchangeErrorField", {SignatureSig: "signatureSig", SignatureIntegrity: "signatureIntegrity", SignatureCertUrl: "signatureCertUrl", SignatureCertSha256: "signatureCertSha256", SignatureValidityUrl: "signatureValidityUrl", SignatureTimestamps: "signatureTimestamps"});
 inspectorBackend.registerEnum("Network.ContentEncoding", {Deflate: "deflate", Gzip: "gzip", Br: "br", Zstd: "zstd"});
 inspectorBackend.registerEnum("Network.DirectSocketDnsQueryType", {Ipv4: "ipv4", Ipv6: "ipv6"});
-inspectorBackend.registerEnum("Network.PrivateNetworkRequestPolicy", {Allow: "Allow", BlockFromInsecureToMorePrivate: "BlockFromInsecureToMorePrivate", WarnFromInsecureToMorePrivate: "WarnFromInsecureToMorePrivate", PreflightBlock: "PreflightBlock", PreflightWarn: "PreflightWarn", PermissionBlock: "PermissionBlock", PermissionWarn: "PermissionWarn"});
+inspectorBackend.registerEnum("Network.PrivateNetworkRequestPolicy", {Allow: "Allow", BlockFromInsecureToMorePrivate: "BlockFromInsecureToMorePrivate", WarnFromInsecureToMorePrivate: "WarnFromInsecureToMorePrivate", PermissionBlock: "PermissionBlock", PermissionWarn: "PermissionWarn"});
 inspectorBackend.registerEnum("Network.IPAddressSpace", {Loopback: "Loopback", Local: "Local", Public: "Public", Unknown: "Unknown"});
 inspectorBackend.registerEnum("Network.CrossOriginOpenerPolicyValue", {SameOrigin: "SameOrigin", SameOriginAllowPopups: "SameOriginAllowPopups", RestrictProperties: "RestrictProperties", UnsafeNone: "UnsafeNone", SameOriginPlusCoep: "SameOriginPlusCoep", RestrictPropertiesPlusCoep: "RestrictPropertiesPlusCoep", NoopenerAllowPopups: "NoopenerAllowPopups"});
 inspectorBackend.registerEnum("Network.CrossOriginEmbedderPolicyValue", {None: "None", Credentialless: "Credentialless", RequireCorp: "RequireCorp"});

package/front_end/generated/SupportedCSSProperties.js

@@ -419,7 +419,10 @@ export const generatedProperties = [
    "column-height",
    "column-rule-break",
    "column-rule-color",
-   "column-rule-outset",
+   "column-rule-edge-end-outset",
+   "column-rule-edge-start-outset",
+   "column-rule-interior-end-outset",
+   "column-rule-interior-start-outset",
    "column-rule-style",
    "column-rule-visibility-items",
    "column-rule-width",
@@ -639,7 +642,10 @@ export const generatedProperties = [
    "row-gap",
    "row-rule-break",
    "row-rule-color",
-   "row-rule-outset",
+   "row-rule-edge-end-outset",
+   "row-rule-edge-start-outset",
+   "row-rule-interior-end-outset",
+   "row-rule-interior-start-outset",
    "row-rule-style",
    "row-rule-visibility-items",
    "row-rule-width",
@@ -1723,6 +1729,27 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "name": "column-rule-edge-end-outset"
+ },
+ {
+  "inherited": false,
+  "name": "column-rule-edge-start-outset"
+ },
+ {
+  "inherited": false,
+  "name": "column-rule-interior-end-outset"
+ },
+ {
+  "inherited": false,
+  "name": "column-rule-interior-start-outset"
+ },
+ {
+  "longhands": [
+   "column-rule-edge-start-outset",
+   "column-rule-edge-end-outset",
+   "column-rule-interior-start-outset",
+   "column-rule-interior-end-outset"
+  ],
   "name": "column-rule-outset"
  },
  {
@@ -3711,6 +3738,27 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
+  "name": "row-rule-edge-end-outset"
+ },
+ {
+  "inherited": false,
+  "name": "row-rule-edge-start-outset"
+ },
+ {
+  "inherited": false,
+  "name": "row-rule-interior-end-outset"
+ },
+ {
+  "inherited": false,
+  "name": "row-rule-interior-start-outset"
+ },
+ {
+  "longhands": [
+   "row-rule-edge-start-outset",
+   "row-rule-edge-end-outset",
+   "row-rule-interior-start-outset",
+   "row-rule-interior-end-outset"
+  ],
   "name": "row-rule-outset"
  },
  {
@@ -3797,13 +3845,6 @@ export const generatedProperties = [
   ],
   "name": "rule-color"
  },
- {
-  "longhands": [
-   "row-rule-outset",
-   "column-rule-outset"
-  ],
-  "name": "rule-outset"
- },
  {
   "longhands": [
    "column-rule-style",

package/front_end/generated/protocol.ts

@@ -4440,6 +4440,8 @@ export namespace DOM {
     DetailsContent = 'details-content',
     Picker = 'picker',
     PermissionIcon = 'permission-icon',
+    OverscrollAreaParent = 'overscroll-area-parent',
+    OverscrollClientArea = 'overscroll-client-area',
   }
 
   /**
@@ -11124,8 +11126,6 @@ export namespace Network {
     Allow = 'Allow',
     BlockFromInsecureToMorePrivate = 'BlockFromInsecureToMorePrivate',
     WarnFromInsecureToMorePrivate = 'WarnFromInsecureToMorePrivate',
-    PreflightBlock = 'PreflightBlock',
-    PreflightWarn = 'PreflightWarn',
     PermissionBlock = 'PermissionBlock',
     PermissionWarn = 'PermissionWarn',
   }

package/front_end/models/ai_assistance/EvaluateAction.ts

@@ -5,16 +5,25 @@
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 
+import {PAGE_EXPOSED_FUNCTIONS} from './injected.js';
+
 export function formatError(message: string): string {
   return `Error: ${message}`;
 }
 export class SideEffectError extends Error {}
 
+export interface GetErrorStackOutput {
+  message: string;
+  stack?: string;
+}
+
+/* istanbul ignore next */
+export function getErrorStackOnThePage(this: Error): GetErrorStackOutput {
+  return {stack: this.stack, message: this.message};
+}
+
 /* istanbul ignore next */
 export function stringifyObjectOnThePage(this: unknown): string {
-  if (this instanceof Error) {
-    return `Error: ${this.message}`;
-  }
   const seenBefore = new WeakMap();
   return JSON.stringify(this, function replacer(this: unknown, key: string, value: unknown) {
     if (typeof value === 'object' && value !== null) {
@@ -44,7 +53,8 @@ export function stringifyObjectOnThePage(this: unknown): string {
   });
 }
 
-export async function stringifyRemoteObject(object: SDK.RemoteObject.RemoteObject): Promise<string> {
+export async function stringifyRemoteObject(
+    object: SDK.RemoteObject.RemoteObject, functionDeclaration: string): Promise<string> {
   switch (object.type) {
     case Protocol.Runtime.RemoteObjectType.String:
       return `'${object.value}'`;
@@ -59,7 +69,17 @@ export async function stringifyRemoteObject(object: SDK.RemoteObject.RemoteObjec
     case Protocol.Runtime.RemoteObjectType.Function:
       return `${object.description}`;
     case Protocol.Runtime.RemoteObjectType.Object: {
+      if (object.subtype === 'error') {
+        const res = await object.callFunctionJSON(getErrorStackOnThePage, []);
+
+        if (!res) {
+          throw new Error('Could not stringify the object' + object);
+        }
+
+        return EvaluateAction.stringifyError(res, functionDeclaration);
+      }
       const res = await object.callFunction(stringifyObjectOnThePage);
+
       if (!res.object || res.object.type !== Protocol.Runtime.RemoteObjectType.String) {
         throw new Error('Could not stringify the object' + object);
       }
@@ -110,9 +130,72 @@ export class EvaluateAction {
         return formatError(exceptionDescription ?? 'JS exception');
       }
 
-      return await stringifyRemoteObject(response.object);
+      return await stringifyRemoteObject(response.object, functionDeclaration);
     } finally {
       executionContext.runtimeModel.releaseEvaluationResult(response);
     }
   }
+
+  static getExecutedLineFromStack(stack: string, pageExposedFunctions: string[]): number|null {
+    const lines = stack.split('\n');
+
+    const stackLines = lines.map(curr => curr.trim()).filter(trimmedLine => {
+      return trimmedLine.startsWith('at');
+    });
+
+    const selectedStack = stackLines.find(stackLine => {
+      const splittedStackLine = stackLine.split(' ');
+
+      if (splittedStackLine.length < 2) {
+        return false;
+      }
+
+      const signature = splittedStackLine[1] === 'async' ?
+          splittedStackLine[2] :  // if the stack line contains async the function name is the next element
+          splittedStackLine[1];
+
+      const lastDotIndex = signature.lastIndexOf('.');
+      const functionName = lastDotIndex !== -1 ? signature.substring(lastDotIndex + 1) : signature;
+
+      return !pageExposedFunctions.includes(functionName);
+    });
+
+    if (!selectedStack) {
+      return null;
+    }
+
+    const frameLocationRegex = /:(\d+)(?::\d+)?\)?$/;
+    const match = selectedStack.match(frameLocationRegex);
+
+    if (!match?.[1]) {
+      return null;
+    }
+
+    const lineNum = parseInt(match[1], 10);
+    if (isNaN(lineNum)) {
+      return null;
+    }
+
+    return lineNum - 1;
+  }
+
+  static stringifyError(result: GetErrorStackOutput, functionDeclaration: string): string {
+    if (!result.stack) {
+      return `Error: ${result.message}`;
+    }
+
+    const lineNum = EvaluateAction.getExecutedLineFromStack(result.stack, PAGE_EXPOSED_FUNCTIONS);
+    if (!lineNum) {
+      return `Error: ${result.message}`;
+    }
+
+    const functionLines = functionDeclaration.split('\n');
+
+    const errorLine = functionLines[lineNum];
+    if (!errorLine) {
+      return `Error: ${result.message}`;
+    }
+
+    return `Error: executing the line "${errorLine.trim()}" failed with the following error:\n${result.message}`;
+  }
 }

package/front_end/models/ai_assistance/injected.ts

@@ -24,6 +24,7 @@ export interface FreestyleCallbackArgs {
   className: `${typeof AI_ASSISTANCE_CSS_CLASS_NAME}-${number}`;
   styles: Record<string, string>;
   element: Node;
+  error: Error;
 }
 
 interface FreestyleCallbackData {
@@ -31,6 +32,7 @@ interface FreestyleCallbackData {
   element: Node;
   resolve(value: string): void;
   reject(err?: Error): void;
+  error: Error;
 }
 interface FreestylerBinding {
   (args: FreestyleCallbackArgs): Promise<string>;
@@ -58,6 +60,7 @@ function freestylerBindingFunc(bindingName: string): void {
         element: args.element,
         resolve,
         reject,
+        error: args.error,
       });
       // @ts-expect-error this is binding added though CDP
       globalThis[bindingName](String(freestyler.id));
@@ -72,11 +75,16 @@ function freestylerBindingFunc(bindingName: string): void {
     freestyler.getArgs = (callbackId: number) => {
       return freestyler.callbacks.get(callbackId)?.args;
     };
-    freestyler.respond = (callbackId: number, styleChangesOrError: string) => {
+    freestyler.respond = (callbackId: number, styleChangesOrError: string|Error) => {
       if (typeof styleChangesOrError === 'string') {
         freestyler.callbacks.get(callbackId)?.resolve(styleChangesOrError);
       } else {
-        freestyler.callbacks.get(callbackId)?.reject(styleChangesOrError);
+        const callback = freestyler.callbacks.get(callbackId);
+
+        if (callback) {
+          callback.error.message = styleChangesOrError.message;
+          callback.reject(callback?.error);
+        }
       }
 
       freestyler.callbacks.delete(callbackId);
@@ -87,6 +95,8 @@ function freestylerBindingFunc(bindingName: string): void {
 
 export const freestylerBinding = `(${String(freestylerBindingFunc)})('${FREESTYLER_BINDING_NAME}')`;
 
+export const PAGE_EXPOSED_FUNCTIONS = ['setElementStyles'];
+
 /**
  * Please see fileoverview
  */
@@ -134,12 +144,15 @@ function setupSetElementStyles(prefix: typeof AI_ASSISTANCE_CSS_CLASS_NAME): voi
       el.style[key] = '';
     }
 
+    const bindingError = new Error();
+
     const result = await global.freestyler({
       method: 'setElementStyles',
       selector,
       className,
       styles,
       element: el,
+      error: bindingError,
     });
 
     const rootNode = el.getRootNode();

package/front_end/models/live-metrics/web-vitals-injected/README.md

@@ -2,4 +2,4 @@
 
 [`web-vitals`](https://github.com/GoogleChrome/web-vitals-extension) is a Google-maintained library that measures CWV metrics using their canonical definition. We use it to ensure we are using consistent implementations for measuring CWV across Google. It can also measure performance metrics of the current page *after* the they happen (See [`PerformanceObserver` buffered setting](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/observe#buffered)). See [go/cpq:rpp-metric-observations](http://go/cpq:rpp-metric-observations) for more information.
 
-The web-vitals library needs to be run in the target page (although it can be used in an isolated execution context). We therefore need to create a JS binary that can be injected via `Page.evaluate`/`Page.addScriptToEvaluateOnNewDocument`. See `BUILD.gn` and `rollup.config.js` for how we bundle the JS binary.
+The web-vitals library needs to be run in the target page (although it can be used in an isolated execution context). We therefore need to create a JS binary that can be injected via `Page.evaluate`/`Page.addScriptToEvaluateOnNewDocument`. See `BUILD.gn` and `rollup.config.mjs` for how we bundle the JS binary.

package/front_end/models/trace/Styles.ts

@@ -432,7 +432,7 @@ const UIStrings = {
   /**
    * @description Event category in the Performance panel for time spent to perform Garbage Collection for C++: https://chromium.googlesource.com/v8/v8/+/main/include/cppgc/README.md
    */
-  cppGc: 'CPP GC',
+  cppGc: 'C++ GC',
   /**
    * @description Event category in the Performance panel for time spent to perform encryption
    */