chrome-devtools-frontend 1.0.1536371 → 1.0.1537860

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -7971,7 +7971,7 @@ export const NativeFunctions = [
   },
   {
     name: "createContext",
-    signatures: [["?options"],["gpuDevice"]]
+    signatures: [["?options"]]
   },
   {
     name: "MLGraphBuilder",

package/front_end/models/trace/types/File.ts

@@ -219,6 +219,8 @@ export interface MetaData {
   cruxFieldData?: CrUXManager.PageResult[];
   /** Currently only stores JS maps, not CSS. This never stores data url source maps. */
   sourceMaps?: MetadataSourceMap[];
+  /** Currently only stores HTML and CSS resources. */
+  resources?: MetadataResource[];
   visualTrackConfig?: PersistedTraceVisualConfig;
   hostDPR?: number;
 }
@@ -230,6 +232,13 @@ export interface MetadataSourceMap {
   sourceMap: SDK.SourceMap.SourceMapV3;
 }
 
+export interface MetadataResource {
+  url: string;
+  frame: string;
+  content: string;
+  mimeType: string;
+}
+
 export type Contents = TraceFile|Event[];
 
 export function traceEventKeyToValues(key: SerializableKey): SerializableKeyValues {

package/front_end/models/trace_source_maps_resolver/SourceMapsResolver.ts

@@ -173,7 +173,7 @@ export class SourceMapsResolver extends EventTarget {
           const resolvedFunctionName =
               await SourceMapScopes.NamesResolver.resolveProfileFrameFunctionName(node.callFrame, target);
           updatedMappings ||= Boolean(resolvedFunctionName);
-          node.setFunctionName(resolvedFunctionName);
+          node.setOriginalFunctionName(resolvedFunctionName);
 
           const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel);
           const script = debuggerModel?.scriptForId(node.scriptId) || null;

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -531,13 +531,9 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   #getChatUiState(): ChatViewState {
     const blockedByAge = Root.Runtime.hostConfig.aidaAvailability?.blockedByAge === true;
 
-    // Special case due to the way its handled downstream quirks
-    if (this.#aidaAvailability !== Host.AidaClient.AidaAccessPreconditions.AVAILABLE) {
-      return ChatViewState.CHAT_VIEW;
-    }
-
-    if (!this.#aiAssistanceEnabledSetting?.getIfNotDisabled() || blockedByAge) {
-      return ChatViewState.CONSENT_VIEW;
+    if (this.#aidaAvailability !== Host.AidaClient.AidaAccessPreconditions.AVAILABLE ||
+        !this.#aiAssistanceEnabledSetting?.getIfNotDisabled() || blockedByAge) {
+      return ChatViewState.DISABLED_VIEW;
     }
 
     if (this.#conversation?.type) {
@@ -986,7 +982,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
   #getChatInputPlaceholder(): Platform.UIString.LocalizedString {
     const state = this.#getChatUiState();
-    if (state === ChatViewState.CONSENT_VIEW || !this.#conversation) {
+    if (state === ChatViewState.DISABLED_VIEW || !this.#conversation) {
       return i18nString(UIStrings.followTheSteps);
     }
 
@@ -1019,7 +1015,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
   #getDisclaimerText(): Platform.UIString.LocalizedString {
     const state = this.#getChatUiState();
-    if (state === ChatViewState.CONSENT_VIEW || !this.#conversation || this.#conversation.isReadOnly) {
+    if (state === ChatViewState.DISABLED_VIEW || !this.#conversation || this.#conversation.isReadOnly) {
       return i18nString(UIStrings.inputDisclaimerForEmptyState);
     }
 

package/front_end/panels/ai_assistance/components/ChatView.ts

@@ -204,10 +204,6 @@ const UIStringsNotTranslate = {
    * @description Title for the add image button.
    */
   addImageButtonTitle: 'Add image',
-  /**
-   * @description Disclaimer text right after the chat input.
-   */
-  inputDisclaimerForEmptyState: 'This is an experimental AI feature and won\'t always get it right.',
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('panels/ai_assistance/components/ChatView.ts', UIStrings);
@@ -264,7 +260,7 @@ export interface ModelChatMessage {
 export type ChatMessage = UserChatMessage|ModelChatMessage;
 
 export const enum State {
-  CONSENT_VIEW = 'consent-view',
+  DISABLED_VIEW = 'disabled-view',
   CHAT_VIEW = 'chat-view',
   EXPLORE_VIEW = 'explore-view'
 }
@@ -517,6 +513,10 @@ export class ChatView extends HTMLElement {
 
   #render(): void {
     const renderFooter = (): Lit.LitTemplate => {
+      if (this.#props.state !== State.CHAT_VIEW) {
+        return Lit.nothing;
+      }
+
       const classes = Lit.Directives.classMap({
         'chat-view-footer': true,
         'has-conversation': !!this.#props.conversationType,
@@ -524,35 +524,58 @@ export class ChatView extends HTMLElement {
       });
 
       // clang-format off
-      const footerContents = this.#props.conversationType
-        ? renderRelevantDataDisclaimer({
-          isLoading: this.#props.isLoading,
-          blockedByCrossOrigin: this.#props.blockedByCrossOrigin,
-          tooltipId: RELEVANT_DATA_LINK_FOOTER_ID,
-          disclaimerText: this.#props.disclaimerText,
-        })
-        : html`<p>
-            ${lockedString(UIStringsNotTranslate.inputDisclaimerForEmptyState)}
-            <button
-              class="link"
-              role="link"
-              jslog=${VisualLogging.link('open-ai-settings').track({
-                click: true,
-              })}
-              @click=${() => {
-                void UI.ViewManager.ViewManager.instance().showView(
-                  'chrome-ai',
-                );
-              }}
-            >${i18nString(UIStrings.learnAbout)}</button>
-          </p>`;
-
       return html`
         <footer class=${classes} jslog=${VisualLogging.section('footer')}>
-          ${footerContents}
+          ${renderRelevantDataDisclaimer({
+            isLoading: this.#props.isLoading,
+            blockedByCrossOrigin: this.#props.blockedByCrossOrigin,
+            tooltipId: RELEVANT_DATA_LINK_FOOTER_ID,
+            disclaimerText: this.#props.disclaimerText
+          })}
         </footer>
       `;
+      // clang-format on
     };
+
+    const renderInputOrReadOnlySection = (): Lit.LitTemplate => {
+      if (this.#props.state !== State.CHAT_VIEW) {
+        return Lit.nothing;
+      }
+
+      if (this.#props.conversationType && this.#props.isReadOnly) {
+        return renderReadOnlySection({
+          conversationType: this.#props.conversationType,
+          onNewConversation: this.#props.onNewConversation,
+        });
+      }
+
+      return renderChatInput({
+        isLoading: this.#props.isLoading,
+        blockedByCrossOrigin: this.#props.blockedByCrossOrigin,
+        isTextInputDisabled: this.#props.isTextInputDisabled,
+        inputPlaceholder: this.#props.inputPlaceholder,
+        disclaimerText: this.#props.disclaimerText,
+        selectedContext: this.#props.selectedContext,
+        inspectElementToggled: this.#props.inspectElementToggled,
+        multimodalInputEnabled: this.#props.multimodalInputEnabled,
+        conversationType: this.#props.conversationType,
+        imageInput: this.#props.imageInput,
+        aidaAvailability: this.#props.aidaAvailability,
+        isTextInputEmpty: this.#props.isTextInputEmpty,
+        uploadImageInputEnabled: this.#props.uploadImageInputEnabled,
+        onContextClick: this.#props.onContextClick,
+        onInspectElementClick: this.#props.onInspectElementClick,
+        onSubmit: this.#handleSubmit,
+        onTextAreaKeyDown: this.#handleTextAreaKeyDown,
+        onCancel: this.#handleCancel,
+        onNewConversation: this.#props.onNewConversation,
+        onTakeScreenshot: this.#props.onTakeScreenshot,
+        onRemoveImageInput: this.#props.onRemoveImageInput,
+        onTextInputChange: this.#props.onTextInputChange,
+        onImageUpload: this.#handleImageUpload
+      });
+    };
+
     // clang-format off
     Lit.render(html`
       <style>${chatViewStyles}</style>
@@ -577,38 +600,7 @@ export class ChatView extends HTMLElement {
             onMessageContainerRef: this.#handleMessageContainerRef,
             onCopyResponseClick: this.#props.onCopyResponseClick,
           })}
-          ${this.#props.isReadOnly
-            ? renderReadOnlySection({
-                conversationType: this.#props.conversationType,
-                onNewConversation: this.#props.onNewConversation,
-              })
-            : renderChatInput({
-                isLoading: this.#props.isLoading,
-                blockedByCrossOrigin: this.#props.blockedByCrossOrigin,
-                isTextInputDisabled: this.#props.isTextInputDisabled,
-                inputPlaceholder: this.#props.inputPlaceholder,
-                state: this.#props.state,
-                disclaimerText: this.#props.disclaimerText,
-                selectedContext: this.#props.selectedContext,
-                inspectElementToggled: this.#props.inspectElementToggled,
-                multimodalInputEnabled: this.#props.multimodalInputEnabled,
-                conversationType: this.#props.conversationType,
-                imageInput: this.#props.imageInput,
-                isTextInputEmpty: this.#props.isTextInputEmpty,
-                aidaAvailability: this.#props.aidaAvailability,
-                uploadImageInputEnabled: this.#props.uploadImageInputEnabled,
-                onContextClick: this.#props.onContextClick,
-                onInspectElementClick: this.#props.onInspectElementClick,
-                onSubmit: this.#handleSubmit,
-                onTextAreaKeyDown: this.#handleTextAreaKeyDown,
-                onCancel: this.#handleCancel,
-                onNewConversation: this.#props.onNewConversation,
-                onTakeScreenshot: this.#props.onTakeScreenshot,
-                onRemoveImageInput: this.#props.onRemoveImageInput,
-                onTextInputChange: this.#props.onTextInputChange,
-                onImageUpload: this.#handleImageUpload,
-              })
-          }
+          ${renderInputOrReadOnlySection()}
         </main>
        ${renderFooter()}
       </div>
@@ -1412,7 +1404,6 @@ function renderChatInput({
   blockedByCrossOrigin,
   isTextInputDisabled,
   inputPlaceholder,
-  state,
   selectedContext,
   inspectElementToggled,
   multimodalInputEnabled,
@@ -1437,7 +1428,6 @@ function renderChatInput({
   blockedByCrossOrigin: boolean,
   isTextInputDisabled: boolean,
   inputPlaceholder: Platform.UIString.LocalizedString,
-  state: State,
   selectedContext: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null,
   inspectElementToggled: boolean,
   isTextInputEmpty: boolean,
@@ -1462,8 +1452,7 @@ function renderChatInput({
     return Lit.nothing;
   }
 
-  const shouldShowMultiLine = state !== State.CONSENT_VIEW &&
-      aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE && selectedContext;
+  const shouldShowMultiLine = aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE && selectedContext;
   const chatInputContainerCls = Lit.Directives.classMap({
     'chat-input-container': true,
     'single-line-layout': !shouldShowMultiLine,
@@ -1618,11 +1607,10 @@ function renderMainContents({
   conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,
   changeSummary?: string,
 }): Lit.LitTemplate {
-  if (state === State.CONSENT_VIEW) {
-    return renderDisabledState(renderConsentViewContents());
-  }
-
-  if (aidaAvailability !== Host.AidaClient.AidaAccessPreconditions.AVAILABLE) {
+  if (state === State.DISABLED_VIEW) {
+    if (aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE) {
+      return renderDisabledState(renderConsentViewContents());
+    }
     return renderDisabledState(renderAidaUnavailableContents(aidaAvailability));
   }
 

package/front_end/panels/application/BackForwardCacheTreeElement.ts

@@ -6,8 +6,6 @@ import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import type * as Platform from '../../core/platform/platform.js';
 import * as IconButton from '../../ui/components/icon_button/icon_button.js';
-import * as LegacyWrapper from '../../ui/components/legacy_wrapper/legacy_wrapper.js';
-import * as UI from '../../ui/legacy/legacy.js';
 
 import {ApplicationPanelTreeElement} from './ApplicationPanelTreeElement.js';
 import * as ApplicationComponents from './components/components.js';
@@ -23,8 +21,7 @@ const str_ = i18n.i18n.registerUIStrings('panels/application/BackForwardCacheTre
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class BackForwardCacheTreeElement extends ApplicationPanelTreeElement {
-  private view?: LegacyWrapper.LegacyWrapper
-      .LegacyWrapper<UI.Widget.Widget, ApplicationComponents.BackForwardCacheView.BackForwardCacheView>;
+  private view?: ApplicationComponents.BackForwardCacheView.BackForwardCacheView;
 
   constructor(resourcesPanel: ResourcesPanel) {
     super(resourcesPanel, i18nString(UIStrings.backForwardCache), false, 'bfcache');
@@ -39,8 +36,7 @@ export class BackForwardCacheTreeElement extends ApplicationPanelTreeElement {
   override onselect(selectedByUser?: boolean): boolean {
     super.onselect(selectedByUser);
     if (!this.view) {
-      this.view = LegacyWrapper.LegacyWrapper.legacyWrapper(
-          UI.Widget.Widget, new ApplicationComponents.BackForwardCacheView.BackForwardCacheView());
+      this.view = new ApplicationComponents.BackForwardCacheView.BackForwardCacheView();
     }
     this.showView(this.view);
     Host.userMetrics.panelShown('back-forward-cache');

package/front_end/panels/application/StorageView.ts

@@ -12,6 +12,7 @@ import type * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as uiI18n from '../../ui/i18n/i18n.js';
 import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
+import * as SettingsUI from '../../ui/legacy/components/settings_ui/settings_ui.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
@@ -207,7 +208,7 @@ export class StorageView extends UI.Widget.VBox {
     this.clearButton.id = 'storage-view-clear-button';
     clearButtonSection.appendChild(this.clearButton);
 
-    const includeThirdPartyCookiesCheckbox = UI.SettingsUI.createSettingCheckbox(
+    const includeThirdPartyCookiesCheckbox = SettingsUI.SettingsUI.createSettingCheckbox(
         i18nString(UIStrings.includingThirdPartyCookies), this.includeThirdPartyCookiesSetting);
     includeThirdPartyCookiesCheckbox.classList.add('include-third-party-cookies');
     clearButtonSection.appendChild(includeThirdPartyCookiesCheckbox);
@@ -280,7 +281,7 @@ export class StorageView extends UI.Widget.VBox {
     const row = section.appendRow();
     const setting = this.settings.get(settingName);
     if (setting) {
-      row.appendChild(UI.SettingsUI.createSettingCheckbox(title, setting));
+      row.appendChild(SettingsUI.SettingsUI.createSettingCheckbox(title, setting));
     }
   }