chrome-devtools-frontend 1.0.1536371 → 1.0.1537268

package/front_end/ui/components/tooltips/Tooltip.ts

@@ -443,7 +443,7 @@ export class Tooltip extends HTMLElement {
     this.#previousAnchorRect = anchorRect;
     this.#previousPopoverRect = currentPopoverRect;
 
-    const inspectorViewRect = UI.InspectorView.InspectorView.instance().element.getBoundingClientRect();
+    const inspectorViewRect = UI.UIUtils.getDevToolsBoundingElement().getBoundingClientRect();
     const preferredPositions =
         this.preferSpanLeft ? [PositionOption.BOTTOM_SPAN_LEFT, PositionOption.TOP_SPAN_LEFT] : [];
     const proposedPopoverRect = this.variant === 'rich' ?

package/front_end/ui/legacy/Dialog.ts

@@ -33,7 +33,6 @@ export class Dialog extends Common.ObjectWrapper.eventMixin<EventTypes, typeof G
       this.contentElement.setAttribute(
           'jslog', `${VisualLogging.dialog(jslogContext).track({resize: true, keydown: 'Escape'})}`);
     }
-    this.widget().setDefaultFocusedElement(this.contentElement);
     this.setPointerEventsBehavior(PointerEventsBehavior.BLOCKED_BY_GLASS_PANE);
     this.setOutsideClickCallback(event => {
       // If there are stacked dialogs, we only want to

package/front_end/ui/legacy/SettingsUI.ts

@@ -205,16 +205,6 @@ const bindCheckboxImpl = function(
   };
 };
 
-export const createCustomSetting = function(name: string, element: Element): Element {
-  const p = document.createElement('p');
-  p.classList.add('settings-select');
-  const label = p.createChild('label');
-  label.textContent = name;
-  ARIAUtils.bindLabelToControl(label, element);
-  p.appendChild(element);
-  return p;
-};
-
 export const createControlForSetting = function(
     setting: Common.Settings.Setting<unknown>, subtitle?: string): HTMLElement|null {
   const uiTitle = setting.title();
@@ -239,10 +229,6 @@ export const createControlForSetting = function(
   }
 };
 
-export interface SettingUI {
-  settingElement(): Element|null;
-}
-
 /**
  * Track toggle action as a whole or
  * track on and off action separately.

package/front_end/ui/legacy/XLink.ts

@@ -4,7 +4,6 @@
 
 import * as Host from '../../core/host/host.js';
 import * as Platform from '../../core/platform/platform.js';
-import {html} from '../lit/lit.js';
 import * as VisualLogging from '../visual_logging/visual_logging.js';
 
 import * as ARIAUtils from './ARIAUtils.js';
@@ -155,5 +154,3 @@ export class ContextMenuProvider implements Provider<Node> {
 }
 
 customElements.define('x-link', XLink);
-
-export const sample = html`<p>Hello, <x-link>world!</x-link></p>`;

package/front_end/ui/legacy/components/data_grid/DataGridElement.ts

@@ -372,6 +372,15 @@ class DataGridElement extends UI.UIUtils.HTMLElementWithLightDOMTemplate {
       this.#updateColumns();
     }
     this.#updateCreationNode();
+
+    const hadAddedNodes = mutationList.some(m => m.addedNodes.length > 0);
+    // If we got an update, and the data grid is sorted, we need to update the
+    // columns to maintain the sort order as the data within has changed.
+    // However, if we have nodes added, that will trigger a sort anyway so we
+    // don't need to re-sort again.
+    if (this.#dataGrid.sortColumnId() !== null && !hadAddedNodes) {
+      this.#dataGrid.dispatchEventToListeners(DataGridEvents.SORTING_CHANGED);
+    }
   }
 
   #editCallback(

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -919,7 +919,7 @@ export class LinkContextMenuProvider implements UI.ContextMenu.Provider<Node> {
 
 let linkHandlerSettingUIInstance: LinkHandlerSettingUI;
 
-export class LinkHandlerSettingUI implements UI.SettingsUI.SettingUI {
+export class LinkHandlerSettingUI {
   private element: HTMLSelectElement;
 
   private constructor() {
@@ -960,8 +960,14 @@ export class LinkHandlerSettingUI implements UI.SettingsUI.SettingUI {
     Linkifier.linkHandlerSetting().set(value);
   }
 
-  settingElement(): Element|null {
-    return UI.SettingsUI.createCustomSetting(i18nString(UIStrings.linkHandling), this.element);
+  settingElement(): Element {
+    const p = document.createElement('p');
+    p.classList.add('settings-select');
+    const label = p.createChild('label');
+    label.textContent = i18nString(UIStrings.linkHandling);
+    UI.ARIAUtils.bindLabelToControl(label, this.element);
+    p.appendChild(this.element);
+    return p;
   }
 }
 

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -3839,7 +3839,7 @@ export const knownContextValues = new Set([
   'timeline.enable',
   'timeline.export-trace-options',
   'timeline.export-trace-options.annotations-checkbox',
-  'timeline.export-trace-options.script-content-checkbox',
+  'timeline.export-trace-options.resource-content-checkbox',
   'timeline.export-trace-options.should-compress-checkbox',
   'timeline.export-trace-options.source-maps-checkbox',
   'timeline.extension',

package/mcp/mcp.ts

@@ -2,6 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/**
+ * IMPORTANT! Make sure that any class that is exported here has related unit
+ * tests added to foundation_unittests. See front_end/core/i18n/BUILD.gn as an
+ * example.
+ */
 export * as I18n from '../front_end/core/i18n/i18n.js';
 export {ConnectionTransport} from '../front_end/core/protocol_client/ConnectionTransport.js';
 export {

package/package.json

@@ -102,5 +102,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1536371"
+  "version": "1.0.1537268"
 }

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatterBounds.snapshot.txt

@@ -1,4 +0,0 @@
-Title: PerformanceTraceFormatterBounds serializeBounds works
-Content:
-{min: 1, max: 2}
-=== end content

package/front_end/ui/components/docs/breadcrumbs_perf/initial-breadcrumb-perf.html

@@ -1,20 +0,0 @@
-<!--
-  Copyright 2020 The Chromium Authors
-  Use of this source code is governed by a BSD-style license that can be
-  found in the LICENSE file.
--->
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <meta name="viewport" content="width=device-width" />
-    <title>Breadcrumb example</title>
-  </head>
-  <body>
-
-    <div id="container">
-    </div>
-
-    <script type="module" src="./initial-breadcrumb-perf.js"></script>
-  </body>
-</html>

package/front_end/ui/components/docs/breadcrumbs_perf/initial-breadcrumb-perf.ts

@@ -1,25 +0,0 @@
-// Copyright 2023 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as Trace from '../../../../../front_end/models/trace/trace.js';
-import * as TimelineComponents from '../../../../../front_end/panels/timeline/components/components.js';
-
-const breadcrumbsUI = new TimelineComponents.BreadcrumbsUI.BreadcrumbsUI();
-document.getElementById('container')?.appendChild(breadcrumbsUI);
-
-const traceWindow: Trace.Types.Timing.TraceWindowMicro = {
-  min: Trace.Types.Timing.Micro(3),
-  max: Trace.Types.Timing.Micro(9),
-  range: Trace.Types.Timing.Micro(6),
-};
-
-const breadcrumb: Trace.Types.File.Breadcrumb = {
-  window: traceWindow,
-  child: null,
-};
-
-breadcrumbsUI.data = {
-  initialBreadcrumb: breadcrumb,
-  activeBreadcrumb: breadcrumb,
-};

package/front_end/ui/components/docs/breadcrumbs_perf/nested-breadcrumbs-perf.html

@@ -1,20 +0,0 @@
-<!--
-  Copyright 2020 The Chromium Authors
-  Use of this source code is governed by a BSD-style license that can be
-  found in the LICENSE file.
--->
-<!DOCTYPE html>
-<html>
-  <head>
-    <meta charset="UTF-8" />
-    <meta name="viewport" content="width=device-width" />
-    <title>Breadcrumb example</title>
-  </head>
-  <body>
-
-    <div id="container">
-    </div>
-
-    <script type="module" src="./nested-breadcrumbs-perf.js"></script>
-  </body>
-</html>

package/front_end/ui/components/docs/breadcrumbs_perf/nested-breadcrumbs-perf.ts

@@ -1,36 +0,0 @@
-// Copyright 2023 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as Trace from '../../../../../front_end/models/trace/trace.js';
-import * as TimelineComponents from '../../../../../front_end/panels/timeline/components/components.js';
-
-const breadcrumbsUI = new TimelineComponents.BreadcrumbsUI.BreadcrumbsUI();
-document.getElementById('container')?.appendChild(breadcrumbsUI);
-
-const traceWindow2: Trace.Types.Timing.TraceWindowMicro = {
-  min: Trace.Types.Timing.Micro(4),
-  max: Trace.Types.Timing.Micro(8),
-  range: Trace.Types.Timing.Micro(4),
-};
-
-const traceWindow: Trace.Types.Timing.TraceWindowMicro = {
-  min: Trace.Types.Timing.Micro(3),
-  max: Trace.Types.Timing.Micro(9),
-  range: Trace.Types.Timing.Micro(6),
-};
-
-const breadcrumb2: Trace.Types.File.Breadcrumb = {
-  window: traceWindow2,
-  child: null,
-};
-
-const breadcrumb: Trace.Types.File.Breadcrumb = {
-  window: traceWindow,
-  child: breadcrumb2,
-};
-
-breadcrumbsUI.data = {
-  initialBreadcrumb: breadcrumb,
-  activeBreadcrumb: breadcrumb,
-};