chrome-devtools-frontend 1.0.1534717 → 1.0.1536371

package/docs/contributing/issues.md

@@ -48,10 +48,11 @@ to Markdown (with a preview below the text input box).
 1.  Replace `<from chrome://version/>` and `<OS version>` with the relevant
     version information.
 1.  Outline exact steps to reproduce the problem. Make sure to provide steps
-    that are easy and accessible. Ideally create a minified test case on
-    [glitch.com](http://glitch.com) or [GitHub](http://github.com). Also
-    make sure to include screenshots and videos that help us to reproduce
-    and understand the problem you are facing.
+    that are easy and accessible. Ideally create a [minimal, reproducible
+    example](https://stackoverflow.com/help/minimal-reproducible-example), e.g.
+    on [codepen.io](https://codepen.io), [jsbin.com](https://jsbin.com) or
+    [GitHub](https://github.com). Also make sure to include screenshots and
+    videos that help us to reproduce and understand the problem you are facing.
 
 ## Overview
 
@@ -61,53 +62,29 @@ Tracker]. This section provides an overview of the Chromium DevTools specifics.
 ### Issue types
 
 [crbug] supports a wide range of different issue types, with ambiguous semantics.
-For Chromium DevTools we explicitly limit the set of types we use and give them
-well-defined semantics:
+For the Chromium DevTools component tree ([Chromium>Platform>DevTools]) we
+explicitly limit the set of types we use and give them well-defined semantics:
 
 | Issue Type           | Meaning                                    |
 | -------------------- | ------------------------------------------ |
 | **Bug**              | The behavior does not match what is supposed to occur or what is documented. The product does not work as expected. |
 | **Feature Request**  | The product works as intended but could be improved. |
 | **Internal Cleanup** | This is typically a maintenance issue. The issue has no effect on the behavior of a product, but addressing it may allow more intuitive interaction. |
-| **Vulnerability**    | Security vulnerabilities subject to the handling outlined in Google's [Vulnerability Priority Guidelines](http://go/vulnerability-slo). |
 | **Privacy Issue**    | Privacy issues subject to the handling outlined in Google's [Privacy Issue Bugs](http://go/pib-slo). |
 | **Task**             | A small unit of work.                      |
-| **Project**          | A goal-driven effort with a finite start and end, focused on creating a unique product, service, or result. |
-| **Feature**          | A collection of work that provides a specific value to the user. |
-
-The first 6 (**Bug** to **Task**) are used for day-to-day work and for issues
-reported by users. The last 2 (**Project** and **Feature**) are used to organize
-the other types of issues for the purpose of planning (ahead). We explicitly
-don't use Customer Issue, Process, Milestone, Epic, and Story within Chrome DevTools.
-
-*** promo
-**BEST PRACTICE:** Limit the nesting of **Project** and **Feature** to the bare
-minimum needed, and use **Task** for small chunks of work.
-***
-
-### Parent-Child Relationships and Blocking
-
-*** note
-**TL;DR:**
-
--  Prefer parent-child relationships to split work into smaller chunks.
--  Prefer blocking to express dependencies between independent / adjacent
-issues.
-***
+| **Vulnerability**    | Security vulnerabilities subject to the handling outlined in Google's [Vulnerability Priority Guidelines](http://go/vulnerability-slo). |
 
-When splitting up work into smaller chunks or when scoping a project that
-encompasses multiple bugs or feature requests, favor to express this via a
-parent-child relationship. Consider the example of a CSS Nesting:
+These are used to track day-to-day work, primarily issues reported by users. We
+explicitly don't use the Customer Issue, Process, and Story types, because the
+former is already sufficiently covered with **Bug**, **Privacy Issue** and
+**Vulnerability**, while the latter two are basically just special sub types of
+**Task** and this fine-grained distinction would add more confusion than good.
+Any use of the disallowed issue types will be corrected automatically by the
+[Blunderbuss](http://go/blunderbuss) bot.
 
-1.  This should start with an issue of type Feature which is about adding CSS
-    Nesting support to Chromium DevTools.
-1.  This Feature has child issues of type Task, which are concerned with adding
-    CSS Nesting support to the various parts of DevTools involved, for example
-    the CDP (Chrome DevTools Protocol), the Elements panel, the Sources panel,
-    and so forth.
-1.  Over the course of the project there'll likely also be Feature Requests and
-    Bugs from internal and external developers, which should also be parented
-    under the CSS Nesting Feature issue.
+We also explicitly disallow goal-type issues in the [Chromium>Platform>DevTools]
+component tree. Check out [go/chrome-tooling/project-management] for guidance
+how to manage goals using **Feature** and **Project** (_Googlers-only_).
 
 ### Priorities
 
@@ -197,25 +174,21 @@ DevTools we want to
 1. reduce the number of regressions that ship to the (Chrome) Stable channel, and
 2. reduce the number of bugs overall.
 
-The following SLOs (Service Level Objectives) apply to issues of type Bug,
-Vulnerability, and Privacy Issue. other types of issues such as Feature Request
-or Task are out of scope for SLOs (with the notable exception of Postmortem action
-items, where Chrome also enforces SLOs for non-bug issues). We also explicitly
-restrict these SLOs to bugs in [crbug], and are not concerned with bugs that are
-tracked in other places such as GitHub. Below is a high level summary of our SLOs
-(Googlers can check the [Chrome DevTools SLO Policy] and [Chrome SLO Policy] for
-more details):
+The following SLOs (Service Level Objectives) apply to issues of type "Bug",
+"Vulnerability", and "Privacy Issue". other types of issues such as "Feature
+Request" or "Task" are out of scope for SLOs (with the notable exception of
+Postmortem action items, where Chrome also enforces SLOs for non-bug issues).
+We also explicitly restrict these SLOs to bugs in [crbug], and are not concerned
+with bugs that are tracked in other places such as GitHub. Below is a high level
+summary of our SLOs (Googlers can check the [Chrome SLO Policy] for details):
 
 |      | Assignment     | Response           | Closure
 | ---- | -------------- | ------------------ | --------
 | `P0` | 1 business day | Every business day | 1 week
 | `P1` | 1 week         | 1 week             | 4 weeks
-| `P2` | 2 months       | -                  | 6 months
-| `P3` | 1 year         | -                  | -
 
-The first two rows are identical to [go/chrome-slo], with the last two rows being
-specific to Chrome DevTools. [crbug] provides a **Nearest SLO** column that
-surfaces SLO violations easily:
+These are identical to [go/chrome-slo]. [crbug] provides a **Nearest SLO**
+column that surfaces SLO violations easily:
 
 ![Nearest SLO in crbug](./images/issues-nearestslo.png "Nearest SLO in crbug")
 
@@ -224,7 +197,7 @@ surfaces SLO violations easily:
 
 ### Release Blocking Issues
 
-In accordance with go/chrome-slo there are special SLOs for issues that are
+In compliance with [go/chrome-slo] there are special SLOs for issues that are
 severe enough to block a release shipping to users (see [go/chrome-release-slos]).
 They apply to bug types in the same way as the above SLOs.
 
@@ -261,10 +234,11 @@ refreshed every 2-4 hours, to see SLO compliance for a given lead.
   [How to file a good browser bug]: https://web.dev/articles/how-to-file-a-good-bug
   [Open Chromium DevTools Bugs]: https://issues.chromium.org/issues?q=status:open%20componentid:1457055%2B%20type:bug
   [goo.gle/devtools-bug]: https://goo.gle/devtools-bug
-  [Chrome DevTools SLO Policy]: https://b.corp.google.com/slos/61348
-  [Chrome SLO Policy]: https://b.corp.google.com/slos/1834
+  [Chrome SLO Policy]: http://b/slos/1834
   [go/chrome-slo]: http://go/chrome-slo
   [go/chrome-release-slos]: http://go/chrome-release-slos
-  [Buganizer SLO Compliance]: go/b-slo-compliance
+  [go/chrome-tooling/project-management]: http://go/chrome-tooling/project-management
+  [Buganizer SLO Compliance]: http://go/b-slo-compliance
   [TaskFlow]: http://go/chrome-devtools:taskflow
   [TaskFlow Inbox]: http://go/chrome-devtools:taskflow/inbox
+  [Chromium>Platform>DevTools]: https://issues.chromium.org/components/1457055

package/eslint.config.mjs

@@ -84,6 +84,7 @@ export default defineConfig([
 
     linterOptions: {
       reportUnusedDisableDirectives: 'error',
+      reportUnusedInlineConfigs: 'error',
     },
 
     rules: {

package/front_end/core/common/Console.ts

@@ -8,14 +8,7 @@ import {reveal} from './Revealer.js';
 let consoleInstance: Console|undefined;
 
 export class Console extends ObjectWrapper<EventTypes> {
-  readonly #messages: Message[];
-  /**
-   * Instantiable via the instance() factory below.
-   */
-  constructor() {
-    super();
-    this.#messages = [];
-  }
+  readonly #messages: Message[] = [];
 
   static instance(opts?: {forceNew: boolean}): Console {
     if (!consoleInstance || opts?.forceNew) {

package/front_end/core/common/ParsedURL.ts

@@ -57,33 +57,23 @@ type BrandedPathString =
     Platform.DevToolsPath.UrlString|Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.EncodedPathString;
 
 export class ParsedURL {
-  isValid: boolean;
+  isValid = false;
   url: string;
-  scheme: string;
-  user: string;
-  host: string;
-  port: string;
-  path: string;
-  queryParams: string;
-  fragment: string;
-  folderPathComponents: string;
-  lastPathComponent: string;
+  scheme = '';
+  user = '';
+  host = '';
+  port = '';
+  path = '';
+  queryParams = '';
+  fragment = '';
+  folderPathComponents = '';
+  lastPathComponent = '';
   readonly blobInnerScheme: string|undefined;
   #displayName?: string;
   #dataURLDisplayName?: string;
 
   constructor(url: string) {
-    this.isValid = false;
     this.url = url;
-    this.scheme = '';
-    this.user = '';
-    this.host = '';
-    this.port = '';
-    this.path = '';
-    this.queryParams = '';
-    this.fragment = '';
-    this.folderPathComponents = '';
-    this.lastPathComponent = '';
 
     const isBlobUrl = this.url.startsWith('blob:');
     const urlToMatch = isBlobUrl ? url.substring(5) : url;

package/front_end/core/common/SegmentedRange.ts

@@ -24,11 +24,10 @@ export class Segment<T> {
 }
 
 export class SegmentedRange<T> {
-  #segments: Array<Segment<T>>;
+  #segments: Array<Segment<T>> = [];
   readonly #mergeCallback: ((arg0: Segment<T>, arg1: Segment<T>) => Segment<T>| null)|undefined;
 
   constructor(mergeCallback?: ((arg0: Segment<T>, arg1: Segment<T>) => Segment<T>| null)) {
-    this.#segments = [];
     this.#mergeCallback = mergeCallback;
   }
 

package/front_end/core/common/StringOutputStream.ts

@@ -8,10 +8,7 @@ export interface OutputStream {
 }
 
 export class StringOutputStream implements OutputStream {
-  #data: string;
-  constructor() {
-    this.#data = '';
-  }
+  #data = '';
 
   async write(chunk: string): Promise<void> {
     this.#data += chunk;

package/front_end/core/host/InspectorFrontendHost.ts

@@ -601,6 +601,12 @@ class InspectorFrontendAPIImpl {
   }
 }
 
+/**
+ * Used in `front_end/devtools_compatibility.js` to verify that calls from there
+ * are valid.
+ */
+export type InspectorFrontendAPIImplMethods = keyof InspectorFrontendAPIImpl;
+
 (function(): void {
 
 function initializeInspectorFrontendHost(): void {

package/front_end/core/host/UserMetrics.ts

@@ -523,7 +523,11 @@ export enum Action {
   AiCodeCompletionError = 188,
   AttributeLinkClicked = 189,
   InsightRequestedViaTeaser = 190,
-  MAX_VALUE = 191,
+  InsightTeaserGenerationStarted = 191,
+  InsightTeaserGenerationCompleted = 192,
+  InsightTeaserGenerationAborted = 193,
+  InsightTeaserGenerationErrored = 194,
+  MAX_VALUE = 195,
   /* eslint-enable @typescript-eslint/naming-convention */
 }
 

package/front_end/core/i18n/i18nImpl.ts

@@ -1,7 +1,6 @@
 // Copyright 2020 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as I18n from '../../third_party/i18n/i18n.js';
 import type * as Platform from '../platform/platform.js';
@@ -117,29 +116,6 @@ export function registerUIStrings(
   return i18nInstance.registerFileStrings(path, stringStructure);
 }
 
-/**
- * Returns a span element that may contains other DOM element as placeholders
- */
-export function getFormatLocalizedString(
-    registeredStrings: I18n.LocalizedStringSet.RegisteredFileStrings, stringId: string,
-    placeholders: Record<string, Object>): HTMLSpanElement {
-  const formatter =
-      registeredStrings.getLocalizedStringSetFor(DevToolsLocale.instance().locale).getMessageFormatterFor(stringId);
-
-  const element = document.createElement('span');
-  for (const icuElement of formatter.getAst()) {
-    if (icuElement.type === /* argumentElement */ 1) {
-      const placeholderValue = placeholders[icuElement.value];
-      if (placeholderValue) {
-        element.append(placeholderValue as Node | string);
-      }
-    } else if ('value' in icuElement) {
-      element.append(String(icuElement.value));
-    }
-  }
-  return element;
-}
-
 export function serializeUIString(string: string, values: Record<string, Object> = {}): string {
   const serializedMessage = {string, values};
   return JSON.stringify(serializedMessage);

package/front_end/core/protocol_client/CDPConnection.ts

@@ -4,6 +4,55 @@
 
 import type {ProtocolMapping} from '../../generated/protocol-mapping.js';
 
+export type CommandParams<T extends keyof ProtocolMapping.Commands> = ProtocolMapping.Commands[T]['paramsType'][0];
+export type CommandResult<T extends keyof ProtocolMapping.Commands> = ProtocolMapping.Commands[T]['returnType'];
+export type EventParams<T extends keyof ProtocolMapping.Events> = ProtocolMapping.Events[T];
+
+export interface CDPBaseMessage {
+  sessionId?: string;
+}
+
+export interface CDPCommandRequest<T extends keyof ProtocolMapping.Commands> extends CDPBaseMessage {
+  id: number;
+  method: T;
+  params: CommandParams<T>;
+}
+
+export interface CDPCommandResponse<T extends keyof ProtocolMapping.Commands> extends CDPBaseMessage {
+  id: number;
+  result: CommandResult<T>;
+}
+
+export interface CDPEvent<T extends keyof ProtocolMapping.Events> extends CDPBaseMessage {
+  method: T;
+  params: EventParams<T>;
+}
+
+/**
+ * Keep this in sync with https://source.chromium.org/chromium/chromium/src/+/main:third_party/inspector_protocol/crdtp/dispatch.h.
+ */
+export const enum CDPErrorStatus {
+  PARSE_ERROR = -32700,
+  INVALID_REQUEST = -32600,
+  METHOD_NOT_FOUND = -32601,
+  INVALID_PARAMS = -32602,
+  INTERNAL_ERROR = -32603,
+  SERVER_ERROR = -32000,
+  SESSION_NOT_FOUND = SERVER_ERROR - 1,
+}
+
+export interface CDPError extends CDPBaseMessage {
+  id?: number;
+  error: {
+    code: CDPErrorStatus,
+    message: string,
+    data?: string,
+  };
+}
+
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type CDPMessage = CDPCommandRequest<any>|CDPCommandResponse<any>|CDPEvent<any>|CDPError;
+
 /**
  * Allows the sending and receiving of CDP commands and the notification of CDP events to observers.
  *
@@ -12,9 +61,8 @@ import type {ProtocolMapping} from '../../generated/protocol-mapping.js';
  * would conflict with any other shared traffic.
  */
 export interface CDPConnection {
-  send<T extends keyof ProtocolMapping.Commands>(
-      method: T, params: ProtocolMapping.Commands[T]['paramsType'][0],
-      sessionId: string|undefined): Promise<ProtocolMapping.Commands[T]['returnType']|{getError(): string}>;
+  send<T extends keyof ProtocolMapping.Commands>(method: T, params: CommandParams<T>, sessionId: string|undefined):
+      Promise<CommandResult<T>|{getError(): string}>;
 
   observe(observer: CDPConnectionObserver): void;
   unobserve(observer: CDPConnectionObserver): void;
@@ -34,6 +82,6 @@ export interface DebuggableCDPConnection extends CDPConnection {
 }
 
 export interface RawMessageObserver {
-  onMessageReceived(message: unknown): void;
-  onMessageSent(message: unknown): void;
+  onMessageReceived(message: CDPMessage): void;
+  onMessageSent(message: CDPMessage): void;
 }

package/front_end/core/protocol_client/protocol_client.ts

@@ -2,11 +2,13 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as CDPConnection from './CDPConnection.js';
 import * as ConnectionTransport from './ConnectionTransport.js';
 import * as InspectorBackend from './InspectorBackend.js';
 import * as NodeURL from './NodeURL.js';
 
 export {
+  CDPConnection,
   ConnectionTransport,
   InspectorBackend,
   NodeURL,

package/front_end/core/sdk/AnimationModel.ts

@@ -836,12 +836,11 @@ export class AnimationGroup {
   readonly #id: string;
   #scrollNode: AnimationDOMNode|undefined;
   #animations: AnimationImpl[];
-  #paused: boolean;
+  #paused = false;
   constructor(animationModel: AnimationModel, id: string, animations: AnimationImpl[]) {
     this.#animationModel = animationModel;
     this.#id = id;
     this.#animations = animations;
-    this.#paused = false;
   }
 
   isScrollDriven(): boolean {

package/front_end/core/sdk/CSSMatchedStyles.ts

@@ -361,7 +361,7 @@ export class CSSMatchedStyles {
       inheritedResult.matchedCSSRules = cleanUserAgentPayload(inheritedResult.matchedCSSRules);
     }
 
-    this.#environmentVariables = await this.cssModel().getEnvironmentVariales();
+    this.#environmentVariables = await this.cssModel().getEnvironmentVariables();
 
     this.#mainDOMCascade = await this.buildMainCascade(
         inlinePayload, attributesPayload, matchedPayload, inheritedPayload, animationStylesPayload,
@@ -450,7 +450,7 @@ export class CSSMatchedStyles {
     nodeCascades.push(new NodeCascade(this, nodeStyles, this.#node, false /* #isInherited */));
 
     // Walk the node structure and identify styles with inherited properties.
-    let parentNode: (DOMNode|null) = this.#node.parentNode;
+    let parentNode: DOMNode|null = this.#node.parentNode;
     const traverseParentInFlatTree = async(node: DOMNode): Promise<DOMNode|null> => {
       if (node.hasAssignedSlot()) {
         return await node.assignedSlot?.deferredNode.resolvePromise() ?? null;

package/front_end/core/sdk/CSSModel.ts

@@ -407,7 +407,7 @@ export class CSSModel extends SDKModel<EventTypes> {
     };
   }
 
-  async getEnvironmentVariales(): Promise<Record<string, string>> {
+  async getEnvironmentVariables(): Promise<Record<string, string>> {
     const response = await this.agent.invoke_getEnvironmentVariables();
     if (response.getError()) {
       return {};

package/front_end/core/sdk/CSSProperty.ts

@@ -41,9 +41,9 @@ export class CSSProperty extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
   implicit: boolean;
   text: string|null|undefined;
   range: TextUtils.TextRange.TextRange|null;
-  #active: boolean;
-  #nameRange: TextUtils.TextRange.TextRange|null;
-  #valueRange: TextUtils.TextRange.TextRange|null;
+  #active = true;
+  #nameRange: TextUtils.TextRange.TextRange|null = null;
+  #valueRange: TextUtils.TextRange.TextRange|null = null;
   #invalidString?: Common.UIString.LocalizedString;
   #longhandProperties: CSSProperty[] = [];
 
@@ -62,9 +62,6 @@ export class CSSProperty extends Common.ObjectWrapper.ObjectWrapper<EventTypes>
     this.implicit = implicit;  // A longhand, implicitly set by missing values of shorthand.
     this.text = text;
     this.range = range ? TextUtils.TextRange.TextRange.fromObject(range) : null;
-    this.#active = true;
-    this.#nameRange = null;
-    this.#valueRange = null;
 
     if (longhandProperties && longhandProperties.length > 0) {
       for (const property of longhandProperties) {

package/front_end/core/sdk/CSSStyleDeclaration.ts

@@ -14,14 +14,14 @@ import type {Target} from './Target.js';
 export class CSSStyleDeclaration {
   readonly #cssModel: CSSModel;
   parentRule: CSSRule|null;
-  #allProperties!: CSSProperty[];
+  #allProperties: CSSProperty[] = [];
   styleSheetId?: Protocol.CSS.StyleSheetId;
-  range!: TextUtils.TextRange.TextRange|null;
+  range: TextUtils.TextRange.TextRange|null = null;
   cssText?: string;
   #shorthandValues = new Map<string, string>();
   #shorthandIsImportant = new Set<string>();
   #activePropertyMap = new Map<string, CSSProperty>();
-  #leadingProperties!: CSSProperty[]|null;
+  #leadingProperties: CSSProperty[]|null = null;
   type: Type;
   // For CSSStyles coming from animations,
   // This holds the name of the animation.
@@ -97,7 +97,7 @@ export class CSSStyleDeclaration {
     this.#computeInactiveProperties();
 
     // TODO(changhaohan): verify if this #activePropertyMap is still necessary, or if it is
-    // providing different information against the activeness in allPropertiesInternal.
+    // providing different information against the activeness in #allProperties.
     this.#activePropertyMap = new Map();
     for (const property of this.#allProperties) {
       if (!property.activeInStyle()) {

package/front_end/core/sdk/DebuggerModel.ts

@@ -1402,14 +1402,13 @@ export class Scope implements ScopeChainEntry {
   readonly #name: string|undefined;
   #ordinal: number;
   readonly #locationRange: LocationRange|null;
-  #object: RemoteObject|null;
+  #object: RemoteObject|null = null;
   constructor(callFrame: CallFrame, ordinal: number) {
     this.#callFrame = callFrame;
     this.#payload = callFrame.getPayload().scopeChain[ordinal];
     this.#type = this.#payload.type;
     this.#name = this.#payload.name;
     this.#ordinal = ordinal;
-    this.#object = null;
 
     const start =
         this.#payload.startLocation ? Location.fromPayload(callFrame.debuggerModel, this.#payload.startLocation) : null;

package/front_end/core/sdk/EnhancedTracesParser.ts

@@ -164,6 +164,10 @@ export class EnhancedTracesParser {
           if (frame.url === 'about:blank') {
             continue;
           }
+          if (!frame.isInPrimaryMainFrame) {
+            continue;
+          }
+
           const frameId = frame.frame as string as Protocol.Target.TargetID;
           if (!this.#targets.find(target => target.targetId === frameId)) {
             const frameType = frame.isOutermostMainFrame ? 'page' : 'iframe';

package/front_end/core/sdk/SourceMap.ts

@@ -128,7 +128,7 @@ export class SourceMap {
   readonly #compiledURL: Platform.DevToolsPath.UrlString;
   readonly #sourceMappingURL: Platform.DevToolsPath.UrlString;
   readonly #baseURL: Platform.DevToolsPath.UrlString;
-  #mappings: SourceMapEntry[]|null;
+  #mappings: SourceMapEntry[]|null = null;
 
   readonly #sourceInfos: SourceInfo[] = [];
   readonly #sourceInfoByURL = new Map<Platform.DevToolsPath.UrlString, SourceInfo>();
@@ -154,7 +154,6 @@ export class SourceMap {
     this.#baseURL = (Common.ParsedURL.schemeIs(sourceMappingURL, 'data:')) ? compiledURL : sourceMappingURL;
     this.#debugId = 'debugId' in payload ? (payload.debugId as DebugId | undefined) : undefined;
 
-    this.#mappings = null;
     if ('sections' in this.#json) {
       if (this.#json.sections.find(section => 'url' in section)) {
         Common.Console.Console.instance().warn(
@@ -435,7 +434,7 @@ export class SourceMap {
   #computeReverseMappings(mappings: SourceMapEntry[]): void {
     const reverseMappingsPerUrl = new Map<Platform.DevToolsPath.UrlString, number[]>();
     for (let i = 0; i < mappings.length; i++) {
-      const entryUrl = mappings[i].sourceURL;
+      const entryUrl = mappings[i]?.sourceURL;
       if (!entryUrl) {
         continue;
       }