chrome-devtools-frontend 1.0.1532884 → 1.0.1533544

package/eslint.config.mjs

@@ -3,16 +3,16 @@
 // found in the LICENSE file.
 
 import stylisticPlugin from '@stylistic/eslint-plugin';
+import { defineConfig, globalIgnores } from 'eslint/config';
 import eslintPlugin from 'eslint-plugin-eslint-plugin';
 import importPlugin from 'eslint-plugin-import';
 import jsdocPlugin from 'eslint-plugin-jsdoc';
 import mochaPlugin from 'eslint-plugin-mocha';
-import {defineConfig, globalIgnores} from 'eslint/config';
 import globals from 'globals';
-import {join} from 'path';
+import { join } from 'path';
 import typescriptEslint from 'typescript-eslint';
 
-import rulesdirPlugin from './scripts/eslint_rules/rules-dir.mjs';
+import devToolsPlugin from './scripts/eslint_rules/plugin.mjs';
 
 export default defineConfig([
   globalIgnores([
@@ -69,7 +69,7 @@ export default defineConfig([
       '@stylistic': stylisticPlugin,
       '@eslint-plugin': eslintPlugin,
       mocha: mochaPlugin,
-      rulesdir: rulesdirPlugin,
+      '@devtools': devToolsPlugin,
       import: importPlugin,
       jsdoc: jsdocPlugin,
     },
@@ -193,7 +193,7 @@ export default defineConfig([
       radix: 'error',
       'valid-typeof': 'error',
       'no-return-assign': ['error', 'always'],
-      'no-implicit-coercion': ['error', {allow: ['!!']}],
+      'no-implicit-coercion': ['error', { allow: ['!!'] }],
 
       'no-array-constructor': 'error',
 
@@ -282,9 +282,9 @@ export default defineConfig([
         },
       ],
       // Try to spot '// console.log()' left over from debugging
-      'rulesdir/no-commented-out-console': 'error',
+      '@devtools/no-commented-out-console': 'error',
       // Prevent imports being commented out rather than deleted.
-      'rulesdir/no-commented-out-import': 'error',
+      '@devtools/no-commented-out-import': 'error',
       /**
        * Enforce some consistency and usefulness of JSDoc comments, to make sure
        * we actually benefit from them.
@@ -294,8 +294,8 @@ export default defineConfig([
         'error',
         {
           definedTags: [
-            'attribute',  // @attribute is used by lit-analyzer (through web-component-analyzer)
-            'meaning',    // @meaning is used by localization
+            'attribute', // @attribute is used by lit-analyzer (through web-component-analyzer)
+            'meaning', // @meaning is used by localization
           ],
         },
       ],
@@ -326,11 +326,11 @@ export default defineConfig([
       parserOptions: {
         allowAutomaticSingleRunInference: true,
         project: join(
-            import.meta.dirname,
-            'config',
-            'typescript',
-            'tsconfig.eslint.json',
-            ),
+          import.meta.dirname,
+          'config',
+          'typescript',
+          'tsconfig.eslint.json',
+        ),
       },
     },
 
@@ -567,25 +567,25 @@ export default defineConfig([
       'no-useless-constructor': 'off',
       '@typescript-eslint/no-useless-constructor': 'error',
 
-      'rulesdir/no-underscored-properties': 'error',
-      'rulesdir/inline-type-imports': 'error',
+      '@devtools/no-underscored-properties': 'error',
+      '@devtools/inline-type-imports': 'error',
 
-      'rulesdir/enforce-default-import-name': [
+      '@devtools/enforce-default-import-name': [
         'error',
         {
           // Enforce that any import of models/trace/trace.js names the import Trace.
           modulePath: join(
-              import.meta.dirname,
-              'front_end',
-              'models',
-              'trace',
-              'trace.js',
-              ),
+            import.meta.dirname,
+            'front_end',
+            'models',
+            'trace',
+            'trace.js',
+          ),
           importName: 'Trace',
         },
       ],
 
-      'rulesdir/validate-timing-types': 'error',
+      '@devtools/validate-timing-types': 'error',
 
       // Disallow redundant (and potentially conflicting) type information
       // within JSDoc comments.
@@ -598,7 +598,7 @@ export default defineConfig([
     files: ['scripts/**/*'],
     rules: {
       'no-console': 'off',
-      'rulesdir/es-modules-import': 'off',
+      '@devtools/es-modules-import': 'off',
       'import/no-default-export': 'off',
     },
   },
@@ -607,17 +607,17 @@ export default defineConfig([
     files: ['front_end/**/*'],
     rules: {
       // L10n rules are only relevant in 'front_end'.
-      'rulesdir/l10n-filename-matches': [
+      '@devtools/l10n-filename-matches': [
         'error',
         {
           rootFrontendDirectory: join(import.meta.dirname, 'front_end'),
         },
       ],
-      'rulesdir/l10n-i18nString-call-only-with-uistrings': 'error',
-      'rulesdir/l10n-no-i18nString-calls-module-instantiation': 'error',
-      'rulesdir/l10n-no-locked-or-placeholder-only-phrase': 'error',
-      'rulesdir/l10n-no-uistrings-export': 'error',
-      'rulesdir/l10n-no-unused-message': 'error',
+      '@devtools/l10n-i18nString-call-only-with-uistrings': 'error',
+      '@devtools/l10n-no-i18nString-calls-module-instantiation': 'error',
+      '@devtools/l10n-no-locked-or-placeholder-only-phrase': 'error',
+      '@devtools/l10n-no-uistrings-export': 'error',
+      '@devtools/l10n-no-unused-message': 'error',
     },
   },
   {
@@ -632,41 +632,41 @@ export default defineConfig([
           allowIIFEs: true,
         },
       ],
-      'rulesdir/no-imperative-dom-api': 'error',
-      'rulesdir/no-lit-render-outside-of-view': 'error',
-      'rulesdir/no-importing-images-from-src': 'error',
-      'rulesdir/enforce-custom-event-names': 'error',
-      'rulesdir/set-data-type-reference': 'error',
-      'rulesdir/no-bound-component-methods': 'error',
-      'rulesdir/no-adopted-style-sheets': 'error',
-      'rulesdir/no-customized-builtin-elements': 'error',
-      'rulesdir/no-deprecated-component-usages': 'error',
-      'rulesdir/no-self-closing-custom-element-tagnames': 'error',
-      'rulesdir/no-a-tags-in-lit': 'error',
-      'rulesdir/check-css-import': 'error',
-      'rulesdir/enforce-optional-properties-last': 'error',
-      'rulesdir/check-enumerated-histograms': 'error',
-      'rulesdir/require-super-calls-in-overridden-methods': [
+      '@devtools/no-imperative-dom-api': 'error',
+      '@devtools/no-lit-render-outside-of-view': 'error',
+      '@devtools/no-importing-images-from-src': 'error',
+      '@devtools/enforce-custom-event-names': 'error',
+      '@devtools/set-data-type-reference': 'error',
+      '@devtools/no-bound-component-methods': 'error',
+      '@devtools/no-adopted-style-sheets': 'error',
+      '@devtools/no-customized-builtin-elements': 'error',
+      '@devtools/no-deprecated-component-usages': 'error',
+      '@devtools/no-self-closing-custom-element-tagnames': 'error',
+      '@devtools/no-a-tags-in-lit': 'error',
+      '@devtools/check-css-import': 'error',
+      '@devtools/enforce-optional-properties-last': 'error',
+      '@devtools/check-enumerated-histograms': 'error',
+      '@devtools/require-super-calls-in-overridden-methods': [
         'error',
         {
           methodNames: ['wasShown', 'willHide'],
         },
       ],
-      'rulesdir/static-custom-event-names': 'error',
-      'rulesdir/lit-no-attribute-quotes': 'error',
-      'rulesdir/lit-template-result-or-nothing': 'error',
-      'rulesdir/inject-checkbox-styles': 'error',
-      'rulesdir/jslog-context-list': 'error',
-      'rulesdir/es-modules-import': 'error',
-      'rulesdir/html-tagged-template': 'error',
-      'rulesdir/enforce-custom-element-definitions-location': [
+      '@devtools/static-custom-event-names': 'error',
+      '@devtools/lit-no-attribute-quotes': 'error',
+      '@devtools/lit-template-result-or-nothing': 'error',
+      '@devtools/inject-checkbox-styles': 'error',
+      '@devtools/jslog-context-list': 'error',
+      '@devtools/es-modules-import': 'error',
+      '@devtools/html-tagged-template': 'error',
+      '@devtools/enforce-custom-element-definitions-location': [
         'error',
         {
           rootFrontendDirectory: join(import.meta.dirname, 'front_end'),
         },
       ],
-      'rulesdir/enforce-ui-strings-as-const': 'error',
-      'rulesdir/no-new-lit-element-components': 'error',
+      '@devtools/enforce-ui-strings-as-const': 'error',
+      '@devtools/no-new-lit-element-components': 'error',
     },
   },
   {
@@ -720,23 +720,23 @@ export default defineConfig([
         },
       ],
 
-      'rulesdir/check-test-definitions': 'error',
-      'rulesdir/no-assert-strict-equal-for-arrays-and-objects': 'error',
-      'rulesdir/no-assert-deep-strict-equal': 'error',
-      'rulesdir/no-assert-equal': 'error',
-      'rulesdir/no-assert-equal-boolean-null-undefined': 'error',
-      'rulesdir/no-capture-screenshot': 'error',
-      'rulesdir/no-imperative-dom-api': 'off',
-      'rulesdir/no-lit-render-outside-of-view': 'off',
-      'rulesdir/prefer-assert-instance-of': 'error',
-      'rulesdir/prefer-assert-is-ok': 'error',
-      'rulesdir/prefer-assert-length-of': 'error',
-      'rulesdir/prefer-assert-strict-equal': 'error',
-      'rulesdir/prefer-sinon-assert': 'error',
-      'rulesdir/prefer-url-string': 'error',
-      'rulesdir/trace-engine-test-timeouts': 'error',
-      'rulesdir/no-document-body-mutation': 'error',
-      'rulesdir/enforce-custom-element-definitions-location': 'off',
+      '@devtools/check-test-definitions': 'error',
+      '@devtools/no-assert-strict-equal-for-arrays-and-objects': 'error',
+      '@devtools/no-assert-deep-strict-equal': 'error',
+      '@devtools/no-assert-equal': 'error',
+      '@devtools/no-assert-equal-boolean-null-undefined': 'error',
+      '@devtools/no-capture-screenshot': 'error',
+      '@devtools/no-imperative-dom-api': 'off',
+      '@devtools/no-lit-render-outside-of-view': 'off',
+      '@devtools/prefer-assert-instance-of': 'error',
+      '@devtools/prefer-assert-is-ok': 'error',
+      '@devtools/prefer-assert-length-of': 'error',
+      '@devtools/prefer-assert-strict-equal': 'error',
+      '@devtools/prefer-sinon-assert': 'error',
+      '@devtools/prefer-url-string': 'error',
+      '@devtools/trace-engine-test-timeouts': 'error',
+      '@devtools/no-document-body-mutation': 'error',
+      '@devtools/enforce-custom-element-definitions-location': 'off',
     },
 
     settings: {
@@ -773,7 +773,7 @@ export default defineConfig([
     ],
 
     rules: {
-      'rulesdir/prefer-private-class-members': 'error',
+      '@devtools/prefer-private-class-members': 'error',
     },
   },
   {
@@ -784,14 +784,14 @@ export default defineConfig([
     ],
     rules: {
       // TODO(crbug/1402569): Reenable once https://github.com/microsoft/TypeScript/issues/48885 is closed.
-      'rulesdir/prefer-private-class-members': 'off',
+      '@devtools/prefer-private-class-members': 'off',
     },
   },
   {
     name: 'Supported CSS properties rules',
     files: ['front_end/generated/SupportedCSSProperties.js'],
     rules: {
-      'rulesdir/jslog-context-list': 'error',
+      '@devtools/jslog-context-list': 'error',
     },
   },
   {
@@ -805,7 +805,7 @@ export default defineConfig([
     name: 'Legacy test runner',
     files: ['front_end/legacy_test_runner/**/*'],
     rules: {
-      'rulesdir/es-modules-import': 'off',
+      '@devtools/es-modules-import': 'off',
     },
   },
   {
@@ -818,9 +818,9 @@ export default defineConfig([
       '@typescript-eslint/explicit-function-return-type': 'off',
       // We use Lit to help render examples sometimes and we don't use
       // {host: this} as often the `this` is the window.
-      'rulesdir/lit-host-this': 'off',
-      'rulesdir/no-imperative-dom-api': 'off',
-      'rulesdir/no-lit-render-outside-of-view': 'off',
+      '@devtools/lit-host-this': 'off',
+      '@devtools/no-imperative-dom-api': 'off',
+      '@devtools/no-lit-render-outside-of-view': 'off',
     },
   },
   {
@@ -828,64 +828,20 @@ export default defineConfig([
     files: ['front_end/models/trace/**/*.ts'],
     ignores: ['front_end/models/trace/**/*.test.ts'],
     rules: {
-      'rulesdir/no-imports-in-directory': [
+      '@devtools/no-imports-in-directory': [
         'error',
         {
           bannedImportPaths: [
             {
               bannedPath: join(
-                  import.meta.dirname,
-                  'front_end',
-                  'core',
-                  'sdk',
-                  'sdk.js',
-                  ),
+                import.meta.dirname,
+                'front_end',
+                'core',
+                'sdk',
+                'sdk.js',
+              ),
               allowTypeImports: true,
             },
-            {
-              bannedPath: join(
-                  import.meta.dirname,
-                  'front_end',
-                  'ui',
-                  'legacy',
-                  'legacy.js',
-                  ),
-              allowTypeImports: false,
-            },
-          ],
-        },
-      ],
-    },
-  },
-  {
-    name: 'No UI in models',
-    files: ['front_end/models/**/*.ts'],
-    ignores: ['front_end/models/**/*.test.ts'],
-    rules: {
-      'rulesdir/no-imports-in-directory': [
-        'error',
-        {
-          bannedImportPaths: [
-            {
-              bannedPath: join(
-                  import.meta.dirname,
-                  'front_end',
-                  'ui',
-                  'legacy',
-                  'legacy.js',
-                  ),
-              allowTypeImports: false,
-            },
-            {
-              bannedPath: join(
-                  import.meta.dirname,
-                  'front_end',
-                  'ui',
-                  'lit',
-                  'lit.js',
-                  ),
-              allowTypeImports: false,
-            },
           ],
         },
       ],
@@ -896,7 +852,7 @@ export default defineConfig([
     files: ['front_end/panels/recorder/injected/**/*.ts'],
     rules: {
       // The code is rolled up and tree-shaken independently from the regular entrypoints.
-      'rulesdir/es-modules-import': 'off',
+      '@devtools/es-modules-import': 'off',
     },
   },
   {
@@ -908,7 +864,7 @@ export default defineConfig([
       // enabled in this folder because it is an
       // expensive rule to run and we do not need it
       // for any code that doesn't use Canvas.
-      'rulesdir/canvas-context-tracking': 'error',
+      '@devtools/canvas-context-tracking': 'error',
     },
   },
   {

package/front_end/core/host/InspectorFrontendHost.ts

@@ -212,7 +212,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
       }
     }
 
-    /* eslint-disable-next-line rulesdir/no-imperative-dom-api */
+    /* eslint-disable-next-line @devtools/no-imperative-dom-api */
     const link = document.createElement('a');
     link.download = fileName;
     let blob;

package/front_end/core/host/UserMetrics.ts

@@ -506,8 +506,6 @@ export enum Action {
   AiAssistanceSideEffectConfirmed = 179,
   AiAssistanceSideEffectRejected = 180,
   AiAssistanceError = 181,
-  AiAssistanceOpenedFromPerformanceInsight = 182,
-  AiAssistanceOpenedFromPerformanceFullButton = 183,
   AiCodeCompletionResponseServedFromCache = 184,
   AiCodeCompletionRequestTriggered = 185,
   AiCodeCompletionSuggestionDisplayed = 186,
@@ -801,8 +799,6 @@ export enum DevtoolsExperiments {
   'just-my-code' = 65,
   'use-source-map-scopes' = 76,
   'timeline-show-postmessage-events' = 86,
-  'timeline-enhanced-traces' = 90,
-  'timeline-compiled-sources' = 91,
   'timeline-debug-mode' = 93,
   /* eslint-enable @typescript-eslint/naming-convention */
 

package/front_end/core/i18n/i18nImpl.ts

@@ -1,7 +1,7 @@
 // Copyright 2020 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as I18n from '../../third_party/i18n/i18n.js';
 import type * as Platform from '../platform/platform.js';

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -191,14 +191,13 @@ export const test = {
    * Set to get notified about any messages sent over protocol.
    */
   onMessageSent: null as
-          ((message: {domain: string, method: string, params: Object, id: number, sessionId?: string},
-            target: TargetBase|null) => void) |
+          ((message: {domain: string, method: string, params: Object, id: number, sessionId?: string}) => void) |
       null,
 
   /**
    * Set to get notified about any messages received over protocol.
    */
-  onMessageReceived: null as ((message: Object, target: TargetBase|null) => void) | null,
+  onMessageReceived: null as ((message: Object) => void) | null,
 };
 
 const LongPollingMethods = new Set<string>(['CSS.takeComputedStyleUpdates']);
@@ -257,14 +256,6 @@ export class SessionRouter {
     this.#sessions.delete(sessionId);
   }
 
-  private getTargetBySessionId(sessionId: string): TargetBase|null {
-    const session = this.#sessions.get(sessionId ? sessionId : '');
-    if (!session) {
-      return null;
-    }
-    return session.target;
-  }
-
   private nextMessageId(): number {
     return this.#lastMessageId++;
   }
@@ -293,9 +284,7 @@ export class SessionRouter {
 
     if (test.onMessageSent) {
       const paramsObject = JSON.parse(JSON.stringify(params || {}));
-      test.onMessageSent(
-          {domain, method, params: (paramsObject as Object), id: messageId, sessionId},
-          this.getTargetBySessionId(sessionId));
+      test.onMessageSent({domain, method, params: (paramsObject as Object), id: messageId, sessionId});
     }
 
     ++this.#pendingResponsesCount;
@@ -324,7 +313,7 @@ export class SessionRouter {
 
     if (test.onMessageReceived) {
       const messageObjectCopy = JSON.parse((typeof message === 'string') ? message : JSON.stringify(message));
-      test.onMessageReceived(messageObjectCopy, this.getTargetBySessionId(messageObjectCopy.sessionId));
+      test.onMessageReceived(messageObjectCopy);
     }
 
     const messageObject = ((typeof message === 'string') ? JSON.parse(message) : message) as Message;

package/front_end/core/root/Runtime.ts

@@ -404,8 +404,6 @@ export interface HostConfigAiAssistancePerformanceAgent {
   temperature: number;
   enabled: boolean;
   userTier: string;
-  // Introduced in crrev.com/c/6243415
-  insightsEnabled?: boolean;
   featureName?: string;
 }
 

package/front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -1,7 +1,7 @@
 // Copyright 2023 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';