chrome-devtools-frontend 1.0.1532228 → 1.0.1533544

package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/prefer-private-class-members */
+/* eslint-disable @devtools/prefer-private-class-members */
 
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';

package/front_end/entrypoints/inspector_main/OutermostTargetSelector.ts

@@ -1,7 +1,7 @@
 // Copyright 2023 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import type * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/entrypoints/inspector_main/RenderingOptions.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';

package/front_end/entrypoints/main/MainImpl.ts

@@ -1,8 +1,8 @@
 // Copyright 2021 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
-/* eslint-disable rulesdir/no-lit-render-outside-of-view */
+/* eslint-disable @devtools/no-imperative-dom-api */
+/* eslint-disable @devtools/no-lit-render-outside-of-view */
 
 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
@@ -47,7 +47,6 @@ import * as Badges from '../../models/badges/badges.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import * as Breakpoints from '../../models/breakpoints/breakpoints.js';
 import * as CrUXManager from '../../models/crux-manager/crux-manager.js';
-import * as Extensions from '../../models/extensions/extensions.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import * as LiveMetrics from '../../models/live-metrics/live-metrics.js';
 import * as Logs from '../../models/logs/logs.js';
@@ -312,10 +311,6 @@ export class MainImpl {
     Root.Runtime.experiments.register('timeline-show-all-events', 'Performance panel: show all events', true);
     Root.Runtime.experiments.register(
         'timeline-v8-runtime-call-stats', 'Performance panel: V8 runtime call stats', true);
-    Root.Runtime.experiments.register(
-        'timeline-enhanced-traces', 'Performance panel: Enable collecting enhanced traces', true);
-    Root.Runtime.experiments.register(
-        'timeline-compiled-sources', 'Performance panel: Enable collecting source text for compiled script', true);
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.TIMELINE_DEBUG_MODE,
         'Performance panel: Enable debug mode (trace event details, etc)', true);
@@ -473,7 +468,7 @@ export class MainImpl {
       debuggerWorkspaceBinding: Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance(),
     });
     // @ts-expect-error e2e test global
-    self.Extensions.extensionServer = Extensions.ExtensionServer.ExtensionServer.instance({forceNew: true});
+    self.Extensions.extensionServer = PanelCommon.ExtensionServer.ExtensionServer.instance({forceNew: true});
 
     new Persistence.FileSystemWorkspaceBinding.FileSystemWorkspaceBinding(
         isolatedFileSystemManager, Workspace.Workspace.WorkspaceImpl.instance());
@@ -656,7 +651,7 @@ export class MainImpl {
 
   async #lateInitialization(): Promise<void> {
     MainImpl.time('Main._lateInitialization');
-    Extensions.ExtensionServer.ExtensionServer.instance().initializeExtensions();
+    PanelCommon.ExtensionServer.ExtensionServer.instance().initializeExtensions();
     const promises: Array<Promise<void>> =
         Common.Runnable.lateInitializationRunnables().map(async lateInitializationLoader => {
           const runnable = await lateInitializationLoader();

package/front_end/entrypoints/node_app/NodeConnectionsPanel.ts

@@ -1,7 +1,7 @@
 // Copyright 2015 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import type * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';

package/front_end/entrypoints/node_app/NodeMain.ts

@@ -146,7 +146,7 @@ export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implemen
   }
 }
 
-export class NodeConnection implements ProtocolClient.InspectorBackend.Connection {
+export class NodeConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   readonly #targetAgent: ProtocolProxyApi.TargetApi;
   readonly #sessionId: Protocol.Target.SessionID;
   onMessage: ((arg0: Object|string) => void)|null;

package/front_end/entrypoints/node_app/node_app.ts

@@ -13,8 +13,8 @@ import type * as Sources from '../../panels/sources/sources.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as Main from '../main/main.js';
 
-import {NodeConnectionsPanel} from './NodeConnectionsPanel.js';  // eslint-disable-line rulesdir/es-modules-import
-import {NodeMainImpl} from './NodeMain.js';                      // eslint-disable-line rulesdir/es-modules-import
+import {NodeConnectionsPanel} from './NodeConnectionsPanel.js';  // eslint-disable-line @devtools/es-modules-import
+import {NodeMainImpl} from './NodeMain.js';                      // eslint-disable-line @devtools/es-modules-import
 
 const UIStrings = {
   /**

package/front_end/generated/InspectorBackendCommands.js

@@ -839,10 +839,6 @@ inspectorBackend.registerEvent("Network.responseReceivedEarlyHints", ["requestId
 inspectorBackend.registerEnum("Network.TrustTokenOperationDoneEventStatus", {Ok: "Ok", InvalidArgument: "InvalidArgument", MissingIssuerKeys: "MissingIssuerKeys", FailedPrecondition: "FailedPrecondition", ResourceExhausted: "ResourceExhausted", AlreadyExists: "AlreadyExists", ResourceLimited: "ResourceLimited", Unauthorized: "Unauthorized", BadResponse: "BadResponse", InternalError: "InternalError", UnknownError: "UnknownError", FulfilledLocally: "FulfilledLocally", SiteIssuerLimit: "SiteIssuerLimit"});
 inspectorBackend.registerEvent("Network.trustTokenOperationDone", ["status", "type", "requestId", "topLevelOrigin", "issuerOrigin", "issuedTokenCount"]);
 inspectorBackend.registerEvent("Network.policyUpdated", []);
-inspectorBackend.registerEvent("Network.subresourceWebBundleMetadataReceived", ["requestId", "urls"]);
-inspectorBackend.registerEvent("Network.subresourceWebBundleMetadataError", ["requestId", "errorMessage"]);
-inspectorBackend.registerEvent("Network.subresourceWebBundleInnerResponseParsed", ["innerRequestId", "innerRequestURL", "bundleRequestId"]);
-inspectorBackend.registerEvent("Network.subresourceWebBundleInnerResponseError", ["innerRequestId", "innerRequestURL", "errorMessage", "bundleRequestId"]);
 inspectorBackend.registerEvent("Network.reportingApiReportAdded", ["report"]);
 inspectorBackend.registerEvent("Network.reportingApiReportUpdated", ["report"]);
 inspectorBackend.registerEvent("Network.reportingApiEndpointsChangedForOrigin", ["origin", "endpoints"]);

package/front_end/generated/protocol-mapping.d.ts

@@ -427,24 +427,6 @@ export namespace ProtocolMapping {
      * Fired once security policy has been updated.
      */
     'Network.policyUpdated': [];
-    /**
-     * Fired once when parsing the .wbn file has succeeded.
-     * The event contains the information about the web bundle contents.
-     */
-    'Network.subresourceWebBundleMetadataReceived': [Protocol.Network.SubresourceWebBundleMetadataReceivedEvent];
-    /**
-     * Fired once when parsing the .wbn file has failed.
-     */
-    'Network.subresourceWebBundleMetadataError': [Protocol.Network.SubresourceWebBundleMetadataErrorEvent];
-    /**
-     * Fired when handling requests for resources within a .wbn file.
-     * Note: this will only be fired for resources that are requested by the webpage.
-     */
-    'Network.subresourceWebBundleInnerResponseParsed': [Protocol.Network.SubresourceWebBundleInnerResponseParsedEvent];
-    /**
-     * Fired when request for resources within a .wbn file failed.
-     */
-    'Network.subresourceWebBundleInnerResponseError': [Protocol.Network.SubresourceWebBundleInnerResponseErrorEvent];
     /**
      * Is sent whenever a new report is added.
      * And after 'enableReportingApi' for all existing reports.

package/front_end/generated/protocol-proxy-api.d.ts

@@ -2873,28 +2873,6 @@ declare namespace ProtocolProxyApi {
      */
     policyUpdated(): void;
 
-    /**
-     * Fired once when parsing the .wbn file has succeeded.
-     * The event contains the information about the web bundle contents.
-     */
-    subresourceWebBundleMetadataReceived(params: Protocol.Network.SubresourceWebBundleMetadataReceivedEvent): void;
-
-    /**
-     * Fired once when parsing the .wbn file has failed.
-     */
-    subresourceWebBundleMetadataError(params: Protocol.Network.SubresourceWebBundleMetadataErrorEvent): void;
-
-    /**
-     * Fired when handling requests for resources within a .wbn file.
-     * Note: this will only be fired for resources that are requested by the webpage.
-     */
-    subresourceWebBundleInnerResponseParsed(params: Protocol.Network.SubresourceWebBundleInnerResponseParsedEvent): void;
-
-    /**
-     * Fired when request for resources within a .wbn file failed.
-     */
-    subresourceWebBundleInnerResponseError(params: Protocol.Network.SubresourceWebBundleInnerResponseErrorEvent): void;
-
     /**
      * Is sent whenever a new report is added.
      * And after 'enableReportingApi' for all existing reports.

package/front_end/generated/protocol.ts

@@ -12596,80 +12596,6 @@ export namespace Network {
     issuedTokenCount?: integer;
   }
 
-  /**
-   * Fired once when parsing the .wbn file has succeeded.
-   * The event contains the information about the web bundle contents.
-   */
-  export interface SubresourceWebBundleMetadataReceivedEvent {
-    /**
-     * Request identifier. Used to match this information to another event.
-     */
-    requestId: RequestId;
-    /**
-     * A list of URLs of resources in the subresource Web Bundle.
-     */
-    urls: string[];
-  }
-
-  /**
-   * Fired once when parsing the .wbn file has failed.
-   */
-  export interface SubresourceWebBundleMetadataErrorEvent {
-    /**
-     * Request identifier. Used to match this information to another event.
-     */
-    requestId: RequestId;
-    /**
-     * Error message
-     */
-    errorMessage: string;
-  }
-
-  /**
-   * Fired when handling requests for resources within a .wbn file.
-   * Note: this will only be fired for resources that are requested by the webpage.
-   */
-  export interface SubresourceWebBundleInnerResponseParsedEvent {
-    /**
-     * Request identifier of the subresource request
-     */
-    innerRequestId: RequestId;
-    /**
-     * URL of the subresource resource.
-     */
-    innerRequestURL: string;
-    /**
-     * Bundle request identifier. Used to match this information to another event.
-     * This made be absent in case when the instrumentation was enabled only
-     * after webbundle was parsed.
-     */
-    bundleRequestId?: RequestId;
-  }
-
-  /**
-   * Fired when request for resources within a .wbn file failed.
-   */
-  export interface SubresourceWebBundleInnerResponseErrorEvent {
-    /**
-     * Request identifier of the subresource request
-     */
-    innerRequestId: RequestId;
-    /**
-     * URL of the subresource resource.
-     */
-    innerRequestURL: string;
-    /**
-     * Error message
-     */
-    errorMessage: string;
-    /**
-     * Bundle request identifier. Used to match this information to another event.
-     * This made be absent in case when the instrumentation was enabled only
-     * after webbundle was parsed.
-     */
-    bundleRequestId?: RequestId;
-  }
-
   /**
    * Is sent whenever a new report is added.
    * And after 'enableReportingApi' for all existing reports.

package/front_end/global_typings/global_defs.d.ts

@@ -12,6 +12,22 @@ declare module '*.css.js' {
   export default styles;
 }
 
+// TODO: remove once URLPattern types are available in TypeScript (see https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1199).
+declare class URLPattern {
+  constructor(input: string);
+  hash: string;
+  hostname: string;
+  password: string;
+  pathname: string;
+  port: string;
+  protocol: string;
+  search: string;
+  username: string;
+  hasRegExpGroups: boolean;
+  test(url: string): boolean;
+  prototype: URLPattern;
+}
+
 // [start] Types for the Scheduler API.
 // These are taken from
 // https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/wicg-task-scheduling

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -185,7 +185,7 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
   override getTitle(): string {
     const focus = this.#focus;
 
-    let url = focus.insightSet?.url;
+    let url = focus.primaryInsightSet?.url;
     if (!url) {
       url = new URL(focus.parsedTrace.data.Meta.mainFrameURL);
     }
@@ -226,10 +226,11 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
     const suggestions: ConversationSuggestions =
         [{title: 'What performance issues exist with my page?', jslogContext: 'performance-default'}];
 
-    if (focus.insightSet) {
-      const lcp = focus.insightSet ? Trace.Insights.Common.getLCP(focus.insightSet) : null;
-      const cls = focus.insightSet ? Trace.Insights.Common.getCLS(focus.insightSet) : null;
-      const inp = focus.insightSet ? Trace.Insights.Common.getINP(focus.insightSet) : null;
+    const insightSet = focus.primaryInsightSet;
+    if (insightSet) {
+      const lcp = insightSet ? Trace.Insights.Common.getLCP(insightSet) : null;
+      const cls = insightSet ? Trace.Insights.Common.getCLS(insightSet) : null;
+      const inp = insightSet ? Trace.Insights.Common.getINP(insightSet) : null;
 
       const ModelHandlers = Trace.Handlers.ModelHandlers;
       const GOOD = Trace.Handlers.ModelHandlers.PageLoadMetrics.ScoreClassification.GOOD;
@@ -246,7 +247,7 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
 
       // Add up to 3 suggestions from the top failing insights.
       const top3FailingInsightSuggestions =
-          Object.values(focus.insightSet.model)
+          Object.values(insightSet.model)
               .filter(model => model.state !== 'pass')
               .map(model => new PerformanceInsightFormatter(focus, model).getSuggestions().at(-1))
               .filter(suggestion => !!suggestion)
@@ -625,7 +626,8 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
   #declareFunctions(context: PerformanceTraceContext): void {
     const focus = context.getItem();
-    const {parsedTrace, insightSet} = focus;
+    const {parsedTrace} = focus;
+    const insightSet = focus.primaryInsightSet;
 
     this.declareFunction<{insightName: string}, {details: string}>('getInsightDetails', {
       description:

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts

@@ -26,7 +26,7 @@ export class PerformanceTraceFormatter {
   constructor(focus: AgentFocus) {
     this.#focus = focus;
     this.#parsedTrace = focus.parsedTrace;
-    this.#insightSet = focus.insightSet;
+    this.#insightSet = focus.primaryInsightSet;
     this.#eventsSerializer = focus.eventsSerializer;
   }
 

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatterBounds.snapshot.txt

@@ -1,4 +1,4 @@
-Title: PerformanceTraceFormatter serializeBounds works
+Title: PerformanceTraceFormatterBounds serializeBounds works
 Content:
 {min: 1, max: 2}
 === end content

package/front_end/models/ai_assistance/injected.ts

@@ -9,7 +9,7 @@
  * They need remain isolated for importing other function so
  * bundling them for production does not create issues.
  */
-/* eslint-disable rulesdir/no-adopted-style-sheets --
+/* eslint-disable @devtools/no-adopted-style-sheets --
  * The scripts in this file aren't executed as part of DevTools front-end,
  * but are injected into the page.
  **/

package/front_end/models/ai_assistance/performance/AIContext.ts

@@ -8,7 +8,6 @@ import {AICallTree} from './AICallTree.js';
 
 interface AgentFocusData {
   parsedTrace: Trace.TraceModel.ParsedTrace;
-  insightSet: Trace.Insights.Types.InsightSet|null;
   /** Note: at most one of event or callTree is non-null. */
   event: Trace.Types.Events.Event|null;
   /** Note: at most one of event or callTree is non-null. */
@@ -22,11 +21,8 @@ interface AgentFocusData {
  * 2. If there are more, prefer the first we find that has a navigation associated with it.
  * 3. If none with a navigation are found, fallback to the first one.
  * 4. Otherwise, return null.
- *
- * TODO(cjamcl): we should just give the agent the entire insight set, and give
- * summary detail about all of them + the ability to query each.
  */
-function getFirstInsightSet(insights: Trace.Insights.Types.TraceInsightSets): Trace.Insights.Types.InsightSet|null {
+function getPrimaryInsightSet(insights: Trace.Insights.Types.TraceInsightSets): Trace.Insights.Types.InsightSet|null {
   const insightSets = Array.from(insights.values());
   if (insightSets.length === 0) {
     return null;
@@ -44,10 +40,8 @@ export class AgentFocus {
       throw new Error('missing insights');
     }
 
-    const insightSet = getFirstInsightSet(parsedTrace.insights);
     return new AgentFocus({
       parsedTrace,
-      insightSet,
       event: null,
       callTree: null,
       insight: null,
@@ -60,10 +54,8 @@ export class AgentFocus {
       throw new Error('missing insights');
     }
 
-    const insightSet = getFirstInsightSet(parsedTrace.insights);
     return new AgentFocus({
       parsedTrace,
-      insightSet,
       event: null,
       callTree: null,
       insight,
@@ -75,42 +67,33 @@ export class AgentFocus {
       throw new Error('missing insights');
     }
 
-    const insightSet = getFirstInsightSet(parsedTrace.insights);
     const result = AgentFocus.#getCallTreeOrEvent(parsedTrace, event);
-    return new AgentFocus({parsedTrace, insightSet, event: result.event, callTree: result.callTree, insight: null});
+    return new AgentFocus({parsedTrace, event: result.event, callTree: result.callTree, insight: null});
   }
 
   static fromCallTree(callTree: AICallTree): AgentFocus {
-    const insights = callTree.parsedTrace.insights;
-
-    // Select the insight set containing the call tree.
-    // If for some reason that fails, fallback to the first one.
-    let insightSet = null;
-    if (insights) {
-      const callTreeTimeRange = Trace.Helpers.Timing.traceWindowFromEvent(callTree.rootNode.event);
-      insightSet = insights.values().find(set => Trace.Helpers.Timing.boundsIncludeTimeRange({
-        timeRange: callTreeTimeRange,
-        bounds: set.bounds,
-      })) ??
-          getFirstInsightSet(insights);
-    }
-
-    return new AgentFocus({parsedTrace: callTree.parsedTrace, insightSet, event: null, callTree, insight: null});
+    return new AgentFocus({parsedTrace: callTree.parsedTrace, event: null, callTree, insight: null});
   }
 
   #data: AgentFocusData;
+  #primaryInsightSet: Trace.Insights.Types.InsightSet|null;
   readonly eventsSerializer = new Trace.EventsSerializer.EventsSerializer();
 
   constructor(data: AgentFocusData) {
+    if (!data.parsedTrace.insights) {
+      throw new Error('missing insights');
+    }
+
     this.#data = data;
+    this.#primaryInsightSet = getPrimaryInsightSet(data.parsedTrace.insights);
   }
 
   get parsedTrace(): Trace.TraceModel.ParsedTrace {
     return this.#data.parsedTrace;
   }
 
-  get insightSet(): Trace.Insights.Types.InsightSet|null {
-    return this.#data.insightSet;
+  get primaryInsightSet(): Trace.Insights.Types.InsightSet|null {
+    return this.#primaryInsightSet;
   }
 
   /** Note: at most one of event or callTree is non-null. */

package/front_end/models/bindings/CompilerScriptMapping.ts

@@ -5,7 +5,7 @@
 import * as Common from '../../core/common/common.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-// eslint-disable-next-line rulesdir/es-modules-import
+// eslint-disable-next-line @devtools/es-modules-import
 import * as StackTraceImpl from '../stack_trace/stack_trace_impl.js';
 import * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';

package/front_end/models/bindings/DebuggerWorkspaceBinding.ts

@@ -7,7 +7,7 @@ import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
 import type * as StackTrace from '../stack_trace/stack_trace.js';
-// eslint-disable-next-line rulesdir/es-modules-import
+// eslint-disable-next-line @devtools/es-modules-import
 import * as StackTraceImpl from '../stack_trace/stack_trace_impl.js';
 import type * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';

package/front_end/models/extensions/ExtensionAPI.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import type * as PublicAPI from '../../../extension-api/ExtensionAPI'; // eslint-disable-line rulesdir/es-modules-import
+import type * as PublicAPI from '../../../extension-api/ExtensionAPI.js';
 import type * as Platform from '../../core/platform/platform.js';
 import type * as HAR from '../har/har.js';
 

package/front_end/models/extensions/extensions.ts

@@ -4,9 +4,6 @@
 
 import * as ExtensionAPI from './ExtensionAPI.js';
 import * as ExtensionEndpoint from './ExtensionEndpoint.js';
-import * as ExtensionPanel from './ExtensionPanel.js';
-import * as ExtensionServer from './ExtensionServer.js';
-import * as ExtensionView from './ExtensionView.js';
 import * as HostUrlPattern from './HostUrlPattern.js';
 import * as LanguageExtensionEndpoint from './LanguageExtensionEndpoint.js';
 import * as RecorderExtensionEndpoint from './RecorderExtensionEndpoint.js';
@@ -15,9 +12,6 @@ import * as RecorderPluginManager from './RecorderPluginManager.js';
 export {
   ExtensionAPI,
   ExtensionEndpoint,
-  ExtensionPanel,
-  ExtensionServer,
-  ExtensionView,
   HostUrlPattern,
   LanguageExtensionEndpoint,
   RecorderExtensionEndpoint,

package/front_end/models/formatter/FormatterWorkerPool.ts

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 import * as Common from '../../core/common/common.js';
-import * as FormatterActions from '../../entrypoints/formatter_worker/FormatterActions.js';  // eslint-disable-line rulesdir/es-modules-import
+import * as FormatterActions from '../../entrypoints/formatter_worker/FormatterActions.js';  // eslint-disable-line @devtools/es-modules-import
 
 export {DefinitionKind, ScopeKind, type ScopeTreeNode} from '../../entrypoints/formatter_worker/FormatterActions.js';
 

package/front_end/models/issues_manager/DeprecationIssue.ts

@@ -29,7 +29,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/issues_manager/DeprecationIssue.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
-// eslint-disable-next-line rulesdir/l10n-filename-matches
+// eslint-disable-next-line @devtools/l10n-filename-matches
 const strDeprecation = i18n.i18n.registerUIStrings('generated/Deprecation.ts', Deprecation.UIStrings);
 const i18nLazyDeprecationString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, strDeprecation);
 

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -9095,6 +9095,10 @@ export const NativeFunctions = [
     name: "copyExternalImageToTexture",
     signatures: [["source","destination","copySize"]]
   },
+  {
+    name: "copyElementImageToTexture",
+    signatures: [["source","destination"]]
+  },
   {
     name: "setIndexBuffer",
     signatures: [["buffer","format","?offset","?size"]]
@@ -9331,6 +9335,10 @@ export const NativeFunctions = [
     name: "requestSession",
     signatures: [["mode","?options"]]
   },
+  {
+    name: "XRVisibilityMaskChangeEvent",
+    signatures: [["type","eventInitDict"]]
+  },
   {
     name: "XRWebGLLayer",
     signatures: [["session","context","?layerInit"]]

package/front_end/models/stack_trace/StackTraceModel.ts

@@ -5,7 +5,7 @@
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 
-// eslint-disable-next-line rulesdir/es-modules-import
+// eslint-disable-next-line @devtools/es-modules-import
 import * as StackTrace from './stack_trace.js';
 import {AsyncFragmentImpl, FragmentImpl, FrameImpl, StackTraceImpl} from './StackTraceImpl.js';
 import {type FrameNode, type RawFrame, Trie} from './Trie.js';

package/front_end/models/trace/extras/TraceTree.ts

@@ -397,6 +397,7 @@ export class BottomUpRootNode extends Node {
     const root = this;
     const startTime = this.startTime;
     const endTime = this.endTime;
+    const idStack: string[] = [];
     const nodeById = new Map<string, Node>();
     const selfTimeStack: number[] = [endTime - startTime];
     const firstNodeStack: boolean[] = [];
@@ -460,6 +461,13 @@ export class BottomUpRootNode extends Node {
       if (forceGroupIdCallback && eventGroupIdCallback) {
         id = `${id}-${eventGroupIdCallback(e)}`;
       }
+
+      idStack.push(id);
+
+      // For an event 'X' that contains another event 'X' (resolving to the same node
+      // id), we need to measure `totalTime` from the start of the outermost 'X' to
+      // its corresponding end. This logic ensures we don't double-count the duration
+      // of the inner event.
       const noNodeOnStack = !totalTimeById.has(id);
       if (noNodeOnStack) {
         totalTimeById.set(id, duration);
@@ -468,10 +476,11 @@ export class BottomUpRootNode extends Node {
     }
 
     function onEndEvent(event: Types.Events.Event): void {
-      let id = generateEventID(event);
-      if (forceGroupIdCallback && eventGroupIdCallback) {
-        id = `${id}-${eventGroupIdCallback(event)}`;
+      const id = idStack.pop();
+      if (!id) {
+        return;
       }
+
       let node = nodeById.get(id);
       if (!node) {
         node = new BottomUpNode(root, id, event, false, root);
@@ -484,6 +493,7 @@ export class BottomUpRootNode extends Node {
         node.totalTime += totalTimeById.get(id) || 0;
         totalTimeById.delete(id);
       }
+      // TODO: this may be wrong. See the skipped test in TraceTree.test.ts.
       if (firstNodeStack.length) {
         node.setHasChildren(true);
       }

package/front_end/models/trace/lantern/testing/MetricTestUtils.ts

@@ -4,7 +4,7 @@
 
 // Unsure why this lint is failing, given `lantern/metrics/SpeedIndex.test.ts` does the same
 // and is fine. Maybe `*.test.*` files are excluded from this rule?
-// eslint-disable-next-line rulesdir/es-modules-import
+// eslint-disable-next-line @devtools/es-modules-import
 import * as TraceLoader from '../../../../testing/TraceLoader.js';
 import * as Trace from '../../trace.js';
 import * as Lantern from '../lantern.js';

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts

@@ -1,7 +1,7 @@
 // Copyright 2016 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';

package/front_end/panels/accessibility/AccessibilityNodeView.ts

@@ -1,7 +1,7 @@
 // Copyright 2016 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/panels/accessibility/AccessibilitySidebarView.ts

@@ -1,7 +1,7 @@
 // Copyright 2015 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-/* eslint-disable rulesdir/no-imperative-dom-api */
+/* eslint-disable @devtools/no-imperative-dom-api */
 
 import type * as Common from '../../core/common/common.js';
 import * as Root from '../../core/root/root.js';