chrome-devtools-frontend 1.0.1532228 → 1.0.1532884

package/AUTHORS

@@ -81,6 +81,7 @@ Ross Wollman <ross.wollman@gmail.com>
 Royi Hagigi <rhagigi@gmail.com>
 Ryan Puhalovich <reanpuhalovich@gmail.com>
 Ryuhei Shima <shimaryuhei@gmail.com>
+Samuel Maddock <samuelmaddock@electronjs.org>
 Satvic Dhawan <satvicdhawan14@gmail.com>
 Sebastian Markbåge <sebastian@calyptus.eu>
 Serg Kryvonos <sergeikrivonos@gmail.com>

package/front_end/core/platform/ArrayUtilities.ts

@@ -22,7 +22,7 @@ export const removeElement = <T>(array: T[], element: T, firstOnly?: boolean): b
 
 type NumberComparator = (a: number, b: number) => number;
 
-function swap(array: number[], i1: number, i2: number): void {
+export function swap<T>(array: T[], i1: number, i2: number): void {
   const temp = array[i1];
   array[i1] = array[i2];
   array[i2] = temp;

package/front_end/core/protocol_client/ConnectionTransport.ts

@@ -0,0 +1,26 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+let connectionFactory: () => ConnectionTransport;
+
+export abstract class ConnectionTransport {
+  declare onMessage: ((arg0: Object) => void)|null;
+
+  // on message from browser
+  abstract setOnMessage(onMessage: (arg0: Object|string) => void): void;
+  abstract setOnDisconnect(onDisconnect: (arg0: string) => void): void;
+
+  // send raw CDP message to browser
+  abstract sendRawMessage(message: string): void;
+
+  abstract disconnect(): Promise<void>;
+
+  static setFactory(factory: () => ConnectionTransport): void {
+    connectionFactory = factory;
+  }
+
+  static getFactory(): () => ConnectionTransport {
+    return connectionFactory;
+  }
+}

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -7,6 +7,7 @@ import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import type * as Protocol from '../../generated/protocol.js';
 import type * as Platform from '../platform/platform.js';
 
+import {ConnectionTransport} from './ConnectionTransport.js';
 import {NodeURL} from './NodeURL.js';
 
 export const DevToolsStubErrorCode = -32015;
@@ -160,35 +161,6 @@ export class InspectorBackend {
   }
 }
 
-let connectionFactory: () => Connection;
-
-export class Connection {
-  declare onMessage: ((arg0: Object) => void)|null;
-
-  // on message from browser
-  setOnMessage(_onMessage: (arg0: Object|string) => void): void {
-  }
-
-  setOnDisconnect(_onDisconnect: (arg0: string) => void): void {
-  }
-
-  // send raw CDP message to browser
-  sendRawMessage(_message: string): void {
-  }
-
-  disconnect(): Promise<void> {
-    throw new Error('not implemented');
-  }
-
-  static setFactory(factory: () => Connection): void {
-    connectionFactory = factory;
-  }
-
-  static getFactory(): () => Connection {
-    return connectionFactory;
-  }
-}
-
 type SendRawMessageCallback = (...args: unknown[]) => void;
 
 export const test = {
@@ -232,18 +204,18 @@ export const test = {
 const LongPollingMethods = new Set<string>(['CSS.takeComputedStyleUpdates']);
 
 export class SessionRouter {
-  readonly #connection: Connection;
+  readonly #connection: ConnectionTransport;
   #lastMessageId = 1;
   #pendingResponsesCount = 0;
   readonly #pendingLongPollingMessageIds = new Set<number>();
   readonly #sessions = new Map<string, {
     target: TargetBase,
     callbacks: Map<number, CallbackWithDebugInfo>,
-    proxyConnection: Connection|undefined|null,
+    proxyConnection: ConnectionTransport|undefined|null,
   }>();
   #pendingScripts: Array<() => void> = [];
 
-  constructor(connection: Connection) {
+  constructor(connection: ConnectionTransport) {
     this.#connection = connection;
 
     test.deprecatedRunAfterPendingDispatches = this.deprecatedRunAfterPendingDispatches.bind(this);
@@ -259,7 +231,7 @@ export class SessionRouter {
     });
   }
 
-  registerSession(target: TargetBase, sessionId: string, proxyConnection?: Connection|null): void {
+  registerSession(target: TargetBase, sessionId: string, proxyConnection?: ConnectionTransport|null): void {
     // Only the Audits panel uses proxy connections. If it is ever possible to have multiple active at the
     // same time, it should be tested thoroughly.
     if (proxyConnection) {
@@ -297,7 +269,7 @@ export class SessionRouter {
     return this.#lastMessageId++;
   }
 
-  connection(): Connection {
+  connection(): ConnectionTransport {
     return this.#connection;
   }
 
@@ -497,7 +469,8 @@ export class TargetBase {
   #dispatchers: DispatcherMap = new Map();
 
   constructor(
-      needsNodeJSPatching: boolean, parentTarget: TargetBase|null, sessionId: string, connection: Connection|null) {
+      needsNodeJSPatching: boolean, parentTarget: TargetBase|null, sessionId: string,
+      connection: ConnectionTransport|null) {
     this.needsNodeJSPatching = needsNodeJSPatching;
     this.sessionId = sessionId;
 
@@ -511,7 +484,7 @@ export class TargetBase {
     } else if (connection) {
       router = new SessionRouter(connection);
     } else {
-      router = new SessionRouter(connectionFactory());
+      router = new SessionRouter(ConnectionTransport.getFactory()());
     }
 
     this.#router = router;

package/front_end/core/protocol_client/protocol_client.ts

@@ -2,10 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as ConnectionTransport from './ConnectionTransport.js';
 import * as InspectorBackend from './InspectorBackend.js';
 import * as NodeURL from './NodeURL.js';
 
 export {
+  ConnectionTransport,
   InspectorBackend,
   NodeURL,
 };

package/front_end/core/root/Runtime.ts

@@ -343,8 +343,6 @@ export const enum ExperimentName {
   USE_SOURCE_MAP_SCOPES = 'use-source-map-scopes',
   TIMELINE_SHOW_POST_MESSAGE_EVENTS = 'timeline-show-postmessage-events',
   TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
-  TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',
-  TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
   // Adding or removing an entry from this enum?
   // You will need to update:
   // 1. REGISTERED_EXPERIMENTS in EnvironmentHelpers.ts (to create this experiment in the test env)

package/front_end/core/sdk/ChildTargetManager.ts

@@ -36,7 +36,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   readonly #targetInfos = new Map<Protocol.Target.TargetID, Protocol.Target.TargetInfo>();
   readonly #childTargetsBySessionId = new Map<Protocol.Target.SessionID, Target>();
   readonly #childTargetsById = new Map<Protocol.Target.TargetID|'main', Target>();
-  readonly #parallelConnections = new Map<string, ProtocolClient.InspectorBackend.Connection>();
+  readonly #parallelConnections = new Map<string, ProtocolClient.ConnectionTransport.ConnectionTransport>();
   #parentTargetId: Protocol.Target.TargetID|null = null;
 
   constructor(parentTarget: Target) {
@@ -261,7 +261,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   }
 
   async createParallelConnection(onMessage: (arg0: Object|string) => void):
-      Promise<{connection: ProtocolClient.InspectorBackend.Connection, sessionId: string}> {
+      Promise<{connection: ProtocolClient.ConnectionTransport.ConnectionTransport, sessionId: string}> {
     // The main Target id is actually just `main`, instead of the real targetId.
     // Get the real id (requires an async operation) so that it can be used synchronously later.
     const targetId = await this.getParentTargetId();
@@ -274,7 +274,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
 
   private async createParallelConnectionAndSessionForTarget(target: Target, targetId: Protocol.Target.TargetID):
       Promise<{
-        connection: ProtocolClient.InspectorBackend.Connection,
+        connection: ProtocolClient.ConnectionTransport.ConnectionTransport,
         sessionId: string,
       }> {
     const targetAgent = target.targetAgent();

package/front_end/core/sdk/Connections.ts

@@ -19,7 +19,7 @@ const UIStrings = {
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/Connections.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-export class MainConnection implements ProtocolClient.InspectorBackend.Connection {
+export class MainConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
   #messageBuffer = '';
@@ -81,7 +81,7 @@ export class MainConnection implements ProtocolClient.InspectorBackend.Connectio
   }
 }
 
-export class WebSocketConnection implements ProtocolClient.InspectorBackend.Connection {
+export class WebSocketConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   #socket: WebSocket|null;
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
@@ -176,7 +176,7 @@ export class WebSocketConnection implements ProtocolClient.InspectorBackend.Conn
   }
 }
 
-export class StubConnection implements ProtocolClient.InspectorBackend.Connection {
+export class StubConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
 
@@ -213,17 +213,17 @@ export class StubConnection implements ProtocolClient.InspectorBackend.Connectio
   }
 }
 
-export interface ParallelConnectionInterface extends ProtocolClient.InspectorBackend.Connection {
+export interface ParallelConnectionInterface extends ProtocolClient.ConnectionTransport.ConnectionTransport {
   getSessionId: () => string;
   getOnDisconnect: () => ((arg0: string) => void) | null;
 }
 
 export class ParallelConnection implements ParallelConnectionInterface {
-  readonly #connection: ProtocolClient.InspectorBackend.Connection;
+  readonly #connection: ProtocolClient.ConnectionTransport.ConnectionTransport;
   #sessionId: string;
   onMessage: ((arg0: Object) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
-  constructor(connection: ProtocolClient.InspectorBackend.Connection, sessionId: string) {
+  constructor(connection: ProtocolClient.ConnectionTransport.ConnectionTransport, sessionId: string) {
     this.#connection = connection;
     this.#sessionId = sessionId;
   }
@@ -265,13 +265,13 @@ export class ParallelConnection implements ParallelConnectionInterface {
 export async function initMainConnection(
     createRootTarget: () => Promise<void>,
     onConnectionLost: (message: Platform.UIString.LocalizedString) => void): Promise<void> {
-  ProtocolClient.InspectorBackend.Connection.setFactory(createMainConnection.bind(null, onConnectionLost));
+  ProtocolClient.ConnectionTransport.ConnectionTransport.setFactory(createMainConnection.bind(null, onConnectionLost));
   await createRootTarget();
   Host.InspectorFrontendHost.InspectorFrontendHostInstance.connectionReady();
 }
 
 function createMainConnection(onConnectionLost: (message: Platform.UIString.LocalizedString) => void):
-    ProtocolClient.InspectorBackend.Connection {
+    ProtocolClient.ConnectionTransport.ConnectionTransport {
   if (Root.Runtime.Runtime.isTraceApp()) {
     return new RehydratingConnection(onConnectionLost);
   }

package/front_end/core/sdk/NetworkManager.ts

@@ -1817,6 +1817,26 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
     this.#conditionsChanged();
   }
 
+  decreasePriority(condition: RequestCondition): void {
+    const index = this.#conditions.indexOf(condition);
+    if (index < 0 || index >= this.#conditions.length - 1) {
+      return;
+    }
+
+    Platform.ArrayUtilities.swap(this.#conditions, index, index + 1);
+    this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
+  }
+
+  increasePriority(condition: RequestCondition): void {
+    const index = this.#conditions.indexOf(condition);
+    if (index <= 0) {
+      return;
+    }
+
+    Platform.ArrayUtilities.swap(this.#conditions, index - 1, index);
+    this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
+  }
+
   delete(condition: RequestCondition): void {
     const index = this.#conditions.indexOf(condition);
     if (index < 0) {

package/front_end/core/sdk/RehydratingConnection.ts

@@ -63,7 +63,7 @@ export const enum RehydratingConnectionState {
   REHYDRATED = 3,
 }
 
-export class RehydratingConnection implements ProtocolClient.InspectorBackend.Connection {
+export class RehydratingConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   rehydratingConnectionState: RehydratingConnectionState = RehydratingConnectionState.UNINITIALIZED;
   onDisconnect: ((arg0: string) => void)|null = null;
   onMessage: ((arg0: Object) => void)|null = null;
@@ -106,11 +106,13 @@ export class RehydratingConnection implements ProtocolClient.InspectorBackend.Co
 
   #setupMessagePassing(): void {
     this.#rehydratingWindow.addEventListener('message', this.#onReceiveHostWindowPayloadBound);
-    if (!this.#rehydratingWindow.opener) {
+    if (this.#rehydratingWindow.opener) {
+      this.#rehydratingWindow.opener.postMessage({type: 'REHYDRATING_WINDOW_READY'});
+    } else if (this.#rehydratingWindow !== window.top) {
+      this.#rehydratingWindow.parent.postMessage({type: 'REHYDRATING_IFRAME_READY'});
+    } else {
       this.#onConnectionLost(i18nString(UIStrings.noHostWindow));
-      return;
     }
-    this.#rehydratingWindow.opener.postMessage({type: 'REHYDRATING_WINDOW_READY'});
   }
 
   /**

package/front_end/core/sdk/Target.ts

@@ -39,7 +39,8 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
   constructor(
       targetManager: TargetManager, id: Protocol.Target.TargetID|'main', name: string, type: Type,
       parentTarget: Target|null, sessionId: string, suspended: boolean,
-      connection: ProtocolClient.InspectorBackend.Connection|null, targetInfo?: Protocol.Target.TargetInfo) {
+      connection: ProtocolClient.ConnectionTransport.ConnectionTransport|null,
+      targetInfo?: Protocol.Target.TargetInfo) {
     const needsNodeJSPatching = type === Type.NODE;
     super(needsNodeJSPatching, parentTarget, sessionId, connection);
     this.#targetManager = targetManager;

package/front_end/core/sdk/TargetManager.ts

@@ -209,7 +209,8 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
 
   createTarget(
       id: Protocol.Target.TargetID|'main', name: string, type: TargetType, parentTarget: Target|null,
-      sessionId?: string, waitForDebuggerInPage?: boolean, connection?: ProtocolClient.InspectorBackend.Connection,
+      sessionId?: string, waitForDebuggerInPage?: boolean,
+      connection?: ProtocolClient.ConnectionTransport.ConnectionTransport,
       targetInfo?: Protocol.Target.TargetInfo): Target {
     const target = new Target(
         this, id, name, type, parentTarget, sessionId || '', this.#isSuspended, connection || null, targetInfo);

package/front_end/entrypoints/node_app/NodeMain.ts

@@ -146,7 +146,7 @@ export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implemen
   }
 }
 
-export class NodeConnection implements ProtocolClient.InspectorBackend.Connection {
+export class NodeConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   readonly #targetAgent: ProtocolProxyApi.TargetApi;
   readonly #sessionId: Protocol.Target.SessionID;
   onMessage: ((arg0: Object|string) => void)|null;

package/front_end/models/trace/extras/TraceTree.ts

@@ -397,6 +397,7 @@ export class BottomUpRootNode extends Node {
     const root = this;
     const startTime = this.startTime;
     const endTime = this.endTime;
+    const idStack: string[] = [];
     const nodeById = new Map<string, Node>();
     const selfTimeStack: number[] = [endTime - startTime];
     const firstNodeStack: boolean[] = [];
@@ -460,6 +461,13 @@ export class BottomUpRootNode extends Node {
       if (forceGroupIdCallback && eventGroupIdCallback) {
         id = `${id}-${eventGroupIdCallback(e)}`;
       }
+
+      idStack.push(id);
+
+      // For an event 'X' that contains another event 'X' (resolving to the same node
+      // id), we need to measure `totalTime` from the start of the outermost 'X' to
+      // its corresponding end. This logic ensures we don't double-count the duration
+      // of the inner event.
       const noNodeOnStack = !totalTimeById.has(id);
       if (noNodeOnStack) {
         totalTimeById.set(id, duration);
@@ -468,10 +476,11 @@ export class BottomUpRootNode extends Node {
     }
 
     function onEndEvent(event: Types.Events.Event): void {
-      let id = generateEventID(event);
-      if (forceGroupIdCallback && eventGroupIdCallback) {
-        id = `${id}-${eventGroupIdCallback(event)}`;
+      const id = idStack.pop();
+      if (!id) {
+        return;
       }
+
       let node = nodeById.get(id);
       if (!node) {
         node = new BottomUpNode(root, id, event, false, root);
@@ -484,6 +493,7 @@ export class BottomUpRootNode extends Node {
         node.totalTime += totalTimeById.get(id) || 0;
         totalTimeById.delete(id);
       }
+      // TODO: this may be wrong. See the skipped test in TraceTree.test.ts.
       if (firstNodeStack.length) {
         node.setHasChildren(true);
       }

package/front_end/panels/console/ConsoleInsightTeaser.ts

@@ -115,51 +115,6 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
   }
 
   const showPlaceholder = !Boolean(input.mainText);
-  const renderFooter = (): Lit.LitTemplate => {
-    // clang-format off
-    return html`
-      <div class="tooltip-footer">
-        ${input.hasTellMeMoreButton ? html`
-          <devtools-button
-            title=${lockedString(UIStringsNotTranslate.tellMeMore)}
-            .jslogContext=${'insights-teaser-tell-me-more'},
-            .variant=${Buttons.Button.Variant.PRIMARY}
-            @click=${input.onTellMeMoreClick}
-          >
-            <devtools-icon class="lightbulb-icon" name="lightbulb-spark"></devtools-icon>
-            ${lockedString(UIStringsNotTranslate.tellMeMore)}
-          </devtools-button>
-        ` : Lit.nothing}
-        ${showPlaceholder ? Lit.nothing : html`
-          <devtools-button
-            .iconName=${'info'}
-            .variant=${Buttons.Button.Variant.ICON}
-            aria-details=${'teaser-info-tooltip-' + input.uuid}
-            aria-label=${lockedString(UIStringsNotTranslate.learnDataUsage)}
-          ></devtools-button>
-          <devtools-tooltip id=${'teaser-info-tooltip-' + input.uuid} variant="rich">
-            <div class="info-tooltip-text">${lockedString(UIStringsNotTranslate.infoTooltipText)}</div>
-            <div class="learn-more">
-              <x-link
-                class="devtools-link"
-                title=${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}
-                href=${DATA_USAGE_URL}
-                jslog=${VisualLogging.link().track({click: true, keydown:'Enter|Space'}).context('explain.teaser.learn-more')}
-              >${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}</x-link>
-            </div>
-          </devtools-tooltip>
-        `}
-        <devtools-checkbox
-          aria-label=${lockedString(UIStringsNotTranslate.dontShow)}
-          @change=${input.dontShowChanged}
-          jslog=${VisualLogging.toggle('explain.teaser.dont-show').track({ change: true })}>
-          ${lockedString(UIStringsNotTranslate.dontShow)}
-        </devtools-checkbox>
-      </div>
-    `;
-    // clang-format on
-  };
-
   // clang-format off
   render(html`
     <style>${consoleInsightTeaserStyles}</style>
@@ -185,7 +140,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
               class="loader"
               style="clip-path: url(${'#clipPath-' + input.uuid});"
             >
-              <svg width="100%" height="52">
+              <svg width="100%" height="58">
                 <defs>
                 <clipPath id=${'clipPath-' + input.uuid}>
                   <rect x="0" y="0" width="100%" height="12" rx="8"></rect>
@@ -197,10 +152,47 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: undefined, target: HTMLE
             </div>
           ` : html`
             <h2>${input.headerText}</h2>
-            <div>${input.mainText}</div>
+            <div class="main-text">${input.mainText}</div>
           `
         }
-        ${input.isError || input.isSlowGeneration || !showPlaceholder ? renderFooter() : Lit.nothing}
+        <div class="tooltip-footer">
+          ${input.hasTellMeMoreButton ? html`
+            <devtools-button
+              title=${lockedString(UIStringsNotTranslate.tellMeMore)}
+              .jslogContext=${'insights-teaser-tell-me-more'},
+              .variant=${Buttons.Button.Variant.PRIMARY}
+              @click=${input.onTellMeMoreClick}
+            >
+              <devtools-icon class="lightbulb-icon" name="lightbulb-spark"></devtools-icon>
+              ${lockedString(UIStringsNotTranslate.tellMeMore)}
+            </devtools-button>
+          ` : Lit.nothing}
+          ${showPlaceholder ? Lit.nothing : html`
+            <devtools-button
+              .iconName=${'info'}
+              .variant=${Buttons.Button.Variant.ICON}
+              aria-details=${'teaser-info-tooltip-' + input.uuid}
+              .accessibleLabel=${lockedString(UIStringsNotTranslate.learnDataUsage)}
+            ></devtools-button>
+            <devtools-tooltip id=${'teaser-info-tooltip-' + input.uuid} variant="rich">
+              <div class="info-tooltip-text">${lockedString(UIStringsNotTranslate.infoTooltipText)}</div>
+              <div class="learn-more">
+                <x-link
+                  class="devtools-link"
+                  title=${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}
+                  href=${DATA_USAGE_URL}
+                  jslog=${VisualLogging.link().track({click: true, keydown:'Enter|Space'}).context('explain.teaser.learn-more')}
+                >${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}</x-link>
+              </div>
+            </devtools-tooltip>
+          `}
+          <devtools-checkbox
+            aria-label=${lockedString(UIStringsNotTranslate.dontShow)}
+            @change=${input.dontShowChanged}
+            jslog=${VisualLogging.toggle('explain.teaser.dont-show').track({ change: true })}>
+            ${lockedString(UIStringsNotTranslate.dontShow)}
+          </devtools-checkbox>
+        </div>
       </div>
     </devtools-tooltip>
   `, target);

package/front_end/panels/console/consoleInsightTeaser.css

@@ -51,6 +51,19 @@
   h2 {
     font: var(--sys-typescale-body4-bold);
     margin: 0 0 var(--sys-size-3);
+    line-clamp: 1;
+    -webkit-line-clamp: 1;
+    display: -webkit-box;
+    -webkit-box-orient: vertical;
+    overflow: hidden;
+  }
+
+  .main-text {
+    line-clamp: 4;
+    -webkit-line-clamp: 4;
+    display: -webkit-box;
+    -webkit-box-orient: vertical;
+    overflow: hidden;
   }
 
   .lightbulb-icon {

package/front_end/panels/lighthouse/LighthousePanel.ts

@@ -328,7 +328,7 @@ export class LighthousePanel extends UI.Panel.Panel {
     this.reportSelector.prepend(optionElement);
     this.refreshToolbarUI();
     this.renderReport(lighthouseResult);
-    this.newButton.element.focus();
+    (this.auditResultsElement.querySelector('.lh-topbar__url') as HTMLElement | null)?.focus();
   }
 
   private handleDrop(dataTransfer: DataTransfer): void {

package/front_end/panels/lighthouse/LighthouseProtocolService.ts

@@ -60,7 +60,7 @@ export interface LighthouseRun {
 export class ProtocolService {
   private mainSessionId?: string;
   private rootTargetId?: string;
-  private parallelConnection?: ProtocolClient.InspectorBackend.Connection;
+  private parallelConnection?: ProtocolClient.ConnectionTransport.ConnectionTransport;
   private lighthouseWorkerPromise?: Promise<Worker>;
   private lighthouseMessageUpdateCallback?: ((arg0: string) => void);
   private removeDialogHandler?: () => void;

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -99,6 +99,14 @@ const UIStrings = {
    * @description Message to be announced for a when list item is removed from list widget
    */
   learnMore: 'Learn more',
+  /**
+   * @description Aria label on a button moving an entry up
+   */
+  increasePriority: 'Increase priority',
+  /**
+   * @description Aria label on a button moving an entry down
+   */
+  decreasePriority: 'Decrease priority',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/network/RequestConditionsDrawer.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -253,6 +261,18 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
     const {enabled, originalOrUpgradedURLPattern, constructorStringOrWildcardURL, wildcardURL} = condition;
 
     if (Root.Runtime.hostConfig.devToolsIndividualRequestThrottling?.enabled) {
+      const moveUp = (e: Event): void => {
+        if (this.manager.requestConditions.conditionsEnabled) {
+          e.consume(true);
+          this.manager.requestConditions.increasePriority(condition);
+        }
+      };
+      const moveDown = (e: Event): void => {
+        if (this.manager.requestConditions.conditionsEnabled) {
+          e.consume(true);
+          this.manager.requestConditions.decreasePriority(condition);
+        }
+      };
       render(
           // clang-format off
         html`
@@ -262,17 +282,19 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
       ?checked=${enabled}
       ?disabled=${!editable || !originalOrUpgradedURLPattern}
       .jslog=${VisualLogging.toggle().track({ change: true })}>
-    <devtools-widget
-      class=conditions-selector
-      ?disabled=${!editable}
-      .widgetConfig=${UI.Widget.widgetConfig(
-        MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelectorWidget, {
-          variant:
-            MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS,
-          jslogContext: 'request-conditions',
-          onConditionsChanged,
-          currentConditions: condition.conditions,
-        })}></devtools-widget>
+    <devtools-button
+      .iconName=${'arrow-down'}
+      .variant=${Buttons.Button.Variant.ICON}
+      .title=${i18nString(UIStrings.increasePriority)}
+      .jslogContext=${'increase-priority'}
+      @click=${moveDown}></devtools-button>
+    <devtools-button
+      .iconName=${'arrow-up'}
+      .variant=${Buttons.Button.Variant.ICON}
+      .title=${i18nString(UIStrings.decreasePriority)}
+      .jslogContext=${'decrease-priority'}
+      @click=${moveUp}>
+    </devtools-button>
     ${originalOrUpgradedURLPattern ? html`
       <devtools-tooltip variant=rich jslogcontext=url-pattern id=url-pattern-${index}>
         <div>hash: ${originalOrUpgradedURLPattern.hash}</div>
@@ -309,6 +331,17 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
       aria-details=url-pattern-${index}>
         ${constructorStringOrWildcardURL}
     </div>
+   <devtools-widget
+      class=conditions-selector
+      ?disabled=${!editable}
+      .widgetConfig=${UI.Widget.widgetConfig(
+        MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelectorWidget, {
+          variant:
+            MobileThrottling.NetworkThrottlingSelector.NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS,
+          jslogContext: 'request-conditions',
+          onConditionsChanged,
+          currentConditions: condition.conditions,
+        })}></devtools-widget>
     <div class=blocked-url-count>${i18nString(UIStrings.dBlocked, {PH1: count})}</div>`,
           // clang-format on
           element);