chrome-devtools-frontend 1.0.1531367 → 1.0.1532884

package/AUTHORS

@@ -65,6 +65,7 @@ Marijn Haverbeke <marijnh@gmail.com>
 Max 😎 Coplan <mchcopl@gmail.com>
 Michael Brüning <michael.bruning@qt.io>
 Michael Rienstra <mrienstra@gmail.com>
+Mostafa Aboalkasim <mostafa.aboalkasim.offical@gmail.com>
 Muhammad Mahad <mahadtxt@gmail.com>
 Naoto Ono <onoto1998@gmail.com>
 Paras Awasthi <awasthiparas6@gmail.com>
@@ -80,6 +81,7 @@ Ross Wollman <ross.wollman@gmail.com>
 Royi Hagigi <rhagigi@gmail.com>
 Ryan Puhalovich <reanpuhalovich@gmail.com>
 Ryuhei Shima <shimaryuhei@gmail.com>
+Samuel Maddock <samuelmaddock@electronjs.org>
 Satvic Dhawan <satvicdhawan14@gmail.com>
 Sebastian Markbåge <sebastian@calyptus.eu>
 Serg Kryvonos <sergeikrivonos@gmail.com>
@@ -93,6 +95,7 @@ Tony Kostowny <tonykostowny@gmail.com>
 Toshiaki Tanaka <zokutyou2@gmail.com>
 Tushar Singh <tusharvickey1999@gmail.com>
 Varun Varada <varuncvarada@gmail.com>
+Vishwa Kalubowila <vishwa.kalubowila@codimite.com>
 Vitali Zaidman <vzaidman@gmail.com>
 Will Hernandez <w.hernandez.code@gmail.com>
 Yeol Park <peary2@gmail.com>

package/front_end/core/platform/ArrayUtilities.ts

@@ -22,7 +22,7 @@ export const removeElement = <T>(array: T[], element: T, firstOnly?: boolean): b
 
 type NumberComparator = (a: number, b: number) => number;
 
-function swap(array: number[], i1: number, i2: number): void {
+export function swap<T>(array: T[], i1: number, i2: number): void {
   const temp = array[i1];
   array[i1] = array[i2];
   array[i2] = temp;

package/front_end/core/protocol_client/ConnectionTransport.ts

@@ -0,0 +1,26 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+let connectionFactory: () => ConnectionTransport;
+
+export abstract class ConnectionTransport {
+  declare onMessage: ((arg0: Object) => void)|null;
+
+  // on message from browser
+  abstract setOnMessage(onMessage: (arg0: Object|string) => void): void;
+  abstract setOnDisconnect(onDisconnect: (arg0: string) => void): void;
+
+  // send raw CDP message to browser
+  abstract sendRawMessage(message: string): void;
+
+  abstract disconnect(): Promise<void>;
+
+  static setFactory(factory: () => ConnectionTransport): void {
+    connectionFactory = factory;
+  }
+
+  static getFactory(): () => ConnectionTransport {
+    return connectionFactory;
+  }
+}

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -2,10 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as InspectorBackendCommands from '../../generated/InspectorBackendCommands.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import type * as Protocol from '../../generated/protocol.js';
 import type * as Platform from '../platform/platform.js';
 
+import {ConnectionTransport} from './ConnectionTransport.js';
 import {NodeURL} from './NodeURL.js';
 
 export const DevToolsStubErrorCode = -32015;
@@ -78,6 +80,15 @@ export class InspectorBackend {
   readonly typeMap = new Map<QualifiedName, CommandParameter[]>();
   readonly enumMap = new Map<QualifiedName, Record<string, string>>();
 
+  constructor() {
+    // Create the global here because registering commands will involve putting
+    // items onto the global.
+    // @ts-expect-error Global namespace instantiation
+    globalThis.Protocol ||= {};
+
+    InspectorBackendCommands.registerCommands(this);
+  }
+
   private getOrCreateEventParameterNamesForDomain(domain: ProtocolDomainName): EventParameterNames {
     let map = this.#eventParameterNamesForDomain.get(domain);
     if (!map) {
@@ -150,35 +161,6 @@ export class InspectorBackend {
   }
 }
 
-let connectionFactory: () => Connection;
-
-export class Connection {
-  declare onMessage: ((arg0: Object) => void)|null;
-
-  // on message from browser
-  setOnMessage(_onMessage: (arg0: Object|string) => void): void {
-  }
-
-  setOnDisconnect(_onDisconnect: (arg0: string) => void): void {
-  }
-
-  // send raw CDP message to browser
-  sendRawMessage(_message: string): void {
-  }
-
-  disconnect(): Promise<void> {
-    throw new Error('not implemented');
-  }
-
-  static setFactory(factory: () => Connection): void {
-    connectionFactory = factory;
-  }
-
-  static getFactory(): () => Connection {
-    return connectionFactory;
-  }
-}
-
 type SendRawMessageCallback = (...args: unknown[]) => void;
 
 export const test = {
@@ -222,18 +204,18 @@ export const test = {
 const LongPollingMethods = new Set<string>(['CSS.takeComputedStyleUpdates']);
 
 export class SessionRouter {
-  readonly #connection: Connection;
+  readonly #connection: ConnectionTransport;
   #lastMessageId = 1;
   #pendingResponsesCount = 0;
   readonly #pendingLongPollingMessageIds = new Set<number>();
   readonly #sessions = new Map<string, {
     target: TargetBase,
     callbacks: Map<number, CallbackWithDebugInfo>,
-    proxyConnection: Connection|undefined|null,
+    proxyConnection: ConnectionTransport|undefined|null,
   }>();
   #pendingScripts: Array<() => void> = [];
 
-  constructor(connection: Connection) {
+  constructor(connection: ConnectionTransport) {
     this.#connection = connection;
 
     test.deprecatedRunAfterPendingDispatches = this.deprecatedRunAfterPendingDispatches.bind(this);
@@ -249,7 +231,7 @@ export class SessionRouter {
     });
   }
 
-  registerSession(target: TargetBase, sessionId: string, proxyConnection?: Connection|null): void {
+  registerSession(target: TargetBase, sessionId: string, proxyConnection?: ConnectionTransport|null): void {
     // Only the Audits panel uses proxy connections. If it is ever possible to have multiple active at the
     // same time, it should be tested thoroughly.
     if (proxyConnection) {
@@ -287,7 +269,7 @@ export class SessionRouter {
     return this.#lastMessageId++;
   }
 
-  connection(): Connection {
+  connection(): ConnectionTransport {
     return this.#connection;
   }
 
@@ -367,9 +349,8 @@ export class SessionRouter {
     const sessionId = messageObject.sessionId || '';
     const session = this.#sessions.get(sessionId);
     if (!session) {
-      if (!suppressUnknownMessageErrors) {
-        InspectorBackend.reportProtocolError('Protocol Error: the message with wrong session id', messageObject);
-      }
+      // In the DevTools MCP case, we may share the transport with puppeteer so we silently
+      // ignore unknown sessions.
       return;
     }
 
@@ -488,21 +469,22 @@ export class TargetBase {
   #dispatchers: DispatcherMap = new Map();
 
   constructor(
-      needsNodeJSPatching: boolean, parentTarget: TargetBase|null, sessionId: string, connection: Connection|null) {
+      needsNodeJSPatching: boolean, parentTarget: TargetBase|null, sessionId: string,
+      connection: ConnectionTransport|null) {
     this.needsNodeJSPatching = needsNodeJSPatching;
     this.sessionId = sessionId;
 
-    if ((!parentTarget && connection) || (!parentTarget && sessionId) || (connection && sessionId)) {
-      throw new Error('Either connection or sessionId (but not both) must be supplied for a child target');
+    if (parentTarget && !sessionId) {
+      throw new Error('Specifying a parent target requires a session ID');
     }
 
     let router: SessionRouter;
-    if (sessionId && parentTarget && parentTarget.#router) {
+    if (parentTarget && parentTarget.#router) {
       router = parentTarget.#router;
     } else if (connection) {
       router = new SessionRouter(connection);
     } else {
-      router = new SessionRouter(connectionFactory());
+      router = new SessionRouter(ConnectionTransport.getFactory()());
     }
 
     this.#router = router;

package/front_end/core/protocol_client/protocol_client.ts

@@ -2,20 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as InspectorBackendCommands from '../../generated/InspectorBackendCommands.js';
-
+import * as ConnectionTransport from './ConnectionTransport.js';
 import * as InspectorBackend from './InspectorBackend.js';
 import * as NodeURL from './NodeURL.js';
 
 export {
+  ConnectionTransport,
   InspectorBackend,
   NodeURL,
 };
-
-// Create the global here because registering commands will involve putting
-// items onto the global.
-// @ts-expect-error Global namespace instantiation
-globalThis.Protocol = globalThis.Protocol || {};
-
-// FIXME: This instance of InspectorBackend should not be a side effect of importing this module.
-InspectorBackendCommands.registerCommands(InspectorBackend.inspectorBackend);

package/front_end/core/root/Runtime.ts

@@ -343,8 +343,6 @@ export const enum ExperimentName {
   USE_SOURCE_MAP_SCOPES = 'use-source-map-scopes',
   TIMELINE_SHOW_POST_MESSAGE_EVENTS = 'timeline-show-postmessage-events',
   TIMELINE_DEBUG_MODE = 'timeline-debug-mode',
-  TIMELINE_ENHANCED_TRACES = 'timeline-enhanced-traces',
-  TIMELINE_COMPILED_SOURCES = 'timeline-compiled-sources',
   // Adding or removing an entry from this enum?
   // You will need to update:
   // 1. REGISTERED_EXPERIMENTS in EnvironmentHelpers.ts (to create this experiment in the test env)

package/front_end/core/sdk/ChildTargetManager.ts

@@ -36,7 +36,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   readonly #targetInfos = new Map<Protocol.Target.TargetID, Protocol.Target.TargetInfo>();
   readonly #childTargetsBySessionId = new Map<Protocol.Target.SessionID, Target>();
   readonly #childTargetsById = new Map<Protocol.Target.TargetID|'main', Target>();
-  readonly #parallelConnections = new Map<string, ProtocolClient.InspectorBackend.Connection>();
+  readonly #parallelConnections = new Map<string, ProtocolClient.ConnectionTransport.ConnectionTransport>();
   #parentTargetId: Protocol.Target.TargetID|null = null;
 
   constructor(parentTarget: Target) {
@@ -261,7 +261,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   }
 
   async createParallelConnection(onMessage: (arg0: Object|string) => void):
-      Promise<{connection: ProtocolClient.InspectorBackend.Connection, sessionId: string}> {
+      Promise<{connection: ProtocolClient.ConnectionTransport.ConnectionTransport, sessionId: string}> {
     // The main Target id is actually just `main`, instead of the real targetId.
     // Get the real id (requires an async operation) so that it can be used synchronously later.
     const targetId = await this.getParentTargetId();
@@ -274,7 +274,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
 
   private async createParallelConnectionAndSessionForTarget(target: Target, targetId: Protocol.Target.TargetID):
       Promise<{
-        connection: ProtocolClient.InspectorBackend.Connection,
+        connection: ProtocolClient.ConnectionTransport.ConnectionTransport,
         sessionId: string,
       }> {
     const targetAgent = target.targetAgent();

package/front_end/core/sdk/Connections.ts

@@ -19,7 +19,7 @@ const UIStrings = {
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/Connections.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
-export class MainConnection implements ProtocolClient.InspectorBackend.Connection {
+export class MainConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
   #messageBuffer = '';
@@ -81,7 +81,7 @@ export class MainConnection implements ProtocolClient.InspectorBackend.Connectio
   }
 }
 
-export class WebSocketConnection implements ProtocolClient.InspectorBackend.Connection {
+export class WebSocketConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   #socket: WebSocket|null;
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
@@ -176,7 +176,7 @@ export class WebSocketConnection implements ProtocolClient.InspectorBackend.Conn
   }
 }
 
-export class StubConnection implements ProtocolClient.InspectorBackend.Connection {
+export class StubConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   onMessage: ((arg0: Object|string) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
 
@@ -213,17 +213,17 @@ export class StubConnection implements ProtocolClient.InspectorBackend.Connectio
   }
 }
 
-export interface ParallelConnectionInterface extends ProtocolClient.InspectorBackend.Connection {
+export interface ParallelConnectionInterface extends ProtocolClient.ConnectionTransport.ConnectionTransport {
   getSessionId: () => string;
   getOnDisconnect: () => ((arg0: string) => void) | null;
 }
 
 export class ParallelConnection implements ParallelConnectionInterface {
-  readonly #connection: ProtocolClient.InspectorBackend.Connection;
+  readonly #connection: ProtocolClient.ConnectionTransport.ConnectionTransport;
   #sessionId: string;
   onMessage: ((arg0: Object) => void)|null = null;
   #onDisconnect: ((arg0: string) => void)|null = null;
-  constructor(connection: ProtocolClient.InspectorBackend.Connection, sessionId: string) {
+  constructor(connection: ProtocolClient.ConnectionTransport.ConnectionTransport, sessionId: string) {
     this.#connection = connection;
     this.#sessionId = sessionId;
   }
@@ -265,13 +265,13 @@ export class ParallelConnection implements ParallelConnectionInterface {
 export async function initMainConnection(
     createRootTarget: () => Promise<void>,
     onConnectionLost: (message: Platform.UIString.LocalizedString) => void): Promise<void> {
-  ProtocolClient.InspectorBackend.Connection.setFactory(createMainConnection.bind(null, onConnectionLost));
+  ProtocolClient.ConnectionTransport.ConnectionTransport.setFactory(createMainConnection.bind(null, onConnectionLost));
   await createRootTarget();
   Host.InspectorFrontendHost.InspectorFrontendHostInstance.connectionReady();
 }
 
 function createMainConnection(onConnectionLost: (message: Platform.UIString.LocalizedString) => void):
-    ProtocolClient.InspectorBackend.Connection {
+    ProtocolClient.ConnectionTransport.ConnectionTransport {
   if (Root.Runtime.Runtime.isTraceApp()) {
     return new RehydratingConnection(onConnectionLost);
   }

package/front_end/core/sdk/NetworkManager.ts

@@ -1817,6 +1817,26 @@ export class RequestConditions extends Common.ObjectWrapper.ObjectWrapper<Reques
     this.#conditionsChanged();
   }
 
+  decreasePriority(condition: RequestCondition): void {
+    const index = this.#conditions.indexOf(condition);
+    if (index < 0 || index >= this.#conditions.length - 1) {
+      return;
+    }
+
+    Platform.ArrayUtilities.swap(this.#conditions, index, index + 1);
+    this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
+  }
+
+  increasePriority(condition: RequestCondition): void {
+    const index = this.#conditions.indexOf(condition);
+    if (index <= 0) {
+      return;
+    }
+
+    Platform.ArrayUtilities.swap(this.#conditions, index - 1, index);
+    this.dispatchEventToListeners(RequestConditions.Events.REQUEST_CONDITIONS_CHANGED);
+  }
+
   delete(condition: RequestCondition): void {
     const index = this.#conditions.indexOf(condition);
     if (index < 0) {

package/front_end/core/sdk/RehydratingConnection.ts

@@ -63,7 +63,7 @@ export const enum RehydratingConnectionState {
   REHYDRATED = 3,
 }
 
-export class RehydratingConnection implements ProtocolClient.InspectorBackend.Connection {
+export class RehydratingConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   rehydratingConnectionState: RehydratingConnectionState = RehydratingConnectionState.UNINITIALIZED;
   onDisconnect: ((arg0: string) => void)|null = null;
   onMessage: ((arg0: Object) => void)|null = null;
@@ -106,11 +106,13 @@ export class RehydratingConnection implements ProtocolClient.InspectorBackend.Co
 
   #setupMessagePassing(): void {
     this.#rehydratingWindow.addEventListener('message', this.#onReceiveHostWindowPayloadBound);
-    if (!this.#rehydratingWindow.opener) {
+    if (this.#rehydratingWindow.opener) {
+      this.#rehydratingWindow.opener.postMessage({type: 'REHYDRATING_WINDOW_READY'});
+    } else if (this.#rehydratingWindow !== window.top) {
+      this.#rehydratingWindow.parent.postMessage({type: 'REHYDRATING_IFRAME_READY'});
+    } else {
       this.#onConnectionLost(i18nString(UIStrings.noHostWindow));
-      return;
     }
-    this.#rehydratingWindow.opener.postMessage({type: 'REHYDRATING_WINDOW_READY'});
   }
 
   /**

package/front_end/core/sdk/Target.ts

@@ -39,7 +39,8 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
   constructor(
       targetManager: TargetManager, id: Protocol.Target.TargetID|'main', name: string, type: Type,
       parentTarget: Target|null, sessionId: string, suspended: boolean,
-      connection: ProtocolClient.InspectorBackend.Connection|null, targetInfo?: Protocol.Target.TargetInfo) {
+      connection: ProtocolClient.ConnectionTransport.ConnectionTransport|null,
+      targetInfo?: Protocol.Target.TargetInfo) {
     const needsNodeJSPatching = type === Type.NODE;
     super(needsNodeJSPatching, parentTarget, sessionId, connection);
     this.#targetManager = targetManager;

package/front_end/core/sdk/TargetManager.ts

@@ -209,7 +209,8 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
 
   createTarget(
       id: Protocol.Target.TargetID|'main', name: string, type: TargetType, parentTarget: Target|null,
-      sessionId?: string, waitForDebuggerInPage?: boolean, connection?: ProtocolClient.InspectorBackend.Connection,
+      sessionId?: string, waitForDebuggerInPage?: boolean,
+      connection?: ProtocolClient.ConnectionTransport.ConnectionTransport,
       targetInfo?: Protocol.Target.TargetInfo): Target {
     const target = new Target(
         this, id, name, type, parentTarget, sessionId || '', this.#isSuspended, connection || null, targetInfo);

package/front_end/entrypoints/node_app/NodeMain.ts

@@ -146,7 +146,7 @@ export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implemen
   }
 }
 
-export class NodeConnection implements ProtocolClient.InspectorBackend.Connection {
+export class NodeConnection implements ProtocolClient.ConnectionTransport.ConnectionTransport {
   readonly #targetAgent: ProtocolProxyApi.TargetApi;
   readonly #sessionId: Protocol.Target.SessionID;
   onMessage: ((arg0: Object|string) => void)|null;