chrome-devtools-frontend 1.0.1531367 → 1.0.1532228

package/AUTHORS

@@ -65,6 +65,7 @@ Marijn Haverbeke <marijnh@gmail.com>
 Max 😎 Coplan <mchcopl@gmail.com>
 Michael Brüning <michael.bruning@qt.io>
 Michael Rienstra <mrienstra@gmail.com>
+Mostafa Aboalkasim <mostafa.aboalkasim.offical@gmail.com>
 Muhammad Mahad <mahadtxt@gmail.com>
 Naoto Ono <onoto1998@gmail.com>
 Paras Awasthi <awasthiparas6@gmail.com>
@@ -93,6 +94,7 @@ Tony Kostowny <tonykostowny@gmail.com>
 Toshiaki Tanaka <zokutyou2@gmail.com>
 Tushar Singh <tusharvickey1999@gmail.com>
 Varun Varada <varuncvarada@gmail.com>
+Vishwa Kalubowila <vishwa.kalubowila@codimite.com>
 Vitali Zaidman <vzaidman@gmail.com>
 Will Hernandez <w.hernandez.code@gmail.com>
 Yeol Park <peary2@gmail.com>

package/front_end/core/protocol_client/InspectorBackend.ts

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as InspectorBackendCommands from '../../generated/InspectorBackendCommands.js';
 import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js';
 import type * as Protocol from '../../generated/protocol.js';
 import type * as Platform from '../platform/platform.js';
@@ -78,6 +79,15 @@ export class InspectorBackend {
   readonly typeMap = new Map<QualifiedName, CommandParameter[]>();
   readonly enumMap = new Map<QualifiedName, Record<string, string>>();
 
+  constructor() {
+    // Create the global here because registering commands will involve putting
+    // items onto the global.
+    // @ts-expect-error Global namespace instantiation
+    globalThis.Protocol ||= {};
+
+    InspectorBackendCommands.registerCommands(this);
+  }
+
   private getOrCreateEventParameterNamesForDomain(domain: ProtocolDomainName): EventParameterNames {
     let map = this.#eventParameterNamesForDomain.get(domain);
     if (!map) {
@@ -367,9 +377,8 @@ export class SessionRouter {
     const sessionId = messageObject.sessionId || '';
     const session = this.#sessions.get(sessionId);
     if (!session) {
-      if (!suppressUnknownMessageErrors) {
-        InspectorBackend.reportProtocolError('Protocol Error: the message with wrong session id', messageObject);
-      }
+      // In the DevTools MCP case, we may share the transport with puppeteer so we silently
+      // ignore unknown sessions.
       return;
     }
 
@@ -492,12 +501,12 @@ export class TargetBase {
     this.needsNodeJSPatching = needsNodeJSPatching;
     this.sessionId = sessionId;
 
-    if ((!parentTarget && connection) || (!parentTarget && sessionId) || (connection && sessionId)) {
-      throw new Error('Either connection or sessionId (but not both) must be supplied for a child target');
+    if (parentTarget && !sessionId) {
+      throw new Error('Specifying a parent target requires a session ID');
     }
 
     let router: SessionRouter;
-    if (sessionId && parentTarget && parentTarget.#router) {
+    if (parentTarget && parentTarget.#router) {
       router = parentTarget.#router;
     } else if (connection) {
       router = new SessionRouter(connection);

package/front_end/core/protocol_client/protocol_client.ts

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as InspectorBackendCommands from '../../generated/InspectorBackendCommands.js';
-
 import * as InspectorBackend from './InspectorBackend.js';
 import * as NodeURL from './NodeURL.js';
 
@@ -11,11 +9,3 @@ export {
   InspectorBackend,
   NodeURL,
 };
-
-// Create the global here because registering commands will involve putting
-// items onto the global.
-// @ts-expect-error Global namespace instantiation
-globalThis.Protocol = globalThis.Protocol || {};
-
-// FIXME: This instance of InspectorBackend should not be a side effect of importing this module.
-InspectorBackendCommands.registerCommands(InspectorBackend.inspectorBackend);