chrome-devtools-frontend 1.0.1529904 → 1.0.1530564

package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts

@@ -6,14 +6,14 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as Badges from '../../models/badges/badges.js';
+import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import {ThrottlingManager} from './ThrottlingManager.js';
-import {type NetworkThrottlingConditionsGroup, ThrottlingPresets} from './ThrottlingPresets.js';
+import type {NetworkThrottlingConditionsGroup} from './ThrottlingPresets.js';
 
-const {render, html, Directives} = Lit;
+const {render, html, Directives, nothing} = Lit;
 
 const UIStrings = {
   /**
@@ -28,6 +28,10 @@ const UIStrings = {
    * @description Text in Network Throttling Selector of the Network panel
    */
   custom: 'Custom',
+  /**
+   * @description  Title for a network throttling group containing the request blocking option
+   */
+  blockingGroup: 'Blocking',
   /**
    *@description Text with two placeholders separated by a colon
    *@example {Node removed} PH1
@@ -54,26 +58,28 @@ const str_ = i18n.i18n.registerUIStrings('panels/mobile_throttling/NetworkThrott
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 interface ViewInput {
-  recommendedConditions: SDK.NetworkManager.Conditions|null;
-  selectedConditions: SDK.NetworkManager.Conditions;
+  recommendedConditions: SDK.NetworkManager.ThrottlingConditions|null;
+  selectedConditions: SDK.NetworkManager.ThrottlingConditions|undefined;
   throttlingGroups: NetworkThrottlingConditionsGroup[];
   customConditionsGroup: NetworkThrottlingConditionsGroup;
-  jslogContext: string;
-  title: string;
-  onSelect: (conditions: SDK.NetworkManager.Conditions) => void;
+  jslogContext: string|undefined;
+  title: string|undefined;
+  onSelect: (conditions: SDK.NetworkManager.ThrottlingConditions) => void;
   onAddCustomConditions: () => void;
 }
 export type ViewFunction = (input: ViewInput, output: object, target: HTMLElement) => void;
 
 export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
   // The title is usually an i18nLazyString except for custom values that are stored in the local storage in the form of a string.
-  const title = (conditions: SDK.NetworkManager.Conditions): string =>
+  const title = (conditions: SDK.NetworkManager.ThrottlingConditions): string =>
       typeof conditions.title === 'function' ? conditions.title() : conditions.title;
-  const jslog = (group: NetworkThrottlingConditionsGroup, condition: SDK.NetworkManager.Conditions): string =>
-      `${VisualLogging.item(Platform.StringUtilities.toKebabCase(condition.i18nTitleKey || title(condition))).track({
-        click: true
-      })}`;
-  const optionsMap = new WeakMap<HTMLOptionElement, SDK.NetworkManager.Conditions>();
+  const jslog = (group: NetworkThrottlingConditionsGroup, condition: SDK.NetworkManager.ThrottlingConditions): string =>
+      `${
+          VisualLogging
+              .item(Platform.StringUtilities.toKebabCase(
+                  ('i18nTitleKey' in condition && condition.i18nTitleKey) || title(condition)))
+              .track({click: true})}`;
+  const optionsMap = new WeakMap<HTMLOptionElement, SDK.NetworkManager.ThrottlingConditions>();
   let selectedConditions = input.selectedConditions;
   function onSelect(event: Event): void {
     const element = (event.target as HTMLSelectElement | null);
@@ -87,7 +93,9 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
     if (option === element.options[element.options.length - 1]) {
       input.onAddCustomConditions();
       event.consume(true);
-      element.value = title(selectedConditions);
+      if (selectedConditions) {
+        element.value = title(selectedConditions);
+      }
     } else {
       const conditions = optionsMap.get(option);
       if (conditions) {
@@ -96,10 +104,11 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
       }
     }
   }
+
   render(
       // clang-format off
     html`<select
-      aria-label=${input.title}
+      aria-label=${input.title ?? nothing}
       jslog=${VisualLogging.dropDown().track({change: true}).context(input.jslogContext)}
       @change=${onSelect}>
           ${input.throttlingGroups.map(
@@ -108,7 +117,9 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
             label=${group.title}>
             ${group.items.map(condition => html`<option
               ${Directives.ref(option => option && optionsMap.set(option as HTMLOptionElement, condition))}
-              ?selected=${SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
+              ?selected=${selectedConditions ?
+                  SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions) :
+                  (group === input.throttlingGroups[0])}
               value=${title(condition)}
               aria-label=${i18nString(UIStrings.sS, {PH1: group.title, PH2: title(condition)})}
               jslog=${jslog(group, condition)}>
@@ -120,7 +131,7 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
         <optgroup label=${input.customConditionsGroup.title}>
           ${input.customConditionsGroup.items.map(condition => html`<option
               ${Directives.ref(option => option && optionsMap.set(option as HTMLOptionElement, condition))}
-              ?selected=${SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
+              ?selected=${selectedConditions && SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
               value=${title(condition)}
               aria-label=${i18nString(UIStrings.sS, {PH1: input.customConditionsGroup.title, PH2: title(condition)})}
               jslog=${VisualLogging.item('custom-network-throttling-item').track({click: true})}>
@@ -144,25 +155,29 @@ export const enum Events {
 }
 
 export interface EventTypes {
-  [Events.CONDITIONS_CHANGED]: SDK.NetworkManager.Conditions;
+  [Events.CONDITIONS_CHANGED]: SDK.NetworkManager.ThrottlingConditions;
 }
 
 export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   #recommendedConditions: SDK.NetworkManager.Conditions|null = null;
   readonly #element: HTMLElement;
-  readonly #jslogContext: string;
-  #currentConditions: SDK.NetworkManager.Conditions;
-  readonly #title: string;
+  #jslogContext?: string;
+  #currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined;
+  readonly #title?: string;
   readonly #view: ViewFunction;
+  #variant: NetworkThrottlingSelect.Variant = NetworkThrottlingSelect.Variant.GLOBAL_CONDITIONS;
 
   static createForGlobalConditions(element: HTMLElement, title: string): NetworkThrottlingSelect {
     ThrottlingManager.instance();  // Instantiate the throttling manager to connect network manager with the setting
-    const select = new NetworkThrottlingSelect(
-        element, title, SDK.NetworkManager.activeNetworkThrottlingKeySetting().name,
-        SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions());
+    const select = new NetworkThrottlingSelect(element, {
+      title,
+      jslogContext: SDK.NetworkManager.activeNetworkThrottlingKeySetting().name,
+      currentConditions: SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions()
+    });
     select.addEventListener(
         Events.CONDITIONS_CHANGED,
-        ev => SDK.NetworkManager.MultitargetNetworkManager.instance().setNetworkConditions(ev.data));
+        ev => !('block' in ev.data) &&
+            SDK.NetworkManager.MultitargetNetworkManager.instance().setNetworkConditions(ev.data));
     SDK.NetworkManager.MultitargetNetworkManager.instance().addEventListener(
         SDK.NetworkManager.MultitargetNetworkManager.Events.CONDITIONS_CHANGED, () => {
           select.currentConditions = SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions();
@@ -171,29 +186,57 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
   }
 
   constructor(
-      element: HTMLElement, title: string, jslogContext: string, currentConditions: SDK.NetworkManager.Conditions,
+      element: HTMLElement, options: {
+        title?: string,
+        jslogContext?: string,
+        currentConditions?: SDK.NetworkManager.Conditions,
+        includeBlocking?: true,
+      } = {},
       view = DEFAULT_VIEW) {
     super();
     SDK.NetworkManager.customUserNetworkConditionsSetting().addChangeListener(this.#performUpdate, this);
     this.#element = element;
-    this.#jslogContext = jslogContext;
-    this.#currentConditions = currentConditions;
-    this.#title = title;
+    this.#jslogContext = options.jslogContext;
+    this.#currentConditions = options.currentConditions;
+    this.#title = options.title;
     this.#view = view;
 
     this.#performUpdate();
   }
 
+  get recommendedConditions(): SDK.NetworkManager.Conditions|null {
+    return this.#recommendedConditions;
+  }
   set recommendedConditions(recommendedConditions: SDK.NetworkManager.Conditions|null) {
     this.#recommendedConditions = recommendedConditions;
     this.#performUpdate();
   }
 
-  set currentConditions(currentConditions: SDK.NetworkManager.Conditions) {
+  get currentConditions(): SDK.NetworkManager.ThrottlingConditions|undefined {
+    return this.#currentConditions;
+  }
+  set currentConditions(currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined) {
     this.#currentConditions = currentConditions;
     this.#performUpdate();
   }
 
+  get jslogContext(): string|undefined {
+    return this.#jslogContext;
+  }
+  set jslogContext(jslogContext: string|undefined) {
+    this.#jslogContext = jslogContext;
+    this.#performUpdate();
+  }
+
+  get variant(): NetworkThrottlingSelect.Variant {
+    return this.#variant;
+  }
+  set variant(variant: NetworkThrottlingSelect.Variant) {
+    this.#variant = variant;
+    this.#performUpdate();
+  }
+
+  // FIXME Should use requestUpdate once we merge this with the widget
   #performUpdate(): void {
     const customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting();
     const customNetworkConditions = customNetworkConditionsSetting.get();
@@ -201,16 +244,41 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
       void Common.Revealer.reveal(SDK.NetworkManager.customUserNetworkConditionsSetting());
     };
 
-    const onSelect = (conditions: SDK.NetworkManager.Conditions): void => {
+    const onSelect = (conditions: SDK.NetworkManager.ThrottlingConditions): void => {
       this.dispatchEventToListeners(Events.CONDITIONS_CHANGED, conditions);
-      Badges.UserBadges.instance().recordAction(Badges.BadgeAction.NETWORK_SPEED_THROTTLED);
     };
 
-    const throttlingGroups = [
-      {title: i18nString(UIStrings.disabled), items: [SDK.NetworkManager.NoThrottlingConditions]},
-      {title: i18nString(UIStrings.presets), items: ThrottlingPresets.networkPresets},
-    ];
+    const throttlingGroups: NetworkThrottlingConditionsGroup[] = [];
+
+    switch (this.#variant) {
+      case NetworkThrottlingSelect.Variant.GLOBAL_CONDITIONS:
+        throttlingGroups.push(
+            {title: i18nString(UIStrings.disabled), items: [SDK.NetworkManager.NoThrottlingConditions]}, {
+              title: i18nString(UIStrings.presets),
+              items: [
+                SDK.NetworkManager.Fast4GConditions,
+                SDK.NetworkManager.Slow4GConditions,
+                SDK.NetworkManager.Slow3GConditions,
+                SDK.NetworkManager.OfflineConditions,
+              ]
+            });
+        break;
+      case NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS:
+        throttlingGroups.push(
+            {title: i18nString(UIStrings.blockingGroup), items: [SDK.NetworkManager.BlockingConditions]},
+            {
+              title: i18nString(UIStrings.presets),
+              items: [
+                SDK.NetworkManager.Fast4GConditions,
+                SDK.NetworkManager.Slow4GConditions,
+                SDK.NetworkManager.Slow3GConditions,
+              ]
+            },
+        );
+        break;
+    }
     const customConditionsGroup = {title: i18nString(UIStrings.custom), items: customNetworkConditions};
+
     const viewInput: ViewInput = {
       recommendedConditions: this.#recommendedConditions,
       selectedConditions: this.#currentConditions,
@@ -224,3 +292,35 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
     this.#view(viewInput, {}, this.#element);
   }
 }
+export namespace NetworkThrottlingSelect {
+  export const enum Variant {
+    GLOBAL_CONDITIONS = 'global-conditions',
+    INDIVIDUAL_REQUEST_CONDITIONS = 'individual-request-conditions',
+  }
+}
+
+export class NetworkThrottlingSelectorWidget extends UI.Widget.VBox {
+  #select: NetworkThrottlingSelect;
+  #conditionsChangedHandler?: ((conditions: SDK.NetworkManager.ThrottlingConditions) => void);
+  constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
+    super(element, {useShadowDom: true});
+    this.#select = new NetworkThrottlingSelect(this.contentElement, {}, view);
+    this.#select.addEventListener(Events.CONDITIONS_CHANGED, ({data}) => this.#conditionsChangedHandler?.(data));
+  }
+
+  set variant(variant: NetworkThrottlingSelect.Variant) {
+    this.#select.variant = variant;
+  }
+
+  set jslogContext(context: string) {
+    this.#select.jslogContext = context;
+  }
+
+  set currentConditions(currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined) {
+    this.#select.currentConditions = currentConditions;
+  }
+
+  set onConditionsChanged(handler: (conditions: SDK.NetworkManager.ThrottlingConditions) => void) {
+    this.#conditionsChangedHandler = handler;
+  }
+}

package/front_end/panels/mobile_throttling/ThrottlingPresets.ts

@@ -167,7 +167,7 @@ export interface Conditions {
 
 export interface NetworkThrottlingConditionsGroup {
   title: string;
-  items: SDK.NetworkManager.Conditions[];
+  items: SDK.NetworkManager.ThrottlingConditions[];
 }
 
 export interface MobileThrottlingConditionsGroup {

package/front_end/panels/sources/AiCodeCompletionPlugin.ts

@@ -154,7 +154,7 @@ export class AiCodeCompletionPlugin extends Plugin {
           if (this.#aiCodeCompletion && this.#editor && TextEditor.Config.hasActiveAiSuggestion(this.#editor.state)) {
             const {accepted, suggestion} = TextEditor.Config.acceptAiAutoCompleteSuggestion(this.#editor.editor);
             if (accepted) {
-              if (suggestion?.rpcGlobalId && suggestion?.sampleId) {
+              if (suggestion?.rpcGlobalId) {
                 this.#aiCodeCompletion?.registerUserAcceptance(suggestion.rpcGlobalId, suggestion.sampleId);
               }
               this.#onAiCodeCompletionSuggestionAccepted();

package/front_end/panels/sources/SourcesPanel.ts

@@ -1212,6 +1212,11 @@ export class SourcesPanel extends UI.Panel.Panel implements
       this.sidebarPaneView.detach();
     }
 
+    if (Root.Runtime.Runtime.isTraceApp()) {
+      this.splitWidget.hideSidebar();
+      return;
+    }
+
     this.splitWidget.setVertical(!vertically);
     this.splitWidget.element.classList.toggle('sources-split-view-vertical', vertically);
 

package/front_end/panels/sources/sources-meta.ts

@@ -5,6 +5,7 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Breakpoints from '../../models/breakpoints/breakpoints.js';
 import * as Workspace from '../../models/workspace/workspace.js';
@@ -528,6 +529,7 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.snippets),
   order: 6,
   persistence: UI.ViewManager.ViewPersistence.PERMANENT,
+  condition: () => !Root.Runtime.Runtime.isTraceApp(),
   async loadView() {
     const Sources = await loadSourcesModule();
     return new Sources.SourcesNavigator.SnippetsNavigatorView();
@@ -1280,18 +1282,17 @@ UI.ActionRegistration.registerActionExtension({
   title: i18nLazyString(UIStrings.createNewSnippet),
 });
 
-if (!Host.InspectorFrontendHost.InspectorFrontendHostInstance.isHostedMode()) {
-  UI.ActionRegistration.registerActionExtension({
-    category: UI.ActionRegistration.ActionCategory.SOURCES,
-    actionId: 'sources.add-folder-to-workspace',
-    async loadActionDelegate() {
-      const Sources = await loadSourcesModule();
-      return new Sources.SourcesNavigator.ActionDelegate();
-    },
-    iconClass: UI.ActionRegistration.IconClass.PLUS,
-    title: i18nLazyString(UIStrings.addFolderToWorkspace),
-  });
-}
+UI.ActionRegistration.registerActionExtension({
+  category: UI.ActionRegistration.ActionCategory.SOURCES,
+  actionId: 'sources.add-folder-to-workspace',
+  condition: () => !Host.InspectorFrontendHost.InspectorFrontendHostInstance.isHostedMode(),
+  async loadActionDelegate() {
+    const Sources = await loadSourcesModule();
+    return new Sources.SourcesNavigator.ActionDelegate();
+  },
+  iconClass: UI.ActionRegistration.IconClass.PLUS,
+  title: i18nLazyString(UIStrings.addFolderToWorkspace),
+});
 
 UI.ActionRegistration.registerActionExtension({
   category: UI.ActionRegistration.ActionCategory.DEBUGGER,

package/front_end/panels/sources/sourcesView.css

@@ -15,6 +15,7 @@
 #sources-panel-sources-view .sources-toolbar {
   display: flex;
   flex: 0 0 auto;
+  min-height: 27px;
   background-color: var(--sys-color-cdt-base-container);
   border-top: 1px solid var(--sys-color-divider);
   overflow: hidden;

package/front_end/panels/timeline/TimelinePanel.ts

@@ -1637,6 +1637,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     const url = new URL(window.location.href);
     const pathToEntrypoint = url.pathname.slice(0, url.pathname.lastIndexOf('/'));
     url.pathname = `${pathToEntrypoint}/trace_app.html`;
+    url.search = '';
     pathToLaunch = url.toString();
 
     // Clarifying the window the code is referring to

package/front_end/panels/timeline/TimelineSelectorStatsView.ts

@@ -11,7 +11,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Trace from '../../models/trace/trace.js';
-import * as CopyToClipboard from '../../ui/components/copy_to_clipboard/copy_to_clipboard.js';
 import type * as Linkifier from '../../ui/components/linkifier/linkifier.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {html, render} from '../../ui/lit/lit.js';
@@ -259,7 +258,7 @@ export class TimelineSelectorStatsView extends UI.Widget.VBox {
         ].join('\t'));
       }
       const data = tableData.join('\n');
-      CopyToClipboard.copyTextToClipboard(data, i18nString(UIStrings.tableCopiedToClipboard));
+      UI.UIUtils.copyTextToClipboard(data, i18nString(UIStrings.tableCopiedToClipboard));
     });
   }
 

package/front_end/panels/timeline/TimelineTreeView.ts

@@ -799,9 +799,9 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
       const parsedTrace = this.treeView.parsedTrace();
       const target = parsedTrace ? targetForEvent(parsedTrace, event) : null;
       const linkifier = this.treeView.linkifier;
-      const isFreshRecording =
-          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace));
-      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshRecording);
+      const isFreshOrEnhanced =
+          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFreshOrEnhanced(parsedTrace));
+      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshOrEnhanced);
       if (this.linkElement) {
         container.createChild('div', 'activity-link').appendChild(this.linkElement);
       }

package/front_end/panels/timeline/TimelineUIUtils.ts

@@ -493,7 +493,7 @@ interface LinkifyLocationOptions {
   lineNumber: number;
   target: SDK.Target.Target|null;
   linkifier: LegacyComponents.Linkifier.Linkifier;
-  isFreshRecording?: boolean;
+  isFreshOrEnhanced?: boolean;
   columnNumber?: number;
   omitOrigin?: boolean;
 }
@@ -656,7 +656,7 @@ export class TimelineUIUtils {
 
   static async buildDetailsNodeForTraceEvent(
       event: Trace.Types.Events.Event, target: SDK.Target.Target|null, linkifier: LegacyComponents.Linkifier.Linkifier,
-      isFreshRecording = false, parsedTrace: Trace.TraceModel.ParsedTrace): Promise<Node|null> {
+      isFreshOrEnhanced = false, parsedTrace: Trace.TraceModel.ParsedTrace): Promise<Node|null> {
     let details: HTMLElement|HTMLSpanElement|(Element | null)|Text|null = null;
     let detailsText;
     // TODO(40287735): update this code with type-safe data checks.
@@ -706,7 +706,7 @@ export class TimelineUIUtils {
           lineNumber: callFrame?.lineNumber || 0,
           columnNumber: callFrame?.columnNumber,
           target,
-          isFreshRecording,
+          isFreshOrEnhanced,
           linkifier,
           omitOrigin: true,
         });
@@ -725,7 +725,7 @@ export class TimelineUIUtils {
           lineNumber: 0,
           columnNumber: 0,
           target,
-          isFreshRecording,
+          isFreshOrEnhanced,
           linkifier,
         });
         break;
@@ -743,7 +743,7 @@ export class TimelineUIUtils {
             lineNumber: lineNumber || 0,
             columnNumber: 0,
             target,
-            isFreshRecording,
+            isFreshOrEnhanced,
             linkifier,
             omitOrigin: true,
           });
@@ -761,7 +761,7 @@ export class TimelineUIUtils {
             lineNumber: 0,
             columnNumber: 0,
             target,
-            isFreshRecording,
+            isFreshOrEnhanced,
             linkifier,
             omitOrigin: true,
           });
@@ -779,7 +779,7 @@ export class TimelineUIUtils {
             Trace.Types.Events.isProfileCall(event)) {
           detailsText = null;
         } else {
-          details = this.linkifyTopCallFrame(event, target, linkifier, isFreshRecording) ?? null;
+          details = this.linkifyTopCallFrame(event, target, linkifier, isFreshOrEnhanced) ?? null;
         }
         break;
       }
@@ -792,7 +792,7 @@ export class TimelineUIUtils {
   }
 
   static linkifyLocation(linkifyOptions: LinkifyLocationOptions): Element|null {
-    const {scriptId, url, lineNumber, columnNumber, isFreshRecording, linkifier, target, omitOrigin} = linkifyOptions;
+    const {scriptId, url, lineNumber, columnNumber, isFreshOrEnhanced, linkifier, target, omitOrigin} = linkifyOptions;
     const options = {
       lineNumber,
       columnNumber,
@@ -802,7 +802,7 @@ export class TimelineUIUtils {
       tabStop: true,
       omitOrigin,
     };
-    if (isFreshRecording) {
+    if (isFreshOrEnhanced) {
       return linkifier.linkifyScriptLocation(
           target, scriptId, url as Platform.DevToolsPath.UrlString, lineNumber, options);
     }
@@ -811,7 +811,7 @@ export class TimelineUIUtils {
 
   static linkifyTopCallFrame(
       event: Trace.Types.Events.Event, target: SDK.Target.Target|null, linkifier: LegacyComponents.Linkifier.Linkifier,
-      isFreshRecording = false): Element|null {
+      isFreshOrEnhanced = false): Element|null {
     let frame = Trace.Helpers.Trace.getZeroIndexedStackTraceInEventPayload(event)?.[0];
     if (Trace.Types.Events.isProfileCall(event)) {
       frame = event.callFrame;
@@ -827,7 +827,7 @@ export class TimelineUIUtils {
       columnNumber: frame.columnNumber,
       lineNumber: frame.lineNumber,
     };
-    if (isFreshRecording) {
+    if (isFreshOrEnhanced) {
       return linkifier.maybeLinkifyConsoleCallFrame(target, frame, {showColumnNumber: true, inlineFrameIndex: 0});
     }
     return LegacyComponents.Linkifier.Linkifier.linkifyURL(frame.url as Platform.DevToolsPath.UrlString, options);
@@ -1078,8 +1078,8 @@ export class TimelineUIUtils {
       }
     }
 
-    const isFreshRecording =
-        Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace));
+    const isFreshOrEnhanced =
+        Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFreshOrEnhanced(parsedTrace));
 
     switch (event.name) {
       case Trace.Types.Events.Name.GC:
@@ -1110,7 +1110,7 @@ export class TimelineUIUtils {
       }
       case Trace.Types.Events.Name.FUNCTION_CALL: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.function), detailsNode);
           const originWithEntity = this.getOriginWithEntity(entityMapper, parsedTrace, event);
@@ -1473,7 +1473,7 @@ export class TimelineUIUtils {
 
       case Trace.Types.Events.Name.EVENT_TIMING: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.details), detailsNode);
         }
@@ -1491,7 +1491,7 @@ export class TimelineUIUtils {
 
       default: {
         const detailsNode = await TimelineUIUtils.buildDetailsNodeForTraceEvent(
-            event, targetForEvent(parsedTrace, event), linkifier, isFreshRecording, parsedTrace);
+            event, targetForEvent(parsedTrace, event), linkifier, isFreshOrEnhanced, parsedTrace);
         if (detailsNode) {
           contentHelper.appendElementRow(i18nString(UIStrings.details), detailsNode);
         }

package/front_end/services/tracing/FreshRecording.ts

@@ -28,4 +28,8 @@ export class Tracker {
   recordingIsFresh(data: Trace.TraceModel.ParsedTrace): boolean {
     return this.#freshRecordings.has(data);
   }
+
+  recordingIsFreshOrEnhanced(data: Trace.TraceModel.ParsedTrace): boolean {
+    return this.#freshRecordings.has(data) || data.metadata.enhancedTraceVersion !== undefined;
+  }
 }

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: https://source.chromium.org/chromium/chromium/src/+/main:components/variations/proto/devtools/
 Version: N/A
-Revision: f5bb0cd608ece3474fa780146f397334b24689b2
+Revision: b8cee13d6f07e8bccc83905ddeccf1865b86b5e4
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/third_party/puppeteer/README.chromium

@@ -1,10 +1,10 @@
 Name: Puppeteer Core
 Short Name: Puppeteer Core
 URL: https://github.com/puppeteer/puppeteer/tree/main/packages/puppeteer-core
-Version: 24.23.0
+Version: 24.25.0
 License: Apache-2.0
 License File: LICENSE
-Revision: 0998859565a9e049f044dab93bcd770dd141deac
+Revision: 7d3f88132698d4c7374ca059662d2d750001e521
 Security Critical: no
 Shipped: yes
 Update Mechanism: Autoroll

package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/bidi/core/Realm.d.ts

@@ -34,8 +34,8 @@ export declare abstract class Realm extends EventEmitter<{
 }> {
     #private;
     protected readonly disposables: {
-        "__#59409@#disposed": boolean;
-        "__#59409@#stack": Disposable[];
+        "__#59417@#disposed": boolean;
+        "__#59417@#stack": Disposable[];
         readonly disposed: boolean;
         dispose(): void;
         use<T extends Disposable | null | undefined>(value: T): T;

package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/cdp/Accessibility.js

@@ -239,6 +239,7 @@ class AXNode {
     #name;
     #role;
     #ignored;
+    #cachedHasFocusableChild;
     #realm;
     constructor(realm, payload) {
         this.payload = payload;
@@ -275,6 +276,18 @@ class AXNode {
             role === 'InlineTextBox' ||
             role === 'StaticText');
     }
+    #hasFocusableChild() {
+        if (this.#cachedHasFocusableChild === undefined) {
+            this.#cachedHasFocusableChild = false;
+            for (const child of this.children) {
+                if (child.#focusable || child.#hasFocusableChild()) {
+                    this.#cachedHasFocusableChild = true;
+                    break;
+                }
+            }
+        }
+        return this.#cachedHasFocusableChild;
+    }
     find(predicate) {
         if (predicate(this)) {
             return this;
@@ -316,6 +329,9 @@ class AXNode {
             default:
                 break;
         }
+        if (this.#hasFocusableChild()) {
+            return false;
+        }
         if (this.#role === 'heading' && this.#name) {
             return true;
         }