chrome-devtools-frontend 1.0.1529186 → 1.0.1530564

package/front_end/panels/console/ConsoleViewMessage.ts

@@ -380,7 +380,7 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
   wasShown(): void {
     this.isVisibleInternal = true;
     if (this.elementInternal) {
-      this.#teaser?.show(this.elementInternal);
+      this.#teaser?.show(this.elementInternal, this.consoleRowWrapper);
     }
   }
 
@@ -1343,14 +1343,14 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
     return this.contentElementInternal;
   }
 
-  #onMouseEnter(_event: MouseEvent): void {
+  #startTeaserGeneration(): void {
     if (this.#teaser &&
         Common.Settings.Settings.instance().moduleSetting('console-insight-teasers-enabled').getIfNotDisabled()) {
       this.#teaser.maybeGenerateTeaser();
     }
   }
 
-  #onMouseLeave(): void {
+  #abortTeaserGeneration(): void {
     this.#teaser?.abortTeaserGeneration();
   }
 
@@ -1361,8 +1361,10 @@ export class ConsoleViewMessage implements ConsoleViewportElement {
     this.elementInternal = document.createElement('div');
     this.elementInternal.tabIndex = -1;
     this.elementInternal.addEventListener('keydown', (this.onKeyDown.bind(this) as EventListener));
-    this.elementInternal.addEventListener('mouseenter', this.#onMouseEnter.bind(this));
-    this.elementInternal.addEventListener('mouseleave', this.#onMouseLeave.bind(this));
+    this.elementInternal.addEventListener('mouseenter', this.#startTeaserGeneration.bind(this));
+    this.elementInternal.addEventListener('focusin', this.#startTeaserGeneration.bind(this));
+    this.elementInternal.addEventListener('mouseleave', this.#abortTeaserGeneration.bind(this));
+    this.elementInternal.addEventListener('focusout', this.#abortTeaserGeneration.bind(this));
     this.updateMessageElement();
     this.elementInternal.classList.toggle('console-adjacent-user-command-result', this.#adjacentUserCommandResult);
     return this.elementInternal;

package/front_end/panels/console/consoleInsightTeaser.css

@@ -72,10 +72,6 @@
     display: flex;
     align-items: center;
 
-    .info-icon {
-      margin-left: var(--sys-size-4);
-    }
-
     devtools-checkbox {
       margin-left: auto;
     }

package/front_end/panels/console/consolePrompt.css

@@ -18,13 +18,14 @@
 
 #console-prompt .console-prompt-icon {
   position: absolute;
-  left: -13px;
-  top: 2px;
+  left: -9px;
+  top: 4px;
   user-select: none;
 }
 
 .console-eager-preview {
   padding-bottom: 2px;
+  margin-left: 4px;
   opacity: 60%;
   position: relative;
 }

package/front_end/panels/console/consoleView.css

@@ -1,4 +1,7 @@
-/*
+/* Copyright 2021 The Chromium Authors
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ *
  * Copyright (C) 2006, 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Anthony Ricaud <rik@webkit.org>
  *
@@ -90,17 +93,20 @@
 
 .console-prompt-editor-container {
   min-height: 21px;
+  padding-left: 2px;
+  padding-top: 1px;
 }
 
 .console-message,
 .console-user-command {
   clear: right;
   position: relative;
-  padding: 3px 22px 1px 0;
+  padding: 1px 22px 1px 0;
   margin-left: 24px;
-  min-height: 17px;  /* Sync with ConsoleViewMessage.js */
+  min-height: 18px;
   flex: auto;
   display: flex;
+  align-items: flex-end;
 }
 
 .console-message > * {
@@ -215,7 +221,7 @@
   --console-color-white: #fff;
 
   &.console-selected {
-    background-color: var(--sys-color-tonal-container);
+    background-color: var(--sys-color-state-focus-highlight);
   }
 }
 
@@ -329,7 +335,6 @@
   display: inline-block;
   overflow-wrap: break-word;
   max-width: 100%;
-  vertical-align: top;
   margin-top: -1.5px;
 }
 

package/front_end/panels/elements/ElementsTreeOutline.ts

@@ -41,7 +41,6 @@ import * as Badges from '../../models/badges/badges.js';
 import * as Elements from '../../models/elements/elements.js';
 import * as IssuesManager from '../../models/issues_manager/issues_manager.js';
 import * as CodeHighlighter from '../../ui/components/code_highlighter/code_highlighter.js';
-import * as CopyToClipboard from '../../ui/components/copy_to_clipboard/copy_to_clipboard.js';
 import * as IssueCounter from '../../ui/components/issue_counter/issue_counter.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {html, nothing, render} from '../../ui/lit/lit.js';
@@ -736,7 +735,7 @@ export class ElementsTreeOutline extends
     }
     void node.getOuterHTML(includeShadowRoots).then(outerHTML => {
       if (outerHTML !== null) {
-        CopyToClipboard.copyTextToClipboard(outerHTML);
+        UI.UIUtils.copyTextToClipboard(outerHTML);
       }
     });
     this.setClipboardData({node, isCut});

package/front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts

@@ -6,14 +6,14 @@ import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
-import * as Badges from '../../models/badges/badges.js';
+import * as UI from '../../ui/legacy/legacy.js';
 import * as Lit from '../../ui/lit/lit.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import {ThrottlingManager} from './ThrottlingManager.js';
-import {type NetworkThrottlingConditionsGroup, ThrottlingPresets} from './ThrottlingPresets.js';
+import type {NetworkThrottlingConditionsGroup} from './ThrottlingPresets.js';
 
-const {render, html, Directives} = Lit;
+const {render, html, Directives, nothing} = Lit;
 
 const UIStrings = {
   /**
@@ -28,6 +28,10 @@ const UIStrings = {
    * @description Text in Network Throttling Selector of the Network panel
    */
   custom: 'Custom',
+  /**
+   * @description  Title for a network throttling group containing the request blocking option
+   */
+  blockingGroup: 'Blocking',
   /**
    *@description Text with two placeholders separated by a colon
    *@example {Node removed} PH1
@@ -54,26 +58,28 @@ const str_ = i18n.i18n.registerUIStrings('panels/mobile_throttling/NetworkThrott
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 interface ViewInput {
-  recommendedConditions: SDK.NetworkManager.Conditions|null;
-  selectedConditions: SDK.NetworkManager.Conditions;
+  recommendedConditions: SDK.NetworkManager.ThrottlingConditions|null;
+  selectedConditions: SDK.NetworkManager.ThrottlingConditions|undefined;
   throttlingGroups: NetworkThrottlingConditionsGroup[];
   customConditionsGroup: NetworkThrottlingConditionsGroup;
-  jslogContext: string;
-  title: string;
-  onSelect: (conditions: SDK.NetworkManager.Conditions) => void;
+  jslogContext: string|undefined;
+  title: string|undefined;
+  onSelect: (conditions: SDK.NetworkManager.ThrottlingConditions) => void;
   onAddCustomConditions: () => void;
 }
 export type ViewFunction = (input: ViewInput, output: object, target: HTMLElement) => void;
 
 export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
   // The title is usually an i18nLazyString except for custom values that are stored in the local storage in the form of a string.
-  const title = (conditions: SDK.NetworkManager.Conditions): string =>
+  const title = (conditions: SDK.NetworkManager.ThrottlingConditions): string =>
       typeof conditions.title === 'function' ? conditions.title() : conditions.title;
-  const jslog = (group: NetworkThrottlingConditionsGroup, condition: SDK.NetworkManager.Conditions): string =>
-      `${VisualLogging.item(Platform.StringUtilities.toKebabCase(condition.i18nTitleKey || title(condition))).track({
-        click: true
-      })}`;
-  const optionsMap = new WeakMap<HTMLOptionElement, SDK.NetworkManager.Conditions>();
+  const jslog = (group: NetworkThrottlingConditionsGroup, condition: SDK.NetworkManager.ThrottlingConditions): string =>
+      `${
+          VisualLogging
+              .item(Platform.StringUtilities.toKebabCase(
+                  ('i18nTitleKey' in condition && condition.i18nTitleKey) || title(condition)))
+              .track({click: true})}`;
+  const optionsMap = new WeakMap<HTMLOptionElement, SDK.NetworkManager.ThrottlingConditions>();
   let selectedConditions = input.selectedConditions;
   function onSelect(event: Event): void {
     const element = (event.target as HTMLSelectElement | null);
@@ -87,7 +93,9 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
     if (option === element.options[element.options.length - 1]) {
       input.onAddCustomConditions();
       event.consume(true);
-      element.value = title(selectedConditions);
+      if (selectedConditions) {
+        element.value = title(selectedConditions);
+      }
     } else {
       const conditions = optionsMap.get(option);
       if (conditions) {
@@ -96,10 +104,11 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
       }
     }
   }
+
   render(
       // clang-format off
     html`<select
-      aria-label=${input.title}
+      aria-label=${input.title ?? nothing}
       jslog=${VisualLogging.dropDown().track({change: true}).context(input.jslogContext)}
       @change=${onSelect}>
           ${input.throttlingGroups.map(
@@ -108,7 +117,9 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
             label=${group.title}>
             ${group.items.map(condition => html`<option
               ${Directives.ref(option => option && optionsMap.set(option as HTMLOptionElement, condition))}
-              ?selected=${SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
+              ?selected=${selectedConditions ?
+                  SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions) :
+                  (group === input.throttlingGroups[0])}
               value=${title(condition)}
               aria-label=${i18nString(UIStrings.sS, {PH1: group.title, PH2: title(condition)})}
               jslog=${jslog(group, condition)}>
@@ -120,7 +131,7 @@ export const DEFAULT_VIEW: ViewFunction = (input, output, target) => {
         <optgroup label=${input.customConditionsGroup.title}>
           ${input.customConditionsGroup.items.map(condition => html`<option
               ${Directives.ref(option => option && optionsMap.set(option as HTMLOptionElement, condition))}
-              ?selected=${SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
+              ?selected=${selectedConditions && SDK.NetworkManager.networkConditionsEqual(condition, selectedConditions)}
               value=${title(condition)}
               aria-label=${i18nString(UIStrings.sS, {PH1: input.customConditionsGroup.title, PH2: title(condition)})}
               jslog=${VisualLogging.item('custom-network-throttling-item').track({click: true})}>
@@ -144,25 +155,29 @@ export const enum Events {
 }
 
 export interface EventTypes {
-  [Events.CONDITIONS_CHANGED]: SDK.NetworkManager.Conditions;
+  [Events.CONDITIONS_CHANGED]: SDK.NetworkManager.ThrottlingConditions;
 }
 
 export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
   #recommendedConditions: SDK.NetworkManager.Conditions|null = null;
   readonly #element: HTMLElement;
-  readonly #jslogContext: string;
-  #currentConditions: SDK.NetworkManager.Conditions;
-  readonly #title: string;
+  #jslogContext?: string;
+  #currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined;
+  readonly #title?: string;
   readonly #view: ViewFunction;
+  #variant: NetworkThrottlingSelect.Variant = NetworkThrottlingSelect.Variant.GLOBAL_CONDITIONS;
 
   static createForGlobalConditions(element: HTMLElement, title: string): NetworkThrottlingSelect {
     ThrottlingManager.instance();  // Instantiate the throttling manager to connect network manager with the setting
-    const select = new NetworkThrottlingSelect(
-        element, title, SDK.NetworkManager.activeNetworkThrottlingKeySetting().name,
-        SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions());
+    const select = new NetworkThrottlingSelect(element, {
+      title,
+      jslogContext: SDK.NetworkManager.activeNetworkThrottlingKeySetting().name,
+      currentConditions: SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions()
+    });
     select.addEventListener(
         Events.CONDITIONS_CHANGED,
-        ev => SDK.NetworkManager.MultitargetNetworkManager.instance().setNetworkConditions(ev.data));
+        ev => !('block' in ev.data) &&
+            SDK.NetworkManager.MultitargetNetworkManager.instance().setNetworkConditions(ev.data));
     SDK.NetworkManager.MultitargetNetworkManager.instance().addEventListener(
         SDK.NetworkManager.MultitargetNetworkManager.Events.CONDITIONS_CHANGED, () => {
           select.currentConditions = SDK.NetworkManager.MultitargetNetworkManager.instance().networkConditions();
@@ -171,29 +186,57 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
   }
 
   constructor(
-      element: HTMLElement, title: string, jslogContext: string, currentConditions: SDK.NetworkManager.Conditions,
+      element: HTMLElement, options: {
+        title?: string,
+        jslogContext?: string,
+        currentConditions?: SDK.NetworkManager.Conditions,
+        includeBlocking?: true,
+      } = {},
       view = DEFAULT_VIEW) {
     super();
     SDK.NetworkManager.customUserNetworkConditionsSetting().addChangeListener(this.#performUpdate, this);
     this.#element = element;
-    this.#jslogContext = jslogContext;
-    this.#currentConditions = currentConditions;
-    this.#title = title;
+    this.#jslogContext = options.jslogContext;
+    this.#currentConditions = options.currentConditions;
+    this.#title = options.title;
     this.#view = view;
 
     this.#performUpdate();
   }
 
+  get recommendedConditions(): SDK.NetworkManager.Conditions|null {
+    return this.#recommendedConditions;
+  }
   set recommendedConditions(recommendedConditions: SDK.NetworkManager.Conditions|null) {
     this.#recommendedConditions = recommendedConditions;
     this.#performUpdate();
   }
 
-  set currentConditions(currentConditions: SDK.NetworkManager.Conditions) {
+  get currentConditions(): SDK.NetworkManager.ThrottlingConditions|undefined {
+    return this.#currentConditions;
+  }
+  set currentConditions(currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined) {
     this.#currentConditions = currentConditions;
     this.#performUpdate();
   }
 
+  get jslogContext(): string|undefined {
+    return this.#jslogContext;
+  }
+  set jslogContext(jslogContext: string|undefined) {
+    this.#jslogContext = jslogContext;
+    this.#performUpdate();
+  }
+
+  get variant(): NetworkThrottlingSelect.Variant {
+    return this.#variant;
+  }
+  set variant(variant: NetworkThrottlingSelect.Variant) {
+    this.#variant = variant;
+    this.#performUpdate();
+  }
+
+  // FIXME Should use requestUpdate once we merge this with the widget
   #performUpdate(): void {
     const customNetworkConditionsSetting = SDK.NetworkManager.customUserNetworkConditionsSetting();
     const customNetworkConditions = customNetworkConditionsSetting.get();
@@ -201,16 +244,41 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
       void Common.Revealer.reveal(SDK.NetworkManager.customUserNetworkConditionsSetting());
     };
 
-    const onSelect = (conditions: SDK.NetworkManager.Conditions): void => {
+    const onSelect = (conditions: SDK.NetworkManager.ThrottlingConditions): void => {
       this.dispatchEventToListeners(Events.CONDITIONS_CHANGED, conditions);
-      Badges.UserBadges.instance().recordAction(Badges.BadgeAction.NETWORK_SPEED_THROTTLED);
     };
 
-    const throttlingGroups = [
-      {title: i18nString(UIStrings.disabled), items: [SDK.NetworkManager.NoThrottlingConditions]},
-      {title: i18nString(UIStrings.presets), items: ThrottlingPresets.networkPresets},
-    ];
+    const throttlingGroups: NetworkThrottlingConditionsGroup[] = [];
+
+    switch (this.#variant) {
+      case NetworkThrottlingSelect.Variant.GLOBAL_CONDITIONS:
+        throttlingGroups.push(
+            {title: i18nString(UIStrings.disabled), items: [SDK.NetworkManager.NoThrottlingConditions]}, {
+              title: i18nString(UIStrings.presets),
+              items: [
+                SDK.NetworkManager.Fast4GConditions,
+                SDK.NetworkManager.Slow4GConditions,
+                SDK.NetworkManager.Slow3GConditions,
+                SDK.NetworkManager.OfflineConditions,
+              ]
+            });
+        break;
+      case NetworkThrottlingSelect.Variant.INDIVIDUAL_REQUEST_CONDITIONS:
+        throttlingGroups.push(
+            {title: i18nString(UIStrings.blockingGroup), items: [SDK.NetworkManager.BlockingConditions]},
+            {
+              title: i18nString(UIStrings.presets),
+              items: [
+                SDK.NetworkManager.Fast4GConditions,
+                SDK.NetworkManager.Slow4GConditions,
+                SDK.NetworkManager.Slow3GConditions,
+              ]
+            },
+        );
+        break;
+    }
     const customConditionsGroup = {title: i18nString(UIStrings.custom), items: customNetworkConditions};
+
     const viewInput: ViewInput = {
       recommendedConditions: this.#recommendedConditions,
       selectedConditions: this.#currentConditions,
@@ -224,3 +292,35 @@ export class NetworkThrottlingSelect extends Common.ObjectWrapper.ObjectWrapper<
     this.#view(viewInput, {}, this.#element);
   }
 }
+export namespace NetworkThrottlingSelect {
+  export const enum Variant {
+    GLOBAL_CONDITIONS = 'global-conditions',
+    INDIVIDUAL_REQUEST_CONDITIONS = 'individual-request-conditions',
+  }
+}
+
+export class NetworkThrottlingSelectorWidget extends UI.Widget.VBox {
+  #select: NetworkThrottlingSelect;
+  #conditionsChangedHandler?: ((conditions: SDK.NetworkManager.ThrottlingConditions) => void);
+  constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
+    super(element, {useShadowDom: true});
+    this.#select = new NetworkThrottlingSelect(this.contentElement, {}, view);
+    this.#select.addEventListener(Events.CONDITIONS_CHANGED, ({data}) => this.#conditionsChangedHandler?.(data));
+  }
+
+  set variant(variant: NetworkThrottlingSelect.Variant) {
+    this.#select.variant = variant;
+  }
+
+  set jslogContext(context: string) {
+    this.#select.jslogContext = context;
+  }
+
+  set currentConditions(currentConditions: SDK.NetworkManager.ThrottlingConditions|undefined) {
+    this.#select.currentConditions = currentConditions;
+  }
+
+  set onConditionsChanged(handler: (conditions: SDK.NetworkManager.ThrottlingConditions) => void) {
+    this.#conditionsChangedHandler = handler;
+  }
+}

package/front_end/panels/mobile_throttling/ThrottlingPresets.ts

@@ -167,7 +167,7 @@ export interface Conditions {
 
 export interface NetworkThrottlingConditionsGroup {
   title: string;
-  items: SDK.NetworkManager.Conditions[];
+  items: SDK.NetworkManager.ThrottlingConditions[];
 }
 
 export interface MobileThrottlingConditionsGroup {

package/front_end/panels/sources/AiCodeCompletionPlugin.ts

@@ -55,7 +55,6 @@ export class AiCodeCompletionPlugin extends Plugin {
     this.#boundOnAidaAvailabilityChange = this.#onAidaAvailabilityChange.bind(this);
     Host.AidaClient.HostConfigTracker.instance().addEventListener(
         Host.AidaClient.Events.AIDA_AVAILABILITY_CHANGED, this.#boundOnAidaAvailabilityChange);
-    void this.#onAidaAvailabilityChange();
     const showTeaser = !this.#aiCodeCompletionSetting.get() && !this.#aiCodeCompletionTeaserDismissedSetting.get();
     if (showTeaser) {
       this.#teaser = new PanelCommon.AiCodeCompletionTeaser({onDetach: this.#detachAiCodeCompletionTeaser.bind(this)});
@@ -84,9 +83,7 @@ export class AiCodeCompletionPlugin extends Plugin {
     this.#editor.addEventListener('keydown', this.#boundEditorKeyDown);
     this.#aiCodeCompletionSetting.addChangeListener(this.#boundOnAiCodeCompletionSettingChanged);
     this.#onAiCodeCompletionSettingChanged();
-    if (editor.state.doc.length === 0) {
-      this.#addTeaserPluginToCompartmentImmediate(editor.editor);
-    }
+    void this.#onAidaAvailabilityChange();
   }
 
   override editorExtension(): CodeMirror.Extension {
@@ -157,7 +154,7 @@ export class AiCodeCompletionPlugin extends Plugin {
           if (this.#aiCodeCompletion && this.#editor && TextEditor.Config.hasActiveAiSuggestion(this.#editor.state)) {
             const {accepted, suggestion} = TextEditor.Config.acceptAiAutoCompleteSuggestion(this.#editor.editor);
             if (accepted) {
-              if (suggestion?.rpcGlobalId && suggestion?.sampleId) {
+              if (suggestion?.rpcGlobalId) {
                 this.#aiCodeCompletion?.registerUserAcceptance(suggestion.rpcGlobalId, suggestion.sampleId);
               }
               this.#onAiCodeCompletionSuggestionAccepted();
@@ -281,8 +278,16 @@ export class AiCodeCompletionPlugin extends Plugin {
       this.#aidaAvailability = currentAidaAvailability;
       if (this.#aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE) {
         this.#onAiCodeCompletionSettingChanged();
+        if (this.#editor?.state.doc.length === 0) {
+          this.#addTeaserPluginToCompartmentImmediate(this.#editor?.editor);
+        }
       } else if (this.#aiCodeCompletion) {
         this.#cleanupAiCodeCompletion();
+        if (this.#teaser) {
+          this.#editor?.dispatch({
+            effects: this.#teaserCompartment.reconfigure([]),
+          });
+        }
       }
     }
   }

package/front_end/panels/sources/SourcesPanel.ts

@@ -1212,6 +1212,11 @@ export class SourcesPanel extends UI.Panel.Panel implements
       this.sidebarPaneView.detach();
     }
 
+    if (Root.Runtime.Runtime.isTraceApp()) {
+      this.splitWidget.hideSidebar();
+      return;
+    }
+
     this.splitWidget.setVertical(!vertically);
     this.splitWidget.element.classList.toggle('sources-split-view-vertical', vertically);
 

package/front_end/panels/sources/sources-meta.ts

@@ -5,6 +5,7 @@
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Breakpoints from '../../models/breakpoints/breakpoints.js';
 import * as Workspace from '../../models/workspace/workspace.js';
@@ -528,6 +529,7 @@ UI.ViewManager.registerViewExtension({
   title: i18nLazyString(UIStrings.snippets),
   order: 6,
   persistence: UI.ViewManager.ViewPersistence.PERMANENT,
+  condition: () => !Root.Runtime.Runtime.isTraceApp(),
   async loadView() {
     const Sources = await loadSourcesModule();
     return new Sources.SourcesNavigator.SnippetsNavigatorView();
@@ -1280,18 +1282,17 @@ UI.ActionRegistration.registerActionExtension({
   title: i18nLazyString(UIStrings.createNewSnippet),
 });
 
-if (!Host.InspectorFrontendHost.InspectorFrontendHostInstance.isHostedMode()) {
-  UI.ActionRegistration.registerActionExtension({
-    category: UI.ActionRegistration.ActionCategory.SOURCES,
-    actionId: 'sources.add-folder-to-workspace',
-    async loadActionDelegate() {
-      const Sources = await loadSourcesModule();
-      return new Sources.SourcesNavigator.ActionDelegate();
-    },
-    iconClass: UI.ActionRegistration.IconClass.PLUS,
-    title: i18nLazyString(UIStrings.addFolderToWorkspace),
-  });
-}
+UI.ActionRegistration.registerActionExtension({
+  category: UI.ActionRegistration.ActionCategory.SOURCES,
+  actionId: 'sources.add-folder-to-workspace',
+  condition: () => !Host.InspectorFrontendHost.InspectorFrontendHostInstance.isHostedMode(),
+  async loadActionDelegate() {
+    const Sources = await loadSourcesModule();
+    return new Sources.SourcesNavigator.ActionDelegate();
+  },
+  iconClass: UI.ActionRegistration.IconClass.PLUS,
+  title: i18nLazyString(UIStrings.addFolderToWorkspace),
+});
 
 UI.ActionRegistration.registerActionExtension({
   category: UI.ActionRegistration.ActionCategory.DEBUGGER,

package/front_end/panels/sources/sourcesView.css

@@ -15,6 +15,7 @@
 #sources-panel-sources-view .sources-toolbar {
   display: flex;
   flex: 0 0 auto;
+  min-height: 27px;
   background-color: var(--sys-color-cdt-base-container);
   border-top: 1px solid var(--sys-color-divider);
   overflow: hidden;

package/front_end/panels/timeline/TimelinePanel.ts

@@ -1468,9 +1468,8 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     metadata.enhancedTraceVersion =
         includeScriptContent ? SDK.EnhancedTracesParser.EnhancedTracesParser.enhancedTraceVersion : undefined;
 
-    let fileName = (isCpuProfile ? `CPU-${isoDate}.cpuprofile` :
-                        includeScriptContent ? `EnhancedTrace-${isoDate}.json` :
-                                               `Trace-${isoDate}.json`) as Platform.DevToolsPath.RawPathString;
+    let fileName =
+        (isCpuProfile ? `CPU-${isoDate}.cpuprofile` : `Trace-${isoDate}.json`) as Platform.DevToolsPath.RawPathString;
 
     let blobParts: string[] = [];
     if (isCpuProfile) {
@@ -1638,6 +1637,7 @@ export class TimelinePanel extends Common.ObjectWrapper.eventMixin<EventTypes, t
     const url = new URL(window.location.href);
     const pathToEntrypoint = url.pathname.slice(0, url.pathname.lastIndexOf('/'));
     url.pathname = `${pathToEntrypoint}/trace_app.html`;
+    url.search = '';
     pathToLaunch = url.toString();
 
     // Clarifying the window the code is referring to

package/front_end/panels/timeline/TimelineSelectorStatsView.ts

@@ -11,7 +11,6 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as Trace from '../../models/trace/trace.js';
-import * as CopyToClipboard from '../../ui/components/copy_to_clipboard/copy_to_clipboard.js';
 import type * as Linkifier from '../../ui/components/linkifier/linkifier.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import {html, render} from '../../ui/lit/lit.js';
@@ -259,7 +258,7 @@ export class TimelineSelectorStatsView extends UI.Widget.VBox {
         ].join('\t'));
       }
       const data = tableData.join('\n');
-      CopyToClipboard.copyTextToClipboard(data, i18nString(UIStrings.tableCopiedToClipboard));
+      UI.UIUtils.copyTextToClipboard(data, i18nString(UIStrings.tableCopiedToClipboard));
     });
   }
 

package/front_end/panels/timeline/TimelineTreeView.ts

@@ -799,9 +799,9 @@ export class GridNode extends DataGrid.SortableDataGrid.SortableDataGridNode<Gri
       const parsedTrace = this.treeView.parsedTrace();
       const target = parsedTrace ? targetForEvent(parsedTrace, event) : null;
       const linkifier = this.treeView.linkifier;
-      const isFreshRecording =
-          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace));
-      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshRecording);
+      const isFreshOrEnhanced =
+          Boolean(parsedTrace && Tracing.FreshRecording.Tracker.instance().recordingIsFreshOrEnhanced(parsedTrace));
+      this.linkElement = TimelineUIUtils.linkifyTopCallFrame(event, target, linkifier, isFreshOrEnhanced);
       if (this.linkElement) {
         container.createChild('div', 'activity-link').appendChild(this.linkElement);
       }