chrome-devtools-frontend 1.0.1522585 → 1.0.1524741

package/front_end/core/sdk/CSSMetadata.ts

@@ -362,7 +362,7 @@ export const CubicBezierKeywordValues = new Map([
   ['ease-out', 'cubic-bezier(0, 0, 0.58, 1)'],
 ]);
 
-// CSS-wide keywords.
+/** CSS-wide keywords. **/
 export const enum CSSWideKeyword {
   INHERIT = 'inherit',
   INITIAL = 'initial',
@@ -370,8 +370,10 @@ export const enum CSSWideKeyword {
   REVERT_LAYER = 'revert-layer',
   UNSET = 'unset',
 }
-// Spec: https://drafts.csswg.org/css-cascade/#defaulting-keywords
-// https://drafts.csswg.org/css-cascade-5/#revert-layer
+/**
+ * Spec: https://drafts.csswg.org/css-cascade/#defaulting-keywords
+ * https://drafts.csswg.org/css-cascade-5/#revert-layer
+ **/
 export const CSSWideKeywords: CSSWideKeyword[] = [
   CSSWideKeyword.INHERIT,
   CSSWideKeyword.INITIAL,
@@ -380,7 +382,7 @@ export const CSSWideKeywords: CSSWideKeyword[] = [
   CSSWideKeyword.UNSET,
 ];
 
-// https://www.w3.org/TR/css-anchor-position-1/#typedef-try-size
+/** https://www.w3.org/TR/css-anchor-position-1/#typedef-try-size **/
 export const enum PositionTryOrderKeyword {
   NORMAL = 'normal',
   MOST_HEIGHT = 'most-height',

package/front_end/core/sdk/CSSPropertyParser.ts

@@ -309,11 +309,11 @@ class ComputedTextChunk {
     return this.#cachedComputedText;
   }
 
-  // If the match is top-level, i.e. is an outermost subexpression in the property value, count the number of outermost
-  // subexpressions after applying any potential substitutions.
+  // If the match is top-level, i.e. is an outermost sub-expression in the property value, count the number of outermost
+  // sub-expressions after applying any potential substitutions.
   get topLevelValueCount(): number {
     if (this.match.node.parent?.name !== 'Declaration') {
-      // Not a top-level matchh.
+      // Not a top-level match.
       return 0;
     }
     const computedText = this.computedText;
@@ -332,12 +332,14 @@ class ComputedTextChunk {
   }
 }
 
-// This class constructs the "computed" text from the input property text, i.e., it will strip comments and substitute
-// var() functions if possible. It's intended for use during the bottom-up tree matching process. The original text is
-// not modified. Instead, computed text slices are produced on the fly. During bottom-up matching, the sequence of
-// top-level comments and var() matches will be recorded. This produces an ordered sequence of text pieces that need to
-// be substituted into the original text. When a computed text slice is requested, it is generated by piecing together
-// original and computed slices as required.
+/**
+ * This class constructs the "computed" text from the input property text, i.e., it will strip comments and substitute
+ * var() functions if possible. It's intended for use during the bottom-up tree matching process. The original text is
+ * not modified. Instead, computed text slices are produced on the fly. During bottom-up matching, the sequence of
+ * top-level comments and var() matches will be recorded. This produces an ordered sequence of text pieces that need to
+ * be substituted into the original text. When a computed text slice is requested, it is generated by piecing together
+ * original and computed slices as required.
+ **/
 export class ComputedText {
   readonly #chunks: ComputedTextChunk[] = [];
   readonly text: string;
@@ -486,10 +488,12 @@ export class ComputedText {
   }
 }
 
-// This function determines whether concatenating two pieces of text requires any spacing inbetween. For example, there
-// shouldn't be any space between 'var' and '(', but there should be a space between '1px' and 'solid'. The node
-// sequences that make up the pieces of text may contain non-text nodes/trees. Any such element inbetween the texts is
-// ignored for the spacing requirement.
+/**
+ * This function determines whether concatenating two pieces of text requires any spacing in between. For example, there
+ * shouldn't be any space between 'var' and '(', but there should be a space between '1px' and 'solid'. The node
+ * sequences that make up the pieces of text may contain non-text nodes/trees. Any such element in between the texts is
+ * ignored for the spacing requirement.
+ **/
 export function requiresSpace(a: string, b: string): boolean;
 export function requiresSpace(a: Node[], b: Node[]): boolean;
 export function requiresSpace(a: Node[]|string|undefined, b: Node[]|string|undefined): boolean {

package/front_end/core/sdk/CSSPropertyParserMatchers.ts

@@ -178,13 +178,15 @@ function getCssEvaluationElement(): HTMLElement {
   return cssEvaluationElement;
 }
 
-// These functions use an element in the frontend to evaluate CSS. The advantage
-// of this is that it is synchronous and doesn't require a CDP method. The
-// disadvantage is it lacks context that would allow substitutions such as
-// `var()` and `calc()` to be resolved correctly, and if the user is doing
-// remote debugging there is a possibility that the CSS behavior is different
-// between the two browser versions. We use it for type checking after
-// substitutions (but not for actual evaluation) and for applying units.
+/**
+ * These functions use an element in the frontend to evaluate CSS. The advantage
+ * of this is that it is synchronous and doesn't require a CDP method. The
+ * disadvantage is it lacks context that would allow substitutions such as
+ * `var()` and `calc()` to be resolved correctly, and if the user is doing
+ * remote debugging there is a possibility that the CSS behavior is different
+ * between the two browser versions. We use it for type checking after
+ * substitutions (but not for actual evaluation) and for applying units.
+ **/
 export function localEvalCSS(value: string, type: string): string|null {
   const element = getCssEvaluationElement();
   element.setAttribute('data-value', value);
@@ -192,9 +194,11 @@ export function localEvalCSS(value: string, type: string): string|null {
   return element.computedStyleMap().get('--evaluation')?.toString() ?? null;
 }
 
-// It is important to establish whether a type is valid, because if it is not,
-// the current behavior of blink is to ignore the fallback and parse as a
-// raw string, returning '' if the attribute is not set.
+/**
+ * It is important to establish whether a type is valid, because if it is not,
+ * the current behavior of blink is to ignore the fallback and parse as a
+ * raw string, returning '' if the attribute is not set.
+ **/
 export function isValidCSSType(type: string): boolean {
   const element = getCssEvaluationElement();
   element.setAttribute('data-custom-expr', `attr(data-nonexistent ${type}, "good")`);
@@ -1133,8 +1137,10 @@ export class GridTemplateMatcher extends matcherBase(GridTemplateMatch) {
     // `needClosingLineNames` tracks if the current row can still consume an optional LineNames,
     // which will decide if we should start a new line or not when a LineNames is encountered.
     let needClosingLineNames = false;
-    // Gather row definitions of [<line-names>? <string> <track-size>? <line-names>?], which
-    // be rendered into separate lines.
+    /**
+     * Gather row definitions of [<line-names>? <string> <track-size>? <line-names>?], which
+     * be rendered into separate lines.
+     **/
     function parseNodes(nodes: CodeMirror.SyntaxNode[], varParsingMode = false): void {
       for (const curNode of nodes) {
         if (matching.getMatch(curNode) instanceof BaseVariableMatch) {
@@ -1247,7 +1253,7 @@ export class AnchorFunctionMatcher extends matcherBase(AnchorFunctionMatch) {
   }
 }
 
-// For linking `position-anchor: --anchor-name`.
+/** For linking `position-anchor: --anchor-name`. **/
 export class PositionAnchorMatch implements Match {
   constructor(readonly text: string, readonly matching: BottomUpTreeMatching, readonly node: CodeMirror.SyntaxNode) {
   }

package/front_end/core/sdk/ChildTargetManager.ts

@@ -12,6 +12,8 @@ import type * as ProtocolClient from '../protocol_client/protocol_client.js';
 import {ParallelConnection} from './Connections.js';
 import {PrimaryPageChangeType, ResourceTreeModel} from './ResourceTreeModel.js';
 import {SDKModel} from './SDKModel.js';
+import {SecurityOriginManager} from './SecurityOriginManager.js';
+import {StorageKeyManager} from './StorageKeyManager.js';
 import {Capability, type Target, Type} from './Target.js';
 import {Events as TargetManagerEvents, TargetManager} from './TargetManager.js';
 
@@ -204,6 +206,39 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
     if (waitingForDebugger) {
       void target.runtimeAgent().invoke_runIfWaitingForDebugger();
     }
+
+    // For top-level workers (those not attached to a frame), we need to
+    // initialize their storage context manually. The `Capability.STORAGE` is
+    // only granted in `Target.ts` to workers that are not parented by a frame,
+    // which makes this check safe. Frame-associated workers have their storage
+    // managed by ResourceTreeModel.
+    if (type !== Type.FRAME && target.hasAllCapabilities(Capability.STORAGE)) {
+      await this.initializeStorage(target);
+    }
+  }
+
+  private async initializeStorage(target: Target): Promise<void> {
+    const storageAgent = target.storageAgent();
+    const response = await storageAgent.invoke_getStorageKey({});
+
+    const storageKey = response.storageKey;
+    if (response.getError() || !storageKey) {
+      console.error(`Failed to get storage key for target ${target.id()}: ${response.getError()}`);
+      return;
+    }
+
+    const storageKeyManager = target.model(StorageKeyManager);
+    if (storageKeyManager) {
+      storageKeyManager.setMainStorageKey(storageKey);
+      storageKeyManager.updateStorageKeys(new Set([storageKey]));
+    }
+
+    const securityOriginManager = target.model(SecurityOriginManager);
+    if (securityOriginManager) {
+      const origin = new URL(storageKey).origin;
+      securityOriginManager.setMainSecurityOrigin(origin, '');
+      securityOriginManager.updateSecurityOrigins(new Set([origin]));
+    }
   }
 
   detachedFromTarget({sessionId}: Protocol.Target.DetachedFromTargetEvent): void {

package/front_end/core/sdk/DOMModel.ts

@@ -49,7 +49,7 @@ import {SDKModel} from './SDKModel.js';
 import {Capability, type Target} from './Target.js';
 import {TargetManager} from './TargetManager.js';
 
-// Keep this list in sync with https://w3c.github.io/aria/#state_prop_def
+/** Keep this list in sync with https://w3c.github.io/aria/#state_prop_def **/
 export const ARIA_ATTRIBUTES = new Set<string>([
   'role',
   'aria-activedescendant',

package/front_end/core/sdk/EventBreakpointsModel.ts

@@ -51,8 +51,10 @@ export class EventBreakpointsModel extends SDKModel<void> {
   }
 }
 
-// This implementation (as opposed to similar class in DOMDebuggerModel) is for
-// instrumentation breakpoints in targets that run JS but do not have a DOM.
+/**
+ * This implementation (as opposed to similar class in DOMDebuggerModel) is for
+ * instrumentation breakpoints in targets that run JS but do not have a DOM.
+ **/
 class EventListenerBreakpoint extends CategorizedBreakpoint {
   override setEnabled(enabled: boolean): void {
     if (this.enabled() === enabled) {

package/front_end/core/sdk/HttpReasonPhraseStrings.ts

@@ -4,8 +4,10 @@
 
 import * as i18n from '../i18n/i18n.js';
 
-// Reason phrase sources
-// See https://www.rfc-editor.org/rfc/rfc9110.html#name-status-codes
+/**
+ * Reason phrase sources
+ * See https://www.rfc-editor.org/rfc/rfc9110.html#name-status-codes
+ **/
 export function getStatusText(statusCode: number): string {
   const statusTextLookup: Record<number, string> = {
     100: 'Continue',

package/front_end/core/sdk/NetworkManager.ts

@@ -23,8 +23,6 @@ import {
   type IncludedCookieWithReason,
   type NameValue,
   NetworkRequest,
-  type WebBundleInfo,
-  type WebBundleInnerRequestInfo
 } from './NetworkRequest.js';
 import {SDKModel} from './SDKModel.js';
 import {Capability, type Target} from './Target.js';
@@ -1502,44 +1500,20 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     request.setTrustTokenOperationDoneEvent(event);
   }
 
-  subresourceWebBundleMetadataReceived({requestId, urls}: Protocol.Network.SubresourceWebBundleMetadataReceivedEvent):
-      void {
-    const extraInfoBuilder = this.getExtraInfoBuilder(requestId);
-    extraInfoBuilder.setWebBundleInfo({resourceUrls: urls as Platform.DevToolsPath.UrlString[]});
-    const finalRequest = extraInfoBuilder.finalRequest();
-    if (finalRequest) {
-      this.updateNetworkRequest(finalRequest);
-    }
+  subresourceWebBundleMetadataReceived(): void {
+    // TODO: remove implementation after deleting this methods from definition in Network.pdl
   }
 
-  subresourceWebBundleMetadataError({requestId, errorMessage}: Protocol.Network.SubresourceWebBundleMetadataErrorEvent):
-      void {
-    const extraInfoBuilder = this.getExtraInfoBuilder(requestId);
-    extraInfoBuilder.setWebBundleInfo({errorMessage});
-    const finalRequest = extraInfoBuilder.finalRequest();
-    if (finalRequest) {
-      this.updateNetworkRequest(finalRequest);
-    }
+  subresourceWebBundleMetadataError(): void {
+    // TODO: remove implementation after deleting this methods from definition in Network.pdl
   }
 
-  subresourceWebBundleInnerResponseParsed({innerRequestId, bundleRequestId}:
-                                              Protocol.Network.SubresourceWebBundleInnerResponseParsedEvent): void {
-    const extraInfoBuilder = this.getExtraInfoBuilder(innerRequestId);
-    extraInfoBuilder.setWebBundleInnerRequestInfo({bundleRequestId});
-    const finalRequest = extraInfoBuilder.finalRequest();
-    if (finalRequest) {
-      this.updateNetworkRequest(finalRequest);
-    }
+  subresourceWebBundleInnerResponseParsed(): void {
+    // TODO: remove implementation after deleting this methods from definition in Network.pdl
   }
 
-  subresourceWebBundleInnerResponseError({innerRequestId, errorMessage}:
-                                             Protocol.Network.SubresourceWebBundleInnerResponseErrorEvent): void {
-    const extraInfoBuilder = this.getExtraInfoBuilder(innerRequestId);
-    extraInfoBuilder.setWebBundleInnerRequestInfo({errorMessage});
-    const finalRequest = extraInfoBuilder.finalRequest();
-    if (finalRequest) {
-      this.updateNetworkRequest(finalRequest);
-    }
+  subresourceWebBundleInnerResponseError(): void {
+    // TODO: remove implementation after deleting this methods from definition in Network.pdl
   }
 
   reportingApiReportAdded(data: Protocol.Network.ReportingApiReportAddedEvent): void {
@@ -2151,8 +2125,6 @@ class ExtraInfoBuilder {
   #responseExtraInfos: Array<ExtraResponseInfo|null> = [];
   #responseEarlyHintsHeaders: NameValue[] = [];
   #finished = false;
-  #webBundleInfo: WebBundleInfo|null = null;
-  #webBundleInnerRequestInfo: WebBundleInnerRequestInfo|null = null;
 
   addRequest(req: NetworkRequest): void {
     this.#requests.push(req);
@@ -2189,16 +2161,6 @@ class ExtraInfoBuilder {
     this.updateFinalRequest();
   }
 
-  setWebBundleInfo(info: WebBundleInfo): void {
-    this.#webBundleInfo = info;
-    this.updateFinalRequest();
-  }
-
-  setWebBundleInnerRequestInfo(info: WebBundleInnerRequestInfo): void {
-    this.#webBundleInnerRequestInfo = info;
-    this.updateFinalRequest();
-  }
-
   finished(): void {
     this.#finished = true;
     // We may have missed responseReceived event in case of failure.
@@ -2260,8 +2222,6 @@ class ExtraInfoBuilder {
       return;
     }
     const finalRequest = this.finalRequest();
-    finalRequest?.setWebBundleInfo(this.#webBundleInfo);
-    finalRequest?.setWebBundleInnerRequestInfo(this.#webBundleInnerRequestInfo);
     finalRequest?.setEarlyHintsHeaders(this.#responseEarlyHintsHeaders);
   }
 }

package/front_end/core/sdk/NetworkRequest.ts

@@ -236,8 +236,6 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
   #initialPriority: Protocol.Network.ResourcePriority|null = null;
   #currentPriority: Protocol.Network.ResourcePriority|null = null;
   #signedExchangeInfo: Protocol.Network.SignedExchangeInfo|null = null;
-  #webBundleInfo: WebBundleInfo|null = null;
-  #webBundleInnerRequestInfo: WebBundleInnerRequestInfo|null = null;
   #resourceType: Common.ResourceType.ResourceType = Common.ResourceType.resourceTypes.Other;
   #contentData: Promise<TextUtils.ContentData.ContentDataOrError>|null = null;
   #streamingContentData: Promise<TextUtils.StreamingContentData.StreamingContentDataOrError>|null = null;
@@ -1500,22 +1498,6 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     return this.#signedExchangeInfo;
   }
 
-  setWebBundleInfo(info: WebBundleInfo|null): void {
-    this.#webBundleInfo = info;
-  }
-
-  webBundleInfo(): WebBundleInfo|null {
-    return this.#webBundleInfo;
-  }
-
-  setWebBundleInnerRequestInfo(info: WebBundleInnerRequestInfo|null): void {
-    this.#webBundleInnerRequestInfo = info;
-  }
-
-  webBundleInnerRequestInfo(): WebBundleInnerRequestInfo|null {
-    return this.#webBundleInnerRequestInfo;
-  }
-
   async populateImageSource(image: HTMLImageElement): Promise<void> {
     const contentData = await this.requestContentData();
     if (TextUtils.ContentData.ContentData.isError(contentData)) {
@@ -2207,16 +2189,6 @@ export interface EarlyHintsInfo {
   responseHeaders: NameValue[];
 }
 
-export interface WebBundleInfo {
-  resourceUrls?: Platform.DevToolsPath.UrlString[];
-  errorMessage?: string;
-}
-
-export interface WebBundleInnerRequestInfo {
-  bundleRequestId?: string;
-  errorMessage?: string;
-}
-
 export type OverrideType = 'content'|'headers';
 
 export enum DirectSocketType {

package/front_end/core/sdk/PageResourceLoader.ts

@@ -59,7 +59,7 @@ export interface PageResource {
   duration: number|null;
 }
 
-// Used for revealing a resource.
+/** Used for revealing a resource. **/
 export class ResourceKey {
   readonly key: string;
 

package/front_end/core/sdk/PreloadingModel.ts

@@ -23,11 +23,13 @@ export interface WithId<I, V> {
   value: V;
 }
 
-// Holds preloading related information.
-//
-// - SpeculationRule rule sets
-// - Preloading attempts
-// - Relationship between rule sets and preloading attempts
+/**
+ * Holds preloading related information.
+ *
+ * - SpeculationRule rule sets
+ * - Preloading attempts
+ * - Relationship between rule sets and preloading attempts
+ **/
 export class PreloadingModel extends SDKModel<EventTypes> {
   private agent: ProtocolProxyApi.PreloadApi;
   private loaderIds: Protocol.Network.LoaderId[] = [];
@@ -410,19 +412,21 @@ class RuleSetRegistry {
   }
 }
 
-// Protocol.Preload.PreloadingStatus|'NotTriggered'
-//
-// A renderer sends SpeculationCandidate to the browser process and the
-// browser process checks eligibilities, and starts PreloadingAttempt.
-//
-// In the frontend, "NotTriggered" is used to denote that a
-// PreloadingAttempt is waiting for at trigger event (eg:
-// mousedown/mouseover). All PreloadingAttempts will start off as
-// "NotTriggered", but "eager" preloading attempts (attempts not
-// actually waiting for any trigger) will be processed by the browser
-// immediately, and will not stay in this state for long.
-//
-// TODO(https://crbug.com/1384419): Add NotEligible.
+/**
+ * Protocol.Preload.PreloadingStatus|'NotTriggered'
+ *
+ * A renderer sends SpeculationCandidate to the browser process and the
+ * browser process checks eligibilities, and starts PreloadingAttempt.
+ *
+ * In the frontend, "NotTriggered" is used to denote that a
+ * PreloadingAttempt is waiting for at trigger event (eg:
+ * mousedown/mouseover). All PreloadingAttempts will start off as
+ * "NotTriggered", but "eager" preloading attempts (attempts not
+ * actually waiting for any trigger) will be processed by the browser
+ * immediately, and will not stay in this state for long.
+ *
+ * TODO(https://crbug.com/1384419): Add NotEligible.
+ **/
 export const enum PreloadingStatus {
   NOT_TRIGGERED = 'NotTriggered',
   PENDING = 'Pending',

package/front_end/core/sdk/RehydratingConnection.ts

@@ -210,7 +210,7 @@ export class RehydratingConnection implements ProtocolClient.InspectorBackend.Co
   }
 }
 
-// Default rehydrating session with default responses.
+/** Default rehydrating session with default responses. **/
 class RehydratingSessionBase {
   connection: RehydratingConnectionInterface|null = null;
 

package/front_end/core/sdk/RehydratingObject.ts

@@ -4,7 +4,7 @@
 
 import type * as Protocol from '../../generated/protocol.js';
 
-// This object is emitted to ScriptParsed and also used in the RehydratingConnection
+/** This object is emitted to ScriptParsed and also used in the RehydratingConnection **/
 export interface RehydratingScript extends Protocol.Debugger.ScriptParsedEvent {
   sourceText?: string;
   executionContextAuxData?: RehydratingExecutionContextAuxData;

package/front_end/core/sdk/RemoteObject.ts

@@ -9,7 +9,7 @@ import type {DOMPinnedWebIDLProp, DOMPinnedWebIDLType} from '../common/JavaScrip
 import type {DebuggerModel, FunctionDetails} from './DebuggerModel.js';
 import type {RuntimeModel} from './RuntimeModel.js';
 
-// This cannot be an interface due to "instanceof RemoteObject" checks in the code.
+/** This cannot be an interface due to "instanceof RemoteObject" checks in the code. **/
 export abstract class RemoteObject {
   static fromLocalObject(value: unknown): RemoteObject {
     return new LocalJSONObject(value);

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -104,6 +104,8 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
     if (!this.framesInternal.has(frameId)) {
       return null;
     }
+
+    // TODO(crbug.com/445966299): Refactor to use `storageAgent().invoke_getStorageKey()` instead.
     const response = await this.storageAgent.invoke_getStorageKeyForFrame({frameId});
     if (response.getError() === 'Frame tree node for given frame not found') {
       return null;

package/front_end/core/sdk/ScreenCaptureModel.ts

@@ -15,8 +15,10 @@ export const enum ScreenshotMode {
   FULLPAGE = 'fullpage',
 }
 
-// This structure holds a specific `startScreencast` request's parameters
-// and its callbacks so that they can be re-started if needed.
+/**
+ * This structure holds a specific `startScreencast` request's parameters
+ * and its callbacks so that they can be re-started if needed.
+ **/
 interface ScreencastOperation {
   id: number;
   request: {
@@ -35,24 +37,26 @@ interface ScreencastOperation {
 type ScreencastFrameCallback = ((arg0: Protocol.binary, arg1: Protocol.Page.ScreencastFrameMetadata) => void);
 type ScreencastVisibilityChangedCallback = ((arg0: boolean) => void);
 
-// Manages concurrent screencast requests by queuing and prioritizing.
-//
-// When startScreencast is invoked:
-//   - If a screencast is currently active, the existing screencast's parameters and callbacks are
-//     saved in the #screencastOperations array.
-//   - The active screencast is then stopped.
-//   - A new screencast is initiated using the parameters and callbacks from the current startScreencast call.
-//
-// When stopScreencast is invoked:
-//   - The currently active screencast is stopped.
-//   - The #screencastOperations is checked for interrupted screencast operations.
-//   - If any operations are found, the latest one is started
-//     using its saved parameters and callbacks.
-//
-// This ensures that:
-//   - Only one screencast is active at a time.
-//   - Interrupted screencasts are resumed after the current screencast is stopped.
-// This ensures animation previews, which use screencasting, don't disrupt ongoing remote debugging sessions. Without this mechanism, stopping a preview screencast would terminate the debugging screencast, freezing the ScreencastView.
+/**
+ * Manages concurrent screencast requests by queuing and prioritizing.
+ *
+ * When startScreencast is invoked:
+ * - If a screencast is currently active, the existing screencast's parameters and callbacks are
+ * saved in the #screencastOperations array.
+ * - The active screencast is then stopped.
+ * - A new screencast is initiated using the parameters and callbacks from the current startScreencast call.
+ *
+ * When stopScreencast is invoked:
+ * - The currently active screencast is stopped.
+ * - The #screencastOperations is checked for interrupted screencast operations.
+ * - If any operations are found, the latest one is started
+ * using its saved parameters and callbacks.
+ *
+ * This ensures that:
+ * - Only one screencast is active at a time.
+ * - Interrupted screencasts are resumed after the current screencast is stopped.
+ * This ensures animation previews, which use screencasting, don't disrupt ongoing remote debugging sessions. Without this mechanism, stopping a preview screencast would terminate the debugging screencast, freezing the ScreencastView.
+ **/
 export class ScreenCaptureModel extends SDKModel<void> implements ProtocolProxyApi.PageDispatcher {
   readonly #agent: ProtocolProxyApi.PageApi;
   #nextScreencastOperationId = 1;

package/front_end/core/sdk/Target.ts

@@ -67,12 +67,15 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.NETWORK | Capability.TARGET |
             Capability.INSPECTOR | Capability.IO | Capability.EVENT_BREAKPOINTS;
         if (parentTarget?.type() !== Type.FRAME) {
-          this.#capabilitiesMask |= Capability.BROWSER;
+          this.#capabilitiesMask |= Capability.BROWSER | Capability.STORAGE;
         }
         break;
       case Type.SHARED_WORKER:
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.NETWORK | Capability.TARGET |
             Capability.IO | Capability.MEDIA | Capability.INSPECTOR | Capability.EVENT_BREAKPOINTS;
+        if (parentTarget?.type() !== Type.FRAME) {
+          this.#capabilitiesMask |= Capability.STORAGE;
+        }
         break;
       case Type.SHARED_STORAGE_WORKLET:
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.INSPECTOR | Capability.EVENT_BREAKPOINTS;
@@ -80,6 +83,9 @@ export class Target extends ProtocolClient.InspectorBackend.TargetBase {
       case Type.Worker:
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.NETWORK | Capability.TARGET |
             Capability.IO | Capability.MEDIA | Capability.EMULATION | Capability.EVENT_BREAKPOINTS;
+        if (parentTarget?.type() !== Type.FRAME) {
+          this.#capabilitiesMask |= Capability.STORAGE;
+        }
         break;
       case Type.WORKLET:
         this.#capabilitiesMask = Capability.JS | Capability.LOG | Capability.EVENT_BREAKPOINTS | Capability.NETWORK;

package/front_end/core/sdk/TraceObject.ts

@@ -10,7 +10,7 @@ import type {NetworkRequest} from './NetworkRequest.js';
 import {ResourceTreeModel} from './ResourceTreeModel.js';
 import type {SourceMapV3} from './SourceMap.js';
 
-// A thin wrapper class, mostly to enable instanceof-based revealing of traces to open in Timeline.
+/** A thin wrapper class, mostly to enable instanceof-based revealing of traces to open in Timeline. **/
 export class TraceObject {
   readonly traceEvents: Protocol.Tracing.DataCollectedEvent['value'];
   readonly metadata: {sourceMaps?: Array<{sourceMapUrl: string, sourceMap: SourceMapV3, url: string}>};
@@ -24,7 +24,7 @@ export class TraceObject {
   }
 }
 
-// Another thin wrapper class to enable revealing individual trace events (aka entries) in Timeline panel.
+/** Another thin wrapper class to enable revealing individual trace events (aka entries) in Timeline panel. **/
 export class RevealableEvent {
   // Only Trace.Types.Events.Event are passed in, but we can't depend on that type from SDK
   /* eslint-disable-next-line @typescript-eslint/no-explicit-any */

package/front_end/entrypoints/formatter_worker/Substitute.ts

@@ -20,10 +20,12 @@ interface Replacement {
   isShorthandAssignmentProperty: boolean;
 }
 
-// Given an |expression| and a mapping from names to new names, the |computeSubstitution|
-// function returns a list of replacements sorted by the offset. The function throws if
-// it cannot parse the expression or the substitution is impossible to perform (for example
-// if the substitution target is 'this' within a function, it would become bound there).
+/**
+ * Given an |expression| and a mapping from names to new names, the |computeSubstitution|
+ * function returns a list of replacements sorted by the offset. The function throws if
+ * it cannot parse the expression or the substitution is impossible to perform (for example
+ * if the substitution target is 'this' within a function, it would become bound there).
+ **/
 function computeSubstitution(expression: string, nameMap: Map<string, string|null>): Replacement[] {
   // Parse the expression and find variables and scopes.
   const root = Acorn.parse(expression, {