chrome-devtools-frontend 1.0.1522145 → 1.0.1524741

package/front_end/third_party/puppeteer/package/src/bidi/Page.ts

@@ -245,7 +245,7 @@ export class BidiPage extends Page {
   }
 
   override async setBypassCSP(enabled: boolean): Promise<void> {
-    // TODO: handle CDP-specific cases such as mprach.
+    // TODO: handle CDP-specific cases such as MPArch.
     await this._client().send('Page.setBypassCSP', {enabled});
   }
 
@@ -626,7 +626,7 @@ export class BidiPage extends Page {
       );
       return;
     }
-    // TODO: handle CDP-specific cases such as mprach.
+    // TODO: handle CDP-specific cases such as MPArch.
     await this._client().send('Network.setCacheDisabled', {
       cacheDisabled: !enabled,
     });
@@ -711,11 +711,20 @@ export class BidiPage extends Page {
     return [...this.#workers];
   }
 
-  #userInterception?: string;
+  get isNetworkInterceptionEnabled(): boolean {
+    return (
+      Boolean(this.#requestInterception) ||
+      Boolean(this.#extraHeadersInterception) ||
+      Boolean(this.#authInterception) ||
+      Boolean(this.#userAgentInterception)
+    );
+  }
+
+  #requestInterception?: string;
   override async setRequestInterception(enable: boolean): Promise<void> {
-    this.#userInterception = await this.#toggleInterception(
+    this.#requestInterception = await this.#toggleInterception(
       [Bidi.Network.InterceptPhase.BeforeRequestSent],
-      this.#userInterception,
+      this.#requestInterception,
       enable,
     );
   }
@@ -1054,7 +1063,7 @@ export function bidiToPuppeteerCookie(
 ): Cookie {
   const partitionKey = bidiCookie[CDP_SPECIFIC_PREFIX + 'partitionKey'];
 
-  function getParitionKey(): {partitionKey?: Cookie['partitionKey']} {
+  function getPartitionKey(): {partitionKey?: Cookie['partitionKey']} {
     if (typeof partitionKey === 'string') {
       return {partitionKey};
     }
@@ -1096,7 +1105,7 @@ export function bidiToPuppeteerCookie(
       'partitionKeyOpaque',
       'priority',
     ),
-    ...getParitionKey(),
+    ...getPartitionKey(),
   };
 }
 

package/front_end/third_party/puppeteer/package/src/bidi/core/Browser.ts

@@ -7,6 +7,7 @@
 import type * as Bidi from 'webdriver-bidi-protocol';
 
 import type {BrowserContextOptions} from '../../api/Browser.js';
+import {UnsupportedOperation} from '../../common/Errors.js';
 import {EventEmitter} from '../../common/EventEmitter.js';
 import {inertIfDisposed, throwIfDisposed} from '../../util/decorators.js';
 import {DisposableStack, disposeSymbol} from '../../util/disposable.js';
@@ -232,11 +233,36 @@ export class Browser extends EventEmitter<{
             noProxy: options.proxyBypassList,
           };
     const {
-      result: {userContext: context},
+      result: {userContext},
     } = await this.session.send('browser.createUserContext', {
       proxy: proxyConfig,
     });
-    return this.#createUserContext(context);
+    if (options.downloadBehavior?.policy === 'allowAndName') {
+      throw new UnsupportedOperation(
+        '`allowAndName` is not supported in WebDriver BiDi',
+      );
+    }
+    if (options.downloadBehavior?.policy === 'allow') {
+      if (options.downloadBehavior.downloadPath === undefined) {
+        throw new UnsupportedOperation(
+          '`downloadPath` is required in `allow` download behavior',
+        );
+      }
+      await this.session.send('browser.setDownloadBehavior', {
+        downloadBehavior: {
+          type: 'allowed',
+          destinationFolder: options.downloadBehavior.downloadPath,
+        },
+        userContexts: [userContext],
+      });
+    }
+    if (options.downloadBehavior?.policy === 'deny') {
+      await this.session.send('browser.setDownloadBehavior', {
+        downloadBehavior: {type: 'denied'},
+        userContexts: [userContext],
+      });
+    }
+    return this.#createUserContext(userContext);
   }
 
   @throwIfDisposed<Browser>(browser => {

package/front_end/third_party/puppeteer/package/src/cdp/HTTPRequest.ts

@@ -170,6 +170,10 @@ export class CdpHTTPRequest extends HTTPRequest {
     };
   }
 
+  protected canBeIntercepted(): boolean {
+    return !this.url().startsWith('data:') && !this._fromMemoryCache;
+  }
+
   /**
    * @internal
    */

package/front_end/third_party/puppeteer/package/src/cdp/PredefinedNetworkConditions.ts

@@ -14,28 +14,19 @@ import type {NetworkConditions} from './NetworkManager.js';
  *
  * ```ts
  * import {PredefinedNetworkConditions} from 'puppeteer';
- * (async () => {
- *   const browser = await puppeteer.launch();
- *   const page = await browser.newPage();
- *   await page.emulateNetworkConditions(
- *     PredefinedNetworkConditions['Slow 3G'],
- *   );
- *   await page.goto('https://www.google.com');
- *   await page.emulateNetworkConditions(
- *     PredefinedNetworkConditions['Fast 3G'],
- *   );
- *   await page.goto('https://www.google.com');
- *   await page.emulateNetworkConditions(
- *     PredefinedNetworkConditions['Slow 4G'],
- *   ); // alias to Fast 3G.
- *   await page.goto('https://www.google.com');
- *   await page.emulateNetworkConditions(
- *     PredefinedNetworkConditions['Fast 4G'],
- *   );
- *   await page.goto('https://www.google.com');
- *   // other actions...
- *   await browser.close();
- * })();
+ * const browser = await puppeteer.launch();
+ * const page = await browser.newPage();
+ * await page.emulateNetworkConditions(PredefinedNetworkConditions['Slow 3G']);
+ * await page.goto('https://www.google.com');
+ * await page.emulateNetworkConditions(PredefinedNetworkConditions['Fast 3G']);
+ * await page.goto('https://www.google.com');
+ * // alias to Fast 3G.
+ * await page.emulateNetworkConditions(PredefinedNetworkConditions['Slow 4G']);
+ * await page.goto('https://www.google.com');
+ * await page.emulateNetworkConditions(PredefinedNetworkConditions['Fast 4G']);
+ * await page.goto('https://www.google.com');
+ * // other actions...
+ * await browser.close();
  * ```
  *
  * @public

package/front_end/third_party/puppeteer/package/src/common/Device.ts

@@ -1738,14 +1738,12 @@ for (const device of knownDevices) {
  * import {KnownDevices} from 'puppeteer';
  * const iPhone = KnownDevices['iPhone 15 Pro'];
  *
- * (async () => {
- *   const browser = await puppeteer.launch();
- *   const page = await browser.newPage();
- *   await page.emulate(iPhone);
- *   await page.goto('https://www.google.com');
- *   // other actions...
- *   await browser.close();
- * })();
+ * const browser = await puppeteer.launch();
+ * const page = await browser.newPage();
+ * await page.emulate(iPhone);
+ * await page.goto('https://www.google.com');
+ * // other actions...
+ * await browser.close();
  * ```
  *
  * @public

package/front_end/third_party/puppeteer/package/src/generated/version.ts

@@ -1,4 +1,4 @@
 /**
  * @internal
  */
-export const packageVersion = '24.22.3';
+export const packageVersion = '24.23.0';

package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts

@@ -372,7 +372,7 @@ export abstract class BrowserLauncher {
    */
   protected async createBiDiOverCdpBrowser(
     browserProcess: ReturnType<typeof launch>,
-    connection: Connection,
+    cdpConnection: Connection,
     closeCallback: BrowserCloseCallback,
     opts: {
       defaultViewport: Viewport | null;
@@ -380,11 +380,14 @@ export abstract class BrowserLauncher {
       networkEnabled: boolean;
     },
   ): Promise<Browser> {
+    const bidiOnly = process.env['PUPPETEER_WEBDRIVER_BIDI_ONLY'] === 'true';
     const BiDi = await import(/* webpackIgnore: true */ '../bidi/bidi.js');
-    const bidiConnection = await BiDi.connectBidiOverCdp(connection);
+    const bidiConnection = await BiDi.connectBidiOverCdp(cdpConnection);
     return await BiDi.BidiBrowser.create({
       connection: bidiConnection,
-      cdpConnection: connection,
+      // Do not provide CDP connection to Browser, if BiDi-only mode is enabled. This
+      // would restrict Browser to use only BiDi endpoint.
+      cdpConnection: bidiOnly ? undefined : cdpConnection,
       closeCallback,
       process: browserProcess.nodeProcess,
       defaultViewport: opts.defaultViewport,

package/front_end/third_party/puppeteer/package/src/node/PuppeteerNode.ts

@@ -44,13 +44,11 @@ import type {ChromeReleaseChannel, LaunchOptions} from './LaunchOptions.js';
  * ```ts
  * import puppeteer from 'puppeteer';
  *
- * (async () => {
- *   const browser = await puppeteer.launch();
- *   const page = await browser.newPage();
- *   await page.goto('https://www.google.com');
- *   // other actions...
- *   await browser.close();
- * })();
+ * const browser = await puppeteer.launch();
+ * const page = await browser.newPage();
+ * await page.goto('https://www.google.com');
+ * // other actions...
+ * await browser.close();
  * ```
  *
  * Once you have created a `page` you have access to a large API to interact

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '140.0.7339.207',
-  'chrome-headless-shell': '140.0.7339.207',
-  firefox: 'stable_143.0.1',
+  chrome: '141.0.7390.54',
+  'chrome-headless-shell': '141.0.7390.54',
+  firefox: 'stable_143.0.3',
 });

package/front_end/ui/components/chrome_link/ChromeLink.ts

@@ -19,8 +19,10 @@ declare global {
   }
 }
 
-// Use this component to render links to 'chrome://...'-URLs
-// (for which regular <x-link>s do not work).
+/**
+ * Use this component to render links to 'chrome://...'-URLs
+ * (for which regular <x-link>s do not work).
+ **/
 export class ChromeLink extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
   #href = '';

package/front_end/ui/components/dialogs/Dialog.ts

@@ -29,9 +29,11 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const IS_DIALOG_SUPPORTED = 'HTMLDialogElement' in globalThis;
 
-// Height in pixels of the dialog's connector. The connector is represented as
-// as a diamond and the height corresponds to half the height of the diamond.
-// (the visible height is only half of the diamond).
+/**
+ * Height in pixels of the dialog's connector. The connector is represented as
+ * as a diamond and the height corresponds to half the height of the diamond.
+ * (the visible height is only half of the diamond).
+ **/
 export const CONNECTOR_HEIGHT = 10;
 const CONNECTOR_WIDTH = 2 * CONNECTOR_HEIGHT;
 
@@ -41,12 +43,14 @@ const DIALOG_ANIMATION_OFFSET = 20;
 export const DIALOG_SIDE_PADDING = 5;
 export const DIALOG_VERTICAL_PADDING = 3;
 
-// If the content of the dialog cannot be completely shown because otherwise
-// the dialog would overflow the window, the dialog's max width and height are
-// set such that the dialog remains inside the visible bounds. In this cases
-// some extra, determined by this constant, is added so that the dialog's borders
-// remain clearly visible. This constant accounts for the padding of the dialog's
-// content (20 px) and a 5px gap left on each extreme of the dialog from the viewport.
+/**
+ * If the content of the dialog cannot be completely shown because otherwise
+ * the dialog would overflow the window, the dialog's max width and height are
+ * set such that the dialog remains inside the visible bounds. In this cases
+ * some extra, determined by this constant, is added so that the dialog's borders
+ * remain clearly visible. This constant accounts for the padding of the dialog's
+ * content (20 px) and a 5px gap left on each extreme of the dialog from the viewport.
+ **/
 export const DIALOG_PADDING_FROM_WINDOW = 3 * CONNECTOR_HEIGHT;
 interface DialogData {
   /**

package/front_end/ui/components/highlighting/HighlightElement.ts

@@ -0,0 +1,77 @@
+// Copyright 2025 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as TextUtils from '../../../models/text_utils/text_utils.js';
+
+import {HighlightManager} from './HighlightManager.js';
+
+export class HighlightElement extends HTMLElement {
+  static readonly observedAttributes = ['ranges', 'current-range'];
+  #ranges: TextUtils.TextRange.SourceRange[] = [];
+  #currentRange: TextUtils.TextRange.SourceRange|undefined;
+
+  attributeChangedCallback(name: string, oldValue: string|null, newValue: string|null): void {
+    if (oldValue === newValue) {
+      return;
+    }
+    switch (name) {
+      case 'ranges':
+        this.#ranges = parseRanges(newValue);
+        break;
+      case 'current-range':
+        this.#currentRange = parseRanges(newValue)[0];
+        break;
+    }
+    HighlightManager.instance().set(this, this.#ranges, this.#currentRange);
+  }
+}
+
+function parseRanges(value: string|null): TextUtils.TextRange.SourceRange[] {
+  if (!value) {
+    return [];
+  }
+  const ranges = value.split(' ')
+                     .filter(rangeString => {
+                       const parts = rangeString.split(',');
+                       // A valid range string must have exactly two parts.
+                       if (parts.length !== 2) {
+                         return false;
+                       }
+                       // Both parts must be convertible to valid numbers.
+                       const num1 = Number(parts[0]);
+                       const num2 = Number(parts[1]);
+                       return !isNaN(num1) && !isNaN(num2);
+                     })
+                     .map(rangeString => {
+                       const parts = rangeString.split(',').map(part => Number(part));
+                       return new TextUtils.TextRange.SourceRange(parts[0], parts[1]);
+                     });
+  return sortAndMergeRanges(ranges);
+}
+
+function sortAndMergeRanges(ranges: TextUtils.TextRange.SourceRange[]): TextUtils.TextRange.SourceRange[] {
+  // Sort by start position.
+  ranges.sort((a, b) => a.offset - b.offset);
+
+  if (ranges.length === 0) {
+    return [];
+  }
+
+  // Merge overlapping ranges.
+  const merged = [ranges[0]];
+  for (let i = 1; i < ranges.length; i++) {
+    const last = merged[merged.length - 1];
+    const current = ranges[i];
+    if (current.offset <= last.offset + last.length) {
+      const newEnd = Math.max(last.offset + last.length, current.offset + current.length);
+      const newLength = newEnd - last.offset;
+      merged[merged.length - 1] = new TextUtils.TextRange.SourceRange(last.offset, newLength);
+    } else {
+      merged.push(current);
+    }
+  }
+  return merged;
+}
+
+customElements.define('devtools-highlight', HighlightElement);

package/front_end/ui/components/highlighting/HighlightManager.ts

@@ -62,10 +62,17 @@ export class RangeWalker {
 export const HIGHLIGHT_REGISTRY = 'highlighted-search-result';
 export const CURRENT_HIGHLIGHT_REGISTRY = 'current-search-result';
 
+interface HighlightState {
+  activeRanges: Range[];
+  ranges: TextUtils.TextRange.SourceRange[];
+  currentRange: TextUtils.TextRange.SourceRange|undefined;
+}
+
 let highlightManagerInstance: HighlightManager;
 export class HighlightManager {
   #highlights = new Highlight();
   #currentHighlights = new Highlight();
+  #stateByNode = new WeakMap<Node, HighlightState>();
 
   constructor() {
     CSS.highlights.set(HIGHLIGHT_REGISTRY, this.#highlights);
@@ -119,4 +126,34 @@ export class HighlightManager {
     }
     return ranges;
   }
+
+  #getOrCreateState(node: Node): HighlightState {
+    let state = this.#stateByNode.get(node);
+    if (!state) {
+      state = {
+        activeRanges: [],
+        ranges: [],
+        currentRange: undefined,
+      };
+      this.#stateByNode.set(node, state);
+    }
+    return state;
+  }
+
+  apply(node: Node): void {
+    const state = this.#getOrCreateState(node);
+    this.removeHighlights(state.activeRanges);
+    state.activeRanges = this.highlightOrderedTextRanges(node, state.ranges);
+    if (state.currentRange) {
+      state.activeRanges.push(...this.highlightOrderedTextRanges(node, [state.currentRange], /* isCurrent=*/ true));
+    }
+  }
+
+  set(element: Node, ranges: TextUtils.TextRange.SourceRange[],
+      currentRange: TextUtils.TextRange.SourceRange|undefined): void {
+    const state = this.#getOrCreateState(element);
+    state.ranges = ranges;
+    state.currentRange = currentRange;
+    this.apply(element);
+  }
 }

package/front_end/ui/components/highlighting/highlighting.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import './HighlightElement.js';
+
 import * as HighlightManager from './HighlightManager.js';
 
 export {HighlightManager};

package/front_end/ui/components/markdown_view/MarkdownImagesMap.ts

@@ -32,9 +32,11 @@ export interface ImageData {
  *
  */
 
-// NOTE: This is only exported for tests, and it should not be
-// imported in any component, instead add image data in map and
-// use getMarkdownImage to get the appropriate image data.
+/**
+ * NOTE: This is only exported for tests, and it should not be
+ * imported in any component, instead add image data in map and
+ * use getMarkdownImage to get the appropriate image data.
+ **/
 export const markdownImages = new Map<string, ImageData>([]);
 
 export const getMarkdownImage = (key: string): ImageData => {

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -9,9 +9,11 @@
  * Find more information about web development at [Learn more](exampleLink)
  */
 
-// This is only exported for tests, and it should not be
-// imported in any component, instead add link in map and
-// use getMarkdownLink to get the appropriate link.
+/**
+ * This is only exported for tests, and it should not be
+ * imported in any component, instead add link in map and
+ * use getMarkdownLink to get the appropriate link.
+ **/
 export const markdownLinks = new Map<string, string>([
   ['issuesContrastWCAG21AA', 'https://www.w3.org/TR/WCAG21/#contrast-minimum'],
   ['issuesContrastWCAG21AAA', 'https://www.w3.org/TR/WCAG21/#contrast-enhanced'],

package/front_end/ui/components/menus/SelectMenu.ts

@@ -463,9 +463,11 @@ export class SelectMenuButtonTriggerEvent extends Event {
   }
 }
 
-// Exported artifacts used in this component and that belong to the Menu are
-// renamed to only make reference to the SelectMenu. This way, the Menu API
-// doesn't have to be used in SelectMenu usages and the SelectMenu implementation
-// can remain transparent to its users.
+/**
+ * Exported artifacts used in this component and that belong to the Menu are
+ * renamed to only make reference to the SelectMenu. This way, the Menu API
+ * doesn't have to be used in SelectMenu usages and the SelectMenu implementation
+ * can remain transparent to its users.
+ **/
 export type SelectMenuItemValue = MenuItemValue;
 export {MenuGroup as SelectMenuGroup};

package/front_end/ui/components/survey_link/SurveyLink.ts

@@ -48,8 +48,10 @@ const enum State {
   DONT_SHOW_LINK = 'DontShowLink',
 }
 
-// A link to a survey. The link is rendered aysnchronously because we need to first check if
-// canShowSurvey succeeds.
+/**
+ * A link to a survey. The link is rendered asynchronously because we need to first check if
+ * canShowSurvey succeeds.
+ **/
 export class SurveyLink extends HTMLElement {
   readonly #shadow = this.attachShadow({mode: 'open'});
   #trigger = '';

package/front_end/ui/components/text_editor/config.ts

@@ -86,9 +86,11 @@ export const tabMovesFocus = DynamicSetting.bool('text-editor-tab-moves-focus',
 
 const disableConservativeCompletion = CM.StateEffect.define();
 
-// When enabled, this suppresses the behavior of showCompletionHint
-// and accepting of completions with Enter until the user selects a
-// completion beyond the initially selected one. Used in the console.
+/**
+ * When enabled, this suppresses the behavior of showCompletionHint
+ * and accepting of completions with Enter until the user selects a
+ * completion beyond the initially selected one. Used in the console.
+ **/
 export const conservativeCompletion = CM.StateField.define<boolean>({
   create() {
     return true;
@@ -123,9 +125,11 @@ function acceptCompletionIfAtEndOfLine(view: CM.EditorView): boolean {
   return false;
 }
 
-// This is a wrapper around CodeMirror's own moveCompletionSelection command, which
-// selects the first selection if the state of the selection is conservative, and
-// otherwise behaves as normal.
+/**
+ * This is a wrapper around CodeMirror's own moveCompletionSelection command, which
+ * selects the first selection if the state of the selection is conservative, and
+ * otherwise behaves as normal.
+ **/
 function moveCompletionSelectionIfNotConservative(
     forward: boolean, by: 'option'|'page' = 'option'): ((view: CM.EditorView) => boolean) {
   return view => {

package/front_end/ui/components/text_editor/javascript.ts

@@ -268,8 +268,10 @@ const maxCacheAge = 30_000;
 
 let cacheInstance: PropertyCache|null = null;
 
-// Store recent collections of property completions. The empty string
-// is used to store the set of global bindings.
+/**
+ * Store recent collections of property completions. The empty string
+ * is used to store the set of global bindings.
+ **/
 class PropertyCache {
   readonly #cache = new Map<string, Promise<CompletionSet>>();
 
@@ -713,8 +715,10 @@ async function prototypesFromObject(object: SDK.RemoteObject.RemoteObject): Prom
   }, []) ?? [];
 }
 
-// Given a function object that is probably a bound function, try to
-// retrieve the argument list from its target function.
+/**
+ * Given a function object that is probably a bound function, try to
+ * retrieve the argument list from its target function.
+ **/
 async function getArgumentsForBoundFunction(object: SDK.RemoteObject.RemoteObject): Promise<string[][]|null> {
   const {internalProperties} = await object.getOwnProperties(false);
   if (!internalProperties) {

package/front_end/ui/components/tooltips/Tooltip.ts

@@ -480,7 +480,13 @@ export class Tooltip extends HTMLElement {
   };
 
   #keyDown = (event: KeyboardEvent): void => {
-    if ((event.altKey && event.key === 'ArrowDown') || (event.key === 'Escape' && this.open)) {
+    // There are two scenarios when we care about keydown:
+    // 1. The tooltip is open, and the user presses ESC
+    // 2. "use-hotkey" is set, and the user presses Alt+ArrowDown.
+    const shouldToggleVisibility =
+        (event.key === 'Escape' && this.open) || (this.useHotkey && event.altKey && event.key === 'ArrowDown');
+
+    if (shouldToggleVisibility) {
       this.#openedViaHotkey = !this.open;
       this.toggle();
       event.consume(true);
@@ -489,15 +495,18 @@ export class Tooltip extends HTMLElement {
 
   #registerEventListeners(): void {
     if (this.#anchor) {
+      // We bind the keydown listener regardless of if use-hotkey is enabled
+      // as we always want to support ESC to close.
+      this.#anchor.addEventListener('keydown', this.#keyDown);
+
       if (this.useClick) {
         this.#anchor.addEventListener('click', this.toggle);
       } else {
         this.#anchor.addEventListener('mouseenter', this.showTooltip);
-        if (this.useHotkey) {
-          this.#anchor.addEventListener('keydown', this.#keyDown);
-        } else {
+        if (!this.useHotkey) {
           this.#anchor.addEventListener('focus', this.showTooltip);
         }
+
         this.#anchor.addEventListener('blur', this.hideTooltip);
         this.#anchor.addEventListener('mouseleave', this.hideTooltip);
         this.addEventListener('mouseleave', this.hideTooltip);

package/front_end/ui/legacy/ForwardedInputEventHandler.ts

@@ -9,8 +9,10 @@ import {Context} from './Context.js';
 import {KeyboardShortcut} from './KeyboardShortcut.js';
 import {ForwardedShortcut, ShortcutRegistry} from './ShortcutRegistry.js';
 
-// This handler only forwards the keystrokes if DevTools front-end is
-// not running in hosted mode.
+/**
+ * This handler only forwards the keystrokes if DevTools front-end is
+ * not running in hosted mode.
+ **/
 export class ForwardedInputEventHandler {
   constructor() {
     Host.InspectorFrontendHost.InspectorFrontendHostInstance.events.addEventListener(

package/front_end/ui/legacy/GlassPane.ts

@@ -347,5 +347,5 @@ export const enum MarginBehavior {
 const containers = new Map<Document, Element>();
 const panes = new Set<GlassPane>();
 
-// Exported for layout tests.
+/** Exported for layout tests. **/
 export const GlassPanePanes = panes;

package/front_end/ui/legacy/SettingsUI.ts

@@ -232,11 +232,7 @@ export const createControlForSetting = function(
       return component;
     }
     case Common.Settings.SettingType.ENUM:
-      if (Array.isArray(setting.options())) {
-        return createSettingSelect(uiTitle, setting.options(), setting.reloadRequired(), setting, subtitle);
-      }
-      console.error('Enum setting defined without options');
-      return null;
+      return createSettingSelect(uiTitle, setting.options(), setting.reloadRequired(), setting, subtitle);
     default:
       console.error('Invalid setting type: ' + setting.type());
       return null;