chrome-devtools-frontend 1.0.1521880 → 1.0.1522585
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/docs/ui_engineering.md +76 -0
- package/front_end/core/host/GdpClient.ts +116 -66
- package/front_end/core/root/Runtime.ts +1 -0
- package/front_end/core/sdk/EnhancedTracesParser.ts +13 -6
- package/front_end/entrypoints/inspector_main/InspectorMain.ts +82 -32
- package/front_end/entrypoints/inspector_main/inspector_main-meta.ts +1 -1
- package/front_end/entrypoints/main/MainImpl.ts +7 -1
- package/front_end/generated/Deprecation.ts +4 -4
- package/front_end/models/ai_assistance/agents/NetworkAgent.ts +10 -6
- package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +559 -0
- package/front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.ts +42 -4
- package/front_end/models/badges/UserBadges.ts +14 -16
- package/front_end/models/javascript_metadata/NativeFunctions.js +1 -1
- package/front_end/models/trace/LanternComputationData.ts +1 -0
- package/front_end/models/trace/handlers/NetworkRequestsHandler.ts +10 -0
- package/front_end/models/trace/insights/DocumentLatency.ts +9 -10
- package/front_end/models/trace/types/TraceEvents.ts +6 -5
- package/front_end/panels/ai_assistance/components/UserActionRow.ts +1 -2
- package/front_end/panels/application/IndexedDBViews.ts +1 -0
- package/front_end/panels/application/ReportingApiTreeElement.ts +1 -2
- package/front_end/panels/application/ReportingApiView.ts +18 -20
- package/front_end/panels/application/ServiceWorkerCacheViews.ts +3 -0
- package/front_end/panels/application/components/EndpointsGrid.ts +51 -59
- package/front_end/panels/application/components/ReportsGrid.ts +86 -107
- package/front_end/panels/application/components/StorageMetadataView.ts +30 -4
- package/front_end/panels/application/components/endpointsGrid.css +30 -0
- package/front_end/panels/application/components/reportsGrid.css +34 -0
- package/front_end/panels/application/components/storageMetadataView.css +9 -0
- package/front_end/panels/browser_debugger/CategorizedBreakpointsSidebarPane.ts +19 -27
- package/front_end/panels/common/BadgeNotification.ts +10 -3
- package/front_end/panels/network/NetworkPanel.ts +1 -1
- package/front_end/panels/protocol_monitor/ProtocolMonitor.ts +31 -32
- package/front_end/panels/search/SearchResultsPane.ts +14 -13
- package/front_end/panels/search/SearchView.ts +3 -20
- package/front_end/panels/settings/components/SyncSection.ts +8 -6
- package/front_end/panels/sources/SearchSourcesView.ts +1 -1
- package/front_end/panels/timeline/TimelineFlameChartView.ts +17 -0
- package/front_end/panels/timeline/TimelinePanel.ts +5 -0
- package/front_end/panels/timeline/TimelineUIUtils.ts +12 -3
- package/front_end/panels/timeline/components/ExportTraceOptions.ts +21 -9
- package/front_end/panels/timeline/timelineDetailsView.css +5 -0
- package/front_end/panels/whats_new/ReleaseNoteText.ts +15 -11
- package/front_end/panels/whats_new/resources/WNDT.md +9 -6
- package/front_end/third_party/chromium/README.chromium +1 -1
- package/front_end/third_party/diff/README.chromium +0 -1
- package/front_end/ui/components/tooltips/Tooltip.ts +13 -4
- package/front_end/ui/legacy/Treeoutline.ts +6 -9
- package/front_end/ui/legacy/UIUtils.ts +4 -17
- package/front_end/ui/legacy/Widget.ts +0 -5
- package/front_end/ui/legacy/XElement.ts +0 -33
- package/front_end/ui/legacy/components/data_grid/DataGridElement.ts +3 -3
- package/front_end/ui/legacy/components/perf_ui/FilmStripView.ts +38 -21
- package/front_end/ui/legacy/components/perf_ui/filmStripView.css +29 -0
- package/front_end/ui/legacy/components/source_frame/XMLView.ts +3 -2
- package/front_end/ui/legacy/legacy.ts +0 -2
- package/front_end/ui/visual_logging/KnownContextValues.ts +1 -0
- package/package.json +1 -1
- package/front_end/panels/application/components/reportingApiGrid.css +0 -31
- package/front_end/ui/legacy/XWidget.ts +0 -133
package/docs/ui_engineering.md
CHANGED
@@ -1223,3 +1223,79 @@ export const DEFAULT_VIEW = (input, _output, target) => {
|
|
1223
1223
|
target, {host: input});
|
1224
1224
|
};
|
1225
1225
|
```
|
1226
|
+
|
1227
|
+
## Refactoring UI.Toolbar.Provider
|
1228
|
+
|
1229
|
+
As part of the migration, sometimes classes need to be broken up into smaller pieces. Classes implementing
|
1230
|
+
`UI.Toolbar.Provider` logic are good examples of this, if they implement `View` logic in addition to their
|
1231
|
+
`UI.Toolbar.Provider` responsibilities. The View logic needs to be moved to a separate class.
|
1232
|
+
|
1233
|
+
|
1234
|
+
**Before:**
|
1235
|
+
```typescript
|
1236
|
+
export class NodeIndicator implements UI.Toolbar.Provider {
|
1237
|
+
readonly #element: Element;
|
1238
|
+
readonly #item: UI.Toolbar.ToolbarItem;
|
1239
|
+
|
1240
|
+
private constructor() {
|
1241
|
+
// Creates `this.#element` and `this.#item` imperatively (e.g. using document.createElement/createChild).
|
1242
|
+
}
|
1243
|
+
static instance(opts: { forceNew: boolean|null, } = {forceNew: null}): NodeIndicator {
|
1244
|
+
// Creates an instance of this class and returns it.
|
1245
|
+
}
|
1246
|
+
#update(input): void { /* Handles updates to `this.#element` and `this.#item`. */}
|
1247
|
+
item(): UI.Toolbar.ToolbarItem|null {
|
1248
|
+
return this.#item;
|
1249
|
+
}
|
1250
|
+
}
|
1251
|
+
```
|
1252
|
+
|
1253
|
+
**After:**
|
1254
|
+
```typescript
|
1255
|
+
export const DEFAULT_VIEW: View = (input, output, target) => {
|
1256
|
+
// Implementation of the View using Lit.render() (omitted for brevity).
|
1257
|
+
};
|
1258
|
+
|
1259
|
+
export class NodeIndicator extends UI.Widget.Widget {
|
1260
|
+
readonly #view: View;
|
1261
|
+
|
1262
|
+
constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
|
1263
|
+
super(element, {useShadowDom: true});
|
1264
|
+
this.#view = view;
|
1265
|
+
}
|
1266
|
+
|
1267
|
+
override performUpdate(): void {
|
1268
|
+
const input = {
|
1269
|
+
// Whatever input the View needs.
|
1270
|
+
};
|
1271
|
+
this.#view(input, {}, this.contentElement);
|
1272
|
+
}
|
1273
|
+
}
|
1274
|
+
|
1275
|
+
let nodeIndicatorProviderInstance: NodeIndicatorProvider;
|
1276
|
+
export class NodeIndicatorProvider implements UI.Toolbar.Provider {
|
1277
|
+
#toolbarItem: UI.Toolbar.ToolbarItem;
|
1278
|
+
#widgetElement: UI.Widget.WidgetElement<NodeIndicator>;
|
1279
|
+
|
1280
|
+
private constructor() {
|
1281
|
+
this.#widgetElement = document.createElement('devtools-widget') as UI.Widget.WidgetElement<NodeIndicator>;
|
1282
|
+
this.#widgetElement.widgetConfig = UI.Widget.widgetConfig(NodeIndicator);
|
1283
|
+
|
1284
|
+
this.#toolbarItem = new UI.Toolbar.ToolbarItem(this.#widgetElement);
|
1285
|
+
this.#toolbarItem.setVisible(false);
|
1286
|
+
}
|
1287
|
+
|
1288
|
+
item(): UI.Toolbar.ToolbarItem|null {
|
1289
|
+
return this.#toolbarItem;
|
1290
|
+
}
|
1291
|
+
|
1292
|
+
static instance(opts: {forceNew: boolean|null} = {forceNew: null}): NodeIndicatorProvider {
|
1293
|
+
const {forceNew} = opts;
|
1294
|
+
if (!nodeIndicatorProviderInstance || forceNew) {
|
1295
|
+
nodeIndicatorProviderInstance = new NodeIndicatorProvider();
|
1296
|
+
}
|
1297
|
+
|
1298
|
+
return nodeIndicatorProviderInstance;
|
1299
|
+
}
|
1300
|
+
}
|
1301
|
+
```
|
@@ -68,11 +68,22 @@ export interface Profile {
|
|
68
68
|
};
|
69
69
|
}
|
70
70
|
|
71
|
-
interface
|
72
|
-
|
71
|
+
export interface GetProfileResponse {
|
72
|
+
profile: Profile|null;
|
73
73
|
isEligible: boolean;
|
74
74
|
}
|
75
75
|
|
76
|
+
export enum GdpErrorType {
|
77
|
+
HTTP_RESPONSE_UNAVAILABLE = 'HTTP_RESPONSE_UNAVAILABLE',
|
78
|
+
NOT_FOUND = 'NOT_FOUND',
|
79
|
+
}
|
80
|
+
|
81
|
+
class GdpError extends Error {
|
82
|
+
constructor(readonly type: GdpErrorType, options?: ErrorOptions) {
|
83
|
+
super(undefined, options);
|
84
|
+
}
|
85
|
+
}
|
86
|
+
|
76
87
|
// The `batchGet` awards endpoint returns badge names with an
|
77
88
|
// obfuscated user ID (e.g., `profiles/12345/awards/badge-name`).
|
78
89
|
// This function normalizes them to use `me` instead of the ID
|
@@ -84,9 +95,9 @@ function normalizeBadgeName(name: string): string {
|
|
84
95
|
|
85
96
|
export const GOOGLE_DEVELOPER_PROGRAM_PROFILE_LINK = 'https://developers.google.com/profile/u/me';
|
86
97
|
|
87
|
-
async function makeHttpRequest<R
|
98
|
+
async function makeHttpRequest<R>(request: DispatchHttpRequestRequest): Promise<R> {
|
88
99
|
if (!isGdpProfilesAvailable()) {
|
89
|
-
|
100
|
+
throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE);
|
90
101
|
}
|
91
102
|
|
92
103
|
const response = await new Promise<DispatchHttpRequestResult>(resolve => {
|
@@ -94,18 +105,26 @@ async function makeHttpRequest<R extends object>(request: DispatchHttpRequestReq
|
|
94
105
|
});
|
95
106
|
|
96
107
|
debugLog({request, response});
|
108
|
+
if (response.statusCode === 404) {
|
109
|
+
throw new GdpError(GdpErrorType.NOT_FOUND);
|
110
|
+
}
|
111
|
+
|
97
112
|
if ('response' in response && response.statusCode === 200) {
|
98
|
-
|
113
|
+
try {
|
114
|
+
return JSON.parse(response.response) as R;
|
115
|
+
} catch (err) {
|
116
|
+
throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE, {cause: err});
|
117
|
+
}
|
99
118
|
}
|
100
119
|
|
101
|
-
|
120
|
+
throw new GdpError(GdpErrorType.HTTP_RESPONSE_UNAVAILABLE);
|
102
121
|
}
|
103
122
|
|
104
123
|
const SERVICE_NAME = 'gdpService';
|
105
124
|
let gdpClientInstance: GdpClient|null = null;
|
106
125
|
export class GdpClient {
|
107
|
-
#cachedProfilePromise?: Promise<Profile
|
108
|
-
#cachedEligibilityPromise?: Promise<CheckElibigilityResponse
|
126
|
+
#cachedProfilePromise?: Promise<Profile>;
|
127
|
+
#cachedEligibilityPromise?: Promise<CheckElibigilityResponse>;
|
109
128
|
|
110
129
|
private constructor() {
|
111
130
|
}
|
@@ -119,41 +138,58 @@ export class GdpClient {
|
|
119
138
|
return gdpClientInstance;
|
120
139
|
}
|
121
140
|
|
122
|
-
|
123
|
-
|
124
|
-
|
141
|
+
/**
|
142
|
+
* Fetches the user's GDP profile and eligibility status.
|
143
|
+
*
|
144
|
+
* It first attempts to fetch the profile. If the profile is not found
|
145
|
+
* (a `NOT_FOUND` error), this is handled gracefully by treating the profile
|
146
|
+
* as `null` and then proceeding to check for eligibility.
|
147
|
+
*
|
148
|
+
* @returns A promise that resolves with an object containing the `profile`
|
149
|
+
* and `isEligible` status, or `null` if an unexpected error occurs.
|
150
|
+
*/
|
151
|
+
async getProfile(): Promise<GetProfileResponse|null> {
|
152
|
+
try {
|
153
|
+
const profile = await this.#getProfile();
|
125
154
|
return {
|
126
|
-
|
155
|
+
profile,
|
127
156
|
isEligible: true,
|
128
157
|
};
|
158
|
+
} catch (err: unknown) {
|
159
|
+
if (err instanceof GdpError && err.type === GdpErrorType.HTTP_RESPONSE_UNAVAILABLE) {
|
160
|
+
return null;
|
161
|
+
}
|
129
162
|
}
|
130
163
|
|
131
|
-
|
132
|
-
|
133
|
-
|
134
|
-
|
135
|
-
|
164
|
+
try {
|
165
|
+
const checkEligibilityResponse = await this.#checkEligibility();
|
166
|
+
return {
|
167
|
+
profile: null,
|
168
|
+
isEligible: checkEligibilityResponse.createProfile === EligibilityStatus.ELIGIBLE,
|
169
|
+
};
|
170
|
+
} catch {
|
171
|
+
return null;
|
172
|
+
}
|
136
173
|
}
|
137
174
|
|
138
|
-
async getProfile(): Promise<Profile
|
175
|
+
async #getProfile(): Promise<Profile> {
|
139
176
|
if (this.#cachedProfilePromise) {
|
140
177
|
return await this.#cachedProfilePromise;
|
141
178
|
}
|
142
179
|
|
143
|
-
this.#cachedProfilePromise = makeHttpRequest({
|
144
|
-
|
145
|
-
|
146
|
-
|
180
|
+
this.#cachedProfilePromise = makeHttpRequest<Profile>({
|
181
|
+
service: SERVICE_NAME,
|
182
|
+
path: '/v1beta1/profile:get',
|
183
|
+
method: 'GET',
|
184
|
+
}).then(profile => {
|
185
|
+
this.#cachedEligibilityPromise = Promise.resolve({createProfile: EligibilityStatus.ELIGIBLE});
|
186
|
+
return profile;
|
147
187
|
});
|
148
188
|
|
149
|
-
|
150
|
-
if (profile) {
|
151
|
-
this.#cachedEligibilityPromise = Promise.resolve({createProfile: EligibilityStatus.ELIGIBLE});
|
152
|
-
}
|
153
|
-
return profile;
|
189
|
+
return await this.#cachedProfilePromise;
|
154
190
|
}
|
155
191
|
|
156
|
-
async checkEligibility(): Promise<CheckElibigilityResponse
|
192
|
+
async #checkEligibility(): Promise<CheckElibigilityResponse> {
|
157
193
|
if (this.#cachedEligibilityPromise) {
|
158
194
|
return await this.#cachedEligibilityPromise;
|
159
195
|
}
|
@@ -168,42 +204,40 @@ export class GdpClient {
|
|
168
204
|
* @returns null if the request fails, the awarded badge names otherwise.
|
169
205
|
*/
|
170
206
|
async getAwardedBadgeNames({names}: {names: string[]}): Promise<Set<string>|null> {
|
171
|
-
|
172
|
-
|
173
|
-
|
174
|
-
|
175
|
-
|
176
|
-
|
177
|
-
|
178
|
-
|
179
|
-
|
180
|
-
|
181
|
-
|
207
|
+
try {
|
208
|
+
const response = await makeHttpRequest<BatchGetAwardsResponse>({
|
209
|
+
service: SERVICE_NAME,
|
210
|
+
path: '/v1beta1/profiles/me/awards:batchGet',
|
211
|
+
method: 'GET',
|
212
|
+
queryParams: {
|
213
|
+
allowMissing: 'true',
|
214
|
+
names,
|
215
|
+
}
|
216
|
+
});
|
217
|
+
|
218
|
+
return new Set(response.awards?.map(award => normalizeBadgeName(award.name)) ?? []);
|
219
|
+
} catch {
|
182
220
|
return null;
|
183
221
|
}
|
184
|
-
|
185
|
-
return new Set(result.awards?.map(award => normalizeBadgeName(award.name)) ?? []);
|
186
|
-
}
|
187
|
-
|
188
|
-
async isEligibleToCreateProfile(): Promise<boolean> {
|
189
|
-
return (await this.checkEligibility())?.createProfile === EligibilityStatus.ELIGIBLE;
|
190
222
|
}
|
191
223
|
|
192
224
|
async createProfile({user, emailPreference}: {user: string, emailPreference: EmailPreference}):
|
193
225
|
Promise<Profile|null> {
|
194
|
-
|
195
|
-
|
196
|
-
|
197
|
-
|
198
|
-
|
199
|
-
|
200
|
-
|
201
|
-
|
202
|
-
|
203
|
-
|
226
|
+
try {
|
227
|
+
const response = await makeHttpRequest<Profile>({
|
228
|
+
service: SERVICE_NAME,
|
229
|
+
path: '/v1beta1/profiles',
|
230
|
+
method: 'POST',
|
231
|
+
body: JSON.stringify({
|
232
|
+
user,
|
233
|
+
newsletter_email: emailPreference,
|
234
|
+
}),
|
235
|
+
});
|
204
236
|
this.#clearCache();
|
237
|
+
return response;
|
238
|
+
} catch {
|
239
|
+
return null;
|
205
240
|
}
|
206
|
-
return result;
|
207
241
|
}
|
208
242
|
|
209
243
|
#clearCache(): void {
|
@@ -211,16 +245,21 @@ export class GdpClient {
|
|
211
245
|
this.#cachedEligibilityPromise = undefined;
|
212
246
|
}
|
213
247
|
|
214
|
-
createAward({name}: {name: string}): Promise<Award|null> {
|
215
|
-
|
216
|
-
|
217
|
-
|
218
|
-
|
219
|
-
|
220
|
-
|
221
|
-
|
222
|
-
|
223
|
-
|
248
|
+
async createAward({name}: {name: string}): Promise<Award|null> {
|
249
|
+
try {
|
250
|
+
const response = await makeHttpRequest<Award>({
|
251
|
+
service: SERVICE_NAME,
|
252
|
+
path: '/v1beta1/profiles/me/awards',
|
253
|
+
method: 'POST',
|
254
|
+
body: JSON.stringify({
|
255
|
+
awardingUri: 'devtools://devtools',
|
256
|
+
name,
|
257
|
+
})
|
258
|
+
});
|
259
|
+
return response;
|
260
|
+
} catch {
|
261
|
+
return null;
|
262
|
+
}
|
224
263
|
}
|
225
264
|
}
|
226
265
|
|
@@ -260,5 +299,16 @@ export function getGdpProfilesEnterprisePolicy(): Root.Runtime.GdpProfilesEnterp
|
|
260
299
|
Root.Runtime.GdpProfilesEnterprisePolicyValue.DISABLED);
|
261
300
|
}
|
262
301
|
|
302
|
+
export function isBadgesEnabled(): boolean {
|
303
|
+
const isBadgesEnabledByEnterprisePolicy =
|
304
|
+
getGdpProfilesEnterprisePolicy() === Root.Runtime.GdpProfilesEnterprisePolicyValue.ENABLED;
|
305
|
+
const isBadgesEnabledByFeatureFlag = Boolean(Root.Runtime.hostConfig.devToolsGdpProfiles?.badgesEnabled);
|
306
|
+
return isBadgesEnabledByEnterprisePolicy && isBadgesEnabledByFeatureFlag;
|
307
|
+
}
|
308
|
+
|
309
|
+
export function isStarterBadgeEnabled(): boolean {
|
310
|
+
return Boolean(Root.Runtime.hostConfig.devToolsGdpProfiles?.starterBadgeEnabled);
|
311
|
+
}
|
312
|
+
|
263
313
|
// @ts-expect-error
|
264
314
|
globalThis.setDebugGdpIntegrationEnabled = setDebugGdpIntegrationEnabled;
|
@@ -35,11 +35,10 @@ export interface RundownScriptCompiled extends EventBase {
|
|
35
35
|
frameType: 'page'|'iframe',
|
36
36
|
url: string,
|
37
37
|
/**
|
38
|
-
*
|
39
|
-
*
|
40
|
-
* This applies for all `isolate` in trace events we consume.
|
38
|
+
* Older traces were a number, but this is an unsigned 64 bit value, so that was a bug.
|
39
|
+
* New traces use string instead. See https://crbug.com/447654178.
|
41
40
|
*/
|
42
|
-
isolate: number,
|
41
|
+
isolate: string|number,
|
43
42
|
/** AKA V8ContextToken. https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/inspector/inspector_trace_events.cc;l=1229;drc=3c88f61e18b043e70c225d8d57c77832a85e7f58 */
|
44
43
|
v8context: string,
|
45
44
|
origin: string,
|
@@ -60,7 +59,11 @@ export interface RundownScript extends EventBase {
|
|
60
59
|
name: 'ScriptCatchup';
|
61
60
|
args: {
|
62
61
|
data: {
|
63
|
-
|
62
|
+
/**
|
63
|
+
* Older traces were a number, but this is an unsigned 64 bit value, so that was a bug.
|
64
|
+
* New traces use string instead. See https://crbug.com/447654178.
|
65
|
+
*/
|
66
|
+
isolate: string|number,
|
64
67
|
executionContextId: Protocol.Runtime.ExecutionContextId,
|
65
68
|
scriptId: number,
|
66
69
|
isModule: boolean,
|
@@ -119,7 +122,11 @@ interface FunctionCall extends EventBase {
|
|
119
122
|
data: {
|
120
123
|
frame: Protocol.Page.FrameId,
|
121
124
|
scriptId: Protocol.Runtime.ScriptId,
|
122
|
-
|
125
|
+
/**
|
126
|
+
* Older traces were a number, but this is an unsigned 64 bit value, so that was a bug.
|
127
|
+
* New traces use string instead. See https://crbug.com/447654178.
|
128
|
+
*/
|
129
|
+
isolate?: string|number,
|
123
130
|
},
|
124
131
|
};
|
125
132
|
}
|
@@ -1,7 +1,6 @@
|
|
1
1
|
// Copyright 2018 The Chromium Authors
|
2
2
|
// Use of this source code is governed by a BSD-style license that can be
|
3
3
|
// found in the LICENSE file.
|
4
|
-
/* eslint-disable rulesdir/no-imperative-dom-api */
|
5
4
|
|
6
5
|
import * as Common from '../../core/common/common.js';
|
7
6
|
import * as Host from '../../core/host/host.js';
|
@@ -13,9 +12,12 @@ import * as MobileThrottling from '../../panels/mobile_throttling/mobile_throttl
|
|
13
12
|
import * as Security from '../../panels/security/security.js';
|
14
13
|
import * as Components from '../../ui/legacy/components/utils/utils.js';
|
15
14
|
import * as UI from '../../ui/legacy/legacy.js';
|
15
|
+
import * as Lit from '../../ui/lit/lit.js';
|
16
16
|
|
17
17
|
import nodeIconStyles from './nodeIcon.css.js';
|
18
18
|
|
19
|
+
const {html} = Lit;
|
20
|
+
|
19
21
|
const UIStrings = {
|
20
22
|
/**
|
21
23
|
* @description Text that refers to the main target. The main target is the primary webpage that
|
@@ -185,50 +187,98 @@ export class FocusDebuggeeActionDelegate implements UI.ActionRegistration.Action
|
|
185
187
|
}
|
186
188
|
}
|
187
189
|
|
188
|
-
|
190
|
+
interface ViewInput {
|
191
|
+
nodeProcessRunning: Boolean;
|
192
|
+
}
|
189
193
|
|
190
|
-
|
191
|
-
|
192
|
-
|
193
|
-
|
194
|
-
|
195
|
-
|
196
|
-
|
197
|
-
|
198
|
-
|
199
|
-
|
200
|
-
|
201
|
-
|
202
|
-
|
203
|
-
|
204
|
-
|
205
|
-
|
206
|
-
|
207
|
-
|
208
|
-
|
209
|
-
|
210
|
-
|
211
|
-
|
212
|
-
|
194
|
+
type View = (input: ViewInput, _output: object, target: HTMLElement) => void;
|
195
|
+
|
196
|
+
const isNodeProcessRunning = (targetInfos: Protocol.Target.TargetInfo[]): Boolean => {
|
197
|
+
return Boolean(targetInfos.find(target => target.type === 'node' && !target.attached));
|
198
|
+
};
|
199
|
+
|
200
|
+
export const DEFAULT_VIEW: View = (input, output, target) => {
|
201
|
+
const {
|
202
|
+
nodeProcessRunning,
|
203
|
+
} = input;
|
204
|
+
|
205
|
+
// clang-format off
|
206
|
+
Lit.render(html`
|
207
|
+
<style>${nodeIconStyles}</style>
|
208
|
+
<div
|
209
|
+
class="node-icon ${!nodeProcessRunning ? 'inactive' : ''}"
|
210
|
+
title=${i18nString(UIStrings.openDedicatedTools)}
|
211
|
+
@click=${
|
212
|
+
() => Host.InspectorFrontendHost.InspectorFrontendHostInstance.openNodeFrontend()}>
|
213
|
+
</div>
|
214
|
+
`, target);
|
215
|
+
// clang-format on
|
216
|
+
};
|
217
|
+
|
218
|
+
export class NodeIndicator extends UI.Widget.Widget {
|
219
|
+
readonly #view: View;
|
220
|
+
#targetInfos: Protocol.Target.TargetInfo[] = [];
|
221
|
+
#wasShown = false;
|
222
|
+
|
223
|
+
constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
|
224
|
+
super(element, {useShadowDom: true});
|
225
|
+
this.#view = view;
|
213
226
|
|
214
|
-
|
227
|
+
SDK.TargetManager.TargetManager.instance().addEventListener(
|
228
|
+
SDK.TargetManager.Events.AVAILABLE_TARGETS_CHANGED, event => {
|
229
|
+
this.#targetInfos = event.data;
|
230
|
+
this.requestUpdate();
|
231
|
+
});
|
215
232
|
}
|
216
233
|
|
217
|
-
|
234
|
+
override performUpdate(): void {
|
218
235
|
// Disable when we are testing, as debugging e2e
|
219
236
|
// attaches a debug process and this changes some view sizes
|
220
237
|
if (Host.InspectorFrontendHost.isUnderTest()) {
|
221
238
|
return;
|
222
239
|
}
|
223
|
-
|
224
|
-
this.#
|
225
|
-
|
226
|
-
|
240
|
+
|
241
|
+
const nodeProcessRunning: Boolean = isNodeProcessRunning(this.#targetInfos);
|
242
|
+
|
243
|
+
if (!this.#wasShown && !nodeProcessRunning) {
|
244
|
+
// This widget is designed to be hidden until the first debuggable Node process is detected. Therefore
|
245
|
+
// we don't construct the view if there's no data. After we've shown it once, it remains on-sreen and
|
246
|
+
// indicates via its disabled state whether Node debugging is available.
|
247
|
+
return;
|
227
248
|
}
|
249
|
+
this.#wasShown = true;
|
250
|
+
|
251
|
+
const input: ViewInput = {
|
252
|
+
nodeProcessRunning,
|
253
|
+
};
|
254
|
+
this.#view(input, {}, this.contentElement);
|
255
|
+
}
|
256
|
+
}
|
257
|
+
|
258
|
+
let nodeIndicatorProviderInstance: NodeIndicatorProvider;
|
259
|
+
export class NodeIndicatorProvider implements UI.Toolbar.Provider {
|
260
|
+
#toolbarItem: UI.Toolbar.ToolbarItem;
|
261
|
+
#widgetElement: UI.Widget.WidgetElement<NodeIndicator>;
|
262
|
+
|
263
|
+
private constructor() {
|
264
|
+
this.#widgetElement = document.createElement('devtools-widget') as UI.Widget.WidgetElement<NodeIndicator>;
|
265
|
+
this.#widgetElement.widgetConfig = UI.Widget.widgetConfig(NodeIndicator);
|
266
|
+
|
267
|
+
this.#toolbarItem = new UI.Toolbar.ToolbarItem(this.#widgetElement);
|
268
|
+
this.#toolbarItem.setVisible(false);
|
228
269
|
}
|
229
270
|
|
230
271
|
item(): UI.Toolbar.ToolbarItem|null {
|
231
|
-
return this.#
|
272
|
+
return this.#toolbarItem;
|
273
|
+
}
|
274
|
+
|
275
|
+
static instance(opts: {forceNew: boolean|null} = {forceNew: null}): NodeIndicatorProvider {
|
276
|
+
const {forceNew} = opts;
|
277
|
+
if (!nodeIndicatorProviderInstance || forceNew) {
|
278
|
+
nodeIndicatorProviderInstance = new NodeIndicatorProvider();
|
279
|
+
}
|
280
|
+
|
281
|
+
return nodeIndicatorProviderInstance;
|
232
282
|
}
|
233
283
|
}
|
234
284
|
|
@@ -257,7 +257,7 @@ Common.Settings.registerSettingExtension({
|
|
257
257
|
UI.Toolbar.registerToolbarItem({
|
258
258
|
async loadItem() {
|
259
259
|
const InspectorMain = await loadInspectorMainModule();
|
260
|
-
return InspectorMain.InspectorMain.
|
260
|
+
return InspectorMain.InspectorMain.NodeIndicatorProvider.instance();
|
261
261
|
},
|
262
262
|
order: 2,
|
263
263
|
location: UI.Toolbar.ToolbarItemLocation.MAIN_TOOLBAR_LEFT,
|
@@ -519,7 +519,13 @@ export class MainImpl {
|
|
519
519
|
|
520
520
|
// Initialize `GDPClient` and `UserBadges` for Google Developer Program integration
|
521
521
|
if (Host.GdpClient.isGdpProfilesAvailable()) {
|
522
|
-
void Host.GdpClient.GdpClient.instance().
|
522
|
+
void Host.GdpClient.GdpClient.instance().getProfile().then(getProfileResponse => {
|
523
|
+
if (!getProfileResponse) {
|
524
|
+
return;
|
525
|
+
}
|
526
|
+
|
527
|
+
const {profile, isEligible} = getProfileResponse;
|
528
|
+
const hasProfile = Boolean(profile);
|
523
529
|
const contextString = hasProfile ? 'has-profile' :
|
524
530
|
isEligible ? 'no-profile-and-eligible' :
|
525
531
|
'no-profile-and-not-eligible';
|
@@ -57,15 +57,15 @@ export const UIStrings = {
|
|
57
57
|
/**
|
58
58
|
* @description Warning displayed to developers when the Geolocation API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is no longer supported.
|
59
59
|
*/
|
60
|
-
GeolocationInsecureOrigin: "`getCurrentPosition()` and `watchPosition()` no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://
|
60
|
+
GeolocationInsecureOrigin: "`getCurrentPosition()` and `watchPosition()` no longer work on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
|
61
61
|
/**
|
62
62
|
* @description Warning displayed to developers when the Geolocation API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is deprecated.
|
63
63
|
*/
|
64
|
-
GeolocationInsecureOriginDeprecatedNotRemoved: "`getCurrentPosition()` and `watchPosition()` are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://
|
64
|
+
GeolocationInsecureOriginDeprecatedNotRemoved: "`getCurrentPosition()` and `watchPosition()` are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
|
65
65
|
/**
|
66
66
|
* @description This warning occurs when the `getUserMedia()` API is invoked on an insecure (e.g., HTTP) site. This is only permitted on secure sites (e.g., HTTPS).
|
67
67
|
*/
|
68
|
-
GetUserMediaInsecureOrigin: "`getUserMedia()` no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://
|
68
|
+
GetUserMediaInsecureOrigin: "`getUserMedia()` no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
|
69
69
|
/**
|
70
70
|
* @description A deprecation warning shown to developers in the DevTools Issues tab when code tries to use the deprecated hostCandidate field, guiding developers to use the equivalent information in the .address and .port fields instead.
|
71
71
|
*/
|
@@ -105,7 +105,7 @@ export const UIStrings = {
|
|
105
105
|
/**
|
106
106
|
* @description Warning displayed to developers when the Notification API is used from an insecure origin (one that isn't localhost or doesn't use HTTPS) to notify them that this use is no longer supported.
|
107
107
|
*/
|
108
|
-
NotificationInsecureOrigin: "The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://
|
108
|
+
NotificationInsecureOrigin: "The Notification API may no longer be used from insecure origins. You should consider switching your application to a secure origin, such as HTTPS. See https://www.chromium.org/Home/chromium-security/deprecating-powerful-features-on-insecure-origins/ for more details.",
|
109
109
|
/**
|
110
110
|
* @description Warning displayed to developers when permission to use notifications has been requested by a cross-origin iframe, to notify them that this use is no longer supported.
|
111
111
|
*/
|
@@ -149,23 +149,23 @@ export class NetworkAgent extends AiAgent<SDK.NetworkRequest.NetworkRequest> {
|
|
149
149
|
yield {
|
150
150
|
type: ResponseType.CONTEXT,
|
151
151
|
title: lockedString(UIStringsNotTranslate.analyzingNetworkData),
|
152
|
-
details: createContextDetailsForNetworkAgent(selectedNetworkRequest),
|
152
|
+
details: await createContextDetailsForNetworkAgent(selectedNetworkRequest),
|
153
153
|
};
|
154
154
|
}
|
155
155
|
|
156
156
|
override async enhanceQuery(query: string, selectedNetworkRequest: RequestContext|null): Promise<string> {
|
157
157
|
const networkEnchantmentQuery = selectedNetworkRequest ?
|
158
158
|
`# Selected network request \n${
|
159
|
-
new NetworkRequestFormatter(selectedNetworkRequest.getItem(), selectedNetworkRequest.calculator)
|
160
|
-
|
159
|
+
await (new NetworkRequestFormatter(selectedNetworkRequest.getItem(), selectedNetworkRequest.calculator)
|
160
|
+
.formatNetworkRequest())}\n\n# User request\n\n` :
|
161
161
|
'';
|
162
162
|
return `${networkEnchantmentQuery}${query}`;
|
163
163
|
}
|
164
164
|
}
|
165
165
|
|
166
|
-
function createContextDetailsForNetworkAgent(
|
166
|
+
async function createContextDetailsForNetworkAgent(
|
167
167
|
selectedNetworkRequest: RequestContext,
|
168
|
-
): [ContextDetail, ...ContextDetail[]] {
|
168
|
+
): Promise<[ContextDetail, ...ContextDetail[]]> {
|
169
169
|
const request = selectedNetworkRequest.getItem();
|
170
170
|
const formatter = new NetworkRequestFormatter(request, selectedNetworkRequest.calculator);
|
171
171
|
const requestContextDetail: ContextDetail = {
|
@@ -173,10 +173,13 @@ function createContextDetailsForNetworkAgent(
|
|
173
173
|
text: lockedString(UIStringsNotTranslate.requestUrl) + ': ' + request.url() + '\n\n' +
|
174
174
|
formatter.formatRequestHeaders(),
|
175
175
|
};
|
176
|
+
const responseBody = await formatter.formatResponseBody();
|
177
|
+
const responseBodyString = responseBody ? `\n\n${responseBody}` : '';
|
178
|
+
|
176
179
|
const responseContextDetail: ContextDetail = {
|
177
180
|
title: lockedString(UIStringsNotTranslate.response),
|
178
181
|
text: lockedString(UIStringsNotTranslate.responseStatus) + ': ' + request.statusCode + ' ' + request.statusText +
|
179
|
-
|
182
|
+
`\n\n${formatter.formatResponseHeaders()}` + responseBodyString,
|
180
183
|
};
|
181
184
|
const timingContextDetail: ContextDetail = {
|
182
185
|
title: lockedString(UIStringsNotTranslate.timing),
|
@@ -186,6 +189,7 @@ function createContextDetailsForNetworkAgent(
|
|
186
189
|
title: lockedString(UIStringsNotTranslate.requestInitiatorChain),
|
187
190
|
text: formatter.formatRequestInitiatorChain(),
|
188
191
|
};
|
192
|
+
|
189
193
|
return [
|
190
194
|
requestContextDetail,
|
191
195
|
responseContextDetail,
|