chrome-devtools-frontend 1.0.1518653 → 1.0.1520139

package/eslint.config.mjs

@@ -720,6 +720,7 @@ export default defineConfig([
       'rulesdir/no-assert-deep-strict-equal': 'error',
       'rulesdir/no-assert-equal': 'error',
       'rulesdir/no-assert-equal-boolean-null-undefined': 'error',
+      'rulesdir/no-capture-screenshot': 'error',
       'rulesdir/no-imperative-dom-api': 'off',
       'rulesdir/no-lit-render-outside-of-view': 'off',
       'rulesdir/prefer-assert-instance-of': 'error',

package/front_end/core/host/GdpClient.ts

@@ -68,6 +68,11 @@ export interface Profile {
   };
 }
 
+interface InitializeResult {
+  hasProfile: boolean;
+  isEligible: boolean;
+}
+
 // The `batchGet` awards endpoint returns badge names with an
 // obfuscated user ID (e.g., `profiles/12345/awards/badge-name`).
 // This function normalizes them to use `me` instead of the ID
@@ -114,9 +119,13 @@ export class GdpClient {
     return gdpClientInstance;
   }
 
-  async initialize(): Promise<void> {
-    void this.getProfile();
-    void this.checkEligibility();
+  async initialize(): Promise<InitializeResult> {
+    return await Promise.all([this.getProfile(), this.checkEligibility()]).then(([profile, eligibilityResponse]) => {
+      return {
+        hasProfile: Boolean(profile),
+        isEligible: eligibilityResponse?.createProfile === EligibilityStatus.ELIGIBLE
+      };
+    });
   }
 
   async getProfile(): Promise<Profile|null> {

package/front_end/core/sdk/EnhancedTracesParser.ts

@@ -459,11 +459,11 @@ export class EnhancedTracesParser {
     for (const orphanScript of orphanScripts) {
       const orphanScriptExecutionContextIsolateId =
           this.getExecutionContextIsolateId(orphanScript.isolate, orphanScript.executionContextId);
-      if (orphanScriptExecutionContextIsolateId in executionContextIsolateToTarget) {
-        const frameId = executionContextIsolateToTarget.get(orphanScriptExecutionContextIsolateId);
-        if (frameId) {
-          targetToScripts.get(frameId)?.push(orphanScript);
-        }
+      const frameId = executionContextIsolateToTarget.get(orphanScriptExecutionContextIsolateId);
+
+      if (frameId) {
+        // Found a link via execution context, use it.
+        targetToScripts.get(frameId)?.push(orphanScript);
       } else if (orphanScript.pid) {
         const target = targets.find(target => target.pid === orphanScript.pid);
         if (target) {

package/front_end/core/sdk/NetworkManager.ts

@@ -597,6 +597,7 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     networkRequest.mixedContentType = request.mixedContentType || Protocol.Security.MixedContentType.None;
     networkRequest.setReferrerPolicy(request.referrerPolicy);
     networkRequest.setIsSameSite(request.isSameSite || false);
+    networkRequest.setIsAdRelated(request.isAdRelated || false);
   }
 
   private updateNetworkRequestWithResponse(networkRequest: NetworkRequest, response: Protocol.Network.Response): void {

package/front_end/core/sdk/NetworkRequest.ts

@@ -320,6 +320,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
   directSocketInfo?: DirectSocketInfo;
   readonly #directSocketChunks: DirectSocketChunk[] = [];
   #isIpProtectionUsed: boolean;
+  #isAdRelated: boolean;
 
   constructor(
       requestId: string,
@@ -342,6 +343,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     this.#initiator = initiator;
     this.#hasUserGesture = hasUserGesture;
     this.#isIpProtectionUsed = false;
+    this.#isAdRelated = false;
   }
 
   static create(
@@ -1850,6 +1852,14 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     return this.#isIpProtectionUsed;
   }
 
+  setIsAdRelated(isAdRelated: boolean): void {
+    this.#isAdRelated = isAdRelated;
+  }
+
+  isAdRelated(): boolean {
+    return this.#isAdRelated;
+  }
+
   getAssociatedData(key: string): object|null {
     return this.#associatedData.get(key) || null;
   }

package/front_end/core/sdk/RehydratingConnection.snapshot.txt

@@ -992,6 +992,217 @@ Content:
   "sessionId": 1
 }
 
+/* RehydratingConnection says: */
+{
+  "method": "Debugger.scriptParsed",
+  "params": {
+    "scriptId": "6",
+    "isolate": "7348673817420155000",
+    "buildId": "",
+    "executionContextId": 1,
+    "startLine": 0,
+    "startColumn": 0,
+    "endLine": 0,
+    "endColumn": 0,
+    "hash": "",
+    "isModule": false,
+    "url": "",
+    "hasSourceURL": false,
+    "sourceURL": "",
+    "pid": 97964,
+    "sourceText": "(async function(){ a…",
+    "length": 32
+  },
+  "sessionId": 1
+}
+
+/* fakeDevToolsFrontend says: */
+{
+  "id": 21,
+  "sessionId": 1,
+  "method": "Debugger.getScriptSource",
+  "params": {
+    "scriptId": "6"
+  }
+}
+
+/* RehydratingConnection says: */
+{
+  "id": 21,
+  "result": {
+    "scriptSource": "(async function(){ a…"
+  },
+  "sessionId": 1
+}
+
+/* RehydratingConnection says: */
+{
+  "method": "Debugger.scriptParsed",
+  "params": {
+    "scriptId": "1",
+    "isolate": "7348673817420155000",
+    "buildId": "",
+    "executionContextId": 1,
+    "startLine": 0,
+    "startColumn": 0,
+    "endLine": 0,
+    "endColumn": 0,
+    "hash": "",
+    "isModule": false,
+    "url": "",
+    "hasSourceURL": false,
+    "sourceURL": "",
+    "pid": 97964
+  },
+  "sessionId": 1
+}
+
+/* fakeDevToolsFrontend says: */
+{
+  "id": 22,
+  "sessionId": 1,
+  "method": "Debugger.getScriptSource",
+  "params": {
+    "scriptId": "1"
+  }
+}
+
+/* RehydratingConnection says: */
+{
+  "id": 22,
+  "result": {
+    "scriptSource": "No source text avail…"
+  },
+  "sessionId": 1
+}
+
+/* RehydratingConnection says: */
+{
+  "method": "Debugger.scriptParsed",
+  "params": {
+    "scriptId": "2",
+    "isolate": "7348673817420155000",
+    "buildId": "",
+    "executionContextId": 1,
+    "startLine": 0,
+    "startColumn": 0,
+    "endLine": 0,
+    "endColumn": 0,
+    "hash": "",
+    "isModule": false,
+    "url": "",
+    "hasSourceURL": false,
+    "sourceURL": "",
+    "pid": 97964,
+    "sourceText": "() {}…",
+    "length": 5
+  },
+  "sessionId": 1
+}
+
+/* fakeDevToolsFrontend says: */
+{
+  "id": 23,
+  "sessionId": 1,
+  "method": "Debugger.getScriptSource",
+  "params": {
+    "scriptId": "2"
+  }
+}
+
+/* RehydratingConnection says: */
+{
+  "id": 23,
+  "result": {
+    "scriptSource": "() {}…"
+  },
+  "sessionId": 1
+}
+
+/* RehydratingConnection says: */
+{
+  "method": "Debugger.scriptParsed",
+  "params": {
+    "scriptId": "3",
+    "isolate": "7348673817420155000",
+    "buildId": "",
+    "executionContextId": 1,
+    "startLine": 0,
+    "startColumn": 0,
+    "endLine": 0,
+    "endColumn": 0,
+    "hash": "",
+    "isModule": false,
+    "url": "extensions::SafeBuiltins",
+    "hasSourceURL": false,
+    "sourceURL": "",
+    "pid": 97964
+  },
+  "sessionId": 1
+}
+
+/* fakeDevToolsFrontend says: */
+{
+  "id": 24,
+  "sessionId": 1,
+  "method": "Debugger.getScriptSource",
+  "params": {
+    "scriptId": "3"
+  }
+}
+
+/* RehydratingConnection says: */
+{
+  "id": 24,
+  "result": {
+    "scriptSource": "No source text avail…"
+  },
+  "sessionId": 1
+}
+
+/* RehydratingConnection says: */
+{
+  "method": "Debugger.scriptParsed",
+  "params": {
+    "scriptId": "4",
+    "isolate": "7348673817420155000",
+    "buildId": "",
+    "executionContextId": 1,
+    "startLine": 0,
+    "startColumn": 0,
+    "endLine": 0,
+    "endColumn": 0,
+    "hash": "",
+    "isModule": false,
+    "url": "v8/LoadTimes",
+    "hasSourceURL": false,
+    "sourceURL": "",
+    "pid": 97964,
+    "sourceText": "var chrome;if (!chro…",
+    "length": 198
+  },
+  "sessionId": 1
+}
+
+/* fakeDevToolsFrontend says: */
+{
+  "id": 25,
+  "sessionId": 1,
+  "method": "Debugger.getScriptSource",
+  "params": {
+    "scriptId": "4"
+  }
+}
+
+/* RehydratingConnection says: */
+{
+  "id": 25,
+  "result": {
+    "scriptSource": "var chrome;if (!chro…"
+  },
+  "sessionId": 1
+}
+
 /* RehydratingConnection says: */
 {
   "id": 2,

package/front_end/core/sdk/TargetManager.ts

@@ -318,6 +318,10 @@ export class TargetManager extends Common.ObjectWrapper.ObjectWrapper<EventTypes
    *    (eg., tab URL of `devtools://devtools/bundled/devtools_app.html` uses a MainConnection but has no CDP server behind it).
    */
   hasFakeConnection(): boolean {
+    // Rehydrated DevTools always has a fake connection, so we shortcut and avoid the race.
+    if (Root.Runtime.getPathName().includes('rehydrated_devtools_app')) {
+      return true;
+    }
     // There _may_ be a race condition hiding here on the router/connection creation.
     // So we play it safe and consider "no connection yet" as "not fake".
     const connection = this.primaryPageTarget()?.router()?.connection();

package/front_end/entrypoints/main/MainImpl.ts

@@ -519,7 +519,12 @@ export class MainImpl {
 
     // Initialize `GDPClient` and `UserBadges` for Google Developer Program integration
     if (Host.GdpClient.isGdpProfilesAvailable()) {
-      void Host.GdpClient.GdpClient.instance().initialize();
+      void Host.GdpClient.GdpClient.instance().initialize().then(({hasProfile, isEligible}) => {
+        const contextString = hasProfile ? 'has-profile' :
+            isEligible                   ? 'no-profile-and-eligible' :
+                                           'no-profile-and-not-eligible';
+        void VisualLogging.logFunctionCall('gdp-client-initialize', contextString);
+      });
       void Badges.UserBadges.instance().initialize();
       Badges.UserBadges.instance().addEventListener(Badges.Events.BADGE_TRIGGERED, async ev => {
         loadedPanelCommonModule ??= await import('../../panels/common/common.js') as typeof PanelCommon;

package/front_end/entrypoints/main/main-meta.ts

@@ -188,9 +188,9 @@ const UIStrings = {
   browserLanguage: 'Browser UI language',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
-   * of syncing DevTools settings via Chrome Sync.
+   * of saving settings to their Google account.
    */
-  enableSync: 'Enable settings sync',
+  saveSettings: 'Save `DevTools` settings to your `Google` account',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
    * of receiving Google Developer Program (GDP) badges based on their activity in Chrome DevTools.
@@ -789,7 +789,7 @@ Common.Settings.registerSettingExtension({
   // This name must be kept in sync with DevToolsSettings::kSyncDevToolsPreferencesFrontendName.
   settingName: 'sync-preferences',
   settingType: Common.Settings.SettingType.BOOLEAN,
-  title: i18nLazyString(UIStrings.enableSync),
+  title: i18nLazyString(UIStrings.saveSettings),
   defaultValue: false,
   reloadRequired: true,
 });

package/front_end/generated/SupportedCSSProperties.js

@@ -641,6 +641,7 @@ export const generatedProperties = [
    "row-rule-style",
    "row-rule-width",
    "ruby-align",
+   "ruby-overhang",
    "ruby-position",
    "rx",
    "ry",
@@ -738,7 +739,7 @@ export const generatedProperties = [
    "timeline-trigger-name",
    "timeline-trigger-range-end",
    "timeline-trigger-range-start",
-   "timeline-trigger-timeline",
+   "timeline-trigger-source",
    "top",
    "touch-action",
    "transform",
@@ -3732,6 +3733,14 @@ export const generatedProperties = [
   ],
   "name": "ruby-align"
  },
+ {
+  "inherited": true,
+  "keywords": [
+   "auto",
+   "none"
+  ],
+  "name": "ruby-overhang"
+ },
  {
   "inherited": true,
   "keywords": [
@@ -4422,7 +4431,7 @@ export const generatedProperties = [
  {
   "longhands": [
    "timeline-trigger-name",
-   "timeline-trigger-timeline",
+   "timeline-trigger-source",
    "timeline-trigger-behavior",
    "timeline-trigger-range-start",
    "timeline-trigger-range-end",
@@ -4460,7 +4469,7 @@ export const generatedProperties = [
    "none",
    "auto"
   ],
-  "name": "timeline-trigger-timeline"
+  "name": "timeline-trigger-source"
  },
  {
   "keywords": [
@@ -6482,6 +6491,12 @@ export const generatedPropertyValues = {
    "space-between"
   ]
  },
+ "ruby-overhang": {
+  "values": [
+   "auto",
+   "none"
+  ]
+ },
  "ruby-position": {
   "values": [
    "over",
@@ -6839,7 +6854,7 @@ export const generatedPropertyValues = {
    "state"
   ]
  },
- "timeline-trigger-timeline": {
+ "timeline-trigger-source": {
   "values": [
    "none",
    "auto"

package/front_end/models/ai_assistance/agents/AiAgent.ts

@@ -133,13 +133,7 @@ export interface ParsedAnswer {
   suggestions?: [string, ...string[]];
 }
 
-export interface ParsedStep {
-  thought?: string;
-  title?: string;
-  action?: string;
-}
-
-export type ParsedResponse = ParsedAnswer|ParsedStep;
+export type ParsedResponse = ParsedAnswer;
 
 export const MAX_STEPS = 10;
 
@@ -404,13 +398,66 @@ export abstract class AiAgent<T> {
     return this.#origin;
   }
 
+  /**
+   * The AI has instructions to emit structured suggestions in their response. This
+   * function parses for that.
+   *
+   * Note: currently only StylingAgent and PerformanceAgent utilize this, but
+   * eventually all agents should support this.
+   */
+  parseTextResponseForSuggestions(text: string): ParsedResponse {
+    if (!text) {
+      return {answer: ''};
+    }
+
+    const lines = text.split('\n');
+    const answerLines: string[] = [];
+    let suggestions: [string, ...string[]]|undefined;
+
+    for (const line of lines) {
+      const trimmed = line.trim();
+      if (trimmed.startsWith('SUGGESTIONS:')) {
+        try {
+          // TODO: Do basic validation this is an array with strings
+          suggestions = JSON.parse(trimmed.substring('SUGGESTIONS:'.length).trim());
+        } catch {
+        }
+      } else {
+        answerLines.push(line);
+      }
+    }
+
+    // Sometimes the model fails to put the SUGGESTIONS text on its own line. Handle
+    // the case where the suggestions are part of the last line of the answer.
+    if (!suggestions && answerLines.at(-1)?.includes('SUGGESTIONS:')) {
+      const [answer, suggestionsText] = answerLines[answerLines.length - 1].split('SUGGESTIONS:', 2);
+      try {
+        // TODO: Do basic validation this is an array with strings
+        suggestions = JSON.parse(suggestionsText.trim().substring('SUGGESTIONS:'.length).trim());
+      } catch {
+      }
+      answerLines[answerLines.length - 1] = answer;
+    }
+
+    const response: ParsedResponse = {
+      // If we could not parse the parts, consider the response to be an
+      // answer.
+      answer: answerLines.join('\n'),
+    };
+
+    if (suggestions) {
+      response.suggestions = suggestions;
+    }
+
+    return response;
+  }
+
   /**
    * Parses a streaming text response into a
-   * though/action/title/answer/suggestions component. This is only used
-   * by StylingAgent.
+   * though/action/title/answer/suggestions component.
    */
   parseTextResponse(response: string): ParsedResponse {
-    return {answer: response};
+    return this.parseTextResponseForSuggestions(response.trim());
   }
 
   /**