chrome-devtools-frontend 1.0.1516909 → 1.0.1518653

package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.ts

@@ -8,22 +8,30 @@ import type {AICallTree} from '../performance/AICallTree.js';
 import type {AgentFocus} from '../performance/AIContext.js';
 import {AIQueries} from '../performance/AIQueries.js';
 
-import {PerformanceInsightFormatter, TraceEventFormatter} from './PerformanceInsightFormatter.js';
+import {NetworkRequestFormatter} from './NetworkRequestFormatter.js';
+import {PerformanceInsightFormatter} from './PerformanceInsightFormatter.js';
 import {bytes, micros, millis} from './UnitFormatters.js';
 
+export interface NetworkRequestFormatOptions {
+  verbose?: boolean;
+  customTitle?: string;
+}
+
 export class PerformanceTraceFormatter {
+  #focus: AgentFocus;
   #parsedTrace: Trace.TraceModel.ParsedTrace;
   #insightSet: Trace.Insights.Types.InsightSet|null;
-  #eventsSerializer: Trace.EventsSerializer.EventsSerializer;
+  protected eventsSerializer: Trace.EventsSerializer.EventsSerializer;
 
-  constructor(focus: AgentFocus, eventsSerializer: Trace.EventsSerializer.EventsSerializer) {
+  constructor(focus: AgentFocus) {
+    this.#focus = focus;
     this.#parsedTrace = focus.data.parsedTrace;
     this.#insightSet = focus.data.insightSet;
-    this.#eventsSerializer = eventsSerializer;
+    this.eventsSerializer = focus.eventsSerializer;
   }
 
   serializeEvent(event: Trace.Types.Events.Event): string {
-    const key = this.#eventsSerializer.keyForEvent(event);
+    const key = this.eventsSerializer.keyForEvent(event);
     return `(eventKey: ${key}, ts: ${event.ts})`;
   }
 
@@ -167,7 +175,7 @@ export class PerformanceTraceFormatter {
           continue;
         }
 
-        const formatter = new PerformanceInsightFormatter(parsedTrace, model);
+        const formatter = new PerformanceInsightFormatter(this.#focus, model);
         if (!formatter.insightIsSupported()) {
           continue;
         }
@@ -199,7 +207,6 @@ export class PerformanceTraceFormatter {
   }
 
   formatCriticalRequests(): string {
-    const parsedTrace = this.#parsedTrace;
     const insightSet = this.#insightSet;
     const criticalRequests: Trace.Types.Events.SyntheticNetworkRequest[] = [];
 
@@ -213,8 +220,7 @@ export class PerformanceTraceFormatter {
       return '';
     }
 
-    return 'Critical network requests:\n' +
-        TraceEventFormatter.networkRequests(criticalRequests, parsedTrace, {verbose: false});
+    return 'Critical network requests:\n' + this.formatNetworkRequests(criticalRequests, {verbose: false});
   }
 
   #serializeBottomUpRootNode(rootNode: Trace.Extras.TraceTree.BottomUpRootNode, limit: number): string {
@@ -421,7 +427,7 @@ export class PerformanceTraceFormatter {
 
     const requests = this.#parsedTrace.data.NetworkRequests.byTime.filter(
         request => Trace.Helpers.Timing.eventIsInBounds(request, bounds));
-    const requestsText = TraceEventFormatter.networkRequests(requests, this.#parsedTrace, {verbose: false});
+    const requestsText = this.formatNetworkRequests(requests, {verbose: false});
     results.push('# Network requests summary');
     results.push(requestsText || 'No requests in the given bounds');
 
@@ -443,11 +449,304 @@ export class PerformanceTraceFormatter {
     results.push('#'.repeat(headerLevel) + ' Node id to eventKey\n');
     results.push('These node ids correspond to the call tree nodes listed in the above section.\n');
     tree.breadthFirstWalk(tree.rootNode.children().values(), (node, nodeId) => {
-      results.push(`${nodeId}: ${this.#eventsSerializer.keyForEvent(node.event)}`);
+      results.push(`${nodeId}: ${this.eventsSerializer.keyForEvent(node.event)}`);
     });
 
     results.push('\nIMPORTANT: Never show eventKey to the user.');
 
     return results.join('\n');
   }
+
+  formatNetworkRequests(
+      requests: readonly Trace.Types.Events.SyntheticNetworkRequest[], options?: NetworkRequestFormatOptions): string {
+    if (requests.length === 0) {
+      return '';
+    }
+
+    let verbose;
+    if (options?.verbose !== undefined) {
+      verbose = options.verbose;
+    } else {
+      verbose = requests.length === 1;
+    }
+
+    // Use verbose format for a single network request. With the compressed format, a format description
+    // needs to be provided, which is not worth sending if only one network request is being stringified.
+    if (verbose) {
+      return requests.map(request => this.#networkRequestVerbosely(request, options)).join('\n');
+    }
+
+    return this.#networkRequestsArrayCompressed(requests);
+  }
+
+  #getOrAssignUrlIndex(urlIdToIndex: Map<string, number>, url: string): number {
+    let index = urlIdToIndex.get(url);
+    if (index !== undefined) {
+      return index;
+    }
+    index = urlIdToIndex.size;
+    urlIdToIndex.set(url, index);
+    return index;
+  }
+
+  #getInitiatorChain(parsedTrace: Trace.TraceModel.ParsedTrace, request: Trace.Types.Events.SyntheticNetworkRequest):
+      Trace.Types.Events.SyntheticNetworkRequest[] {
+    const initiators: Trace.Types.Events.SyntheticNetworkRequest[] = [];
+
+    let cur: Trace.Types.Events.SyntheticNetworkRequest|undefined = request;
+    while (cur) {
+      const initiator = parsedTrace.data.NetworkRequests.eventToInitiator.get(cur);
+      if (initiator) {
+        // Should never happen, but if it did that would be an infinite loop.
+        if (initiators.includes(initiator)) {
+          return [];
+        }
+
+        initiators.unshift(initiator);
+      }
+
+      cur = initiator;
+    }
+
+    return initiators;
+  }
+
+  /**
+   * This is the data passed to a network request when the Performance Insights
+   * agent is asking for information. It is a slimmed down version of the
+   * request's data to avoid using up too much of the context window.
+   * IMPORTANT: these set of fields have been reviewed by Chrome Privacy &
+   * Security; be careful about adding new data here. If you are in doubt please
+   * talk to jacktfranklin@.
+   */
+  #networkRequestVerbosely(request: Trace.Types.Events.SyntheticNetworkRequest, options?: NetworkRequestFormatOptions):
+      string {
+    const {
+      url,
+      statusCode,
+      initialPriority,
+      priority,
+      fromServiceWorker,
+      mimeType,
+      responseHeaders,
+      syntheticData,
+      protocol
+    } = request.args.data;
+    const parsedTrace = this.#parsedTrace;
+
+    const titlePrefix = `## ${options?.customTitle ?? 'Network request'}`;
+
+    // Note: unlike other agents, we do have the ability to include
+    // cross-origins, hence why we do not sanitize the URLs here.
+    const navigationForEvent = Trace.Helpers.Trace.getNavigationForTraceEvent(
+        request,
+        request.args.data.frame,
+        parsedTrace.data.Meta.navigationsByFrameId,
+    );
+    const baseTime = navigationForEvent?.ts ?? parsedTrace.data.Meta.traceBounds.min;
+
+    // Gets all the timings for this request, relative to the base time.
+    // Note that this is the start time, not total time. E.g. "queuedAt: X"
+    // means that the request was queued at Xms, not that it queued for Xms.
+    const startTimesForLifecycle = {
+      queuedAt: request.ts - baseTime,
+      requestSentAt: syntheticData.sendStartTime - baseTime,
+      downloadCompletedAt: syntheticData.finishTime - baseTime,
+      processingCompletedAt: request.ts + request.dur - baseTime,
+    } as const;
+
+    const mainThreadProcessingDuration =
+        startTimesForLifecycle.processingCompletedAt - startTimesForLifecycle.downloadCompletedAt;
+    const downloadTime = syntheticData.finishTime - syntheticData.downloadStart;
+
+    const renderBlocking = Trace.Helpers.Network.isSyntheticNetworkRequestEventRenderBlocking(request);
+    const initiator = parsedTrace.data.NetworkRequests.eventToInitiator.get(request);
+
+    const priorityLines = [];
+    if (initialPriority === priority) {
+      priorityLines.push(`Priority: ${priority}`);
+    } else {
+      priorityLines.push(`Initial priority: ${initialPriority}`);
+      priorityLines.push(`Final priority: ${priority}`);
+    }
+
+    const redirects = request.args.data.redirects.map((redirect, index) => {
+      const startTime = redirect.ts - baseTime;
+      return `#### Redirect ${index + 1}: ${redirect.url}
+- Start time: ${micros(startTime)}
+- Duration: ${micros(redirect.dur)}`;
+    });
+
+    const initiators = this.#getInitiatorChain(parsedTrace, request);
+    const initiatorUrls = initiators.map(initiator => initiator.args.data.url);
+
+    const eventKey = this.eventsSerializer.keyForEvent(request);
+    const eventKeyLine = eventKey ? `eventKey: ${eventKey}\n` : '';
+
+    return `${titlePrefix}: ${url}
+${eventKeyLine}Timings:
+- Queued at: ${micros(startTimesForLifecycle.queuedAt)}
+- Request sent at: ${micros(startTimesForLifecycle.requestSentAt)}
+- Download complete at: ${micros(startTimesForLifecycle.downloadCompletedAt)}
+- Main thread processing completed at: ${micros(startTimesForLifecycle.processingCompletedAt)}
+Durations:
+- Download time: ${micros(downloadTime)}
+- Main thread processing time: ${micros(mainThreadProcessingDuration)}
+- Total duration: ${micros(request.dur)}${initiator ? `\nInitiator: ${initiator.args.data.url}` : ''}
+Redirects:${redirects.length ? '\n' + redirects.join('\n') : ' no redirects'}
+Status code: ${statusCode}
+MIME Type: ${mimeType}
+Protocol: ${protocol}
+${priorityLines.join('\n')}
+Render blocking: ${renderBlocking ? 'Yes' : 'No'}
+From a service worker: ${fromServiceWorker ? 'Yes' : 'No'}
+Initiators (root request to the request that directly loaded this one): ${initiatorUrls.join(', ') || 'none'}
+${NetworkRequestFormatter.formatHeaders('Response headers', responseHeaders ?? [], true)}`;
+  }
+
+  // A compact network requests format designed to save tokens when sending multiple network requests to the model.
+  // It creates a map that maps request URLs to IDs and references the IDs in the compressed format.
+  //
+  // Important: Do not use this method for stringifying a single network request. With this format, a format description
+  // needs to be provided, which is not worth sending if only one network request is being stringified.
+  // For a single request, use `formatRequestVerbosely`, which formats with all fields specified and does not require a
+  // format description.
+  #networkRequestsArrayCompressed(requests: readonly Trace.Types.Events.SyntheticNetworkRequest[]): string {
+    const networkDataString = `
+Network requests data:
+
+`;
+    const urlIdToIndex = new Map<string, number>();
+    const allRequestsText = requests
+                                .map(request => {
+                                  const urlIndex = this.#getOrAssignUrlIndex(urlIdToIndex, request.args.data.url);
+                                  return this.#networkRequestCompressedFormat(urlIndex, request, urlIdToIndex);
+                                })
+                                .join('\n');
+
+    const urlsMapString = 'allUrls = ' +
+        `[${
+                              Array.from(urlIdToIndex.entries())
+                                  .map(([url, index]) => {
+                                    return `${index}: ${url}`;
+                                  })
+                                  .join(', ')}]`;
+
+    return networkDataString + '\n\n' + urlsMapString + '\n\n' + allRequestsText;
+  }
+
+  /**
+   * Network requests format description that is sent to the model as a fact.
+   */
+  static networkDataFormatDescription = `Network requests are formatted like this:
+\`urlIndex;eventKey;queuedTime;requestSentTime;downloadCompleteTime;processingCompleteTime;totalDuration;downloadDuration;mainThreadProcessingDuration;statusCode;mimeType;priority;initialPriority;finalPriority;renderBlocking;protocol;fromServiceWorker;initiators;redirects:[[redirectUrlIndex|startTime|duration]];responseHeaders:[header1Value|header2Value|...]\`
+
+- \`urlIndex\`: Numerical index for the request's URL, referencing the "All URLs" list.
+- \`eventKey\`: String that uniquely identifies this request's trace event.
+Timings (all in milliseconds, relative to navigation start):
+- \`queuedTime\`: When the request was queued.
+- \`requestSentTime\`: When the request was sent.
+- \`downloadCompleteTime\`: When the download completed.
+- \`processingCompleteTime\`: When main thread processing finished.
+Durations (all in milliseconds):
+- \`totalDuration\`: Total time from the request being queued until its main thread processing completed.
+- \`downloadDuration\`: Time spent actively downloading the resource.
+- \`mainThreadProcessingDuration\`: Time spent on the main thread after the download completed.
+- \`statusCode\`: The HTTP status code of the response (e.g., 200, 404).
+- \`mimeType\`: The MIME type of the resource (e.g., "text/html", "application/javascript").
+- \`priority\`: The final network request priority (e.g., "VeryHigh", "Low").
+- \`initialPriority\`: The initial network request priority.
+- \`finalPriority\`: The final network request priority (redundant if \`priority\` is always final, but kept for clarity if \`initialPriority\` and \`priority\` differ).
+- \`renderBlocking\`: 't' if the request was render-blocking, 'f' otherwise.
+- \`protocol\`: The network protocol used (e.g., "h2", "http/1.1").
+- \`fromServiceWorker\`: 't' if the request was served from a service worker, 'f' otherwise.
+- \`initiators\`: A list (separated by ,) of URL indices for the initiator chain of this request. Listed in order starting from the root request to the request that directly loaded this one. This represents the network dependencies necessary to load this request. If there is no initiator, this is empty.
+- \`redirects\`: A comma-separated list of redirects, enclosed in square brackets. Each redirect is formatted as
+\`[redirectUrlIndex|startTime|duration]\`, where: \`redirectUrlIndex\`: Numerical index for the redirect's URL. \`startTime\`: The start time of the redirect in milliseconds, relative to navigation start. \`duration\`: The duration of the redirect in milliseconds.
+- \`responseHeaders\`: A list (separated by '|') of values for specific, pre-defined response headers, enclosed in square brackets.
+The order of headers corresponds to an internal fixed list. If a header is not present, its value will be empty.
+`;
+
+  /**
+   * This is the network request data passed to the Performance agent.
+   *
+   * The `urlIdToIndex` Map is used to map URLs to numerical indices in order to not need to pass whole url every time it's mentioned.
+   * The map content is passed in the response together will all the requests data.
+   *
+   * See `networkDataFormatDescription` above for specifics.
+   */
+  #networkRequestCompressedFormat(
+      urlIndex: number, request: Trace.Types.Events.SyntheticNetworkRequest,
+      urlIdToIndex: Map<string, number>): string {
+    const {
+      statusCode,
+      initialPriority,
+      priority,
+      fromServiceWorker,
+      mimeType,
+      responseHeaders,
+      syntheticData,
+      protocol,
+    } = request.args.data;
+    const parsedTrace = this.#parsedTrace;
+
+    const navigationForEvent = Trace.Helpers.Trace.getNavigationForTraceEvent(
+        request,
+        request.args.data.frame,
+        parsedTrace.data.Meta.navigationsByFrameId,
+    );
+    const baseTime = navigationForEvent?.ts ?? parsedTrace.data.Meta.traceBounds.min;
+    const queuedTime = micros(request.ts - baseTime);
+    const requestSentTime = micros(syntheticData.sendStartTime - baseTime);
+    const downloadCompleteTime = micros(syntheticData.finishTime - baseTime);
+    const processingCompleteTime = micros(request.ts + request.dur - baseTime);
+    const totalDuration = micros(request.dur);
+    const downloadDuration = micros(syntheticData.finishTime - syntheticData.downloadStart);
+    const mainThreadProcessingDuration = micros(request.ts + request.dur - syntheticData.finishTime);
+    const renderBlocking = Trace.Helpers.Network.isSyntheticNetworkRequestEventRenderBlocking(request) ? 't' : 'f';
+    const finalPriority = priority;
+    const headerValues = responseHeaders
+                             ?.map(header => {
+                               const value =
+                                   NetworkRequestFormatter.allowHeader(header.name) ? header.value : '<redacted>';
+                               return `${header.name}: ${value}`;
+                             })
+                             .join('|');
+    const redirects = request.args.data.redirects
+                          .map(redirect => {
+                            const urlIndex = this.#getOrAssignUrlIndex(urlIdToIndex, redirect.url);
+                            const redirectStartTime = micros(redirect.ts - baseTime);
+                            const redirectDuration = micros(redirect.dur);
+                            return `[${urlIndex}|${redirectStartTime}|${redirectDuration}]`;
+                          })
+                          .join(',');
+
+    const initiators = this.#getInitiatorChain(parsedTrace, request);
+    const initiatorUrlIndices =
+        initiators.map(initiator => this.#getOrAssignUrlIndex(urlIdToIndex, initiator.args.data.url));
+
+    const parts = [
+      urlIndex,
+      this.eventsSerializer.keyForEvent(request) ?? '',
+      queuedTime,
+      requestSentTime,
+      downloadCompleteTime,
+      processingCompleteTime,
+      totalDuration,
+      downloadDuration,
+      mainThreadProcessingDuration,
+      statusCode,
+      mimeType,
+      priority,
+      initialPriority,
+      finalPriority,
+      renderBlocking,
+      protocol,
+      fromServiceWorker ? 't' : 'f',
+      initiatorUrlIndices.join(','),
+      `[${redirects}]`,
+      `[${headerValues ?? ''}]`,
+    ];
+    return parts.join(';');
+  }
 }

package/front_end/models/ai_assistance/performance/AIContext.ts

@@ -21,7 +21,7 @@ function getFirstInsightSet(insights: Trace.Insights.Types.TraceInsightSets): Tr
 }
 
 export class AgentFocus {
-  static full(parsedTrace: Trace.TraceModel.ParsedTrace): AgentFocus {
+  static fromParsedTrace(parsedTrace: Trace.TraceModel.ParsedTrace): AgentFocus {
     if (!parsedTrace.insights) {
       throw new Error('missing insights');
     }
@@ -69,6 +69,7 @@ export class AgentFocus {
   }
 
   #data: AgentFocusData;
+  readonly eventsSerializer = new Trace.EventsSerializer.EventsSerializer();
 
   constructor(data: AgentFocusData) {
     this.#data = data;
@@ -89,6 +90,18 @@ export class AgentFocus {
     focus.#data.callTree = callTree;
     return focus;
   }
+
+  lookupEvent(key: Trace.Types.File.SerializableKey): Trace.Types.Events.Event|null {
+    try {
+      return this.eventsSerializer.eventForKey(key, this.#data.parsedTrace);
+    } catch (err) {
+      if (err.toString().includes('Unknown trace event')) {
+        return null;
+      }
+
+      throw err;
+    }
+  }
 }
 
 export function getPerformanceAgentFocusFromModel(model: Trace.TraceModel.Model): AgentFocus|null {
@@ -97,5 +110,5 @@ export function getPerformanceAgentFocusFromModel(model: Trace.TraceModel.Model)
     return null;
   }
 
-  return AgentFocus.full(parsedTrace);
+  return AgentFocus.fromParsedTrace(parsedTrace);
 }

package/front_end/models/ai_code_completion/AiCodeCompletion.ts

@@ -143,13 +143,14 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
   #stopSequences: string[];
   #renderingTimeout?: number;
   #aidaRequestCache?: CachedRequest;
-  #panel: Panel;
+  #panel: ContextFlavor;
 
   readonly #sessionId: string = crypto.randomUUID();
   readonly #aidaClient: Host.AidaClient.AidaClient;
   readonly #serverSideLoggingEnabled: boolean;
 
-  constructor(opts: AgentOptions, editor: TextEditor.TextEditor.TextEditor, panel: Panel, stopSequences?: string[]) {
+  constructor(
+      opts: AgentOptions, editor: TextEditor.TextEditor.TextEditor, panel: ContextFlavor, stopSequences?: string[]) {
     super();
     this.#aidaClient = opts.aidaClient;
     this.#serverSideLoggingEnabled = opts.serverSideLoggingEnabled ?? false;
@@ -177,12 +178,12 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
     // As a temporary fix for b/441221870 we are prepending a newline for each prefix.
     prefix = '\n' + prefix;
 
-    const additionalFiles = this.#panel === Panel.CONSOLE ? [{
+    const additionalFiles = this.#panel === ContextFlavor.CONSOLE ? [{
       path: 'devtools-console-context.js',
       content: consoleAdditionalContextFileContent,
       included_reason: Host.AidaClient.Reason.RELATED_FILE,
     }] :
-                                                            undefined;
+                                                                    undefined;
 
     return {
       client: Host.AidaClient.CLIENT_NAME,
@@ -276,6 +277,11 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
       return null;
     }
 
+    const isRepetitive = this.#checkIfSuggestionRepeatsExistingText(suggestionSample.generationString, request);
+    if (isRepetitive) {
+      return null;
+    }
+
     const suggestionText = this.#trimSuggestionOverlap(suggestionSample.generationString, request);
     if (suggestionText.length === 0) {
       return null;
@@ -333,11 +339,6 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
           Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiCodeCompletionResponseServedFromCache);
         }
 
-        if (rpcGlobalId) {
-          const latency = performance.now() - startTime;
-          this.#registerUserImpression(rpcGlobalId, sampleId, latency);
-        }
-
         debugLog('Suggestion dispatched to the editor', suggestionText, 'at cursor position', cursorPositionAtRequest);
         this.dispatchEventToListeners(Events.RESPONSE_RECEIVED, {citations});
       }, remainingDelay);
@@ -381,6 +382,11 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
     return generationString;
   }
 
+  #checkIfSuggestionRepeatsExistingText(generationString: string, request: Host.AidaClient.CompletionRequest): boolean {
+    const {prefix, suffix} = request;
+    return Boolean(prefix.includes(generationString.trim()) || suffix?.includes(generationString.trim()));
+  }
+
   #checkCachedRequestForResponse(request: Host.AidaClient.CompletionRequest): Host.AidaClient.CompletionResponse|null {
     if (!this.#aidaRequestCache || this.#aidaRequestCache.request.suffix !== request.suffix ||
         JSON.stringify(this.#aidaRequestCache.request.options) !== JSON.stringify(request.options)) {
@@ -467,8 +473,8 @@ export class AiCodeCompletion extends Common.ObjectWrapper.ObjectWrapper<EventTy
   }
 }
 
-export const enum Panel {
-  CONSOLE = 'console',
+export const enum ContextFlavor {
+  CONSOLE = 'console',  // generated code can contain console specific APIs like `$0`.
   SOURCES = 'sources',
 }
 

package/front_end/models/badges/Badge.ts

@@ -12,6 +12,7 @@ export enum BadgeAction {
   MODERN_DOM_BADGE_CLICKED = 'modern-dom-badge-clicked',
   // TODO(ergunsh): Instrument performance insight clicks.
   PERFORMANCE_INSIGHT_CLICKED = 'performance-insight-clicked',
+  DEBUGGER_PAUSED = 'debugger-paused'
 }
 
 export type BadgeActionEvents = Record<BadgeAction, void>;
@@ -21,8 +22,12 @@ export interface BadgeContext {
   badgeActionEventTarget: Common.ObjectWrapper.ObjectWrapper<BadgeActionEvents>;
 }
 
+export interface TriggerOptions {
+  immediate?: boolean;
+}
+
 export abstract class Badge {
-  #onTriggerBadge: (badge: Badge) => void;
+  #onTriggerBadge: (badge: Badge, opts?: TriggerOptions) => void;
   #badgeActionEventTarget: Common.ObjectWrapper.ObjectWrapper<BadgeActionEvents>;
   #eventListeners: Common.EventTarget.EventDescriptor[] = [];
   #triggeredBefore = false;
@@ -39,14 +44,14 @@ export abstract class Badge {
   }
 
   abstract handleAction(action: BadgeAction): void;
-  protected trigger(): void {
+  protected trigger(opts?: TriggerOptions): void {
     if (this.#triggeredBefore) {
       return;
     }
 
     this.#triggeredBefore = true;
     this.deactivate();
-    this.#onTriggerBadge(this);
+    this.#onTriggerBadge(this, opts);
   }
 
   activate(): void {

package/front_end/models/badges/CodeWhispererBadge.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {Badge, type BadgeAction} from './Badge.js';
+import {Badge, BadgeAction} from './Badge.js';
 
 const CODE_WHISPERER_BADGE_IMAGE_URI = new URL('../../Images/code-whisperer-badge.svg', import.meta.url).toString();
 export class CodeWhispererBadge extends Badge {
@@ -11,9 +11,7 @@ export class CodeWhispererBadge extends Badge {
   override readonly title = 'Code Whisperer';
   override readonly imageUri = CODE_WHISPERER_BADGE_IMAGE_URI;
 
-  override readonly interestedActions = [
-    // TODO(ergunsh): Instrument related actions.
-  ] as const;
+  override readonly interestedActions = [BadgeAction.DEBUGGER_PAUSED] as const;
 
   handleAction(_action: BadgeAction): void {
     this.trigger();

package/front_end/models/badges/StarterBadge.ts

@@ -20,7 +20,7 @@ export class StarterBadge extends Badge {
     BadgeAction.DOM_ELEMENT_OR_ATTRIBUTE_EDITED,
   ] as const;
 
-  handleAction(_action: BadgeAction): void {
-    this.trigger();
+  handleAction(action: BadgeAction): void {
+    this.trigger({immediate: action === BadgeAction.GDP_SIGN_UP_COMPLETE});
   }
 }

package/front_end/models/badges/UserBadges.ts

@@ -4,9 +4,10 @@
 
 import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
+import * as Root from '../../core/root/root.js';
 
 import {AiExplorerBadge} from './AiExplorerBadge.js';
-import type {Badge, BadgeAction, BadgeActionEvents, BadgeContext} from './Badge.js';
+import type {Badge, BadgeAction, BadgeActionEvents, BadgeContext, TriggerOptions} from './Badge.js';
 import {CodeWhispererBadge} from './CodeWhispererBadge.js';
 import {DOMDetectiveBadge} from './DOMDetectiveBadge.js';
 import {SpeedsterBadge} from './SpeedsterBadge.js';
@@ -24,6 +25,7 @@ export interface EventTypes {
 
 const SNOOZE_TIME_MS = 24 * 60 * 60 * 1000;  // 24 hours
 const MAX_SNOOZE_COUNT = 3;
+const DELAY_BEFORE_TRIGGER = 1500;
 
 let userBadgesInstance: UserBadges|undefined = undefined;
 export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
@@ -48,6 +50,10 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     super();
 
     this.#receiveBadgesSetting = Common.Settings.Settings.instance().moduleSetting('receive-gdp-badges');
+    if (Host.GdpClient.getGdpProfilesEnterprisePolicy() ===
+        Root.Runtime.GdpProfilesEnterprisePolicyValue.ENABLED_WITHOUT_BADGES) {
+      this.#receiveBadgesSetting.set(false);
+    }
     this.#receiveBadgesSetting.addChangeListener(this.#reconcileBadges, this);
 
     this.#starterBadgeSnoozeCount = Common.Settings.Settings.instance().createSetting(
@@ -93,7 +99,8 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     this.#badgeActionEventTarget.dispatchEventToListeners(action);
   }
 
-  async #onTriggerBadge(badge: Badge): Promise<void> {
+  async #onTriggerBadge(badge: Badge, opts?: TriggerOptions): Promise<void> {
+    const triggerTime = Date.now();
     let shouldAwardBadge = false;
     // By default, we award non-starter badges directly when they are triggered.
     if (!badge.isStarterBadge) {
@@ -116,7 +123,12 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
       }
     }
 
-    this.dispatchEventToListeners(Events.BADGE_TRIGGERED, badge);
+    const timeElapsedAfterTriggerCall = Date.now() - triggerTime;
+    // We want to add exactly 1.5 second delay between the trigger action & the notification.
+    const delay = opts?.immediate ? 0 : Math.max(DELAY_BEFORE_TRIGGER - timeElapsedAfterTriggerCall, 0);
+    setTimeout(() => {
+      this.dispatchEventToListeners(Events.BADGE_TRIGGERED, badge);
+    }, delay);
   }
 
   #deactivateAllBadges(): void {
@@ -145,6 +157,12 @@ export class UserBadges extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
       return;
     }
 
+    if (!Host.GdpClient.isGdpProfilesAvailable() ||
+        Host.GdpClient.getGdpProfilesEnterprisePolicy() !== Root.Runtime.GdpProfilesEnterprisePolicyValue.ENABLED) {
+      this.#deactivateAllBadges();
+      return;
+    }
+
     const [gdpProfile, isEligibleToCreateProfile] = await Promise.all([
       Host.GdpClient.GdpClient.instance().getProfile(),
       Host.GdpClient.GdpClient.instance().isEligibleToCreateProfile(),

package/front_end/models/javascript_metadata/NativeFunctions.js

@@ -8470,7 +8470,7 @@ export const NativeFunctions = [
   },
   {
     name: "submitPrintJob",
-    signatures: [["job_name","document","attributes"]]
+    signatures: [["job_name","document_data","attributes"]]
   },
   {
     name: "PushEvent",