chrome-devtools-frontend 1.0.1515988 → 1.0.1516909

package/front_end/third_party/puppeteer/package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "puppeteer-core",
-  "version": "24.21.0",
+  "version": "24.22.0",
   "description": "A high-level API to control headless Chrome over the DevTools Protocol",
   "keywords": [
     "puppeteer",

package/front_end/third_party/puppeteer/package/src/cdp/Accessibility.ts

@@ -319,7 +319,6 @@ class AXNode {
   #name: string;
   #role: string;
   #ignored: boolean;
-  #cachedHasFocusableChild?: boolean;
   #realm: Realm;
 
   constructor(realm: Realm, payload: Protocol.Accessibility.AXNode) {
@@ -362,19 +361,6 @@ class AXNode {
     );
   }
 
-  #hasFocusableChild(): boolean {
-    if (this.#cachedHasFocusableChild === undefined) {
-      this.#cachedHasFocusableChild = false;
-      for (const child of this.children) {
-        if (child.#focusable || child.#hasFocusableChild()) {
-          this.#cachedHasFocusableChild = true;
-          break;
-        }
-      }
-    }
-    return this.#cachedHasFocusableChild;
-  }
-
   public find(predicate: (x: AXNode) => boolean): AXNode | null {
     if (predicate(this)) {
       return this;
@@ -420,16 +406,10 @@ class AXNode {
         break;
     }
 
-    // Here and below: Android heuristics
-    if (this.#hasFocusableChild()) {
-      return false;
-    }
-    if (this.#focusable && this.#name && this.#name !== 'Document') {
-      return true;
-    }
     if (this.#role === 'heading' && this.#name) {
       return true;
     }
+
     return false;
   }
 

package/front_end/third_party/puppeteer/package/src/generated/version.ts

@@ -1,4 +1,4 @@
 /**
  * @internal
  */
-export const packageVersion = '24.21.0';
+export const packageVersion = '24.22.0';

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -10,5 +10,5 @@
 export const PUPPETEER_REVISIONS = Object.freeze({
   chrome: '140.0.7339.82',
   'chrome-headless-shell': '140.0.7339.82',
-  firefox: 'stable_142.0.1',
+  firefox: 'stable_143.0',
 });

package/front_end/ui/components/text_editor/config.ts

@@ -484,8 +484,10 @@ export const setAiAutoCompleteSuggestion = CM.StateEffect.define<ActiveSuggestio
 interface ActiveSuggestion {
   text: string;
   from: number;
-  sampleId?: number;
+  sampleId: number;
   rpcGlobalId?: Host.AidaClient.RpcGlobalId;
+  startTime: number;
+  onImpression: (rpcGlobalId: Host.AidaClient.RpcGlobalId, sampleId: number, latency: number) => void;
 }
 
 export const aiAutoCompleteSuggestionState = CM.StateField.define<ActiveSuggestion|null>({
@@ -569,8 +571,15 @@ export const aiAutoCompleteSuggestion: CM.Extension = [
   CM.ViewPlugin.fromClass(
       class {
         decorations: CM.DecorationSet = CM.Decoration.none;
+        #lastLoggedSuggestion: ActiveSuggestion|null = null;
 
         update(update: CM.ViewUpdate): void {
+          // If there is no text on the document, we don't want to show the AI suggestion.
+          if (update.state.doc.length === 0) {
+            this.decorations = CM.Decoration.none;
+            return;
+          }
+
           // Hide decorations if there is no active AI suggestion.
           const activeSuggestion = update.state.field(aiAutoCompleteSuggestionState);
           if (!activeSuggestion) {
@@ -605,6 +614,12 @@ export const aiAutoCompleteSuggestion: CM.Extension = [
 
           let ghostText = activeSuggestion.text.slice(additionallyTypedText.length);
           if (selectedCompletion) {
+            // Do not show AI generated suggestion if top traditional suggestion is of type
+            // 'keyword' - `do`, `while` etc.
+            if (selectedCompletion.type?.includes('keyword')) {
+              this.decorations = CM.Decoration.none;
+              return;
+            }
             // If the user typed the full selected completion, then we don't check for overlap.
             // (e.g. the user wrote `flex`, traditional suggestion is `flex` and the AI autocompletion is
             // `;\njustify-content: center`. Then, we want to show the AI completion)
@@ -635,6 +650,20 @@ export const aiAutoCompleteSuggestion: CM.Extension = [
 
           this.decorations =
               CM.Decoration.set([CM.Decoration.widget({widget: new CompletionHint(ghostText), side: 1}).range(head)]);
+          this.#registerImpressionIfNeeded(activeSuggestion);
+        }
+
+        #registerImpressionIfNeeded(activeSuggestion: ActiveSuggestion): void {
+          if (!activeSuggestion.rpcGlobalId) {
+            return;
+          }
+          if (this.#lastLoggedSuggestion?.rpcGlobalId === activeSuggestion?.rpcGlobalId &&
+              this.#lastLoggedSuggestion?.sampleId === activeSuggestion?.sampleId) {
+            return;
+          }
+          const latency = performance.now() - activeSuggestion.startTime;
+          // only register impression for the first time AI generated suggestion is shown to the user.
+          activeSuggestion.onImpression(activeSuggestion.rpcGlobalId, activeSuggestion.sampleId, latency);
         }
       },
       {decorations: p => p.decorations}),

package/front_end/ui/components/tooltips/Tooltip.ts

@@ -360,9 +360,7 @@ export class Tooltip extends HTMLElement {
     if (this.open && Tooltip.lastOpenedTooltipId === this.id) {
       Tooltip.lastOpenedTooltipId = null;
     }
-    this.#timeout = window.setTimeout(() => {
-      this.hidePopover();
-    }, this.hoverDelay);
+    this.hidePopover();
   };
 
   toggle = (): void => {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1907,6 +1907,8 @@ export const knownContextValues = new Set([
   'interactions',
   'interactivity',
   'interest-delay',
+  'interest-delay-end',
+  'interest-delay-start',
   'interest-groups',
   'interest-hide-delay',
   'interest-show-delay',
@@ -3547,6 +3549,9 @@ export const knownContextValues = new Set([
   'start-time',
   'start-url',
   'start-view',
+  'starter-badge-dismissed',
+  'starter-badge-last-snoozed-timestamp',
+  'starter-badge-snooze-count',
   'static-global-setting',
   'static-synced-setting',
   'status',

package/package.json

@@ -102,5 +102,5 @@
       "@eslint/core": "0.15.1"
     }
   },
-  "version": "1.0.1515988"
+  "version": "1.0.1516909"
 }