chrome-devtools-frontend 1.0.1515796 → 1.0.1516909

package/front_end/models/trace/handlers/LayoutShiftsHandler.ts

@@ -37,15 +37,14 @@ import type {HandlerName} from './types.js';
 // score for the given recording, and almost certainly not the
 // navigation-to-unload CLS score.
 
-interface LayoutShifts {
+interface LayoutShiftsData {
   clusters: readonly Types.Events.SyntheticLayoutShiftCluster[];
   clustersByNavigationId: Map<Types.Events.NavigationId, Types.Events.SyntheticLayoutShiftCluster[]>;
   sessionMaxScore: number;
   // The session window which contains the SessionMaxScore
   clsWindowID: number;
   // We use these to calculate root causes for a given LayoutShift
-  // TODO(crbug/41484172): should be readonly
-  prePaintEvents: Types.Events.PrePaint[];
+  prePaintEvents: readonly Types.Events.PrePaint[];
   paintImageEvents: Types.Events.PaintImage[];
   layoutInvalidationEvents: readonly Types.Events.LayoutInvalidationTracking[];
   scheduleStyleInvalidationEvents: readonly Types.Events.ScheduleStyleInvalidationTracking[];
@@ -55,8 +54,7 @@ interface LayoutShifts {
   layoutImageUnsizedEvents: readonly Types.Events.LayoutImageUnsized[];
   remoteFonts: readonly RemoteFont[];
   scoreRecords: readonly ScoreRecord[];
-  // TODO(crbug/41484172): should be readonly
-  backendNodeIds: Protocol.DOM.BackendNodeId[];
+  backendNodeIds: Set<Protocol.DOM.BackendNodeId>;
 }
 
 interface RemoteFont {
@@ -524,7 +522,7 @@ async function buildLayoutShiftsClusters(): Promise<void> {
   }
 }
 
-export function data(): LayoutShifts {
+export function data(): LayoutShiftsData {
   return {
     clusters,
     sessionMaxScore,
@@ -532,15 +530,14 @@ export function data(): LayoutShifts {
     prePaintEvents,
     layoutInvalidationEvents,
     scheduleStyleInvalidationEvents,
-    styleRecalcInvalidationEvents: [],
+    styleRecalcInvalidationEvents,
     renderFrameImplCreateChildFrameEvents,
     domLoadingEvents,
     layoutImageUnsizedEvents,
     remoteFonts,
     scoreRecords,
-    // TODO(crbug/41484172): change the type so no need to clone
-    backendNodeIds: [...backendNodeIds],
-    clustersByNavigationId: new Map(clustersByNavigationId),
+    backendNodeIds,
+    clustersByNavigationId,
     paintImageEvents,
   };
 }

package/front_end/models/trace/handlers/MetaHandler.ts

@@ -28,11 +28,15 @@ let devicePixelRatio: number|null = null;
 let processNames = new Map<Types.Events.ProcessID, Types.Events.ProcessName>();
 
 let topLevelRendererIds = new Set<Types.Events.ProcessID>();
-const traceBounds: Types.Timing.TraceWindowMicro = {
-  min: Types.Timing.Micro(Number.POSITIVE_INFINITY),
-  max: Types.Timing.Micro(Number.NEGATIVE_INFINITY),
-  range: Types.Timing.Micro(Number.POSITIVE_INFINITY),
-};
+
+function makeNewTraceBounds(): Types.Timing.TraceWindowMicro {
+  return {
+    min: Types.Timing.Micro(Number.POSITIVE_INFINITY),
+    max: Types.Timing.Micro(Number.NEGATIVE_INFINITY),
+    range: Types.Timing.Micro(Number.POSITIVE_INFINITY),
+  };
+}
+let traceBounds: Types.Timing.TraceWindowMicro = makeNewTraceBounds();
 
 /**
  * These represent the user navigating. Values such as First Contentful Paint,
@@ -98,9 +102,7 @@ export function reset(): void {
   rendererProcessesByFrameId = new Map();
   framesByProcessId = new Map();
 
-  traceBounds.min = Types.Timing.Micro(Number.POSITIVE_INFINITY);
-  traceBounds.max = Types.Timing.Micro(Number.NEGATIVE_INFINITY);
-  traceBounds.range = Types.Timing.Micro(Number.POSITIVE_INFINITY);
+  traceBounds = makeNewTraceBounds();
   traceStartedTimeFromTracingStartedEvent = Types.Timing.Micro(-1);
 
   traceIsGeneric = true;
@@ -490,7 +492,7 @@ export type FrameProcessData =
 
 export function data(): MetaHandlerData {
   return {
-    traceBounds: {...traceBounds},
+    traceBounds,
     browserProcessId,
     browserThreadId,
     processNames,

package/front_end/models/trace/handlers/ScreenshotsHandler.ts

@@ -109,7 +109,7 @@ export interface Data {
   legacySyntheticScreenshots: Types.Events.LegacySyntheticScreenshot[]|null;
   screenshots: Types.Events.Screenshot[]|null;
 }
-// TODO(crbug/41484172): should be readonly
+
 export function data(): Data {
   return {
     legacySyntheticScreenshots: syntheticScreenshots.length ? syntheticScreenshots : null,

package/front_end/models/trace/handlers/ScriptsHandler.ts

@@ -54,14 +54,14 @@ export function reset(): void {
 }
 
 export function handleEvent(event: Types.Events.Event): void {
-  const getOrMakeScript = (isolate: string, scriptIdAsNumber: number): Script => {
+  const getOrMakeScript = (isolate: string|number, scriptIdAsNumber: number): Script => {
     const scriptId = String(scriptIdAsNumber) as Protocol.Runtime.ScriptId;
     const key = `${isolate}.${scriptId}`;
     return Platform.MapUtilities.getWithDefault(
         scriptById, key, () => ({isolate, scriptId, frame: '', ts: 0} as Script));
   };
 
-  if (Types.Events.isTargetRundownEvent(event) && event.args.data) {
+  if (Types.Events.isRundownScriptCompiled(event) && event.args.data) {
     const {isolate, scriptId, frame} = event.args.data;
     const script = getOrMakeScript(isolate, scriptId);
     script.frame = frame;
@@ -70,7 +70,7 @@ export function handleEvent(event: Types.Events.Event): void {
     return;
   }
 
-  if (Types.Events.isV8SourceRundownEvent(event)) {
+  if (Types.Events.isRundownScript(event)) {
     const {isolate, scriptId, url, sourceUrl, sourceMapUrl, sourceMapUrlElided} = event.args.data;
     const script = getOrMakeScript(isolate, scriptId);
     script.url = url;
@@ -91,14 +91,14 @@ export function handleEvent(event: Types.Events.Event): void {
     return;
   }
 
-  if (Types.Events.isV8SourceRundownSourcesScriptCatchupEvent(event)) {
+  if (Types.Events.isRundownScriptSource(event)) {
     const {isolate, scriptId, sourceText} = event.args.data;
     const script = getOrMakeScript(isolate, scriptId);
     script.content = sourceText;
     return;
   }
 
-  if (Types.Events.isV8SourceRundownSourcesLargeScriptCatchupEvent(event)) {
+  if (Types.Events.isRundownScriptSourceLarge(event)) {
     const {isolate, scriptId, sourceText} = event.args.data;
     const script = getOrMakeScript(isolate, scriptId);
     script.content = (script.content ?? '') + sourceText;

package/front_end/models/trace/handlers/UserInteractionsHandler.ts

@@ -9,14 +9,8 @@ import {data as metaHandlerData} from './MetaHandler.js';
 import {ScoreClassification} from './PageLoadMetricsHandler.js';
 import type {HandlerName} from './types.js';
 
-// This handler serves two purposes. It generates a list of events that are
-// used to show user clicks in the timeline. It is also used to gather
-// EventTimings into Interactions, which we use to show interactions and
-// highlight long interactions to the user, along with INP.
-
-// We don't need to know which process / thread these events occurred in,
-// because they are effectively global, so we just track all that we find.
-let allEvents: Types.Events.EventTimingBeginOrEnd[] = [];
+// This handler gathers EventTimings into Interactions, which we use to show
+// interactions and highlight long interactions to the user, along with INP.
 
 let beginCommitCompositorFrameEvents: Types.Events.BeginCommitCompositorFrame[] = [];
 let parseMetaViewportEvents: Types.Events.ParseMetaViewport[] = [];
@@ -27,8 +21,6 @@ const INP_GOOD_TIMING = LONG_INTERACTION_THRESHOLD;
 const INP_MEDIUM_TIMING = Helpers.Timing.milliToMicro(Types.Timing.Milli(500));
 
 export interface UserInteractionsData {
-  /** All the user events we found in the trace */
-  allEvents: readonly Types.Events.EventTimingBeginOrEnd[];
   /** All the BeginCommitCompositorFrame events we found in the trace */
   beginCommitCompositorFrameEvents: readonly Types.Events.BeginCommitCompositorFrame[];
   /** All the ParseMetaViewport events we found in the trace */
@@ -68,7 +60,6 @@ let eventTimingEndEventsById = new Map<string, Types.Events.EventTimingEnd>();
 let eventTimingStartEventsForInteractions: Types.Events.EventTimingBegin[] = [];
 
 export function reset(): void {
-  allEvents = [];
   beginCommitCompositorFrameEvents = [];
   parseMetaViewportEvents = [];
   interactionEvents = [];
@@ -98,8 +89,6 @@ export function handleEvent(event: Types.Events.Event): void {
     eventTimingEndEventsById.set(event.id, event);
   }
 
-  allEvents.push(event);
-
   // From this point on we want to find events that represent interactions.
   // These events are always start events - those are the ones that contain all
   // the metadata about the interaction.
@@ -351,7 +340,6 @@ export async function finalize(): Promise<void> {
 
 export function data(): UserInteractionsData {
   return {
-    allEvents,
     beginCommitCompositorFrameEvents,
     parseMetaViewportEvents,
     interactionEvents,

package/front_end/models/trace/handlers/UserTimingsHandler.ts

@@ -226,9 +226,8 @@ export function data(): UserTimingsData {
     performanceMeasures: syntheticEvents.filter(e => e.cat === 'blink.user_timing') as
         Types.Events.SyntheticUserTimingPair[],
     consoleTimings: syntheticEvents.filter(e => e.cat === 'blink.console') as Types.Events.SyntheticConsoleTimingPair[],
-    // TODO(crbug/41484172): UserTimingsHandler.test.ts fails if this is not copied.
-    performanceMarks: [...performanceMarkEvents],
-    timestampEvents: [...timestampEvents],
-    measureTraceByTraceId: new Map(measureTraceByTraceId),
+    performanceMarks: performanceMarkEvents,
+    timestampEvents,
+    measureTraceByTraceId,
   };
 }

package/front_end/models/trace/insights/CLSCulprits.ts

@@ -471,7 +471,7 @@ function getUnsizedImageRootCauses(
   return rootCausesByShift;
 }
 
-export function isCLSCulprits(insight: InsightModel): insight is CLSCulpritsInsightModel {
+export function isCLSCulpritsInsight(insight: InsightModel): insight is CLSCulpritsInsightModel {
   return insight.insightKey === InsightKeys.CLS_CULPRITS;
 }
 

package/front_end/models/trace/insights/DocumentLatency.ts

@@ -81,7 +81,7 @@ const TARGET_MS = 100;
 // Threshold for compression savings.
 const IGNORE_THRESHOLD_IN_BYTES = 1400;
 
-export function isDocumentLatency(x: InsightModel): x is DocumentLatencyInsightModel {
+export function isDocumentLatencyInsight(x: InsightModel): x is DocumentLatencyInsightModel {
   return x.insightKey === 'DocumentLatency';
 }
 
@@ -190,13 +190,12 @@ function finalize(partialModel: PartialInsightModel<DocumentLatencyInsightModel>
 }
 
 export function generateInsight(
-    data: Handlers.Types.HandlerData, context: InsightSetContext,
-    timeFormatters?: Types.Configuration.InsightTimeFormatters): DocumentLatencyInsightModel {
+    data: Handlers.Types.HandlerData, context: InsightSetContext): DocumentLatencyInsightModel {
   if (!context.navigation) {
     return finalize({});
   }
 
-  const millisToString = timeFormatters?.milli ?? i18n.TimeUtilities.millisToString;
+  const millisToString = context.options.insightTimeFormatters?.milli ?? i18n.TimeUtilities.millisToString;
 
   const documentRequest = data.NetworkRequests.byId.get(context.navigationId);
   if (!documentRequest) {

package/front_end/models/trace/insights/DuplicatedJavaScript.ts

@@ -60,7 +60,7 @@ function finalize(partialModel: PartialInsightModel<DuplicatedJavaScriptInsightM
   };
 }
 
-export function isDuplicatedJavaScript(model: InsightModel): model is DuplicatedJavaScriptInsightModel {
+export function isDuplicatedJavaScriptInsight(model: InsightModel): model is DuplicatedJavaScriptInsightModel {
   return model.insightKey === InsightKeys.DUPLICATE_JAVASCRIPT;
 }
 

package/front_end/models/trace/insights/INPBreakdown.ts

@@ -62,7 +62,7 @@ export type INPBreakdownInsightModel = InsightModel<typeof UIStrings, {
   highPercentileInteractionEvent?: SyntheticInteractionPair,
 }>;
 
-export function isINPBreakdown(insight: InsightModel): insight is INPBreakdownInsightModel {
+export function isINPBreakdownInsight(insight: InsightModel): insight is INPBreakdownInsightModel {
   return insight.insightKey === InsightKeys.INP_BREAKDOWN;
 }
 

package/front_end/models/trace/insights/ImageDelivery.ts

@@ -134,7 +134,7 @@ export type ImageDeliveryInsightModel = InsightModel<typeof UIStrings, {
   wastedBytes: number,
 }>;
 
-export function isImageDelivery(model: InsightModel): model is ImageDeliveryInsightModel {
+export function isImageDeliveryInsight(model: InsightModel): model is ImageDeliveryInsightModel {
   return model.insightKey === 'ImageDelivery';
 }
 

package/front_end/models/trace/insights/LCPBreakdown.ts

@@ -89,7 +89,7 @@ interface LCPSubparts {
   renderDelay: Subpart;
 }
 
-export function isLCPBreakdown(model: InsightModel): model is LCPBreakdownInsightModel {
+export function isLCPBreakdownInsight(model: InsightModel): model is LCPBreakdownInsightModel {
   return model.insightKey === 'LCPBreakdown';
 }
 export type LCPBreakdownInsightModel = InsightModel<typeof UIStrings, {

package/front_end/models/trace/insights/LCPDiscovery.ts

@@ -62,7 +62,7 @@ export const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/LCPDiscovery.ts', UIStrings);
 export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export function isLCPDiscovery(model: InsightModel): model is LCPDiscoveryInsightModel {
+export function isLCPDiscoveryInsight(model: InsightModel): model is LCPDiscoveryInsightModel {
   return model.insightKey === 'LCPDiscovery';
 }
 export type LCPDiscoveryInsightModel = InsightModel<typeof UIStrings, {

package/front_end/models/trace/insights/ModernHTTP.ts

@@ -50,7 +50,7 @@ export type ModernHTTPInsightModel = InsightModel<typeof UIStrings, {
   http1Requests: Types.Events.SyntheticNetworkRequest[],
 }>;
 
-export function isModernHTTP(model: InsightModel): model is ModernHTTPInsightModel {
+export function isModernHTTPInsight(model: InsightModel): model is ModernHTTPInsightModel {
   return model.insightKey === InsightKeys.MODERN_HTTP;
 }
 

package/front_end/models/trace/insights/NetworkDependencyTree.ts

@@ -666,7 +666,7 @@ export function generatePreconnectCandidates(
   return preconnectCandidates.slice(0, TOO_MANY_PRECONNECTS_THRESHOLD);
 }
 
-export function isNetworkDependencyTree(model: InsightModel): model is NetworkDependencyTreeInsightModel {
+export function isNetworkDependencyTreeInsight(model: InsightModel): model is NetworkDependencyTreeInsightModel {
   return model.insightKey === InsightKeys.NETWORK_DEPENDENCY_TREE;
 }
 

package/front_end/models/trace/insights/RenderBlocking.ts

@@ -48,7 +48,7 @@ export const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/RenderBlocking.ts', UIStrings);
 export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export function isRenderBlocking(insight: InsightModel): insight is RenderBlockingInsightModel {
+export function isRenderBlockingInsight(insight: InsightModel): insight is RenderBlockingInsightModel {
   return insight.insightKey === 'RenderBlocking';
 }
 

package/front_end/models/trace/insights/types.ts

@@ -14,12 +14,14 @@ import type * as Models from './Models.js';
 export type InsightSetContext = InsightSetContextWithoutNavigation|InsightSetContextWithNavigation;
 
 export interface InsightSetContextWithoutNavigation {
+  options: Types.Configuration.ParseOptions;
   bounds: Types.Timing.TraceWindowMicro;
   frameId: string;
   navigation?: never;
 }
 
 export interface InsightSetContextWithNavigation {
+  options: Types.Configuration.ParseOptions;
   bounds: Types.Timing.TraceWindowMicro;
   frameId: string;
   navigation: Types.Events.NavigationStart;

package/front_end/models/trace/types/TraceEvents.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import type * as Platform from '../../../core/platform/platform.js';
+import type * as SDK from '../../../core/sdk/sdk.js';
 import type * as Protocol from '../../../generated/protocol.js';
 
 import type {Micro, Milli, Seconds, TraceWindowMicro} from './Timing.js';
@@ -207,7 +208,7 @@ export interface RunTask extends Complete {
   name: Name.RUN_TASK;
 }
 export function isRunTask(event: Event): event is RunTask {
-  return event.name === Name.RUN_TASK;
+  return event.name === Name.RUN_TASK && event.ph === Phase.COMPLETE;
 }
 
 export interface FireIdleCallback extends Complete {
@@ -2072,7 +2073,7 @@ export function isEnd(event: Event): event is End {
 }
 
 export function isDispatch(event: Event): event is Dispatch {
-  return event.name === 'EventDispatch';
+  return event.name === 'EventDispatch' && event.ph === Phase.COMPLETE;
 }
 
 export function isInstant(event: Event): event is Instant {
@@ -2084,7 +2085,7 @@ export function isRendererEvent(event: Event): event is RendererEvent {
 }
 
 export function isFireIdleCallback(event: Event): event is FireIdleCallback {
-  return event.name === 'FireIdleCallback';
+  return event.name === 'FireIdleCallback' && event.ph === Phase.COMPLETE;
 }
 
 export function isSchedulePostMessage(event: Event): event is SchedulePostMessage {
@@ -2092,7 +2093,7 @@ export function isSchedulePostMessage(event: Event): event is SchedulePostMessag
 }
 
 export function isHandlePostMessage(event: Event): event is HandlePostMessage {
-  return event.name === Name.HANDLE_POST_MESSAGE;
+  return event.name === Name.HANDLE_POST_MESSAGE && event.ph === Phase.COMPLETE;
 }
 
 export function isUpdateCounters(event: Event): event is UpdateCounters {
@@ -2213,7 +2214,7 @@ export function isProfile(event: Event): event is Profile {
 }
 
 export function isSyntheticCpuProfile(event: Event): event is SyntheticCpuProfile {
-  return event.name === Name.CPU_PROFILE;
+  return event.name === Name.CPU_PROFILE && event.ph === Phase.COMPLETE;
 }
 
 export function isProfileChunk(event: Event): event is ProfileChunk {
@@ -2308,7 +2309,7 @@ export interface DidCommitSameDocumentNavigation extends Complete {
 }
 
 export function isDidCommitSameDocumentNavigation(event: Event): event is DidCommitSameDocumentNavigation {
-  return event.name === 'RenderFrameHostImpl::DidCommitSameDocumentNavigation';
+  return event.name === 'RenderFrameHostImpl::DidCommitSameDocumentNavigation' && event.ph === Phase.COMPLETE;
 }
 
 export function isMainFrameViewport(
@@ -2400,7 +2401,7 @@ export function isProfileCall(event: Event): event is SyntheticProfileCall {
   return 'callFrame' in event;
 }
 
-export interface Paint extends Complete {
+export interface Paint extends Event {
   name: Name.PAINT;
   args: Args&{
     data: ArgsData & {
@@ -2444,7 +2445,7 @@ export interface PaintImage extends Complete {
   };
 }
 export function isPaintImage(event: Event): event is PaintImage {
-  return event.name === Name.PAINT_IMAGE;
+  return event.name === Name.PAINT_IMAGE && event.ph === Phase.COMPLETE;
 }
 
 export interface ScrollLayer extends Complete {
@@ -2457,7 +2458,7 @@ export interface ScrollLayer extends Complete {
   };
 }
 export function isScrollLayer(event: Event): event is ScrollLayer {
-  return event.name === Name.SCROLL_LAYER;
+  return event.name === Name.SCROLL_LAYER && event.ph === Phase.COMPLETE;
 }
 
 export interface SetLayerTreeId extends Instant {
@@ -2472,7 +2473,7 @@ export interface SetLayerTreeId extends Instant {
 export function isSetLayerId(event: Event): event is SetLayerTreeId {
   return event.name === Name.SET_LAYER_TREE_ID;
 }
-export interface UpdateLayer extends Complete {
+export interface UpdateLayer extends Event {
   name: Name.UPDATE_LAYER;
   args: Args&{
     layerId: number,
@@ -2571,7 +2572,7 @@ export interface FireAnimationFrame extends Complete {
 }
 
 export function isFireAnimationFrame(event: Event): event is FireAnimationFrame {
-  return event.name === Name.FIRE_ANIMATION_FRAME;
+  return event.name === Name.FIRE_ANIMATION_FRAME && event.ph === Phase.COMPLETE;
 }
 
 export interface RequestAnimationFrame extends Instant {
@@ -2611,7 +2612,7 @@ export interface TimerFire extends Complete {
   };
 }
 export function isTimerFire(event: Event): event is TimerFire {
-  return event.name === Name.TIMER_FIRE;
+  return event.name === Name.TIMER_FIRE && event.ph === Phase.COMPLETE;
 }
 
 export interface RequestIdleCallback extends Instant {
@@ -2773,7 +2774,7 @@ export interface V8Compile extends Complete {
   };
 }
 export function isV8Compile(event: Event): event is V8Compile {
-  return event.name === Name.COMPILE;
+  return event.name === Name.COMPILE && event.ph === Phase.COMPLETE;
 }
 
 export interface FunctionCall extends Complete {
@@ -2781,11 +2782,12 @@ export interface FunctionCall extends Complete {
   args: Args&{
     data?: Partial<CallFrame>& {
       frame?: string,
+      isolate?: number,
     },
   };
 }
 export function isFunctionCall(event: Event): event is FunctionCall {
-  return event.name === Name.FUNCTION_CALL;
+  return event.name === Name.FUNCTION_CALL && event.ph === Phase.COMPLETE;
 }
 
 export interface SchedulePostTaskCallback extends Instant {
@@ -2816,7 +2818,7 @@ export interface RunPostTaskCallback extends Complete {
   };
 }
 export function isRunPostTaskCallback(event: Event): event is RunPostTaskCallback {
-  return event.name === Name.RUN_POST_TASK_CALLBACK;
+  return event.name === Name.RUN_POST_TASK_CALLBACK && event.ph === Phase.COMPLETE;
 }
 
 export interface AbortPostTaskCallback extends Complete {
@@ -2830,7 +2832,7 @@ export interface AbortPostTaskCallback extends Complete {
   };
 }
 export function isAbortPostTaskCallback(event: Event): event is RunPostTaskCallback {
-  return event.name === Name.ABORT_POST_TASK_CALLBACK;
+  return event.name === Name.ABORT_POST_TASK_CALLBACK && event.ph === Phase.COMPLETE;
 }
 
 /**
@@ -2894,7 +2896,7 @@ export interface ParseAuthorStyleSheet extends Complete {
 }
 
 export function isParseAuthorStyleSheetEvent(event: Event): event is ParseAuthorStyleSheet {
-  return event.name === Name.PARSE_AUTHOR_STYLE_SHEET;
+  return event.name === Name.PARSE_AUTHOR_STYLE_SHEET && event.ph === Phase.COMPLETE;
 }
 
 /**
@@ -3177,75 +3179,51 @@ export interface LegacyLayerPaintEventPicture {
   serializedPicture: string;
 }
 
-export interface TargetRundownEvent extends Event {
+/** Same as `TraceEventTargetRundown` in `EnhancedTracesParser` */
+export interface RundownScriptCompiled extends Event {
   cat: 'disabled-by-default-devtools.target-rundown';
-  name: 'ScriptCompiled';
+  name: SDK.EnhancedTracesParser.RundownScriptCompiled['name'];
   args: Args&{
-    data?: {
-      frame: Protocol.Page.FrameId,
-      frameType: string,
-      url: string,
-      isolate: string,
-      v8context: string,
-      origin: string,
-      scriptId: number,
-      isDefault?: boolean,
-      contextType?: string,
-    },
+    data?: SDK.EnhancedTracesParser.RundownScriptCompiled['args']['data'],
   };
 }
 
-export function isTargetRundownEvent(event: Event): event is TargetRundownEvent {
-  return event.cat === 'disabled-by-default-devtools.target-rundown' && event.name === 'ScriptCompiled';
+export function isRundownScriptCompiled(event: Event): event is RundownScriptCompiled {
+  return event.cat === 'disabled-by-default-devtools.target-rundown';
 }
 
-export interface V8SourceRundownEvent extends Event {
+/** Same as `TraceEventScriptRundown` in `EnhancedTracesParser` */
+export interface RundownScript extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown';
-  name: 'ScriptCatchup';
+  name: SDK.EnhancedTracesParser.RundownScript['name'];
   args: Args&{
-    data: {
-      isolate: string,
-      executionContextId: Protocol.Runtime.ExecutionContextId,
-      scriptId: number,
-      hash: string,
-      isModule: boolean,
-      hasSourceUrl: boolean,
-      url?: string,
-      sourceUrl?: string,
-      sourceMapUrl?: string,
-      sourceMapUrlElided?: boolean,
-    },
+    data: SDK.EnhancedTracesParser.RundownScript['args']['data'],
   };
 }
 
-export function isV8SourceRundownEvent(event: Event): event is V8SourceRundownEvent {
+export function isRundownScript(event: Event): event is RundownScript {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown' && event.name === 'ScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesScriptCatchupEvent extends Event {
+/** Same as `TraceEventScriptRundownSource` in `EnhancedTracesParser` */
+export interface RundownScriptSource extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'ScriptCatchup';
   args: Args&{
-    data: {
-      isolate: string,
-      scriptId: number,
-      length: number,
-      sourceText: string,
-    },
+    data: SDK.EnhancedTracesParser.RundownScriptSource['args']['data'],
   };
 }
 
-export function isV8SourceRundownSourcesScriptCatchupEvent(event: Event):
-    event is V8SourceRundownSourcesScriptCatchupEvent {
+export function isRundownScriptSource(event: Event): event is RundownScriptSource {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources' && event.name === 'ScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesLargeScriptCatchupEvent extends Event {
+export interface RundownScriptSourceLarge extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'LargeScriptCatchup';
   args: Args&{
     data: {
-      isolate: string,
+      isolate: number,
       scriptId: number,
       splitIndex: number,
       splitCount: number,
@@ -3254,23 +3232,22 @@ export interface V8SourceRundownSourcesLargeScriptCatchupEvent extends Event {
   };
 }
 
-export function isV8SourceRundownSourcesLargeScriptCatchupEvent(event: Event):
-    event is V8SourceRundownSourcesLargeScriptCatchupEvent {
+export function isRundownScriptSourceLarge(event: Event): event is RundownScriptSourceLarge {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources' && event.name === 'LargeScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesStubScriptCatchupEvent extends Event {
+export interface RundownScriptStub extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'StubScriptCatchup';
   args: Args&{
     data: {
-      isolate: string,
+      isolate: number,
       scriptId: number,
     },
   };
 }
 
-export function isAnyScriptCatchupEvent(event: Event): event is V8SourceRundownSourcesScriptCatchupEvent|
-    V8SourceRundownSourcesLargeScriptCatchupEvent|V8SourceRundownSourcesStubScriptCatchupEvent {
+export function isAnyScriptSourceEvent(event: Event): event is RundownScriptSource|RundownScriptSourceLarge|
+    RundownScriptStub {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources';
 }

package/front_end/models/trace_source_maps_resolver/trace_source_maps_resolver.ts

@@ -1,4 +1,4 @@
-// Copyright 2025 The Chromium Authors. All rights reserved.
+// Copyright 2025 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.