chrome-devtools-frontend 1.0.1515446 → 1.0.1515988

package/front_end/models/trace/insights/LCPDiscovery.ts

@@ -62,7 +62,7 @@ export const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/LCPDiscovery.ts', UIStrings);
 export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export function isLCPDiscovery(model: InsightModel): model is LCPDiscoveryInsightModel {
+export function isLCPDiscoveryInsight(model: InsightModel): model is LCPDiscoveryInsightModel {
   return model.insightKey === 'LCPDiscovery';
 }
 export type LCPDiscoveryInsightModel = InsightModel<typeof UIStrings, {

package/front_end/models/trace/insights/ModernHTTP.ts

@@ -50,7 +50,7 @@ export type ModernHTTPInsightModel = InsightModel<typeof UIStrings, {
   http1Requests: Types.Events.SyntheticNetworkRequest[],
 }>;
 
-export function isModernHTTP(model: InsightModel): model is ModernHTTPInsightModel {
+export function isModernHTTPInsight(model: InsightModel): model is ModernHTTPInsightModel {
   return model.insightKey === InsightKeys.MODERN_HTTP;
 }
 

package/front_end/models/trace/insights/NetworkDependencyTree.ts

@@ -666,7 +666,7 @@ export function generatePreconnectCandidates(
   return preconnectCandidates.slice(0, TOO_MANY_PRECONNECTS_THRESHOLD);
 }
 
-export function isNetworkDependencyTree(model: InsightModel): model is NetworkDependencyTreeInsightModel {
+export function isNetworkDependencyTreeInsight(model: InsightModel): model is NetworkDependencyTreeInsightModel {
   return model.insightKey === InsightKeys.NETWORK_DEPENDENCY_TREE;
 }
 

package/front_end/models/trace/insights/RenderBlocking.ts

@@ -48,7 +48,7 @@ export const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/RenderBlocking.ts', UIStrings);
 export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
-export function isRenderBlocking(insight: InsightModel): insight is RenderBlockingInsightModel {
+export function isRenderBlockingInsight(insight: InsightModel): insight is RenderBlockingInsightModel {
   return insight.insightKey === 'RenderBlocking';
 }
 

package/front_end/models/trace/insights/types.ts

@@ -14,12 +14,14 @@ import type * as Models from './Models.js';
 export type InsightSetContext = InsightSetContextWithoutNavigation|InsightSetContextWithNavigation;
 
 export interface InsightSetContextWithoutNavigation {
+  options: Types.Configuration.ParseOptions;
   bounds: Types.Timing.TraceWindowMicro;
   frameId: string;
   navigation?: never;
 }
 
 export interface InsightSetContextWithNavigation {
+  options: Types.Configuration.ParseOptions;
   bounds: Types.Timing.TraceWindowMicro;
   frameId: string;
   navigation: Types.Events.NavigationStart;

package/front_end/models/trace/types/Configuration.ts

@@ -8,6 +8,7 @@ import type * as Protocol from '../../../generated/protocol.js';
 import type * as Lantern from '../lantern/lantern.js';
 
 import type * as File from './File.js';
+import type {Milli} from './Timing.js';
 
 export interface Configuration {
   /**
@@ -83,6 +84,17 @@ export interface ParseOptions {
     end: (id: string) => void,
   };
   lanternSettings?: Omit<Lantern.Types.Simulation.Settings, 'networkAnalysis'>;
+  /**
+   * Used when an Insight needs to format a time to string as part of its
+   * output. By default we use the i18n.TimeUtilities in DevTools but this
+   * enables it to be overridden, which is useful if you are consuming the trace
+   * engine outside of DevTools.
+   */
+  insightTimeFormatters?: InsightTimeFormatters;
+}
+
+export interface InsightTimeFormatters {
+  milli: (x: Milli) => string;
 }
 
 export interface ResolveSourceMapParams {

package/front_end/models/trace/types/TraceEvents.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import type * as Platform from '../../../core/platform/platform.js';
+import type * as SDK from '../../../core/sdk/sdk.js';
 import type * as Protocol from '../../../generated/protocol.js';
 
 import type {Micro, Milli, Seconds, TraceWindowMicro} from './Timing.js';
@@ -207,7 +208,7 @@ export interface RunTask extends Complete {
   name: Name.RUN_TASK;
 }
 export function isRunTask(event: Event): event is RunTask {
-  return event.name === Name.RUN_TASK;
+  return event.name === Name.RUN_TASK && event.ph === Phase.COMPLETE;
 }
 
 export interface FireIdleCallback extends Complete {
@@ -2072,7 +2073,7 @@ export function isEnd(event: Event): event is End {
 }
 
 export function isDispatch(event: Event): event is Dispatch {
-  return event.name === 'EventDispatch';
+  return event.name === 'EventDispatch' && event.ph === Phase.COMPLETE;
 }
 
 export function isInstant(event: Event): event is Instant {
@@ -2084,7 +2085,7 @@ export function isRendererEvent(event: Event): event is RendererEvent {
 }
 
 export function isFireIdleCallback(event: Event): event is FireIdleCallback {
-  return event.name === 'FireIdleCallback';
+  return event.name === 'FireIdleCallback' && event.ph === Phase.COMPLETE;
 }
 
 export function isSchedulePostMessage(event: Event): event is SchedulePostMessage {
@@ -2092,7 +2093,7 @@ export function isSchedulePostMessage(event: Event): event is SchedulePostMessag
 }
 
 export function isHandlePostMessage(event: Event): event is HandlePostMessage {
-  return event.name === Name.HANDLE_POST_MESSAGE;
+  return event.name === Name.HANDLE_POST_MESSAGE && event.ph === Phase.COMPLETE;
 }
 
 export function isUpdateCounters(event: Event): event is UpdateCounters {
@@ -2213,7 +2214,7 @@ export function isProfile(event: Event): event is Profile {
 }
 
 export function isSyntheticCpuProfile(event: Event): event is SyntheticCpuProfile {
-  return event.name === Name.CPU_PROFILE;
+  return event.name === Name.CPU_PROFILE && event.ph === Phase.COMPLETE;
 }
 
 export function isProfileChunk(event: Event): event is ProfileChunk {
@@ -2308,7 +2309,7 @@ export interface DidCommitSameDocumentNavigation extends Complete {
 }
 
 export function isDidCommitSameDocumentNavigation(event: Event): event is DidCommitSameDocumentNavigation {
-  return event.name === 'RenderFrameHostImpl::DidCommitSameDocumentNavigation';
+  return event.name === 'RenderFrameHostImpl::DidCommitSameDocumentNavigation' && event.ph === Phase.COMPLETE;
 }
 
 export function isMainFrameViewport(
@@ -2400,7 +2401,7 @@ export function isProfileCall(event: Event): event is SyntheticProfileCall {
   return 'callFrame' in event;
 }
 
-export interface Paint extends Complete {
+export interface Paint extends Event {
   name: Name.PAINT;
   args: Args&{
     data: ArgsData & {
@@ -2444,7 +2445,7 @@ export interface PaintImage extends Complete {
   };
 }
 export function isPaintImage(event: Event): event is PaintImage {
-  return event.name === Name.PAINT_IMAGE;
+  return event.name === Name.PAINT_IMAGE && event.ph === Phase.COMPLETE;
 }
 
 export interface ScrollLayer extends Complete {
@@ -2457,7 +2458,7 @@ export interface ScrollLayer extends Complete {
   };
 }
 export function isScrollLayer(event: Event): event is ScrollLayer {
-  return event.name === Name.SCROLL_LAYER;
+  return event.name === Name.SCROLL_LAYER && event.ph === Phase.COMPLETE;
 }
 
 export interface SetLayerTreeId extends Instant {
@@ -2472,7 +2473,7 @@ export interface SetLayerTreeId extends Instant {
 export function isSetLayerId(event: Event): event is SetLayerTreeId {
   return event.name === Name.SET_LAYER_TREE_ID;
 }
-export interface UpdateLayer extends Complete {
+export interface UpdateLayer extends Event {
   name: Name.UPDATE_LAYER;
   args: Args&{
     layerId: number,
@@ -2571,7 +2572,7 @@ export interface FireAnimationFrame extends Complete {
 }
 
 export function isFireAnimationFrame(event: Event): event is FireAnimationFrame {
-  return event.name === Name.FIRE_ANIMATION_FRAME;
+  return event.name === Name.FIRE_ANIMATION_FRAME && event.ph === Phase.COMPLETE;
 }
 
 export interface RequestAnimationFrame extends Instant {
@@ -2611,7 +2612,7 @@ export interface TimerFire extends Complete {
   };
 }
 export function isTimerFire(event: Event): event is TimerFire {
-  return event.name === Name.TIMER_FIRE;
+  return event.name === Name.TIMER_FIRE && event.ph === Phase.COMPLETE;
 }
 
 export interface RequestIdleCallback extends Instant {
@@ -2773,7 +2774,7 @@ export interface V8Compile extends Complete {
   };
 }
 export function isV8Compile(event: Event): event is V8Compile {
-  return event.name === Name.COMPILE;
+  return event.name === Name.COMPILE && event.ph === Phase.COMPLETE;
 }
 
 export interface FunctionCall extends Complete {
@@ -2781,11 +2782,12 @@ export interface FunctionCall extends Complete {
   args: Args&{
     data?: Partial<CallFrame>& {
       frame?: string,
+      isolate?: number,
     },
   };
 }
 export function isFunctionCall(event: Event): event is FunctionCall {
-  return event.name === Name.FUNCTION_CALL;
+  return event.name === Name.FUNCTION_CALL && event.ph === Phase.COMPLETE;
 }
 
 export interface SchedulePostTaskCallback extends Instant {
@@ -2816,7 +2818,7 @@ export interface RunPostTaskCallback extends Complete {
   };
 }
 export function isRunPostTaskCallback(event: Event): event is RunPostTaskCallback {
-  return event.name === Name.RUN_POST_TASK_CALLBACK;
+  return event.name === Name.RUN_POST_TASK_CALLBACK && event.ph === Phase.COMPLETE;
 }
 
 export interface AbortPostTaskCallback extends Complete {
@@ -2830,7 +2832,7 @@ export interface AbortPostTaskCallback extends Complete {
   };
 }
 export function isAbortPostTaskCallback(event: Event): event is RunPostTaskCallback {
-  return event.name === Name.ABORT_POST_TASK_CALLBACK;
+  return event.name === Name.ABORT_POST_TASK_CALLBACK && event.ph === Phase.COMPLETE;
 }
 
 /**
@@ -2894,7 +2896,7 @@ export interface ParseAuthorStyleSheet extends Complete {
 }
 
 export function isParseAuthorStyleSheetEvent(event: Event): event is ParseAuthorStyleSheet {
-  return event.name === Name.PARSE_AUTHOR_STYLE_SHEET;
+  return event.name === Name.PARSE_AUTHOR_STYLE_SHEET && event.ph === Phase.COMPLETE;
 }
 
 /**
@@ -3177,75 +3179,51 @@ export interface LegacyLayerPaintEventPicture {
   serializedPicture: string;
 }
 
-export interface TargetRundownEvent extends Event {
+/** Same as `TraceEventTargetRundown` in `EnhancedTracesParser` */
+export interface RundownScriptCompiled extends Event {
   cat: 'disabled-by-default-devtools.target-rundown';
-  name: 'ScriptCompiled';
+  name: SDK.EnhancedTracesParser.RundownScriptCompiled['name'];
   args: Args&{
-    data?: {
-      frame: Protocol.Page.FrameId,
-      frameType: string,
-      url: string,
-      isolate: string,
-      v8context: string,
-      origin: string,
-      scriptId: number,
-      isDefault?: boolean,
-      contextType?: string,
-    },
+    data?: SDK.EnhancedTracesParser.RundownScriptCompiled['args']['data'],
   };
 }
 
-export function isTargetRundownEvent(event: Event): event is TargetRundownEvent {
-  return event.cat === 'disabled-by-default-devtools.target-rundown' && event.name === 'ScriptCompiled';
+export function isRundownScriptCompiled(event: Event): event is RundownScriptCompiled {
+  return event.cat === 'disabled-by-default-devtools.target-rundown';
 }
 
-export interface V8SourceRundownEvent extends Event {
+/** Same as `TraceEventScriptRundown` in `EnhancedTracesParser` */
+export interface RundownScript extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown';
-  name: 'ScriptCatchup';
+  name: SDK.EnhancedTracesParser.RundownScript['name'];
   args: Args&{
-    data: {
-      isolate: string,
-      executionContextId: Protocol.Runtime.ExecutionContextId,
-      scriptId: number,
-      hash: string,
-      isModule: boolean,
-      hasSourceUrl: boolean,
-      url?: string,
-      sourceUrl?: string,
-      sourceMapUrl?: string,
-      sourceMapUrlElided?: boolean,
-    },
+    data: SDK.EnhancedTracesParser.RundownScript['args']['data'],
   };
 }
 
-export function isV8SourceRundownEvent(event: Event): event is V8SourceRundownEvent {
+export function isRundownScript(event: Event): event is RundownScript {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown' && event.name === 'ScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesScriptCatchupEvent extends Event {
+/** Same as `TraceEventScriptRundownSource` in `EnhancedTracesParser` */
+export interface RundownScriptSource extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'ScriptCatchup';
   args: Args&{
-    data: {
-      isolate: string,
-      scriptId: number,
-      length: number,
-      sourceText: string,
-    },
+    data: SDK.EnhancedTracesParser.RundownScriptSource['args']['data'],
   };
 }
 
-export function isV8SourceRundownSourcesScriptCatchupEvent(event: Event):
-    event is V8SourceRundownSourcesScriptCatchupEvent {
+export function isRundownScriptSource(event: Event): event is RundownScriptSource {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources' && event.name === 'ScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesLargeScriptCatchupEvent extends Event {
+export interface RundownScriptSourceLarge extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'LargeScriptCatchup';
   args: Args&{
     data: {
-      isolate: string,
+      isolate: number,
       scriptId: number,
       splitIndex: number,
       splitCount: number,
@@ -3254,23 +3232,22 @@ export interface V8SourceRundownSourcesLargeScriptCatchupEvent extends Event {
   };
 }
 
-export function isV8SourceRundownSourcesLargeScriptCatchupEvent(event: Event):
-    event is V8SourceRundownSourcesLargeScriptCatchupEvent {
+export function isRundownScriptSourceLarge(event: Event): event is RundownScriptSourceLarge {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources' && event.name === 'LargeScriptCatchup';
 }
 
-export interface V8SourceRundownSourcesStubScriptCatchupEvent extends Event {
+export interface RundownScriptStub extends Event {
   cat: 'disabled-by-default-devtools.v8-source-rundown-sources';
   name: 'StubScriptCatchup';
   args: Args&{
     data: {
-      isolate: string,
+      isolate: number,
       scriptId: number,
     },
   };
 }
 
-export function isAnyScriptCatchupEvent(event: Event): event is V8SourceRundownSourcesScriptCatchupEvent|
-    V8SourceRundownSourcesLargeScriptCatchupEvent|V8SourceRundownSourcesStubScriptCatchupEvent {
+export function isAnyScriptSourceEvent(event: Event): event is RundownScriptSource|RundownScriptSourceLarge|
+    RundownScriptStub {
   return event.cat === 'disabled-by-default-devtools.v8-source-rundown-sources';
 }

package/front_end/models/trace_source_maps_resolver/trace_source_maps_resolver.ts

@@ -1,4 +1,4 @@
-// Copyright 2025 The Chromium Authors. All rights reserved.
+// Copyright 2025 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -132,10 +132,6 @@ const UIStringsNotTranslate = {
    * @description Placeholder text for the chat UI input.
    */
   inputPlaceholderForFile: 'Ask a question about the selected file',
-  /**
-   * @description Placeholder text for the chat UI input.
-   */
-  inputPlaceholderForPerformance: 'Ask a question about the selected item and its call tree',
   /**
    * @description Placeholder text for the chat UI input.
    */
@@ -152,18 +148,6 @@ const UIStringsNotTranslate = {
    * @description Placeholder text for the chat UI input when there is no context selected.
    */
   inputPlaceholderForFileNoContext: 'Select a file to ask a question',
-  /**
-   * @description Placeholder text for the chat UI input when there is no context selected.
-   */
-  inputPlaceholderForPerformanceNoContext: 'Select an item to ask a question',
-  /**
-   * @description Placeholder text for the chat UI input.
-   */
-  inputPlaceholderForPerformanceInsights: 'Ask a question about the selected performance insight',
-  /**
-   * @description Placeholder text for the chat UI input.
-   */
-  inputPlaceholderForPerformanceInsightsNoContext: 'Select a performance insight to ask a question',
   /**
    * @description Placeholder text for the chat UI input.
    */
@@ -171,7 +155,7 @@ const UIStringsNotTranslate = {
   /**
    *@description Placeholder text for the chat UI input.
    */
-  inputPlaceholderForPerformanceTraceNoContext: 'Select a performance trace to ask a question',
+  inputPlaceholderForPerformanceTraceNoContext: 'Record or select a performance trace to ask a question',
   /**
    * @description Disclaimer text right after the chat input.
    */
@@ -236,7 +220,7 @@ function selectedElementFilter(maybeNode: SDK.DOMModel.DOMNode|null): SDK.DOMMod
 
 async function getEmptyStateSuggestions(
     context: AiAssistanceModel.ConversationContext<unknown>|null,
-    conversationType?: AiAssistanceModel.ConversationType): Promise<AiAssistanceModel.ConversationSuggestion[]> {
+    conversation?: AiAssistanceModel.Conversation): Promise<AiAssistanceModel.ConversationSuggestion[]> {
   if (context) {
     const specialSuggestions = await context.getSuggestions();
 
@@ -245,11 +229,11 @@ async function getEmptyStateSuggestions(
     }
   }
 
-  if (!conversationType) {
+  if (!conversation?.type || conversation.isReadOnly) {
     return [];
   }
 
-  switch (conversationType) {
+  switch (conversation.type) {
     case AiAssistanceModel.ConversationType.STYLING:
       return [
         {title: 'What can you help me with?', jslogContext: 'styling-default'},
@@ -268,28 +252,14 @@ async function getEmptyStateSuggestions(
         {title: 'Are there any security headers present?', jslogContext: 'network-default'},
         {title: 'Why is the request failing?', jslogContext: 'network-default'},
       ];
-    case AiAssistanceModel.ConversationType.PERFORMANCE_FULL:
+    case AiAssistanceModel.ConversationType.PERFORMANCE: {
       return [
         {title: 'What performance issues exist with my page?', jslogContext: 'performance-default'},
       ];
-    case AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT:
-    case AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE: {
-      const focus = context?.getItem() as AiAssistanceModel.AgentFocus | null;
-      if (focus?.data.type === 'call-tree') {
-        return [
-          {title: 'What\'s the purpose of this work?', jslogContext: 'performance-default'},
-          {title: 'Where is time being spent?', jslogContext: 'performance-default'},
-          {title: 'How can I optimize this?', jslogContext: 'performance-default'},
-        ];
-      }
-
-      return [
-        {title: 'Help me optimize my page load performance', jslogContext: 'performance-insights-default'},
-      ];
     }
 
     default:
-      Platform.assertNever(conversationType, 'Unknown conversation type');
+      Platform.assertNever(conversation.type, 'Unknown conversation type');
   }
 }
 
@@ -619,15 +589,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     const isSourcesPanelVisible = viewManager.isViewVisible('sources');
     const isPerformancePanelVisible = viewManager.isViewVisible('timeline');
 
-    // Check if the user has an insight expanded in the performance panel sidebar.
-    // If they have, we default to the Insights agent; otherwise we fallback to
-    // the regular Performance agent.
-    // Note that we do not listen to this flavor changing; this code is here to
-    // ensure that by default we do not pick the Insights agent if the user has
-    // just imported a trace and not done anything else. It doesn't make sense
-    // to select the Insights AI agent in that case.
-    const userHasExpandedPerfInsight =
-        Boolean(UI.Context.Context.instance().flavor(TimelinePanel.TimelinePanel.SelectedInsight));
     let targetConversationType: AiAssistanceModel.ConversationType|undefined = undefined;
     if (isElementsPanelVisible && hostConfig.devToolsFreestyler?.enabled) {
       targetConversationType = AiAssistanceModel.ConversationType.STYLING;
@@ -635,12 +596,8 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       targetConversationType = AiAssistanceModel.ConversationType.NETWORK;
     } else if (isSourcesPanelVisible && hostConfig.devToolsAiAssistanceFileAgent?.enabled) {
       targetConversationType = AiAssistanceModel.ConversationType.FILE;
-    } else if (
-        isPerformancePanelVisible && hostConfig.devToolsAiAssistancePerformanceAgent?.enabled &&
-        hostConfig.devToolsAiAssistancePerformanceAgent?.insightsEnabled && userHasExpandedPerfInsight) {
-      targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT;
     } else if (isPerformancePanelVisible && hostConfig.devToolsAiAssistancePerformanceAgent?.enabled) {
-      targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE;
+      targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE;
     }
 
     if (this.#conversation?.type === targetConversationType) {
@@ -845,25 +802,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         this.#selectedPerformanceTrace =
             Boolean(ev.data) ? new AiAssistanceModel.PerformanceTraceContext(ev.data) : null;
 
-        let conversationType: AiAssistanceModel.ConversationType|undefined;
-        if (ev.data) {
-          if (ev.data.data.type === 'full') {
-            conversationType = AiAssistanceModel.ConversationType.PERFORMANCE_FULL;
-          } else if (ev.data.data.type === 'insight') {
-            conversationType = AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT;
-          } else if (ev.data.data.type === 'call-tree') {
-            conversationType = AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE;
-          } else {
-            Platform.assertNever(ev.data.data, 'Unknown agent focus');
-          }
-        }
-
-        let agent = this.#conversationAgent;
-        if (conversationType && agent instanceof AiAssistanceModel.PerformanceAgent &&
-            agent.getConversationType() !== conversationType) {
-          agent = this.#conversationHandler.createAgent(conversationType);
-        }
-
         this.#updateConversationState({agent: this.#conversationAgent});
       };
 
@@ -898,7 +836,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   override async performUpdate(): Promise<void> {
-    const emptyStateSuggestions = await getEmptyStateSuggestions(this.#selectedContext, this.#conversation?.type);
+    const emptyStateSuggestions = await getEmptyStateSuggestions(this.#selectedContext, this.#conversation);
 
     this.view(
         {
@@ -1039,21 +977,16 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       case AiAssistanceModel.ConversationType.NETWORK:
         return this.#selectedContext ? lockedString(UIStringsNotTranslate.inputPlaceholderForNetwork) :
                                        lockedString(UIStringsNotTranslate.inputPlaceholderForNetworkNoContext);
-      case AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE: {
+      case AiAssistanceModel.ConversationType.PERFORMANCE: {
         const perfPanel = UI.Context.Context.instance().flavor(TimelinePanel.TimelinePanel.TimelinePanel);
         if (perfPanel?.hasActiveTrace()) {
-          return this.#selectedContext ? lockedString(UIStringsNotTranslate.inputPlaceholderForPerformance) :
-                                         lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceNoContext);
+          return this.#selectedContext ?
+              lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceTrace) :
+              lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceTraceNoContext);
         }
+
         return lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceWithNoRecording);
       }
-      case AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT:
-        return this.#selectedContext ?
-            lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceInsights) :
-            lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceInsightsNoContext);
-      case AiAssistanceModel.ConversationType.PERFORMANCE_FULL:
-        return this.#selectedContext ? lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceTrace) :
-                                       lockedString(UIStringsNotTranslate.inputPlaceholderForPerformanceTraceNoContext);
     }
   }
 
@@ -1084,9 +1017,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
       // It is deliberate that both Performance agents use the same disclaimer
       // text and this has been approved by Privacy.
-      case AiAssistanceModel.ConversationType.PERFORMANCE_FULL:
-      case AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE:
-      case AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT:
+      case AiAssistanceModel.ConversationType.PERFORMANCE:
         if (noLogging) {
           return lockedString(UIStringsNotTranslate.inputDisclaimerForPerformanceEnterpriseNoLogging);
         }
@@ -1121,18 +1052,14 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     }
     if (context instanceof AiAssistanceModel.PerformanceTraceContext) {
       const focus = context.getItem().data;
-      if (focus.type === 'full') {
-        return;
-      }
-      if (focus.type === 'call-tree') {
+      if (focus.callTree) {
         const event = focus.callTree.selectedNode?.event ?? focus.callTree.rootNode.event;
         const trace = new SDK.TraceObject.RevealableEvent(event);
         return Common.Revealer.reveal(trace);
       }
-      if (focus.type === 'insight') {
+      if (focus.insight) {
         return Common.Revealer.reveal(focus.insight);
       }
-      Platform.assertNever(focus, 'Unknown agent focus');
     }
     // Node picker is using linkifier.
   }
@@ -1169,17 +1096,17 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       }
       case 'drjones.performance-panel-context': {
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceOpenedFromPerformancePanelCallTree);
-        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE;
+        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE;
         break;
       }
       case 'drjones.performance-insight-context': {
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceOpenedFromPerformanceInsight);
-        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT;
+        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE;
         break;
       }
       case 'drjones.performance-panel-full-context': {
         Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceOpenedFromPerformanceFullButton);
-        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE_FULL;
+        targetConversationType = AiAssistanceModel.ConversationType.PERFORMANCE;
         break;
       }
       case 'drjones.sources-floating-button': {
@@ -1200,10 +1127,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
 
     let agent = this.#conversationAgent;
     if (!this.#conversation || !this.#conversationAgent || this.#conversation.type !== targetConversationType ||
-        this.#conversation?.isEmpty ||
-        targetConversationType === AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE ||
-        (agent instanceof AiAssistanceModel.PerformanceAgent &&
-         agent.getConversationType() !== targetConversationType)) {
+        this.#conversation?.isEmpty) {
       agent = this.#conversationHandler.createAgent(targetConversationType, this.#changeManager);
     }
     this.#updateConversationState({agent});
@@ -1448,9 +1372,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       case AiAssistanceModel.ConversationType.NETWORK:
         context = this.#selectedRequest;
         break;
-      case AiAssistanceModel.ConversationType.PERFORMANCE_FULL:
-      case AiAssistanceModel.ConversationType.PERFORMANCE_CALL_TREE:
-      case AiAssistanceModel.ConversationType.PERFORMANCE_INSIGHT:
+      case AiAssistanceModel.ConversationType.PERFORMANCE:
         context = this.#selectedPerformanceTrace;
         break;
     }

package/front_end/panels/application/ServiceWorkersView.ts

@@ -487,7 +487,6 @@ export class Section {
     this.routerView = new ApplicationComponents.ServiceWorkerRouterView.ServiceWorkerRouterView();
     this.networkRequests = new Buttons.Button.Button();
     this.networkRequests.data = {
-      iconName: 'bottom-panel-open',
       variant: Buttons.Button.Variant.TEXT,
       title: i18nString(UIStrings.networkRequests),
       jslogContext: 'show-network-requests',