chrome-devtools-frontend 1.0.1515446 → 1.0.1515796

package/front_end/third_party/puppeteer/package/src/api/Page.ts

@@ -1655,12 +1655,23 @@ export abstract class Page extends EventEmitter<PageEvents> {
    * @param userAgentData - Specific user agent client hint data to use in this
    * page
    * @returns Promise which resolves when the user agent is set.
+   * @deprecated Use {@link Page.(setUserAgent:2) } instead.
    */
   abstract setUserAgent(
     userAgent: string,
     userAgentMetadata?: Protocol.Emulation.UserAgentMetadata,
   ): Promise<void>;
 
+  /**
+   * @param options - Object containing user agent and optional user agent metadata
+   * @returns Promise which resolves when the user agent is set.
+   */
+  abstract setUserAgent(options: {
+    userAgent?: string;
+    userAgentMetadata?: Protocol.Emulation.UserAgentMetadata;
+    platform?: string;
+  }): Promise<void>;
+
   /**
    * Object containing metrics as key/value pairs.
    *
@@ -2014,7 +2025,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
    *
    * @remarks
    * This method is a shortcut for calling two methods:
-   * {@link Page.setUserAgent} and {@link Page.setViewport}.
+   * {@link Page.(setUserAgent:2) } and {@link Page.setViewport}.
    *
    * This method will resize the page. A lot of websites don't expect phones to
    * change size, so you should emulate before navigating to the page.
@@ -2037,7 +2048,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
    */
   async emulate(device: Device): Promise<void> {
     await Promise.all([
-      this.setUserAgent(device.userAgent),
+      this.setUserAgent({userAgent: device.userAgent}),
       this.setViewport(device.viewport),
     ]);
   }

package/front_end/third_party/puppeteer/package/src/bidi/Page.ts

@@ -141,20 +141,45 @@ export class BidiPage extends Page {
   #userAgentInterception?: string;
   #userAgentPreloadScript?: string;
   override async setUserAgent(
-    userAgent: string,
+    userAgentOrOptions:
+      | string
+      | {
+          userAgent?: string;
+          userAgentMetadata?: Protocol.Emulation.UserAgentMetadata;
+          platform?: string;
+        },
     userAgentMetadata?: Protocol.Emulation.UserAgentMetadata,
   ): Promise<void> {
-    if (!this.#browserContext.browser().cdpSupported && userAgentMetadata) {
+    let userAgent: string;
+    let metadata: Protocol.Emulation.UserAgentMetadata | undefined;
+    let platform: string | undefined;
+
+    if (typeof userAgentOrOptions === 'string') {
+      userAgent = userAgentOrOptions;
+      metadata = userAgentMetadata;
+    } else {
+      userAgent =
+        userAgentOrOptions.userAgent ??
+        (await this.#browserContext.browser().userAgent());
+      metadata = userAgentOrOptions.userAgentMetadata;
+      platform = userAgentOrOptions.platform;
+    }
+
+    if (
+      !this.#browserContext.browser().cdpSupported &&
+      (metadata || platform)
+    ) {
       throw new UnsupportedOperation(
-        'Current Browser does not support `userAgentMetadata`',
+        'Current Browser does not support `userAgentMetadata` or `platform`',
       );
     } else if (
       this.#browserContext.browser().cdpSupported &&
-      userAgentMetadata
+      (metadata || platform)
     ) {
       return await this._client().send('Network.setUserAgentOverride', {
         userAgent: userAgent,
-        userAgentMetadata: userAgentMetadata,
+        userAgentMetadata: metadata,
+        platform: platform,
       });
     }
     const enable = userAgent !== '';
@@ -172,11 +197,20 @@ export class BidiPage extends Page {
       enable,
     );
 
-    const changeUserAgent = (userAgent: string) => {
+    const overrideNavigatorProperties = (
+      userAgent: string,
+      platform: string | undefined,
+    ) => {
       Object.defineProperty(navigator, 'userAgent', {
         value: userAgent,
         configurable: true,
       });
+      if (platform) {
+        Object.defineProperty(navigator, 'platform', {
+          value: platform,
+          configurable: true,
+        });
+      }
     };
 
     const frames = [this.#frame];
@@ -191,12 +225,20 @@ export class BidiPage extends Page {
     }
     const [evaluateToken] = await Promise.all([
       enable
-        ? this.evaluateOnNewDocument(changeUserAgent, userAgent)
+        ? this.evaluateOnNewDocument(
+            overrideNavigatorProperties,
+            userAgent,
+            platform || undefined,
+          )
         : undefined,
       // When we disable the UserAgent we want to
       // evaluate the original value in all Browsing Contexts
       ...frames.map(frame => {
-        return frame.evaluate(changeUserAgent, userAgent);
+        return frame.evaluate(
+          overrideNavigatorProperties,
+          userAgent,
+          platform || undefined,
+        );
       }),
     ]);
     this.#userAgentPreloadScript = evaluateToken?.identifier;

package/front_end/third_party/puppeteer/package/src/bidi/core/BrowsingContext.ts

@@ -713,7 +713,6 @@ export class BrowsingContext extends EventEmitter<{
 
   async setJavaScriptEnabled(enabled: boolean): Promise<void> {
     await this.userContext.browser.session.send(
-      // @ts-expect-error missing types
       'emulation.setScriptingEnabled',
       {
         // Enabled `null` means `default`, `false` means `disabled`.

package/front_end/third_party/puppeteer/package/src/cdp/NetworkManager.ts

@@ -77,11 +77,12 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   #credentials: Credentials | null = null;
   #attemptedAuthentications = new Set<string>();
   #userRequestInterceptionEnabled = false;
-  #protocolRequestInterceptionEnabled = false;
+  #protocolRequestInterceptionEnabled?: boolean;
   #userCacheDisabled?: boolean;
   #emulatedNetworkConditions?: InternalNetworkConditions;
   #userAgent?: string;
   #userAgentMetadata?: Protocol.Emulation.UserAgentMetadata;
+  #platform?: string;
 
   readonly #handlers = [
     ['Fetch.requestPaused', this.#onRequestPaused],
@@ -265,9 +266,11 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   async setUserAgent(
     userAgent: string,
     userAgentMetadata?: Protocol.Emulation.UserAgentMetadata,
+    platform?: string,
   ): Promise<void> {
     this.#userAgent = userAgent;
     this.#userAgentMetadata = userAgentMetadata;
+    this.#platform = platform;
     await this.#applyToAllClients(this.#applyUserAgent.bind(this));
   }
 
@@ -279,6 +282,7 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
       await client.send('Network.setUserAgentOverride', {
         userAgent: this.#userAgent,
         userAgentMetadata: this.#userAgentMetadata,
+        platform: this.#platform,
       });
     } catch (error) {
       if (this.#canIgnoreError(error)) {
@@ -306,6 +310,9 @@ export class NetworkManager extends EventEmitter<NetworkManagerEvents> {
   }
 
   async #applyProtocolRequestInterception(client: CDPSession): Promise<void> {
+    if (this.#protocolRequestInterceptionEnabled === undefined) {
+      return;
+    }
     if (this.#userCacheDisabled === undefined) {
       this.#userCacheDisabled = false;
     }

package/front_end/third_party/puppeteer/package/src/cdp/Page.ts

@@ -747,13 +747,29 @@ export class CdpPage extends Page {
   }
 
   override async setUserAgent(
-    userAgent: string,
+    userAgentOrOptions:
+      | string
+      | {
+          userAgent?: string;
+          userAgentMetadata?: Protocol.Emulation.UserAgentMetadata;
+          platform?: string;
+        },
     userAgentMetadata?: Protocol.Emulation.UserAgentMetadata,
   ): Promise<void> {
-    return await this.#frameManager.networkManager.setUserAgent(
-      userAgent,
-      userAgentMetadata,
-    );
+    if (typeof userAgentOrOptions === 'string') {
+      return await this.#frameManager.networkManager.setUserAgent(
+        userAgentOrOptions,
+        userAgentMetadata,
+      );
+    } else {
+      const userAgent =
+        userAgentOrOptions.userAgent ?? (await this.browser().userAgent());
+      return await this.#frameManager.networkManager.setUserAgent(
+        userAgent,
+        userAgentOrOptions.userAgentMetadata,
+        userAgentOrOptions.platform,
+      );
+    }
   }
 
   override async metrics(): Promise<Metrics> {

package/front_end/third_party/puppeteer/package/src/generated/version.ts

@@ -1,4 +1,4 @@
 /**
  * @internal
  */
-export const packageVersion = '24.20.0';
+export const packageVersion = '24.21.0';

package/front_end/third_party/puppeteer/package/src/node/BrowserLauncher.ts

@@ -181,6 +181,7 @@ export abstract class BrowserLauncher {
             slowMo,
           });
         }
+
         if (protocol === 'webDriverBiDi') {
           browser = await this.createBiDiOverCdpBrowser(
             browserProcess,
@@ -210,6 +211,17 @@ export abstract class BrowserLauncher {
       }
     } catch (error) {
       void browserCloseCallback();
+      if (
+        browserProcess.getRecentLogs().some(line => {
+          return line.includes(
+            'Failed to create a ProcessSingleton for your profile directory',
+          );
+        })
+      ) {
+        throw new Error(
+          `The browser is already running for ${launchArgs.userDataDir}. Use a different \`userDataDir\` or stop the running browser first.`,
+        );
+      }
       if (error instanceof BrowsersTimeoutError) {
         throw new TimeoutError(error.message);
       }

package/front_end/ui/components/text_editor/config.ts

@@ -132,7 +132,6 @@ function moveCompletionSelectionIfNotConservative(
     if (CM.completionStatus(view.state) !== 'active') {
       return false;
     }
-    view.dispatch({effects: setAiAutoCompleteSuggestion.of(null)});
     if (view.state.field(conservativeCompletion, false)) {
       view.dispatch({effects: disableConservativeCompletion.of(null)});
       announceSelectedCompletionInfo(view);
@@ -149,7 +148,6 @@ function moveCompletionSelectionBackwardWrapper(): ((view: CM.EditorView) => boo
     if (CM.completionStatus(view.state) !== 'active') {
       return false;
     }
-    view.dispatch({effects: setAiAutoCompleteSuggestion.of(null)});
     CM.moveCompletionSelection(false)(view);
     announceSelectedCompletionInfo(view);
     return true;
@@ -523,11 +521,11 @@ export const aiAutoCompleteSuggestionState = CM.StateField.define<ActiveSuggesti
     const {head} = tr.state.selection.main;
 
     // If a change happened before the position from which suggestion was generated, set to null.
-    if (tr.changes.touchesRange(0, from - 1) || head < from) {
+    if (head < from) {
       return null;
     }
 
-    // Check if what's typed is a prefix of the suggestion.
+    // Check if what's typed after the AI suggestion is a prefix of the AI suggestion.
     const typedText = tr.state.doc.sliceString(from, head);
     return value.text.startsWith(typedText) ? value : null;
   },
@@ -539,6 +537,11 @@ export function hasActiveAiSuggestion(state: CM.EditorState): boolean {
 
 export function acceptAiAutoCompleteSuggestion(view: CM.EditorView):
     {accepted: boolean, suggestion?: ActiveSuggestion} {
+  const selectedCompletion = CM.selectedCompletion(view.state);
+  if (selectedCompletion) {
+    return {accepted: false};
+  }
+
   const suggestion = view.state.field(aiAutoCompleteSuggestionState);
   if (!suggestion) {
     return {accepted: false};
@@ -568,23 +571,70 @@ export const aiAutoCompleteSuggestion: CM.Extension = [
         decorations: CM.DecorationSet = CM.Decoration.none;
 
         update(update: CM.ViewUpdate): void {
+          // Hide decorations if there is no active AI suggestion.
           const activeSuggestion = update.state.field(aiAutoCompleteSuggestionState);
-          const {head, empty} = update.state.selection.main;
-          let hint = '';
-          if (activeSuggestion && empty && head >= activeSuggestion.from) {
-            const {text, from} = activeSuggestion;
-            const typedText = update.state.doc.sliceString(from, head);
-            if (text.startsWith(typedText)) {
-              hint = text.slice(typedText.length);
-            }
+          if (!activeSuggestion) {
+            this.decorations = CM.Decoration.none;
+            return;
           }
 
-          if (!hint) {
+          // Hide AI suggestion while the user is interacting with the traditional
+          // autocomplete menu to avoid conflicting suggestions.
+          if (CM.completionStatus(update.view.state) === 'pending') {
             this.decorations = CM.Decoration.none;
-          } else {
-            this.decorations =
-                CM.Decoration.set([CM.Decoration.widget({widget: new CompletionHint(hint), side: 1}).range(head)]);
+            return;
           }
+
+          // Hide AI suggestion if the user has selected an item from the
+          // traditional autocomplete menu that is not the first one.
+          const selectedCompletionIndex = CM.selectedCompletionIndex(update.state);
+          if (selectedCompletionIndex && selectedCompletionIndex > 0) {
+            this.decorations = CM.Decoration.none;
+            return;
+          }
+
+          const {head} = update.state.selection.main;
+          const selectedCompletion = CM.selectedCompletion(update.state);
+          const additionallyTypedText = update.state.doc.sliceString(activeSuggestion.from, head);
+          // The user might have typed text after the suggestion is triggered.
+          // If the suggestion no longer starts with the typed text, hide it.
+          if (!activeSuggestion.text.startsWith(additionallyTypedText)) {
+            this.decorations = CM.Decoration.none;
+            return;
+          }
+
+          let ghostText = activeSuggestion.text.slice(additionallyTypedText.length);
+          if (selectedCompletion) {
+            // If the user typed the full selected completion, then we don't check for overlap.
+            // (e.g. the user wrote `flex`, traditional suggestion is `flex` and the AI autocompletion is
+            // `;\njustify-content: center`. Then, we want to show the AI completion)
+            const endsWithCompleteSelectedCompletion =
+                update.state.doc.sliceString(head - selectedCompletion.label.length, head) === selectedCompletion.label;
+            // If a traditional autocomplete menu is shown, the AI suggestion is only
+            // shown if it builds upon the currently selected item. If there is no
+            // overlap, we hide the AI suggestion. For example, for the text `console`
+            // if the traditional autocomplete suggests `log` and the AI
+            // suggests `warn`, there is no overlap and the AI suggestion is hidden.
+            if (!endsWithCompleteSelectedCompletion &&
+                !TextUtils.TextUtils.getOverlap(selectedCompletion.label, ghostText)) {
+              this.decorations = CM.Decoration.none;
+              return;
+            }
+          }
+
+          // When `conservativeCompletion` is disabled in Console, the editor shows a ghost
+          // text for the first item in the traditional autocomplete menu and this ghost text
+          // is reflected in `currentHint`. In this case, we need to remove
+          // the overlapping part from our AI suggestion's ghost text to avoid
+          // showing a double suggestion.
+          const currentMenuHint = update.view.plugin(showCompletionHint)?.currentHint;
+          const conservativeCompletionEnabled = update.state.field(conservativeCompletion, false);
+          if (!conservativeCompletionEnabled && currentMenuHint) {
+            ghostText = ghostText.slice(currentMenuHint.length);
+          }
+
+          this.decorations =
+              CM.Decoration.set([CM.Decoration.widget({widget: new CompletionHint(ghostText), side: 1}).range(head)]);
         }
       },
       {decorations: p => p.decorations}),

package/front_end/ui/legacy/ProgressIndicator.ts

@@ -12,7 +12,7 @@ export class ProgressIndicator extends HTMLElement implements Common.Progress.Pr
   readonly #contentElement: Element;
   #labelElement: Element;
   #progressElement: HTMLProgressElement;
-  readonly #stopButton?: Element;
+  #stopButton?: Element;
   #isCanceled = false;
   #worked = 0;
   #isDone = false;
@@ -25,7 +25,10 @@ export class ProgressIndicator extends HTMLElement implements Common.Progress.Pr
     this.#labelElement = this.#contentElement.createChild('div', 'title');
     this.#progressElement = this.#contentElement.createChild('progress');
     this.#progressElement.value = 0;
+  }
 
+  connectedCallback(): void {
+    this.classList.add('progress-indicator');
     // By default we show the stop button, but this can be controlled by
     // using the 'no-stop-button' attribute on the element.
     if (!this.hasAttribute('no-stop-button')) {
@@ -34,10 +37,6 @@ export class ProgressIndicator extends HTMLElement implements Common.Progress.Pr
     }
   }
 
-  connectedCallback(): void {
-    this.classList.add('progress-indicator');
-  }
-
   done(): void {
     if (this.#isDone) {
       return;

package/front_end/ui/legacy/components/data_grid/DataGridElement.ts

@@ -399,7 +399,7 @@ class DataGridElementNode extends SortableDataGridNode<DataGridElementNode> {
       const cell = cells[i];
       const column = this.#dataGridElement.columns[i];
       if (column.dataType === DataType.BOOLEAN) {
-        this.data[column.id] = hasBooleanAttribute(cell, 'data-value');
+        this.data[column.id] = hasBooleanAttribute(cell, 'data-value') || cell.textContent === 'true';
       } else {
         this.data[column.id] = cell.dataset.value ?? cell.textContent ?? '';
       }
@@ -472,7 +472,9 @@ class DataGridElementNode extends SortableDataGridNode<DataGridElementNode> {
   override createCell(columnId: string): HTMLElement {
     const index = this.#dataGridElement.columns.findIndex(({id}) => id === columnId);
     if (this.#dataGridElement.columns[index].dataType === DataType.BOOLEAN) {
-      return super.createCell(columnId);
+      const cell = super.createCell(columnId);
+      cell.setAttribute('part', `${columnId}-column`);
+      return cell;
     }
     const cell = this.createTD(columnId);
     cell.setAttribute('part', `${columnId}-column`);

package/front_end/ui/visual_logging/Debugging.ts

@@ -731,7 +731,7 @@ function compareVeEvents(actual: TestLogEntry, expected: TestLogEntry): boolean
 interface PendingEventExpectation {
   expectedEvents: TestLogEntry[];
   missingEvents?: TestLogEntry[];
-  unmatchingEvents: TestLogEntry[];
+  unmatchedEvents: TestLogEntry[];
   success: () => void;
   fail: (arg0: Error) => void;
 }
@@ -785,20 +785,33 @@ export async function expectVeEvents(expectedEvents: TestLogEntry[]): Promise<vo
     throw new Error('VE events expectation already set. Cannot set another one until the previous is resolved');
   }
   const {promise, resolve: success, reject: fail} = Promise.withResolvers<void>();
-  pendingEventExpectation = {expectedEvents, success, fail, unmatchingEvents: []};
+  pendingEventExpectation = {expectedEvents, success, fail, unmatchedEvents: []};
   checkPendingEventExpectation();
 
   const timeout = setTimeout(() => {
     if (pendingEventExpectation?.missingEvents) {
-      pendingEventExpectation.fail(new Error(
-          '\nMissing VE Events:\n' + formatVeEvents(pendingEventExpectation.missingEvents) +
-          '\nUnmatched VE Events:\n' + formatVeEvents(pendingEventExpectation.unmatchingEvents) + '\nAll events:\n' +
-          JSON.stringify(veDebugEventsLog, null, 2)));
+      const allLogs = veDebugEventsLog.filter(ve => {
+        if ('interaction' in ve) {
+          // Very noisy in the error and not providing context
+          return ve.interaction !== 'SettingAccess';
+        }
+
+        return true;
+      });
+      pendingEventExpectation.fail(new Error(`
+Missing VE Events:
+${formatVeEvents(pendingEventExpectation.missingEvents)}
+Unmatched VE Events:
+${formatVeEvents(pendingEventExpectation.unmatchedEvents)}
+All events:
+${JSON.stringify(allLogs, null, 2)}
+`));
     }
   }, EVENT_EXPECTATION_TIMEOUT);
 
   return await promise.finally(() => {
     clearTimeout(timeout);
+    pendingEventExpectation = null;
   });
 }
 
@@ -811,7 +824,7 @@ function checkPendingEventExpectation(): void {
   const actualEvents = [...veDebugEventsLog] as TestLogEntry[];
   let partialMatch = false;
   const matchedImpressions = new Set<string>();
-  pendingEventExpectation.unmatchingEvents = [];
+  pendingEventExpectation.unmatchedEvents = [];
   for (let i = 0; i < pendingEventExpectation.expectedEvents.length; ++i) {
     const expectedEvent = pendingEventExpectation.expectedEvents[i];
     while (true) {
@@ -826,9 +839,9 @@ function checkPendingEventExpectation(): void {
       }
       if (!compareVeEvents(actualEvents[i], expectedEvent)) {
         if (partialMatch) {
-          const unmatching = {...actualEvents[i]};
-          if ('impressions' in unmatching && 'impressions' in expectedEvent) {
-            unmatching.impressions = unmatching.impressions.filter(impression => {
+          const unmatched = {...actualEvents[i]};
+          if ('impressions' in unmatched && 'impressions' in expectedEvent) {
+            unmatched.impressions = unmatched.impressions.filter(impression => {
               const matched = expectedEvent.impressions.includes(impression);
               if (matched) {
                 matchedImpressions.add(impression);
@@ -836,7 +849,7 @@ function checkPendingEventExpectation(): void {
               return !matched;
             });
           }
-          pendingEventExpectation.unmatchingEvents.push(unmatching);
+          pendingEventExpectation.unmatchedEvents.push(unmatched);
         }
         actualEvents.splice(i, 1);
       } else {
@@ -847,7 +860,6 @@ function checkPendingEventExpectation(): void {
   }
   numMatchedEvents = veDebugEventsLog.length - actualEvents.length + pendingEventExpectation.expectedEvents.length;
   pendingEventExpectation.success();
-  pendingEventExpectation = null;
 }
 
 function getUnmatchedVeEvents(): string {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -2739,6 +2739,7 @@ export const knownContextValues = new Set([
   'overscroll-behavior-inline',
   'overscroll-behavior-x',
   'overscroll-behavior-y',
+  'overscroll-position',
   'p3',
   'pa',
   'packetLoss',

package/package.json

@@ -23,8 +23,8 @@
     "collect-strings": "vpython3 third_party/node/node.py --output third_party/i18n/collect-strings.js front_end",
     "components-server": "vpython3 third_party/node/node.py --output scripts/component_server/server.js",
     "debug-webtest": "vpython3 third_party/node/node.py --output scripts/npm_test.js --debug-devtools",
-    "generate-protocol-resources": "scripts/deps/generate_protocol_resources.py && git cl format --js",
-    "install-deps": "scripts/deps/manage_node_deps.py",
+    "generate-protocol-resources": "vpython3 scripts/deps/generate_protocol_resources.py && git cl format --js",
+    "install-deps": "vpython3 scripts/deps/manage_node_deps.py",
     "lint": "vpython3 third_party/node/node.py --output --experimental-strip-types --no-warnings=ExperimentalWarning scripts/test/run_lint_check.mjs",
     "prebuild": "gn gen out/Default",
     "rdb": "rdb stream -new -realm chromium:public --",
@@ -102,5 +102,5 @@
       "@eslint/core": "0.15.1"
     }
   },
-  "version": "1.0.1515446"
+  "version": "1.0.1515796"
 }