chrome-devtools-frontend 1.0.1514545 → 1.0.1515446

package/AUTHORS

@@ -14,6 +14,7 @@
 AbdAlRahman Gad <abdobngad@gmail.com>
 Ajay Panthagani <ajaypanthagani321@gmail.com>
 Alesandro Ortiz <alesandro@alesandroortiz.com>
+Alex Ho <wjhe1016@gmail.com>
 Alexander Stammbach <alexander@stammbach.io>
 Alexey Rodionov <fluorescent.hallucinogen@gmail.com>
 Ameen Basha <ameenbasha111@gmail.com>

package/docs/committers_policy.md

@@ -29,7 +29,7 @@ Once you get approval from the existing committers, you'll be added to [chrome-d
 
 In the most unfavorable circumstances, the process could extend up to two weeks. Maintain your commitment to writing patches. Even in the uncommon instances where a nomination fails, the objection is frequently something specific to resolve, such as "more patches" or "not enough people are familiar with this person's work."
 
-Two-factor authentication is a requirement for adding your account as a committer. If you haven't done so already, you'll need to set up a security key on your account.
+Two-factor authentication is a requirement for adding your account as a committer. If you haven't done so already, you'll need to set up a security key on your account. For more information about this requirement see [Gerrit ReAuth](https://chromium.googlesource.com/chromium/src/+/main/docs/gerrit_reauth.md).
 
 # **Maintaining committer status**
 

package/docs/contributing/infrastructure.md

@@ -88,6 +88,12 @@ file in the `infra/config` branch contains the logic that determines
 which builders are needed to verify a CQ. See `custom_locationsfilters`
 for the current logic.
 
+Some of the filters currently in use are:
+ - `cpp_debug_extension` builders only trigger on changes related to the extension
+ - `dtf_check_no_bundle` builder only trigger on GN changes
+ - all other builders will not trigger if only documentation files are updated
+
+
 ## Branch cutting process
 
 At the end of every release cycle Chromium will cut a new branch for the current release.
@@ -139,11 +145,101 @@ To toggle this behaviour you need to edit `buckets/try.star` file ([example](htt
     dictionary together with the desired experiment rate percentage; remove it
     from the list to make it a regular builder
 
-## Controlling when a builder runs
-// TODO
+## Adding a new builder in CQ
+
+To add a new try-builder edit the `buckets/try.start` file to call one of the
+existing functions that generate builder definitions:
+  - `try_builder` used for builder with recipes that do not orchestrate other
+    builders:
+      - build only builders (`dtf_check_no_bundle`)
+      - chromium builders (`devtools_frontend_linux_blink_light_rel_fastbuild`)
+  - `try_pair` used for builders with orchestrating recipes (delegates to a
+    compilator builder before delegating testing to swarming)
+
+Alternatively define your own builder function and call it for the instances you
+need (see `presubmit_builder` and `cpp_debug_extension_try`).
+
+You will need add your new builder to the `cq_builders.devtools_builders` list.
 
-## Adding a new builder
-// TODO
+To control the CL blocking behaviour of your builder see above.
+
+To control if the builder should be not present in the CQ for branches, add your
+builder to `cq_builders.chromium_builders` list.
+
+## Adding a new builder in CI
+
+To add a new try-builder edit the `buckets/ci.start` file to add a new
+`builder_descriptor` to the `builders` of `generate_ci_configs` function call.
+
+In your descriptor decide for the name of builder, the recipe, any other custom
+properties you might need and for which configurations (consoles) to include
+your builder (`ci` stands for the main waterfall console). [Example](https://chromium.googlesource.com/devtools/devtools-frontend/+/refs/heads/infra/config/buckets/ci.star#:~:text=name%20%3D%20%22-,Linux,-Compile%20Debug%22%2C).
 
 ## Anatomy of a CQ build
-// TODO
+
+In CQ the builders that get most attention are `dtf_*_rel` builders. These builders
+run the devtools/trybot_tester recipe and are responsible with building DevTools
+Frontend and running our tests.
+
+Below is a detailed description of what happens in such a build:
+  - The recipe will perform the `bot_update` and `gclient runhooks` step where
+    the tip-of-tree for devtools-frontend gets checked out, your changes get
+    patched on top of it and dependencies get updated.
+  - The compilator bot get triggered (`initialization` step)
+  - We wait for the compilator bot to finish. This bot is responsible for
+    the actual build of devtools-frontend.
+       - It does a `bot_update` of its own
+       - Generates the GN files (`gn` step)
+       - Compiles (`compile`) the project
+       - Reads the e2e_non_hosted test lists
+       - Creates a CAS archive with project and the compilation output
+       - Ouputs the `compilator_properties`
+  - Once the compilator is done we read the `compilator_properties` to find
+     - the `cas_digest` to be used when triggering tests on swarming
+     - the `e2e_non_hosted_test_list` for sharding the e2e tests execution
+  - Write the e2e test list at the location where building would have written it
+  - The default test run phase starts at `Run tests` step:
+     - We trigger all tests on swarming in parallel (`Trigger Tests`) substep.
+        - For all types of tests we calculate the command we want to run on swarming
+         and trigger a task with that command and the collected CAS digest
+        - Before calculating the command for e2e test we read the test list and
+         and split it in a number of shards. Each shard will have the allocated
+         tests specified in the command.
+     - We wait for all swarming task to complete
+  - Next we re-run the failed tests in attemt to exonerate their initial
+   failures (`Flake exonaration attempt` step):
+     - We query ResultDB for any tests that might have failed
+     - We collect the failed test names and contruct new commands to re-run
+      them on new swarming tasks
+     - We wait for all swarming task to complete
+  - Finally we will stress test the tests that were added/modified by the
+   current CL in the `Detect flakes in new tests` step
+     - Run `git diff` to determine which tests were added/modifed
+     - Construct the command to be run on swatming
+     - Trigger and wait for the swarming tasks to finish
+  - Calculate the outcome of the builder:
+     - fail the builder if tests failed in the default run and the exoneration
+      run was unsuccesful
+     - fail the builder if tests failed in the deflaking phase
+     - otherwise report build as passing
+
+### Common build failures
+
+The first place where a build usualy fails is on `bot_update` and this usually
+happens because your changes cannot be applied on top of the current tip-of-tree.
+Rebase your CL and solve any merge conflicts and this failure will go away.
+
+Another common failure is a compilation failure. You can insepct the compilator
+builder (`dtf_*_compiler_rel`) separately by following the link next to the
+`compilator steps` step.
+
+If you have too many tests failing in the default phase the exoneration phase
+gets skipped.
+
+A test might not get exonerated in your build even if your CL does not touch
+anything related to it. The exoneration phase will re-run previously faling
+tests a number of times and at any point the test passes the tests gets
+exonerated. Therefore a test can have a recent history of getting exonerated
+even if it consitently failed 4 times out of 5 runs for some time. Try to
+correlate your failure with a luci-analysys report on this test and skip it
+untill the flakiness gets resolved.

package/front_end/core/common/Settings.ts

@@ -133,7 +133,6 @@ export class Settings {
    * If you are creating a setting that you expect the user to control, and
    * sync, prefer {@see createSetting}
    */
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   moduleSetting<T = any>(settingName: string): Setting<T> {
     const setting = this.moduleSettings.get(settingName) as Setting<T>;
@@ -589,7 +588,6 @@ export class Setting<V> {
   }
 }
 
-// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class RegExpSetting extends Setting<any> {
   #regexFlags: string|undefined;
@@ -643,6 +641,9 @@ export class RegExpSetting extends Setting<any> {
   }
 }
 
+// The VersionController does a lot of mapping and restructuring which often need
+// typecasting to any, allow it in there
+/* eslint-disable @typescript-eslint/no-explicit-any */
 export class VersionController {
   static readonly GLOBAL_VERSION_SETTING_NAME = 'inspectorVersion';
   static readonly SYNCED_VERSION_SETTING_NAME = 'syncedInspectorVersion';
@@ -798,16 +799,16 @@ export class VersionController {
 
       const newSetting = Settings.instance().createSetting(newName, {});
       const newValue = newSetting.get() || {};
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+
       // @ts-expect-error
       newValue.vertical = newValue.vertical || {};
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+
       // @ts-expect-error
       newValue.vertical.showMode = showMode;
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+
       // @ts-expect-error
       newValue.horizontal = newValue.horizontal || {};
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+
       // @ts-expect-error
       newValue.horizontal.showMode = showMode;
       newSetting.set(newValue);
@@ -888,7 +889,7 @@ export class VersionController {
     const newList = [];
     for (let i = 0; i < list.length; ++i) {
       const value = list[i];
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
       const device: Record<string, any> = {};
       device['title'] = value['title'];
       device['type'] = 'unknown';
@@ -930,8 +931,6 @@ export class VersionController {
   }
 
   updateVersionFrom14To15(): void {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createLocalSetting<any>('workspaceExcludedFolders', {});
     const oldValue = setting.get();
     const newValue: Record<string, string[]> = {};
@@ -945,8 +944,6 @@ export class VersionController {
   }
 
   updateVersionFrom15To16(): void {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createSetting<any>('InspectorView.panelOrder', {});
     const tabOrders = setting.get();
     for (const key of Object.keys(tabOrders)) {
@@ -956,8 +953,6 @@ export class VersionController {
   }
 
   updateVersionFrom16To17(): void {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createSetting<any>('networkConditionsCustomProfiles', []);
     const oldValue = setting.get();
     const newValue = [];
@@ -976,8 +971,6 @@ export class VersionController {
   }
 
   updateVersionFrom17To18(): void {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const setting = Settings.instance().createLocalSetting<any>('workspaceExcludedFolders', {});
     const oldValue = setting.get();
     const newValue: Record<string, string> = {};
@@ -997,8 +990,6 @@ export class VersionController {
 
   updateVersionFrom18To19(): void {
     const defaultColumns = {status: true, type: true, initiator: true, size: true, time: true};
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const visibleColumnSettings = Settings.instance().createSetting<any>('networkLogColumnsVisibility', defaultColumns);
     const visibleColumns = visibleColumnSettings.get();
     visibleColumns.name = true;
@@ -1034,8 +1025,6 @@ export class VersionController {
   }
 
   updateVersionFrom21To22(): void {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const breakpointsSetting = Settings.instance().createLocalSetting<any>('breakpoints', []);
     const breakpoints = breakpointsSetting.get();
     for (const breakpoint of breakpoints) {
@@ -1058,8 +1047,7 @@ export class VersionController {
 
   updateVersionFrom24To25(): void {
     const defaultColumns = {status: true, type: true, initiator: true, size: true, time: true};
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
     const networkLogColumnsSetting = Settings.instance().createSetting<any>('networkLogColumns', defaultColumns);
     const columns = networkLogColumnsSetting.get();
     delete columns.product;
@@ -1071,8 +1059,6 @@ export class VersionController {
     const urls = Object.keys(oldSetting.get());
     const textFilter = urls.map(url => `-url:${url}`).join(' ');
     if (textFilter) {
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const textFilterSetting = Settings.instance().createSetting<any>('console.textFilter', '');
       const suffix = textFilterSetting.get() ? ` ${textFilterSetting.get()}` : '';
       textFilterSetting.set(`${textFilter}${suffix}`);
@@ -1082,8 +1068,6 @@ export class VersionController {
 
   updateVersionFrom26To27(): void {
     function renameKeyInObjectSetting(settingName: string, from: string, to: string): void {
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const setting = Settings.instance().createSetting<any>(settingName, {});
       const value = setting.get();
       if (from in value) {
@@ -1115,8 +1099,6 @@ export class VersionController {
 
   updateVersionFrom28To29(): void {
     function renameKeyInObjectSetting(settingName: string, from: string, to: string): void {
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const setting = Settings.instance().createSetting<any>(settingName, {});
       const value = setting.get();
       if (from in value) {
@@ -1171,7 +1153,6 @@ export class VersionController {
     // know on which resource type the given breakpoint was set, we just assume
     // 'script' here to keep things simple.
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const breakpointsSetting = Settings.instance().createLocalSetting<any>('breakpoints', []);
     const breakpoints = breakpointsSetting.get();
     for (const breakpoint of breakpoints) {
@@ -1181,12 +1162,11 @@ export class VersionController {
   }
 
   updateVersionFrom32To33(): void {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const previouslyViewedFilesSetting = Settings.instance().createLocalSetting<any>('previouslyViewedFiles', []);
     let previouslyViewedFiles = previouslyViewedFilesSetting.get();
 
     // Discard old 'previouslyViewedFiles' items that don't have a 'url' property.
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
     previouslyViewedFiles = previouslyViewedFiles.filter((previouslyViewedFile: any) => 'url' in previouslyViewedFile);
 
     // Introduce the new 'resourceTypeName' property on previously viewed files.
@@ -1213,7 +1193,6 @@ export class VersionController {
     const logpointPrefix = '/** DEVTOOLS_LOGPOINT */ console.log(';
     const logpointSuffix = ')';
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const breakpointsSetting = Settings.instance().createLocalSetting<any>('breakpoints', []);
     const breakpoints = breakpointsSetting.get();
     for (const breakpoint of breakpoints) {
@@ -1234,7 +1213,6 @@ export class VersionController {
     const logpointPrefix = '/** DEVTOOLS_LOGPOINT */ console.log(';
     const logpointSuffix = ')';
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     const breakpointsSetting = Settings.instance().createLocalSetting<any>('breakpoints', []);
     const breakpoints = breakpointsSetting.get();
     for (const breakpoint of breakpoints) {
@@ -1466,6 +1444,7 @@ export class VersionController {
     }
   }
 }
+/* eslint-enable @typescript-eslint/no-explicit-any */
 
 export const enum SettingStorageType {
   /** Persists with the active Chrome profile but also syncs the settings across devices via Chrome Sync. */

package/front_end/global_typings/global_defs.d.ts

@@ -12,7 +12,7 @@ declare module '*.css.js' {
   export default styles;
 }
 
-// Types for the Scheduler API.
+// [start] Types for the Scheduler API.
 // These are taken from
 // https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/wicg-task-scheduling
 // but modified because within Chrome we can use the API without worrying that
@@ -66,3 +66,17 @@ interface Window {
 interface WorkerGlobalScope {
   readonly scheduler?: Scheduler;
 }
+// [end] Types for the Scheduler API.
+
+// [start] Type definition for EyeDropper
+
+interface EyeDropper {
+  open: (options?: {signal?: AbortSignal}) => Promise<{sRGBHex: string}>;
+}
+
+interface Window {
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  EyeDropper: {new(): EyeDropper};
+}
+
+// [end] Type definition for EyeDropper

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -9,7 +9,7 @@ import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
 import * as Root from '../../../core/root/root.js';
 import * as SDK from '../../../core/sdk/sdk.js';
-import * as TimelineUtils from '../../../panels/timeline/utils/utils.js';
+import * as Tracing from '../../../services/tracing/tracing.js';
 import * as Trace from '../../trace/trace.js';
 import type {ConversationType} from '../AiHistoryStorage.js';
 import {
@@ -18,6 +18,8 @@ import {
 } from '../data_formatters/PerformanceInsightFormatter.js';
 import {PerformanceTraceFormatter} from '../data_formatters/PerformanceTraceFormatter.js';
 import {debugLog} from '../debug.js';
+import {AICallTree} from '../performance/AICallTree.js';
+import {AgentFocus} from '../performance/AIContext.js';
 
 import {
   type AgentOptions,
@@ -156,23 +158,23 @@ enum ScorePriority {
   DEFAULT = 1,
 }
 
-export class PerformanceTraceContext extends ConversationContext<TimelineUtils.AIContext.AgentFocus> {
+export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
   static full(parsedTrace: Trace.TraceModel.ParsedTrace): PerformanceTraceContext {
-    return new PerformanceTraceContext(TimelineUtils.AIContext.AgentFocus.full(parsedTrace));
+    return new PerformanceTraceContext(AgentFocus.full(parsedTrace));
   }
 
   static fromInsight(parsedTrace: Trace.TraceModel.ParsedTrace, insight: Trace.Insights.Types.InsightModel):
       PerformanceTraceContext {
-    return new PerformanceTraceContext(TimelineUtils.AIContext.AgentFocus.fromInsight(parsedTrace, insight));
+    return new PerformanceTraceContext(AgentFocus.fromInsight(parsedTrace, insight));
   }
 
-  static fromCallTree(callTree: TimelineUtils.AICallTree.AICallTree): PerformanceTraceContext {
-    return new PerformanceTraceContext(TimelineUtils.AIContext.AgentFocus.fromCallTree(callTree));
+  static fromCallTree(callTree: AICallTree): PerformanceTraceContext {
+    return new PerformanceTraceContext(AgentFocus.fromCallTree(callTree));
   }
 
-  #focus: TimelineUtils.AIContext.AgentFocus;
+  #focus: AgentFocus;
 
-  constructor(focus: TimelineUtils.AIContext.AgentFocus) {
+  constructor(focus: AgentFocus) {
     super();
     this.#focus = focus;
   }
@@ -182,7 +184,7 @@ export class PerformanceTraceContext extends ConversationContext<TimelineUtils.A
     return `trace-${min}-${max}`;
   }
 
-  override getItem(): TimelineUtils.AIContext.AgentFocus {
+  override getItem(): AgentFocus {
     return this.#focus;
   }
 
@@ -226,13 +228,13 @@ type PerformanceConversationType =
  * One agent instance handles one conversation. Create a new agent
  * instance for a new conversation.
  */
-export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus> {
+export class PerformanceAgent extends AiAgent<AgentFocus> {
   // TODO: would make more sense on AgentOptions
   #conversationType: PerformanceConversationType;
   #formatter: PerformanceTraceFormatter|null = null;
   #lastInsightForEnhancedQuery: Trace.Insights.Types.InsightModel|undefined;
   #eventsSerializer = new Trace.EventsSerializer.EventsSerializer();
-  #lastFocusHandledForContextDetails: TimelineUtils.AIContext.AgentFocus|null = null;
+  #lastFocusHandledForContextDetails: AgentFocus|null = null;
 
   constructor(opts: AgentOptions, conversationType: PerformanceConversationType) {
     super(opts);
@@ -250,8 +252,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
    *
    * The record key is the result of a function's displayInfoFromArgs.
    */
-  #functionCallCacheForFocus =
-      new Map<TimelineUtils.AIContext.AgentFocus, Record<string, Host.AidaClient.RequestFact>>();
+  #functionCallCacheForFocus = new Map<AgentFocus, Record<string, Host.AidaClient.RequestFact>>();
 
   #networkDataDescriptionFact: Host.AidaClient.RequestFact = {
     text: TraceEventFormatter.networkDataFormatDescription,
@@ -305,8 +306,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
   }
 
   async *
-      handleContextDetails(context: ConversationContext<TimelineUtils.AIContext.AgentFocus>|null):
-          AsyncGenerator<ContextResponse, void, void> {
+      handleContextDetails(context: ConversationContext<AgentFocus>|null): AsyncGenerator<ContextResponse, void, void> {
     if (!context) {
       return;
     }
@@ -368,8 +368,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
     return super.parseTextResponse(response);
   }
 
-  override async enhanceQuery(query: string, context: ConversationContext<TimelineUtils.AIContext.AgentFocus>|null):
-      Promise<string> {
+  override async enhanceQuery(query: string, context: ConversationContext<AgentFocus>|null): Promise<string> {
     if (!context) {
       this.clearDeclaredFunctions();
       return query;
@@ -426,7 +425,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
   }
 
   override async * run(initialQuery: string, options: {
-    selected: ConversationContext<TimelineUtils.AIContext.AgentFocus>|null,
+    selected: ConversationContext<AgentFocus>|null,
     signal?: AbortSignal,
   }): AsyncGenerator<ResponseData, void, void> {
     const focus = options.selected?.getItem();
@@ -518,7 +517,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
     });
   }
 
-  #addFacts(focus: TimelineUtils.AIContext.AgentFocus): void {
+  #addFacts(focus: AgentFocus): void {
     this.addFact(this.#callFrameDataDescriptionFact);
     this.addFact(this.#networkDataDescriptionFact);
 
@@ -543,7 +542,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
     }
   }
 
-  #cacheFunctionResult(focus: TimelineUtils.AIContext.AgentFocus, key: string, result: string): void {
+  #cacheFunctionResult(focus: AgentFocus, key: string, result: string): void {
     const fact: Host.AidaClient.RequestFact = {
       text: `This is the result of calling ${key}:\n${result}`,
       metadata: {source: key, score: ScorePriority.DEFAULT},
@@ -553,7 +552,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
     this.#functionCallCacheForFocus.set(focus, cache);
   }
 
-  #declareFunctions(context: ConversationContext<TimelineUtils.AIContext.AgentFocus>): void {
+  #declareFunctions(context: ConversationContext<AgentFocus>): void {
     const focus = context.getItem();
     const {parsedTrace, insightSet} = focus.data;
 
@@ -786,7 +785,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
           return {error: 'Invalid eventKey'};
         }
 
-        const tree = TimelineUtils.AICallTree.AICallTree.fromEvent(event, parsedTrace);
+        const tree = AICallTree.fromEvent(event, parsedTrace);
         const callTree = tree ? this.#formatter.formatCallTree(tree) : 'No call tree found';
 
         const key = `getDetailedCallTree(${args.eventKey})`;
@@ -796,7 +795,7 @@ export class PerformanceAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus
 
     });
 
-    const isFresh = TimelineUtils.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace);
+    const isFresh = Tracing.FreshRecording.Tracker.instance().recordingIsFresh(parsedTrace);
     const hasScriptContents =
         parsedTrace.metadata.enhancedTraceVersion && parsedTrace.data.Scripts.scripts.some(s => s.content);
 

package/front_end/models/ai_assistance/agents/PerformanceAnnotationsAgent.ts

@@ -5,7 +5,8 @@
 import * as Host from '../../../core/host/host.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Root from '../../../core/root/root.js';
-import type * as TimelineUtils from '../../../panels/timeline/utils/utils.js';
+import type {AICallTree} from '../performance/AICallTree.js';
+import type {AgentFocus} from '../performance/AIContext.js';
 
 import {AiAgent, type ContextResponse, type ConversationContext, type RequestOptions, ResponseType} from './AiAgent.js';
 import {PerformanceTraceContext} from './PerformanceAgent.js';
@@ -87,7 +88,7 @@ The 'calculatePosition' function, taking 80ms, is a potential bottleneck.
 Consider optimizing the position calculation logic or reducing the frequency of calls to improve animation performance.
 `;
 
-export class PerformanceAnnotationsAgent extends AiAgent<TimelineUtils.AIContext.AgentFocus> {
+export class PerformanceAnnotationsAgent extends AiAgent<AgentFocus> {
   override preamble = callTreePreamble;
 
   get clientFeature(): Host.AidaClient.ClientFeature {
@@ -109,8 +110,7 @@ export class PerformanceAnnotationsAgent extends AiAgent<TimelineUtils.AIContext
   }
 
   async *
-      handleContextDetails(context: ConversationContext<TimelineUtils.AIContext.AgentFocus>|null):
-          AsyncGenerator<ContextResponse, void, void> {
+      handleContextDetails(context: ConversationContext<AgentFocus>|null): AsyncGenerator<ContextResponse, void, void> {
     if (!context) {
       return;
     }
@@ -134,8 +134,7 @@ export class PerformanceAnnotationsAgent extends AiAgent<TimelineUtils.AIContext
     };
   }
 
-  override async enhanceQuery(query: string, context: ConversationContext<TimelineUtils.AIContext.AgentFocus>|null):
-      Promise<string> {
+  override async enhanceQuery(query: string, context: ConversationContext<AgentFocus>|null): Promise<string> {
     if (!context) {
       return query;
     }
@@ -153,7 +152,7 @@ export class PerformanceAnnotationsAgent extends AiAgent<TimelineUtils.AIContext
   /**
    * Used in the Performance panel to automatically generate a label for a selected entry.
    */
-  async generateAIEntryLabel(callTree: TimelineUtils.AICallTree.AICallTree): Promise<string> {
+  async generateAIEntryLabel(callTree: AICallTree): Promise<string> {
     const context = PerformanceTraceContext.fromCallTree(callTree);
     const response = await Array.fromAsync(this.run(AI_LABEL_GENERATION_PROMPT, {selected: context}));
     const lastResponse = response.at(-1);

package/front_end/models/ai_assistance/ai_assistance.ts

@@ -23,3 +23,6 @@ export * from './data_formatters/PerformanceTraceFormatter.js';
 export * from './data_formatters/UnitFormatters.js';
 export * from './ConversationHandler.js';
 export * from './injected.js';
+export * from './performance/AICallTree.js';
+export * from './performance/AIContext.js';
+export * from './performance/AIQueries.js';