chrome-devtools-frontend 1.0.1512349 → 1.0.1514545

package/front_end/ui/legacy/TextPrompt.ts

@@ -1,4 +1,4 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
+// Copyright 2021 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */
@@ -47,7 +47,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   private proxyElement!: HTMLElement|undefined;
   private proxyElementDisplay: string;
   private autocompletionTimeout: number;
-  private titleInternal: string;
+  #title: string;
   private queryRange: TextUtils.TextRange.TextRange|null;
   private previousText: string;
   private currentSuggestion: Suggestion|null;
@@ -57,7 +57,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   private loadCompletions!: (this: null, arg1: string, arg2: string, arg3?: boolean|undefined) => Promise<Suggestion[]>;
   private completionStopCharacters!: string;
   private usesSuggestionBuilder!: boolean;
-  private elementInternal?: Element;
+  #element?: Element;
   private boundOnKeyDown?: ((ev: KeyboardEvent) => void);
   private boundOnInput?: ((ev: Event) => void);
   private boundOnMouseWheel?: ((event: Event) => void);
@@ -70,14 +70,14 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   private blurListener?: ((arg0: Event) => void);
   private oldTabIndex?: number;
   private completeTimeout?: number;
-  private disableDefaultSuggestionForEmptyInputInternal?: boolean;
+  #disableDefaultSuggestionForEmptyInput?: boolean;
   jslogContext: string|undefined = undefined;
 
   constructor() {
     super();
     this.proxyElementDisplay = 'inline-block';
     this.autocompletionTimeout = DefaultAutocompletionTimeout;
-    this.titleInternal = '';
+    this.#title = '';
     this.queryRange = null;
     this.previousText = '';
     this.currentSuggestion = null;
@@ -110,7 +110,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
    * they should use the result of this method to attach listeners for bubbling events.
    */
   attach(element: Element): Element {
-    return this.attachInternal(element);
+    return this.#attach(element);
   }
 
   /**
@@ -120,16 +120,16 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
    * (since the "blur" event does not bubble.)
    */
   attachAndStartEditing(element: Element, blurListener: (arg0: Event) => void): Element {
-    const proxyElement = this.attachInternal(element);
+    const proxyElement = this.#attach(element);
     this.startEditing(blurListener);
     return proxyElement;
   }
 
-  private attachInternal(element: Element): Element {
+  #attach(element: Element): Element {
     if (this.proxyElement) {
       throw new Error('Cannot attach an attached TextPrompt');
     }
-    this.elementInternal = element;
+    this.#element = element;
 
     this.boundOnKeyDown = this.onKeyDown.bind(this);
     this.boundOnInput = this.onInput.bind(this);
@@ -152,34 +152,34 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
     if (this.jslogContext) {
       jslog = jslog.context(this.jslogContext);
     }
-    if (!this.elementInternal.hasAttribute('jslog')) {
-      this.elementInternal.setAttribute('jslog', `${jslog}`);
+    if (!this.#element.hasAttribute('jslog')) {
+      this.#element.setAttribute('jslog', `${jslog}`);
     }
-    this.elementInternal.classList.add('text-prompt');
-    ARIAUtils.markAsTextBox(this.elementInternal);
-    ARIAUtils.setAutocomplete(this.elementInternal, ARIAUtils.AutocompleteInteractionModel.BOTH);
-    ARIAUtils.setHasPopup(this.elementInternal, ARIAUtils.PopupRole.LIST_BOX);
-    this.elementInternal.setAttribute('contenteditable', 'plaintext-only');
+    this.#element.classList.add('text-prompt');
+    ARIAUtils.markAsTextBox(this.#element);
+    ARIAUtils.setAutocomplete(this.#element, ARIAUtils.AutocompleteInteractionModel.BOTH);
+    ARIAUtils.setHasPopup(this.#element, ARIAUtils.PopupRole.LIST_BOX);
+    this.#element.setAttribute('contenteditable', 'plaintext-only');
     this.element().addEventListener('keydown', this.boundOnKeyDown, false);
-    this.elementInternal.addEventListener('input', this.boundOnInput, false);
-    this.elementInternal.addEventListener('wheel', this.boundOnMouseWheel, false);
-    this.elementInternal.addEventListener('selectstart', this.boundClearAutocomplete, false);
-    this.elementInternal.addEventListener('blur', this.boundOnBlur, false);
+    this.#element.addEventListener('input', this.boundOnInput, false);
+    this.#element.addEventListener('wheel', this.boundOnMouseWheel, false);
+    this.#element.addEventListener('selectstart', this.boundClearAutocomplete, false);
+    this.#element.addEventListener('blur', this.boundOnBlur, false);
 
     this.suggestBox = new SuggestBox(this, 20);
 
-    if (this.titleInternal) {
-      Tooltip.install(this.proxyElement, this.titleInternal);
+    if (this.#title) {
+      Tooltip.install(this.proxyElement, this.#title);
     }
 
     return this.proxyElement;
   }
 
   element(): HTMLElement {
-    if (!this.elementInternal) {
+    if (!this.#element) {
       throw new Error('Expected an already attached element!');
     }
-    return this.elementInternal as HTMLElement;
+    return this.#element as HTMLElement;
   }
 
   detach(): void {
@@ -256,11 +256,11 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   }
 
   title(): string {
-    return this.titleInternal;
+    return this.#title;
   }
 
   setTitle(title: string): void {
-    this.titleInternal = title;
+    this.#title = title;
     if (this.proxyElement) {
       Tooltip.install(this.proxyElement, title);
     }
@@ -448,7 +448,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
       result = this.suggestBox.acceptSuggestion();
     }
     if (!result) {
-      result = this.acceptSuggestionInternal();
+      result = this.#acceptSuggestion();
     }
     if (this.usesSuggestionBuilder && result) {
       // Trigger autocompletions for text prompts using suggestion builders
@@ -543,7 +543,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   }
 
   disableDefaultSuggestionForEmptyInput(): void {
-    this.disableDefaultSuggestionForEmptyInputInternal = true;
+    this.#disableDefaultSuggestionForEmptyInput = true;
   }
 
   private boxForAnchorAtStart(selection: Selection, textRange: Range): AnchorBox {
@@ -604,7 +604,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
     this.queryRange = new TextUtils.TextRange.TextRange(
         0, beforeRange.toString().length, 0, beforeRange.toString().length + fullWordRange.toString().length);
 
-    const shouldSelect = !this.disableDefaultSuggestionForEmptyInputInternal || Boolean(this.text());
+    const shouldSelect = !this.#disableDefaultSuggestionForEmptyInput || Boolean(this.text());
     if (this.suggestBox) {
       this.suggestBox.updateSuggestions(
           this.boxForAnchorAtStart(selection, fullWordRange), completions, shouldSelect, !this.isCaretAtEndOfPrompt(),
@@ -621,10 +621,10 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   }
 
   acceptSuggestion(): void {
-    this.acceptSuggestionInternal();
+    this.#acceptSuggestion();
   }
 
-  private acceptSuggestionInternal(): boolean {
+  #acceptSuggestion(): boolean {
     if (!this.queryRange) {
       return false;
     }
@@ -696,7 +696,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
         foundNextText = true;
       }
 
-      node = node.traverseNextNode(this.elementInternal);
+      node = node.traverseNextNode(this.#element);
     }
 
     return true;

package/front_end/ui/legacy/ThrottledWidget.ts

@@ -1,4 +1,4 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

package/front_end/ui/legacy/Toolbar.ts

@@ -1,32 +1,6 @@
-/*
- * Copyright (C) 2009 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
+// Copyright 2009 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
 
 /* eslint-disable rulesdir/no-imperative-dom-api */
 
@@ -492,7 +466,7 @@ export interface ToolbarButtonOptions {
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class ToolbarItem<T = any, E extends HTMLElement = HTMLElement> extends Common.ObjectWrapper.ObjectWrapper<T> {
   element: E;
-  private visibleInternal: boolean;
+  #visible: boolean;
   enabled: boolean;
   toolbar: Toolbar|null;
   protected title?: string;
@@ -500,7 +474,7 @@ export class ToolbarItem<T = any, E extends HTMLElement = HTMLElement> extends C
   constructor(element: E) {
     super();
     this.element = element;
-    this.visibleInternal = true;
+    this.#visible = true;
     this.enabled = true;
 
     /**
@@ -537,15 +511,15 @@ export class ToolbarItem<T = any, E extends HTMLElement = HTMLElement> extends C
   }
 
   visible(): boolean {
-    return this.visibleInternal;
+    return this.#visible;
   }
 
   setVisible(x: boolean): void {
-    if (this.visibleInternal === x) {
+    if (this.#visible === x) {
       return;
     }
     this.element.classList.toggle('hidden', !x);
-    this.visibleInternal = x;
+    this.#visible = x;
     if (this.toolbar && !(this instanceof ToolbarSeparator)) {
       this.toolbar.hideSeparatorDupes();
     }
@@ -980,6 +954,7 @@ export class ToolbarMenuButton extends ToolbarItem<ToolbarButton.EventTypes> {
   private readonly contextMenuHandler: (arg0: ContextMenu) => void;
   private readonly useSoftMenu: boolean;
   private readonly keepOpen: boolean;
+  private readonly isIconDropdown: boolean;
   private triggerTimeoutId?: number;
   #triggerDelay = 200;
 
@@ -1013,6 +988,7 @@ export class ToolbarMenuButton extends ToolbarItem<ToolbarButton.EventTypes> {
     this.contextMenuHandler = contextMenuHandler;
     this.useSoftMenu = Boolean(useSoftMenu);
     this.keepOpen = Boolean(keepOpen);
+    this.isIconDropdown = Boolean(isIconDropdown);
     ARIAUtils.markAsMenuButton(this.element);
   }
 
@@ -1074,10 +1050,12 @@ export class ToolbarMenuButton extends ToolbarItem<ToolbarButton.EventTypes> {
   private trigger(event: Event): void {
     delete this.triggerTimeoutId;
 
+    const horizontalPosition =
+        this.isIconDropdown ? this.element.getBoundingClientRect().right : this.element.getBoundingClientRect().left;
     const contextMenu = new ContextMenu(event, {
       useSoftMenu: this.useSoftMenu,
       keepOpen: this.keepOpen,
-      x: this.element.getBoundingClientRect().right,
+      x: horizontalPosition,
       y: this.element.getBoundingClientRect().top + this.element.offsetHeight,
       // Without adding a delay, pointer events will be un-ignored too early, and a single click causes
       // the context menu to be closed and immediately re-opened on Windows (https://crbug.com/339560549).
@@ -1225,7 +1203,6 @@ export class ToolbarComboBox extends ToolbarItem<void, HTMLSelectElement> {
   selectedIndex(): number {
     return this.element.selectedIndex;
   }
-
 }
 
 export interface Option {
@@ -1234,12 +1211,12 @@ export interface Option {
 }
 
 export class ToolbarSettingComboBox extends ToolbarComboBox {
-  private optionsInternal: Option[];
+  #options: Option[];
   private readonly setting: Common.Settings.Setting<string>;
   private muteSettingListener?: boolean;
   constructor(options: Option[], setting: Common.Settings.Setting<string>, accessibleName: string) {
     super(null, accessibleName, undefined, setting.name);
-    this.optionsInternal = options;
+    this.#options = options;
     this.setting = setting;
     this.element.addEventListener('change', this.onSelectValueChange.bind(this), false);
     this.setOptions(options);
@@ -1247,7 +1224,7 @@ export class ToolbarSettingComboBox extends ToolbarComboBox {
   }
 
   setOptions(options: Option[]): void {
-    this.optionsInternal = options;
+    this.#options = options;
     this.element.removeChildren();
     for (let i = 0; i < options.length; ++i) {
       const dataOption = options[i];
@@ -1260,7 +1237,7 @@ export class ToolbarSettingComboBox extends ToolbarComboBox {
   }
 
   value(): string {
-    return this.optionsInternal[this.selectedIndex()].value;
+    return this.#options[this.selectedIndex()].value;
   }
 
   override select(option: Element): void {
@@ -1270,7 +1247,7 @@ export class ToolbarSettingComboBox extends ToolbarComboBox {
 
   override setSelectedIndex(index: number): void {
     super.setSelectedIndex(index);
-    const option = this.optionsInternal.at(index);
+    const option = this.#options.at(index);
     if (option) {
       this.setTitle(option.label);
     }
@@ -1294,8 +1271,8 @@ export class ToolbarSettingComboBox extends ToolbarComboBox {
     }
 
     const value = this.setting.get();
-    for (let i = 0; i < this.optionsInternal.length; ++i) {
-      if (value === this.optionsInternal[i].value) {
+    for (let i = 0; i < this.#options.length; ++i) {
+      if (value === this.#options[i].value) {
         this.setSelectedIndex(i);
         break;
       }
@@ -1306,7 +1283,7 @@ export class ToolbarSettingComboBox extends ToolbarComboBox {
    * Run when the user interacts with the <select> element.
    */
   private onSelectValueChange(_event: Event): void {
-    const option = this.optionsInternal[this.selectedIndex()];
+    const option = this.#options[this.selectedIndex()];
     this.muteSettingListener = true;
     this.setting.set(option.value);
     this.muteSettingListener = false;

package/front_end/ui/legacy/Tooltip.ts

@@ -1,4 +1,4 @@
-// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

package/front_end/ui/legacy/Treeoutline.ts

@@ -1,4 +1,4 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
+// Copyright 2021 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */

package/front_end/ui/legacy/UIUtils.ts

@@ -1,4 +1,4 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
+// Copyright 2021 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */
@@ -965,13 +965,6 @@ export function endBatchUpdate(): void {
   }
 }
 
-export function invokeOnceAfterBatchUpdate(object: Object, method: () => void): void {
-  if (!postUpdateHandlers) {
-    postUpdateHandlers = new InvokeOnceHandlers(true);
-  }
-  postUpdateHandlers.add(object, method);
-}
-
 export function animateFunction(
     window: Window, func: (...args: any[]) => void, params: Array<{
       from: number,

package/front_end/ui/legacy/View.ts

@@ -1,4 +1,4 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 

package/front_end/ui/legacy/ViewManager.ts

@@ -1,4 +1,4 @@
-// Copyright 2019 The Chromium Authors. All rights reserved.
+// Copyright 2019 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */
@@ -583,16 +583,16 @@ const expandableContainerForView = new WeakMap<View, ExpandableContainerWidget>(
 class Location {
   protected readonly manager: ViewManager;
   private readonly revealCallback: (() => void)|undefined;
-  private readonly widgetInternal: Widget;
+  readonly #widget: Widget;
 
   constructor(manager: ViewManager, widget: Widget, revealCallback?: (() => void)) {
     this.manager = manager;
     this.revealCallback = revealCallback;
-    this.widgetInternal = widget;
+    this.#widget = widget;
   }
 
   widget(): Widget {
-    return this.widgetInternal;
+    return this.#widget;
   }
 
   reveal(): void {
@@ -623,7 +623,7 @@ type CloseableTabSetting = Record<string, boolean>;
 type TabOrderSetting = Record<string, number>;
 
 class TabbedLocation extends Location implements TabbedViewLocation {
-  private tabbedPaneInternal: TabbedPane;
+  #tabbedPane: TabbedPane;
   private readonly location: string;
   private readonly allowReorder: boolean|undefined;
   private readonly closeableTabSetting: Common.Settings.Setting<CloseableTabSetting>;
@@ -642,13 +642,12 @@ class TabbedLocation extends Location implements TabbedViewLocation {
 
     super(manager, tabbedPane, revealCallback);
     this.location = location;
-    this.tabbedPaneInternal = tabbedPane;
+    this.#tabbedPane = tabbedPane;
     this.allowReorder = allowReorder;
 
-    this.tabbedPaneInternal.addEventListener(TabbedPaneEvents.TabSelected, this.tabSelected, this);
-    this.tabbedPaneInternal.addEventListener(TabbedPaneEvents.TabClosed, this.tabClosed, this);
-    this.tabbedPaneInternal.addEventListener(
-        TabbedPaneEvents.PaneVisibilityChanged, this.tabbedPaneVisibilityChanged, this);
+    this.#tabbedPane.addEventListener(TabbedPaneEvents.TabSelected, this.tabSelected, this);
+    this.#tabbedPane.addEventListener(TabbedPaneEvents.TabClosed, this.tabClosed, this);
+    this.#tabbedPane.addEventListener(TabbedPaneEvents.PaneVisibilityChanged, this.tabbedPaneVisibilityChanged, this);
 
     this.closeableTabSetting = Common.Settings.Settings.instance().createSetting('closeable-tabs', {});
     // As we give tabs the capability to be closed we also need to add them to the setting so they are still open
@@ -656,7 +655,7 @@ class TabbedLocation extends Location implements TabbedViewLocation {
     this.setOrUpdateCloseableTabsSetting();
 
     this.tabOrderSetting = Common.Settings.Settings.instance().createSetting(location + '-tab-order', {});
-    this.tabbedPaneInternal.addEventListener(TabbedPaneEvents.TabOrderChanged, this.persistTabOrder, this);
+    this.#tabbedPane.addEventListener(TabbedPaneEvents.TabOrderChanged, this.persistTabOrder, this);
     if (restoreSelection) {
       this.lastSelectedTabSetting = Common.Settings.Settings.instance().createSetting(location + '-selected-tab', '');
     }
@@ -678,17 +677,17 @@ class TabbedLocation extends Location implements TabbedViewLocation {
   }
 
   override widget(): Widget {
-    return this.tabbedPaneInternal;
+    return this.#tabbedPane;
   }
 
   tabbedPane(): TabbedPane {
-    return this.tabbedPaneInternal;
+    return this.#tabbedPane;
   }
 
   enableMoreTabsButton(): ToolbarMenuButton {
     const moreTabsButton = new ToolbarMenuButton(
         this.appendTabsToMenu.bind(this), /* isIconDropdown */ true, undefined, 'more-tabs', 'dots-vertical');
-    this.tabbedPaneInternal.leftToolbar().appendToolbarItem(moreTabsButton);
+    this.#tabbedPane.leftToolbar().appendToolbarItem(moreTabsButton);
     return moreTabsButton;
   }
 
@@ -720,9 +719,9 @@ class TabbedLocation extends Location implements TabbedViewLocation {
 
     // If a default tab was provided we open or select it
     if (this.defaultTab) {
-      if (this.tabbedPaneInternal.hasTab(this.defaultTab)) {
+      if (this.#tabbedPane.hasTab(this.defaultTab)) {
         // If the tabbed pane already has the tab we just have to select it
-        this.tabbedPaneInternal.selectTab(this.defaultTab);
+        this.#tabbedPane.selectTab(this.defaultTab);
       } else {
         // If the tab is not present already it can be because:
         // it doesn't correspond to this tabbed location
@@ -733,8 +732,8 @@ class TabbedLocation extends Location implements TabbedViewLocation {
           void this.showView(view);
         }
       }
-    } else if (this.lastSelectedTabSetting && this.tabbedPaneInternal.hasTab(this.lastSelectedTabSetting.get())) {
-      this.tabbedPaneInternal.selectTab(this.lastSelectedTabSetting.get());
+    } else if (this.lastSelectedTabSetting && this.#tabbedPane.hasTab(this.lastSelectedTabSetting.get())) {
+      this.#tabbedPane.selectTab(this.lastSelectedTabSetting.get());
     }
   }
 
@@ -790,18 +789,18 @@ class TabbedLocation extends Location implements TabbedViewLocation {
   }
 
   private appendTab(view: View, index?: number): void {
-    this.tabbedPaneInternal.appendTab(
+    this.#tabbedPane.appendTab(
         view.viewId(), view.title(), new ContainerWidget(view), undefined, false,
         view.isCloseable() || view.isTransient(), view.isPreviewFeature(), index);
     const iconName = view.iconName();
     if (iconName) {
       const icon = IconButton.Icon.create(iconName);
-      this.tabbedPaneInternal.setTabIcon(view.viewId(), icon);
+      this.#tabbedPane.setTabIcon(view.viewId(), icon);
     }
   }
 
   appendView(view: View, insertBefore?: View|null): void {
-    if (this.tabbedPaneInternal.hasTab(view.viewId())) {
+    if (this.#tabbedPane.hasTab(view.viewId())) {
       return;
     }
     const oldLocation = locationForView.get(view);
@@ -812,7 +811,7 @@ class TabbedLocation extends Location implements TabbedViewLocation {
     this.manager.views.set(view.viewId(), view);
     this.views.set(view.viewId(), view);
     let index: number|undefined = undefined;
-    const tabIds = this.tabbedPaneInternal.tabIds();
+    const tabIds = this.#tabbedPane.tabIds();
     if (this.allowReorder) {
       const orderSetting = this.tabOrderSetting.get();
       const order = orderSetting[view.viewId()];
@@ -848,38 +847,38 @@ class TabbedLocation extends Location implements TabbedViewLocation {
       shouldSelectTab: boolean|undefined = true): Promise<void> {
     this.appendView(view, insertBefore);
     if (shouldSelectTab) {
-      this.tabbedPaneInternal.selectTab(view.viewId(), userGesture);
+      this.#tabbedPane.selectTab(view.viewId(), userGesture);
     }
     if (!omitFocus) {
-      this.tabbedPaneInternal.focus();
+      this.#tabbedPane.focus();
     }
-    const widget = (this.tabbedPaneInternal.tabView(view.viewId()) as ContainerWidget);
+    const widget = (this.#tabbedPane.tabView(view.viewId()) as ContainerWidget);
     await widget.materialize();
   }
 
   override removeView(view: View): void {
-    if (!this.tabbedPaneInternal.hasTab(view.viewId())) {
+    if (!this.#tabbedPane.hasTab(view.viewId())) {
       return;
     }
 
     locationForView.delete(view);
     this.manager.views.delete(view.viewId());
-    this.tabbedPaneInternal.closeTab(view.viewId());
+    this.#tabbedPane.closeTab(view.viewId());
     this.views.delete(view.viewId());
   }
 
   override isViewVisible(view: View): boolean {
-    return this.tabbedPaneInternal.isShowing() && this.tabbedPaneInternal?.selectedTabId === view.viewId();
+    return this.#tabbedPane.isShowing() && this.#tabbedPane?.selectedTabId === view.viewId();
   }
 
   private tabbedPaneVisibilityChanged(event: Common.EventTarget.EventTargetEvent<{isVisible: boolean}>): void {
-    if (!this.tabbedPaneInternal.selectedTabId) {
+    if (!this.#tabbedPane.selectedTabId) {
       return;
     }
     this.manager.dispatchEventToListeners(Events.VIEW_VISIBILITY_CHANGED, {
       location: this.location,
-      revealedViewId: event.data.isVisible ? this.tabbedPaneInternal.selectedTabId : undefined,
-      hiddenViewId: event.data.isVisible ? undefined : this.tabbedPaneInternal.selectedTabId,
+      revealedViewId: event.data.isVisible ? this.#tabbedPane.selectedTabId : undefined,
+      hiddenViewId: event.data.isVisible ? undefined : this.#tabbedPane.selectedTabId,
     });
   }
 
@@ -909,7 +908,7 @@ class TabbedLocation extends Location implements TabbedViewLocation {
   }
 
   private persistTabOrder(): void {
-    const tabIds = this.tabbedPaneInternal.tabIds();
+    const tabIds = this.#tabbedPane.tabIds();
     const tabOrders: Record<string, number> = {};
     for (let i = 0; i < tabIds.length; i++) {
       tabOrders[tabIds[i]] = (i + 1) * TabbedLocation.orderStep;

package/front_end/ui/legacy/ViewRegistration.ts

@@ -1,5 +1,5 @@
 
-// Copyright 2020 The Chromium Authors. All rights reserved.
+// Copyright 2020 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 import * as i18n from '../../core/i18n/i18n.js';

package/front_end/ui/legacy/Widget.ts

@@ -1,4 +1,4 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
+// Copyright 2021 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */
@@ -497,7 +497,7 @@ export class Widget {
       }
       this.attach(currentWidget);
     }
-    this.showWidgetInternal(parentElement, insertBefore);
+    this.#showWidget(parentElement, insertBefore);
   }
 
   private attach(parentWidget: Widget): void {
@@ -519,10 +519,10 @@ export class Widget {
     if (!this.element.parentElement) {
       throw new Error('Attempt to show widget that is not hidden using hideWidget().');
     }
-    this.showWidgetInternal(this.element.parentElement, this.element.nextSibling);
+    this.#showWidget(this.element.parentElement, this.element.nextSibling);
   }
 
-  private showWidgetInternal(parentElement: Element, insertBefore?: Node|null): void {
+  #showWidget(parentElement: Element, insertBefore?: Node|null): void {
     let currentParent: Element|null = parentElement;
     while (currentParent && !widgetMap.get(currentParent)) {
       currentParent = currentParent.parentElementOrShadowHost();
@@ -576,10 +576,10 @@ export class Widget {
     if (!this.#visible) {
       return;
     }
-    this.hideWidgetInternal(false);
+    this.#hideWidget(false);
   }
 
-  private hideWidgetInternal(removeFromDOM: boolean): void {
+  #hideWidget(removeFromDOM: boolean): void {
     this.#visible = false;
     const {parentElement} = this.element;
 
@@ -627,7 +627,7 @@ export class Widget {
     // responsibility for the consequences.
     const removeFromDOM = overrideHideOnDetach || !this.shouldHideOnDetach();
     if (this.#visible) {
-      this.hideWidgetInternal(removeFromDOM);
+      this.#hideWidget(removeFromDOM);
     } else if (removeFromDOM) {
       const {parentElement} = this.element;
       if (parentElement) {

package/front_end/ui/legacy/XElement.ts

@@ -1,4 +1,4 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
+// Copyright 2017 The Chromium Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.