chrome-devtools-frontend 1.0.1512147 → 1.0.1513662

package/front_end/core/sdk/CSSStyleSheetHeader.ts

@@ -29,7 +29,7 @@ const str_ = i18n.i18n.registerUIStrings('core/sdk/CSSStyleSheetHeader.ts', UISt
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentProvider, FrameAssociated {
-  #cssModelInternal: CSSModel;
+  #cssModel: CSSModel;
   id: Protocol.CSS.StyleSheetId;
   frameId: Protocol.Page.FrameId;
   sourceURL: Platform.DevToolsPath.UrlString;
@@ -48,10 +48,10 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
   ownerNode: DeferredDOMNode|undefined;
   sourceMapURL: Platform.DevToolsPath.UrlString|undefined;
   readonly loadingFailed: boolean;
-  #originalContentProviderInternal: TextUtils.StaticContentProvider.StaticContentProvider|null;
+  #originalContentProvider: TextUtils.StaticContentProvider.StaticContentProvider|null;
 
   constructor(cssModel: CSSModel, payload: Protocol.CSS.CSSStyleSheetHeader) {
-    this.#cssModelInternal = cssModel;
+    this.#cssModel = cssModel;
     this.id = payload.styleSheetId;
     this.frameId = payload.frameId;
     this.sourceURL = payload.sourceURL as Platform.DevToolsPath.UrlString;
@@ -72,22 +72,22 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
     }
     this.sourceMapURL = payload.sourceMapURL as Platform.DevToolsPath.UrlString;
     this.loadingFailed = payload.loadingFailed ?? false;
-    this.#originalContentProviderInternal = null;
+    this.#originalContentProvider = null;
   }
 
   originalContentProvider(): TextUtils.ContentProvider.ContentProvider {
-    if (!this.#originalContentProviderInternal) {
+    if (!this.#originalContentProvider) {
       const lazyContent = (async(): Promise<TextUtils.ContentData.ContentDataOrError> => {
-        const originalText = await this.#cssModelInternal.originalStyleSheetText(this);
+        const originalText = await this.#cssModel.originalStyleSheetText(this);
         if (originalText === null) {
           return {error: i18nString(UIStrings.couldNotFindTheOriginalStyle)};
         }
         return new TextUtils.ContentData.ContentData(originalText, /* isBase64=*/ false, 'text/css');
       });
-      this.#originalContentProviderInternal =
+      this.#originalContentProvider =
           new TextUtils.StaticContentProvider.StaticContentProvider(this.contentURL(), this.contentType(), lazyContent);
     }
-    return this.#originalContentProviderInternal;
+    return this.#originalContentProvider;
   }
 
   setSourceMapURL(sourceMapURL?: Platform.DevToolsPath.UrlString): void {
@@ -95,11 +95,11 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
   }
 
   cssModel(): CSSModel {
-    return this.#cssModelInternal;
+    return this.#cssModel;
   }
 
   isAnonymousInlineStyleSheet(): boolean {
-    return !this.resourceURL() && !this.#cssModelInternal.sourceMapManager().sourceMapForClient(this);
+    return !this.resourceURL() && !this.#cssModel.sourceMapManager().sourceMapForClient(this);
   }
 
   isConstructedByNew(): boolean {
@@ -111,7 +111,7 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
   }
 
   private getFrameURLPath(): string {
-    const model = this.#cssModelInternal.target().model(ResourceTreeModel);
+    const model = this.#cssModel.target().model(ResourceTreeModel);
     console.assert(Boolean(model));
     if (!model) {
       return '';
@@ -165,7 +165,7 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
   }
 
   async requestContentData(): Promise<TextUtils.ContentData.ContentDataOrError> {
-    const cssText = await this.#cssModelInternal.getStyleSheetText(this.id);
+    const cssText = await this.#cssModel.getStyleSheetText(this.id);
     if (cssText === null) {
       return {error: i18nString(UIStrings.thereWasAnErrorRetrievingThe)};
     }
@@ -184,7 +184,7 @@ export class CSSStyleSheetHeader implements TextUtils.ContentProvider.ContentPro
 
   createPageResourceLoadInitiator(): PageResourceLoadInitiator {
     return {
-      target: this.#cssModelInternal.target(),
+      target: this.#cssModel.target(),
       frameId: this.frameId,
       initiatorUrl: this.hasSourceURL ? Platform.DevToolsPath.EmptyUrlString : this.sourceURL,
     };

package/front_end/core/sdk/CategorizedBreakpoint.ts

@@ -42,12 +42,12 @@ export class CategorizedBreakpoint {
   readonly name: string;
 
   readonly #category: Category;
-  private enabledInternal: boolean;
+  #enabled: boolean;
 
   constructor(category: Category, name: string) {
     this.#category = category;
     this.name = name;
-    this.enabledInternal = false;
+    this.#enabled = false;
   }
 
   category(): Category {
@@ -55,10 +55,10 @@ export class CategorizedBreakpoint {
   }
 
   enabled(): boolean {
-    return this.enabledInternal;
+    return this.#enabled;
   }
 
   setEnabled(enabled: boolean): void {
-    this.enabledInternal = enabled;
+    this.#enabled = enabled;
   }
 }

package/front_end/core/sdk/ChildTargetManager.ts

@@ -31,7 +31,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   readonly #targetManager: TargetManager;
   #parentTarget: Target;
   readonly #targetAgent: ProtocolProxyApi.TargetApi;
-  readonly #targetInfosInternal = new Map<Protocol.Target.TargetID, Protocol.Target.TargetInfo>();
+  readonly #targetInfos = new Map<Protocol.Target.TargetID, Protocol.Target.TargetInfo>();
   readonly #childTargetsBySessionId = new Map<Protocol.Target.SessionID, Target>();
   readonly #childTargetsById = new Map<Protocol.Target.TargetID|'main', Target>();
   readonly #parallelConnections = new Map<string, ProtocolClient.InspectorBackend.Connection>();
@@ -88,13 +88,13 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   }
 
   targetCreated({targetInfo}: Protocol.Target.TargetCreatedEvent): void {
-    this.#targetInfosInternal.set(targetInfo.targetId, targetInfo);
+    this.#targetInfos.set(targetInfo.targetId, targetInfo);
     this.fireAvailableTargetsChanged();
     this.dispatchEventToListeners(Events.TARGET_CREATED, targetInfo);
   }
 
   targetInfoChanged({targetInfo}: Protocol.Target.TargetInfoChangedEvent): void {
-    this.#targetInfosInternal.set(targetInfo.targetId, targetInfo);
+    this.#targetInfos.set(targetInfo.targetId, targetInfo);
     const target = this.#childTargetsById.get(targetInfo.targetId);
     if (target) {
       void target.setHasCrashed(false);
@@ -114,7 +114,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   }
 
   targetDestroyed({targetId}: Protocol.Target.TargetDestroyedEvent): void {
-    this.#targetInfosInternal.delete(targetId);
+    this.#targetInfos.delete(targetId);
     this.fireAvailableTargetsChanged();
     this.dispatchEventToListeners(Events.TARGET_DESTROYED, targetId);
   }
@@ -128,7 +128,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
 
   private fireAvailableTargetsChanged(): void {
     TargetManager.instance().dispatchEventToListeners(
-        TargetManagerEvents.AVAILABLE_TARGETS_CHANGED, [...this.#targetInfosInternal.values()]);
+        TargetManagerEvents.AVAILABLE_TARGETS_CHANGED, [...this.#targetInfos.values()]);
   }
 
   async getParentTargetId(): Promise<Protocol.Target.TargetID> {
@@ -253,7 +253,7 @@ export class ChildTargetManager extends SDKModel<EventTypes> implements Protocol
   }
 
   targetInfos(): Protocol.Target.TargetInfo[] {
-    return Array.from(this.#targetInfosInternal.values());
+    return Array.from(this.#targetInfos.values());
   }
 
   private static lastAnonymousTargetId = 0;

package/front_end/core/sdk/CompilerSourceMappingContentProvider.ts

@@ -49,14 +49,14 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class CompilerSourceMappingContentProvider implements TextUtils.ContentProvider.ContentProvider {
   readonly #sourceURL: Platform.DevToolsPath.UrlString;
-  readonly #contentTypeInternal: Common.ResourceType.ResourceType;
+  readonly #contentType: Common.ResourceType.ResourceType;
   readonly #initiator: PageResourceLoadInitiator;
 
   constructor(
       sourceURL: Platform.DevToolsPath.UrlString, contentType: Common.ResourceType.ResourceType,
       initiator: PageResourceLoadInitiator) {
     this.#sourceURL = sourceURL;
-    this.#contentTypeInternal = contentType;
+    this.#contentType = contentType;
     this.#initiator = initiator;
   }
 
@@ -65,14 +65,14 @@ export class CompilerSourceMappingContentProvider implements TextUtils.ContentPr
   }
 
   contentType(): Common.ResourceType.ResourceType {
-    return this.#contentTypeInternal;
+    return this.#contentType;
   }
 
   async requestContentData(): Promise<TextUtils.ContentData.ContentDataOrError> {
     try {
       const {content} = await PageResourceLoader.instance().loadResource(this.#sourceURL, this.#initiator);
       return new TextUtils.ContentData.ContentData(
-          content, /* isBase64=*/ false, this.#contentTypeInternal.canonicalMimeType());
+          content, /* isBase64=*/ false, this.#contentType.canonicalMimeType());
     } catch (e) {
       const error = i18nString(UIStrings.couldNotLoadContentForSS, {PH1: this.#sourceURL, PH2: e.message});
       console.error(error);

package/front_end/core/sdk/ConsoleModel.ts

@@ -97,12 +97,12 @@ const str_ = i18n.i18n.registerUIStrings('core/sdk/ConsoleModel.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class ConsoleModel extends SDKModel<EventTypes> {
-  #messagesInternal: ConsoleMessage[] = [];
+  #messages: ConsoleMessage[] = [];
   readonly #messagesByTimestamp = new Platform.MapUtilities.Multimap<number, ConsoleMessage>();
   readonly #messageByExceptionId = new Map<RuntimeModel, Map<number, ConsoleMessage>>();
-  #warningsInternal = 0;
-  #errorsInternal = 0;
-  #violationsInternal = 0;
+  #warnings = 0;
+  #errors = 0;
+  #violations = 0;
   #pageLoadSequenceNumber = 0;
   readonly #targetListeners = new WeakMap<Target, Common.EventTarget.EventDescriptor[]>();
 
@@ -207,7 +207,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
       this.clearIfNecessary();
     }
 
-    this.#messagesInternal.push(msg);
+    this.#messages.push(msg);
     this.#messagesByTimestamp.set(msg.timestamp, msg);
     const runtimeModel = msg.runtimeModel();
     const exceptionId = msg.getExceptionId();
@@ -241,7 +241,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
     if (!exceptionMessage) {
       return;
     }
-    this.#errorsInternal--;
+    this.#errors--;
     exceptionMessage.level = Protocol.Log.LogEntryLevel.Verbose;
     this.dispatchEventToListeners(Events.MessageUpdated, exceptionMessage);
   }
@@ -361,21 +361,21 @@ export class ConsoleModel extends SDKModel<EventTypes> {
 
   private incrementErrorWarningCount(msg: ConsoleMessage): void {
     if (msg.source === Protocol.Log.LogEntrySource.Violation) {
-      this.#violationsInternal++;
+      this.#violations++;
       return;
     }
     switch (msg.level) {
       case Protocol.Log.LogEntryLevel.Warning:
-        this.#warningsInternal++;
+        this.#warnings++;
         break;
       case Protocol.Log.LogEntryLevel.Error:
-        this.#errorsInternal++;
+        this.#errors++;
         break;
     }
   }
 
   messages(): ConsoleMessage[] {
-    return this.#messagesInternal;
+    return this.#messages;
   }
 
   // messages[] are not ordered by timestamp.
@@ -403,17 +403,17 @@ export class ConsoleModel extends SDKModel<EventTypes> {
   }
 
   private clear(): void {
-    this.#messagesInternal = [];
+    this.#messages = [];
     this.#messagesByTimestamp.clear();
     this.#messageByExceptionId.clear();
-    this.#errorsInternal = 0;
-    this.#warningsInternal = 0;
-    this.#violationsInternal = 0;
+    this.#errors = 0;
+    this.#warnings = 0;
+    this.#violations = 0;
     this.dispatchEventToListeners(Events.ConsoleCleared);
   }
 
   errors(): number {
-    return this.#errorsInternal;
+    return this.#errors;
   }
 
   static allErrors(): number {
@@ -425,7 +425,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
   }
 
   warnings(): number {
-    return this.#warningsInternal;
+    return this.#warnings;
   }
 
   static allWarnings(): number {
@@ -437,7 +437,7 @@ export class ConsoleModel extends SDKModel<EventTypes> {
   }
 
   violations(): number {
-    return this.#violationsInternal;
+    return this.#violations;
   }
 
   async saveToTempVariable(currentExecutionContext: ExecutionContext|null, remoteObject: RemoteObject|null):
@@ -575,7 +575,7 @@ export interface ConsoleMessageDetails {
 }
 
 export class ConsoleMessage {
-  readonly #runtimeModelInternal: RuntimeModel|null;
+  readonly #runtimeModel: RuntimeModel|null;
   source: MessageSource;
   level: Protocol.Log.LogEntryLevel|null;
   messageText: string;
@@ -610,7 +610,7 @@ export class ConsoleMessage {
   constructor(
       runtimeModel: RuntimeModel|null, source: MessageSource, level: Protocol.Log.LogEntryLevel|null,
       messageText: string, details?: ConsoleMessageDetails) {
-    this.#runtimeModelInternal = runtimeModel;
+    this.#runtimeModel = runtimeModel;
     this.source = source;
     this.level = (level);
     this.messageText = messageText;
@@ -628,11 +628,11 @@ export class ConsoleMessage {
     this.category = details?.category;
     this.isCookieReportIssue = Boolean(details?.isCookieReportIssue);
 
-    if (!this.#executionContextId && this.#runtimeModelInternal) {
+    if (!this.#executionContextId && this.#runtimeModel) {
       if (this.scriptId) {
-        this.#executionContextId = this.#runtimeModelInternal.executionContextIdForScriptId(this.scriptId);
+        this.#executionContextId = this.#runtimeModel.executionContextIdForScriptId(this.scriptId);
       } else if (this.stackTrace) {
-        this.#executionContextId = this.#runtimeModelInternal.executionContextForStackTrace(this.stackTrace);
+        this.#executionContextId = this.#runtimeModel.executionContextForStackTrace(this.stackTrace);
       }
     }
 
@@ -680,11 +680,11 @@ export class ConsoleMessage {
   }
 
   runtimeModel(): RuntimeModel|null {
-    return this.#runtimeModelInternal;
+    return this.#runtimeModel;
   }
 
   target(): Target|null {
-    return this.#runtimeModelInternal ? this.#runtimeModelInternal.target() : null;
+    return this.#runtimeModel ? this.#runtimeModel.target() : null;
   }
 
   setOriginatingMessage(originatingMessage: ConsoleMessage): void {

package/front_end/core/sdk/Cookie.ts

@@ -8,22 +8,22 @@ import type * as Platform from '../platform/platform.js';
 const OPAQUE_PARTITION_KEY = '<opaque>';
 
 export class Cookie {
-  readonly #nameInternal: string;
-  readonly #valueInternal: string;
-  readonly #typeInternal: Type|null|undefined;
+  readonly #name: string;
+  readonly #value: string;
+  readonly #type: Type|null|undefined;
   #attributes = new Map<Attribute, string|number|boolean|undefined>();
-  #sizeInternal = 0;
-  #priorityInternal: Protocol.Network.CookiePriority;
+  #size = 0;
+  #priority: Protocol.Network.CookiePriority;
   #cookieLine: string|null = null;
   #partitionKey: Protocol.Network.CookiePartitionKey|undefined;
 
   constructor(
       name: string, value: string, type?: Type|null, priority?: Protocol.Network.CookiePriority,
       partitionKey?: Protocol.Network.CookiePartitionKey) {
-    this.#nameInternal = name;
-    this.#valueInternal = value;
-    this.#typeInternal = type;
-    this.#priorityInternal = (priority || 'Medium' as Protocol.Network.CookiePriority);
+    this.#name = name;
+    this.#value = value;
+    this.#type = type;
+    this.#priority = (priority || 'Medium' as Protocol.Network.CookiePriority);
     this.#partitionKey = partitionKey;
   }
 
@@ -70,15 +70,15 @@ export class Cookie {
   }
 
   name(): string {
-    return this.#nameInternal;
+    return this.#name;
   }
 
   value(): string {
-    return this.#valueInternal;
+    return this.#value;
   }
 
   type(): Type|null|undefined {
-    return this.#typeInternal;
+    return this.#type;
   }
 
   httpOnly(): boolean {
@@ -148,7 +148,7 @@ export class Cookie {
   }
 
   priority(): Protocol.Network.CookiePriority {
-    return this.#priorityInternal;
+    return this.#priority;
   }
 
   session(): boolean {
@@ -182,7 +182,7 @@ export class Cookie {
   }
 
   size(): number {
-    return this.#sizeInternal;
+    return this.#size;
   }
 
   /**
@@ -205,7 +205,7 @@ export class Cookie {
   }
 
   setSize(size: number): void {
-    this.#sizeInternal = size;
+    this.#size = size;
   }
 
   expiresDate(requestDate: Date): Date|null {
@@ -227,7 +227,7 @@ export class Cookie {
     }
     switch (key) {
       case Attribute.PRIORITY:
-        this.#priorityInternal = (value as Protocol.Network.CookiePriority);
+        this.#priority = (value as Protocol.Network.CookiePriority);
         break;
       default:
         this.#attributes.set(key, value);

package/front_end/core/sdk/CookieParser.ts

@@ -39,7 +39,7 @@ import {Attribute, Cookie, Type} from './Cookie.js';
 
 export class CookieParser {
   readonly #domain: string|undefined;
-  #cookiesInternal: Cookie[];
+  #cookies: Cookie[];
   #input!: string|undefined;
   #originalInputLength: number;
   #lastCookie?: Cookie|null;
@@ -52,7 +52,7 @@ export class CookieParser {
       this.#domain = domain.toLowerCase().replace(/^\./, '');
     }
 
-    this.#cookiesInternal = [];
+    this.#cookies = [];
 
     this.#originalInputLength = 0;
   }
@@ -100,7 +100,7 @@ export class CookieParser {
   }
 
   cookies(): Cookie[] {
-    return this.#cookiesInternal;
+    return this.#cookies;
   }
 
   parseSetCookie(setCookieHeader: string|undefined): Cookie[]|null {
@@ -118,7 +118,7 @@ export class CookieParser {
       }
     }
     this.flushCookie();
-    return this.#cookiesInternal;
+    return this.#cookies;
   }
 
   private initialize(headerValue: string|undefined): boolean {
@@ -128,7 +128,7 @@ export class CookieParser {
       return false;
     }
 
-    this.#cookiesInternal = [];
+    this.#cookies = [];
     this.#lastCookie = null;
     this.#lastCookieLine = '';
     this.#originalInputLength = (this.#input as string).length;
@@ -195,7 +195,7 @@ export class CookieParser {
       this.#lastCookie.addAttribute(Attribute.DOMAIN, this.#domain);
     }
     this.#lastCookiePosition = keyValue.position;
-    this.#cookiesInternal.push(this.#lastCookie);
+    this.#cookies.push(this.#lastCookie);
   }
 }