chrome-devtools-frontend 1.0.1506453 → 1.0.1510180

package/scripts/javascript_natives/index.js

@@ -1,105 +0,0 @@
-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as fs from 'fs';
-import glob from 'glob';
-import ts from 'typescript';
-import * as WebIDL2 from 'webidl2';
-
-import {parseTSFunction, postProcess, walkRoot} from './helpers.js';
-
-if (process.argv.length !== 4) {
-  throw new Error('Please provide path to chromium/src and devtools-frontend');
-}
-
-const chromiumSource = process.argv[2];
-const REL_TS_LIB_PATH = '/node_modules/typescript/lib/';
-const typescriptSources =
-    fs.readdirSync(process.argv[3] + REL_TS_LIB_PATH).map(name => process.argv[3] + REL_TS_LIB_PATH + name);
-
-const program = ts.createProgram({
-  rootNames: typescriptSources,
-  options: {noResolve: true, types: []},
-});
-
-for (const file of program.getSourceFiles()) {
-  ts.forEachChild(file, node => {
-    if (node.kind === ts.SyntaxKind.InterfaceDeclaration) {
-      for (const member of node.members) {
-        if (member.kind === ts.SyntaxKind.MethodSignature) {
-          parseTSFunction(member, node);
-        }
-      }
-    }
-    if (node.kind === ts.SyntaxKind.FunctionDeclaration) {
-      parseTSFunction(node, {name: {text: 'Window'}});
-    }
-  });
-}
-
-// Assume the DevTools front-end repository is at
-// `devtools/devtools-frontend`, where `devtools` is on the same level
-// as `chromium`. This matches `scripts/npm_test.js`.
-const files = glob.sync(
-    `${chromiumSource}/third_party/blink/renderer/+(core|modules)/**/*.idl`,
-    {cwd: process.env.PWD},
-);
-
-for (const file of files) {
-  if (file.includes('testing')) {
-    continue;
-  }
-  const data = fs.readFileSync(file, 'utf8');
-  const lines = data.split('\n');
-  const newLines = [];
-  for (const line of lines) {
-    if (!line.includes(' attribute ')) {
-      newLines.push(line);
-    }
-  }
-
-  try {
-    WebIDL2.parse(newLines.join('\n')).forEach(walkRoot);
-  } catch {
-    // console.error(file);
-  }
-
-  // Source for Console spec: https://console.spec.whatwg.org/#idl-index
-  WebIDL2
-      .parse(
-          `
-[Exposed=(Window,Worker,Worklet)]
-namespace console { // but see namespace object requirements below
-  // Logging
-  undefined assert(optional boolean condition = false, any... data);
-  undefined clear();
-  undefined debug(any... data);
-  undefined error(any... data);
-  undefined info(any... data);
-  undefined log(any... data);
-  undefined table(optional any tabularData, optional sequence<DOMString> properties);
-  undefined trace(any... data);
-  undefined warn(any... data);
-  undefined dir(optional any item, optional object? options);
-  undefined dirxml(any... data);
-
-  // Counting
-  undefined count(optional DOMString label = "default");
-  undefined countReset(optional DOMString label = "default");
-
-  // Grouping
-  undefined group(any... data);
-  undefined groupCollapsed(any... data);
-  undefined groupEnd();
-
-  // Timing
-  undefined time(optional DOMString label = "default");
-  undefined timeLog(optional DOMString label = "default", any... data);
-  undefined timeEnd(optional DOMString label = "default");
-};
-`,
-          )
-      .forEach(walkRoot);
-}
-postProcess();

package/scripts/javascript_natives/package.json

@@ -1,9 +0,0 @@
-{
-  "private": true,
-  "main": "index.js",
-  "scripts": {
-    "start": "node index.js",
-    "test": "mocha tests.js"
-  },
-  "type": "module"
-}

package/scripts/javascript_natives/test.d.ts

@@ -1,13 +0,0 @@
-// Copyright 2025 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-interface Array<T> {
-  at(index: number): T|undefined;
-  diffSig(oneSig: number): T|undefined;
-}
-
-interface ReadonlyArray<T> {
-  at(index: number): T|undefined;
-  diffSig(twoSig: number): T|undefined;
-}

package/scripts/javascript_natives/tests.js

@@ -1,195 +0,0 @@
-// Copyright 2022 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as assert from 'assert';
-import ts from 'typescript';
-import * as WebIDL2 from 'webidl2';
-
-import {clearState, parseTSFunction, postProcess, walkRoot} from './helpers.js';
-
-describe('NativeFunction signature generation', function() {
-  this.afterEach(() => {
-    clearState();
-  });
-
-  it('should produce correct signatures for IDL interface', function() {
-    WebIDL2
-        .parse(`
-[
-    Exposed=Window
-] interface Document : Node {
-    [CallWith=Document] constructor();
-    [Affects=Nothing] HTMLCollection getElementsByTagName(DOMString localName);
-    [Affects=Nothing] HTMLCollection getElementsByTagNameNS(DOMString? namespaceURI, DOMString localName);
-    [Affects=Nothing] HTMLCollection getElementsByClassName(DOMString classNames);
-
-    [NewObject, DoNotTestNewObject, PerWorldBindings, RaisesException, ImplementedAs=CreateElementForBinding] Element createElement(DOMString localName);
-    [NewObject, DoNotTestNewObject, RaisesException] Element createElementNS(DOMString? namespaceURI, DOMString qualifiedName);
-    [NewObject] DocumentFragment createDocumentFragment();
-    [NewObject] Text createTextNode(DOMString data);
-};
-`).forEach(walkRoot);
-    const output = postProcess(/* dryRun: */ true);
-    const expected = `export const NativeFunctions = [
-  {
-    name: "getElementsByTagName",
-    signatures: [["localName"]]
-  },
-  {
-    name: "getElementsByTagNameNS",
-    signatures: [["namespaceURI","localName"]]
-  },
-  {
-    name: "getElementsByClassName",
-    signatures: [["classNames"]]
-  },
-  {
-    name: "createElement",
-    signatures: [["localName"]]
-  },
-  {
-    name: "createElementNS",
-    signatures: [["namespaceURI","qualifiedName"]]
-  },
-  {
-    name: "createTextNode",
-    signatures: [["data"]]
-  }
-];`;
-    assert.equal(output, expected);
-  });
-
-  it('should produce correct signatures for IDL mixin interface', function() {
-    WebIDL2
-        .parse(`[
-    LegacyTreatAsPartialInterface,
-    Exposed=(Window,Worker)
-] interface mixin WindowOrWorkerGlobalScope {
-    [CallWith=ScriptState] void reportError(any e);
-
-    [RaisesException] DOMString atob(DOMString atob);
-    [CallWith=ScriptState, RuntimeCallStatsCounter=WindowSetTimeout] long setTimeout(Function handler, optional long timeout = 0, any... arguments);
-    [CallWith=ScriptState] long setTimeout(ScriptString handler, optional long timeout = 0, any... arguments);
-};
-`).forEach(walkRoot);
-    const output = postProcess(/* dryRun: */ true);
-    const expected = `export const NativeFunctions = [
-  {
-    name: "reportError",
-    signatures: [["e"]]
-  },
-  {
-    name: "atob",
-    signatures: [["atob"]]
-  },
-  {
-    name: "setTimeout",
-    signatures: [["handler","?timeout","...arguments"]]
-  }
-];`;
-    assert.equal(output, expected);
-  });
-
-  it('should produce correct signatures for Console IDL', function() {
-    WebIDL2
-        .parse(`
-[Exposed=(Window,Worker,Worklet)]
-namespace console {
-  undefined assert(optional boolean condition = false, any... data);
-  undefined table(optional any tabularData, optional sequence<DOMString> properties);
-  undefined count(optional DOMString label = "default");
-  undefined groupEnd();
-};
-`).forEach(walkRoot);
-    const output = postProcess(/* dryRun: */ true);
-    const expected = `export const NativeFunctions = [
-  {
-    name: "assert",
-    signatures: [["?condition","...data"]]
-  },
-  {
-    name: "table",
-    signatures: [["?tabularData","?properties"]]
-  },
-  {
-    name: "count",
-    signatures: [["?label"]]
-  }
-];`;
-    assert.equal(output, expected);
-  });
-
-  it('should produce correct signatures for Console IDL', function() {
-    WebIDL2
-        .parse(`
-// https://html.spec.whatwg.org/C/#the-slot-element
-[
-    Exposed=Window,
-    HTMLConstructor
-] interface HTMLSlotElement : HTMLElement {
-    [CEReactions, Reflect] attribute DOMString name;
-    [ImplementedAs=AssignedNodesForBinding] sequence<Node> assignedNodes(optional AssignedNodesOptions options = {});
-    [ImplementedAs=AssignedElementsForBinding] sequence<Element> assignedElements(optional AssignedNodesOptions options = {});
-    [RaisesException] void assign((Element or Text)... nodes);
-};
-`).forEach(walkRoot);
-    const output = postProcess(/* dryRun: */ true);
-    const expected = `export const NativeFunctions = [
-  {
-    name: "assignedNodes",
-    signatures: [["?options"]]
-  },
-  {
-    name: "assignedElements",
-    signatures: [["?options"]]
-  },
-  {
-    name: "assign",
-    signatures: [["...nodes"]]
-  }
-];`;
-    assert.equal(output, expected);
-  });
-
-  it('should produce correct signatures for typescript typings', function() {
-    const program = ts.createProgram(
-        [
-          new URL('test.d.ts', import.meta.url).pathname,
-        ],
-        {noLib: true, types: []});
-
-    for (const file of program.getSourceFiles()) {
-      ts.forEachChild(file, node => {
-        if (node.kind === ts.SyntaxKind.InterfaceDeclaration) {
-          for (const member of node.members) {
-            if (member.kind === ts.SyntaxKind.MethodSignature) {
-              parseTSFunction(member, node);
-            }
-          }
-        }
-        if (node.kind === ts.SyntaxKind.FunctionDeclaration) {
-          parseTSFunction(node, {name: {text: 'Window'}});
-        }
-      });
-    }
-    const output = postProcess(/* dryRun: */ true);
-    const expected = `export const NativeFunctions = [
-  {
-    name: "at",
-    signatures: [["index"]]
-  },
-  {
-    name: "diffSig",
-    signatures: [["oneSig"]],
-    receivers: ["Array"]
-  },
-  {
-    name: "diffSig",
-    signatures: [["twoSig"]],
-    receivers: ["ReadonlyArray"]
-  }
-];`;
-    assert.equal(output, expected);
-  });
-});

package/scripts/migration/class-fields/migrate.js

@@ -1,77 +0,0 @@
-// Copyright 2021 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-const {Project, SyntaxKind} = require('ts-morph');
-const path = require('path');
-const project = new Project({
-  tsConfigFilePath: '../devtools-frontend/tsconfig.json',
-});
-
-function isWithinContructor(classNode, reference) {
-  const constructors = classNode.getConstructors();
-  if (!constructors.length) {
-    return false;
-  }
-
-  if (constructors.length !== 1) {
-    throw new Error('More than one constructor');
-  }
-  return reference.getAncestors().includes(constructors[0]);
-}
-
-const files = project.getSourceFiles();
-for (const file of files) {
-  const filePath = file.getFilePath();
-  if (!filePath.startsWith(
-          path.normalize(
-              path.join(
-                  process.cwd(),
-                  '..',
-                  'devtools-frontend',
-                  'front_end',
-                  process.argv[2],
-                  ),
-              ),
-          )) {
-    continue;
-  }
-  console.log(filePath);
-  if (filePath.includes('third_party') || filePath.includes('generated') || filePath.endsWith('.d.ts')) {
-    continue;
-  }
-  const classNodes = file.getClasses();
-  for (const classNode of classNodes) {
-    for (const property of classNode.getInstanceMembers()) {
-      const name = property.getStructure().name;
-      console.log(name);
-      if (name.startsWith('#') || !property.hasModifier(SyntaxKind.PrivateKeyword)) {
-        continue;
-      }
-
-      if (isWithinContructor(classNode, property)) {
-        continue;
-      }
-
-      const newName = `#${name}`;
-
-      property.toggleModifier('private', false);
-      property.rename(newName);
-      for (const reference of property.findReferencesAsNodes()) {
-        // The first ancestor is the property access on `this.`.
-        const containingNode = reference.getAncestors()[1];
-        // Replace all `delete this.#somePrivateVariable;` (since that is illegal on private class fields)
-        // and replace it with an assignment to `undefined`.
-        if (containingNode.getKind() === SyntaxKind.DeleteExpression) {
-          console.log(
-              `Replacing delete statement on line ${reference.getStartLineNumber()}`,
-          );
-          // We should replace the statement, not the expression itself.
-          containingNode.getFirstAncestor().replaceWithText(`this.${newName} = undefined;`);
-        }
-      }
-    }
-  }
-  file.saveSync();
-}
-// project.save();

package/scripts/migration/class-fields/migrate.sh

@@ -1,8 +0,0 @@
-# This script expects to be called from the root of the repository
-# Example:
-# scripts/migration/class-fields/migrate.sh panels/console
-#
-$PWD/third_party/node/node.py --output scripts/migration/class-fields/migrate.js $1/
-git cl format --js
-NINJA_SUMMARIZE_BUILD=1 autoninja -C out/Default front_end/$1:bundle
-echo 'git commit -m "Migrate to private class fields in $1" -m "" -m "R=szuend@chromium.org" -m "" -m "Bug: 1222126"'

package/scripts/migration/class-fields/package.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": {
-    "ts-morph": "^13.0.1"
-  }
-}

package/scripts/migration/e2e_non_hosted_gemini.mjs

@@ -1,102 +0,0 @@
-// Copyright 2025 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import {execSync, spawn} from 'child_process';
-import path from 'path';
-
-const args = process.argv.slice(2);
-if (args.length !== 2) {
-  throw new Error('Usage: node scripts/migration/e2e_non_hosted_gemini.ts <path> <issue number>');
-}
-
-const oldTestFilePath = args[0];
-const newTestFilePath = oldTestFilePath.replace('/e2e/', '/e2e_non_hosted/');
-const newTestDirectory = newTestFilePath.substring(0, newTestFilePath.lastIndexOf('/'));
-const issueNumber = args[1];
-const branch = `fix-${issueNumber}`;
-const worktreeBasePath = `/tmp/worktree-${branch}`;
-const localCheckoutName = path.basename(process.cwd());
-const worktreePath = `${worktreeBasePath}/${localCheckoutName}`;
-
-const prompt = `Migrate @${oldTestFilePath} to @${newTestFilePath}. ISSUENUMBER is ${issueNumber}.
-
-Step by step instructions:
-
-1) Read all tests in @${newTestDirectory} as examples to understand the aspects of the already migrated files.
-2) Read all files in @test/e2e_non_hosted/shared.
-3) Read the non-migrated test file @${oldTestFilePath}.
-4) Read relevant helpers files imported from the test file.
-5) Create an empty file for the migrated test @${newTestFilePath}.
-6) Update BUILD.gn files to include the new file into the build and remove it from the BUILD.gn files in the e2e folder.
-7) Migrate the test file following the following instructions:
-
-   - each test function should receive a 'devToolsPage' via its arguments and 'inspectedPage' if needed.
-   - when calling helpers pass the 'devToolsPage' as the last argument.
-   - update the helpers that are used by the test to accept 'devToolsPage' as the last argument if needed. CRITICAL: DO NOT UPDATE helpers if an equivalent already exists on the 'DevToolsPage'. Remember that $$, $, waitFor, click, hover, typeText helpers are available directly on devToolsPage. Rewrite accordingly.
-   - keep the helpers from @test/e2e/helpers in place.
-   - in helpers, the 'devToolsPage' argument should be the last one and it should be optional defaulting to 'getBrowserAndPagesWrappers().devToolsPage'.
-   - use the globally available 'setup' function define experiments and flags for the test.
-   - rewrite any beforeEach/afterEach hooks to be local helper functions called from the test directly.
-   - instead of using 'devToolsPage.keyboard.press' use 'devToolsPage.keyboard.pressKey'.
-   - instead of using global 'click' use 'devToolsPage.click'.
-
-8) After you are done with changes, run 'npm run test -- -t StrictTypes ${newTestFilePath}' to verify.
-9) Delete the original test file.
-10) Commit the changes with the message 'Migrate ${oldTestFilePath}'
-11) Run 'git cl presubmit --upload'
-12) Run 'git cl upload -a -s -d -f --hashtag=migration-ai -x ${issueNumber}' to upload the change.
-13) Fix any lint issues. You may have to re-commit if files changed. When re-committing, amend the initial commit to preserve the commit message.
-`;
-
-function runProcess(command, args, options) {
-  return new Promise((resolve, reject) => {
-    const proc = spawn(command, args, options);
-
-    // Rejects on spawn errors (e.g., command not found)
-    proc.on('error', err => {
-      reject(err);
-    });
-
-    // Resolves or rejects based on the final exit code
-    proc.on('close', code => {
-      if (code === 0) {
-        console.log('Child process completed successfully.');
-        resolve(code);
-      } else {
-        // Rejects if the script fails (non-zero exit code)
-        const err = new Error(`Child process failed with exit code: ${code}`);
-        reject(err);
-      }
-    });
-  });
-}
-
-let exitCode = 0;
-try {
-  execSync(`git branch -D ${branch} || true`);
-  execSync(`gclient-new-workdir.py .. ${worktreeBasePath}`);
-
-  execSync(`git new-branch ${branch}`, {cwd: worktreePath});
-  execSync('gclient sync -j20 -Df', {cwd: worktreePath});
-  execSync('gn gen out/StrictTypes --args="is_debug=true"', {cwd: worktreePath});
-
-  await runProcess(
-    'npx',
-    ['@google/gemini-cli', '-y', '-p', prompt],
-    {
-      stdio: 'inherit',
-      cwd: worktreePath,
-      env: process.env,
-    }
-  );
-
-  console.log('Migration successful.');
-} catch (error) {
-  console.error('Migration failed:', error.message);
-  exitCode = 1;
-} finally {
-  console.log('Cleaning up worktree...');
-  execSync(`rm -rf ${worktreeBasePath}`);
-  process.exit(exitCode);
-}

package/scripts/migration/web-tests-esm/rename-legacy-global.mjs

@@ -1,129 +0,0 @@
-// Copyright 2023 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @file A quick and dirty search & replace script to aid in the
- * "*-legacy-ts" removal effort.
- *
- * It replaces each occurrence passed via "--from" to "--to" and adds the
- * import passed via "--import" if not already present in the web test.
- */
-
-import * as fs from 'fs/promises';
-import * as path from 'path';
-import yargs from 'yargs';
-
-const yargsObject = yargs(process.argv.slice(2), process.cwd())
-  .option('web-test-directory', {
-    type: 'string',
-    demandOption: true,
-  })
-  .option('import', {
-    type: 'string',
-    demandOption: true,
-  })
-  .option('from', {
-    type: 'string',
-    demandOption: true,
-  })
-  .option('to', {
-    type: 'string',
-    demandOption: true,
-  })
-  .strict()
-  .parseSync();
-
-// `createPlainTextSearchRegex` is stolen from string-utilities.ts.
-const SPECIAL_REGEX_CHARACTERS = '^[]{}()\\.^$*+?|-,';
-const createPlainTextSearchRegex = function (query) {
-  // This should be kept the same as the one in StringUtil.cpp.
-  let regex = '';
-  for (let i = 0; i < query.length; ++i) {
-    const c = query.charAt(i);
-    if (SPECIAL_REGEX_CHARACTERS.indexOf(c) !== -1) {
-      regex += '\\';
-    }
-    regex += c;
-  }
-  return new RegExp(regex, 'g');
-};
-
-/**
- * Returns all the *.js web tests in a directory (recursively).
- * Skips over 'resources' directories which contain text fixtures.
- */
-async function findWebTests(dir) {
-  const entries = await fs.readdir(dir, { withFileTypes: true });
-  const pathPromises = entries.map(async entry => {
-    const p = path.resolve(dir, entry.name);
-    if (entry.isDirectory() && entry.name !== 'resources') {
-      return findWebTests(p);
-    }
-    if (entry.isFile() && entry.name.endsWith('.js')) {
-      return [p];
-    }
-    return [];
-  });
-  return (await Promise.all(pathPromises)).flat();
-}
-
-/**
- * Inserts `importLine` at the beginning of `content` if not already present.
- * It has some smartness to either start a new 'import * as' block or append
- * it to an existing one.
- */
-function addImportIfNecessary(content, importLine) {
-  if (content.includes(importLine)) {
-    return content;
-  }
-
-  // Find where to insert `importLine`. We'll add it either to
-  // an existing import * as block or start a new one below the import {TestRunner} block.
-  const lines = content.split('\n');
-  let lastImportIndex = 0;
-  let onlyHasTestRunnerImports = true;
-  for (const [index, line] of lines.entries()) {
-    if (line.startsWith('import {')) {
-      lastImportIndex = index;
-    } else if (line.startsWith('import * as')) {
-      lastImportIndex = index;
-      onlyHasTestRunnerImports = false;
-    }
-  }
-
-  const linesToInsert = onlyHasTestRunnerImports
-    ? ['', importLine]
-    : [importLine];
-  lines.splice(lastImportIndex + 1, 0, ...linesToInsert);
-  return lines.join('\n');
-}
-
-const fromRegex = createPlainTextSearchRegex(yargsObject.from);
-const webTestPaths = await findWebTests(yargsObject.webTestDirectory);
-
-for (const filePath of webTestPaths) {
-  const content = await fs.readFile(filePath, { encoding: 'utf-8' });
-
-  let replacedContent = content;
-  if (yargsObject.from === yargsObject.to && !content.match(fromRegex)) {
-    // If the before/after are the same, we only check for the presence
-    // and add the import if needed.
-    continue;
-  } else if (yargsObject.from !== yargsObject.to) {
-    replacedContent = content.replaceAll(fromRegex, yargsObject.to);
-    if (replacedContent === content) {
-      continue;
-    }
-  }
-
-  replacedContent = addImportIfNecessary(replacedContent, yargsObject.import);
-  await fs.writeFile(filePath, replacedContent, { encoding: 'utf-8' });
-}
-
-const suggestedCommitMessage = `
-[DevTools] Replace \`${yargsObject.from}\` global with import
-
-Bug: chromium:1442410
-`.trim();
-console.log(suggestedCommitMessage);