chrome-devtools-frontend 1.0.1376716 → 1.0.1380117

package/front_end/panels/profiler/HeapTimelineOverview.ts

@@ -15,8 +15,8 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
   overviewContainer: HTMLElement;
   overviewGrid: PerfUI.OverviewGrid.OverviewGrid;
   overviewCanvas: HTMLCanvasElement;
-  windowLeft: number;
-  windowRight: number;
+  windowLeftRatio: number;
+  windowRightRatio: number;
   readonly yScale: SmoothScale;
   readonly xScale: SmoothScale;
   profileSamples: Samples;
@@ -24,7 +24,7 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
   updateOverviewCanvas?: boolean;
   updateGridTimerId?: number;
   updateTimerId?: number|null;
-  windowWidth?: number;
+  windowWidthRatio?: number;
   constructor() {
     super();
     this.element.id = 'heap-recording-view';
@@ -40,9 +40,9 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
     this.overviewContainer.appendChild(this.overviewGrid.element);
     this.overviewGrid.addEventListener(PerfUI.OverviewGrid.Events.WINDOW_CHANGED, this.onWindowChanged, this);
 
-    this.windowLeft = 0.0;
-    this.windowRight = 1.0;
-    this.overviewGrid.setWindow(this.windowLeft, this.windowRight);
+    this.windowLeftRatio = 0.0;
+    this.windowRightRatio = 1.0;
+    this.overviewGrid.setWindowRatio(this.windowLeftRatio, this.windowRightRatio);
     this.yScale = new SmoothScale();
     this.xScale = new SmoothScale();
 
@@ -174,7 +174,7 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
     context.closePath();
 
     if (gridValue) {
-      const label = Platform.NumberUtilities.bytesToString(gridValue);
+      const label = i18n.ByteUtilities.bytesToString(gridValue);
       const labelPadding = 4;
       const labelX = 0;
       const labelY = gridY - 0.5;
@@ -210,9 +210,9 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
   }
 
   updateBoundaries(): void {
-    this.windowLeft = this.overviewGrid.windowLeft();
-    this.windowRight = this.overviewGrid.windowRight();
-    this.windowWidth = this.windowRight - this.windowLeft;
+    this.windowLeftRatio = this.overviewGrid.windowLeftRatio();
+    this.windowRightRatio = this.overviewGrid.windowRightRatio();
+    this.windowWidthRatio = this.windowRightRatio - this.windowLeftRatio;
   }
 
   update(): void {
@@ -237,8 +237,8 @@ export class HeapTimelineOverview extends Common.ObjectWrapper.eventMixin<EventT
     const sizes = this.profileSamples.sizes;
     const startTime = timestamps[0];
     const totalTime = this.profileSamples.totalTime;
-    const timeLeft = startTime + totalTime * this.windowLeft;
-    const timeRight = startTime + totalTime * this.windowRight;
+    const timeLeft = startTime + totalTime * this.windowLeftRatio;
+    const timeRight = startTime + totalTime * this.windowRightRatio;
     const minIndex =
         Platform.ArrayUtilities.lowerBound(timestamps, timeLeft, Platform.ArrayUtilities.DEFAULT_COMPARATOR);
     const maxIndex =

package/front_end/panels/profiler/IsolateSelector.ts

@@ -4,7 +4,6 @@
 
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
-import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
@@ -172,7 +171,7 @@ export class IsolateSelector extends UI.Widget.VBox implements UI.ListControl.Li
       total += isolate.usedHeapSize();
       trend += isolate.usedHeapSizeGrowRate();
     }
-    this.totalValueDiv.textContent = Platform.NumberUtilities.bytesToString(total);
+    this.totalValueDiv.textContent = i18n.ByteUtilities.bytesToString(total);
     IsolateSelector.formatTrendElement(trend, this.totalTrendDiv);
   }
 
@@ -182,7 +181,7 @@ export class IsolateSelector extends UI.Widget.VBox implements UI.ListControl.Li
     if (Math.abs(changeRateBytesPerSecond) < changeRateThresholdBytesPerSecond) {
       return;
     }
-    const changeRateText = Platform.NumberUtilities.bytesToString(Math.abs(changeRateBytesPerSecond));
+    const changeRateText = i18n.ByteUtilities.bytesToString(Math.abs(changeRateBytesPerSecond));
     let changeText, changeLabel;
     if (changeRateBytesPerSecond > 0) {
       changeText = '\u2B06' + i18nString(UIStrings.changeRate, {PH1: changeRateText});
@@ -267,7 +266,7 @@ export class ListItem {
   }
 
   updateStats(): void {
-    this.heapDiv.textContent = Platform.NumberUtilities.bytesToString(this.isolate.usedHeapSize());
+    this.heapDiv.textContent = i18n.ByteUtilities.bytesToString(this.isolate.usedHeapSize());
     IsolateSelector.formatTrendElement(this.isolate.usedHeapSizeGrowRate(), this.trendDiv);
   }
 

package/front_end/panels/profiler/ProfileFlameChartDataProvider.ts

@@ -346,7 +346,7 @@ export class OverviewPane extends Common.ObjectWrapper.eventMixin<OverviewPaneEv
   selectRange(timeLeft: number, timeRight: number): void {
     const startTime = this.dataProvider.minimumBoundary();
     const totalTime = this.dataProvider.totalTime();
-    this.overviewGrid.setWindow((timeLeft - startTime) / totalTime, (timeRight - startTime) / totalTime);
+    this.overviewGrid.setWindowRatio((timeLeft - startTime) / totalTime, (timeRight - startTime) / totalTime);
   }
 
   onWindowChanged(event: Common.EventTarget.EventTargetEvent<PerfUI.OverviewGrid.WindowChangedWithPositionEvent>):

package/front_end/panels/profiler/ProfileSidebarTreeElement.ts

@@ -35,8 +35,7 @@ export class ProfileSidebarTreeElement extends UI.TreeOutline.TreeElement {
   small: boolean;
   readonly dataDisplayDelegate: DataDisplayDelegate;
   profile: ProfileHeader;
-  saveLinkElement?: HTMLElement;
-  editing?: UI.InplaceEditor.Controller|null;
+  editing: UI.InplaceEditor.Controller|null;
   constructor(dataDisplayDelegate: DataDisplayDelegate, profile: ProfileHeader, className: string) {
     super('', false);
     this.iconElement = document.createElement('div');
@@ -66,6 +65,7 @@ export class ProfileSidebarTreeElement extends UI.TreeOutline.TreeElement {
     this.dataDisplayDelegate = dataDisplayDelegate;
     this.profile = profile;
     profile.addEventListener(ProfileHeaderEvents.UPDATE_STATUS, this.updateStatus, this);
+    this.editing = null;
   }
 
   updateStatus(event: Common.EventTarget.EventTargetEvent<StatusUpdate>): void {
@@ -93,17 +93,18 @@ export class ProfileSidebarTreeElement extends UI.TreeOutline.TreeElement {
     if (!container) {
       return;
     }
-    const config = new UI.InplaceEditor.Config(this.editingCommitted.bind(this), this.editingCancelled.bind(this));
+    const config =
+        new UI.InplaceEditor.Config(this.editingCommitted.bind(this), this.editingCancelled.bind(this), undefined);
     this.editing = UI.InplaceEditor.InplaceEditor.startEditing(container, config);
   }
 
-  editingCommitted(container: Element, newTitle: string): void {
-    delete this.editing;
+  editingCommitted(_container: Element, newTitle: string): void {
+    this.editing = null;
     this.profile.setTitle(newTitle);
   }
 
   editingCancelled(): void {
-    delete this.editing;
+    this.editing = null;
   }
 
   dispose(): void {

package/front_end/panels/profiler/ProfileView.ts

@@ -566,7 +566,7 @@ export class WritableProfileHeader extends ProfileHeader implements Common.Strin
     if (this.jsonifiedProfile) {
       // TODO(l10n): Is the '%' at the end of this string correct? 4MB% looks wrong
       this.updateStatus(
-          i18nString(UIStrings.loadingD, {PH1: Platform.NumberUtilities.bytesToString(this.jsonifiedProfile.length)}));
+          i18nString(UIStrings.loadingD, {PH1: i18n.ByteUtilities.bytesToString(this.jsonifiedProfile.length)}));
     }
   }
 

package/front_end/panels/recorder/components/RecordingView.ts

@@ -688,12 +688,12 @@ export class RecordingView extends HTMLElement {
           // clang-format off
           replaySettingsFragments.push(html`<div>
             ${i18nString(UIStrings.download, {
-              value: Platform.NumberUtilities.bytesToString(
+              value: i18n.ByteUtilities.bytesToString(
                 this.#settings.networkConditionsSettings.download,
               ),
             })},
             ${i18nString(UIStrings.upload, {
-              value: Platform.NumberUtilities.bytesToString(
+              value: i18n.ByteUtilities.bytesToString(
                 this.#settings.networkConditionsSettings.upload,
               ),
             })},

package/front_end/panels/recorder/injected/{rollup.config.js → rollup.config.mjs}

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-const {terser} = require('../../../../node_modules/rollup-plugin-terser/rollup-plugin-terser.js');
+import terser from '@rollup/plugin-terser';
 
 /**
  * Checks if an env variable is true.

package/front_end/panels/recorder/recorderController.css

@@ -140,7 +140,3 @@ devtools-recording-list-view {
 .feedback .x-link:focus-visible {
   outline: -webkit-focus-ring-color auto 1px;
 }
-
-devtools-shortcut-dialog {
-  padding-right: 6px;
-}

package/front_end/panels/security/CookieReportTreeElement.ts

@@ -5,14 +5,6 @@ import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 
 import {SecurityPanelSidebarTreeElement} from './SecurityPanelSidebarTreeElement.js';
 
-export class ShowCookieReportEvent extends Event {
-  static readonly eventName = 'showcookiereport';
-
-  constructor() {
-    super(ShowCookieReportEvent.eventName, {bubbles: true, composed: true});
-  }
-}
-
 export class CookieReportTreeElement extends SecurityPanelSidebarTreeElement {
   constructor(title: string) {
     super(title);
@@ -20,7 +12,7 @@ export class CookieReportTreeElement extends SecurityPanelSidebarTreeElement {
   }
 
   override onselect(): boolean {
-    this.listItemElement.dispatchEvent(new ShowCookieReportEvent());
+    this.listItemElement.dispatchEvent(new CustomEvent('showCookieReport', {bubbles: true, composed: true}));
     return true;
   }
 }

package/front_end/panels/security/CookieReportView.ts

@@ -0,0 +1,120 @@
+// Copyright 2024 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as i18n from '../../core/i18n/i18n.js';
+import * as UI from '../../ui/legacy/legacy.js';
+import * as LitHtml from '../../ui/lit-html/lit-html.js';
+import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
+
+import cookieReportViewStyles from './cookieReportView.css.js';
+
+const {render, html, Directives: {ref}} = LitHtml;
+
+const UIStrings = {
+  /**
+   *@description Title in the header for the third-party cookie report in the Security & Privacy Panel
+   */
+  title: 'Third-party cookies',
+  /**
+   *@description Explaination in the header about the cookies listed in the report
+   */
+  body:
+      'Third-party cookies that might be restricted by users, depending on their settings. If a user chooses to restrict cookies, then this site might not work for them.',
+  /**
+   *@description A link the user can follow to learn more about third party cookie usage
+   */
+  learnMoreLink: 'Learn more about how third-party cookies are used',
+  /**
+   *@description Status string in the cookie report for a third-party cookie that is allowed without any sort of exception. This is also used as filter chip text to allow the user to filter the table based on cookie status
+   */
+  allowed: 'Allowed',
+  /**
+   *@description Status string in the cookie report for a third-party cookie that is allowed due to a grace period or heuristic exception. Otherwise, this would have been blocked. This is also used as filter chip text to allow the user to filter the table based on cookie status
+   */
+  allowedByException: 'Allowed By Exception',
+  /**
+   *@description Status string in the cookie report for a third-party cookie that was blocked. This is also used as filter chip text to allow the user to filter the table based on cookie status
+   */
+  blocked: 'Blocked',
+};
+const str_ = i18n.i18n.registerUIStrings('panels/security/CookieReportView.ts', UIStrings);
+export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+
+export interface ViewInput {}
+export interface ViewOutput {
+  namedBitSetFilterUI?: UI.FilterBar.NamedBitSetFilterUI;
+}
+
+export interface CookieReportNodeData {
+  name: string;
+  domain: string;
+  type: string;
+  platform: string;
+  status: string;
+  recommendation: string;
+}
+
+export type View = (input: ViewInput, output: ViewOutput, target: HTMLElement) => void;
+
+const filterItems: UI.FilterBar.Item[] = [
+  {
+    name: UIStrings.blocked,
+    label: () => i18nString(UIStrings.blocked),
+    title: UIStrings.blocked,
+    jslogContext: UIStrings.blocked,
+  },
+  {
+    name: UIStrings.allowed,
+    label: () => i18nString(UIStrings.allowed),
+    title: UIStrings.allowed,
+    jslogContext: UIStrings.allowed,
+  },
+  {
+    name: UIStrings.allowedByException,
+    label: () => i18nString(UIStrings.allowedByException),
+    title: UIStrings.allowedByException,
+    jslogContext: UIStrings.allowedByException,
+  },
+];
+
+export class CookieReportView extends UI.Widget.VBox {
+  namedBitSetFilterUI?: UI.FilterBar.NamedBitSetFilterUI;
+  #view: View;
+
+  constructor(element?: HTMLElement, view: View = (input, output, target) => {
+    // clang-format off
+    render(html `
+        <div class="report overflow-auto">
+            <div class="header">
+              <div class="title">${i18nString(UIStrings.title)}</div>
+              <div class="body">${i18nString(UIStrings.body)} <x-link class="x-link" href="https://developers.google.com/privacy-sandbox/cookies/prepare/audit-cookies" jslog=${VisualLogging.link('learn-more').track({click: true})}>${i18nString(UIStrings.learnMoreLink)}</x-link></div>
+            </div>
+            <devtools-named-bit-set-filter
+              class="filter"
+              .options=${{items: filterItems}}
+              ${ref((el?: Element) => {
+                  if(el instanceof UI.FilterBar.NamedBitSetFilterUIElement){
+                    output.namedBitSetFilterUI = el.getOrCreateNamedBitSetFilterUI();
+                  }
+              })}
+            ></devtools-named-bit-set-filter>
+        </div>
+    `, target, {host: this});
+    // clang-format on
+  }) {
+    super(true, undefined, element);
+    this.#view = view;
+
+    this.doUpdate();
+  }
+
+  doUpdate(): void {
+    this.#view(this, this, this.contentElement);
+  }
+
+  override wasShown(): void {
+    super.wasShown();
+    this.registerCSSFiles([cookieReportViewStyles]);
+  }
+}

package/front_end/panels/security/SecurityPanel.ts

@@ -14,6 +14,7 @@ import * as UI from '../../ui/legacy/legacy.js';
 import * as LitHtml from '../../ui/lit-html/lit-html.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
+import {CookieReportView} from './CookieReportView.js';
 import lockIconStyles from './lockIcon.css.js';
 import mainViewStyles from './mainView.css.js';
 import {ShowOriginEvent} from './OriginTreeElement.js';
@@ -534,6 +535,7 @@ export type ViewInput = {
   panel: SecurityPanel,
 };
 export type ViewOutput = {
+  setVisibleView: (view: UI.Widget.VBox) => void,
   splitWidget: UI.SplitWidget.SplitWidget,
   mainView: SecurityMainView,
   visibleView: UI.Widget.VBox|null,
@@ -560,7 +562,7 @@ export class SecurityPanel extends UI.Panel.Panel implements SDK.TargetManager.S
     <devtools-split-widget
     .options=${{vertical: true, settingName: 'security'}}
     ${UI.Widget.widgetRef(UI.SplitWidget.SplitWidget, e => {output.splitWidget = e;})}>
-          <devtools-widget
+        <devtools-widget
           slot="main"
           .widgetClass=${SecurityMainView}
           .widgetParams=${[input.panel] as SecurityMainViewProps}
@@ -569,6 +571,7 @@ export class SecurityPanel extends UI.Panel.Panel implements SDK.TargetManager.S
         <devtools-widget
           slot="sidebar"
           .widgetClass=${SecurityPanelSidebar}
+          @showCookieReport=${()=>output.setVisibleView(new CookieReportView())}
           ${UI.Widget.widgetRef(SecurityPanelSidebar, e => {output.sidebar = e;})}>
         </devtools-widget>
     </devtools-split-widget>`,
@@ -654,6 +657,7 @@ export class SecurityPanel extends UI.Panel.Panel implements SDK.TargetManager.S
     // The sidebar element will trigger displaying the main view. Rather than making a redundant call to display the main view, we rely on this.
     this.sidebar.securityOverviewElement.select(true);
   }
+
   showOrigin(origin: Platform.DevToolsPath.UrlString): void {
     const originState = this.origins.get(origin);
     if (!originState) {
@@ -821,7 +825,9 @@ export class SecurityPanel extends UI.Panel.Panel implements SDK.TargetManager.S
     const {frame} = event.data;
     const request = this.lastResponseReceivedForLoaderId.get(frame.loaderId);
 
-    this.selectAndSwitchToMainView();
+    if (!(this.visibleView instanceof CookieReportView)) {
+      this.selectAndSwitchToMainView();
+    }
     this.sidebar.clearOrigins();
     this.origins.clear();
     this.lastResponseReceivedForLoaderId.clear();

package/front_end/panels/security/cookieReportView.css

@@ -0,0 +1,46 @@
+/*
+ * Copyright 2024 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+.report {
+  display: flex;
+  flex-direction: column;
+  width: 100%;
+  height: 100%;
+  max-height: 100%;
+  gap: var(--sys-size-6);
+  padding-top: var(--sys-size-5);
+  padding-bottom: var(--sys-size-5);
+}
+
+.header {
+  display: flex;
+  flex-direction: column;
+  flex-shrink: 0;
+  gap: var(--sys-size-5);
+  padding-left: var(--sys-size-6);
+  padding-right: var(--sys-size-6);
+  min-width: var(--sys-size-31);
+
+  .title {
+    font: var(--sys-typescale-headline4);
+  }
+
+  .body {
+    font: var(--sys-typescale-body4-regular);
+  }
+}
+
+.x-link {
+  color: var(--sys-color-primary);
+  text-decoration-line: underline;
+  cursor: pointer;
+}
+
+.filter {
+  padding-left: var(--sys-size-5);
+  padding-right: var(--sys-size-6);
+  flex-shrink: 0;
+}

package/front_end/panels/security/sidebar.css

@@ -43,8 +43,7 @@
 .security-main-view-reload-message,
 .tree-outline li.security-sidebar-origins,
 .tree-outline li.security-group-list-item,
-.tree-outline span  {
-
+.tree-outline span {
   font: var(--sys-typescale-body4-medium);
 
   &:hover:not(:has(span[is="dt-checkbox"])) .selection {

package/front_end/panels/sensors/LocationsSettingsTab.ts

@@ -4,6 +4,8 @@
 
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Buttons from '../../ui/components/buttons/buttons.js';
+import * as Cards from '../../ui/components/cards/cards.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
@@ -14,7 +16,7 @@ const UIStrings = {
    *@description Title in the Locations Settings Tab, where custom geographic locations that the user
    *has entered are stored.
    */
-  customLocations: 'Custom locations',
+  locations: 'Locations',
   /**
    *@description Label for the name of a geographic location that the user has entered.
    */
@@ -91,7 +93,7 @@ const UIStrings = {
   /**
    *@description Text of add locations button in Locations Settings Tab of the Device Toolbar
    */
-  addLocation: 'Add location...',
+  addLocation: 'Add location',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/sensors/LocationsSettingsTab.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -106,16 +108,31 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
 
     this.element.setAttribute('jslog', `${VisualLogging.pane('emulation-locations')}`);
 
-    this.contentElement.createChild('div', 'header').textContent = i18nString(UIStrings.customLocations);
-
-    const addButton = UI.UIUtils.createTextButton(
-        i18nString(UIStrings.addLocation), this.addButtonClicked.bind(this),
-        {className: 'add-locations-button', jslogContext: 'emulation.add-location'});
-    this.contentElement.appendChild(addButton);
+    const settingsContent =
+        this.contentElement.createChild('div', 'settings-card-container-wrapper').createChild('div');
+    settingsContent.classList.add('settings-card-container');
+
+    const addButton = new Buttons.Button.Button();
+    addButton.classList.add('add-locations-button');
+    addButton.data = {
+      variant: Buttons.Button.Variant.OUTLINED,
+      iconName: 'plus',
+      jslogContext: 'emulation.add-location',
+    };
+    addButton.textContent = i18nString(UIStrings.addLocation);
+    addButton.addEventListener('click', () => this.addButtonClicked());
+
+    const listContainer = document.createElement('div');
+    const locationsCard = new Cards.Card.Card();
+    locationsCard.data = {
+      heading: i18nString(UIStrings.locations),
+      content: [listContainer, addButton],
+    };
+    settingsContent.appendChild(locationsCard);
 
     this.list = new UI.ListWidget.ListWidget(this, undefined, true);
     this.list.element.classList.add('locations-list');
-    this.list.show(this.contentElement);
+    this.list.show(listContainer);
     this.customSetting =
         Common.Settings.Settings.instance().moduleSetting<LocationDescription[]>('emulation.locations');
     const list =
@@ -144,8 +161,6 @@ export class LocationsSettingsTab extends UI.Widget.VBox implements UI.ListWidge
 
     this.customSetting.set(list);
     this.customSetting.addChangeListener(this.locationsUpdated, this);
-
-    this.setDefaultFocusedElement(addButton);
   }
 
   override wasShown(): void {

package/front_end/panels/sensors/locationsSettingsTab.css

@@ -4,28 +4,13 @@
  * found in the LICENSE file.
  */
 
-:host {
-  overflow: hidden;
-}
-
-.header {
-  padding: 0 0 6px;
-  border-bottom: 1px solid var(--sys-color-divider);
-  font-size: 18px;
-  font-weight: normal;
-  flex: none;
-}
-
 .add-locations-button {
-  flex: none;
-  margin: 10px 5px;
-  min-width: 140px;
-  align-self: flex-start;
+  margin-bottom: var(--sys-size-5);
+  border: none;
 }
 
 .locations-list {
-  max-width: 600px;
-  min-width: 340px;
+  margin-top: var(--sys-size-3);
   flex: auto;
 }
 
@@ -85,3 +70,18 @@
 .locations-input-container {
   padding: 1px;
 }
+
+.settings-card-container-wrapper {
+  scrollbar-gutter: stable;
+  padding-bottom: var(--sys-size-8);
+  overflow: auto;
+  position: absolute;
+  inset: var(--sys-size-8) 0 0;
+}
+
+.settings-card-container {
+  display: flex;
+  flex-direction: column;
+  align-items: center;
+  gap: var(--sys-size-9);
+}

package/front_end/panels/settings/AISettingsTab.ts

@@ -138,10 +138,6 @@ const UIStrings = {
    *@description Label for a link to the privacy notice
    */
   privacyNotice: 'Google Privacy Policy',
-  /**
-   *@description Header for the AI innovations settings page
-   */
-  aiInnovations: 'AI innovations',
   /**
    *@description Label for a toggle to enable the Console Insights feature
    */
@@ -215,14 +211,13 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
 
   #getAiAssistanceSettingDescription(): Platform.UIString.LocalizedString {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    if (config.devToolsAiAssistancePerformanceAgent?.enabled ||
-        config.devToolsAiAssistancePerformanceAgentDogfood?.enabled) {
+    if (config.devToolsAiAssistancePerformanceAgent?.enabled) {
       return i18nString(UIStrings.helpUnderstandStylingNetworkPerformanceAndFile);
     }
-    if (config.devToolsAiAssistanceFileAgent?.enabled || config.devToolsAiAssistanceFileAgentDogfood?.enabled) {
+    if (config.devToolsAiAssistanceFileAgent?.enabled) {
       return i18nString(UIStrings.helpUnderstandStylingNetworkAndFile);
     }
-    if (config.devToolsAiAssistanceNetworkAgent?.enabled || config.devToolsExplainThisResourceDogfood?.enabled) {
+    if (config.devToolsAiAssistanceNetworkAgent?.enabled) {
       return i18nString(UIStrings.helpUnderstandStylingAndNetworkRequest);
     }
     return i18nString(UIStrings.helpUnderstandStyling);
@@ -230,14 +225,13 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
 
   #getAiAssistanceSettingInfo(): Platform.UIString.LocalizedString {
     const config = Common.Settings.Settings.instance().getHostConfig();
-    if (config.devToolsAiAssistancePerformanceAgent?.enabled ||
-        config.devToolsAiAssistancePerformanceAgentDogfood?.enabled) {
+    if (config.devToolsAiAssistancePerformanceAgent?.enabled) {
       return i18nString(UIStrings.explainStylingNetworkPerformanceAndFile);
     }
-    if (config.devToolsAiAssistanceFileAgent?.enabled || config.devToolsAiAssistanceFileAgentDogfood?.enabled) {
+    if (config.devToolsAiAssistanceFileAgent?.enabled) {
       return i18nString(UIStrings.explainStylingNetworkAndFile);
     }
-    if (config.devToolsAiAssistanceNetworkAgent?.enabled || config.devToolsExplainThisResourceDogfood?.enabled) {
+    if (config.devToolsAiAssistanceNetworkAgent?.enabled) {
       return i18nString(UIStrings.explainStylingAndNetworkRequest);
     }
     return i18nString(UIStrings.explainStyling);
@@ -538,9 +532,6 @@ export class AISettingsTab extends LegacyWrapper.LegacyWrapper.WrappableComponen
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     LitHtml.render(html`
-      <header>
-        <h1>${i18nString(UIStrings.aiInnovations)}</h1>
-      </header>
       <div class="settings-container-wrapper" jslog=${VisualLogging.pane('chrome-ai')}>
         ${this.#renderSharedDisclaimer()}
         ${this.#consoleInsightsSetting || this.#aiAssistanceSetting ? html`

package/front_end/panels/settings/KeybindsSettingsTab.ts

@@ -23,7 +23,7 @@ const UIStrings = {
   /**
    *@description Text appearing before a select control offering users their choice of keyboard shortcut presets.
    */
-  matchShortcutsFromPreset: 'Match shortcuts from preset',
+  matchShortcutsFromPreset: 'Shortcut preset',
   /**
    *@description Screen reader label for list of keyboard shortcuts in settings
    */