chrome-devtools-frontend 1.0.1362775 → 1.0.1367881

package/front_end/models/live-metrics/web-vitals-injected/spec/spec.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {type INPAttribution, type MetricType} from '../../../../third_party/web-vitals/web-vitals.js';
+import type {INPAttribution, MetricType} from '../../../../third_party/web-vitals/web-vitals.js';
 
 export const EVENT_BINDING_NAME = '__chromium_devtools_metrics_reporter';
 export const INTERNAL_KILL_SWITCH = '__chromium_devtools_kill_live_metrics';

package/front_end/models/persistence/EditFileSystemView.ts

@@ -35,7 +35,7 @@ import * as UI from '../../ui/legacy/legacy.js';
 
 import editFileSystemViewStyles from './editFileSystemView.css.js';
 import {Events, IsolatedFileSystemManager} from './IsolatedFileSystemManager.js';
-import {type PlatformFileSystem} from './PlatformFileSystem.js';
+import type {PlatformFileSystem} from './PlatformFileSystem.js';
 
 const UIStrings = {
   /**

package/front_end/models/persistence/FileSystemWorkspaceBinding.ts

@@ -34,10 +34,9 @@ import * as Platform from '../../core/platform/platform.js';
 import * as TextUtils from '../text_utils/text_utils.js';
 import * as Workspace from '../workspace/workspace.js';
 
-import {type IsolatedFileSystem} from './IsolatedFileSystem.js';
-
+import type {IsolatedFileSystem} from './IsolatedFileSystem.js';
 import {Events, type IsolatedFileSystemManager} from './IsolatedFileSystemManager.js';
-import {type PlatformFileSystem} from './PlatformFileSystem.js';
+import type {PlatformFileSystem} from './PlatformFileSystem.js';
 
 export class FileSystemWorkspaceBinding {
   readonly isolatedFileSystemManager: IsolatedFileSystemManager;

package/front_end/models/persistence/IsolatedFileSystemManager.ts

@@ -32,11 +32,10 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
-import {type FilesChangedData} from './FileSystemWorkspaceBinding.js';
 
+import type {FilesChangedData} from './FileSystemWorkspaceBinding.js';
 import {IsolatedFileSystem} from './IsolatedFileSystem.js';
-
-import {type PlatformFileSystem} from './PlatformFileSystem.js';
+import type {PlatformFileSystem} from './PlatformFileSystem.js';
 
 const UIStrings = {
   /**

package/front_end/models/persistence/WorkspaceSettingsTab.ts

@@ -8,11 +8,11 @@ import * as UI from '../../ui/legacy/legacy.js';
 import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 
 import {EditFileSystemView} from './EditFileSystemView.js';
-import {type FileSystem} from './FileSystemWorkspaceBinding.js';
+import type {FileSystem} from './FileSystemWorkspaceBinding.js';
 import {IsolatedFileSystem} from './IsolatedFileSystem.js';
 import {Events, IsolatedFileSystemManager} from './IsolatedFileSystemManager.js';
 import {NetworkPersistenceManager} from './NetworkPersistenceManager.js';
-import {type PlatformFileSystem} from './PlatformFileSystem.js';
+import type {PlatformFileSystem} from './PlatformFileSystem.js';
 import workspaceSettingsTabStyles from './workspaceSettingsTab.css.js';
 
 const UIStrings = {

package/front_end/models/text_utils/ContentProvider.ts

@@ -31,9 +31,9 @@
 import type * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';
 
-import {type ContentDataOrError} from './ContentData.js';
-import {type StreamingContentDataOrError} from './StreamingContentData.js';
-import {type WasmDisassembly} from './WasmDisassembly.js';
+import type {ContentDataOrError} from './ContentData.js';
+import type {StreamingContentDataOrError} from './StreamingContentData.js';
+import type {WasmDisassembly} from './WasmDisassembly.js';
 
 export interface ContentProvider {
   contentURL(): Platform.DevToolsPath.UrlString;

package/front_end/models/text_utils/StaticContentProvider.ts

@@ -6,11 +6,7 @@ import type * as Common from '../../core/common/common.js';
 import type * as Platform from '../../core/platform/platform.js';
 
 import {ContentData, type ContentDataOrError} from './ContentData.js';
-import {
-  type ContentProvider,
-  type DeferredContent,
-  type SearchMatch,
-} from './ContentProvider.js';
+import type {ContentProvider, DeferredContent, SearchMatch} from './ContentProvider.js';
 import {performSearchInContentData} from './TextUtils.js';
 
 export class StaticContentProvider implements ContentProvider {

package/front_end/models/text_utils/TextUtils.ts

@@ -32,7 +32,7 @@ import * as Platform from '../../core/platform/platform.js';
 
 import {ContentData, type ContentDataOrError} from './ContentData.js';
 import {SearchMatch} from './ContentProvider.js';
-import {type Text} from './Text.js';
+import type {Text} from './Text.js';
 
 const KEY_VALUE_FILTER_REGEXP = /(?:^|\s)(\-)?([\w\-]+):([^\s]+)/;
 const REGEXP_FILTER_REGEXP = /(?:^|\s)(\-)?\/([^\/\\]+(\\.[^\/]*)*)\//;

package/front_end/models/text_utils/WasmDisassembly.ts

@@ -5,7 +5,7 @@
 import * as Platform from '../../core/platform/platform.js';
 
 import {ContentData} from './ContentData.js';
-import { type DeferredContent } from './ContentProvider.js';
+import type {DeferredContent} from './ContentProvider.js';
 
 interface FunctionBodyOffset {
   start: number;

package/front_end/models/timeline_model/TimelineProfileTree.test.ts

@@ -35,9 +35,9 @@ describeWithEnvironment('TimelineProfileTree', () => {
       assert.strictEqual(children.size, 3);
 
       const nodesIterator = children.values();
-      assert.strictEqual(nodesIterator.next().value.event, eventA);
-      assert.strictEqual(nodesIterator.next().value.event, eventB);
-      assert.strictEqual(nodesIterator.next().value.event, eventC);
+      assert.strictEqual(nodesIterator.next().value!.event, eventA);
+      assert.strictEqual(nodesIterator.next().value!.event, eventB);
+      assert.strictEqual(nodesIterator.next().value!.event, eventC);
     });
 
     it('builds a top-down tree from an event tree with multiple levels 1', () => {
@@ -65,14 +65,14 @@ describeWithEnvironment('TimelineProfileTree', () => {
       const rootChildIterator = rootChildren.values();
       const nodeA = rootChildIterator.next().value as TimelineModel.TimelineProfileTree.TopDownNode;
       assert.strictEqual(nodeA.event, eventA);
-      assert.strictEqual(rootChildIterator.next().value.event, eventB);
+      assert.strictEqual(rootChildIterator.next().value!.event, eventB);
 
       const nodeAChildren = nodeA.children();
       assert.strictEqual(nodeAChildren.size, 2);
 
       const nodeAChildIterator = nodeAChildren.values();
-      assert.strictEqual(nodeAChildIterator.next().value.event, eventC);
-      assert.strictEqual(nodeAChildIterator.next().value.event, eventD);
+      assert.strictEqual(nodeAChildIterator.next().value!.event, eventC);
+      assert.strictEqual(nodeAChildIterator.next().value!.event, eventD);
     });
 
     it('builds a top-down tree from an event tree with multiple levels 2', () => {
@@ -98,7 +98,7 @@ describeWithEnvironment('TimelineProfileTree', () => {
       assert.strictEqual(rootChildren.size, 2);
 
       const rootChildIterator = rootChildren.values();
-      assert.strictEqual(rootChildIterator.next().value.event, eventA);
+      assert.strictEqual(rootChildIterator.next().value!.event, eventA);
       const nodeB = rootChildIterator.next().value as TimelineModel.TimelineProfileTree.TopDownNode;
       assert.strictEqual(nodeB.event, eventB);
 
@@ -106,8 +106,8 @@ describeWithEnvironment('TimelineProfileTree', () => {
       assert.strictEqual(nodeBChildren.size, 2);
 
       const nodeBChildIterator = nodeBChildren.values();
-      assert.strictEqual(nodeBChildIterator.next().value.event, eventC);
-      assert.strictEqual(nodeBChildIterator.next().value.event, eventD);
+      assert.strictEqual(nodeBChildIterator.next().value!.event, eventC);
+      assert.strictEqual(nodeBChildIterator.next().value!.event, eventD);
     });
 
     it('calculates the self time for each node in an event tree correctly', () => {
@@ -137,7 +137,7 @@ describeWithEnvironment('TimelineProfileTree', () => {
 
       const rootChildIterator = rootChildren.values();
       assert.strictEqual(
-          rootChildIterator.next().value.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventA.dur));
+          rootChildIterator.next().value!.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventA.dur));
 
       const nodeB = rootChildIterator.next().value as TimelineModel.TimelineProfileTree.TopDownNode;
       const nodeBSelfTime = Trace.Types.Timing.MicroSeconds(eventB.dur - eventC.dur - eventD.dur);
@@ -148,9 +148,9 @@ describeWithEnvironment('TimelineProfileTree', () => {
 
       const nodeBChildIterator = nodeBChildren.values();
       assert.strictEqual(
-          nodeBChildIterator.next().value.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventC.dur));
+          nodeBChildIterator.next().value!.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventC.dur));
 
-      const nodeD = nodeBChildIterator.next().value;
+      const nodeD = nodeBChildIterator.next().value!;
       const nodeDSelfTime = Trace.Types.Timing.MicroSeconds(eventD.dur - eventE.dur);
       assert.strictEqual(nodeD.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(nodeDSelfTime));
 
@@ -158,7 +158,7 @@ describeWithEnvironment('TimelineProfileTree', () => {
       assert.strictEqual(nodeDChildren.size, 1);
 
       const nodeDChildIterator = nodeDChildren.values();
-      const nodeE = nodeDChildIterator.next().value;
+      const nodeE = nodeDChildIterator.next().value!;
       assert.strictEqual(nodeE.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventE.dur));
     });
   });
@@ -183,9 +183,9 @@ describeWithEnvironment('TimelineProfileTree', () => {
       assert.strictEqual(children.size, 3);
 
       const nodesIterator = children.values();
-      assert.strictEqual(nodesIterator.next().value.event, eventA);
-      assert.strictEqual(nodesIterator.next().value.event, eventB);
-      assert.strictEqual(nodesIterator.next().value.event, eventC);
+      assert.strictEqual(nodesIterator.next().value!.event, eventA);
+      assert.strictEqual(nodesIterator.next().value!.event, eventB);
+      assert.strictEqual(nodesIterator.next().value!.event, eventC);
     });
 
     it('builds a bottom up tree from an event tree with multiple levels 1', () => {
@@ -227,12 +227,12 @@ describeWithEnvironment('TimelineProfileTree', () => {
       const nodeCChildren = nodeC.children();
       assert.strictEqual(nodeCChildren.size, 1);
       const nodeCChildIterator = nodeCChildren.values();
-      assert.strictEqual(nodeCChildIterator.next().value.event, eventA);
+      assert.strictEqual(nodeCChildIterator.next().value!.event, eventA);
 
       const nodeDChildren = nodeC.children();
       assert.strictEqual(nodeDChildren.size, 1);
       const nodeDChildIterator = nodeDChildren.values();
-      assert.strictEqual(nodeDChildIterator.next().value.event, eventA);
+      assert.strictEqual(nodeDChildIterator.next().value!.event, eventA);
 
       const nodeAChildren = nodeA.children();
       assert.strictEqual(nodeAChildren.size, 0);
@@ -281,12 +281,12 @@ describeWithEnvironment('TimelineProfileTree', () => {
       const nodeCChildren = nodeC.children();
       assert.strictEqual(nodeCChildren.size, 1);
       const nodeCChildIterator = nodeCChildren.values();
-      assert.strictEqual(nodeCChildIterator.next().value.event, eventB);
+      assert.strictEqual(nodeCChildIterator.next().value!.event, eventB);
 
       const nodeDChildren = nodeC.children();
       assert.strictEqual(nodeDChildren.size, 1);
       const nodeDChildIterator = nodeDChildren.values();
-      assert.strictEqual(nodeDChildIterator.next().value.event, eventB);
+      assert.strictEqual(nodeDChildIterator.next().value!.event, eventB);
 
       const nodeAChildren = nodeA.children();
       assert.strictEqual(nodeAChildren.size, 0);
@@ -323,7 +323,7 @@ describeWithEnvironment('TimelineProfileTree', () => {
 
       const rootChildIterator = rootChildren.values();
       assert.strictEqual(
-          rootChildIterator.next().value.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventA.dur));
+          rootChildIterator.next().value!.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventA.dur));
 
       const nodeC = rootChildIterator.next().value as TimelineModel.TimelineProfileTree.TopDownNode;
       assert.strictEqual(nodeC.selfTime, Trace.Helpers.Timing.microSecondsToMilliseconds(eventC.dur));

package/front_end/models/timeline_model/TimelineProfileTree.ts

@@ -6,7 +6,7 @@ import type * as Protocol from '../../generated/protocol.js';
 import * as Trace from '../../models/trace/trace.js';
 
 import {TimelineJSProfileProcessor} from './TimelineJSProfile.js';
-import {type TimelineModelFilter} from './TimelineModelFilter.js';
+import type {TimelineModelFilter} from './TimelineModelFilter.js';
 
 export class Node {
   totalTime: number;

package/front_end/models/trace/ModelImpl.test.ts

@@ -87,7 +87,7 @@ describeWithEnvironment('TraceModel', function() {
       // Process the previous trace again to test the trace sequencing
       await TraceLoader.rawEvents(this, 'web-dev.json.gz'),
       await TraceLoader.rawEvents(this, 'multiple-navigations.json.gz'),
-      await TraceLoader.rawEvents(this, 'basic.json.gz'),
+      await TraceLoader.rawEvents(this, 'missing-url.json.gz'),
     ];
     for (const traceFile of traceFiles) {
       await model.parse(traceFile);

package/front_end/models/trace/ModelImpl.ts

@@ -16,7 +16,6 @@ import * as Types from './types/types.js';
 
 export interface ParseConfig {
   metadata?: Types.File.MetaData;
-  // Unused but will eventually be consumed by UIUtils Linkifier, etc.
   isFreshRecording?: boolean;
 }
 
@@ -92,6 +91,7 @@ export class Model extends EventTarget {
   async parse(traceEvents: readonly Types.Events.Event[], config?: ParseConfig): Promise<void> {
     const metadata = config?.metadata || {};
     const isFreshRecording = config?.isFreshRecording || false;
+    const isCPUProfile = metadata?.dataOrigin === Types.File.DataOrigin.CPU_PROFILE;
     // During parsing, periodically update any listeners on each processors'
     // progress (if they have any updates).
     const onTraceUpdate = (event: Event): void => {
@@ -113,7 +113,10 @@ export class Model extends EventTarget {
       // Wait for all outstanding promises before finishing the async execution,
       // but perform all tasks in parallel.
       const syntheticEventsManager = Helpers.SyntheticEvents.SyntheticEventsManager.createAndActivate(traceEvents);
-      await this.#processor.parse(traceEvents, isFreshRecording);
+      await this.#processor.parse(traceEvents, {
+        isFreshRecording,
+        isCPUProfile,
+      });
       this.#storeParsedFileData(file, this.#processor.parsedTrace, this.#processor.insights);
       // We only push the file onto this.#traces here once we know it's valid
       // and there's been no errors in the parsing.
@@ -157,27 +160,15 @@ export class Model extends EventTarget {
    * If no index is given, the last stored parsed data is returned.
    */
   parsedTrace(index: number = this.#traces.length - 1): Handlers.Types.ParsedTrace|null {
-    if (!this.#traces[index]) {
-      return null;
-    }
-
-    return this.#traces[index].parsedTrace;
+    return this.#traces.at(index)?.parsedTrace ?? null;
   }
 
   traceInsights(index: number = this.#traces.length - 1): Insights.Types.TraceInsightSets|null {
-    if (!this.#traces[index]) {
-      return null;
-    }
-
-    return this.#traces[index].traceInsights;
+    return this.#traces.at(index)?.traceInsights ?? null;
   }
 
   metadata(index: number = this.#traces.length - 1): Types.File.MetaData|null {
-    if (!this.#traces[index]) {
-      return null;
-    }
-
-    return this.#traces[index].metadata;
+    return this.#traces.at(index)?.metadata ?? null;
   }
 
   overrideModifications(index: number, newModifications: Types.File.Modifications): void {
@@ -187,20 +178,12 @@ export class Model extends EventTarget {
   }
 
   rawTraceEvents(index: number = this.#traces.length - 1): readonly Types.Events.Event[]|null {
-    if (!this.#traces[index]) {
-      return null;
-    }
-
-    return this.#traces[index].traceEvents;
+    return this.#traces.at(index)?.traceEvents ?? null;
   }
 
   syntheticTraceEventsManager(index: number = this.#traces.length - 1): Helpers.SyntheticEvents.SyntheticEventsManager
       |null {
-    if (!this.#syntheticEventsManagerByTrace[index]) {
-      return null;
-    }
-
-    return this.#syntheticEventsManagerByTrace[index];
+    return this.#syntheticEventsManagerByTrace.at(index) ?? null;
   }
 
   size(): number {

package/front_end/models/trace/Processor.test.ts

@@ -13,13 +13,13 @@ describeWithEnvironment('TraceProcessor', function() {
 
     // Check parsing after instantiation.
     assert.isNull(processor.parsedTrace);
-    await processor.parse(file);
+    await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
     assert.isNotNull(processor.parsedTrace);
 
     // Check parsing without a reset.
     let thrown;
     try {
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
     } catch (e) {
       thrown = e as Error;
     }
@@ -30,7 +30,7 @@ describeWithEnvironment('TraceProcessor', function() {
     processor.reset();
     assert.isNull(processor.parsedTrace);
     assert.isNull(processor.insights);
-    await processor.parse(file);
+    await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
     assert.isNotNull(processor.parsedTrace);
     assert.isNotNull(processor.insights);
     // Cleanup.
@@ -39,8 +39,9 @@ describeWithEnvironment('TraceProcessor', function() {
     // Check simultaneous parsing without waiting.
     let promise;
     try {
-      promise = processor.parse(file);
-      await processor.parse(file);
+      promise = processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
+
     } catch (e) {
       thrown = e as Error;
     } finally {
@@ -53,7 +54,7 @@ describeWithEnvironment('TraceProcessor', function() {
     // Check if data is null immediately after resetting.
     assert.isNull(processor.parsedTrace);
     assert.isNull(processor.insights);
-    await processor.parse(file);
+    await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
     assert.isNotNull(processor.parsedTrace);
     assert.isNotNull(processor.insights);
     processor.reset();
@@ -62,7 +63,7 @@ describeWithEnvironment('TraceProcessor', function() {
 
     // Check resetting while parsing.
     try {
-      promise = processor.parse(file);
+      promise = processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       processor.reset();
     } catch (e) {
       thrown = e as Error;
@@ -76,7 +77,7 @@ describeWithEnvironment('TraceProcessor', function() {
     // Check parsing after resetting while parsing.
     assert.isNull(processor.parsedTrace);
     assert.isNull(processor.insights);
-    await processor.parse(file);
+    await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
     assert.isNotNull(processor.parsedTrace);
     assert.isNotNull(processor.insights);
   });
@@ -86,7 +87,7 @@ describeWithEnvironment('TraceProcessor', function() {
       Animations: Trace.Handlers.ModelHandlers.Animations,
     });
     const events = await TraceLoader.rawEvents(this, 'animation.json.gz');
-    await processor.parse(events);
+    await processor.parse(events, {isFreshRecording: true, isCPUProfile: false});
     assert.isNotNull(processor.parsedTrace);
     assert.deepEqual(Object.keys(processor.parsedTrace || {}), ['Meta', 'Animations']);
   });
@@ -129,7 +130,7 @@ describeWithEnvironment('TraceProcessor', function() {
     const rawEvents = await TraceLoader.rawEvents(this, 'web-dev-outermost-frames.json.gz');
     // This trace has 106,110 events. At default of 50k chunks we should see 2 updates.
     // Additional progress updates are emitted for handers, etc.
-    await processor.parse(rawEvents).then(() => {
+    await processor.parse(rawEvents, {isFreshRecording: true, isCPUProfile: false}).then(() => {
       assert.isAtLeast(updateEventCount, 2);
     });
   });
@@ -245,7 +246,7 @@ describeWithEnvironment('TraceProcessor', function() {
       const processor = Trace.Processor.TraceProcessor.createWithAllHandlers();
       const file = await TraceLoader.rawEvents(this, 'basic.json.gz');
 
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       if (!processor.insights) {
         throw new Error('No insights');
       }
@@ -269,7 +270,7 @@ describeWithEnvironment('TraceProcessor', function() {
       const processor = Trace.Processor.TraceProcessor.createWithAllHandlers();
       const file = await TraceLoader.rawEvents(this, 'load-simple.json.gz');
 
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       if (!processor.insights) {
         throw new Error('No insights');
       }
@@ -286,7 +287,7 @@ describeWithEnvironment('TraceProcessor', function() {
       });
       const file = await TraceLoader.rawEvents(this, 'load-simple.json.gz');
 
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       if (!processor.insights) {
         throw new Error('No insights');
       }
@@ -305,7 +306,7 @@ describeWithEnvironment('TraceProcessor', function() {
       const processor = Trace.Processor.TraceProcessor.createWithAllHandlers();
       const file = await TraceLoader.rawEvents(this, 'load-simple.json.gz');
 
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       if (!processor.insights) {
         throw new Error('No insights');
       }
@@ -331,7 +332,7 @@ describeWithEnvironment('TraceProcessor', function() {
       const processor = Trace.Processor.TraceProcessor.createWithAllHandlers();
       const file = await TraceLoader.rawEvents(this, 'multiple-navigations.json.gz');
 
-      await processor.parse(file);
+      await processor.parse(file, {isFreshRecording: true, isCPUProfile: false});
       if (!processor.insights) {
         throw new Error('No insights');
       }

package/front_end/models/trace/Processor.ts

@@ -49,6 +49,19 @@ declare global {
   }
 }
 
+export interface ParseOptions {
+  /**
+   * If the trace was just recorded on the current page, rather than an imported file.
+   * @default false
+   */
+  isFreshRecording?: boolean;
+  /**
+   * If the trace is a CPU Profile rather than a Chrome tracing trace.
+   * @default false
+   */
+  isCPUProfile?: boolean;
+}
+
 export class TraceProcessor extends EventTarget {
   // We force the Meta handler to be enabled, so the TraceHandlers type here is
   // the model handlers the user passes in and the Meta handler.
@@ -151,14 +164,14 @@ export class TraceProcessor extends EventTarget {
     this.#status = Status.IDLE;
   }
 
-  async parse(traceEvents: readonly Types.Events.Event[], freshRecording = false): Promise<void> {
+  async parse(traceEvents: readonly Types.Events.Event[], options: ParseOptions): Promise<void> {
     if (this.#status !== Status.IDLE) {
       throw new Error(`Trace processor can't start parsing when not idle. Current state: ${this.#status}`);
     }
     try {
       this.#status = Status.PARSING;
-      await this.#computeParsedTrace(traceEvents, freshRecording);
-      if (this.#data) {
+      await this.#computeParsedTrace(traceEvents, Boolean(options.isFreshRecording));
+      if (this.#data && !options.isCPUProfile) {  // We do not calculate insights for CPU Profiles.
         this.#computeInsights(this.#data, traceEvents);
       }
       this.#status = Status.FINISHED_PARSING;
@@ -308,8 +321,10 @@ export class TraceProcessor extends EventTarget {
     const networkAnalysis = Lantern.Core.NetworkAnalyzer.analyze(requests);
     const simulator: Lantern.Simulation.Simulator<Types.Events.SyntheticNetworkRequest> =
         Lantern.Simulation.Simulator.createSimulator({
+          // TODO(crbug.com/372674229): if devtools throttling was on, does this network analysis capture
+          // that? Do we need to set 'devtools' throttlingMethod?
           networkAnalysis,
-          throttlingMethod: 'simulate',
+          throttlingMethod: 'provided',
         });
 
     const computeData = {graph, simulator, processedNavigation};
@@ -342,19 +357,28 @@ export class TraceProcessor extends EventTarget {
       Object.assign(data, {[name]: insightResult});
     }
 
-    let id, label, navigation;
+    let id, urlString, navigation;
     if (context.navigation) {
       id = context.navigationId;
-      label = context.navigation.args.data?.documentLoaderURL ?? parsedTrace.Meta.mainFrameURL;
+      urlString = context.navigation.args.data?.documentLoaderURL ?? parsedTrace.Meta.mainFrameURL;
       navigation = context.navigation;
     } else {
       id = Types.Events.NO_NAVIGATION;
-      label = parsedTrace.Meta.mainFrameURL;
+      urlString = parsedTrace.Meta.mainFrameURL;
+    }
+
+    let url;
+    try {
+      url = new URL(urlString);
+    } catch {
+      // We're pretty sure this only happens for our test fixture: missing-url.json.gz. Shouldn't
+      // happen for real traces.
+      return;
     }
 
     const insightSets = {
       id,
-      label,
+      url,
       navigation,
       frameId: context.frameId,
       bounds: context.bounds,
@@ -403,7 +427,7 @@ export class TraceProcessor extends EventTarget {
       const frameId = navigation.args.frame;
       const navigationId = navigation.args.data?.navigationId as string;
 
-      // The lantern sub-context is optional on NavigationInsightContext, so not setting it is OK.
+      // The lantern sub-context is optional on InsightSetContext, so not setting it is OK.
       // This is also a hedge against an error inside Lantern resulting in breaking the entire performance panel.
       // Additionally, many trace fixtures are too old to be processed by Lantern.
       let lantern;

package/front_end/models/trace/extras/FilmStrip.ts

@@ -30,7 +30,7 @@ export type HandlerDataWithScreenshots = Handlers.Types.EnabledHandlerDataWithMe
 // Cache film strips based on:
 // 1. The trace parsed data object
 // 2. The start time.
-const filmStripCache = new Map<HandlerDataWithScreenshots, Map<Types.Timing.MicroSeconds, Data>>();
+const filmStripCache = new WeakMap<HandlerDataWithScreenshots, Map<Types.Timing.MicroSeconds, Data>>();
 
 export function fromParsedTrace(
     parsedTrace: HandlerDataWithScreenshots, customZeroTime?: Types.Timing.MicroSeconds): Data {
@@ -43,7 +43,7 @@ export function fromParsedTrace(
     return fromCache;
   }
 
-  for (const screenshotEvent of parsedTrace.Screenshots) {
+  for (const screenshotEvent of parsedTrace.Screenshots.all) {
     if (screenshotEvent.ts < zeroTime) {
       continue;
     }

package/front_end/models/trace/handlers/LayoutShiftsHandler.test.ts

@@ -235,11 +235,11 @@ describe('LayoutShiftsHandler', function() {
 
     for (const cluster of clusters) {
       // Get the max shift score from the list of layout shifts.
-      const maxShiftScore = Math.max(...cluster.events.map(s => s.args.data?.score ?? 0));
+      const maxShiftScore = Math.max(...cluster.events.map(s => s.args.data?.weighted_score_delta ?? 0));
       const gotShift = cluster.worstShiftEvent as Trace.Types.Events.SyntheticLayoutShift;
       assert.isNotNull(gotShift);
       // Make sure the worstShiftEvent's data matches the maxShiftScore.
-      assert.strictEqual(gotShift.args.data?.score ?? 0, maxShiftScore);
+      assert.strictEqual(gotShift.args.data?.weighted_score_delta ?? 0, maxShiftScore);
     }
   });
 

package/front_end/models/trace/handlers/LayoutShiftsHandler.ts

@@ -9,6 +9,7 @@ import * as Types from '../types/types.js';
 
 import {data as metaHandlerData} from './MetaHandler.js';
 import {ScoreClassification} from './PageLoadMetricsHandler.js';
+import {data as screenshotsHandlerData} from './ScreenshotsHandler.js';
 import {type HandlerName, HandlerState} from './types.js';
 
 // We start with a score of zero and step through all Layout Shift records from
@@ -183,6 +184,13 @@ function updateTraceWindowMax(
   traceWindow.range = Types.Timing.MicroSeconds(traceWindow.max - traceWindow.min);
 }
 
+function findScreenshots(timestamp: Types.Timing.MicroSeconds): Types.Events.LayoutShiftParsedData['screenshots'] {
+  const screenshots = screenshotsHandlerData().all;
+  const before = Helpers.Trace.findPreviousEventBeforeTimestamp(screenshots, timestamp);
+  const after = before ? screenshots[screenshots.indexOf(before) + 1] : null;
+  return {before, after};
+}
+
 function buildScoreRecords(): void {
   const {traceBounds} = metaHandlerData();
   scoreRecords.push({ts: traceBounds.min, score: 0});
@@ -364,6 +372,7 @@ async function buildLayoutShiftsClusters(): Promise<void> {
           },
           parsedData: {
             timeFromNavigation,
+            screenshots: findScreenshots(event.ts),
             cumulativeWeightedScoreInWindow: currentCluster.clusterCumulativeScore,
             // The score of the session window is temporarily set to 0 just
             // to initialize it. Since we need to get the score of all shifts
@@ -452,7 +461,7 @@ async function buildLayoutShiftsClusters(): Promise<void> {
       }
 
       // Find the worst layout shift of the cluster.
-      const score = shift.args.data?.score;
+      const score = shift.args.data?.weighted_score_delta;
       if (score !== undefined && score > largestScore) {
         largestScore = score;
         worstShiftEvent = shift;