chrome-devtools-frontend 1.0.1153166 → 1.0.1155899

package/front_end/panels/elements/elements-meta.ts

@@ -8,6 +8,7 @@ import * as SDK from '../../core/sdk/sdk.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import type * as Elements from './elements.js';
+import type * as ElementsComponents from './components/components.js';
 
 import * as i18n from '../../core/i18n/i18n.js';
 const UIStrings = {
@@ -153,6 +154,7 @@ const UIStrings = {
 const str_ = i18n.i18n.registerUIStrings('panels/elements/elements-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 let loadedElementsModule: (typeof Elements|undefined);
+let loadedElementsComponentsModule: (typeof ElementsComponents|undefined);
 
 async function loadElementsModule(): Promise<typeof Elements> {
   if (!loadedElementsModule) {
@@ -160,6 +162,12 @@ async function loadElementsModule(): Promise<typeof Elements> {
   }
   return loadedElementsModule;
 }
+async function loadElementsComponentsModule(): Promise<typeof ElementsComponents> {
+  if (!loadedElementsComponentsModule) {
+    loadedElementsComponentsModule = await import('./components/components.js');
+  }
+  return loadedElementsComponentsModule;
+}
 function maybeRetrieveContextTypes<T = unknown>(getClassCallBack: (elementsModule: typeof Elements) => T[]): T[] {
   if (loadedElementsModule === undefined) {
     return [];
@@ -250,8 +258,8 @@ UI.ViewManager.registerViewExtension({
   order: 4,
   persistence: UI.ViewManager.ViewPersistence.PERMANENT,
   async loadView() {
-    const Elements = await loadElementsModule();
-    return Elements.LayoutSidebarPane.LayoutSidebarPane.instance();
+    const ElementsComponents = await loadElementsComponentsModule();
+    return ElementsComponents.LayoutPane.LayoutPane.instance().wrapper as UI.Widget.Widget;
   },
 });
 

package/front_end/panels/elements/elements.ts

@@ -49,7 +49,6 @@ import * as ElementsTreeOutline from './ElementsTreeOutline.js';
 import * as EventListenersWidget from './EventListenersWidget.js';
 import * as InspectElementModeController from './InspectElementModeController.js';
 import * as LayersWidget from './LayersWidget.js';
-import * as LayoutSidebarPane from './LayoutSidebarPane.js';
 import * as MarkerDecorator from './MarkerDecorator.js';
 import * as MetricsSidebarPane from './MetricsSidebarPane.js';
 import * as NodeStackTraceWidget from './NodeStackTraceWidget.js';
@@ -83,7 +82,6 @@ export {
   EventListenersWidget,
   InspectElementModeController,
   LayersWidget,
-  LayoutSidebarPane,
   MarkerDecorator,
   MetricsSidebarPane,
   NodeStackTraceWidget,

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -1284,6 +1284,13 @@ export class NetworkRequestNode extends NetworkNode {
     }
   }
 
+  #getLinkifierMetric(): Host.UserMetrics.Action|undefined {
+    if (this.requestInternal.resourceType().isStyleSheet()) {
+      return Host.UserMetrics.Action.StyleSheetInitiatorLinkClicked;
+    }
+    return undefined;
+  }
+
   private renderInitiatorCell(cell: HTMLElement): void {
     this.initiatorCell = cell;
     const request = this.requestInternal;
@@ -1301,6 +1308,7 @@ export class NetworkRequestNode extends NetworkNode {
                                                         text: uiSourceCode ? uiSourceCode.displayName() : undefined,
                                                         lineNumber: initiator.lineNumber,
                                                         columnNumber: initiator.columnNumber,
+                                                        userMetric: this.#getLinkifierMetric(),
                                                       } as Components.Linkifier.LinkifyURLOptions)));
         this.appendSubtitle(cell, i18nString(UIStrings.parser));
         break;

package/front_end/panels/network/NetworkLogView.ts

@@ -1452,7 +1452,8 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
 
   private onRequestUpdated(event: Common.EventTarget.EventTargetEvent<SDK.NetworkRequest.NetworkRequest>): void {
     const request = event.data;
-    if (SDK.TargetManager.TargetManager.instance().isInScope(SDK.NetworkManager.NetworkManager.forRequest(request))) {
+    const networkManager = SDK.NetworkManager.NetworkManager.forRequest(request);
+    if (!networkManager || SDK.TargetManager.TargetManager.instance().isInScope(networkManager)) {
       this.refreshRequest(request);
     }
   }

package/front_end/panels/network/NetworkPanel.ts

@@ -371,7 +371,15 @@ export class NetworkPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
       void {
     const startTime = Math.max(this.calculator.minimumBoundary(), event.data.startTime / 1000);
     const endTime = Math.min(this.calculator.maximumBoundary(), event.data.endTime / 1000);
-    this.networkLogView.setWindow(startTime, endTime);
+    if (startTime === this.calculator.minimumBoundary() && endTime === this.calculator.maximumBoundary()) {
+      // Reset the filters for NetworkLogView when the window is reset
+      // to its boundaries. This clears the filters and allows the users
+      // to see the incoming requests after they have updated the curtains
+      // to be in the edges. (ex: by double clicking on the overview grid)
+      this.networkLogView.setWindow(0, 0);
+    } else {
+      this.networkLogView.setWindow(startTime, endTime);
+    }
   }
 
   private async searchToggleClick(): Promise<void> {
@@ -531,6 +539,9 @@ export class NetworkPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
 
   private load(): void {
     if (this.filmStripRecorder && this.filmStripRecorder.isRecording()) {
+      if (this.pendingStopTimer) {
+        window.clearTimeout(this.pendingStopTimer);
+      }
       this.pendingStopTimer = window.setTimeout(this.stopFilmStripRecording.bind(this), this.displayScreenshotDelay);
     }
   }

package/front_end/panels/recorder/components/ExtensionView.ts

@@ -111,7 +111,7 @@ export class ExtensionView extends HTMLElement {
                 {
                   variant: Buttons.Button.Variant.ROUND,
                   size: Buttons.Button.Size.TINY,
-                  iconName: 'bin',
+                  iconName: 'cross',
                 } as Buttons.Button.ButtonData
               }
               @click=${this.#closeView}

package/front_end/panels/sources/DebuggerPlugin.ts

@@ -44,12 +44,12 @@ import type * as TextEditor from '../../ui/components/text_editor/text_editor.js
 import * as ObjectUI from '../../ui/legacy/components/object_ui/object_ui.js';
 import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
+import * as SourceComponents from './components/components.js';
 
 import {AddDebugInfoURLDialog} from './AddSourceMapURLDialog.js';
 import {BreakpointEditDialog, type BreakpointEditDialogResult} from './BreakpointEditDialog.js';
 import {Plugin} from './Plugin.js';
 import {SourcesPanel} from './SourcesPanel.js';
-import {BreakpointsSidebarController} from './BreakpointsSidebarPane.js';
 
 const {EMPTY_BREAKPOINT_CONDITION, NEVER_PAUSE_HERE_CONDITION} = Breakpoints.BreakpointManager;
 
@@ -837,10 +837,12 @@ export class DebuggerPlugin extends Plugin {
       dialog.detach();
       editor.dispatch({effects: compartment.reconfigure([])});
       if (!result.committed) {
-        BreakpointsSidebarController.instance().breakpointEditFinished(breakpoint, false);
+        SourceComponents.BreakpointsView.BreakpointsSidebarController.instance().breakpointEditFinished(
+            breakpoint, false);
         return;
       }
-      BreakpointsSidebarController.instance().breakpointEditFinished(breakpoint, oldCondition !== result.condition);
+      SourceComponents.BreakpointsView.BreakpointsSidebarController.instance().breakpointEditFinished(
+          breakpoint, oldCondition !== result.condition);
       recordBreakpointWithConditionAdded(result);
       if (breakpoint) {
         breakpoint.setCondition(result.condition, result.isLogpoint);
@@ -1672,7 +1674,8 @@ export class BreakpointLocationRevealer implements Common.Revealer.Revealer {
     if (debuggerPlugin) {
       debuggerPlugin.editBreakpointLocation(breakpointLocation);
     } else {
-      BreakpointsSidebarController.instance().breakpointEditFinished(breakpointLocation.breakpoint, false);
+      SourceComponents.BreakpointsView.BreakpointsSidebarController.instance().breakpointEditFinished(
+          breakpointLocation.breakpoint, false);
     }
   }
 }

package/front_end/panels/sources/SourcesPanel.ts

@@ -261,7 +261,7 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
     tabbedPane.addEventListener(
         UI.TabbedPane.Events.TabSelected,
         ({data: {tabId}}: Common.EventTarget.EventTargetEvent<UI.TabbedPane.EventData>): void =>
-            Host.userMetrics.sidebarPaneShown(tabId));
+            Host.userMetrics.sourcesSidebarTabShown(tabId));
 
     if (UI.ViewManager.ViewManager.instance().hasViewsForLocation('run-view-sidebar')) {
       const navigatorSplitWidget =