chrome-devtools-frontend 1.0.1036726 → 1.0.1037221

package/front_end/entrypoints/main/MainImpl.ts

@@ -298,7 +298,7 @@ export class MainImpl {
         'https://developer.chrome.com/blog/new-in-devtools-92/#source-order');
     Root.Runtime.experiments.register('webauthnPane', 'WebAuthn Pane');
     Root.Runtime.experiments.register(
-        'keyboardShortcutEditor', 'Enable keyboard shortcut editor', true,
+        'keyboardShortcutEditor', 'Enable keyboard shortcut editor', false,
         'https://developer.chrome.com/blog/new-in-devtools-88/#keyboard-shortcuts');
 
     // Back/forward cache
@@ -429,6 +429,7 @@ export class MainImpl {
       Root.Runtime.ExperimentName.CSS_LAYERS,
       ...('EyeDropper' in window ? [Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER] : []),
       'lighthousePanelFR',
+      'keyboardShortcutEditor',
     ]);
 
     Root.Runtime.experiments.setNonConfigurableExperiments([

package/front_end/panels/media/PlayerPropertiesView.ts

@@ -4,6 +4,7 @@
 
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
+import * as SourceFrame from '../../ui/legacy/components/source_frame/source_frame.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import playerPropertiesViewStyles from './playerPropertiesView.css.js';
@@ -136,7 +137,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 type TabData = {
-  [x: string]: string,
+  [x: string]: string|object,
 };
 
 // Keep this enum in sync with panels/media/base/media_log_properties.h
@@ -179,7 +180,7 @@ export class PropertyRenderer extends UI.Widget.VBox {
     super();
     this.contentElement.classList.add('media-property-renderer');
     const titleElement = this.contentElement.createChild('span', 'media-property-renderer-title');
-    this.contents = this.contentElement.createChild('span', 'media-property-renderer-contents');
+    this.contents = this.contentElement.createChild('div', 'media-property-renderer-contents');
     UI.UIUtils.createTextChild(titleElement, title);
     this.title = title;
     this.value = null;
@@ -213,16 +214,36 @@ export class PropertyRenderer extends UI.Widget.VBox {
     }
   }
 
+  protected unsetNestedContents(): void {
+    this.contentElement.classList.add('media-property-renderer-hidden');
+    if (this.pseudoColorProtectionElement === null) {
+      this.pseudoColorProtectionElement = document.createElement('div');
+      this.pseudoColorProtectionElement.classList.add('media-property-renderer');
+      this.pseudoColorProtectionElement.classList.add('media-property-renderer-hidden');
+      (this.contentElement.parentNode as HTMLElement)
+          .insertBefore(this.pseudoColorProtectionElement, this.contentElement);
+    }
+  }
+
+  changeNestedContents(value: object): void {
+    if (value === null || Object.keys(value).length === 0) {
+      this.unsetNestedContents();
+    } else {
+      if (this.pseudoColorProtectionElement !== null) {
+        this.pseudoColorProtectionElement.remove();
+        this.pseudoColorProtectionElement = null;
+      }
+      this.contentElement.classList.remove('media-property-renderer-hidden');
+      this.contents.removeChildren();
+      const jsonWrapperElement =
+          new SourceFrame.JSONView.JSONView(new SourceFrame.JSONView.ParsedJSON(value, '', ''), true);
+      jsonWrapperElement.show(this.contents);
+    }
+  }
+
   changeContents(value: string|null): void {
     if (value === null) {
-      this.contentElement.classList.add('media-property-renderer-hidden');
-      if (this.pseudoColorProtectionElement === null) {
-        this.pseudoColorProtectionElement = document.createElement('div');
-        this.pseudoColorProtectionElement.classList.add('media-property-renderer');
-        this.pseudoColorProtectionElement.classList.add('media-property-renderer-hidden');
-        (this.contentElement.parentNode as HTMLElement)
-            .insertBefore(this.pseudoColorProtectionElement, this.contentElement);
-      }
+      this.unsetNestedContents();
     } else {
       if (this.pseudoColorProtectionElement !== null) {
         this.pseudoColorProtectionElement.remove();
@@ -260,6 +281,13 @@ export class DefaultPropertyRenderer extends PropertyRenderer {
   }
 }
 
+export class NestedPropertyRenderer extends PropertyRenderer {
+  constructor(title: Platform.UIString.LocalizedString, content: object) {
+    super(title);
+    this.changeNestedContents(content);
+  }
+}
+
 export class DimensionPropertyRenderer extends PropertyRenderer {
   private width: number;
   private height: number;
@@ -337,7 +365,11 @@ export class TrackManager {
   addNewTab(tabs: GenericTrackMenu|NoTracksPlaceholderMenu, tabData: TabData, tabNumber: number): void {
     const tabElements = [];
     for (const [name, data] of Object.entries(tabData)) {
-      tabElements.push(new DefaultPropertyRenderer(i18n.i18n.lockedString(name), data));
+      if (typeof data === 'object') {
+        tabElements.push(new NestedPropertyRenderer(i18n.i18n.lockedString(name), data));
+      } else {
+        tabElements.push(new DefaultPropertyRenderer(i18n.i18n.lockedString(name), data));
+      }
     }
     const newTab = new AttributesView(tabElements);
 

package/front_end/panels/media/playerPropertiesView.css

@@ -12,6 +12,8 @@
   line-height: 20px;
   min-height: 28px;
   padding: 4px 10px;
+  display: block;
+  overflow: hidden;
 }
 
 .media-property-renderer-hidden {
@@ -19,14 +21,23 @@
 }
 
 .media-property-renderer-title {
-  font-size: 14px;
+  font-size: 12px;
+  float: left;
+  width: 150px;
+}
+
+.media-property-renderer-title::first-letter {
+  text-transform: uppercase;
 }
 
 .media-property-renderer-contents {
-  position: absolute;
+  position: relative;
   left: 200px;
+}
+
+.media-property-renderer-contents > .json-view {
   overflow: hidden;
-  height: 20px;
+  padding: 0;
 }
 
 .media-property-renderer:nth-child(even) {
@@ -37,10 +48,18 @@
   background: var(--color-background-hover-overlay);
 }
 
+.media-property-renderer:has(.json-view) {
+  padding-bottom: 0;
+}
+
 .-theme-with-dark-background .media-property-renderer:nth-child(even) {
   background: rgb(41 41 41);
 }
 
+.media-property-renderer:has(.json-view > .expanded) {
+  padding-bottom: 4px;
+}
+
 .media-properties-frame {
   display: block;
   overflow-x: hidden;

package/front_end/panels/sources/components/BreakpointsView.ts

@@ -119,19 +119,14 @@ export class BreakpointsView extends HTMLElement {
   }
 
   #renderBreakpointGroup(group: BreakpointGroup): LitHtml.TemplateResult {
-    const groupClassMap = {
-      'expanded': group.expanded,
-    };
     // clang-format off
     return LitHtml.html`
-      <div data-group='true' class=${LitHtml.Directives.classMap(groupClassMap)}>
-        <div class='group-header' @click=${(): void => this.#onGroupExpandToggled(group)}>
-            <span class='triangle'></span>
-            ${this.#renderFileIcon()}
-            <span class='group-header-title'>${group.name}</span>
-        </div>
-        ${group.expanded? LitHtml.html`
-          ${group.breakpointItems.map(entry => this.#renderBreakpointEntry(entry))}` : LitHtml.nothing}
+      <details data-group='true' ?open=${group.expanded} @click=${(e: Event): void => this.#onGroupExpandToggled(e, group)}>
+        <summary>
+          <span class='group-header'>${this.#renderFileIcon()}<span class='group-header-title'>${group.name}</span></span>
+        </summary>
+        ${LitHtml.html`
+          ${group.breakpointItems.map(entry => this.#renderBreakpointEntry(entry))}`}
       </div>
       `;
     // clang-format on
@@ -155,7 +150,7 @@ export class BreakpointsView extends HTMLElement {
 
     // clang-format off
     return LitHtml.html`
-    <div class=${LitHtml.Directives.classMap(classMap)} aria-label=${breakpointItemDescription}  tabIndex=${breakpointItem.isHit ? 0 : 1}>
+    <div class=${LitHtml.Directives.classMap(classMap)} aria-label=${breakpointItemDescription}  tabIndex=${breakpointItem.isHit ? 0 : -1}>
       <label class='checkbox-label'>
         <input type='checkbox' aria-label=${breakpointItem.location} ?indeterminate=${breakpointItem.status === BreakpointStatus.INDETERMINATE} ?checked=${breakpointItem.status === BreakpointStatus.ENABLED} @change=${(e: Event): void => this.#onCheckboxToggled(e, breakpointItem)}>
       </label>
@@ -185,10 +180,10 @@ export class BreakpointsView extends HTMLElement {
     return i18nString(UIStrings.breakpointHit, {PH1: checkboxDescription});
   }
 
-  #onGroupExpandToggled(group: BreakpointGroup): void {
-    group.expanded = !group.expanded;
-    this.dispatchEvent(new ExpandedStateChangedEvent(group.url, group.expanded));
-    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
+  #onGroupExpandToggled(e: Event, group: BreakpointGroup): void {
+    const detailsElement = e.target as HTMLDetailsElement;
+    group.expanded = detailsElement.open;
+    this.dispatchEvent(new ExpandedStateChangedEvent(group.url, detailsElement.open));
   }
 
   #onCheckboxToggled(e: Event, item: BreakpointItem): void {

package/front_end/panels/sources/components/breakpointsView.css

@@ -35,26 +35,34 @@ input {
   margin: 3px 0;
 }
 
-.triangle {
-  margin-left: 6px;
-  margin-right: 4px;
-  display: inline-block;
+details > summary {
+  height: 18px;
+  list-style: none;
+  display: flex;
+  padding: 4px 4px 4px 6px;
+  align-items: center;
+}
+
+details > summary::before {
+  display: block;
+  user-select: none;
   -webkit-mask-image: var(--image-file-treeoutlineTriangles);
   -webkit-mask-size: 32px 24px;
   -webkit-mask-position: 0 0;
-  background-color: var(--color-text-primary);
+  background-color: var(--color-text-secondary);
+  content: "";
   height: 12px;
-  width: 8px;
+  width: 9px;
+  overflow: hidden;
 }
 
-.group-header {
-  display: flex;
-  align-items: center;
-  height: 18px;
+details[open] > summary::before {
+  -webkit-mask-position: -16px 0;
 }
 
-.expanded > .group-header > .triangle {
-  -webkit-mask-position: -16px 0;
+.group-header {
+  display: inline-flex;
+  align-items: center;
 }
 
 .group-header-title {
@@ -84,7 +92,7 @@ input {
 }
 
 .checkbox-label {
-  padding-left: 24px;
+  padding-left: 20px;
   display: flex;
   align-items: center;
 }

package/front_end/panels/timeline/TimelineLoader.ts

@@ -136,7 +136,7 @@ export class TimelineLoader implements Common.StringOutputStream.OutputStream {
     this.firstRawChunk = false;
 
     if (this.state === State.Initial) {
-      if (chunk.startsWith('{"nodes":[')) {
+      if (chunk.match(/^{(\s)*"nodes":(\s)*\[/)) {
         this.state = State.LoadingCPUProfileFormat;
       } else if (chunk[0] === '{') {
         this.state = State.LookingForEvents;

package/front_end/ui/components/text_prompt/TextPrompt.ts

@@ -68,7 +68,7 @@ export class TextPrompt extends HTMLElement {
 
   onInput(): void {
     this.#suggestion().value = this.#text();
-    this.dispatchEvent(new PromptInputEvent(this.#text().trim()));
+    this.dispatchEvent(new PromptInputEvent(this.#text()));
   }
 
   onKeyDown(event: KeyboardEvent): void {

package/front_end/ui/legacy/components/quick_open/FilteredListWidget.ts

@@ -209,7 +209,7 @@ export class FilteredListWidget extends Common.ObjectWrapper.eventMixin<EventTyp
   }
 
   private cleanValue(): string {
-    return this.query.substring(this.prefix.length);
+    return this.query.substring(this.prefix.length).trim();
   }
 
   wasShown(): void {

package/package.json

@@ -56,5 +56,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1036726"
+  "version": "1.0.1037221"
 }