chrome-devtools-frontend 1.0.1033423 → 1.0.1033742

package/config/gni/devtools_grd_files.gni

@@ -286,9 +286,14 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/arInvalidRegisterSourceHeader.md",
   "front_end/models/issues_manager/descriptions/arInvalidRegisterTriggerHeader.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
+  "front_end/models/issues_manager/descriptions/arSourceAndTriggerHeaders.md",
+  "front_end/models/issues_manager/descriptions/arSourceIgnored.md",
+  "front_end/models/issues_manager/descriptions/arTriggerIgnored.md",
   "front_end/models/issues_manager/descriptions/arUntrustworthyReportingOrigin.md",
   "front_end/models/issues_manager/descriptions/clientHintMetaTagAllowListInvalidOrigin.md",
   "front_end/models/issues_manager/descriptions/clientHintMetaTagModifiedHTML.md",
+  "front_end/models/issues_manager/descriptions/cookieExcludeDomainNonAscii.md",
+  "front_end/models/issues_manager/descriptions/cookieWarnDomainNonAscii.md",
   "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",
   "front_end/models/issues_manager/descriptions/corsDisabledScheme.md",
   "front_end/models/issues_manager/descriptions/corsDisallowedByMode.md",

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -16,6 +16,9 @@ export const enum IssueCode {
   InvalidRegisterTriggerHeader = 'AttributionReportingIssue::InvalidRegisterTriggerHeader',
   InvalidEligibleHeader = 'AttributionReportingIssue::InvalidEligibleHeader',
   TooManyConcurrentRequests = 'AttributionReportingIssue::TooManyConcurrentRequests',
+  SourceAndTriggerHeaders = 'AttributionReportingIssue::SourceAndTriggerHeaders',
+  SourceIgnored = 'AttributionReportingIssue::SourceIgnored',
+  TriggerIgnored = 'AttributionReportingIssue::TriggerIgnored',
   // TODO(apaseltiner): Remove this once old issue types are removed from
   // protocol.
   Unknown = 'AttributionReportingIssue::Unknown',
@@ -37,11 +40,22 @@ function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails)
       return IssueCode.InvalidEligibleHeader;
     case Protocol.Audits.AttributionReportingIssueType.TooManyConcurrentRequests:
       return IssueCode.TooManyConcurrentRequests;
+    case Protocol.Audits.AttributionReportingIssueType.SourceAndTriggerHeaders:
+      return IssueCode.SourceAndTriggerHeaders;
+    case Protocol.Audits.AttributionReportingIssueType.SourceIgnored:
+      return IssueCode.SourceIgnored;
+    case Protocol.Audits.AttributionReportingIssueType.TriggerIgnored:
+      return IssueCode.TriggerIgnored;
     default:
       return IssueCode.Unknown;
   }
 }
 
+const structuredHeaderLink = {
+  link: 'https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html#rfc.section.4.2.2',
+  linkTitle: 'Structured Headers RFC',
+};
+
 export class AttributionReportingIssue extends Issue<IssueCode> {
   issueDetails: Readonly<Protocol.Audits.AttributionReportingIssueDetails>;
 
@@ -85,16 +99,28 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidEligibleHeader:
         return {
           file: 'arInvalidEligibleHeader.md',
-          links: [{
-            link: 'https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html#rfc.section.4.2.2',
-            linkTitle: 'Structured Headers RFC',
-          }],
+          links: [structuredHeaderLink],
         };
       case IssueCode.TooManyConcurrentRequests:
         return {
           file: 'arTooManyConcurrentRequests.md',
           links: [],
         };
+      case IssueCode.SourceAndTriggerHeaders:
+        return {
+          file: 'arSourceAndTriggerHeaders.md',
+          links: [],
+        };
+      case IssueCode.SourceIgnored:
+        return {
+          file: 'arSourceIgnored.md',
+          links: [structuredHeaderLink],
+        };
+      case IssueCode.TriggerIgnored:
+        return {
+          file: 'arTriggerIgnored.md',
+          links: [structuredHeaderLink],
+        };
       case IssueCode.Unknown:
         return null;
     }

package/front_end/models/issues_manager/CookieIssue.ts

@@ -435,6 +435,16 @@ const attributeValueExceedsMaxSize: LazyMarkdownIssueDescription = {
   links: [],
 };
 
+const warnDomainNonAscii: LazyMarkdownIssueDescription = {
+  file: 'cookieWarnDomainNonAscii.md',
+  links: [],
+};
+
+const excludeDomainNonAscii: LazyMarkdownIssueDescription = {
+  file: 'cookieExcludeDomainNonAscii.md',
+  links: [],
+};
+
 const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::ReadCookie', sameSiteUnspecifiedErrorRead],
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::SetCookie', sameSiteUnspecifiedErrorSet],
@@ -466,4 +476,8 @@ const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeSamePartyCrossPartyContext::SetCookie', samePartyCrossPartyContextSet],
   ['CookieIssue::WarnAttributeValueExceedsMaxSize::ReadCookie', attributeValueExceedsMaxSize],
   ['CookieIssue::WarnAttributeValueExceedsMaxSize::SetCookie', attributeValueExceedsMaxSize],
+  ['CookieIssue::WarnDomainNonASCII::ReadCookie', warnDomainNonAscii],
+  ['CookieIssue::WarnDomainNonASCII::SetCookie', warnDomainNonAscii],
+  ['CookieIssue::ExcludeDomainNonASCII::ReadCookie', excludeDomainNonAscii],
+  ['CookieIssue::ExcludeDomainNonASCII::SetCookie', excludeDomainNonAscii],
 ]);

package/front_end/models/issues_manager/descriptions/arSourceAndTriggerHeaders.md

@@ -0,0 +1,9 @@
+# Ensure that attribution responses contain either source or trigger, not both
+
+This page tried to register a source and a trigger in the same HTTP response
+using the Attribution Reporting API, which is prohibited.
+
+The corresponding request was eligible to register either a source or a
+trigger, but the response may only set either the
+`Attribution-Reporting-Register-Source` header or the
+`Attribution-Reporting-Register-Trigger` header, not both.

package/front_end/models/issues_manager/descriptions/arSourceIgnored.md

@@ -0,0 +1,13 @@
+# An attribution source registration was ignored because the request was ineligible
+
+This page tried to register a source using the Attribution Reporting API, but
+the request was ineligible to do so, so the source registration was ignored.
+
+A request is eligible for source registration if it has an
+`Attribution-Reporting-Eligible` header whose value is a structured dictionary
+that contains the key `navigation-source` or `event-source`. If the header is
+absent or does not contain one of those keys, any
+`Attribution-Reporting-Register-Source` response header will be ignored.
+
+Additionally, a single HTTP redirect chain may register only all sources or all
+triggers, not a combination of both.

package/front_end/models/issues_manager/descriptions/arTriggerIgnored.md

@@ -0,0 +1,12 @@
+# An attribution trigger registration was ignored because the request was ineligible
+
+This page tried to register a trigger using the Attribution Reporting API, but
+the request was ineligible to do so, so the trigger registration was ignored.
+
+A request is eligible for trigger registration if it has an
+`Attribution-Reporting-Eligible` header whose value is a structured dictionary
+that contains the key `trigger`, or if the header is absent. Otherwise, any
+`Attribution-Reporting-Register-Trigger` response header will be ignored.
+
+Additionally, a single HTTP redirect chain may register only all sources or all
+triggers, not a combination of both.

package/front_end/models/issues_manager/descriptions/cookieExcludeDomainNonAscii.md

@@ -0,0 +1,11 @@
+# Ensure cookie `Domain` attribute values only contain ASCII characters
+
+`Domain` attributes in cookies are restricted to the ASCII character set. Any
+cookies that contain characters outside of the ASCII range in their `Domain`
+attribute will be ignored.
+
+To resolve this issue, you need to remove all non-ASCII characters from the
+`Domain` attribute of the affected cookies.
+
+If your site has an internationalized domain name (IDN), you should use
+[punycode](punycodeReference) representation for the `Domain` attribute instead.

package/front_end/models/issues_manager/descriptions/cookieWarnDomainNonAscii.md

@@ -0,0 +1,11 @@
+# Ensure cookie `Domain` attribute values only contain ASCII characters
+
+`Domain` attributes in cookies are restricted to the ASCII character set. Any
+cookies that contain characters outside of the ASCII range in their `Domain`
+attribute will be ignored in the future.
+
+To resolve this issue, you need to remove all non-ASCII characters from the
+`Domain` attribute of the affected cookies.
+
+If your site has an internationalized domain name (IDN), you should use
+[punycode](punycodeReference) representation for the `Domain` attribute instead.

package/front_end/panels/console/ConsolePinPane.ts

@@ -329,8 +329,8 @@ export class ConsolePin {
     const executionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
     const preprocessedExpression = ObjectUI.JavaScriptREPL.JavaScriptREPL.preprocessExpression(text);
     const {preview, result} = await ObjectUI.JavaScriptREPL.JavaScriptREPL.evaluateAndBuildPreview(
-        preprocessedExpression, throwOnSideEffect, false /* replMode */, timeout, !isEditing /* allowErrors */,
-        'console', true /* awaitPromise */);
+        preprocessedExpression, throwOnSideEffect, true /* replMode */, timeout, !isEditing /* allowErrors */,
+        'console', true /* awaitPromise */, true /* silent */);
     if (this.lastResult && this.lastExecutionContext) {
       this.lastExecutionContext.runtimeModel.releaseEvaluationResult(this.lastResult);
     }

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -62,6 +62,8 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterSourceHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterTriggerHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEligibleHeader:
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceIgnored:
+      case IssuesManager.AttributionReportingIssue.IssueCode.TriggerIgnored:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidHeaderValue));
         break;
@@ -79,6 +81,9 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.maximumConcurrentRegistrations));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceAndTriggerHeaders:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        break;
     }
 
     this.affectedResources.appendChild(header);
@@ -102,6 +107,8 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterSourceHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterTriggerHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEligibleHeader:
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceIgnored:
+      case IssuesManager.AttributionReportingIssue.IssueCode.TriggerIgnored:
         this.#appendRequestOrEmptyCell(element, details.request);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
@@ -119,6 +126,9 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         await this.#appendElementOrEmptyCell(element, issue);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceAndTriggerHeaders:
+        this.#appendRequestOrEmptyCell(element, details.request);
+        break;
     }
 
     this.affectedResources.appendChild(element);

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -307,6 +307,22 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     return objType.slice(0, objType.length - 1);
   }
 
+  // When inspecting a pointer variable, we indicate that we display the pointed-to object in the viewer
+  // by prepending an asterisk to the pointer expression's name (mimicking C++ dereferencing).
+  // If the object isn't a pointer, we return the expression unchanged.
+  //
+  // Examples:
+  // (int *) myNumber -> (int) *myNumber
+  // (int[]) numbers -> (int[]) numbers
+  static extractObjectName(obj: Bindings.DebuggerLanguagePlugins.ValueNode, expression: string): string {
+    const lastChar = obj.description?.charAt(obj.description.length - 1);
+    const isPointerType = lastChar === '*';
+    if (isPointerType) {
+      return '*' + expression;
+    }
+    return expression;
+  }
+
   async openInspectorView(obj: SDK.RemoteObject.RemoteObject, address?: number, expression?: string): Promise<void> {
     const response = await LinearMemoryInspectorController.retrieveDWARFMemoryObjectAndAddress(obj);
     let memoryObj = obj;
@@ -368,7 +384,7 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
       highlightInfo = {
         startAddress: obj.inspectableAddress || 0,
         size: LinearMemoryInspectorController.extractObjectSize(obj),
-        name: expression,
+        name: expression ? LinearMemoryInspectorController.extractObjectName(obj, expression) : expression,
         type: LinearMemoryInspectorController.extractObjectTypeDescription(obj),
       };
     } catch (err) {

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -27,6 +27,7 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['issueQuirksModeDoctype', 'https://web.dev/doctype/'],
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
+  ['punycodeReference', 'https://wikipedia.org/wiki/Punycode'],
   // Link URLs for deprecation issues (see blink::Deprecation)
   ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
   ['https://goo.gle/chrome-insecure-origins', 'https://goo.gle/chrome-insecure-origins'],

package/front_end/ui/legacy/components/object_ui/JavaScriptREPL.ts

@@ -36,7 +36,7 @@ export class JavaScriptREPL {
 
   static async evaluateAndBuildPreview(
       text: string, throwOnSideEffect: boolean, replMode: boolean, timeout?: number, allowErrors?: boolean,
-      objectGroup?: string, awaitPromise: boolean = false): Promise<{
+      objectGroup?: string, awaitPromise: boolean = false, silent: boolean = false): Promise<{
     preview: DocumentFragment,
     result: SDK.RuntimeModel.EvaluationResult|null,
   }> {
@@ -56,7 +56,7 @@ export class JavaScriptREPL {
       objectGroup: objectGroup,
       disableBreaks: true,
       replMode: replMode,
-      silent: undefined,
+      silent: silent,
       returnByValue: undefined,
       allowUnsafeEvalBlockedByCSP: undefined,
     };

package/package.json

@@ -56,5 +56,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1033423"
+  "version": "1.0.1033742"
 }