chrome-devtools-frontend 1.0.1028626 → 1.0.1029795

package/front_end/panels/protocol_monitor/ProtocolMonitor.ts

@@ -82,6 +82,11 @@ const UIStrings = {
   *@description A placeholder for an input in Protocol Monitor. The input accepts commands that are sent to the backend on Enter. CDP stands for Chrome DevTools Protocol.
   */
   sendRawCDPCommand: 'Send a raw `CDP` command',
+  /**
+   * @description A tooltip text for the input in the Protocol Monitor panel. The tooltip describes what format is expected.
+   */
+  sendRawCDPCommandExplanation:
+      'Format: `\'Domain.commandName\'` for a command without parameters, or `\'{"command":"Domain.commandName", "parameters": {...}}\'` as a JSON object for a command with parameters. `\'cmd\'`/`\'method\'` and `\'args\'`/`\'params\'`/`\'arguments\'` are also supported as alternative keys for the `JSON` object.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/protocol_monitor/ProtocolMonitor.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -120,6 +125,8 @@ export class ProtocolMonitorImpl extends UI.Widget.VBox {
   private messages: LogMessage[] = [];
   private isRecording: boolean = false;
 
+  #historyAutocompleteDataProvider = new HistoryAutocompleteDataProvider();
+
   constructor() {
     super(true);
     this.started = false;
@@ -287,31 +294,35 @@ export class ProtocolMonitorImpl extends UI.Widget.VBox {
     });
     topToolbar.appendToolbarItem(this.textFilterUI);
 
-    const onSend = (): void => {
-      const value = input.value();
-      // If input cannot be parsed as json, we assume it's the command name
-      // for a command without parameters. Otherwise, we expect an object
-      // with "command" and "parameters" attributes.
-      let json = null;
-      try {
-        json = JSON.parse(value);
-      } catch (err) {
-      }
-      const command = json ? json.command : value;
-      const parameters = json ? json.parameters : null;
-      const test = ProtocolClient.InspectorBackend.test;
-      // TODO: TS thinks that properties are read-only because
-      // in TS test is defined as a namespace.
-      // @ts-ignore
-      test.sendRawMessage(command, parameters, () => {});
-    };
-    const input = new UI.Toolbar.ToolbarInput(i18nString(UIStrings.sendRawCDPCommand), '', 1, .2, '', undefined, false);
-    input.addEventListener(UI.Toolbar.ToolbarInput.Event.EnterPressed, onSend);
     const bottomToolbar = new UI.Toolbar.Toolbar('protocol-monitor-bottom-toolbar', this.contentElement);
-    bottomToolbar.appendToolbarItem(input);
+    bottomToolbar.appendToolbarItem(this.#createCommandInput());
   }
 
-  static instance(opts = {forceNew: null}): ProtocolMonitorImpl {
+  #createCommandInput(): UI.Toolbar.ToolbarInput {
+    const placeholder = i18nString(UIStrings.sendRawCDPCommand);
+    const accessiblePlaceholder = placeholder;
+    const growFactor = 1;
+    const shrinkFactor = 0.2;
+    const tooltip = i18nString(UIStrings.sendRawCDPCommandExplanation);
+    const input = new UI.Toolbar.ToolbarInput(
+        placeholder, accessiblePlaceholder, growFactor, shrinkFactor, tooltip,
+        this.#historyAutocompleteDataProvider.buildTextPromptCompletions, false);
+    input.addEventListener(UI.Toolbar.ToolbarInput.Event.EnterPressed, () => this.#onCommandSend(input));
+    return input;
+  }
+
+  #onCommandSend(input: UI.Toolbar.ToolbarInput): void {
+    const value = input.value();
+    const {command, parameters} = parseCommandInput(value);
+    const test = ProtocolClient.InspectorBackend.test;
+    // TODO: TS thinks that properties are read-only because
+    // in TS test is defined as a namespace.
+    // @ts-ignore
+    test.sendRawMessage(command, parameters, () => {});
+    this.#historyAutocompleteDataProvider.addEntry(value);
+  }
+
+  static instance(opts: {forceNew: null|boolean} = {forceNew: null}): ProtocolMonitorImpl {
     const {forceNew} = opts;
     if (!protocolMonitorImplInstance || forceNew) {
       protocolMonitorImplInstance = new ProtocolMonitorImpl();
@@ -481,6 +492,39 @@ export class ProtocolMonitorImpl extends UI.Widget.VBox {
   }
 }
 
+export class HistoryAutocompleteDataProvider {
+  #maxHistorySize = 200;
+  #commandHistory = new Set<string>();
+
+  constructor(maxHistorySize?: number) {
+    if (maxHistorySize !== undefined) {
+      this.#maxHistorySize = maxHistorySize;
+    }
+  }
+
+  buildTextPromptCompletions =
+      async(expression: string, prefix: string, force?: boolean): Promise<UI.SuggestBox.Suggestions> => {
+    if (!prefix && !force && expression) {
+      return [];
+    }
+    const newestToOldest = [...this.#commandHistory].reverse();
+    return newestToOldest.filter(cmd => cmd.startsWith(prefix)).map(text => ({
+                                                                      text,
+                                                                    }));
+  };
+
+  addEntry(value: string): void {
+    if (this.#commandHistory.has(value)) {
+      this.#commandHistory.delete(value);
+    }
+    this.#commandHistory.add(value);
+    if (this.#commandHistory.size > this.#maxHistorySize) {
+      const earliestEntry = this.#commandHistory.values().next().value;
+      this.#commandHistory.delete(earliestEntry);
+    }
+  }
+}
+
 export class InfoWidget extends UI.Widget.VBox {
   private readonly tabbedPane: UI.TabbedPane.TabbedPane;
   constructor() {
@@ -518,3 +562,17 @@ export class InfoWidget extends UI.Widget.VBox {
     this.tabbedPane.changeTabView('response', SourceFrame.JSONView.JSONView.createViewSync(responseParsed));
   }
 }
+
+export function parseCommandInput(input: string): {command: string, parameters: unknown} {
+  // If input cannot be parsed as json, we assume it's the command name
+  // for a command without parameters. Otherwise, we expect an object
+  // with "command"/"method"/"cmd" and "parameters"/"params"/"args"/"arguments" attributes.
+  let json = null;
+  try {
+    json = JSON.parse(input);
+  } catch (err) {
+  }
+  const command = json ? json.command || json.method || json.cmd : input;
+  const parameters = json ? json.parameters || json.params || json.args || json.arguments : null;
+  return {command, parameters};
+}

package/front_end/panels/timeline/TimelineLoader.ts

@@ -98,7 +98,8 @@ export class TimelineLoader implements Common.StringOutputStream.OutputStream {
 
   static loadFromURL(url: Platform.DevToolsPath.UrlString, client: Client): TimelineLoader {
     const loader = new TimelineLoader(client);
-    Host.ResourceLoader.loadAsStream(url, null, loader);
+    const allowFileUNCPaths = Common.Settings.Settings.instance().moduleSetting('network.enable-unc-loading').get();
+    Host.ResourceLoader.loadAsStream(url, null, loader, undefined, allowFileUNCPaths);
     return loader;
   }
 

package/front_end/ui/legacy/SplitWidget.ts

@@ -532,6 +532,7 @@ export class SplitWidget extends Common.ObjectWrapper.eventMixin<EventTypes, typ
     // This order of things is important.
     // 1. Resize main element early and force layout.
     this.contentElement.style.setProperty(animatedMarginPropertyName, marginFrom);
+    this.contentElement.style.setProperty('overflow', 'hidden');
     if (!reverse) {
       suppressUnused(this.mainElement.offsetWidth);
       suppressUnused(this.sidebarElementInternal.offsetWidth);
@@ -579,6 +580,7 @@ export class SplitWidget extends Common.ObjectWrapper.eventMixin<EventTypes, typ
     this.contentElement.style.removeProperty('margin-bottom');
     this.contentElement.style.removeProperty('margin-left');
     this.contentElement.style.removeProperty('transition');
+    this.contentElement.style.removeProperty('overflow');
 
     if (this.animationFrameHandle) {
       this.contentElement.window().cancelAnimationFrame(this.animationFrameHandle);

package/front_end/ui/legacy/TextPrompt.ts

@@ -89,7 +89,7 @@ export class TextPrompt extends Common.ObjectWrapper.ObjectWrapper<EventTypes> i
   }
 
   initialize(
-      completions: (this: null, arg1: string, arg2: string, arg3?: boolean|undefined) => Promise<Suggestion[]>,
+      completions: (this: null, expression: string, filter: string, force?: boolean|undefined) => Promise<Suggestion[]>,
       stopCharacters?: string, usesSuggestionBuilder?: boolean): void {
     this.loadCompletions = completions;
     this.completionStopCharacters = stopCharacters || ' =:[({;,!+-*/&|^<>.';

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -437,6 +437,8 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
       progressIndicator.setTotalWork(100);
       this.progressToolbarItem.element.appendChild(progressIndicator.element);
 
+      progressIndicator.setWorked(1);
+
       const deferredContent = await this.lazyContent();
       let error, content;
       if (deferredContent.content === null) {
@@ -448,57 +450,13 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
           const view = new DataView(Common.Base64.decode(deferredContent.content));
           const decoder = new TextDecoder();
           this.rawContent = decoder.decode(view, {stream: true});
+        } else if ('wasmDisassemblyInfo' in deferredContent && deferredContent.wasmDisassemblyInfo) {
+          const {wasmDisassemblyInfo} = deferredContent;
+          this.rawContent = CodeMirror.Text.of(wasmDisassemblyInfo.lines);
+          this.wasmDisassemblyInternal = wasmDisassemblyInfo;
         } else {
-          this.rawContent = deferredContent.content;
-        }
-      }
-
-      progressIndicator.setWorked(1);
-
-      if (!error && this.contentType === 'application/wasm') {
-        const worker = Common.Worker.WorkerWrapper.fromURL(
-            new URL('../../../../entrypoints/wasmparser_worker/wasmparser_worker-entrypoint.js', import.meta.url));
-        const promise = new Promise<{
-          lines: string[],
-          offsets: number[],
-          functionBodyOffsets: {
-            start: number,
-            end: number,
-          }[],
-        }>((resolve, reject) => {
-          worker.onmessage =
-              // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-              // eslint-disable-next-line @typescript-eslint/no-explicit-any
-              ({data}: MessageEvent<any>): void => {
-                if ('event' in data) {
-                  switch (data.event) {
-                    case 'progress':
-                      progressIndicator.setWorked(data.params.percentage);
-                      break;
-                  }
-                } else if ('method' in data) {
-                  switch (data.method) {
-                    case 'disassemble':
-                      if ('error' in data) {
-                        reject(data.error);
-                      } else if ('result' in data) {
-                        resolve(data.result);
-                      }
-                      break;
-                  }
-                }
-              };
-          worker.onerror = reject;
-        });
-        worker.postMessage({method: 'disassemble', params: {content}});
-        try {
-          const {lines, offsets, functionBodyOffsets} = await promise;
-          this.rawContent = content = CodeMirror.Text.of(lines);
-          this.wasmDisassemblyInternal = new Common.WasmDisassembly.WasmDisassembly(offsets, functionBodyOffsets);
-        } catch (e) {
-          this.rawContent = content = error = e.message;
-        } finally {
-          worker.terminate();
+          this.rawContent = content;
+          this.wasmDisassemblyInternal = null;
         }
       }
 
@@ -514,7 +472,7 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
         this.textEditor.editor.setState(this.placeholderEditorState(error));
         this.prettyToggle.setEnabled(false);
       } else {
-        if (this.shouldAutoPrettyPrint && TextUtils.TextUtils.isMinified(content)) {
+        if (this.shouldAutoPrettyPrint && TextUtils.TextUtils.isMinified(content || '')) {
           await this.setPretty(true);
         } else {
           await this.setContent(this.rawContent || '');

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1028626"
+  "version": "1.0.1029795"
 }

package/front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyFrameOrigin.md

@@ -1,4 +0,0 @@
-# Ensure an attribution source triggers in a secure context
-
-An attribution source event was not recorded because the frame that triggered the event (or the main frame if they
-are different) is not trustworthy.

package/front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyOrigin.md

@@ -1,5 +0,0 @@
-# Ensure the origins provided in an attribution source are trustworthy
-
-An attribution source event was not recorded because an untrustworthy origin was specified.
-Both, the `attributiondestination` and the `attributionreportto` origins must be
-trustworthy.

package/front_end/models/issues_manager/descriptions/arAttributionUntrustworthyFrameOrigin.md

@@ -1,4 +0,0 @@
-# Ensure an attribution triggers in a secure context
-
-An attribution was not recorded because the frame that triggered the attribution (or the main frame if they
-are different) is not trustworthy.

package/front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md

@@ -1,4 +0,0 @@
-# Ensure the origin of an attribution-registration request is trustworthy
-
-An attribution source or trigger was not registered because the origin of the
-request was not trustworthy.

package/front_end/models/issues_manager/descriptions/arInvalidHeader.md

@@ -1,3 +0,0 @@
-# Ensure that Attribution Reporting API response headers are valid
-
-This page tries to use the Attribution Reporting API but failed because a response header was invalid.