chrome-devtools-frontend 1.0.1026673 → 1.0.1027150

package/config/owner/LIGHTHOUSE_OWNERS

@@ -1,3 +1,3 @@
 paulirish@chromium.org
 cjamcl@chromium.org
-asraine@google.com
+asraine@chromium.org

package/front_end/core/host/UserMetrics.ts

@@ -636,8 +636,9 @@ export enum DevtoolsExperiments {
   'instrumentationBreakpoints' = 61,
   'cssAuthoringHints' = 62,
   'authoredDeployedGrouping' = 63,
+  'importantDOMProperties' = 64,
   // Increment this when new experiments are added.
-  'MaxValue' = 64,
+  'MaxValue' = 65,
 }
 /* eslint-enable @typescript-eslint/naming-convention */
 

package/front_end/core/i18n/locales/en-US.json

@@ -9548,6 +9548,12 @@
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | addPattern": {
     "message": "Add pattern..."
   },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScripts": {
+    "message": "Automatically add known third-party scripts to ignore list"
+  },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScriptsTooltip": {
+    "message": "Add sources from the x_google_ignoreList field from source maps to the ignore list"
+  },
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | behavior": {
     "message": "Behavior"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -9548,6 +9548,12 @@
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | addPattern": {
     "message": "Âd́d̂ ṕât́t̂ér̂ń..."
   },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScripts": {
+    "message": "Âút̂óm̂át̂íĉál̂ĺŷ ád̂d́ k̂ńôẃn̂ t́ĥír̂d́-p̂ár̂t́ŷ śĉŕîṕt̂ś t̂ó îǵn̂ór̂é l̂íŝt́"
+  },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScriptsTooltip": {
+    "message": "Âd́d̂ śôúr̂ćêś f̂ŕôḿ t̂h́ê x_google_ignoreList f́îél̂d́ f̂ŕôḿ ŝóûŕĉé m̂áp̂ś t̂ó t̂h́ê íĝńôŕê ĺîśt̂"
+  },
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | behavior": {
     "message": "B̂éĥáv̂íôŕ"
   },

package/front_end/core/root/Runtime.ts

@@ -293,6 +293,7 @@ export enum ExperimentName {
   INSTRUMENTATION_BREAKPOINTS = 'instrumentationBreakpoints',
   CSS_AUTHORING_HINTS = 'cssAuthoringHints',
   AUTHORED_DEPLOYED_GROUPING = 'authoredDeployedGrouping',
+  IMPORTANT_DOM_PROPERTIES = 'importantDOMProperties',
 }
 
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/core/sdk/NetworkManager.ts

@@ -914,8 +914,13 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     const oldDispatcher = (NetworkManager.forRequest(request) as NetworkManager).dispatcher;
     oldDispatcher.#requestsById.delete(requestId);
     oldDispatcher.#requestsByURL.delete(request.url());
+    const builder = oldDispatcher.#requestIdToExtraInfoBuilder.get(requestId);
+    oldDispatcher.#requestIdToExtraInfoBuilder.delete(requestId);
     this.#requestsById.set(requestId, request);
     this.#requestsByURL.set(request.url(), request);
+    if (builder) {
+      this.#requestIdToExtraInfoBuilder.set(requestId, builder);
+    }
     requestToManagerMap.set(request, this.#manager);
     return request;
   }
@@ -981,9 +986,21 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
   }
 
   clearRequests(): void {
-    this.#requestsById.clear();
-    this.#requestsByURL.clear();
-    this.#requestIdToExtraInfoBuilder.clear();
+    for (const [requestId, request] of this.#requestsById) {
+      if (request.finished) {
+        this.#requestsById.delete(requestId);
+      }
+    }
+    for (const [requestURL, request] of this.#requestsByURL) {
+      if (request.finished) {
+        this.#requestsByURL.delete(requestURL);
+      }
+    }
+    for (const [requestId, builder] of this.#requestIdToExtraInfoBuilder) {
+      if (builder.isFinished()) {
+        this.#requestIdToExtraInfoBuilder.delete(requestId);
+      }
+    }
   }
 
   webTransportCreated({transportId, url: requestURL, timestamp: time, initiator}:
@@ -1643,6 +1660,10 @@ class ExtraInfoBuilder {
     this.updateFinalRequest();
   }
 
+  isFinished(): boolean {
+    return this.#finishedInternal;
+  }
+
   private sync(index: number): void {
     const req = this.#requests[index];
     if (!req) {

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -232,7 +232,7 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
       this.processPendingEvents(frame);
       this.dispatchEventToListeners(Events.MainFrameNavigated, frame);
       const networkManager = this.target().model(NetworkManager);
-      if (networkManager) {
+      if (networkManager && frame.isTopFrame()) {
         networkManager.clearRequests();
       }
     }

package/front_end/core/sdk/sdk-meta.ts

@@ -332,6 +332,13 @@ Common.Settings.registerSettingExtension({
   defaultValue: false,
 });
 
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
+  settingName: 'automaticallyIgnoreListKnownThirdPartyScripts',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+});
+
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.CONSOLE,
   storageType: Common.Settings.SettingStorageType.Synced,

package/front_end/devtools_compatibility.js

@@ -1155,6 +1155,7 @@
       'showWhitespacesInEditor',
       'sidebarPosition',
       'skipContentScripts',
+      'automaticallyIgnoreListKnownThirdPartyScripts',
       'skipStackFramesPattern',
       'sourceMapInfobarDisabled',
       'sourcesPanelDebuggerSidebarSplitViewState',

package/front_end/entrypoints/main/MainImpl.ts

@@ -406,6 +406,11 @@ export class MainImpl {
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.AUTHORED_DEPLOYED_GROUPING, 'Group sources into Authored and Deployed trees');
 
+    // Highlight important DOM properties in the Object Properties viewer.
+    Root.Runtime.experiments.register(
+        Root.Runtime.ExperimentName.IMPORTANT_DOM_PROPERTIES,
+        'Highlight important DOM properties in the Object Properties viewer');
+
     Root.Runtime.experiments.enableExperimentsByDefault([
       'sourceOrderViewer',
       'hideIssuesFeature',