npm - chrome-devtools-frontend - Versions diffs - 1.0.1026160 → 1.0.1027447 - Mend

chrome-devtools-frontend 1.0.1026160 → 1.0.1027447

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (49) hide show

package/config/owner/LIGHTHOUSE_OWNERS CHANGED Viewed

@@ -1,3 +1,3 @@
 paulirish@chromium.org
 cjamcl@chromium.org
-asraine@google.com
+asraine@chromium.org

package/docs/triage_guidelines.md CHANGED Viewed

@@ -1,124 +1,3 @@
 # Triage Guidelines
-## Disclaimer
-The most important thing: please use common sense. The guidelines below are likely not exhaustive and do not cover every case.
-## What should be triaged?
-All `Untriaged` DevTools issues, as well as any `Unconfirmed` issues that also have the `TE-NeedsTriageHelp` label need to be triaged.
-[[Query]](https://bugs.chromium.org/p/chromium/issues/list?sort=-modified&q=-label%3ADevTools-Triaged%20component%3APlatform%3EDevTools%20status%3AUntriaged%20OR%20component%3APlatform%3EDevTools%20status%3AUnconfirmed%20label%3ATE-NeedsTriageHelp)
-## Who is triaging?
-Right now there is a Google-internal rotation set-up, with people that do weekly shifts.
-As Microsoft is in an opposite timezone they have a similar rotation on the same triage queue, but during a different time.
-- Google rotation: GMT+1
-- MS rotation: GMT-9
-## What are the SLOs?
-[[Query]](https://bugs.chromium.org/p/chromium/issues/list?q=component%3APlatform%3EDevTools%20status%3AUntriaged%20modified-before%3Atoday-7%20OR%20component%3APlatform%3EDevTools%20status%3AUnconfirmed%20label%3ATE-NeedsTriageHelp%20modified-before%3Atoday-7)
-Issues in the untriaged queue should receive a meaningful response within a business week. This means that the goal is to make the query mentioned above return zero issues.
-## How are priorities defined?
-- P0: This needs to be urgently done, fire drill alert!
-  - Most of the time, this seldom needs to be used.
-  - Critical security exploits that affect stable are a good example for a P0
-  - DevTools crashing on startup is a good example
-- P1: This is important. Let’s aim to get this done next
-  - Non-critical security fixes will likely be in this category
-  - Regression bugs will be likely in this category
-  - Important features that partners are waiting for might be in this category
-- P2: We want to do that. The exact time of delivery is not that important though.
-  - General feature work will likely be in this category
-  - Non-severe bugs
-- P3: This is nice, but not important. We unlikely will do work here.
-  - Edge-case bugs might fit this category
-  - Non-important feature requests too
-## How should issues be triaged?
-- Close issues as `WontFix` if they don't reproduce (in simple cases) or are requests for features we've already concluded not to pursue.
-- Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
-- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `DevTools-Triaged` label and leave the `Untriaged` status as is.
-- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
-- Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
-- Put one of the following labels on it and set the status to `Available`:
-  - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.
-  - `Team-DevTools-BrowserAutomation` if it's an issue related to ChromeDriver or puppeteer.
-  - `Team-DevTools-RuntimeDebugging` if it's a JavaScript or WebAssembly debugging issue.
-  - `Team-DevTools-WebDebugging` if it's a Web specific debugging issue (i.e. Network or Application panel).
-  - `Team-DevTools-DesignAccessibility` if it's a design or accessibility issue.
-  - `Team-DevTools-Performance` if the issue is related to our performance tooling (i.e. Performance panel, Lighthouse).
-  - `Team-DevTools-RecordReplay` if it's an issue with the recorder or puppeteer.
-  - No specific `Team` or `Hotlist` if it doesn't fit any specific team otherwise. Make sure to have the `Platform>DevTools` component (or a subcomponent) on it though.
-- Also remember to put the `Needs-UX` label on it, if help from a designer is likely to be required.
-### Setting Assigned or Available
-Set issues to `Available` if they don’t need immediate action and nobody right now and in the short-term future (an iteration) needs to work on it.
-Issues that are handled by Microsoft have the label “Hotlist-DevTools-MS-Backlog” and “Hotlist-DevTools-MS-CurrentSprint” respectively and can be considered triaged.
-If you think they are super urgent, please assign them to yangguo@chromium.org and cc bmeurer@chromium.org and hablich@chromium.org.
-### Closing issues
-Don’t be afraid to close issues with WontFix if:
-- Bugs that are not reproducible
-- After two weeks you did not get a response back from the reporter on a question
-- The requested “bug” is the intended behavior
-  Make sure that you bundle the WontFix with a brief comment explaining it e.g. “Setting to WontFix because not reproducible.”
-## FAQ
-### What if the issue belongs to another team?
-If you think the to-triage issue is not a DevTools issue, please simply set it to a component that you think it should belong to and potentially remove the DevTools component. Make sure that the status is set to Untriaged. Please also ensure that you add the label DevTools-Triaged to the bug to ensure that the bug does not come back to the DevTools component. Feel free to CC people that you think might help with triaging this.
-This essentially moves the issue out of the DevTools triage queue into another team’s queue.
-### What if the issue is best handled by Microsoft?
-If you think the to-triage issue or feature request is best handled by Microsoft then add the label "msft-consider" to the issue along with completing the other normal triage steps.
-### There is a feature request I am unsure how to handle. What should I do?
-Please set the request to Available and add the label “Hotlist-DevTools-ProductReview”.
-### How do I indicate that a bug should block a release?
-The combination of the label “M-<milestone>” and “Release-Block-<channel>” signals that this very bug is blocking a release. Examples:
-- M-80, Release-Block-Stable
-  - This blocks the release of 80 to the Stable channel
-  - Depends in which release channel 80 is, this might not be an urgent (but still important bug to fix)
-- M-81, Release-Block-Beta
-  - This blocks the release of 81 to the Beta channel
-  - Depends in which release channel 81 is, this might not be an urgent (but still important bug to fix)
-- M-81, Release-Block-Dev
-  - This blocks the release of 81 to the Dev channel
-  - This typically means that the bug is urgent and important, as Dev releases are happening every week and are ok to be a little bit buggy.
-## Out of scope
-### Managing the backlog
-[[Query]](https://bugs.chromium.org/p/chromium/issues/list?q=component%3APlatform%3EDevTools%20status%3AAvailable)
-Managing the backlog is out of scope for the triage rotation. The backlog will be groomed continuously by hablich@ for now. The SLA is that there should be a maximum of 50 issues in there.
-### Managing the ProductReview queue
-[[Query]](https://bugs.chromium.org/p/chromium/issues/list?q=Hotlist%3DDevTools-ProductReview)
-Issues in `ProductReview` will continuously be handled by hablich@ to unblock items in there. SLA is max 10 issues.
-## References
-- [Chromium triage guidelines](https://www.chromium.org/for-testers/bug-reporting-guidelines/triage-best-practices)
+Moved to [go/chrome-devtools/triage-sheriff](http://go/chrome-devtools/triage-sheriff).

package/front_end/core/host/UserMetrics.ts CHANGED Viewed

@@ -636,8 +636,9 @@ export enum DevtoolsExperiments {
   'instrumentationBreakpoints' = 61,
   'cssAuthoringHints' = 62,
   'authoredDeployedGrouping' = 63,
+  'importantDOMProperties' = 64,
   // Increment this when new experiments are added.
-  'MaxValue' = 64,
+  'MaxValue' = 65,
 }
 /* eslint-enable @typescript-eslint/naming-convention */

package/front_end/core/i18n/locales/en-US.json CHANGED Viewed

@@ -1709,6 +1709,12 @@
   "models/timeline_model/TimelineModel.ts | workerSS": {
     "message": "Worker: {PH1} — {PH2}"
   },
+  "models/timeline_model/TimelineModel.ts | workletService": {
+    "message": "Auction Worklet Service"
+  },
+  "models/timeline_model/TimelineModel.ts | workletServiceS": {
+    "message": "Auction Worklet Service — {PH1}"
+  },
   "models/workspace/UISourceCode.ts | index": {
     "message": "(index)"
   },
@@ -8921,6 +8927,12 @@
   "panels/security/SecurityPanel.ts | contentWithCertificateErrors": {
     "message": "content with certificate errors"
   },
+  "panels/security/SecurityPanel.ts | enabled": {
+    "message": "enabled"
+  },
+  "panels/security/SecurityPanel.ts | encryptedClientHello": {
+    "message": "Encrypted ClientHello"
+  },
   "panels/security/SecurityPanel.ts | flaggedByGoogleSafeBrowsing": {
     "message": "Flagged by Google Safe Browsing"
   },
@@ -9044,6 +9056,9 @@
   "panels/security/SecurityPanel.ts | securityOverview": {
     "message": "Security overview"
   },
+  "panels/security/SecurityPanel.ts | serverSignature": {
+    "message": "Server signature"
+  },
   "panels/security/SecurityPanel.ts | showFullDetails": {
     "message": "Show full details"
   },
@@ -9146,6 +9161,9 @@
   "panels/security/SecurityPanel.ts | unknownCanceled": {
     "message": "Unknown / canceled"
   },
+  "panels/security/SecurityPanel.ts | unknownField": {
+    "message": "unknown"
+  },
   "panels/security/SecurityPanel.ts | validAndTrusted": {
     "message": "valid and trusted"
   },
@@ -9530,6 +9548,12 @@
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | addPattern": {
     "message": "Add pattern..."
   },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScripts": {
+    "message": "Automatically add known third-party scripts to ignore list"
+  },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScriptsTooltip": {
+    "message": "Add sources from the x_google_ignoreList field from source maps to the ignore list"
+  },
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | behavior": {
     "message": "Behavior"
   },

package/front_end/core/i18n/locales/en-XL.json CHANGED Viewed

@@ -1709,6 +1709,12 @@
   "models/timeline_model/TimelineModel.ts | workerSS": {
     "message": "Worker: {PH1} — {PH2}"
   },
+  "models/timeline_model/TimelineModel.ts | workletService": {
+    "message": "Âúĉt́îón̂ Ẃôŕk̂ĺêt́ Ŝér̂v́îćê"
+  },
+  "models/timeline_model/TimelineModel.ts | workletServiceS": {
+    "message": "Âúĉt́îón̂ Ẃôŕk̂ĺêt́ Ŝér̂v́îćê — {PH1}"
+  },
   "models/workspace/UISourceCode.ts | index": {
     "message": "(îńd̂éx̂)"
   },
@@ -8921,6 +8927,12 @@
   "panels/security/SecurityPanel.ts | contentWithCertificateErrors": {
     "message": "ĉón̂t́êńt̂ ẃît́ĥ ćêŕt̂íf̂íĉát̂é êŕr̂ór̂ś"
   },
+  "panels/security/SecurityPanel.ts | enabled": {
+    "message": "êńâb́l̂éd̂"
+  },
+  "panels/security/SecurityPanel.ts | encryptedClientHello": {
+    "message": "Êńĉŕŷṕt̂éd̂ Ćl̂íêńt̂H́êĺl̂ó"
+  },
   "panels/security/SecurityPanel.ts | flaggedByGoogleSafeBrowsing": {
     "message": "F̂ĺâǵĝéd̂ b́ŷ Ǵôóĝĺê Śâf́ê B́r̂óŵśîńĝ"
   },
@@ -9044,6 +9056,9 @@
   "panels/security/SecurityPanel.ts | securityOverview": {
     "message": "Ŝéĉúr̂ít̂ý ôv́êŕv̂íêẃ"
   },
+  "panels/security/SecurityPanel.ts | serverSignature": {
+    "message": "Ŝér̂v́êŕ ŝíĝńât́ûŕê"
+  },
   "panels/security/SecurityPanel.ts | showFullDetails": {
     "message": "Ŝh́ôẃ f̂úl̂ĺ d̂ét̂áîĺŝ"
   },
@@ -9146,6 +9161,9 @@
   "panels/security/SecurityPanel.ts | unknownCanceled": {
     "message": "Ûńk̂ńôẃn̂ / ćâńĉél̂éd̂"
   },
+  "panels/security/SecurityPanel.ts | unknownField": {
+    "message": "ûńk̂ńôẃn̂"
+  },
   "panels/security/SecurityPanel.ts | validAndTrusted": {
     "message": "v̂ál̂íd̂ án̂d́ t̂ŕûśt̂éd̂"
   },
@@ -9530,6 +9548,12 @@
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | addPattern": {
     "message": "Âd́d̂ ṕât́t̂ér̂ń..."
   },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScripts": {
+    "message": "Âút̂óm̂át̂íĉál̂ĺŷ ád̂d́ k̂ńôẃn̂ t́ĥír̂d́-p̂ár̂t́ŷ śĉŕîṕt̂ś t̂ó îǵn̂ór̂é l̂íŝt́"
+  },
+  "panels/settings/FrameworkIgnoreListSettingsTab.ts | automaticallyIgnoreListKnownThirdPartyScriptsTooltip": {
+    "message": "Âd́d̂ śôúr̂ćêś f̂ŕôḿ t̂h́ê x_google_ignoreList f́îél̂d́ f̂ŕôḿ ŝóûŕĉé m̂áp̂ś t̂ó t̂h́ê íĝńôŕê ĺîśt̂"
+  },
   "panels/settings/FrameworkIgnoreListSettingsTab.ts | behavior": {
     "message": "B̂éĥáv̂íôŕ"
   },

package/front_end/core/root/Runtime.ts CHANGED Viewed

@@ -293,6 +293,7 @@ export enum ExperimentName {
   INSTRUMENTATION_BREAKPOINTS = 'instrumentationBreakpoints',
   CSS_AUTHORING_HINTS = 'cssAuthoringHints',
   AUTHORED_DEPLOYED_GROUPING = 'authoredDeployedGrouping',
+  IMPORTANT_DOM_PROPERTIES = 'importantDOMProperties',
 }
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/core/sdk/NetworkManager.ts CHANGED Viewed

@@ -914,8 +914,13 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     const oldDispatcher = (NetworkManager.forRequest(request) as NetworkManager).dispatcher;
     oldDispatcher.#requestsById.delete(requestId);
     oldDispatcher.#requestsByURL.delete(request.url());
+    const builder = oldDispatcher.#requestIdToExtraInfoBuilder.get(requestId);
+    oldDispatcher.#requestIdToExtraInfoBuilder.delete(requestId);
     this.#requestsById.set(requestId, request);
     this.#requestsByURL.set(request.url(), request);
+    if (builder) {
+      this.#requestIdToExtraInfoBuilder.set(requestId, builder);
+    }
     requestToManagerMap.set(request, this.#manager);
     return request;
   }
@@ -981,9 +986,21 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
   }
   clearRequests(): void {
-    this.#requestsById.clear();
-    this.#requestsByURL.clear();
-    this.#requestIdToExtraInfoBuilder.clear();
+    for (const [requestId, request] of this.#requestsById) {
+      if (request.finished) {
+        this.#requestsById.delete(requestId);
+      }
+    }
+    for (const [requestURL, request] of this.#requestsByURL) {
+      if (request.finished) {
+        this.#requestsByURL.delete(requestURL);
+      }
+    }
+    for (const [requestId, builder] of this.#requestIdToExtraInfoBuilder) {
+      if (builder.isFinished()) {
+        this.#requestIdToExtraInfoBuilder.delete(requestId);
+      }
+    }
   }
   webTransportCreated({transportId, url: requestURL, timestamp: time, initiator}:
@@ -1643,6 +1660,10 @@ class ExtraInfoBuilder {
     this.updateFinalRequest();
   }
+  isFinished(): boolean {
+    return this.#finishedInternal;
+  }
   private sync(index: number): void {
     const req = this.#requests[index];
     if (!req) {

package/front_end/core/sdk/ResourceTreeModel.ts CHANGED Viewed

@@ -232,7 +232,7 @@ export class ResourceTreeModel extends SDKModel<EventTypes> {
       this.processPendingEvents(frame);
       this.dispatchEventToListeners(Events.MainFrameNavigated, frame);
       const networkManager = this.target().model(NetworkManager);
-      if (networkManager) {
+      if (networkManager && frame.isTopFrame()) {
         networkManager.clearRequests();
       }
     }

package/front_end/core/sdk/SourceMap.ts CHANGED Viewed

@@ -77,6 +77,9 @@ export interface SourceMap {
       SourceMapEntry|null;
   mappings(): SourceMapEntry[];
   mapsOrigin(): boolean;
+  hasIgnoreListHint(sourceURL: Platform.DevToolsPath.UrlString): boolean;
+  findRanges(predicate: (sourceURL: Platform.DevToolsPath.UrlString) => boolean, options: {isStartMatching: boolean}):
+      TextUtils.TextRange.TextRange[];
 }
 export class SourceMapV3 {
@@ -595,19 +598,32 @@ export class TextSourceMap implements SourceMap {
   }
   /**
-   * Returns a list of ranges in the generated script, which are known to be
-   * third-party code that should be ignore-listed. Each range is a [begin, end)
-   * pair, meaning that code at the beginning location, up to but not including
-   * the end location, is known to be third-party code.
+   * Returns a list of ranges in the generated script for original sources that
+   * match a predicate. Each range is a [begin, end) pair, meaning that code at
+   * the beginning location, up to but not including the end location, matches
+   * the predicate.
    */
-  ignoreListRanges(): TextUtils.TextRange.TextRange[] {
+  findRanges(predicate: (sourceURL: Platform.DevToolsPath.UrlString) => boolean, options?: {isStartMatching: boolean}):
+      TextUtils.TextRange.TextRange[] {
     const mappings = this.mappings();
     const ranges = [];
+    if (!mappings.length) {
+      return [];
+    }
     let current: TextUtils.TextRange.TextRange|null = null;
+    // If the first mapping isn't at the beginning of the original source, it's
+    // up to the caller to decide if it should be considered matching the
+    // predicate or not. By default, it's not.
+    if ((mappings[0].lineNumber !== 0 || mappings[0].columnNumber !== 0) && options?.isStartMatching) {
+      current = TextUtils.TextRange.TextRange.createUnboundedFromLocation(0, 0);
+      ranges.push(current);
+    }
     for (const {sourceURL, lineNumber, columnNumber} of mappings) {
-      const ignoreListHint = sourceURL && this.hasIgnoreListHint(sourceURL);
+      const ignoreListHint = sourceURL && predicate(sourceURL);
       if (!current && ignoreListHint) {
         current = TextUtils.TextRange.TextRange.createUnboundedFromLocation(lineNumber, columnNumber);

package/front_end/core/sdk/sdk-meta.ts CHANGED Viewed

@@ -332,6 +332,13 @@ Common.Settings.registerSettingExtension({
   defaultValue: false,
 });
+Common.Settings.registerSettingExtension({
+  storageType: Common.Settings.SettingStorageType.Synced,
+  settingName: 'automaticallyIgnoreListKnownThirdPartyScripts',
+  settingType: Common.Settings.SettingType.BOOLEAN,
+  defaultValue: true,
+});
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.CONSOLE,
   storageType: Common.Settings.SettingStorageType.Synced,

package/front_end/devtools_compatibility.js CHANGED Viewed

@@ -1155,6 +1155,7 @@
       'showWhitespacesInEditor',
       'sidebarPosition',
       'skipContentScripts',
+      'automaticallyIgnoreListKnownThirdPartyScripts',
       'skipStackFramesPattern',
       'sourceMapInfobarDisabled',
       'sourcesPanelDebuggerSidebarSplitViewState',

package/front_end/entrypoints/main/MainImpl.ts CHANGED Viewed

@@ -406,6 +406,11 @@ export class MainImpl {
     Root.Runtime.experiments.register(
         Root.Runtime.ExperimentName.AUTHORED_DEPLOYED_GROUPING, 'Group sources into Authored and Deployed trees');
+    // Highlight important DOM properties in the Object Properties viewer.
+    Root.Runtime.experiments.register(
+        Root.Runtime.ExperimentName.IMPORTANT_DOM_PROPERTIES,
+        'Highlight important DOM properties in the Object Properties viewer');
     Root.Runtime.experiments.enableExperimentsByDefault([
       'sourceOrderViewer',
       'hideIssuesFeature',