chrome-devtools-frontend 1.0.1025631 → 1.0.1027150

package/front_end/ui/components/docs/building-ui-documentation/CreatingComponents.md

@@ -78,9 +78,11 @@ Each component defines a `#render` method which is responsible for invoking LitH
 The `#render` method calls `LitHtml.render`, building up a template with `LitHtml.html`:
 
 ```ts
-LitHtml.render(LitHtml.html``, this.#shadow, {host: this});
+LitHtml.render(LitHtml.html`<p>hello world!</p>`, this.#shadow, {host: this});
 ```
 
+The third argument (`{host: this}`) tells LitHtml to automatically bind event listeners to the component. This can save you some painful debugging where event listeners do not have the right `this` reference; so we enforce the use of `{host: this}` via a custom ESLint rule.
+
 There is unfortunately a [clang-format bug](crbug.com/1079231) which makes its auto-formatting of LitHtml templates very unreadable, so we usually disable clang-format round the call:
 
 ```ts
@@ -110,3 +112,172 @@ void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
 ```
 
 > `scheduleRender` returns a promise; we use the `void` keyword to instruct TypeScript that we are purposefully not using `await` to wait for the promise to resolve. When scheduling a render it's most common to "fire and forget".
+
+To summarise, most components start off life looking like:
+
+```ts
+export class ElementsBreadcrumbs extends HTMLElement {
+  static readonly litTagName = LitHtml.literal`devtools-chrome-link`;
+  readonly #shadow = this.attachShadow({mode: 'open'});
+  readonly #boundRender = this.#render.bind(this);
+
+  #render(): void {
+    LitHtml.render(LitHtml.html``, this.#shadow, {host:this});
+  }
+}
+```
+
+## Triggering a render
+
+One of the most important aspects to understand about our component system is that **rendering does not happen automatically**.
+
+To ensure we trigger a render once the component is added to the DOM, we can define [`connectedCallback`](https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_custom_elements#:~:text=lifecycle.%20For%20example%2C-,connectedCallback,-is%20invoked%20each):
+
+```ts
+export class ElementsBreadcrumbs extends HTMLElement {
+  static readonly litTagName = LitHtml.literal`devtools-chrome-link`;
+  readonly #shadow = this.attachShadow({mode: 'open'});
+  readonly #boundRender = this.#render.bind(this);
+
+  connectedCallback(): void {
+    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
+  }
+
+  #render(): void {
+    LitHtml.render(LitHtml.html``, this.#shadow, {host:this});
+  }
+}
+```
+
+## Passing data into a component
+
+Most of our components will require data that is passed into them. For example, `ElementsBreadcrumbs` takes in an array of `DOMNode` objects.
+
+To provide a component some data, we define a `data` setter. This setter takes an object with any data the component requires. This object should have a TypeScript interface defined for it:
+
+```ts
+export interface ElementsBreadcrumbsData {
+  selectedNode: DOMNode|null;
+  crumbs: DOMNode[];
+}
+
+export class ElementsBreadcrumbs extends HTMLElement {
+  // ...
+  #crumbs: DOMNode[] = [];
+  #selectedNode: DOMNode|null = null;
+
+  set data(data: ElementsBreadcrumbsData) {
+    this.#crumbs = data.crumbs;
+    this.#selectedNode = data.selectedNode;
+    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
+  }
+}
+```
+
+## Rendering components
+
+Now we know how to create components that can take data, let's render them!
+
+### From a DevTools Widget
+
+If you are rendering a component from the DevTools widget system, you should instantiate the component, pass any `data` to it, and then append it into the DOM:
+
+```ts
+// Within a Widget
+const breadcrumbs = new ElementsBreadcrumbs();
+breadcrumbs.data = {selectedNode: node, crumbs: [...]};
+this.appendChild(breadcrumbs);
+```
+
+### From another component
+
+If you are rendering a component from within another component, render it within the call to `LitHtml.html` and use the static `litTagName` property:
+
+```ts
+// Within some component
+LitHtml.render(LitHtml.html`
+  <${ElementsBreadcrumbs.litTagName}></${ElementsBreadcrumbs>
+`, this.#shadow, {host: this});
+```
+
+To pass data, we use [LitHtml's dot syntax](https://lit.dev/docs/templates/expressions/#property-expressions) to set the `data` property (and invoke our `set data` setter):
+
+```ts
+// Within some component
+LitHtml.render(LitHtml.html`
+  <${ElementsBreadcrumbs.litTagName} .data=${{
+    selectedNode: node,
+    crumbs: [...],
+  }}>
+  </${ElementsBreadcrumbs>
+`, this.#shadow, {host: this});
+```
+
+To enforce some type safety, we also use TypeScript's `as` keyword to force the compiler to type-check the `data` object against the interface:
+
+```ts
+// Within some component
+LitHtml.render(LitHtml.html`
+  <${ElementsBreadcrumbs.litTagName} .data=${{
+    selectedNode: node,
+    crumbs: [...],
+  } as ElementsBreadcrumbsData}>
+  </${ElementsBreadcrumbs>
+`, this.#shadow, {host: this});
+```
+
+This type-checking requirement is enforced by an ESLint rule.
+
+## Performance concerns with data passing
+
+The approach of `set data(data)` was chosen because:
+
+1. It requires few lines of code.
+2. It provides some form of type safety via the `as FooData` check.
+3. At the time we didn't have a solution for scheduled and batched renders, and didn't want multiple setters to trigger multiple unnecessary renders.
+
+However, using `set data(data)` does come with some negative performance costs:
+
+1. LitHtml will always think the value has changed, because it's an object. If a component renders twice with `.data=${{name: 'Jack'}}`, Lit will think that the value has changed because it's a new object, even though we can see it's holding the same data.
+2. This approach causes these objects to be created (and subsequently garbage collected) on/after each render.
+
+For most components in DevTools, these trade-offs are acceptable, and we prefer the type-safety of `set data` and take the usually imperceivable performance hit. However, in rare circumstances, this performance hit is noticeable. A good example of this is in Performance Insights, where we have to constantly re-render components as the user scrolls through their performance timeline. We noticed that this caused a large amount of garbage collection from all the objects being created per-render and then immediately disposed.
+
+For these situations, we can instead move to an approach where we set properties individually. We still define the interface as before, and then define an individual setter for each property:
+
+```ts
+interface ElementsBreadcrumbsData {
+  selectedNode: DOMNode|null;
+  crumbs: DOMNode[];
+}
+
+class ElementsBreadcrumbs extends HTMLElement {
+  #crumbs: DOMNode[] = [];
+  #selectedNode: DOMNode|null = null;
+
+  set crumbs(crumbs: ElementsBreadcrumbsData['crumbs']) {
+    this.#crumbs = crumbs;
+    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
+  }
+
+  set selectedNode(selectedNode: ElementsBreadcrumbsData['selectedNode']) {
+    this.#selectedNode = selectedNode;
+    void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#boundRender);
+  }
+}
+```
+
+Rendering this component within another Lit component would now be done like so:
+
+```ts
+// Within some component
+LitHtml.render(LitHtml.html`
+  <${ElementsBreadcrumbs.litTagName} .crumbs=${[...]} .selectedNode=${node}>
+  </${ElementsBreadcrumbs>
+`, this.#shadow, {host: this});
+```
+
+This solution is more performant, but less type-safe as TypeScript has no means of checking those values. This is something we may rectify using the `as` pattern, but for now it's preferred to use the `set data` method by default.
+
+
+

package/front_end/ui/components/panel_feedback/PreviewToggle.ts

@@ -72,23 +72,22 @@ export class PreviewToggle extends HTMLElement {
     render(
       html`
       <div class="container">
-        <div class="checkbox-line">
-          <label class="experiment-preview">
-            <input type="checkbox" ?checked=${checked} @change=${this.#checkboxChanged} aria-label=${this.#name}/>
-            <${IconButton.Icon.Icon.litTagName} .data=${{
-              iconName: 'ic_preview_feature',
-              width: '16px',
-              height: '16px',
-              color: 'var(--color-text-secondary)',
-            } as IconButton.Icon.IconData}>
-            </${IconButton.Icon.Icon.litTagName}>${this.#name}
-          </label>
-          ${this.#feedbackURL && !this.#helperText
-            ? html`<div class="feedback"><x-link class="x-link" href=${this.#feedbackURL}>${i18nString(UIStrings.shortFeedbackLink)}</x-link></div>`
-            : nothing}
-        </div>
+        <label class="experiment-preview">
+          <input type="checkbox" ?checked=${checked} @change=${this.#checkboxChanged} aria-label=${this.#name}/>
+          <${IconButton.Icon.Icon.litTagName} .data=${{
+            iconName: 'ic_preview_feature',
+            width: '16px',
+            height: '16px',
+            color: 'var(--color-text-secondary)',
+          } as IconButton.Icon.IconData}>
+          </${IconButton.Icon.Icon.litTagName}>${this.#name}
+        </label>
+        <div class="spacer"></div>
+        ${this.#feedbackURL && !this.#helperText
+          ? html`<div class="feedback"><x-link class="x-link" href=${this.#feedbackURL}>${i18nString(UIStrings.shortFeedbackLink)}</x-link></div>`
+          : nothing}
         ${this.#learnMoreURL
-          ? html`<x-link class="x-link" href=${this.#learnMoreURL}>${i18nString(UIStrings.learnMoreLink)}</x-link>`
+          ? html`<div class="learn-more"><x-link class="x-link" href=${this.#learnMoreURL}>${i18nString(UIStrings.learnMoreLink)}</x-link></div>`
           : nothing}
         <div class="helper">
           ${this.#helperText && this.#feedbackURL

package/front_end/ui/components/panel_feedback/previewToggle.css

@@ -8,35 +8,33 @@
   display: block;
 }
 
-.experiment-preview {
+.container {
+  display: flex;
+  flex-wrap: wrap;
+  padding: 4px;
+}
+
+.experiment-preview,
+.feedback,
+.learn-more {
   display: flex;
   align-items: center;
 }
 
 .helper {
+  flex-basis: 100%;
   text-align: center;
   font-style: italic;
 }
 
-.feedback {
-  text-align: right;
-}
-
-.checkbox-line {
-  display: flex;
-  justify-content: space-between;
-  align-items: center;
-  flex-wrap: wrap;
-}
-
-.container {
-  padding: 4px;
+.spacer {
+  flex: 1;
 }
 
 .x-link {
   color: var(--color-primary);
   text-decoration-line: underline;
-  margin: 4px;
+  margin: 0 4px;
 }
 
 .feedback .x-link {

package/front_end/ui/components/text_editor/TextEditor.ts

@@ -105,6 +105,9 @@ export class TextEditor extends HTMLElement {
   connectedCallback(): void {
     if (!this.#activeEditor) {
       this.#createEditor();
+    } else {
+      this.#activeEditor.scrollDOM.scrollTop = this.#lastScrollPos.top;
+      this.#activeEditor.scrollDOM.scrollLeft = this.#lastScrollPos.left;
     }
   }
 

package/front_end/ui/legacy/ListControl.ts

@@ -428,6 +428,10 @@ export class ListControl<T> {
       }
       if (newElement) {
         ARIAUtils.setSelected(newElement, true);
+        const text = newElement.textContent;
+        if (text) {
+          ARIAUtils.alert(text);
+        }
       }
       ARIAUtils.setActiveDescendant(this.element, newElement);
     }

package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts

@@ -30,6 +30,7 @@
 
 import * as Common from '../../../../core/common/common.js';
 import type * as Components from '../utils/utils.js';
+import * as Root from '../../../../core/root/root.js';
 import * as Host from '../../../../core/host/host.js';
 import * as i18n from '../../../../core/i18n/i18n.js';
 import * as LinearMemoryInspector from '../../../components/linear_memory_inspector/linear_memory_inspector.js';
@@ -222,8 +223,12 @@ export class ObjectPropertiesSection extends UI.TreeOutline.TreeOutlineInShadow
       return;
     }
 
+    const includedWebIdlTypes = webIdlType.includes?.map(className => domPinnedProperties[className]) ?? [];
+    const includedWebIdlProps = includedWebIdlTypes.flatMap(webIdlType => Object.entries(webIdlType.props ?? {}));
+    const webIdlProps = {...webIdlType.props, ...Object.fromEntries(includedWebIdlProps)};
+
     for (const property of properties) {
-      const webIdlProperty = webIdlType?.props?.[property.name];
+      const webIdlProperty = webIdlProps[property.name];
       if (webIdlProperty) {
         property.webIdl = {info: webIdlProperty};
       }
@@ -1118,10 +1123,12 @@ export class ObjectPropertyTreeElement extends UI.TreeOutline.TreeElement {
       this.expandedValueElement = this.createExpandedValueElement(this.property.value);
     }
 
+    const experiment = Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.IMPORTANT_DOM_PROPERTIES);
+
     let adorner: Element|string = '';
     let container: Element;
 
-    if (this.property.webIdl?.applicable) {
+    if (this.property.webIdl?.applicable && experiment) {
       const icon = new IconButton.Icon.Icon();
       icon.data = {
         iconName: 'star_outline',
@@ -1148,7 +1155,10 @@ export class ObjectPropertyTreeElement extends UI.TreeOutline.TreeElement {
     this.listItemElement.removeChildren();
     this.rowContainer = (container as HTMLElement);
     this.listItemElement.appendChild(this.rowContainer);
-    this.listItemElement.dataset.webidl = this.property.webIdl?.applicable ? 'true' : 'false';
+
+    if (experiment) {
+      this.listItemElement.dataset.webidl = this.property.webIdl?.applicable ? 'true' : 'false';
+    }
   }
 
   private updatePropertyPath(): void {

package/front_end/ui/legacy/components/utils/JSPresentationUtils.ts

@@ -70,7 +70,7 @@ function populateContextMenu(link: Element, event: Event): void {
   const uiLocation = Linkifier.uiLocation(link);
   if (uiLocation &&
       Bindings.IgnoreListManager.IgnoreListManager.instance().canIgnoreListUISourceCode(uiLocation.uiSourceCode)) {
-    if (Bindings.IgnoreListManager.IgnoreListManager.instance().isIgnoreListedUISourceCode(uiLocation.uiSourceCode)) {
+    if (Bindings.IgnoreListManager.IgnoreListManager.instance().isUserIgnoreListedURL(uiLocation.uiSourceCode.url())) {
       contextMenu.debugSection().appendItem(
           i18nString(UIStrings.removeFromIgnore),
           () => Bindings.IgnoreListManager.IgnoreListManager.instance().unIgnoreListUISourceCode(
@@ -127,8 +127,8 @@ export function buildStackTraceRows(
         // TODO(crbug.com/1183325): fix race condition with uiLocation still being null here
         const uiLocation = Linkifier.uiLocation(link);
         if (uiLocation &&
-            Bindings.IgnoreListManager.IgnoreListManager.instance().isIgnoreListedUISourceCode(
-                uiLocation.uiSourceCode)) {
+            Bindings.IgnoreListManager.IgnoreListManager.instance().isUserIgnoreListedURL(
+                uiLocation.uiSourceCode.url())) {
           ignoreListHide = true;
         }
         // Linkifier is using a workaround with the 'zero width space' (\u200b).
@@ -175,7 +175,8 @@ function updateHiddenRows(
     if ('link' in row && row.link) {
       const uiLocation = Linkifier.uiLocation(row.link);
       if (uiLocation &&
-          Bindings.IgnoreListManager.IgnoreListManager.instance().isIgnoreListedUISourceCode(uiLocation.uiSourceCode)) {
+          Bindings.IgnoreListManager.IgnoreListManager.instance().isUserIgnoreListedURL(
+              uiLocation.uiSourceCode.url())) {
         row.ignoreListHide = true;
       }
       if (row.rowCountHide || row.ignoreListHide) {

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1025631"
+  "version": "1.0.1027150"
 }