chrome-devtools-frontend 1.0.1023108 → 1.0.1023618

package/front_end/generated/protocol.ts

@@ -10,16 +10,12 @@
 
 export type integer = number;
 export type binary = string;
-export type EnumerableEnum<T> = {
-  [K in keyof T]: T[K]
-};
+export type EnumerableEnum<T> = {[K in keyof T]: T[K]};
 export interface ProtocolResponseWithError {
   /** Returns an error message if the request failed. */
   getError(): string|undefined;
 }
-type OpaqueType<Tag extends string> = {
-  protocolOpaqueTypeTag: Tag
-};
+type OpaqueType<Tag extends string> = {protocolOpaqueTypeTag: Tag};
 type OpaqueIdentifier<RepresentationType, Tag extends string> = RepresentationType&OpaqueType<Tag>;
 
 export namespace Accessibility {
@@ -1059,14 +1055,12 @@ export namespace Audits {
     RequestedSubresourceWithEmbeddedCredentials = 'RequestedSubresourceWithEmbeddedCredentials',
     RTCConstraintEnableDtlsSrtpFalse = 'RTCConstraintEnableDtlsSrtpFalse',
     RTCConstraintEnableDtlsSrtpTrue = 'RTCConstraintEnableDtlsSrtpTrue',
-    RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics =
-        'RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics',
+    RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics = 'RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics',
     RTCPeerConnectionSdpSemanticsPlanB = 'RTCPeerConnectionSdpSemanticsPlanB',
     RtcpMuxPolicyNegotiate = 'RtcpMuxPolicyNegotiate',
     SharedArrayBufferConstructedWithoutIsolation = 'SharedArrayBufferConstructedWithoutIsolation',
     TextToSpeech_DisallowedByAutoplay = 'TextToSpeech_DisallowedByAutoplay',
-    V8SharedArrayBufferConstructedInExtensionWithoutIsolation =
-        'V8SharedArrayBufferConstructedInExtensionWithoutIsolation',
+    V8SharedArrayBufferConstructedInExtensionWithoutIsolation = 'V8SharedArrayBufferConstructedInExtensionWithoutIsolation',
     XHRJSONEncodingDetection = 'XHRJSONEncodingDetection',
     XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload = 'XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload',
     XRSupportsSession = 'XRSupportsSession',
@@ -11009,8 +11003,7 @@ export namespace Page {
     EmbedderDomDistillerSelfDeletingRequestDelegate = 'EmbedderDomDistillerSelfDeletingRequestDelegate',
     EmbedderOomInterventionTabHelper = 'EmbedderOomInterventionTabHelper',
     EmbedderOfflinePage = 'EmbedderOfflinePage',
-    EmbedderChromePasswordManagerClientBindCredentialManager =
-        'EmbedderChromePasswordManagerClientBindCredentialManager',
+    EmbedderChromePasswordManagerClientBindCredentialManager = 'EmbedderChromePasswordManagerClientBindCredentialManager',
     EmbedderPermissionRequestManager = 'EmbedderPermissionRequestManager',
     EmbedderModalDialog = 'EmbedderModalDialog',
     EmbedderExtensions = 'EmbedderExtensions',

package/front_end/panels/elements/DOMLinkifier.ts

@@ -95,7 +95,11 @@ export const linkifyNodeReference = function(
   link.addEventListener('mouseleave', () => SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(), false);
 
   if (!options.preventKeyboardFocus) {
-    link.addEventListener('keydown', event => event.key === 'Enter' && Common.Revealer.reveal(node, false) && false);
+    link.addEventListener('keydown', event => {
+      if (event.key === 'Enter') {
+        void Common.Revealer.reveal(node, false);
+      }
+    });
     link.tabIndex = 0;
     UI.ARIAUtils.markAsLink(link);
   }

package/front_end/panels/network/components/RequestHeadersView.css

@@ -161,6 +161,10 @@ div.raw-headers-row {
   padding: 2px 0; /* adjust focus ring size */
 }
 
+.explanation .link {
+  font-weight: normal;
+}
+
 .inline-icon {
   vertical-align: middle;
 }

package/front_end/panels/network/components/RequestHeadersView.ts

@@ -74,6 +74,19 @@ const UIStrings = {
   onlyChooseThisOptionIfAn:
       'Only choose this option if an arbitrary website including this resource does not impose a security risk.',
   /**
+  *@description Message to explain lack of raw headers for a particular network request
+  */
+  provisionalHeadersAreShownDisableCache: 'Provisional headers are shown. Disable cache to see full headers.',
+  /**
+  *@description Tooltip to explain lack of raw headers for a particular network request
+  */
+  onlyProvisionalHeadersAre:
+      'Only provisional headers are available because this request was not sent over the network and instead was served from a local cache, which doesn’t store the original request headers. Disable cache to see full request headers.',
+  /**
+  *@description Message to explain lack of raw headers for a particular network request
+  */
+  provisionalHeadersAreShown: 'Provisional headers are shown.',
+  /**
   *@description Text in Request Headers View of the Network panel
   */
   referrerPolicy: 'Referrer Policy',
@@ -289,12 +302,44 @@ export class RequestHeadersComponent extends HTMLElement {
       >
         ${(this.#showRequestHeadersText && requestHeadersText) ?
             this.#renderRawHeaders(requestHeadersText, false) : html`
+          ${this.#maybeRenderProvisionalHeadersWarning()}
           ${headers.map(header => this.#renderHeader({...header, headerNotSet: false}))}
         `}
       </${Category.litTagName}>
     `;
   }
 
+  #maybeRenderProvisionalHeadersWarning(): LitHtml.LitTemplate {
+    assertNotNullOrUndefined(this.#request);
+    if (this.#request.requestHeadersText() !== undefined) {
+      return LitHtml.nothing;
+    }
+
+    let cautionText;
+    let cautionTitle = '';
+    if (this.#request.cachedInMemory() || this.#request.cached()) {
+      cautionText = i18nString(UIStrings.provisionalHeadersAreShownDisableCache);
+      cautionTitle = i18nString(UIStrings.onlyProvisionalHeadersAre);
+    } else {
+      cautionText = i18nString(UIStrings.provisionalHeadersAreShown);
+    }
+    return html`
+      <div class="call-to-action">
+        <div class="call-to-action-body">
+          <div class="explanation" title=${cautionTitle}>
+            <${IconButton.Icon.Icon.litTagName} class="inline-icon" .data=${{
+              iconName: 'warning_icon',
+              width: '12px',
+              height: '12px',
+              } as IconButton.Icon.IconData}>
+            </${IconButton.Icon.Icon.litTagName}>
+            ${cautionText} <x-link href="https://developer.chrome.com/docs/devtools/network/reference/#provisional-headers" class="link">${i18nString(UIStrings.learnMore)}</x-link>
+          </div>
+        </div>
+      </div>
+    `;
+  }
+
   #renderHeader(header: HeaderDescriptor): LitHtml.TemplateResult {
     return html`
       <div class="row">
@@ -310,20 +355,18 @@ export class RequestHeadersComponent extends HTMLElement {
       return LitHtml.nothing;
     }
     return html`
-      <div class="header-details">
-        <div class="call-to-action">
-          <div class="call-to-action-body">
-            <div class="explanation">${headerDetails.explanation()}</div>
-            ${headerDetails.examples.map(example => html`
-              <div class="example">
-                <code>${example.codeSnippet}</code>
-                ${example.comment ? html`
-                  <span class="comment">${example.comment()}</span>
-                ` : ''}
-              </div>
-            `)}
-            ${this.#maybeRenderHeaderDetailsLink(headerDetails)}
-          </div>
+      <div class="call-to-action">
+        <div class="call-to-action-body">
+          <div class="explanation">${headerDetails.explanation()}</div>
+          ${headerDetails.examples.map(example => html`
+            <div class="example">
+              <code>${example.codeSnippet}</code>
+              ${example.comment ? html`
+                <span class="comment">${example.comment()}</span>
+              ` : ''}
+            </div>
+          `)}
+          ${this.#maybeRenderHeaderDetailsLink(headerDetails)}
         </div>
       </div>
     `;

package/front_end/ui/components/buttons/Button.ts

@@ -63,7 +63,7 @@ export type ButtonData = {
 };
 
 interface ButtonElementInternals extends ElementInternals {
-  readonly form?: HTMLFormElement;
+  readonly form: HTMLFormElement|null;
   readonly validity: ValidityState;
   readonly willValidate: boolean;
   readonly validationMessage: string;
@@ -254,7 +254,7 @@ export class Button extends HTMLElement {
   // The following properties and methods aren't strictly required,
   // but browser-level form controls provide them. Providing them helps
   // ensure consistency with browser-provided controls.
-  get form(): HTMLFormElement|undefined {
+  get form(): HTMLFormElement|null {
     return this.#internals.form;
   }
   get name(): string|null {

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1023108"
+  "version": "1.0.1023618"
 }

package/scripts/build/generate_aria.py

@@ -32,4 +32,5 @@ with open(GENERATED_LOCATION, "w+") as f:
     f.write('// Use of this source code is governed by a BSD-style license that can be\n')
     f.write('// found in the LICENSE file.\n')
     f.write('\n')
-    f.write("export const config = %s;\n" % json.dumps(ARIA_PROPERTIES))
+    f.write("export const config = %s;\n" %
+            json.dumps(ARIA_PROPERTIES, sort_keys=True, indent=1))

package/scripts/build/generate_supported_css.py

@@ -108,7 +108,10 @@ with open(GENERATED_LOCATION, "w+") as f:
     f.write('// Use of this source code is governed by a BSD-style license that can be\n')
     f.write('// found in the LICENSE file.\n')
     f.write('\n')
-    f.write("export const generatedProperties = %s;\n" % json.dumps(properties))
+    f.write("export const generatedProperties = %s;\n" %
+            json.dumps(properties, sort_keys=True, indent=1))
     # sort keys to ensure entries are generated in a deterministic way to avoid inconsistencies across different OS
-    f.write("export const generatedPropertyValues = %s;\n" % json.dumps(property_values, sort_keys=True))
-    f.write("export const generatedAliasesFor = new Map(%s);\n" % json.dumps(aliases_for))
+    f.write("export const generatedPropertyValues = %s;\n" %
+            json.dumps(property_values, sort_keys=True, indent=1))
+    f.write("export const generatedAliasesFor = new Map(%s);\n" %
+            json.dumps(aliases_for, sort_keys=True, indent=1))