chrome-devtools-frontend 1.0.1021582 → 1.0.1022475

package/front_end/panels/sources/ScopeChainSidebarPane.ts

@@ -99,6 +99,8 @@ export class ScopeChainSidebarPane extends UI.Widget.VBox implements UI.ContextF
     this.infoElement = document.createElement('div');
     this.infoElement.className = 'gray-info-message';
     this.infoElement.tabIndex = -1;
+    SDK.TargetManager.TargetManager.instance().addModelListener(
+        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebugInfoAttached, this.debugInfoAttached, this);
     void this.update();
   }
 
@@ -151,6 +153,12 @@ export class ScopeChainSidebarPane extends UI.Widget.VBox implements UI.ContextF
     }
   }
 
+  private debugInfoAttached(event: Common.EventTarget.EventTargetEvent<SDK.Script.Script>): void {
+    if (event.data === this.#scopesScript) {
+      void this.update();
+    }
+  }
+
   private async update(): Promise<void> {
     // The `resolveThisObject(callFrame)` and `resolveScopeChain(callFrame)` calls
     // below may take a while to complete, so indicate to the user that something

package/front_end/panels/sources/SourcesPanel.ts

@@ -314,6 +314,8 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
         SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebuggerWasEnabled, this.debuggerWasEnabled, this);
     SDK.TargetManager.TargetManager.instance().addModelListener(
         SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this.debuggerPaused, this);
+    SDK.TargetManager.TargetManager.instance().addModelListener(
+        SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebugInfoAttached, this.debugInfoAttached, this);
     SDK.TargetManager.TargetManager.instance().addModelListener(
         SDK.DebuggerModel.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed,
         event => this.debuggerResumed(event.data));
@@ -474,6 +476,18 @@ export class SourcesPanel extends UI.Panel.Panel implements UI.ContextMenu.Provi
     }
   }
 
+  private debugInfoAttached(event: Common.EventTarget.EventTargetEvent<SDK.Script.Script>): void {
+    const {debuggerModel} = event.data;
+    if (!debuggerModel.isPaused()) {
+      return;
+    }
+
+    const details = debuggerModel.debuggerPausedDetails();
+    if (details && UI.Context.Context.instance().flavor(SDK.Target.Target) === debuggerModel.target()) {
+      this.showDebuggerPausedDetails(details);
+    }
+  }
+
   private showDebuggerPausedDetails(details: SDK.DebuggerModel.DebuggerPausedDetails): void {
     this.pausedInternal = true;
     void this.updateDebuggerButtonsAndStatus();

package/front_end/third_party/acorn/acorn.ts

@@ -4,7 +4,7 @@
 
 import * as acorn from './package/dist/acorn.mjs';
 
-import type * as ESTree from './estree-legacy';
+import type * as ESTree from './estree-legacy.js';
 export {ESTree};
 
 export { type Comment, defaultOptions, getLineInfo, isNewLine, lineBreak, lineBreakG, Node, SourceLocation, Token, tokTypes, tokContexts} from './package/dist/acorn.mjs';

package/front_end/third_party/chromium/client-variations/client-variations.ts

@@ -2,4 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-export * from './ClientVariations.js';
+export * from './ClientVariations.js';

package/front_end/third_party/diff/DiffWrapper.ts

@@ -5,10 +5,12 @@
 import * as Common from '../../core/common/common.js';
 
 declare global {
+  /* eslint-disable @typescript-eslint/naming-convention */
   class diff_match_patch {
     diff_main(text1: string, text2: string): Array<{0: number, 1: string}>;
     diff_cleanupSemantic(diff: Array<{0: number, 1: string}>): void;
   }
+  /* eslint-enable @typescript-eslint/naming-convention */
 }
 
 export const DiffWrapper = {

package/front_end/third_party/i18n/i18n-impl.ts

@@ -15,8 +15,12 @@ export class I18n {
   readonly supportedLocales: ReadonlySet<Intl.UnicodeBCP47LocaleIdentifier>;
 
   private localeData = new Map<Intl.UnicodeBCP47LocaleIdentifier, LocalizedMessages>();
+  readonly defaultLocale;
+
+  constructor(
+    supportedLocales: readonly Intl.UnicodeBCP47LocaleIdentifier[] = LOCALES, defaultLocale = DEFAULT_LOCALE) {
+    this.defaultLocale = defaultLocale;
 
-  constructor(supportedLocales: ReadonlyArray<Intl.UnicodeBCP47LocaleIdentifier> = LOCALES, public readonly defaultLocale = DEFAULT_LOCALE) {
     this.supportedLocales = new Set(supportedLocales);
   }
 

package/front_end/third_party/i18n/i18n.ts

@@ -8,4 +8,4 @@ import * as LocalizedStringSet from './localized-string-set.js';
 export {
   I18n,
   LocalizedStringSet,
-}
+};

package/front_end/third_party/i18n/locales.ts

@@ -2,7 +2,7 @@
 // Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 // Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
 
-export const LOCALES: ReadonlyArray<Intl.UnicodeBCP47LocaleIdentifier> = [
+export const LOCALES: readonly Intl.UnicodeBCP47LocaleIdentifier[] = [
   'af',
   'am',
   'ar',

package/front_end/third_party/marked/marked.ts

@@ -1,3 +1,3 @@
 import {marked as Marked} from './package/lib/marked.esm.js';
 
-export {Marked}
+export {Marked};

package/front_end/third_party/puppeteer/puppeteer.ts

@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import { Browser } from "./package/lib/esm/puppeteer/common/Browser.js";
-import { Connection } from "./package/lib/esm/puppeteer/common/Connection.js";
-import { type ConnectionTransport } from "./package/lib/esm/puppeteer/common/ConnectionTransport.js";
-import { Frame } from "./package/lib/esm/puppeteer/common/FrameManager.js";
-import { ElementHandle } from "./package/lib/esm/puppeteer/common/ElementHandle";
-import { Page } from "./package/lib/esm/puppeteer/common/Page.js";
+import { Browser } from './package/lib/esm/puppeteer/common/Browser.js';
+import { Connection } from './package/lib/esm/puppeteer/common/Connection.js';
+import { type ConnectionTransport } from './package/lib/esm/puppeteer/common/ConnectionTransport.js';
+import { Frame } from './package/lib/esm/puppeteer/common/FrameManager.js';
+import { ElementHandle } from './package/lib/esm/puppeteer/common/ElementHandle.js';
+import { Page } from './package/lib/esm/puppeteer/common/Page.js';
 
 export { Browser, Connection, ConnectionTransport, ElementHandle, Frame, Page };

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -79,7 +79,13 @@ async function getBufferFromObject(obj: SDK.RemoteObject.RemoteObject): Promise<
 }
 
 export function isDWARFMemoryObject(obj: SDK.RemoteObject.RemoteObject): boolean {
-  return obj instanceof Bindings.DebuggerLanguagePlugins.ValueNode && obj.inspectableAddress !== undefined;
+  if (obj instanceof Bindings.DebuggerLanguagePlugins.ValueNode) {
+    return obj.inspectableAddress !== undefined;
+  }
+  if (obj instanceof Bindings.DebuggerLanguagePlugins.ExtensionRemoteObject) {
+    return obj.linearMemoryAddress !== undefined;
+  }
+  return false;
 }
 
 export function isMemoryObjectProperty(obj: SDK.RemoteObject.RemoteObject): boolean {
@@ -169,6 +175,22 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
 
   static async retrieveDWARFMemoryObjectAndAddress(obj: SDK.RemoteObject.RemoteObject):
       Promise<{obj: SDK.RemoteObject.RemoteObject, address: number}|undefined> {
+    if (obj instanceof Bindings.DebuggerLanguagePlugins.ExtensionRemoteObject) {
+      const valueNode = obj;
+      const address = valueNode.linearMemoryAddress || 0;
+      const callFrame = valueNode.callFrame;
+      const response = await obj.debuggerModel().agent.invoke_evaluateOnCallFrame({
+        callFrameId: callFrame.id,
+        expression: 'memories[0]',
+      });
+      const error = response.getError();
+      if (error) {
+        console.error(error);
+        Common.Console.Console.instance().error(i18nString(UIStrings.couldNotOpenLinearMemory));
+      }
+      const runtimeModel = obj.debuggerModel().runtimeModel();
+      return {obj: runtimeModel.createRemoteObject(response.result), address};
+    }
     if (!(obj instanceof Bindings.DebuggerLanguagePlugins.ValueNode)) {
       return;
     }

package/front_end/ui/legacy/ReportView.ts

@@ -36,6 +36,10 @@ export class ReportView extends VBox {
     this.sectionList = this.contentBox.createChild('div', 'vbox');
   }
 
+  getHeaderElement(): Element {
+    return this.headerElement;
+  }
+
   setTitle(title: string): void {
     if (this.titleElement.textContent === title) {
       return;
@@ -122,6 +126,10 @@ export class Section extends VBox {
     return this.titleElement.textContent || '';
   }
 
+  getTitleElement(): Element {
+    return this.titleElement;
+  }
+
   setTitle(title: string, tooltip?: string): void {
     if (this.titleElement.textContent !== title) {
       this.titleElement.textContent = title;

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1021582"
+  "version": "1.0.1022475"
 }

package/scripts/eslint_rules/lib/custom_element_definitions_location.js

@@ -5,18 +5,6 @@
 
 const path = require('path');
 
-const FRONT_END_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end');
-const PANELS_DIRECTORY = path.join(FRONT_END_DIRECTORY, 'panels');
-
-const ALLOWED_CUSTOM_ELEMENT_LOCATIONS = new Set([
-  path.join(FRONT_END_DIRECTORY, 'ui', 'components'),
-
-  // These should be moved to `ui/components` at some point
-  path.join(FRONT_END_DIRECTORY, 'ui', 'legacy', 'components', 'inline_editor'),
-  path.join(FRONT_END_DIRECTORY, 'ui', 'legacy', 'components', 'perf_ui', 'PieChart.ts'),
-  path.join(FRONT_END_DIRECTORY, 'ui', 'legacy', 'XElement.ts'),
-]);
-
 module.exports = {
   meta: {
     type: 'problem',
@@ -32,11 +20,38 @@ module.exports = {
           'either place it in `ui/components/` or in a `components` sub-folder of a panel. ' +
           'E.g. `panels/elements/components/`.'
     },
-    schema: []  // no options
+    schema: [{
+      'type': 'object',
+      'properties': {
+        'rootFrontendDirectory': {
+          'type': 'string',
+        },
+      },
+      additionalProperties: false,
+    }]
   },
   create: function(context) {
     const classDefiningFileName = path.resolve(context.getFilename());
 
+    let frontEndDirectory = '';
+    if (context.options?.[0]?.rootFrontendDirectory) {
+      frontEndDirectory = context.options[0].rootFrontendDirectory;
+    }
+    if (!frontEndDirectory) {
+      throw new Error('rootFrontEndDirectory must be provided to custom_elements_definitions_location.');
+    }
+
+    const PANELS_DIRECTORY = path.join(frontEndDirectory, 'panels');
+
+    const ALLOWED_CUSTOM_ELEMENT_LOCATIONS = new Set([
+      path.join(frontEndDirectory, 'ui', 'components'),
+
+      // These should be moved to `ui/components` at some point
+      path.join(frontEndDirectory, 'ui', 'legacy', 'components', 'inline_editor'),
+      path.join(frontEndDirectory, 'ui', 'legacy', 'components', 'perf_ui', 'PieChart.ts'),
+      path.join(frontEndDirectory, 'ui', 'legacy', 'XElement.ts'),
+    ]);
+
     return {
       ['ClassDeclaration[superClass.name=\'HTMLElement\']'](node) {
         for (const allowedLocation of ALLOWED_CUSTOM_ELEMENT_LOCATIONS) {
@@ -49,7 +64,7 @@ module.exports = {
           const filePathWithPanelName = classDefiningFileName.substring(PANELS_DIRECTORY.length + 1);
           const filePathWithoutPanelName = filePathWithPanelName.substring(filePathWithPanelName.indexOf(path.sep) + 1);
 
-          if (filePathWithoutPanelName.startsWith('components' + path.sep)) {
+          if (filePathWithoutPanelName.includes(`components${path.sep}`)) {
             return;
           }
         }

package/scripts/eslint_rules/lib/es_modules_import.js

@@ -11,6 +11,7 @@
 const path = require('path');
 
 const FRONT_END_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end');
+const THIRD_PARTY_DIRECTORY = path.join(FRONT_END_DIRECTORY, 'third_party');
 const INSPECTOR_OVERLAY_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end', 'inspector_overlay');
 const COMPONENT_DOCS_DIRECTORY = path.join(FRONT_END_DIRECTORY, 'ui', 'components', 'docs');
 
@@ -164,7 +165,10 @@ module.exports = {
           });
         }
 
-        if (importingFileName.startsWith(INSPECTOR_OVERLAY_DIRECTORY)) {
+        // the Module import rules do not apply within:
+        // 1. inspector_overlay
+        // 2. front_end/third_party
+        if (importingFileName.startsWith(INSPECTOR_OVERLAY_DIRECTORY) || importingFileName.startsWith(THIRD_PARTY_DIRECTORY)) {
           return;
         }
 

package/scripts/eslint_rules/tests/custom_element_definitions_location_test.js

@@ -4,6 +4,7 @@
 'use strict';
 
 const rule = require('../lib/custom_element_definitions_location.js');
+const path = require('path');
 const ruleTester = new (require('eslint').RuleTester)({
   parserOptions: {ecmaVersion: 9, sourceType: 'module'},
   parser: require.resolve('@typescript-eslint/parser'),
@@ -14,30 +15,41 @@ ruleTester.run('custom_element_definitions_location', rule, {
     {
       code: 'class Foo extends HTMLElement {}',
       filename: 'front_end/ui/components/foo/Foo.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'class Foo extends HTMLElement {}',
       filename: 'front_end/panels/issues/components/Foo.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'class Foo extends HTMLElement {}',
       filename: 'front_end/panels/issues/components/nested/folder/Foo.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
+    },
+    {
+      code: 'class Foo extends HTMLElement {}',
+      filename: 'front_end/panels/performance/library/components/metrics/Metric.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'class Foo extends OtherClass {}',
       filename: 'front_end/models/some/Model.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
   ],
   invalid: [
     {
       code: 'class Foo extends HTMLElement {}',
       filename: 'front_end/panels/issues/IssuesPanel.ts',
-      errors: [{messageId: 'definitionInWrongFolder'}]
+      errors: [{messageId: 'definitionInWrongFolder'}],
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'class Foo extends HTMLElement {}',
       filename: 'front_end/models/bindings/Bindings.ts',
-      errors: [{messageId: 'definitionInWrongFolder'}]
+      errors: [{messageId: 'definitionInWrongFolder'}],
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
   ]
 });

package/scripts/eslint_rules/tests/es_modules_import_test.js

@@ -127,6 +127,11 @@ ruleTester.run('es_modules_import', rule, {
     {
       code: 'import checkboxStyles from \'./checkbox.css.js\';',
       filename: 'front_end/ui/components/input/input.ts',
+    },
+    {
+      // Valid even though it breaks the rules, because it's in front_end/third_party.
+      code: 'import { Browser } from "./package/lib/esm/puppeteer/common/Browser.js";',
+      filename: 'front_end/third_party/puppeteer/puppeteer.ts',
     }
   ],