chrome-devtools-frontend 1.0.1021582 → 1.0.1022059

package/.eslintignore

@@ -8,7 +8,20 @@ front_end/diff/diff_match_patch.js
 front_end/generated/protocol.ts
 front_end/javascript_metadata/NativeFunctions.js
 front_end/javascript_metadata/DOMPinnedProperties.ts
-front_end/third_party/
+
+// Any third_party addition has its source code checked out into
+// third_party/X/package, so we ignore that code as it's not code we author or
+// own.
+front_end/third_party/*/package/
+// Any JS files are also not authored by devtools-frontend, so we ignore those.
+front_end/third_party/**/*.js
+// Lighthouse doesn't have a package/ folder but has other nested folders, so
+// we ignore any folders within the lighthouse directory.
+front_end/third_party/lighthouse/*/
+// The CodeMirror bundle file is auto-generated and rolled-up as part of the
+// install script, so we don't need to lint it.
+front_end/third_party/codemirror.next/bundle.ts
+
 node_modules
 scripts/migration/**/*.js
 scripts/protocol_typescript/*.js

package/extension-api/ExtensionAPI.d.ts

@@ -176,6 +176,25 @@ export namespace Chrome {
       stringifyStep(step: Record<string, any>): Promise<string>;
     }
 
+    export type RemoteObjectId = string;
+    export type RemoteObjectType = 'object'|'undefined'|'string'|'number'|'boolean'|'bigint'|'array'|'null';
+
+
+    export interface RemoteObject {
+      type: RemoteObjectType;
+      className?: string;
+      value?: any;
+      description?: string;
+      objectId?: RemoteObjectId;
+      linearMemoryAddress?: number;
+      hasChildren: boolean;
+    }
+
+    export interface PropertyDescriptor {
+      name: string;
+      value: RemoteObject;
+    }
+
     export interface LanguageExtensionPlugin {
       /**
        * A new raw module has been loaded. If the raw wasm module references an external debug info module, its URL will be
@@ -210,8 +229,9 @@ export namespace Chrome {
       removeRawModule(rawModuleId: string): Promise<void>;
 
       /**
-       * Return type information for an expression. The result describes the type (and recursively its member types) of the
-       * result of the expression if it were evaluated in the given context.
+       * DEPRECATED. Return type information for an expression. The result describes the type (and recursively its
+       * member types) of the result of the expression if it were evaluated in the given context.
+       * TODO(crbug.com/1342848) Remove.
        */
       getTypeInfo(expression: string, context: RawLocation): Promise<{
         typeInfos: Array<TypeInfo>,
@@ -219,7 +239,9 @@ export namespace Chrome {
       }|null>;
 
       /**
-       * Returns a piece of JavaScript code that, if evaluated, produces a representation of the given expression or field.
+       * DEPRECATED. Returns a piece of JavaScript code that, if evaluated, produces a representation of the given
+       * expression or field.
+       * TODO(crbug.com/1342848) Remove.
        */
       getFormatter(
           expressionOrField: string|{
@@ -231,7 +253,16 @@ export namespace Chrome {
       }|null>;
 
       /**
-       * Returns a piece of JavaScript code that, if evaluated, produces the address of the given field in the wasm memory.
+       * Evaluate a source language expression in the context of a given raw location and a given stopId. stopId is an
+       * opaque key that should be passed to the APIs accessing wasm state, e.g., getWasmLinearMemory. A stopId is
+       * invalidated once the debugger resumes.
+       * TODO(crbug.com/1342848) Make non-optional.
+       */
+      evaluate?(expression: string, context: RawLocation, stopId: unknown): Promise<RemoteObject|null>;
+
+      /**
+       * DEPRECATED. Returns a piece of JavaScript code that, if evaluated, produces the address of the given field in the wasm memory.
+       * TODO(crbug.com/1342848) Remove.
        */
       getInspectableAddress(field: {
         base: EvalBase,
@@ -263,6 +294,17 @@ export namespace Chrome {
        * Retrieve a list of line numbers in a file for which line-to-raw-location mappings exist.
        */
       getMappedLines(rawModuleId: string, sourceFileURL: string): Promise<number[]|undefined>;
+
+      /**
+       * Retrieve properties of the remote object identified by the object id.
+       * TODO(crbug.com/1342848) Make non-optional.
+       */
+      getProperties?(objectId: RemoteObjectId): Promise<PropertyDescriptor[]>;
+      /**
+       * Permanently release the remote object identified by the object id.
+       * TODO(crbug.com/1342848) Make non-optional.
+       */
+      releaseObject?(objectId: RemoteObjectId): Promise<void>;
     }
 
 
@@ -271,11 +313,19 @@ export namespace Chrome {
       symbol_types: string[];
     }
 
+    export type WasmValue = {type: 'i32'|'f32'|'f64', value: number}|{type: 'i64', value: bigint}|
+        {type: 'v128', value: string};
+
     export interface LanguageExtensions {
       registerLanguageExtensionPlugin(
           plugin: LanguageExtensionPlugin, pluginName: string,
           supportedScriptTypes: SupportedScriptTypes): Promise<void>;
       unregisterLanguageExtensionPlugin(plugin: LanguageExtensionPlugin): Promise<void>;
+
+      getWasmLinearMemory(offset: number, length: number, stopId: unknown): Promise<ArrayBuffer>;
+      getWasmLocal(local: number, stopId: unknown): Promise<WasmValue>;
+      getWasmGlobal(global: number, stopId: unknown): Promise<WasmValue>;
+      getWasmOp(op: number, stopId: unknown): Promise<WasmValue>;
     }
 
     export interface RecorderExtensions {

package/front_end/.eslintrc.js

@@ -20,7 +20,9 @@ module.exports = {
     'rulesdir/l10n_no_locked_or_placeholder_only_phrase': 2,
     'rulesdir/l10n_no_uistrings_export': 2,
     'rulesdir/l10n_no_unused_message': 2,
-    'rulesdir/custom_element_definitions_location': 2,
+    'rulesdir/custom_element_definitions_location': [2, {
+      rootFrontendDirectory: __dirname,
+    }],
     'rulesdir/custom_element_component_definition': 2,
   },
   'overrides': [

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -376,4 +376,5 @@ export enum EnumeratedHistogram {
   RecordingReplayStarted = 'DevTools.RecordingReplayStarted',
   RecordingToggled = 'DevTools.RecordingToggled',
   StyleTextCopied = 'DevTools.StyleTextCopied',
+  ManifestSectionSelected = 'DevTools.ManifestSectionSelected',
 }

package/front_end/core/host/UserMetrics.ts

@@ -270,6 +270,13 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(
         EnumeratedHistogram.StyleTextCopied, value, StyleTextCopied.MaxValue);
   }
+
+  manifestSectionSelected(sectionTitle: string): void {
+    const code =
+        ManifestSectionCodes[sectionTitle as keyof typeof ManifestSectionCodes] || ManifestSectionCodes.OtherSection;
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(
+        EnumeratedHistogram.ManifestSectionSelected, code, ManifestSectionCodes.MaxValue);
+  }
 }
 
 /**
@@ -972,4 +979,15 @@ export enum StyleTextCopied {
   MaxValue = 11,
 }
 
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum ManifestSectionCodes {
+  OtherSection = 0,
+  'Identity' = 1,
+  'Presentation' = 2,
+  'Protocol Handlers' = 3,
+  'Icons' = 4,
+  MaxValue = 5,
+}
+
 /* eslint-enable @typescript-eslint/naming-convention */

package/front_end/core/i18n/locales/en-US.json

@@ -1679,12 +1679,30 @@
   "models/timeline_model/TimelineJSProfile.ts | threadS": {
     "message": "Thread {PH1}"
   },
+  "models/timeline_model/TimelineModel.ts | bidderWorklet": {
+    "message": "Bidder Worklet"
+  },
+  "models/timeline_model/TimelineModel.ts | bidderWorkletS": {
+    "message": "Bidder Worklet — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | dedicatedWorker": {
     "message": "Dedicated Worker"
   },
+  "models/timeline_model/TimelineModel.ts | sellerWorklet": {
+    "message": "Seller Worklet"
+  },
+  "models/timeline_model/TimelineModel.ts | sellerWorkletS": {
+    "message": "Seller Worklet — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | threadS": {
     "message": "Thread {PH1}"
   },
+  "models/timeline_model/TimelineModel.ts | unknownWorklet": {
+    "message": "Auction Worklet"
+  },
+  "models/timeline_model/TimelineModel.ts | unknownWorkletS": {
+    "message": "Auction Worklet — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | workerS": {
     "message": "Worker — {PH1}"
   },
@@ -2207,6 +2225,9 @@
   "panels/application/ApplicationPanelSidebar.ts | backgroundServices": {
     "message": "Background Services"
   },
+  "panels/application/ApplicationPanelSidebar.ts | beforeInvokeAlert": {
+    "message": "{PH1}: Invoke to scroll to this section in manifest"
+  },
   "panels/application/ApplicationPanelSidebar.ts | cache": {
     "message": "Cache"
   },
@@ -2240,6 +2261,12 @@
   "panels/application/ApplicationPanelSidebar.ts | manifest": {
     "message": "Manifest"
   },
+  "panels/application/ApplicationPanelSidebar.ts | onInvokeAlert": {
+    "message": "Scrolled to {PH1}"
+  },
+  "panels/application/ApplicationPanelSidebar.ts | onInvokeManifestAlert": {
+    "message": "Manifest: Invoke to scroll to the top of manifest"
+  },
   "panels/application/ApplicationPanelSidebar.ts | openedWindows": {
     "message": "Opened Windows"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -1679,12 +1679,30 @@
   "models/timeline_model/TimelineJSProfile.ts | threadS": {
     "message": "T̂h́r̂éâd́ {PH1}"
   },
+  "models/timeline_model/TimelineModel.ts | bidderWorklet": {
+    "message": "B̂íd̂d́êŕ Ŵór̂ḱl̂ét̂"
+  },
+  "models/timeline_model/TimelineModel.ts | bidderWorkletS": {
+    "message": "B̂íd̂d́êŕ Ŵór̂ḱl̂ét̂ — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | dedicatedWorker": {
     "message": "D̂éd̂íĉát̂éd̂ Worker"
   },
+  "models/timeline_model/TimelineModel.ts | sellerWorklet": {
+    "message": "Ŝél̂ĺêŕ Ŵór̂ḱl̂ét̂"
+  },
+  "models/timeline_model/TimelineModel.ts | sellerWorkletS": {
+    "message": "Ŝél̂ĺêŕ Ŵór̂ḱl̂ét̂ — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | threadS": {
     "message": "T̂h́r̂éâd́ {PH1}"
   },
+  "models/timeline_model/TimelineModel.ts | unknownWorklet": {
+    "message": "Âúĉt́îón̂ Ẃôŕk̂ĺêt́"
+  },
+  "models/timeline_model/TimelineModel.ts | unknownWorkletS": {
+    "message": "Âúĉt́îón̂ Ẃôŕk̂ĺêt́ — {PH1}"
+  },
   "models/timeline_model/TimelineModel.ts | workerS": {
     "message": "Worker — {PH1}"
   },
@@ -2207,6 +2225,9 @@
   "panels/application/ApplicationPanelSidebar.ts | backgroundServices": {
     "message": "B̂áĉḱĝŕôún̂d́ Ŝér̂v́îćêś"
   },
+  "panels/application/ApplicationPanelSidebar.ts | beforeInvokeAlert": {
+    "message": "{PH1}: Îńv̂ók̂é t̂ó ŝćr̂ól̂ĺ t̂ó t̂h́îś ŝéĉt́îón̂ ín̂ ḿâńîf́êśt̂"
+  },
   "panels/application/ApplicationPanelSidebar.ts | cache": {
     "message": "Ĉáĉh́ê"
   },
@@ -2240,6 +2261,12 @@
   "panels/application/ApplicationPanelSidebar.ts | manifest": {
     "message": "M̂án̂íf̂éŝt́"
   },
+  "panels/application/ApplicationPanelSidebar.ts | onInvokeAlert": {
+    "message": "Ŝćr̂ól̂ĺêd́ t̂ó {PH1}"
+  },
+  "panels/application/ApplicationPanelSidebar.ts | onInvokeManifestAlert": {
+    "message": "M̂án̂íf̂éŝt́: Îńv̂ók̂é t̂ó ŝćr̂ól̂ĺ t̂ó t̂h́ê t́ôṕ ôf́ m̂án̂íf̂éŝt́"
+  },
   "panels/application/ApplicationPanelSidebar.ts | openedWindows": {
     "message": "Ôṕêńêd́ Ŵín̂d́ôẃŝ"
   },

package/front_end/devtools_compatibility.js

@@ -421,6 +421,7 @@
     RecordingToggled: 'DevTools.RecordingToggled',
     SyncSetting: 'DevTools.SyncSetting',
     StyleTextCopied: 'DevTools.StyleTextCopied',
+    ManifestSectionSelected: 'DevTools.ManifestSectionSelected',
   };
 
   /**

package/front_end/legacy_test_runner/sources_test_runner/DebuggerTestRunner.js

@@ -355,10 +355,11 @@ SourcesTestRunner.captureStackTraceIntoString = async function(callFrames, async
 
 SourcesTestRunner.dumpSourceFrameContents = function(sourceFrame) {
   TestRunner.addResult('==Source frame contents start==');
-  const textEditor = sourceFrame.textEditor;
+  const {baseDoc} = sourceFrame;
 
-  for (let i = 0; i < textEditor.linesCount; ++i) {
-    TestRunner.addResult(textEditor.line(i));
+  for (let i = 1; i <= baseDoc.lines; ++i) {
+    const {text} = baseDoc.line(i);
+    TestRunner.addResult(text);
   }
 
   TestRunner.addResult('==Source frame contents end==');