chrome-devtools-frontend 1.0.1020771 → 1.0.1022059

package/front_end/panels/elements/TopLayerContainer.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import * as ElementsComponents from './components/components.js';
@@ -79,7 +80,14 @@ export class TopLayerContainer extends UI.TreeOutline.TreeElement {
     const config = ElementsComponents.AdornerManager.getRegisteredAdorner(
         ElementsComponents.AdornerManager.RegisteredAdorners.TOP_LAYER);
     const adornerContent = document.createElement('span');
-    adornerContent.textContent = ` top-layer (${topLayerElementIndex}) `;
+    adornerContent.classList.add('adorner-with-icon');
+    const linkIcon = new IconButton.Icon.Icon();
+    linkIcon
+        .data = {iconName: 'ic_show_node_16x16', color: 'var(--color-text-disabled)', width: '12px', height: '12px'};
+    const adornerText = document.createElement('span');
+    adornerText.textContent = ` top-layer (${topLayerElementIndex}) `;
+    adornerContent.append(linkIcon);
+    adornerContent.append(adornerText);
     const adorner = element?.adorn(config, adornerContent);
     if (adorner) {
       const onClick = (((): void => {

package/front_end/panels/elements/components/AdornerManager.ts

@@ -31,6 +31,7 @@ export enum RegisteredAdorners {
   CONTAINER = 'container',
   SLOT = 'slot',
   TOP_LAYER = 'top-layer',
+  REVEAL = 'reveal',
 }
 
 // This enum-like const object serves as the authoritative registry for all the
@@ -79,6 +80,12 @@ export function getRegisteredAdorner(which: RegisteredAdorners): RegisteredAdorn
         category: AdornerCategories.LAYOUT,
         enabledByDefault: true,
       };
+    case RegisteredAdorners.REVEAL:
+      return {
+        name: 'reveal',
+        category: AdornerCategories.DEFAULT,
+        enabledByDefault: true,
+      };
   }
 }
 

package/front_end/panels/elements/components/CSSHintDetailsView.ts

@@ -0,0 +1,71 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
+import * as LitHtml from '../../../ui/lit-html/lit-html.js';
+import * as i18n from '../../../core/i18n/i18n.js';
+
+import cssHintDetailsViewStyles from './cssHintDetailsView.css.js';
+
+const UIStrings = {
+  /**
+    *@description Text for button that redirects to CSS property documentation.
+    */
+    learnMore: 'Learn More',
+};
+const str_ = i18n.i18n.registerUIStrings('panels/elements/components/CSSHintDetailsView.ts', UIStrings);
+const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+
+const {render, html, Directives} = LitHtml;
+
+interface Hint {
+    getHintPrefix(): string;
+    getHintMessage(): string;
+    getPossibleFixMessage(): string|null;
+    getLearnMoreLink(): string|null;
+}
+
+export class CSSHintDetailsView extends HTMLElement {
+    static readonly litTagName = LitHtml.literal`devtools-css-hint-details-view`;
+    readonly #shadow = this.attachShadow({mode: 'open'});
+    readonly #authoringHint: Hint;
+
+    constructor(authoringHint: Hint) {
+        super();
+        this.#authoringHint = authoringHint;
+        this.#shadow.adoptedStyleSheets = [cssHintDetailsViewStyles];
+        this.#render();
+    }
+
+    #render(): void {
+        render(html`
+            <div class="hint-popup-wrapper">
+                <div class="hint-popup-reason">
+                    <strong>${this.#authoringHint.getHintPrefix()}:</strong> ${Directives.unsafeHTML(this.#authoringHint.getHintMessage())}
+                </div>
+                ${this.#authoringHint.getPossibleFixMessage() ? html`
+                    <div class="hint-popup-possible-fix">
+                        ${Directives.unsafeHTML(this.#authoringHint.getPossibleFixMessage())}
+                        ${this.#authoringHint.getLearnMoreLink() ? html`
+                            <x-link id='learn-more' href='${this.#authoringHint.getLearnMoreLink()}' class='clickable underlined unbreakable-text'}>
+                                ${i18nString(UIStrings.learnMore)}
+                            </x-link>
+                        `: ''}
+                    </div>
+                ` : ''}
+            </div>
+        `, this.#shadow, {
+            host: this,
+          });
+    }
+}
+
+ComponentHelpers.CustomElements.defineComponent('devtools-css-hint-details-view', CSSHintDetailsView);
+
+declare global {
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    interface HTMLElementTagNameMap {
+      'devtools-css-hint-details-view': CSSHintDetailsView;
+    }
+}

package/front_end/panels/elements/components/components.ts

@@ -5,6 +5,7 @@
 import * as AccessibilityTreeNode from './AccessibilityTreeNode.js';
 import * as AdornerManager from './AdornerManager.js';
 import * as AdornerSettingsPane from './AdornerSettingsPane.js';
+import * as CSSHintDetailsView from './CSSHintDetailsView.js';
 import * as ComputedStyleProperty from './ComputedStyleProperty.js';
 import * as ComputedStyleTrace from './ComputedStyleTrace.js';
 import * as CSSPropertyIconResolver from './CSSPropertyIconResolver.js';
@@ -22,6 +23,7 @@ export {
   AccessibilityTreeNode,
   AdornerManager,
   AdornerSettingsPane,
+  CSSHintDetailsView,
   ComputedStyleProperty,
   ComputedStyleTrace,
   CSSPropertyIconResolver,

package/front_end/panels/elements/components/cssHintDetailsView.css

@@ -0,0 +1,36 @@
+/*
+ * Copyright 2022 The Chromium Authors. All rights reserved.
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+.hint-popup-wrapper {
+  width: 400px;
+  line-height: 1.1;
+  font-size: 12px;
+}
+
+code {
+  background-color: var(--color-background-elevation-1);
+  padding: 0 2px;
+}
+
+.property {
+  color: var(--color-syntax-1);
+}
+
+.hint-popup-possible-fix {
+  margin-top: 8px;
+}
+
+.clickable {
+  color: var(--color-link);
+}
+
+.underlined {
+  text-decoration: underline;
+}
+
+.unbreakable-text {
+  white-space: nowrap;
+}

package/front_end/panels/elements/elementsTreeOutline.css

@@ -27,6 +27,10 @@
   display: none;
 }
 
+.adorner-reveal {
+  margin: 3px;
+}
+
 .adorner-with-icon {
   display: flex;
   justify-content: center;

package/front_end/panels/elements/stylesSectionTree.css

@@ -159,7 +159,7 @@ ol.expanded {
   position: absolute;
   top: 0;
   bottom: 0;
-  margin: auto;
+  margin: auto auto auto 5px;
   display: inline-block;
   cursor: pointer;
   transform: scale(0.9);

package/front_end/panels/network/components/RequestHeadersView.ts

@@ -8,6 +8,7 @@ import {assertNotNullOrUndefined} from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';
 import * as Buttons from '../../../ui/components/buttons/buttons.js';
 import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
+import * as Input from '../../../ui/components/input/input.js';
 import * as UI from '../../../ui/legacy/legacy.js';
 import * as LitHtml from '../../../ui/lit-html/lit-html.js';
 
@@ -357,7 +358,7 @@ export class Category extends HTMLElement {
   #checked: boolean|undefined = undefined;
 
   connectedCallback(): void {
-    this.#shadow.adoptedStyleSheets = [requestHeadersViewStyles];
+    this.#shadow.adoptedStyleSheets = [requestHeadersViewStyles, Input.checkboxStyles];
   }
 
   set data(data: CategoryData) {

package/front_end/services/puppeteer/PuppeteerConnection.ts

@@ -60,14 +60,12 @@ export class Transport implements puppeteer.ConnectionTransport {
 }
 
 export class PuppeteerConnection extends puppeteer.Connection {
-  // Overriding Puppeteer's API here.
-  // eslint-disable-next-line rulesdir/no_underscored_properties
-  async _onMessage(message: string): Promise<void> {
+  override async onMessage(message: string): Promise<void> {
     const msgObj = JSON.parse(message) as {id: number, method: string, params: unknown, sessionId?: string};
     if (msgObj.sessionId && !this._sessions.has(msgObj.sessionId)) {
       return;
     }
-    void super._onMessage(message);
+    void super.onMessage(message);
   }
 }
 
@@ -90,7 +88,7 @@ export async function getPuppeteerConnection(
     return targetInfo.targetId === mainTargetId || targetInfo.openerId === mainTargetId || targetInfo.type === 'iframe';
   };
 
-  const browser = await puppeteer.Browser.create(
+  const browser = await puppeteer.Browser._create(
       connection,
       [] /* contextIds */,
       false /* ignoreHTTPSErrors */,

package/front_end/third_party/acorn/acorn.ts

@@ -4,7 +4,7 @@
 
 import * as acorn from './package/dist/acorn.mjs';
 
-import type * as ESTree from './estree-legacy';
+import type * as ESTree from './estree-legacy.js';
 export {ESTree};
 
 export { type Comment, defaultOptions, getLineInfo, isNewLine, lineBreak, lineBreakG, Node, SourceLocation, Token, tokTypes, tokContexts} from './package/dist/acorn.mjs';

package/front_end/third_party/chromium/client-variations/client-variations.ts

@@ -2,4 +2,4 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-export * from './ClientVariations.js';
+export * from './ClientVariations.js';

package/front_end/third_party/diff/DiffWrapper.ts

@@ -5,10 +5,12 @@
 import * as Common from '../../core/common/common.js';
 
 declare global {
+  /* eslint-disable @typescript-eslint/naming-convention */
   class diff_match_patch {
     diff_main(text1: string, text2: string): Array<{0: number, 1: string}>;
     diff_cleanupSemantic(diff: Array<{0: number, 1: string}>): void;
   }
+  /* eslint-enable @typescript-eslint/naming-convention */
 }
 
 export const DiffWrapper = {

package/front_end/third_party/i18n/i18n-impl.ts

@@ -15,8 +15,12 @@ export class I18n {
   readonly supportedLocales: ReadonlySet<Intl.UnicodeBCP47LocaleIdentifier>;
 
   private localeData = new Map<Intl.UnicodeBCP47LocaleIdentifier, LocalizedMessages>();
+  readonly defaultLocale;
+
+  constructor(
+    supportedLocales: readonly Intl.UnicodeBCP47LocaleIdentifier[] = LOCALES, defaultLocale = DEFAULT_LOCALE) {
+    this.defaultLocale = defaultLocale;
 
-  constructor(supportedLocales: ReadonlyArray<Intl.UnicodeBCP47LocaleIdentifier> = LOCALES, public readonly defaultLocale = DEFAULT_LOCALE) {
     this.supportedLocales = new Set(supportedLocales);
   }
 

package/front_end/third_party/i18n/i18n.ts

@@ -8,4 +8,4 @@ import * as LocalizedStringSet from './localized-string-set.js';
 export {
   I18n,
   LocalizedStringSet,
-}
+};

package/front_end/third_party/i18n/locales.ts

@@ -2,7 +2,7 @@
 // Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
 // Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
 
-export const LOCALES: ReadonlyArray<Intl.UnicodeBCP47LocaleIdentifier> = [
+export const LOCALES: readonly Intl.UnicodeBCP47LocaleIdentifier[] = [
   'af',
   'am',
   'ar',

package/front_end/third_party/lit-html/directives.ts

@@ -8,3 +8,4 @@ export * from './package/directives/style-map.js';
 export * from './package/directives/live.js';
 export * from './package/directives/repeat.js';
 export * from './package/directives/until.js';
+export * from './package/directives/unsafe-html.js';

package/front_end/third_party/lit-html/lit-html-tsconfig.json

@@ -8,6 +8,7 @@
     "package/directive.js",
     "package/directives/class-map.js",
     "package/directives/if-defined.js",
+    "package/directives/unsafe-html.js",
     "package/directives/style-map.js",
     "package/directives/repeat.js",
     "package/directives/until.js",

package/front_end/third_party/marked/marked.ts

@@ -1,3 +1,3 @@
 import {marked as Marked} from './package/lib/marked.esm.js';
 
-export {Marked}
+export {Marked};