chrome-devtools-frontend 1.0.1019389 → 1.0.1019968

package/config/gni/devtools_grd_files.gni

@@ -605,6 +605,7 @@ grd_files_debug_sources = [
   "front_end/core/sdk/CSSPropertyParser.js",
   "front_end/core/sdk/CSSQuery.js",
   "front_end/core/sdk/CSSRule.js",
+  "front_end/core/sdk/CSSScope.js",
   "front_end/core/sdk/CSSStyleDeclaration.js",
   "front_end/core/sdk/CSSStyleSheetHeader.js",
   "front_end/core/sdk/CSSSupports.js",
@@ -1461,6 +1462,7 @@ grd_files_debug_sources = [
   "front_end/ui/components/linear_memory_inspector/LinearMemoryNavigator.js",
   "front_end/ui/components/linear_memory_inspector/LinearMemoryValueInterpreter.js",
   "front_end/ui/components/linear_memory_inspector/LinearMemoryViewer.js",
+  "front_end/ui/components/linear_memory_inspector/LinearMemoryViewerUtils.js",
   "front_end/ui/components/linear_memory_inspector/ValueInterpreterDisplay.js",
   "front_end/ui/components/linear_memory_inspector/ValueInterpreterDisplayUtils.js",
   "front_end/ui/components/linear_memory_inspector/ValueInterpreterSettings.js",

package/front_end/core/sdk/CSSMatchedStyles.ts

@@ -491,7 +491,7 @@ export class CSSMatchedStyles {
       return true;
     }
     const parentRule = style.parentRule as CSSStyleRule;
-    const queries = [...parentRule.media, ...parentRule.containerQueries, ...parentRule.supports];
+    const queries = [...parentRule.media, ...parentRule.containerQueries, ...parentRule.supports, ...parentRule.scopes];
     for (const query of queries) {
       if (!query.active()) {
         return false;

package/front_end/core/sdk/CSSModel.ts

@@ -461,6 +461,28 @@ export class CSSModel extends SDKModel<EventTypes> {
     }
   }
 
+  async setScopeText(
+      styleSheetId: Protocol.CSS.StyleSheetId, range: TextUtils.TextRange.TextRange,
+      newScopeText: string): Promise<boolean> {
+    Host.userMetrics.actionTaken(Host.UserMetrics.Action.StyleRuleEdited);
+
+    try {
+      await this.ensureOriginalStyleSheetText(styleSheetId);
+      const {scope} = await this.agent.invoke_setScopeText({styleSheetId, range, text: newScopeText});
+
+      if (!scope) {
+        return false;
+      }
+      this.#domModel.markUndoableState();
+      const edit = new Edit(styleSheetId, range, newScopeText, scope);
+      this.fireStyleSheetChanged(styleSheetId, edit);
+      return true;
+    } catch (e) {
+      console.error(e);
+      return false;
+    }
+  }
+
   async addRule(styleSheetId: Protocol.CSS.StyleSheetId, ruleText: string, ruleLocation: TextUtils.TextRange.TextRange):
       Promise<CSSStyleRule|null> {
     try {

package/front_end/core/sdk/CSSQuery.ts

@@ -9,7 +9,8 @@ import type {CSSModel, Edit} from './CSSModel.js';
 import {CSSLocation} from './CSSModel.js';
 import type {CSSStyleSheetHeader} from './CSSStyleSheetHeader.js';
 
-type CSSQueryPayload = Protocol.CSS.CSSMedia|Protocol.CSS.CSSContainerQuery|Protocol.CSS.CSSSupports;
+type CSSQueryPayload =
+    Protocol.CSS.CSSMedia|Protocol.CSS.CSSContainerQuery|Protocol.CSS.CSSSupports|Protocol.CSS.CSSScope;
 
 export abstract class CSSQuery {
   text = '';

package/front_end/core/sdk/CSSRule.ts

@@ -9,6 +9,7 @@ import * as Platform from '../platform/platform.js';
 import {CSSContainerQuery} from './CSSContainerQuery.js';
 import {CSSLayer} from './CSSLayer.js';
 import {CSSMedia} from './CSSMedia.js';
+import {CSSScope} from './CSSScope.js';
 import {CSSSupports} from './CSSSupports.js';
 
 import type {CSSModel, Edit} from './CSSModel.js';
@@ -103,6 +104,7 @@ export class CSSStyleRule extends CSSRule {
   media: CSSMedia[];
   containerQueries: CSSContainerQuery[];
   supports: CSSSupports[];
+  scopes: CSSScope[];
   layers: CSSLayer[];
   wasUsed: boolean;
   constructor(cssModel: CSSModel, payload: Protocol.CSS.CSSRule, wasUsed?: boolean) {
@@ -113,6 +115,7 @@ export class CSSStyleRule extends CSSRule {
     this.containerQueries = payload.containerQueries ?
         CSSContainerQuery.parseContainerQueriesPayload(cssModel, payload.containerQueries) :
         [];
+    this.scopes = payload.scopes ? CSSScope.parseScopesPayload(cssModel, payload.scopes) : [];
     this.supports = payload.supports ? CSSSupports.parseSupportsPayload(cssModel, payload.supports) : [];
     this.layers = payload.layers ? CSSLayer.parseLayerPayload(cssModel, payload.layers) : [];
     this.wasUsed = wasUsed || false;
@@ -200,6 +203,7 @@ export class CSSStyleRule extends CSSRule {
     }
     this.media.forEach(media => media.rebase(edit));
     this.containerQueries.forEach(cq => cq.rebase(edit));
+    this.scopes.forEach(scope => scope.rebase(edit));
     this.supports.forEach(supports => supports.rebase(edit));
 
     super.rebase(edit);

package/front_end/core/sdk/CSSScope.ts

@@ -0,0 +1,30 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as TextUtils from '../../models/text_utils/text_utils.js';
+import type * as Protocol from '../../generated/protocol.js';
+
+import type {CSSModel} from './CSSModel.js';
+import {CSSQuery} from './CSSQuery.js';
+
+export class CSSScope extends CSSQuery {
+  static parseScopesPayload(cssModel: CSSModel, payload: Protocol.CSS.CSSScope[]): CSSScope[] {
+    return payload.map(scope => new CSSScope(cssModel, scope));
+  }
+
+  constructor(cssModel: CSSModel, payload: Protocol.CSS.CSSScope) {
+    super(cssModel);
+    this.reinitialize(payload);
+  }
+
+  reinitialize(payload: Protocol.CSS.CSSScope): void {
+    this.text = payload.text;
+    this.range = payload.range ? TextUtils.TextRange.TextRange.fromObject(payload.range) : null;
+    this.styleSheetId = payload.styleSheetId;
+  }
+
+  active(): boolean {
+    return true;
+  }
+}

package/front_end/core/sdk/sdk.ts

@@ -33,6 +33,7 @@ import * as CSSProperty from './CSSProperty.js';
 import * as CSSPropertyParser from './CSSPropertyParser.js';
 import * as CSSQuery from './CSSQuery.js';
 import * as CSSRule from './CSSRule.js';
+import * as CSSScope from './CSSScope.js';
 import * as CSSStyleDeclaration from './CSSStyleDeclaration.js';
 import * as CSSStyleSheetHeader from './CSSStyleSheetHeader.js';
 import * as CSSSupports from './CSSSupports.js';
@@ -103,6 +104,7 @@ export {
   CSSPropertyParser,
   CSSQuery,
   CSSRule,
+  CSSScope,
   CSSStyleDeclaration,
   CSSStyleSheetHeader,
   CSSSupports,

package/front_end/models/bindings/BreakpointManager.ts

@@ -409,13 +409,18 @@ export type EventTypes = {
   [Events.BreakpointRemoved]: BreakpointLocation,
 };
 
-const enum DebuggerUpdateResult {
+export const enum DebuggerUpdateResult {
   OK = 'OK',
-  ERROR = 'ERROR',
+  ERROR_BREAKPOINT_CLASH = 'ERROR_BREAKPOINT_CLASH',
+  ERROR_BACKEND = 'ERROR_BACKEND',
+
   // PENDING implies that the current update requires another re-run.
   PENDING = 'PENDING',
 }
 
+export type ScheduleUpdateResult =
+    DebuggerUpdateResult.OK|DebuggerUpdateResult.ERROR_BACKEND|DebuggerUpdateResult.ERROR_BREAKPOINT_CLASH;
+
 const enum ResolveLocationResult {
   OK = 'OK',
   ERROR = 'ERROR',
@@ -430,7 +435,7 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
   uiSourceCodes: Set<Workspace.UISourceCode.UISourceCode>;
   #conditionInternal!: string;
   #enabledInternal!: boolean;
-  isRemoved!: boolean;
+  isRemoved = false;
   currentState: Breakpoint.State|null;
   readonly #modelBreakpoints: Map<SDK.DebuggerModel.DebuggerModel, ModelBreakpoint>;
 
@@ -629,6 +634,9 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
   }
 
   async remove(keepInStorage: boolean): Promise<void> {
+    if (this.getIsRemoved()) {
+      return;
+    }
     this.isRemoved = true;
     const removeFromStorage = !keepInStorage;
 
@@ -676,9 +684,11 @@ export class Breakpoint implements SDK.TargetManager.SDKModelObserver<SDK.Debugg
   }
 
   async #updateModel(model: ModelBreakpoint): Promise<void> {
-    const success = await model.scheduleUpdateInDebugger();
-    if (!success) {
-      await this.remove(false);
+    const result = await model.scheduleUpdateInDebugger();
+    if (result === DebuggerUpdateResult.ERROR_BACKEND) {
+      await this.remove(true /* keepInStorage */);
+    } else if (result === DebuggerUpdateResult.ERROR_BREAKPOINT_CLASH) {
+      await this.remove(false /* keepInStorage */);
     }
   }
 }
@@ -722,11 +732,9 @@ export class ModelBreakpoint {
     this.#liveLocations.disposeAll();
   }
 
-  // Returns true, if scheduling ran as expected.
-  // Returns false, if an error occurred.
-  async scheduleUpdateInDebugger(): Promise<boolean> {
+  async scheduleUpdateInDebugger(): Promise<ScheduleUpdateResult> {
     if (!this.#debuggerModel.debuggerEnabled()) {
-      return true;
+      return DebuggerUpdateResult.OK;
     }
 
     const release = await this.#updateMutex.acquire();
@@ -735,7 +743,7 @@ export class ModelBreakpoint {
       result = await this.#updateInDebugger();
     }
     release();
-    return result === DebuggerUpdateResult.OK;
+    return result;
   }
 
   private scriptDiverged(): boolean {
@@ -849,7 +857,7 @@ export class ModelBreakpoint {
     // Something went wrong: we expect to have a non-null state, but have not received any
     // breakpointIds from the back-end.
     if (!breakpointIds.length) {
-      return DebuggerUpdateResult.ERROR;
+      return DebuggerUpdateResult.ERROR_BACKEND;
     }
 
     this.#breakpointIds = breakpointIds;
@@ -859,7 +867,7 @@ export class ModelBreakpoint {
 
     // Breakpoint clash: the resolved location resolves to a different breakpoint, report an error.
     if (resolvedResults.includes(ResolveLocationResult.ERROR)) {
-      return DebuggerUpdateResult.ERROR;
+      return DebuggerUpdateResult.ERROR_BREAKPOINT_CLASH;
     }
     return DebuggerUpdateResult.OK;
   }
@@ -917,7 +925,7 @@ export class ModelBreakpoint {
       Promise<void> {
     const result = await this.addResolvedLocation(location);
     if (result === ResolveLocationResult.ERROR) {
-      await this.#breakpoint.remove(false);
+      await this.#breakpoint.remove(false /* keepInStorage */);
     }
   }
 

package/front_end/panels/elements/ElementsTreeOutline.ts

@@ -35,10 +35,12 @@
 import * as Common from '../../core/common/common.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as Adorners from '../../ui/components/adorners/adorners.js';
 import * as CodeHighlighter from '../../ui/components/code_highlighter/code_highlighter.js';
+import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
-import {linkifyDeferredNodeReference} from './DOMLinkifier.js';
+import * as ElementsComponents from './components/components.js';
 import {ElementsPanel} from './ElementsPanel.js';
 import {ElementsTreeElement, InitialChildrenLimit} from './ElementsTreeElement.js';
 import elementsTreeOutlineStyles from './elementsTreeOutline.css.js';
@@ -555,7 +557,9 @@ export class ElementsTreeOutline extends
     // items extend at least to the right edge of the outer <ol> container.
     // In the no-word-wrap mode the outer <ol> may be wider than the tree container
     // (and partially hidden), in which case we are left to use only its right boundary.
-    const x = scrollContainer.totalOffsetLeft() + scrollContainer.offsetWidth - 18;
+    // We use .clientWidth to account for possible scrollbar, and subtract 6px
+    // for the width of the split widget (see splitWidget.css).
+    const x = scrollContainer.totalOffsetLeft() + scrollContainer.clientWidth - 6;
 
     const y = event.pageY;
 
@@ -1627,13 +1631,45 @@ export class ShortcutTreeElement extends UI.TreeOutline.TreeElement {
       text = '<' + text + '>';
     }
     title.textContent = '\u21AA ' + text;
-
-    const link = (linkifyDeferredNodeReference(nodeShortcut.deferredNode) as Element);
-    UI.UIUtils.createTextChild(this.listItemElement, ' ');
-    link.classList.add('elements-tree-shortcut-link');
-    link.textContent = i18nString(UIStrings.reveal);
-    this.listItemElement.appendChild(link);
     this.nodeShortcut = nodeShortcut;
+    this.addRevealAdorner();
+  }
+
+  addRevealAdorner(): void {
+    const adorner = new Adorners.Adorner.Adorner();
+    adorner.classList.add('adorner-reveal');
+    const config = ElementsComponents.AdornerManager.getRegisteredAdorner(
+        ElementsComponents.AdornerManager.RegisteredAdorners.REVEAL);
+    const name = config.name;
+    const adornerContent = document.createElement('span');
+    const linkIcon = new IconButton.Icon.Icon();
+    linkIcon
+        .data = {iconName: 'ic_show_node_16x16', color: 'var(--color-text-disabled)', width: '12px', height: '12px'};
+    const slotText = document.createElement('span');
+    slotText.textContent = name;
+    adornerContent.append(linkIcon);
+    adornerContent.append(slotText);
+    adornerContent.classList.add('adorner-with-icon');
+    adorner.data = {
+      name,
+      content: adornerContent,
+    };
+    this.listItemElement.appendChild(adorner);
+    const onClick = (((): void => {
+                       this.nodeShortcut.deferredNode.resolve(
+                           node => {
+                             void Common.Revealer.reveal(node);
+                           },
+                       );
+                     }) as EventListener);
+    adorner.addInteraction(onClick, {
+      isToggle: false,
+      shouldPropagateOnKeydown: false,
+      ariaLabelDefault: i18nString(UIStrings.reveal),
+      ariaLabelActive: i18nString(UIStrings.reveal),
+    });
+    adorner.addEventListener('mousedown', e => e.consume(), false);
+    ElementsPanel.instance().registerAdorner(adorner);
   }
 
   get hovered(): boolean {

package/front_end/panels/elements/StylePropertiesSection.ts

@@ -708,6 +708,7 @@ export class StylePropertiesSection {
   protected createAtRuleLists(rule: SDK.CSSRule.CSSStyleRule): void {
     this.createMediaList(rule.media);
     this.createContainerQueryList(rule.containerQueries);
+    this.createScopesList(rule.scopes);
     this.createSupportsList(rule.supports);
   }
 
@@ -778,6 +779,28 @@ export class StylePropertiesSection {
     }
   }
 
+  protected createScopesList(scopesList: SDK.CSSScope.CSSScope[]): void {
+    for (let i = scopesList.length - 1; i >= 0; --i) {
+      const scope = scopesList[i];
+      if (!scope.text) {
+        continue;
+      }
+
+      let onQueryTextClick;
+      if (scope.styleSheetId) {
+        onQueryTextClick = this.handleQueryRuleClick.bind(this, scope);
+      }
+
+      const scopeElement = new ElementsComponents.CSSQuery.CSSQuery();
+      scopeElement.data = {
+        queryPrefix: '@scope',
+        queryText: scope.text,
+        onQueryTextClick,
+      };
+      this.queryListElement.append(scopeElement);
+    }
+  }
+
   protected createSupportsList(supportsList: SDK.CSSSupports.CSSSupports[]): void {
     for (let i = supportsList.length - 1; i >= 0; --i) {
       const supports = supportsList[i];
@@ -1185,6 +1208,8 @@ export class StylePropertiesSection {
         success = await cssModel.setContainerQueryText(query.styleSheetId, range, newContent);
       } else if (query instanceof SDK.CSSSupports.CSSSupports) {
         success = await cssModel.setSupportsText(query.styleSheetId, range, newContent);
+      } else if (query instanceof SDK.CSSScope.CSSScope) {
+        success = await cssModel.setScopeText(query.styleSheetId, range, newContent);
       } else {
         success = await cssModel.setMediaText(query.styleSheetId, range, newContent);
       }

package/front_end/panels/elements/TopLayerContainer.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 import * as i18n from '../../core/i18n/i18n.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as IconButton from '../../ui/components/icon_button/icon_button.js';
 import * as UI from '../../ui/legacy/legacy.js';
 
 import * as ElementsComponents from './components/components.js';
@@ -79,7 +80,14 @@ export class TopLayerContainer extends UI.TreeOutline.TreeElement {
     const config = ElementsComponents.AdornerManager.getRegisteredAdorner(
         ElementsComponents.AdornerManager.RegisteredAdorners.TOP_LAYER);
     const adornerContent = document.createElement('span');
-    adornerContent.textContent = ` top-layer (${topLayerElementIndex}) `;
+    adornerContent.classList.add('adorner-with-icon');
+    const linkIcon = new IconButton.Icon.Icon();
+    linkIcon
+        .data = {iconName: 'ic_show_node_16x16', color: 'var(--color-text-disabled)', width: '12px', height: '12px'};
+    const adornerText = document.createElement('span');
+    adornerText.textContent = ` top-layer (${topLayerElementIndex}) `;
+    adornerContent.append(linkIcon);
+    adornerContent.append(adornerText);
     const adorner = element?.adorn(config, adornerContent);
     if (adorner) {
       const onClick = (((): void => {

package/front_end/panels/elements/components/AdornerManager.ts

@@ -31,6 +31,7 @@ export enum RegisteredAdorners {
   CONTAINER = 'container',
   SLOT = 'slot',
   TOP_LAYER = 'top-layer',
+  REVEAL = 'reveal',
 }
 
 // This enum-like const object serves as the authoritative registry for all the
@@ -79,6 +80,12 @@ export function getRegisteredAdorner(which: RegisteredAdorners): RegisteredAdorn
         category: AdornerCategories.LAYOUT,
         enabledByDefault: true,
       };
+    case RegisteredAdorners.REVEAL:
+      return {
+        name: 'reveal',
+        category: AdornerCategories.DEFAULT,
+        enabledByDefault: true,
+      };
   }
 }
 

package/front_end/panels/elements/elementsTreeOutline.css

@@ -27,6 +27,10 @@
   display: none;
 }
 
+.adorner-reveal {
+  margin: 3px;
+}
+
 .adorner-with-icon {
   display: flex;
   justify-content: center;

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspector.ts

@@ -27,6 +27,7 @@ import {
 import {formatAddress, parseAddress} from './LinearMemoryInspectorUtils.js';
 import type {JumpToPointerAddressEvent, ValueTypeModeChangedEvent} from './ValueInterpreterDisplay.js';
 import {LinearMemoryViewer} from './LinearMemoryViewer.js';
+import type {HighlightInfo} from './LinearMemoryViewerUtils.js';
 
 import * as i18n from '../../../core/i18n/i18n.js';
 const UIStrings = {
@@ -51,6 +52,7 @@ export interface LinearMemoryInspectorData {
   valueTypes?: Set<ValueType>;
   valueTypeModes?: Map<ValueType, ValueTypeMode>;
   endianness?: Endianness;
+  highlightInfo?: HighlightInfo;
 }
 
 export type Settings = {
@@ -120,6 +122,10 @@ export class LinearMemoryInspector extends HTMLElement {
   #outerMemoryLength = 0;
 
   #address = -1;
+  #highlightInfo: HighlightInfo = {
+    size: 0,
+    startAddress: 0,
+  };
 
   #currentNavigatorMode = Mode.Submitted;
   #currentNavigatorAddressLine = `${this.#address}`;
@@ -143,12 +149,23 @@ export class LinearMemoryInspector extends HTMLElement {
       throw new Error('Memory offset has to be greater or equal to zero.');
     }
 
+    if (data.highlightInfo !== undefined) {
+      if (data.highlightInfo.size < 0) {
+        throw new Error('Object size has to be greater than or equal to zero');
+      }
+      if (data.highlightInfo.startAddress > data.memoryOffset + data.memory.length ||
+          data.highlightInfo.startAddress < 0) {
+        throw new Error('Object start address is out of bounds.');
+      }
+    }
+
     this.#memory = data.memory;
     this.#memoryOffset = data.memoryOffset;
     this.#outerMemoryLength = data.outerMemoryLength;
     this.#valueTypeModes = data.valueTypeModes || this.#valueTypeModes;
     this.#valueTypes = data.valueTypes || this.#valueTypes;
     this.#endianness = data.endianness || this.#endianness;
+    this.#highlightInfo = data.highlightInfo || this.#highlightInfo;
     this.#setAddress(data.address);
     this.#render();
   }
@@ -179,7 +196,12 @@ export class LinearMemoryInspector extends HTMLElement {
           @pagenavigation=${this.#navigatePage}
           @historynavigation=${this.#navigateHistory}></${LinearMemoryNavigator.litTagName}>
         <${LinearMemoryViewer.litTagName}
-          .data=${{memory: this.#memory.slice(start - this.#memoryOffset, end - this.#memoryOffset), address: this.#address, memoryOffset: start, focus: this.#currentNavigatorMode === Mode.Submitted} as LinearMemoryViewerData}
+          .data=${{
+            memory: this.#memory.slice(start - this.#memoryOffset,
+            end - this.#memoryOffset),
+            address: this.#address, memoryOffset: start,
+            focus: this.#currentNavigatorMode === Mode.Submitted,
+            highlightInfo: this.#highlightInfo } as LinearMemoryViewerData}
           @byteselected=${this.#onByteSelected}
           @resize=${this.#resize}>
         </${LinearMemoryViewer.litTagName}>

package/front_end/ui/components/linear_memory_inspector/LinearMemoryViewer.ts

@@ -4,6 +4,7 @@
 import * as LitHtml from '../../lit-html/lit-html.js';
 import * as ComponentHelpers from '../helpers/helpers.js';
 
+import type {HighlightInfo} from './LinearMemoryViewerUtils.js';
 import {toHexString} from './LinearMemoryInspectorUtils.js';
 import linearMemoryViewerStyles from './linearMemoryViewer.css.js';
 
@@ -14,6 +15,7 @@ export interface LinearMemoryViewerData {
   address: number;
   memoryOffset: number;
   focus: boolean;
+  highlightInfo?: HighlightInfo;
 }
 
 export class ByteSelectedEvent extends Event {
@@ -50,6 +52,10 @@ export class LinearMemoryViewer extends HTMLElement {
   #memory = new Uint8Array();
   #address = 0;
   #memoryOffset = 0;
+  #highlightInfo: HighlightInfo = {
+    size: 0,
+    startAddress: 0,
+  };
 
   #numRows = 1;
   #numBytesInRow = BYTE_GROUP_SIZE;
@@ -69,6 +75,7 @@ export class LinearMemoryViewer extends HTMLElement {
 
     this.#memory = data.memory;
     this.#address = data.address;
+    this.#highlightInfo = data.highlightInfo || this.#highlightInfo;
     this.#memoryOffset = data.memoryOffset;
     this.#focusOnByte = data.focus;
     this.#update();
@@ -230,18 +237,20 @@ export class LinearMemoryViewer extends HTMLElement {
   #renderByteValues(startIndex: number, endIndex: number): LitHtml.TemplateResult {
     const cells = [];
     for (let i = startIndex; i < endIndex; ++i) {
+      const actualIndex = i + this.#memoryOffset;
       // Add margin after each group of bytes of size byteGroupSize.
       const addMargin = i !== startIndex && (i - startIndex) % BYTE_GROUP_SIZE === 0;
       const selected = i === this.#address - this.#memoryOffset;
+      const shouldBeHighlighted = this.#shouldBeHighlighted(actualIndex);
       const classMap = {
         'cell': true,
         'byte-cell': true,
         'byte-group-margin': addMargin,
         selected,
+        'highlight-area': shouldBeHighlighted,
       };
       const isSelectableCell = i < this.#memory.length;
       const byteValue = isSelectableCell ? html`${toHexString({number: this.#memory[i], pad: 2, prefix: false})}` : '';
-      const actualIndex = i + this.#memoryOffset;
       const onSelectedByte = isSelectableCell ? this.#onSelectedByte.bind(this, actualIndex) : '';
       cells.push(html`<span class=${LitHtml.Directives.classMap(classMap)} @click=${onSelectedByte}>${byteValue}</span>`);
     }
@@ -251,10 +260,13 @@ export class LinearMemoryViewer extends HTMLElement {
   #renderCharacterValues(startIndex: number, endIndex: number): LitHtml.TemplateResult {
     const cells = [];
     for (let i = startIndex; i < endIndex; ++i) {
+      const actualIndex = i + this.#memoryOffset;
+      const shouldBeHighlighted = this.#shouldBeHighlighted(actualIndex);
       const classMap = {
         'cell': true,
         'text-cell': true,
         selected: this.#address - this.#memoryOffset === i,
+        'highlight-area': shouldBeHighlighted,
       };
       const isSelectableCell = i < this.#memory.length;
       const value = isSelectableCell ? html`${this.#toAscii(this.#memory[i])}` : '';
@@ -274,6 +286,11 @@ export class LinearMemoryViewer extends HTMLElement {
   #onSelectedByte(index: number): void {
     this.dispatchEvent(new ByteSelectedEvent(index));
   }
+
+  #shouldBeHighlighted(index: number): boolean {
+    return this.#highlightInfo.startAddress <= index
+    && index < this.#highlightInfo.startAddress + this.#highlightInfo.size;
+  }
 }
 
 ComponentHelpers.CustomElements.defineComponent('devtools-linear-memory-inspector-viewer', LinearMemoryViewer);

package/front_end/ui/components/linear_memory_inspector/LinearMemoryViewerUtils.ts

@@ -0,0 +1,8 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+export interface HighlightInfo {
+  startAddress: number;
+  size: number;
+}

package/front_end/ui/components/linear_memory_inspector/linearMemoryViewer.css

@@ -36,6 +36,10 @@
   background-color: var(--legacy-item-selection-bg-color);
 }
 
+.highlight-area {
+  background-color: var(--legacy-item-selection-bg-color);
+}
+
 .byte-cell {
   min-width: 21px;
   color: var(--color-text-primary);

package/front_end/ui/components/linear_memory_inspector/linear_memory_inspector.ts

@@ -9,6 +9,7 @@ import * as LinearMemoryInspectorUtils from './LinearMemoryInspectorUtils.js';
 import * as LinearMemoryNavigator from './LinearMemoryNavigator.js';
 import * as LinearMemoryValueInterpreter from './LinearMemoryValueInterpreter.js';
 import * as LinearMemoryViewer from './LinearMemoryViewer.js';
+import * as LinearMemoryViewerUtils from './LinearMemoryViewerUtils.js';
 import * as ValueInterpreterDisplay from './ValueInterpreterDisplay.js';
 import * as ValueInterpreterDisplayUtils from './ValueInterpreterDisplayUtils.js';
 import * as ValueInterpreterSettings from './ValueInterpreterSettings.js';
@@ -21,6 +22,7 @@ export {
   LinearMemoryNavigator,
   LinearMemoryValueInterpreter,
   LinearMemoryViewer,
+  LinearMemoryViewerUtils,
   ValueInterpreterDisplay,
   ValueInterpreterDisplayUtils,
   ValueInterpreterSettings,

package/front_end/ui/components/panel_feedback/PreviewToggle.ts

@@ -67,18 +67,11 @@ export class PreviewToggle extends HTMLElement {
 
   #render(): void {
     const checked = Root.Runtime.experiments.isEnabled(this.#experiment);
-    const hasLink = Boolean(this.#feedbackURL) || Boolean(this.#learnMoreURL);
-
-    const containerClasses = LitHtml.Directives.classMap({
-      'container': true,
-      'has-link': hasLink,
-    });
-
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     render(
       html`
-      <div class=${containerClasses}>
+      <div class="container">
         <div class="checkbox-line">
           <label class="experiment-preview">
             <input type="checkbox" ?checked=${checked} @change=${this.#checkboxChanged} aria-label=${this.#name}/>

package/front_end/ui/components/panel_feedback/previewToggle.css

@@ -33,16 +33,10 @@
   padding: 4px;
 }
 
-.container.has-link {
-  /* For x-link outline not to paint over the helper text
-  we need to have 2 * <padding>px additional line height */
-  line-height: calc(1em + 8px);
-}
-
 .x-link {
   color: var(--color-primary);
   text-decoration-line: underline;
-  padding: 4px;
+  margin: 4px;
 }
 
 .feedback .x-link {

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1019389"
+  "version": "1.0.1019968"
 }