chrome-devtools-frontend 1.0.1018017 → 1.0.1019017

package/config/gni/devtools_grd_files.gni

@@ -933,6 +933,7 @@ grd_files_debug_sources = [
   "front_end/panels/developer_resources/developerResourcesView.css.js",
   "front_end/panels/elements/AccessibilityTreeUtils.js",
   "front_end/panels/elements/AccessibilityTreeView.js",
+  "front_end/panels/elements/CSSRuleValidator.js",
   "front_end/panels/elements/ClassesPaneWidget.js",
   "front_end/panels/elements/ColorSwatchPopoverIcon.js",
   "front_end/panels/elements/ComputedStyleModel.js",

package/front_end/core/i18n/locales/en-US.json

@@ -3209,6 +3209,9 @@
   "panels/application/components/PermissionsPolicySection.ts | showDetails": {
     "message": "Show details"
   },
+  "panels/application/components/ProtocolHandlersView.ts | dropdownLabel": {
+    "message": "Select protocol handler"
+  },
   "panels/application/components/ProtocolHandlersView.ts | manifest": {
     "message": "manifest"
   },
@@ -3227,6 +3230,9 @@
   "panels/application/components/ProtocolHandlersView.ts | testProtocol": {
     "message": "Test protocol"
   },
+  "panels/application/components/ProtocolHandlersView.ts | textboxLabel": {
+    "message": "Query parameter or endpoint for protocol handler"
+  },
   "panels/application/components/ReportsGrid.ts | destination": {
     "message": "Destination"
   },
@@ -4682,6 +4688,12 @@
   "panels/elements/ComputedStyleWidget.ts | showAll": {
     "message": "Show all"
   },
+  "panels/elements/CSSRuleValidator.ts | alignContentRuleOnNoWrapFlex": {
+    "message": "This element has flex-wrap: nowrap rule, therefore 'align-content' has no effect."
+  },
+  "panels/elements/CSSRuleValidator.ts | notFlexItemHint": {
+    "message": "Parent of this element is not flex container, therefore {PH1} property has no effect."
+  },
   "panels/elements/DOMLinkifier.ts | node": {
     "message": "<node>"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -3209,6 +3209,9 @@
   "panels/application/components/PermissionsPolicySection.ts | showDetails": {
     "message": "Ŝh́ôẃ d̂ét̂áîĺŝ"
   },
+  "panels/application/components/ProtocolHandlersView.ts | dropdownLabel": {
+    "message": "Ŝél̂éĉt́ p̂ŕôt́ôćôĺ ĥán̂d́l̂ér̂"
+  },
   "panels/application/components/ProtocolHandlersView.ts | manifest": {
     "message": "m̂án̂íf̂éŝt́"
   },
@@ -3227,6 +3230,9 @@
   "panels/application/components/ProtocolHandlersView.ts | testProtocol": {
     "message": "T̂éŝt́ p̂ŕôt́ôćôĺ"
   },
+  "panels/application/components/ProtocolHandlersView.ts | textboxLabel": {
+    "message": "Q̂úêŕŷ ṕâŕâḿêt́êŕ ôŕ êńd̂ṕôín̂t́ f̂ór̂ ṕr̂ót̂óĉól̂ h́âńd̂ĺêŕ"
+  },
   "panels/application/components/ReportsGrid.ts | destination": {
     "message": "D̂éŝt́îńât́îón̂"
   },
@@ -4682,6 +4688,12 @@
   "panels/elements/ComputedStyleWidget.ts | showAll": {
     "message": "Ŝh́ôẃ âĺl̂"
   },
+  "panels/elements/CSSRuleValidator.ts | alignContentRuleOnNoWrapFlex": {
+    "message": "T̂h́îś êĺêḿêńt̂ h́âś f̂ĺêx́-ŵŕâṕ: n̂óŵŕâṕ r̂úl̂é, t̂h́êŕêf́ôŕê 'ál̂íĝń-ĉón̂t́êńt̂' h́âś n̂ó êf́f̂éĉt́."
+  },
+  "panels/elements/CSSRuleValidator.ts | notFlexItemHint": {
+    "message": "P̂ár̂én̂t́ ôf́ t̂h́îś êĺêḿêńt̂ íŝ ńôt́ f̂ĺêx́ ĉón̂t́âín̂ér̂, t́ĥér̂éf̂ór̂é {PH1} p̂ŕôṕêŕt̂ý ĥáŝ ńô éf̂f́êćt̂."
+  },
   "panels/elements/DOMLinkifier.ts | node": {
     "message": "<n̂ód̂é>"
   },

package/front_end/panels/application/DOMStorageModel.ts

@@ -319,12 +319,16 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
     }
   }
 
-  private storageKey(securityOrigin: string, storageKey: string, isLocalStorage: boolean): string {
+  private storageKey(securityOrigin: string|undefined, storageKey: string|undefined, isLocalStorage: boolean): string {
     // TODO(crbug.com/1313434) Prioritize storageKey once everything is ready
+    console.assert(Boolean(securityOrigin) || Boolean(storageKey));
     if (securityOrigin) {
       return JSON.stringify(DOMStorage.storageIdWithSecurityOrigin(securityOrigin, isLocalStorage));
     }
-    return JSON.stringify(DOMStorage.storageIdWithStorageKey(storageKey, isLocalStorage));
+    if (storageKey) {
+      return JSON.stringify(DOMStorage.storageIdWithStorageKey(storageKey, isLocalStorage));
+    }
+    throw new Error('Either securityOrigin or storageKey is required');
   }
 
   private keyForSecurityOrigin(securityOrigin: string, isLocalStorage: boolean): string {
@@ -375,7 +379,8 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   }
 
   storageForId(storageId: Protocol.DOMStorage.StorageId): DOMStorage {
-    return this.storagesInternal[JSON.stringify(storageId)];
+    return this
+        .storagesInternal[this.storageKey(storageId.securityOrigin, storageId.storageKey, storageId.isLocalStorage)];
   }
 
   storages(): DOMStorage[] {

package/front_end/panels/application/components/ProtocolHandlersView.ts

@@ -48,6 +48,14 @@ const UIStrings = {
  *@description Text for test protocol button
  */
   testProtocol: 'Test protocol',
+  /**
+  * @description Aria text for screen reader to announce they can select a protocol handler in the dropdown
+  */
+  dropdownLabel: 'Select protocol handler',
+  /**
+  * @description Aria text for screen reader to announce they can enter query parameters or endpoints into the textbox
+  */
+  textboxLabel: 'Query parameter or endpoint for protocol handler',
 };
 
 const str_ = i18n.i18n.registerUIStrings('panels/application/components/ProtocolHandlersView.ts', UIStrings);
@@ -121,11 +129,12 @@ export class ProtocolHandlersView extends HTMLElement {
                                 .map(p => LitHtml.html`<option value=${p.protocol}>${p.protocol}://</option>`);
     return LitHtml.html`
        <div class="protocol-handlers-row">
-        <select class="chrome-select protocol-select" @change=${this.#handleProtocolSelect}>
+        <select class="chrome-select protocol-select" @change=${this.#handleProtocolSelect} aria-label=${
+        i18nString(UIStrings.dropdownLabel)}>
            ${protocolOptions}
         </select>
         <input .value=${this.#queryInputState} class="devtools-text-input" type="text" @change=${
-        this.#handleQueryInputChange}/>
+        this.#handleQueryInputChange} aria-label=${i18nString(UIStrings.textboxLabel)}/>
         <${Buttons.Button.Button.litTagName} .variant=${Buttons.Button.Variant.PRIMARY} @click=${
         this.#handleTestProtocolClick}>
             ${i18nString(UIStrings.testProtocol)}

package/front_end/panels/elements/CSSRuleValidator.ts

@@ -0,0 +1,100 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as i18n from '../../core/i18n/i18n.js';
+
+const UIStrings = {
+  /**
+    *@description Hint for Align-content rule where element also has flex-wrap nowrap rule.
+    */
+  alignContentRuleOnNoWrapFlex: 'This element has flex-wrap: nowrap rule, therefore \'align-content\' has no effect.',
+  /**
+    *@description Hint for element that does not have effect if parent container is not flex.
+    *@example {flex} PH1
+    */
+  notFlexItemHint: 'Parent of this element is not flex container, therefore {PH1} property has no effect.',
+};
+const str_ = i18n.i18n.registerUIStrings('panels/elements/CSSRuleValidator.ts', UIStrings);
+const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+
+export abstract class CSSRuleValidator {
+  readonly #affectedProperties: string[];
+
+  constructor(affectedProperties: string[]) {
+    this.#affectedProperties = affectedProperties;
+  }
+
+  abstract isRuleValid(computedStyles: Map<String, String>|null, parentsComputedStyles?: Map<String, String>|null):
+      boolean;
+
+  getAffectedProperties(): string[] {
+    return this.#affectedProperties;
+  }
+
+  abstract getHintMessage(propertyName: string): string;
+}
+
+export class AlignContentValidator extends CSSRuleValidator {
+  constructor() {
+    super(['align-content']);
+  }
+
+  isRuleValid(computedStyles: Map<String, String>|null): boolean {
+    if (computedStyles === null || computedStyles === undefined) {
+      return true;
+    }
+    const display = computedStyles.get('display');
+    if (display !== 'flex' && display !== 'inline-flex') {
+      return true;
+    }
+    return computedStyles.get('flex-wrap') !== 'nowrap';
+  }
+
+  getHintMessage(): string {
+    return i18nString(UIStrings.alignContentRuleOnNoWrapFlex);
+  }
+}
+
+export class FlexItemValidator extends CSSRuleValidator {
+  constructor() {
+    super(['flex', 'flex-basis', 'flex-grow', 'flex-shrink']);
+  }
+
+  isRuleValid(computedStyles: Map<String, String>|null, parentsComputedStyles: Map<String, String>|null): boolean {
+    if (computedStyles === null || computedStyles === undefined || parentsComputedStyles === null ||
+        parentsComputedStyles === undefined) {
+      return true;
+    }
+    const parentDisplay = parentsComputedStyles.get('display');
+    return parentDisplay === 'flex' || parentDisplay === 'inline-flex';
+  }
+
+  getHintMessage(property: string): string {
+    return i18nString(UIStrings.notFlexItemHint, {
+      'PH1': property,
+    });
+  }
+}
+
+const setupCSSRulesValidators = (): Map<String, CSSRuleValidator[]> => {
+  const validators = [new AlignContentValidator(), new FlexItemValidator()];
+
+  const validatorsMap = new Map<String, CSSRuleValidator[]>();
+  for (const validator of validators) {
+    const affectedProperties = validator.getAffectedProperties();
+
+    for (const affectedProperty of affectedProperties) {
+      let propertyValidators = validatorsMap.get(affectedProperty);
+      if (propertyValidators === undefined) {
+        propertyValidators = [];
+      }
+      propertyValidators.push(validator);
+
+      validatorsMap.set(affectedProperty, propertyValidators);
+    }
+  }
+  return validatorsMap;
+};
+
+export const cssRuleValidatorsMap: Map<String, CSSRuleValidator[]> = setupCSSRulesValidators();

package/front_end/panels/elements/StylePropertiesSection.ts

@@ -121,6 +121,8 @@ export class StylePropertiesSection {
   protected parentPane: StylesSidebarPane;
   styleInternal: SDK.CSSStyleDeclaration.CSSStyleDeclaration;
   readonly matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles;
+  private computedStyles: Map<string, string>|null;
+  private parentsComputedStyles: Map<string, string>|null;
   editable: boolean;
   private hoverTimer: number|null;
   private willCauseCancelEditing: boolean;
@@ -152,11 +154,14 @@ export class StylePropertiesSection {
 
   constructor(
       parentPane: StylesSidebarPane, matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles,
-      style: SDK.CSSStyleDeclaration.CSSStyleDeclaration, sectionIdx: number) {
+      style: SDK.CSSStyleDeclaration.CSSStyleDeclaration, sectionIdx: number, computedStyles: Map<string, string>|null,
+      parentsComputedStyles: Map<string, string>|null) {
     this.parentPane = parentPane;
     this.sectionIdx = sectionIdx;
     this.styleInternal = style;
     this.matchedStyles = matchedStyles;
+    this.computedStyles = computedStyles;
+    this.parentsComputedStyles = parentsComputedStyles;
     this.editable = Boolean(style.styleSheetId && style.range);
     this.hoverTimer = null;
     this.willCauseCancelEditing = false;
@@ -932,6 +937,8 @@ export class StylePropertiesSection {
       }
       const item = new StylePropertyTreeElement(
           this.parentPane, this.matchedStyles, property, isShorthand, inherited, overloaded, false);
+      item.setComputedStyles(this.computedStyles);
+      item.setParentsComputedStyles(this.parentsComputedStyles);
       this.propertiesTreeOutline.appendChild(item);
     }
 
@@ -1449,7 +1456,7 @@ export class BlankStylePropertiesSection extends StylePropertiesSection {
       insertAfterStyle: SDK.CSSStyleDeclaration.CSSStyleDeclaration, sectionIdx: number) {
     const cssModel = (stylesPane.cssModel() as SDK.CSSModel.CSSModel);
     const rule = SDK.CSSRule.CSSStyleRule.createDummyRule(cssModel, defaultSelectorText);
-    super(stylesPane, matchedStyles, rule.style, sectionIdx);
+    super(stylesPane, matchedStyles, rule.style, sectionIdx, null, null);
     this.normal = false;
     this.ruleLocation = ruleLocation;
     this.styleSheetId = styleSheetId;
@@ -1553,7 +1560,7 @@ export class KeyframePropertiesSection extends StylePropertiesSection {
   constructor(
       stylesPane: StylesSidebarPane, matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles,
       style: SDK.CSSStyleDeclaration.CSSStyleDeclaration, sectionIdx: number) {
-    super(stylesPane, matchedStyles, style, sectionIdx);
+    super(stylesPane, matchedStyles, style, sectionIdx, null, null);
     this.selectorElement.className = 'keyframe-key';
   }
 

package/front_end/panels/elements/StylePropertyTreeElement.ts

@@ -21,6 +21,7 @@ import {StyleEditorWidget} from './StyleEditorWidget.js';
 import type {StylePropertiesSection} from './StylePropertiesSection.js';
 import {CSSPropertyPrompt, StylesSidebarPane, StylesSidebarPropertyRenderer} from './StylesSidebarPane.js';
 import {getCssDeclarationAsJavascriptProperty} from './StylePropertyUtils.js';
+import {cssRuleValidatorsMap} from './CSSRuleValidator.js';
 
 const FlexboxEditor = ElementsComponents.StylePropertyEditor.FlexboxEditor;
 const GridEditor = ElementsComponents.StylePropertyEditor.GridEditor;
@@ -120,6 +121,8 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
   private hasBeenEditedIncrementally: boolean;
   private prompt: CSSPropertyPrompt|null;
   private lastComputedValue: string|null;
+  private computedStyles: Map<string, string>|null = null;
+  private parentsComputedStyles: Map<string, string>|null = null;
   private contextForTest!: Context|undefined;
   #propertyTextFromSource: string;
 
@@ -179,6 +182,14 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
     this.updateState();
   }
 
+  setComputedStyles(computedStyles: Map<string, string>|null): void {
+    this.computedStyles = computedStyles;
+  }
+
+  setParentsComputedStyles(parentsComputedStyles: Map<string, string>|null): void {
+    this.parentsComputedStyles = parentsComputedStyles;
+  }
+
   get name(): string {
     return this.property.name;
   }
@@ -568,6 +579,8 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
       const item = new StylePropertyTreeElement(
           this.parentPaneInternal, this.matchedStylesInternal, longhandProperties[i], false, inherited, overloaded,
           false);
+      item.setComputedStyles(this.computedStyles);
+      item.setParentsComputedStyles(this.parentsComputedStyles);
       this.appendChild(item);
     }
   }
@@ -702,6 +715,17 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
       }
     }
 
+    const hintMessage = this.getHintMessage(this.computedStyles, this.parentsComputedStyles);
+    if (hintMessage !== null) {
+      const hintIcon = UI.Icon.Icon.create('mediumicon-info', 'hint');
+      const hintPopover =
+          new UI.PopoverHelper.PopoverHelper(hintIcon, event => this.handleHintPopoverRequest(hintMessage, event));
+      hintPopover.setHasPadding(true);
+      hintPopover.setTimeout(0, 100);
+
+      this.listItemElement.append(hintIcon);
+    }
+
     if (!this.property.parsedOk) {
       // Avoid having longhands under an invalid shorthand.
       this.listItemElement.classList.add('not-parsed-ok');
@@ -793,6 +817,41 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
         StylesSidebarPane.createExclamationMark(this.property, warnings.join(' ')), this.listItemElement.firstChild);
   }
 
+  private getHintMessage(computedStyles: Map<string, string>|null, parentComputedStyles: Map<string, string>|null):
+      string|null {
+    const propertyName = this.property.name;
+
+    if (!Root.Runtime.experiments.isEnabled(Root.Runtime.ExperimentName.CSS_AUTHORING_HINTS) ||
+        !cssRuleValidatorsMap.has(propertyName)) {
+      return null;
+    }
+
+    for (const validator of cssRuleValidatorsMap.get(propertyName) || []) {
+      if (!validator.isRuleValid(computedStyles, parentComputedStyles)) {
+        return validator.getHintMessage(propertyName);
+      }
+    }
+
+    return null;
+  }
+
+  private handleHintPopoverRequest(hintMessageContent: string, event: Event): UI.PopoverHelper.PopoverRequest|null {
+    const link = event.composedPath()[0];
+    Platform.DCHECK(() => link instanceof Element, 'Link is not an instance of Element');
+
+    return {
+      box: (link as Element).boxInWindow(),
+      show: async(popover: UI.GlassPane.GlassPane): Promise<boolean> => {
+        const node = this.node();
+        if (!node) {
+          return false;
+        }
+        popover.contentElement.insertAdjacentHTML('beforeend', hintMessageContent);
+        return true;
+      },
+    };
+  }
+
   private mouseUp(event: MouseEvent): void {
     const activeTreeElement = parentMap.get(this.parentPaneInternal);
     parentMap.delete(this.parentPaneInternal);

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -583,8 +583,16 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
       }, 200 /* only spin for loading time > 200ms to avoid unpleasant render flashes */);
     }
 
+    const node = this.node();
+    // TODO: Fetch the parent node id using CDP command
+    const parentNode = node ? node.parentNode : null;
+
+    const [computedStyles, parentsComputedStyles] =
+        await Promise.all([this.fetchComputedStylesFor(node), this.fetchComputedStylesFor(parentNode)]);
+
     const matchedStyles = await this.fetchMatchedCascade();
-    await this.innerRebuildUpdate(matchedStyles);
+
+    await this.innerRebuildUpdate(matchedStyles, computedStyles, parentsComputedStyles);
     if (!this.initialUpdateCompleted) {
       this.initialUpdateCompleted = true;
       this.appendToolbarItem(this.createRenderingShortcuts());
@@ -599,6 +607,13 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     this.dispatchEventToListeners(Events.StylesUpdateCompleted, {hasMatchedStyles: this.hasMatchedStyles});
   }
 
+  private async fetchComputedStylesFor(node: SDK.DOMModel.DOMNode|null): Promise<Map<string, string>|null> {
+    if (!node) {
+      return null;
+    }
+    return await node.domModel().cssModel().getComputedStyle(node.id);
+  }
+
   onResize(): void {
     void this.resizeThrottler.schedule(this.innerResize.bind(this));
   }
@@ -718,7 +733,9 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     }
   }
 
-  private async innerRebuildUpdate(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles|null): Promise<void> {
+  private async innerRebuildUpdate(
+      matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles|null, computedStyles: Map<string, string>|null,
+      parentsComputedStyles: Map<string, string>|null): Promise<void> {
     // ElementsSidebarPane's throttler schedules this method. Usually,
     // rebuild is suppressed while editing (see onCSSModelChanged()), but we need a
     // 'force' flag since the currently running throttler process cannot be canceled.
@@ -742,8 +759,8 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
       return;
     }
 
-    this.sectionBlocks =
-        await this.rebuildSectionsForMatchedStyleRules((matchedStyles as SDK.CSSMatchedStyles.CSSMatchedStyles));
+    this.sectionBlocks = await this.rebuildSectionsForMatchedStyleRules(
+        (matchedStyles as SDK.CSSMatchedStyles.CSSMatchedStyles), computedStyles, parentsComputedStyles);
 
     // Style sections maybe re-created when flexbox editor is activated.
     // With the following code we re-bind the flexbox editor to the new
@@ -814,8 +831,9 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     // For sniffing in tests.
   }
 
-  private async rebuildSectionsForMatchedStyleRules(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles):
-      Promise<SectionBlock[]> {
+  private async rebuildSectionsForMatchedStyleRules(
+      matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, computedStyles: Map<string, string>|null,
+      parentsComputedStyles: Map<string, string>|null): Promise<SectionBlock[]> {
     if (this.idleCallbackManager) {
       this.idleCallbackManager.discard();
     }
@@ -872,7 +890,8 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
       const lastBlock = blocks[blocks.length - 1];
       if (lastBlock) {
         this.idleCallbackManager.schedule(() => {
-          const section = new StylePropertiesSection(this, matchedStyles, style, sectionIdx);
+          const section =
+              new StylePropertiesSection(this, matchedStyles, style, sectionIdx, computedStyles, parentsComputedStyles);
           sectionIdx++;
           lastBlock.sections.push(section);
         });
@@ -941,7 +960,8 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
         addLayerSeparator(style);
         const lastBlock = blocks[blocks.length - 1];
         this.idleCallbackManager.schedule(() => {
-          const section = new HighlightPseudoStylePropertiesSection(this, matchedStyles, style, sectionIdx);
+          const section = new HighlightPseudoStylePropertiesSection(
+              this, matchedStyles, style, sectionIdx, computedStyles, parentsComputedStyles);
           sectionIdx++;
           lastBlock.sections.push(section);
         });

package/front_end/panels/elements/elements.ts

@@ -22,6 +22,7 @@ import './StylePropertyHighlighter.js';
 import './StylesSidebarPane.js';
 import './StylePropertyTreeElement.js';
 import './ComputedStyleWidget.js';
+import './CSSRuleValidator.js';
 import './ElementsPanel.js';
 import './ClassesPaneWidget.js';
 import './ElementStatePaneWidget.js';
@@ -32,6 +33,7 @@ import * as ClassesPaneWidget from './ClassesPaneWidget.js';
 import * as ColorSwatchPopoverIcon from './ColorSwatchPopoverIcon.js';
 import * as ComputedStyleModel from './ComputedStyleModel.js';
 import * as ComputedStyleWidget from './ComputedStyleWidget.js';
+import * as CSSRuleValidator from './CSSRuleValidator.js';
 import * as DOMLinkifier from './DOMLinkifier.js';
 import * as DOMPath from './DOMPath.js';
 import * as ElementsPanel from './ElementsPanel.js';
@@ -62,6 +64,7 @@ export {
   ColorSwatchPopoverIcon,
   ComputedStyleModel,
   ComputedStyleWidget,
+  CSSRuleValidator,
   DOMLinkifier,
   DOMPath,
   ElementsPanel,

package/front_end/panels/elements/stylesSectionTree.css

@@ -155,6 +155,16 @@ ol.expanded {
   transform: scale(0.9);
 }
 
+.hint {
+  position: absolute;
+  top: 0;
+  bottom: 0;
+  margin: auto;
+  display: inline-block;
+  cursor: pointer;
+  transform: scale(0.9);
+}
+
 .has-ignorable-error {
   color: var(--color-text-disabled);
 }

package/front_end/panels/media/eventDisplayTable.css

@@ -16,3 +16,7 @@
 .data-grid .event-display-table-basic-text-table-entry {
   line-height: 26px;
 }
+
+.event-display-table-contents-json-wrapper > .json-view {
+  overflow: visible;
+}

package/front_end/ui/components/panel_feedback/PreviewToggle.ts

@@ -67,11 +67,18 @@ export class PreviewToggle extends HTMLElement {
 
   #render(): void {
     const checked = Root.Runtime.experiments.isEnabled(this.#experiment);
+    const hasLink = Boolean(this.#feedbackURL) || Boolean(this.#learnMoreURL);
+
+    const containerClasses = LitHtml.Directives.classMap({
+      'container': true,
+      'has-link': hasLink,
+    });
+
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     render(
       html`
-      <div class="container">
+      <div class=${containerClasses}>
         <div class="checkbox-line">
           <label class="experiment-preview">
             <input type="checkbox" ?checked=${checked} @change=${this.#checkboxChanged} aria-label=${this.#name}/>

package/front_end/ui/components/panel_feedback/previewToggle.css

@@ -33,6 +33,12 @@
   padding: 4px;
 }
 
+.container.has-link {
+  /* For x-link outline not to paint over the helper text
+  we need to have 2 * <padding>px additional line height */
+  line-height: calc(1em + 8px);
+}
+
 .x-link {
   color: var(--color-primary);
   text-decoration-line: underline;

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1018017"
+  "version": "1.0.1019017"
 }