chrome-devtools-frontend 1.0.1017938 → 1.0.1018569

package/front_end/core/i18n/locales/en-US.json

@@ -3209,6 +3209,9 @@
   "panels/application/components/PermissionsPolicySection.ts | showDetails": {
     "message": "Show details"
   },
+  "panels/application/components/ProtocolHandlersView.ts | dropdownLabel": {
+    "message": "Select protocol handler"
+  },
   "panels/application/components/ProtocolHandlersView.ts | manifest": {
     "message": "manifest"
   },
@@ -3227,6 +3230,9 @@
   "panels/application/components/ProtocolHandlersView.ts | testProtocol": {
     "message": "Test protocol"
   },
+  "panels/application/components/ProtocolHandlersView.ts | textboxLabel": {
+    "message": "Query parameter or endpoint for protocol handler"
+  },
   "panels/application/components/ReportsGrid.ts | destination": {
     "message": "Destination"
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -3209,6 +3209,9 @@
   "panels/application/components/PermissionsPolicySection.ts | showDetails": {
     "message": "Ŝh́ôẃ d̂ét̂áîĺŝ"
   },
+  "panels/application/components/ProtocolHandlersView.ts | dropdownLabel": {
+    "message": "Ŝél̂éĉt́ p̂ŕôt́ôćôĺ ĥán̂d́l̂ér̂"
+  },
   "panels/application/components/ProtocolHandlersView.ts | manifest": {
     "message": "m̂án̂íf̂éŝt́"
   },
@@ -3227,6 +3230,9 @@
   "panels/application/components/ProtocolHandlersView.ts | testProtocol": {
     "message": "T̂éŝt́ p̂ŕôt́ôćôĺ"
   },
+  "panels/application/components/ProtocolHandlersView.ts | textboxLabel": {
+    "message": "Q̂úêŕŷ ṕâŕâḿêt́êŕ ôŕ êńd̂ṕôín̂t́ f̂ór̂ ṕr̂ót̂óĉól̂ h́âńd̂ĺêŕ"
+  },
   "panels/application/components/ReportsGrid.ts | destination": {
     "message": "D̂éŝt́îńât́îón̂"
   },

package/front_end/core/sdk/SourceMap.ts

@@ -451,11 +451,10 @@ export class TextSourceMap implements SourceMap {
       if (url === this.#compiledURLInternal && source) {
         url = Common.ParsedURL.ParsedURL.concatenate(url, '? [sm]');
       }
-      if (this.#sourceInfos.has(url)) {
-        continue;
-      }
-      this.#sourceInfos.set(url, new TextSourceMap.SourceInfo(source ?? null));
       sourcesList.push(url);
+      if (!this.#sourceInfos.has(url)) {
+        this.#sourceInfos.set(url, new TextSourceMap.SourceInfo(source ?? null));
+      }
     }
     sourceMapToSourceList.set(sourceMap, sourcesList);
   }

package/front_end/panels/application/DOMStorageModel.ts

@@ -319,12 +319,16 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
     }
   }
 
-  private storageKey(securityOrigin: string, storageKey: string, isLocalStorage: boolean): string {
+  private storageKey(securityOrigin: string|undefined, storageKey: string|undefined, isLocalStorage: boolean): string {
     // TODO(crbug.com/1313434) Prioritize storageKey once everything is ready
+    console.assert(Boolean(securityOrigin) || Boolean(storageKey));
     if (securityOrigin) {
       return JSON.stringify(DOMStorage.storageIdWithSecurityOrigin(securityOrigin, isLocalStorage));
     }
-    return JSON.stringify(DOMStorage.storageIdWithStorageKey(storageKey, isLocalStorage));
+    if (storageKey) {
+      return JSON.stringify(DOMStorage.storageIdWithStorageKey(storageKey, isLocalStorage));
+    }
+    throw new Error('Either securityOrigin or storageKey is required');
   }
 
   private keyForSecurityOrigin(securityOrigin: string, isLocalStorage: boolean): string {
@@ -375,7 +379,8 @@ export class DOMStorageModel extends SDK.SDKModel.SDKModel<EventTypes> {
   }
 
   storageForId(storageId: Protocol.DOMStorage.StorageId): DOMStorage {
-    return this.storagesInternal[JSON.stringify(storageId)];
+    return this
+        .storagesInternal[this.storageKey(storageId.securityOrigin, storageId.storageKey, storageId.isLocalStorage)];
   }
 
   storages(): DOMStorage[] {

package/front_end/panels/application/components/ProtocolHandlersView.ts

@@ -48,6 +48,14 @@ const UIStrings = {
  *@description Text for test protocol button
  */
   testProtocol: 'Test protocol',
+  /**
+  * @description Aria text for screen reader to announce they can select a protocol handler in the dropdown
+  */
+  dropdownLabel: 'Select protocol handler',
+  /**
+  * @description Aria text for screen reader to announce they can enter query parameters or endpoints into the textbox
+  */
+  textboxLabel: 'Query parameter or endpoint for protocol handler',
 };
 
 const str_ = i18n.i18n.registerUIStrings('panels/application/components/ProtocolHandlersView.ts', UIStrings);
@@ -121,11 +129,12 @@ export class ProtocolHandlersView extends HTMLElement {
                                 .map(p => LitHtml.html`<option value=${p.protocol}>${p.protocol}://</option>`);
     return LitHtml.html`
        <div class="protocol-handlers-row">
-        <select class="chrome-select protocol-select" @change=${this.#handleProtocolSelect}>
+        <select class="chrome-select protocol-select" @change=${this.#handleProtocolSelect} aria-label=${
+        i18nString(UIStrings.dropdownLabel)}>
            ${protocolOptions}
         </select>
         <input .value=${this.#queryInputState} class="devtools-text-input" type="text" @change=${
-        this.#handleQueryInputChange}/>
+        this.#handleQueryInputChange} aria-label=${i18nString(UIStrings.textboxLabel)}/>
         <${Buttons.Button.Button.litTagName} .variant=${Buttons.Button.Variant.PRIMARY} @click=${
         this.#handleTestProtocolClick}>
             ${i18nString(UIStrings.testProtocol)}

package/front_end/panels/media/eventDisplayTable.css

@@ -16,3 +16,7 @@
 .data-grid .event-display-table-basic-text-table-entry {
   line-height: 26px;
 }
+
+.event-display-table-contents-json-wrapper > .json-view {
+  overflow: visible;
+}

package/front_end/ui/components/panel_feedback/PreviewToggle.ts

@@ -67,11 +67,18 @@ export class PreviewToggle extends HTMLElement {
 
   #render(): void {
     const checked = Root.Runtime.experiments.isEnabled(this.#experiment);
+    const hasLink = Boolean(this.#feedbackURL) || Boolean(this.#learnMoreURL);
+
+    const containerClasses = LitHtml.Directives.classMap({
+      'container': true,
+      'has-link': hasLink,
+    });
+
     // Disabled until https://crbug.com/1079231 is fixed.
     // clang-format off
     render(
       html`
-      <div class="container">
+      <div class=${containerClasses}>
         <div class="checkbox-line">
           <label class="experiment-preview">
             <input type="checkbox" ?checked=${checked} @change=${this.#checkboxChanged} aria-label=${this.#name}/>

package/front_end/ui/components/panel_feedback/previewToggle.css

@@ -33,6 +33,12 @@
   padding: 4px;
 }
 
+.container.has-link {
+  /* For x-link outline not to paint over the helper text
+  we need to have 2 * <padding>px additional line height */
+  line-height: calc(1em + 8px);
+}
+
 .x-link {
   color: var(--color-primary);
   text-decoration-line: underline;

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1017938"
+  "version": "1.0.1018569"
 }