npm - chrome-devtools-frontend - Versions diffs - 1.0.1013875 → 1.0.1014346 - Mend

chrome-devtools-frontend 1.0.1013875 → 1.0.1014346

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (7) hide show

package/front_end/core/i18n/locales/en-US.json CHANGED Viewed

@@ -1412,6 +1412,9 @@
   "models/issues_manager/DeprecationIssue.ts | hostCandidateAttributeGetter": {
     "message": "RTCPeerConnectionIceErrorEvent.hostCandidate is deprecated. Please use RTCPeerConnectionIceErrorEvent.address or RTCPeerConnectionIceErrorEvent.port instead."
   },
+  "models/issues_manager/DeprecationIssue.ts | identityInCanMakePaymentEvent": {
+    "message": "The merchant origin and arbitrary data from the canmakepayment service worker event are deprecated and will be removed: topOrigin, paymentRequestOrigin, methodData, modifiers."
+  },
   "models/issues_manager/DeprecationIssue.ts | insecurePrivateNetworkSubresourceRequest": {
     "message": "The website requested a subresource from a network that it could only access because of its users' privileged network position. These requests expose non-public devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage. To mitigate these risks, Chrome deprecates requests to non-public subresources when initiated from non-secure contexts, and will start blocking them."
   },

package/front_end/core/i18n/locales/en-XL.json CHANGED Viewed

@@ -1412,6 +1412,9 @@
   "models/issues_manager/DeprecationIssue.ts | hostCandidateAttributeGetter": {
     "message": "RTCPeerConnectionIceErrorEvent.hostCandidate îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê RTCPeerConnectionIceErrorEvent.address ór̂ RTCPeerConnectionIceErrorEvent.port ín̂śt̂éâd́."
   },
+  "models/issues_manager/DeprecationIssue.ts | identityInCanMakePaymentEvent": {
+    "message": "T̂h́ê ḿêŕĉh́âńt̂ ór̂íĝín̂ án̂d́ âŕb̂ít̂ŕâŕŷ d́ât́â f́r̂óm̂ t́ĥé canmakepayment ŝér̂v́îćê ẃôŕk̂ér̂ év̂én̂t́ âŕê d́êṕr̂éĉát̂éd̂ án̂d́ ŵíl̂ĺ b̂é r̂ém̂óv̂éd̂: topOrigin, paymentRequestOrigin, methodData, modifiers."
+  },
   "models/issues_manager/DeprecationIssue.ts | insecurePrivateNetworkSubresourceRequest": {
     "message": "T̂h́ê ẃêb́ŝít̂é r̂éq̂úêśt̂éd̂ á ŝúb̂ŕêśôúr̂ćê f́r̂óm̂ á n̂ét̂ẃôŕk̂ t́ĥát̂ ít̂ ćôúl̂d́ ôńl̂ý âćĉéŝś b̂éĉáûśê óf̂ ít̂ś ûśêŕŝ' ṕr̂ív̂íl̂éĝéd̂ ńêt́ŵór̂ḱ p̂óŝít̂íôń. T̂h́êśê ŕêq́ûéŝt́ŝ éx̂ṕôśê ńôń-p̂úb̂ĺîć d̂év̂íĉéŝ án̂d́ ŝér̂v́êŕŝ t́ô t́ĥé îńt̂ér̂ńêt́, îńĉŕêáŝín̂ǵ t̂h́ê ŕîśk̂ óf̂ á ĉŕôśŝ-śît́ê ŕêq́ûéŝt́ f̂ór̂ǵêŕŷ (ĆŜŔF̂) át̂t́âćk̂, án̂d́/ôŕ îńf̂ór̂ḿât́îón̂ ĺêák̂áĝé. T̂ó m̂ít̂íĝát̂é t̂h́êśê ŕîśk̂ś, Ĉh́r̂óm̂é d̂ép̂ŕêćât́êś r̂éq̂úêśt̂ś t̂ó n̂ón̂-ṕûb́l̂íĉ śûb́r̂éŝóûŕĉéŝ ẃĥén̂ ín̂ít̂íât́êd́ f̂ŕôḿ n̂ón̂-śêćûŕê ćôńt̂éx̂t́ŝ, án̂d́ ŵíl̂ĺ ŝt́âŕt̂ b́l̂óĉḱîńĝ t́ĥém̂."
   },

package/front_end/models/issues_manager/DeprecationIssue.ts CHANGED Viewed

@@ -119,6 +119,12 @@ const UIStrings = {
    */
   hostCandidateAttributeGetter:
       '`RTCPeerConnectionIceErrorEvent.hostCandidate` is deprecated. Please use `RTCPeerConnectionIceErrorEvent.address` or `RTCPeerConnectionIceErrorEvent.port` instead.',
+  /**
+   * @description A deprecation warning shown in the DevTools Issues tab,
+   * when a service worker reads one of the fields from an event named
+   * "canmakepayment".
+   */
+  identityInCanMakePaymentEvent: 'The merchant origin and arbitrary data from the `canmakepayment` service worker event are deprecated and will be removed: `topOrigin`, `paymentRequestOrigin`, `methodData`, `modifiers`.',
   /**
    * @description TODO(crbug.com/1320343): Description needed for translation
    */
@@ -377,6 +383,10 @@ export class DeprecationIssue extends Issue {
       case Protocol.Audits.DeprecationIssueType.HostCandidateAttributeGetter:
         messageFunction = i18nLazyString(UIStrings.hostCandidateAttributeGetter);
         break;
+      case Protocol.Audits.DeprecationIssueType.IdentityInCanMakePaymentEvent:
+        messageFunction = i18nLazyString(UIStrings.identityInCanMakePaymentEvent);
+        feature = 5190978431352832;
+        break;
       case Protocol.Audits.DeprecationIssueType.InsecurePrivateNetworkSubresourceRequest:
         messageFunction = i18nLazyString(UIStrings.insecurePrivateNetworkSubresourceRequest);
         feature = 5436853517811712;

package/front_end/panels/lighthouse/LighthouseStartView.ts CHANGED Viewed

@@ -256,6 +256,7 @@ export class StartView extends UI.Widget.Widget {
   }
   wasShown(): void {
     super.wasShown();
+    this.controller.recomputePageAuditability();
     this.registerCSSFiles([lighthouseStartViewStyles]);
   }
 }

package/package.json CHANGED Viewed

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1013875"
+  "version": "1.0.1014346"
 }

package/scripts/eslint_rules/lib/check_component_naming.js CHANGED Viewed

@@ -19,6 +19,7 @@ module.exports = {
       noDefineCall: 'Could not find a defineComponent() call for the component {{ tagName }}.',
       defineCallNonLiteral: 'defineComponent() first argument must be a string literal.',
       staticLiteralInvalid: 'static readonly litTagName must use a literal string, with no interpolation.',
+      duplicateStaticLitTagName: 'found a duplicated litTagName: {{ tagName }}',
       litTagNameNotLiteral:
           'litTagName must be defined as a string passed in as LitHtml.literal`component-name`, but no tagged template was found.',
       staticLiteralNotReadonly: 'static litTagName must be readonly.'
@@ -90,8 +91,9 @@ module.exports = {
       });
     }
-    /** @type {Set<{classNode: any, tagName: string}>} */
-    const componentClassDefinitionLitTagNamesFound = new Set();
+    // Map of litTagName to the class node.
+    /** @type {Map<string, any}>} */
+    const componentClassDefinitionLitTagNameNodes = new Map();
     /** @type {Set<string>} */
     const defineComponentCallsFound = new Set();
@@ -147,8 +149,15 @@ module.exports = {
           // Grab the name of the component, e.g:
           // LitHtml.literal`devtools-foo` will pull "devtools-foo" out.
           const componentTagName = componentTagNameNode.value.quasi.quasis[0].value.cooked;
-          componentClassDefinitionLitTagNamesFound.add(
-              {tagName: componentTagName, classNode: componentClassDefinition});
+          // Now we ensure that we haven't found this tag name before. If we
+          // have, we have two components with the same litTagName property,
+          // which is an error.
+          if (componentClassDefinitionLitTagNameNodes.has(componentTagName)) {
+            context.report({node: componentClassDefinition, messageId: 'duplicateStaticLitTagName', data: {tagName: componentTagName}});
+          }
+          componentClassDefinitionLitTagNameNodes.set(componentTagName, componentClassDefinition);
         }
         // Find all defineComponent() calls and store the arguments to them.
@@ -177,8 +186,7 @@ module.exports = {
           }
         }
-        for (const foundComponentClass of componentClassDefinitionLitTagNamesFound) {
-          const {tagName, classNode} = foundComponentClass;
+        for (const [tagName, classNode] of componentClassDefinitionLitTagNameNodes) {
           // Check that each tagName has a matching entry in both other places we expect it.
           if (!defineComponentCallsFound.has(tagName)) {
             context.report({node: classNode, messageId: 'noDefineCall', data: {tagName}});

package/scripts/eslint_rules/tests/check_component_naming_test.js CHANGED Viewed

@@ -233,5 +233,28 @@ ruleTester.run('check_component_naming', rule, {
       filename: 'front_end/ui/components/Foo.ts',
       errors: [{messageId: 'noDefineCall', data: {tagName: 'devtools-bar'}}]
     },
+    {
+      // Multiple components in one file is valid.
+      // But here devtools-foo is fine, but devtools-bar has the wrong static tag name
+      code: `export class Foo extends HTMLElement {
+        static readonly litTagName = LitHtml.literal\`devtools-foo\`
+      }
+      export class Bar extends HTMLElement {
+        static readonly litTagName = LitHtml.literal\`devtools-foo\`
+      }
+      ComponentHelpers.CustomElements.defineComponent('devtools-foo', Foo);
+      ComponentHelpers.CustomElements.defineComponent('devtools-bar', Foo);
+      declare global {
+        interface HTMLElementTagNameMap {
+          'devtools-foo': Foo
+          'devtools-bar': Bar
+        }
+      }`,
+      filename: 'front_end/ui/components/Foo.ts',
+      errors: [{messageId: 'duplicateStaticLitTagName', data: {tagName: 'devtools-foo'}}]
+    },
   ]
 });