npm - chrome-devtools-frontend - Versions diffs - 1.0.1013367 → 1.0.1014853 - Mend

chrome-devtools-frontend 1.0.1013367 → 1.0.1014853

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (23) hide show

package/.eslintignore +1 -0
package/docs/workflows.md +28 -0
package/front_end/core/i18n/locales/en-US.json +7 -1
package/front_end/core/i18n/locales/en-XL.json +7 -1
package/front_end/core/sdk/SourceMap.ts +88 -27
package/front_end/models/issues_manager/DeprecationIssue.ts +24 -2
package/front_end/models/javascript_metadata/DOMPinnedProperties.ts +4243 -0
package/front_end/models/source_map_scopes/NamesResolver.ts +134 -36
package/front_end/models/workspace/UISourceCode.ts +1 -1
package/front_end/panels/lighthouse/LighthouseStartView.ts +1 -0
package/front_end/panels/sources/TabbedEditorContainer.ts +16 -4
package/front_end/ui/components/linear_memory_inspector/ValueInterpreterDisplay.ts +6 -6
package/front_end/ui/components/linear_memory_inspector/valueInterpreterDisplay.css +8 -0
package/package.json +1 -1
package/scripts/devtools_paths.js +1 -1
package/scripts/eslint_rules/lib/check_component_naming.js +14 -6
package/scripts/eslint_rules/tests/check_component_naming_test.js +23 -0
package/scripts/webidl-properties/config.js +345 -0
package/scripts/webidl-properties/get-props.js +150 -0
package/scripts/webidl-properties/index.js +90 -0
package/scripts/webidl-properties/package.json +9 -0
package/scripts/webidl-properties/tests.js +162 -0
package/scripts/webidl-properties/util.js +81 -0

package/.eslintignore CHANGED Viewed

@@ -7,6 +7,7 @@ front_end/.eslintrc.js
 front_end/diff/diff_match_patch.js
 front_end/generated/protocol.ts
 front_end/javascript_metadata/NativeFunctions.js
+front_end/javascript_metadata/DOMPinnedProperties.ts
 front_end/third_party/
 node_modules
 scripts/migration/**/*.js

package/docs/workflows.md CHANGED Viewed

@@ -246,6 +246,34 @@ third_party/blink/tools/run_web_tests.py -t Default http/tests/devtools
 Usual [steps](https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#creating-a-change) for creating a change work out of the box, when executed in the DevTools frontend repository.
+Tips to create meaningful CL descriptions:
+- Provide information on what was changed and why
+- Provide before/after screenshots (if applicable)
+- Provide relevant link to demo or example (if applicable)
+- Provide link to design doc (if applicable)
+Example CL, adapted from [Chromium guidelines](https://chromium.googlesource.com/chromium/src/+/main/docs/contributing.md#uploading-a-change-for-review):
+```
+Summary of change (one line)
+Longer description of change addressing as appropriate:
+what change was made, why the change is made, context if
+it is part of many changes, description of previous behavior
+and newly introduced differences, etc.
+Long lines should be wrapped to 72 columns for easier log message
+viewing in terminals.
+How to test:
+  1. ..
+  2. ..
+Before:  https://page-to-before-screenshot.com/before
+After:  https://page-to-after-screenshot.com/after
+Bug: 123456
+```
 ## Managing dependencies
 - To sync dependencies from Chromium to DevTools frontend, use `scripts/deps/roll_deps.py && npm run generate-protocol-resources`.

package/front_end/core/i18n/locales/en-US.json CHANGED Viewed

@@ -1412,6 +1412,9 @@
   "models/issues_manager/DeprecationIssue.ts | hostCandidateAttributeGetter": {
     "message": "RTCPeerConnectionIceErrorEvent.hostCandidate is deprecated. Please use RTCPeerConnectionIceErrorEvent.address or RTCPeerConnectionIceErrorEvent.port instead."
   },
+  "models/issues_manager/DeprecationIssue.ts | identityInCanMakePaymentEvent": {
+    "message": "The merchant origin and arbitrary data from the canmakepayment service worker event are deprecated and will be removed: topOrigin, paymentRequestOrigin, methodData, modifiers."
+  },
   "models/issues_manager/DeprecationIssue.ts | insecurePrivateNetworkSubresourceRequest": {
     "message": "The website requested a subresource from a network that it could only access because of its users' privileged network position. These requests expose non-public devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage. To mitigate these risks, Chrome deprecates requests to non-public subresources when initiated from non-secure contexts, and will start blocking them."
   },
@@ -1442,11 +1445,14 @@
   "models/issues_manager/DeprecationIssue.ts | obsoleteWebRtcCipherSuite": {
     "message": "Your partner is negotiating an obsolete (D)TLS version. Please check with your partner to have this fixed."
   },
+  "models/issues_manager/DeprecationIssue.ts | openWebDatabaseInsecureContext": {
+    "message": "WebSQL in non-secure contexts is deprecated and will be removed in M107. Please use Web Storage or Indexed Database."
+  },
   "models/issues_manager/DeprecationIssue.ts | pictureSourceSrc": {
     "message": "<source src> with a <picture> parent is invalid and therefore ignored. Please use <source srcset> instead."
   },
   "models/issues_manager/DeprecationIssue.ts | prefixedStorageInfo": {
-    "message": "window.webkitStorageInfo is deprecated. Please use navigator.webkitTemporaryStorage or navigator.webkitPersistentStorage instead."
+    "message": "window.webkitStorageInfo is deprecated. Please use standardized navigator.storage instead."
   },
   "models/issues_manager/DeprecationIssue.ts | requestedSubresourceWithEmbeddedCredentials": {
     "message": "Subresource requests whose URLs contain embedded credentials (e.g. https://user:pass@host/) are blocked."

package/front_end/core/i18n/locales/en-XL.json CHANGED Viewed

@@ -1412,6 +1412,9 @@
   "models/issues_manager/DeprecationIssue.ts | hostCandidateAttributeGetter": {
     "message": "RTCPeerConnectionIceErrorEvent.hostCandidate îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê RTCPeerConnectionIceErrorEvent.address ór̂ RTCPeerConnectionIceErrorEvent.port ín̂śt̂éâd́."
   },
+  "models/issues_manager/DeprecationIssue.ts | identityInCanMakePaymentEvent": {
+    "message": "T̂h́ê ḿêŕĉh́âńt̂ ór̂íĝín̂ án̂d́ âŕb̂ít̂ŕâŕŷ d́ât́â f́r̂óm̂ t́ĥé canmakepayment ŝér̂v́îćê ẃôŕk̂ér̂ év̂én̂t́ âŕê d́êṕr̂éĉát̂éd̂ án̂d́ ŵíl̂ĺ b̂é r̂ém̂óv̂éd̂: topOrigin, paymentRequestOrigin, methodData, modifiers."
+  },
   "models/issues_manager/DeprecationIssue.ts | insecurePrivateNetworkSubresourceRequest": {
     "message": "T̂h́ê ẃêb́ŝít̂é r̂éq̂úêśt̂éd̂ á ŝúb̂ŕêśôúr̂ćê f́r̂óm̂ á n̂ét̂ẃôŕk̂ t́ĥát̂ ít̂ ćôúl̂d́ ôńl̂ý âćĉéŝś b̂éĉáûśê óf̂ ít̂ś ûśêŕŝ' ṕr̂ív̂íl̂éĝéd̂ ńêt́ŵór̂ḱ p̂óŝít̂íôń. T̂h́êśê ŕêq́ûéŝt́ŝ éx̂ṕôśê ńôń-p̂úb̂ĺîć d̂év̂íĉéŝ án̂d́ ŝér̂v́êŕŝ t́ô t́ĥé îńt̂ér̂ńêt́, îńĉŕêáŝín̂ǵ t̂h́ê ŕîśk̂ óf̂ á ĉŕôśŝ-śît́ê ŕêq́ûéŝt́ f̂ór̂ǵêŕŷ (ĆŜŔF̂) át̂t́âćk̂, án̂d́/ôŕ îńf̂ór̂ḿât́îón̂ ĺêák̂áĝé. T̂ó m̂ít̂íĝát̂é t̂h́êśê ŕîśk̂ś, Ĉh́r̂óm̂é d̂ép̂ŕêćât́êś r̂éq̂úêśt̂ś t̂ó n̂ón̂-ṕûb́l̂íĉ śûb́r̂éŝóûŕĉéŝ ẃĥén̂ ín̂ít̂íât́êd́ f̂ŕôḿ n̂ón̂-śêćûŕê ćôńt̂éx̂t́ŝ, án̂d́ ŵíl̂ĺ ŝt́âŕt̂ b́l̂óĉḱîńĝ t́ĥém̂."
   },
@@ -1442,11 +1445,14 @@
   "models/issues_manager/DeprecationIssue.ts | obsoleteWebRtcCipherSuite": {
     "message": "Ŷóûŕ p̂ár̂t́n̂ér̂ íŝ ńêǵôt́îát̂ín̂ǵ âń ôb́ŝól̂ét̂é (D̂)T́L̂Ś v̂ér̂śîón̂. Ṕl̂éâśê ćĥéĉḱ ŵít̂h́ ŷóûŕ p̂ár̂t́n̂ér̂ t́ô h́âv́ê t́ĥíŝ f́îx́êd́."
   },
+  "models/issues_manager/DeprecationIssue.ts | openWebDatabaseInsecureContext": {
+    "message": "Ŵéb̂ŚQ̂Ĺ îń n̂ón̂-śêćûŕê ćôńt̂éx̂t́ŝ íŝ d́êṕr̂éĉát̂éd̂ án̂d́ ŵíl̂ĺ b̂é r̂ém̂óv̂éd̂ ín̂ Ḿ107. P̂ĺêáŝé ûśê Ẃêb́ Ŝt́ôŕâǵê ór̂ Ín̂d́êx́êd́ D̂át̂áb̂áŝé."
+  },
   "models/issues_manager/DeprecationIssue.ts | pictureSourceSrc": {
     "message": "<source src> ŵít̂h́ â <picture> ṕâŕêńt̂ íŝ ín̂v́âĺîd́ âńd̂ t́ĥér̂éf̂ór̂é îǵn̂ór̂éd̂. Ṕl̂éâśê úŝé <source srcset> îńŝt́êád̂."
   },
   "models/issues_manager/DeprecationIssue.ts | prefixedStorageInfo": {
-    "message": "window.webkitStorageInfo îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê navigator.webkitTemporaryStorage ór̂ navigator.webkitPersistentStorage ín̂śt̂éâd́."
+    "message": "window.webkitStorageInfo îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê śt̂án̂d́âŕd̂íẑéd̂ navigator.storage ín̂śt̂éâd́."
   },
   "models/issues_manager/DeprecationIssue.ts | requestedSubresourceWithEmbeddedCredentials": {
     "message": "Ŝúb̂ŕêśôúr̂ćê ŕêq́ûéŝt́ŝ ẃĥóŝé ÛŔL̂ś ĉón̂t́âín̂ ém̂b́êd́d̂éd̂ ćr̂éd̂én̂t́îál̂ś (ê.ǵ. https://user:pass@host/) âŕê b́l̂óĉḱêd́."

package/front_end/core/sdk/SourceMap.ts CHANGED Viewed

@@ -66,6 +66,11 @@ export interface SourceMap {
       TextUtils.ContentProvider.ContentProvider;
   embeddedContentByURL(sourceURL: Platform.DevToolsPath.UrlString): string|null;
   findEntry(lineNumber: number, columnNumber: number): SourceMapEntry|null;
+  findEntryRanges(lineNumber: number, columnNumber: number): {
+    range: TextUtils.TextRange.TextRange,
+    sourceRange: TextUtils.TextRange.TextRange,
+    sourceURL: Platform.DevToolsPath.UrlString,
+  }|null;
   findReverseRanges(sourceURL: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber: number):
       TextUtils.TextRange.TextRange[];
   sourceLineMapping(sourceURL: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber: number):
@@ -233,6 +238,52 @@ export class TextSourceMap implements SourceMap {
     return index ? mappings[index - 1] : null;
   }
+  findEntryRanges(lineNumber: number, columnNumber: number): {
+    range: TextUtils.TextRange.TextRange,
+    sourceRange: TextUtils.TextRange.TextRange,
+    sourceURL: Platform.DevToolsPath.UrlString,
+  }|null {
+    const mappings = this.mappings();
+    const index = Platform.ArrayUtilities.upperBound(
+        mappings, undefined, (unused, entry) => lineNumber - entry.lineNumber || columnNumber - entry.columnNumber);
+    if (!index) {
+      // If the line and column are preceding all the entries, then there is nothing to map.
+      return null;
+    }
+    const sourceURL = mappings[index].sourceURL;
+    if (!sourceURL) {
+      return null;
+    }
+    // Let us compute the range that contains the source position in the compiled code.
+    const endLine = index < mappings.length ? mappings[index].lineNumber : 2 ** 31 - 1;
+    const endColumn = index < mappings.length ? mappings[index].columnNumber : 2 ** 31 - 1;
+    const range = new TextUtils.TextRange.TextRange(
+        mappings[index - 1].lineNumber, mappings[index - 1].columnNumber, endLine, endColumn);
+    // Now try to find the corresponding token in the original code.
+    const reverseMappings = this.reversedMappings(sourceURL);
+    const startSourceLine = mappings[index - 1].sourceLineNumber;
+    const startSourceColumn = mappings[index - 1].sourceColumnNumber;
+    const endReverseIndex = Platform.ArrayUtilities.upperBound(
+        reverseMappings, undefined,
+        (unused, i) =>
+            startSourceLine - mappings[i].sourceLineNumber || startSourceColumn - mappings[i].sourceColumnNumber);
+    if (!endReverseIndex) {
+      return null;
+    }
+    const endSourceLine = endReverseIndex < reverseMappings.length ?
+        mappings[reverseMappings[endReverseIndex]].sourceLineNumber :
+        2 ** 31 - 1;
+    const endSourceColumn = endReverseIndex < reverseMappings.length ?
+        mappings[reverseMappings[endReverseIndex]].sourceColumnNumber :
+        2 ** 31 - 1;
+    const sourceRange =
+        new TextUtils.TextRange.TextRange(startSourceLine, startSourceColumn, endSourceLine, endSourceColumn);
+    return {range, sourceRange, sourceURL};
+  }
   sourceLineMapping(sourceURL: Platform.DevToolsPath.UrlString, lineNumber: number, columnNumber: number):
       SourceMapEntry|null {
     const mappings = this.mappings();
@@ -315,42 +366,53 @@ export class TextSourceMap implements SourceMap {
   }
   mappings(): SourceMapEntry[] {
+    this.#ensureMappingsProcessed();
+    return this.#mappingsInternal ?? [];
+  }
+  private reversedMappings(sourceURL: Platform.DevToolsPath.UrlString): number[] {
+    this.#ensureMappingsProcessed();
+    return this.#sourceInfos.get(sourceURL)?.reverseMappings ?? [];
+  }
+  #ensureMappingsProcessed(): void {
     if (this.#mappingsInternal === null) {
       this.#mappingsInternal = [];
       this.eachSection(this.parseMap.bind(this));
+      this.#computeReverseMappings(this.#mappingsInternal);
       this.#json = null;
     }
-    return this.#mappingsInternal;
   }
-  private reversedMappings(sourceURL: Platform.DevToolsPath.UrlString): number[] {
-    const info = this.#sourceInfos.get(sourceURL);
-    if (!info) {
-      return [];
-    }
-    const mappings = this.mappings();
-    if (info.reverseMappings === null) {
-      const indexes = Array(mappings.length).fill(0).map((_, i) => i);
-      info.reverseMappings = indexes.filter(i => mappings[i].sourceURL === sourceURL).sort(sourceMappingComparator);
+  #computeReverseMappings(mappings: SourceMapEntry[]): void {
+    const reverseMappingsPerUrl = new Map<Platform.DevToolsPath.UrlString, number[]>();
+    for (let i = 0; i < mappings.length; i++) {
+      const entryUrl = mappings[i].sourceURL;
+      if (!entryUrl) {
+        continue;
+      }
+      let reverseMap = reverseMappingsPerUrl.get(entryUrl);
+      if (!reverseMap) {
+        reverseMap = [];
+        reverseMappingsPerUrl.set(entryUrl, reverseMap);
+      }
+      reverseMap.push(i);
     }
-    return info.reverseMappings;
+    for (const [url, reverseMap] of reverseMappingsPerUrl.entries()) {
+      const info = this.#sourceInfos.get(url);
+      if (!info) {
+        continue;
+      }
+      reverseMap.sort(sourceMappingComparator);
+      info.reverseMappings = reverseMap;
+    }
     function sourceMappingComparator(indexA: number, indexB: number): number {
       const a = mappings[indexA];
       const b = mappings[indexB];
-      if (a.sourceLineNumber !== b.sourceLineNumber) {
-        return a.sourceLineNumber - b.sourceLineNumber;
-      }
-      if (a.sourceColumnNumber !== b.sourceColumnNumber) {
-        return a.sourceColumnNumber - b.sourceColumnNumber;
-      }
-      if (a.lineNumber !== b.lineNumber) {
-        return a.lineNumber - b.lineNumber;
-      }
-      return a.columnNumber - b.columnNumber;
+      return a.sourceLineNumber - b.sourceLineNumber || a.sourceColumnNumber - b.sourceColumnNumber ||
+          a.lineNumber - b.lineNumber || a.columnNumber - b.columnNumber;
     }
   }
@@ -392,7 +454,7 @@ export class TextSourceMap implements SourceMap {
       if (this.#sourceInfos.has(url)) {
         continue;
       }
-      this.#sourceInfos.set(url, new TextSourceMap.SourceInfo(source || null, null));
+      this.#sourceInfos.set(url, new TextSourceMap.SourceInfo(source ?? null));
       sourcesList.push(url);
     }
     sourceMapToSourceList.set(sourceMap, sourcesList);
@@ -560,11 +622,10 @@ export namespace TextSourceMap {
   export class SourceInfo {
     content: string|null;
-    reverseMappings: number[]|null;
+    reverseMappings: number[]|null = null;
-    constructor(content: string|null, reverseMappings: number[]|null) {
+    constructor(content: string|null) {
       this.content = content;
-      this.reverseMappings = reverseMappings;
     }
   }
 }

package/front_end/models/issues_manager/DeprecationIssue.ts CHANGED Viewed

@@ -77,7 +77,9 @@ const UIStrings = {
    */
   crossOriginWindowApi: 'Triggering {PH1} from cross origin iframes has been deprecated and will be removed in the future.',
   /**
-   * @description TODO(crbug.com/1320339): Description needed for translation
+   * @description Warning displayed to developers when they hide the Cast button
+   * on a video element using the deprecated CSS selector instead of using the
+   * disableRemotePlayback attribute on the element.
    */
   cssSelectorInternalMediaControlsOverlayCastButton:
       'The `disableRemotePlayback` attribute should be used in order to disable the default Cast integration instead of using `-internal-media-controls-overlay-cast-button` selector.',
@@ -117,6 +119,12 @@ const UIStrings = {
    */
   hostCandidateAttributeGetter:
       '`RTCPeerConnectionIceErrorEvent.hostCandidate` is deprecated. Please use `RTCPeerConnectionIceErrorEvent.address` or `RTCPeerConnectionIceErrorEvent.port` instead.',
+  /**
+   * @description A deprecation warning shown in the DevTools Issues tab,
+   * when a service worker reads one of the fields from an event named
+   * "canmakepayment".
+   */
+  identityInCanMakePaymentEvent: 'The merchant origin and arbitrary data from the `canmakepayment` service worker event are deprecated and will be removed: `topOrigin`, `paymentRequestOrigin`, `methodData`, `modifiers`.',
   /**
    * @description TODO(crbug.com/1320343): Description needed for translation
    */
@@ -164,6 +172,11 @@ const UIStrings = {
    */
   obsoleteWebRtcCipherSuite:
       'Your partner is negotiating an obsolete (D)TLS version. Please check with your partner to have this fixed.',
+  /**
+   * @description Warning displayed to developers when `window.openDatabase` is used in non-secure contexts to notify that the API is deprecated and will be removed.
+   */
+  openWebDatabaseInsecureContext:
+      'WebSQL in non-secure contexts is deprecated and will be removed in M107. Please use Web Storage or Indexed Database.',
   /**
    * @description This issue indicates that a `<source>` element with a `<picture>` parent was using an `src` attribute, which is not valid and is ignored by the browser. The `srcset` attribute should be used instead.
    */
@@ -180,7 +193,7 @@ const UIStrings = {
    * @description Warning displayed to developers when `window.webkitStorageInfo` is used to notify that the API is deprecated.
    */
   prefixedStorageInfo:
-      '`window.webkitStorageInfo` is deprecated. Please use `navigator.webkitTemporaryStorage` or `navigator.webkitPersistentStorage` instead.',
+      '`window.webkitStorageInfo` is deprecated. Please use standardized `navigator.storage` instead.',
   /**
    * @description Standard message when one web API is deprecated in favor of another. Both
    * placeholders are always web API functions.
@@ -370,6 +383,10 @@ export class DeprecationIssue extends Issue {
       case Protocol.Audits.DeprecationIssueType.HostCandidateAttributeGetter:
         messageFunction = i18nLazyString(UIStrings.hostCandidateAttributeGetter);
         break;
+      case Protocol.Audits.DeprecationIssueType.IdentityInCanMakePaymentEvent:
+        messageFunction = i18nLazyString(UIStrings.identityInCanMakePaymentEvent);
+        feature = 5190978431352832;
+        break;
       case Protocol.Audits.DeprecationIssueType.InsecurePrivateNetworkSubresourceRequest:
         messageFunction = i18nLazyString(UIStrings.insecurePrivateNetworkSubresourceRequest);
         feature = 5436853517811712;
@@ -407,6 +424,11 @@ export class DeprecationIssue extends Issue {
         messageFunction = i18nLazyString(UIStrings.obsoleteWebRtcCipherSuite);
         milestone = 81;
         break;
+      case Protocol.Audits.DeprecationIssueType.OpenWebDatabaseInsecureContext:
+        messageFunction = i18nLazyString(UIStrings.openWebDatabaseInsecureContext);
+        feature = 5175124599767040;
+        milestone = 105;
+        break;
       case Protocol.Audits.DeprecationIssueType.PictureSourceSrc:
         messageFunction = i18nLazyString(UIStrings.pictureSourceSrc);
         break;