chrome-devtools-frontend 1.0.1002543 → 1.0.1003496

package/front_end/ui/components/text_editor/javascript.ts

@@ -216,8 +216,8 @@ export async function javascriptCompletionSource(cx: CodeMirror.CompletionContex
   };
 }
 
-const SPAN_IDENT = /^#?[\w\P{ASCII}]*$/u, SPAN_SINGLE_QUOTE = /^\'(\\.|[^\\'\n])*'?$/,
-      SPAN_DOUBLE_QUOTE = /^"(\\.|[^\\"\n])*"?$/;
+const SPAN_IDENT = /^#?(?:[$_\p{ID_Start}])(?:[$_\u200C\u200D\p{ID_Continue}])*$/u,
+      SPAN_SINGLE_QUOTE = /^\'(\\.|[^\\'\n])*'?$/, SPAN_DOUBLE_QUOTE = /^"(\\.|[^\\"\n])*"?$/;
 
 function getExecutionContext(): SDK.RuntimeModel.ExecutionContext|null {
   return UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
@@ -340,8 +340,6 @@ async function completeProperties(
   return result;
 }
 
-const prototypePropertyPenalty = -80;
-
 async function completePropertiesInner(
     expression: string,
     context: SDK.RuntimeModel.ExecutionContext,
@@ -382,17 +380,10 @@ async function completePropertiesInner(
           (!prop.private || expression === 'this') && (quoted || SPAN_IDENT.test(prop.name))) {
         const label =
             quoted ? quoted + prop.name.replaceAll('\\', '\\\\').replaceAll(quoted, '\\' + quoted) + quoted : prop.name;
-        const completion: CodeMirror.Completion = {
-          label,
-          type: prop.value?.type === 'function' ? functionType : otherType,
-        };
-        if (quoted && !hasBracket) {
-          completion.apply = label + ']';
-        }
-        if (!prop.isOwn) {
-          completion.boost = prototypePropertyPenalty;
-        }
-        result.add(completion);
+        const apply = (quoted && !hasBracket) ? `${label}]` : undefined;
+        const boost = 2 * Number(prop.isOwn) + 1 * Number(prop.enumerable);
+        const type = prop.value?.type === 'function' ? functionType : otherType;
+        result.add({apply, label, type, boost});
       }
     }
   }

package/front_end/ui/legacy/InspectorView.ts

@@ -115,6 +115,15 @@ const UIStrings = {
   *@description The aria label for the drawer hidden.
   */
   drawerHidden: 'Drawer hidden',
+  /**
+  * @description Request for the user to select a local file system folder for DevTools
+  * to store local overrides in.
+  */
+  selectOverrideFolder: 'Select a folder to store override files in.',
+  /**
+  *@description Label for a button which opens a file picker.
+  */
+  selectFolder: 'Select folder',
 };
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/InspectorView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -133,6 +142,7 @@ export class InspectorView extends VBox implements ViewLocationResolver {
   private focusRestorer?: WidgetFocusRestorer|null;
   private ownerSplitWidget?: SplitWidget;
   private reloadRequiredInfobar?: Infobar;
+  #selectOverrideFolderInfobar?: Infobar;
 
   constructor() {
     super();
@@ -439,6 +449,25 @@ export class InspectorView extends VBox implements ViewLocationResolver {
     }
   }
 
+  displaySelectOverrideFolderInfobar(callback: () => void): void {
+    if (!this.#selectOverrideFolderInfobar) {
+      const infobar = new Infobar(InfobarType.Info, i18nString(UIStrings.selectOverrideFolder), [
+        {
+          text: i18nString(UIStrings.selectFolder),
+          highlight: true,
+          delegate: (): void => callback(),
+          dismiss: true,
+        },
+      ]);
+      infobar.setParentView(this);
+      this.attachInfobar(infobar);
+      this.#selectOverrideFolderInfobar = infobar;
+      infobar.setCloseCallback(() => {
+        this.#selectOverrideFolderInfobar = undefined;
+      });
+    }
+  }
+
   private createInfoBarDiv(): void {
     if (!this.infoBarDiv) {
       this.infoBarDiv = document.createElement('div');

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1002543"
+  "version": "1.0.1003496"
 }

package/scripts/whitespaces.txt

@@ -9,3 +9,4 @@ Surma was here.
 .
 Today's answer to life the universe and everything is 161!
 No good text, but numbers ... 2!
+.