chrome-devtools-frontend 1.0.1001476 → 1.0.1003469

package/front_end/entrypoints/formatter_worker/Substitute.ts

@@ -5,6 +5,8 @@
 import * as Acorn from '../../third_party/acorn/acorn.js';
 
 import {ECMA_VERSION} from './AcornTokenizer.js';
+import {DefinitionKind} from './FormatterActions.js';
+import {ScopeVariableAnalysis} from './ScopeParser.js';
 
 export function substituteExpression(expression: string, nameMap: Map<string, string>): string {
   const replacements = computeSubstitution(expression, nameMap);
@@ -26,8 +28,8 @@ function computeSubstitution(expression: string, nameMap: Map<string, string>):
   // Parse the expression and find variables and scopes.
   const root = Acorn.parse(expression, {ecmaVersion: ECMA_VERSION, allowAwaitOutsideFunction: true, ranges: false}) as
       Acorn.ESTree.Node;
-  const scopeVariables = new ScopeVariableAnalysis();
-  scopeVariables.processNode(root);
+  const scopeVariables = new ScopeVariableAnalysis(root);
+  scopeVariables.run();
   const freeVariables = scopeVariables.getFreeVariables();
   const result: Replacement[] = [];
 
@@ -101,441 +103,3 @@ function applySubstitution(expression: string, replacements: Replacement[]): str
   accumulator.push(expression.slice(last));
   return accumulator.join('');
 }
-
-interface Use {
-  offset: number;
-  scope: Scope;
-  isShorthandAssignmentProperty: boolean;
-}
-
-const enum DefinitionKind {
-  None = 0,
-  Let = 1,
-  Var = 2,
-  Fixed = 3,
-}
-
-interface VariableUses {
-  definitionKind: DefinitionKind;
-  uses: Use[];
-}
-
-class Scope {
-  readonly variables = new Map<string, VariableUses>();
-  readonly parent: Scope|null;
-
-  constructor(parent: Scope|null) {
-    this.parent = parent;
-  }
-
-  addVariable(name: string, offset: number, definitionKind: DefinitionKind, isShorthandAssignmentProperty: boolean):
-      void {
-    const variable = this.variables.get(name);
-    const use = {offset, scope: this, isShorthandAssignmentProperty};
-    if (!variable) {
-      this.variables.set(name, {definitionKind, uses: [use]});
-      return;
-    }
-    if (variable.definitionKind === DefinitionKind.None) {
-      variable.definitionKind = definitionKind;
-    }
-    variable.uses.push(use);
-  }
-
-  findBinders(name: string): VariableUses[] {
-    const result = [];
-    let scope: Scope|null = this;
-    while (scope !== null) {
-      const defUse = scope.variables.get(name);
-      if (defUse && defUse.definitionKind !== DefinitionKind.None) {
-        result.push(defUse);
-      }
-      scope = scope.parent;
-    }
-    return result;
-  }
-
-  #mergeChildDefUses(name: string, defUses: VariableUses): void {
-    const variable = this.variables.get(name);
-    if (!variable) {
-      this.variables.set(name, defUses);
-      return;
-    }
-    variable.uses.push(...defUses.uses);
-    if (defUses.definitionKind === DefinitionKind.Var) {
-      console.assert(variable.definitionKind !== DefinitionKind.Let);
-      if (variable.definitionKind === DefinitionKind.None) {
-        variable.definitionKind = defUses.definitionKind;
-      }
-    } else {
-      console.assert(defUses.definitionKind === DefinitionKind.None);
-    }
-  }
-
-  finalizeToParent(isFunctionScope: boolean): void {
-    if (!this.parent) {
-      console.error('Internal error: wrong nesting in scope analysis.');
-      throw new Error('Internal error');
-    }
-
-    // Move all unbound variables to the parent (also move var-bound variables
-    // if the parent is not a function).
-    const keysToRemove = [];
-    for (const [name, defUse] of this.variables.entries()) {
-      if (defUse.definitionKind === DefinitionKind.None ||
-          (defUse.definitionKind === DefinitionKind.Var && !isFunctionScope)) {
-        this.parent.#mergeChildDefUses(name, defUse);
-        keysToRemove.push(name);
-      }
-    }
-    keysToRemove.forEach(k => this.variables.delete(k));
-  }
-}
-
-class ScopeVariableAnalysis {
-  readonly #rootScope = new Scope(null);
-  readonly #allNames = new Set<string>();
-  #currentScope = this.#rootScope;
-
-  processNode(node: Acorn.ESTree.Node|null): void {
-    if (node === null) {
-      return;
-    }
-    switch (node.type) {
-      case 'AwaitExpression':
-        this.processNode(node.argument);
-        break;
-      case 'ArrayExpression':
-        node.elements.forEach(item => this.processNode(item));
-        break;
-      case 'ExpressionStatement':
-        this.processNode(node.expression);
-        break;
-      case 'Program':
-        console.assert(this.#currentScope === this.#rootScope);
-        node.body.forEach(item => this.processNode(item));
-        console.assert(this.#currentScope === this.#rootScope);
-        break;
-      case 'ArrayPattern':
-        node.elements.forEach(item => this.processNode(item));
-        break;
-      case 'ArrowFunctionExpression':
-        this.#pushScope();
-        node.params.forEach(this.#processNodeAsDefinition.bind(this, DefinitionKind.Var));
-        this.processNode(node.body);
-        this.#popScope(true);
-        break;
-      case 'AssignmentExpression':
-      case 'AssignmentPattern':
-      case 'BinaryExpression':
-      case 'LogicalExpression':
-        this.processNode(node.left);
-        this.processNode(node.right);
-        break;
-      case 'BlockStatement':
-        this.#pushScope();
-        node.body.forEach(this.processNode.bind(this));
-        this.#popScope(false);
-        break;
-      case 'CallExpression':
-        this.processNode(node.callee);
-        node.arguments.forEach(this.processNode.bind(this));
-        break;
-      case 'VariableDeclaration': {
-        const definitionKind = node.kind === 'var' ? DefinitionKind.Var : DefinitionKind.Let;
-        node.declarations.forEach(this.#processVariableDeclarator.bind(this, definitionKind));
-        break;
-      }
-      case 'CatchClause':
-        this.#pushScope();
-        this.#processNodeAsDefinition(DefinitionKind.Let, node.param);
-        node.body.body.forEach(this.processNode.bind(this));
-        this.#popScope(false);
-        break;
-      case 'ClassBody':
-        node.body.forEach(this.processNode.bind(this));
-        break;
-      case 'ClassDeclaration':
-        this.#processNodeAsDefinition(DefinitionKind.Let, node.id);
-        this.#pushScope();
-        this.processNode(node.superClass ?? null);
-        this.processNode(node.body);
-        this.#popScope(false);
-        break;
-      case 'ClassExpression':
-        this.#pushScope();
-        // Intentionally ignore the id.
-        this.processNode(node.superClass ?? null);
-        this.processNode(node.body);
-        this.#popScope(false);
-        break;
-      case 'ChainExpression':
-        this.processNode(node.expression);
-        break;
-      case 'ConditionalExpression':
-        this.processNode(node.test);
-        this.processNode(node.consequent);
-        this.processNode(node.alternate);
-        break;
-      case 'DoWhileStatement':
-        this.processNode(node.body);
-        this.processNode(node.test);
-        break;
-      case 'ForInStatement':
-      case 'ForOfStatement':
-        this.#pushScope();
-        this.processNode(node.left);
-        this.processNode(node.right);
-        this.processNode(node.body);
-        this.#popScope(false);
-        break;
-      case 'ForStatement':
-        this.#pushScope();
-        this.processNode(node.init ?? null);
-        this.processNode(node.test ?? null);
-        this.processNode(node.update ?? null);
-        this.processNode(node.body);
-        this.#popScope(false);
-        break;
-      case 'FunctionDeclaration':
-        this.#processNodeAsDefinition(DefinitionKind.Var, node.id);
-        this.#pushScope();
-        this.#addVariable('this', node.start, DefinitionKind.Fixed);
-        this.#addVariable('arguments', node.start, DefinitionKind.Fixed);
-        node.params.forEach(this.#processNodeAsDefinition.bind(this, DefinitionKind.Let));
-        this.processNode(node.body);
-        this.#popScope(true);
-        break;
-      case 'FunctionExpression':
-        // Id is intentionally ignored in function expressions.
-        this.#pushScope();
-        this.#addVariable('this', node.start, DefinitionKind.Fixed);
-        this.#addVariable('arguments', node.start, DefinitionKind.Fixed);
-        node.params.forEach(this.#processNodeAsDefinition.bind(this, DefinitionKind.Let));
-        this.processNode(node.body);
-        this.#popScope(true);
-        break;
-      case 'Identifier':
-        this.#addVariable(node.name, node.start);
-        break;
-      case 'IfStatement':
-        this.processNode(node.test);
-        this.processNode(node.consequent);
-        this.processNode(node.alternate ?? null);
-        break;
-      case 'LabeledStatement':
-        this.processNode(node.body);
-        break;
-      case 'MetaProperty':
-        break;
-      case 'MethodDefinition':
-        if (node.computed) {
-          this.processNode(node.key);
-        }
-        this.processNode(node.value);
-        break;
-      case 'NewExpression':
-        this.processNode(node.callee);
-        node.arguments.forEach(this.processNode.bind(this));
-        break;
-      case 'MemberExpression':
-        this.processNode(node.object);
-        if (node.computed) {
-          this.processNode(node.property);
-        }
-        break;
-      case 'ObjectExpression':
-        node.properties.forEach(this.processNode.bind(this));
-        break;
-      case 'ObjectPattern':
-        node.properties.forEach(this.processNode.bind(this));
-        break;
-      case 'PrivateIdentifier':
-        break;
-      case 'PropertyDefinition':
-        if (node.computed) {
-          this.processNode(node.key);
-        }
-        this.processNode(node.value ?? null);
-        break;
-      case 'Property':
-        if (node.shorthand) {
-          console.assert(node.value === node.key);
-          console.assert(node.value.type === 'Identifier');
-          this.#addVariable((node.value as Acorn.ESTree.Identifier).name, node.value.start, DefinitionKind.None, true);
-        } else {
-          if (node.computed) {
-            this.processNode(node.key);
-          }
-          this.processNode(node.value);
-        }
-        break;
-      case 'RestElement':
-        this.#processNodeAsDefinition(DefinitionKind.Let, node.argument);
-        break;
-      case 'ReturnStatement':
-        this.processNode(node.argument ?? null);
-        break;
-      case 'SequenceExpression':
-        node.expressions.forEach(this.processNode.bind(this));
-        break;
-      case 'SpreadElement':
-        this.processNode(node.argument);
-        break;
-      case 'SwitchCase':
-        this.processNode(node.test ?? null);
-        node.consequent.forEach(this.processNode.bind(this));
-        break;
-      case 'SwitchStatement':
-        this.processNode(node.discriminant);
-        node.cases.forEach(this.processNode.bind(this));
-        break;
-      case 'TaggedTemplateExpression':
-        this.processNode(node.tag);
-        this.processNode(node.quasi);
-        break;
-      case 'TemplateLiteral':
-        node.expressions.forEach(this.processNode.bind(this));
-        break;
-      case 'ThisExpression':
-        this.#addVariable('this', node.start);
-        break;
-      case 'ThrowStatement':
-        this.processNode(node.argument);
-        break;
-      case 'TryStatement':
-        this.processNode(node.block);
-        this.processNode(node.handler ?? null);
-        this.processNode(node.finalizer ?? null);
-        break;
-      case 'WithStatement':
-        this.processNode(node.object);
-        // TODO jarin figure how to treat the with body.
-        this.processNode(node.body);
-        break;
-      case 'YieldExpression':
-        this.processNode(node.argument ?? null);
-        break;
-      case 'UnaryExpression':
-      case 'UpdateExpression':
-        this.processNode(node.argument);
-        break;
-      case 'WhileStatement':
-        this.processNode(node.test);
-        this.processNode(node.body);
-        break;
-
-      // Ignore, no expressions involved.
-      case 'BreakStatement':
-      case 'ContinueStatement':
-      case 'DebuggerStatement':
-      case 'EmptyStatement':
-      case 'Literal':
-      case 'Super':
-      case 'TemplateElement':
-        break;
-        // Ignore, cannot be used outside of a module.
-      case 'ImportDeclaration':
-      case 'ImportDefaultSpecifier':
-      case 'ImportNamespaceSpecifier':
-      case 'ImportSpecifier':
-      case 'ImportExpression':
-      case 'ExportAllDeclaration':
-      case 'ExportDefaultDeclaration':
-      case 'ExportNamedDeclaration':
-      case 'ExportSpecifier':
-        break;
-
-      case 'VariableDeclarator':
-        console.error('Should not encounter VariableDeclarator in general traversal.');
-        break;
-    }
-  }
-
-  getFreeVariables(): Map<string, Use[]> {
-    const result = new Map<string, Use[]>();
-    for (const [name, defUse] of this.#rootScope.variables) {
-      if (defUse.definitionKind !== DefinitionKind.None) {
-        // Skip bound variables.
-        continue;
-      }
-      result.set(name, defUse.uses);
-    }
-    return result;
-  }
-
-  getAllNames(): Set<string> {
-    return this.#allNames;
-  }
-
-  #pushScope(): void {
-    this.#currentScope = new Scope(this.#currentScope);
-  }
-
-  #popScope(isFunctionContext: boolean): void {
-    if (this.#currentScope.parent === null) {
-      console.error('Internal error: wrong nesting in scope analysis.');
-      throw new Error('Internal error');
-    }
-    this.#currentScope.finalizeToParent(isFunctionContext);
-    this.#currentScope = this.#currentScope.parent;
-  }
-
-  #addVariable(
-      name: string, offset: number, definitionKind: DefinitionKind = DefinitionKind.None,
-      isShorthandAssignmentProperty: boolean = false): void {
-    this.#allNames.add(name);
-    this.#currentScope.addVariable(name, offset, definitionKind, isShorthandAssignmentProperty);
-  }
-
-  #processNodeAsDefinition(
-      definitionKind: DefinitionKind.Let|DefinitionKind.Var,
-      node: Acorn.ESTree.Pattern|Acorn.ESTree.AssignmentProperty|null): void {
-    if (node === null) {
-      return;
-    }
-    switch (node.type) {
-      case 'ArrayPattern':
-        node.elements.forEach(this.#processNodeAsDefinition.bind(this, definitionKind));
-        break;
-      case 'AssignmentPattern':
-        this.#processNodeAsDefinition(definitionKind, node.left);
-        this.processNode(node.right);
-        break;
-      case 'Identifier':
-        this.#addVariable(node.name, node.start, definitionKind);
-        break;
-      case 'MemberExpression':
-        this.processNode(node.object);
-        if (node.computed) {
-          this.processNode(node.property);
-        }
-        break;
-      case 'ObjectPattern':
-        node.properties.forEach(this.#processNodeAsDefinition.bind(this, definitionKind));
-        break;
-      case 'Property':
-        // This is AssignmentProperty inside an object pattern.
-        if (node.shorthand) {
-          console.assert(node.value === node.key);
-          console.assert(node.value.type === 'Identifier');
-          this.#addVariable((node.value as Acorn.ESTree.Identifier).name, node.value.start, definitionKind, true);
-        } else {
-          if (node.computed) {
-            this.processNode(node.key);
-          }
-          this.#processNodeAsDefinition(definitionKind, node.value);
-        }
-        break;
-      case 'RestElement':
-        this.#processNodeAsDefinition(definitionKind, node.argument);
-        break;
-    }
-  }
-
-  #processVariableDeclarator(
-      definitionKind: DefinitionKind.Let|DefinitionKind.Var, decl: Acorn.ESTree.VariableDeclarator): void {
-    this.#processNodeAsDefinition(definitionKind, decl.id);
-    this.processNode(decl.init ?? null);
-  }
-}

package/front_end/entrypoints/formatter_worker/formatter_worker.ts

@@ -16,6 +16,7 @@ import * as HTMLOutline from './HTMLOutline.js';
 import * as JavaScriptFormatter from './JavaScriptFormatter.js';
 import * as JavaScriptOutline from './JavaScriptOutline.js';
 import * as JSONFormatter from './JSONFormatter.js';
+import * as ScopeParser from './ScopeParser.js';
 import * as Substitute from './Substitute.js';
 
 export {
@@ -28,5 +29,6 @@ export {
   JavaScriptFormatter,
   JavaScriptOutline,
   JSONFormatter,
+  ScopeParser,
   Substitute,
 };

package/front_end/entrypoints/main/MainImpl.ts

@@ -407,6 +407,7 @@ export class MainImpl {
       Root.Runtime.ExperimentName.SYNC_SETTINGS,
       Root.Runtime.ExperimentName.CSS_LAYERS,
       Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER,
+      'lighthousePanelFR',
     ]);
 
     Root.Runtime.experiments.cleanUpStaleExperiments();

package/front_end/generated/InspectorBackendCommands.js

@@ -263,11 +263,9 @@ export function registerCommands(inspectorBackend) {
       {KHttpError: 'kHttpError', KUnavailableOffline: 'kUnavailableOffline', KDigitalAssetLinks: 'kDigitalAssetLinks'});
   inspectorBackend.registerEnum('Audits.AttributionReportingIssueType', {
     PermissionPolicyDisabled: 'PermissionPolicyDisabled',
-    InvalidAttributionSourceEventId: 'InvalidAttributionSourceEventId',
     AttributionSourceUntrustworthyOrigin: 'AttributionSourceUntrustworthyOrigin',
     AttributionUntrustworthyOrigin: 'AttributionUntrustworthyOrigin',
-    InvalidAttributionSourceExpiry: 'InvalidAttributionSourceExpiry',
-    InvalidAttributionSourcePriority: 'InvalidAttributionSourcePriority'
+    InvalidHeader: 'InvalidHeader'
   });
   inspectorBackend.registerEnum(
       'Audits.GenericIssueErrorType', {CrossOriginPortalPostMessageError: 'CrossOriginPortalPostMessageError'});
@@ -291,10 +289,7 @@ export function registerCommands(inspectorBackend) {
     GetUserMediaInsecureOrigin: 'GetUserMediaInsecureOrigin',
     HostCandidateAttributeGetter: 'HostCandidateAttributeGetter',
     InsecurePrivateNetworkSubresourceRequest: 'InsecurePrivateNetworkSubresourceRequest',
-    LegacyConstraintGoogCpuOveruseDetection: 'LegacyConstraintGoogCpuOveruseDetection',
     LegacyConstraintGoogIPv6: 'LegacyConstraintGoogIPv6',
-    LegacyConstraintGoogScreencastMinBitrate: 'LegacyConstraintGoogScreencastMinBitrate',
-    LegacyConstraintGoogSuspendBelowMinBitrate: 'LegacyConstraintGoogSuspendBelowMinBitrate',
     LocalCSSFileExtensionRejected: 'LocalCSSFileExtensionRejected',
     MediaElementAudioSourceNode: 'MediaElementAudioSourceNode',
     MediaSourceAbortRemove: 'MediaSourceAbortRemove',
@@ -321,16 +316,13 @@ export function registerCommands(inspectorBackend) {
     RTCConstraintEnableDtlsSrtpTrue: 'RTCConstraintEnableDtlsSrtpTrue',
     RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics:
         'RTCPeerConnectionComplexPlanBSdpUsingDefaultSdpSemantics',
-    RTCPeerConnectionLegacyCreateWithMediaConstraints: 'RTCPeerConnectionLegacyCreateWithMediaConstraints',
     RTCPeerConnectionSdpSemanticsPlanB: 'RTCPeerConnectionSdpSemanticsPlanB',
     RtcpMuxPolicyNegotiate: 'RtcpMuxPolicyNegotiate',
     RTPDataChannel: 'RTPDataChannel',
-    SelectionAddRangeIntersect: 'SelectionAddRangeIntersect',
     SharedArrayBufferConstructedWithoutIsolation: 'SharedArrayBufferConstructedWithoutIsolation',
     TextToSpeech_DisallowedByAutoplay: 'TextToSpeech_DisallowedByAutoplay',
     V8SharedArrayBufferConstructedInExtensionWithoutIsolation:
         'V8SharedArrayBufferConstructedInExtensionWithoutIsolation',
-    WebCodecsVideoFrameDefaultTimestamp: 'WebCodecsVideoFrameDefaultTimestamp',
     XHRJSONEncodingDetection: 'XHRJSONEncodingDetection',
     XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload: 'XMLHttpRequestSynchronousInNonWorkerOutsideBeforeUnload',
     XRSupportsSession: 'XRSupportsSession'
@@ -1071,6 +1063,8 @@ export function registerCommands(inspectorBackend) {
         {'name': 'key', 'type': 'string', 'optional': false}, {'name': 'value', 'type': 'string', 'optional': false}
       ],
       []);
+  inspectorBackend.registerCommand(
+      'DOMStorage.getStorageKeyForFrame', [{'name': 'frameId', 'type': 'string', 'optional': false}], ['storageKey']);
 
   // Database.
   inspectorBackend.registerEvent('Database.addDatabase', ['database']);
@@ -2348,7 +2342,41 @@ export function registerCommands(inspectorBackend) {
   inspectorBackend.registerEnum(
       'Page.BackForwardCacheNotRestoredReasonType',
       {SupportPending: 'SupportPending', PageSupportNeeded: 'PageSupportNeeded', Circumstantial: 'Circumstantial'});
-  inspectorBackend.registerEnum('Page.PrerenderFinalStatus', {Activated: 'Activated'});
+  inspectorBackend.registerEnum('Page.PrerenderFinalStatus', {
+    Activated: 'Activated',
+    Destroyed: 'Destroyed',
+    LowEndDevice: 'LowEndDevice',
+    CrossOriginRedirect: 'CrossOriginRedirect',
+    CrossOriginNavigation: 'CrossOriginNavigation',
+    InvalidSchemeRedirect: 'InvalidSchemeRedirect',
+    InvalidSchemeNavigation: 'InvalidSchemeNavigation',
+    InProgressNavigation: 'InProgressNavigation',
+    NavigationRequestBlockedByCsp: 'NavigationRequestBlockedByCsp',
+    MainFrameNavigation: 'MainFrameNavigation',
+    MojoBinderPolicy: 'MojoBinderPolicy',
+    RendererProcessCrashed: 'RendererProcessCrashed',
+    RendererProcessKilled: 'RendererProcessKilled',
+    Download: 'Download',
+    TriggerDestroyed: 'TriggerDestroyed',
+    NavigationNotCommitted: 'NavigationNotCommitted',
+    NavigationBadHttpStatus: 'NavigationBadHttpStatus',
+    ClientCertRequested: 'ClientCertRequested',
+    NavigationRequestNetworkError: 'NavigationRequestNetworkError',
+    MaxNumOfRunningPrerendersExceeded: 'MaxNumOfRunningPrerendersExceeded',
+    CancelAllHostsForTesting: 'CancelAllHostsForTesting',
+    DidFailLoad: 'DidFailLoad',
+    Stop: 'Stop',
+    SslCertificateError: 'SslCertificateError',
+    LoginAuthRequested: 'LoginAuthRequested',
+    UaChangeRequiresReload: 'UaChangeRequiresReload',
+    BlockedByClient: 'BlockedByClient',
+    AudioOutputDeviceRequested: 'AudioOutputDeviceRequested',
+    MixedContent: 'MixedContent',
+    TriggerBackgrounded: 'TriggerBackgrounded',
+    EmbedderTriggeredAndSameOriginRedirected: 'EmbedderTriggeredAndSameOriginRedirected',
+    EmbedderTriggeredAndCrossOriginRedirected: 'EmbedderTriggeredAndCrossOriginRedirected',
+    EmbedderTriggeredAndDestroyed: 'EmbedderTriggeredAndDestroyed'
+  });
   inspectorBackend.registerEvent('Page.domContentEventFired', ['timestamp']);
   inspectorBackend.registerEnum(
       'Page.FileChooserOpenedEventMode', {SelectSingle: 'selectSingle', SelectMultiple: 'selectMultiple'});
@@ -3320,7 +3348,8 @@ export function registerCommands(inspectorBackend) {
       [
         {'name': 'reportProgress', 'type': 'boolean', 'optional': true},
         {'name': 'treatGlobalObjectsAsRoots', 'type': 'boolean', 'optional': true},
-        {'name': 'captureNumericValue', 'type': 'boolean', 'optional': true}
+        {'name': 'captureNumericValue', 'type': 'boolean', 'optional': true},
+        {'name': 'exposeInternals', 'type': 'boolean', 'optional': true}
       ],
       []);
   inspectorBackend.registerCommand(
@@ -3328,7 +3357,8 @@ export function registerCommands(inspectorBackend) {
       [
         {'name': 'reportProgress', 'type': 'boolean', 'optional': true},
         {'name': 'treatGlobalObjectsAsRoots', 'type': 'boolean', 'optional': true},
-        {'name': 'captureNumericValue', 'type': 'boolean', 'optional': true}
+        {'name': 'captureNumericValue', 'type': 'boolean', 'optional': true},
+        {'name': 'exposeInternals', 'type': 'boolean', 'optional': true}
       ],
       []);
 

package/front_end/generated/SupportedCSSProperties.js

@@ -486,11 +486,11 @@ export const generatedProperties = [
   {'name': 'forced-color-adjust', 'inherited': true, 'keywords': ['auto', 'none', 'preserve-parent-color']},
   {'longhands': ['row-gap', 'column-gap'], 'name': 'gap'},
   {
-    'name': 'grid',
     'longhands': [
       'grid-template-rows', 'grid-template-columns', 'grid-template-areas', 'grid-auto-flow', 'grid-auto-rows',
       'grid-auto-columns'
-    ]
+    ],
+    'name': 'grid'
   },
   {'longhands': ['grid-row-start', 'grid-column-start', 'grid-row-end', 'grid-column-end'], 'name': 'grid-area'},
   {'name': 'grid-auto-columns', 'keywords': ['auto', 'min-content', 'max-content']},
@@ -505,7 +505,7 @@ export const generatedProperties = [
   {'name': 'grid-row-end', 'keywords': ['auto']},
   {'longhands': ['row-gap'], 'name': 'grid-row-gap'},
   {'name': 'grid-row-start', 'keywords': ['auto']},
-  {'name': 'grid-template', 'longhands': ['grid-template-rows', 'grid-template-columns', 'grid-template-areas']},
+  {'longhands': ['grid-template-rows', 'grid-template-columns', 'grid-template-areas'], 'name': 'grid-template'},
   {'keywords': ['none'], 'name': 'grid-template-areas'},
   {'name': 'grid-template-columns', 'keywords': ['none']},
   {'name': 'grid-template-rows', 'keywords': ['none']},
@@ -589,7 +589,6 @@ export const generatedProperties = [
   },
   {'name': 'negative'},
   {'name': 'object-fit', 'keywords': ['fill', 'contain', 'cover', 'none', 'scale-down']},
-  {'name': 'object-overflow', 'keywords': ['clip', 'visible']},
   {'name': 'object-position'},
   {'name': 'object-view-box', 'keywords': ['none']},
   {
@@ -1101,7 +1100,6 @@ export const generatedPropertyValues = {
     ]
   },
   'object-fit': {'values': ['fill', 'contain', 'cover', 'none', 'scale-down']},
-  'object-overflow': {'values': ['clip', 'visible']},
   'object-view-box': {'values': ['none']},
   'offset-anchor': {'values': ['auto']},
   'offset-path': {'values': ['none']},

package/front_end/generated/protocol-mapping.d.ts

@@ -1464,6 +1464,10 @@ export namespace ProtocolMapping {
     'DOMStorage.removeDOMStorageItem':
         {paramsType: [Protocol.DOMStorage.RemoveDOMStorageItemRequest]; returnType: void;};
     'DOMStorage.setDOMStorageItem': {paramsType: [Protocol.DOMStorage.SetDOMStorageItemRequest]; returnType: void;};
+    'DOMStorage.getStorageKeyForFrame': {
+      paramsType: [Protocol.DOMStorage.GetStorageKeyForFrameRequest];
+      returnType: Protocol.DOMStorage.GetStorageKeyForFrameResponse;
+    };
     /**
      * Disables database tracking, prevents database events from being sent to the client.
      */
@@ -1614,7 +1618,7 @@ export namespace ProtocolMapping {
      * Sends a BeginFrame to the target and returns when the frame was completed. Optionally captures a
      * screenshot from the resulting frame. Requires that the target was created with enabled
      * BeginFrameControl. Designed for use with --run-all-compositor-stages-before-draw, see also
-     * https://goo.gl/3zHXhB for more background.
+     * https://goo.gle/chrome-headless-rendering for more background.
      */
     'HeadlessExperimental.beginFrame': {
       paramsType: [Protocol.HeadlessExperimental.BeginFrameRequest?];

package/front_end/generated/protocol-proxy-api.d.ts

@@ -1280,6 +1280,9 @@ declare namespace ProtocolProxyApi {
 
     invoke_setDOMStorageItem(params: Protocol.DOMStorage.SetDOMStorageItemRequest):
         Promise<Protocol.ProtocolResponseWithError>;
+
+    invoke_getStorageKeyForFrame(params: Protocol.DOMStorage.GetStorageKeyForFrameRequest):
+        Promise<Protocol.DOMStorage.GetStorageKeyForFrameResponse>;
   }
   export interface DOMStorageDispatcher {
     domStorageItemAdded(params: Protocol.DOMStorage.DomStorageItemAddedEvent): void;
@@ -1496,7 +1499,7 @@ declare namespace ProtocolProxyApi {
      * Sends a BeginFrame to the target and returns when the frame was completed. Optionally captures a
      * screenshot from the resulting frame. Requires that the target was created with enabled
      * BeginFrameControl. Designed for use with --run-all-compositor-stages-before-draw, see also
-     * https://goo.gl/3zHXhB for more background.
+     * https://goo.gle/chrome-headless-rendering for more background.
      */
     invoke_beginFrame(params: Protocol.HeadlessExperimental.BeginFrameRequest):
         Promise<Protocol.HeadlessExperimental.BeginFrameResponse>;