chrome-ai-bridge 1.0.3 → 1.0.5

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/Styles.js

@@ -307,6 +307,10 @@ const UIStrings = {
      * @description Text in Timeline UIUtils of the Performance panel
      */
     largestContentfulPaint: 'Largest Contentful Paint',
+    /**
+     * @description Text in Timeline UIUtils of the Performance panel
+     */
+    softLargestContentfulPaint: 'Soft Largest Contentful Paint',
     /**
      * @description Text for timestamps of items
      */
@@ -684,6 +688,7 @@ export function maybeInitSylesMap() {
         ["firstPaint" /* Types.Events.Name.MARK_FIRST_PAINT */]: new TimelineRecordStyle(i18nString(UIStrings.firstPaint), defaultCategoryStyles.painting, true),
         ["firstContentfulPaint" /* Types.Events.Name.MARK_FCP */]: new TimelineRecordStyle(i18nString(UIStrings.firstContentfulPaint), defaultCategoryStyles.rendering, true),
         ["largestContentfulPaint::Candidate" /* Types.Events.Name.MARK_LCP_CANDIDATE */]: new TimelineRecordStyle(i18nString(UIStrings.largestContentfulPaint), defaultCategoryStyles.rendering, true),
+        ["largestContentfulPaint::CandidateForSoftNavigation" /* Types.Events.Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */]: new TimelineRecordStyle(i18nString(UIStrings.softLargestContentfulPaint), defaultCategoryStyles.rendering, true),
         ["TimeStamp" /* Types.Events.Name.TIME_STAMP */]: new TimelineRecordStyle(i18nString(UIStrings.timestamp), defaultCategoryStyles.scripting),
         ["ConsoleTime" /* Types.Events.Name.CONSOLE_TIME */]: new TimelineRecordStyle(i18nString(UIStrings.consoleTime), defaultCategoryStyles.scripting),
         ["UserTiming" /* Types.Events.Name.USER_TIMING */]: new TimelineRecordStyle(i18nString(UIStrings.userTiming), defaultCategoryStyles.scripting),
@@ -795,13 +800,16 @@ export function markerDetailsForEvent(event) {
         color = 'var(--sys-color-green-bright)';
         title = "FCP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.FCP */;
     }
-    if (Types.Events.isLargestContentfulPaintCandidate(event)) {
+    if (Types.Events.isAnyLargestContentfulPaintCandidate(event)) {
         color = 'var(--sys-color-green)';
-        title = "LCP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP */;
+        title = Types.Events.isSoftLargestContentfulPaintCandidate(event) ?
+            "LCP*" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.SOFT_LCP */ :
+            "LCP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP */;
     }
-    if (Types.Events.isNavigationStart(event)) {
+    if (Types.Events.isNavigationStart(event) || Types.Events.isSoftNavigationStart(event)) {
         color = 'var(--color-text-primary)';
-        title = "Nav" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.NAV */;
+        title = Types.Events.isSoftNavigationStart(event) ? "Nav*" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.SOFT_NAV */ :
+            "Nav" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.NAV */;
     }
     if (Types.Events.isMarkDOMContent(event)) {
         color = 'var(--color-text-disabled)';

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/extras/Initiators.js

@@ -0,0 +1,46 @@
+import { get as getStackTrace } from './StackTraceForEvent.js';
+/**
+ * There are bugs in the backend tracing that means that network requests are
+ * often incorrectly tied to an initiator. This function exists as a utility to
+ * look up an event's initiator regardless of the type of event, but also to
+ * provide a post-parsing fix for network initiators.
+ * The TL;DR is that images injected by a script will incorrectly have their
+ * initiator set to the root document. To fix this, we look at the stack trace
+ * when the request was sent, and use that.
+ */
+export function getNetworkInitiator(data, event) {
+    const networkHandlerInitiator = data.NetworkRequests.incompleteInitiator.get(event);
+    if (networkHandlerInitiator?.args.data.mimeType === 'text/css') {
+        // The bugs in tracing & initiators apply mostly to scripts; we have not
+        // seen a case where the trace events identify a CSS stylesheet as the
+        // initiator that is incorrect. Therefore, if a stylesheet is identified as
+        // the initiator, we trust that it is accurate and can exit early.
+        return networkHandlerInitiator;
+    }
+    // For network requests, it is more reliable to calculate the initiator via
+    // the stack trace if we have one.
+    // We have to use the raw source event (`ResourceSendRequest`) as that is
+    // the event with the `sampleStackId` property which is required to
+    // calculate this stacktrace correctly.
+    const stack = getStackTrace(event.rawSourceEvent, data);
+    // If the resource was injected by a script, it will have a parent call
+    // frame that points to the script. Otherwise, there is no parent and
+    // therefore we fallthrough to looking at the initiator directly on the
+    // network request.
+    const initiatorCallFrame = stack?.parent?.callFrames.at(0);
+    if (!initiatorCallFrame) {
+        return networkHandlerInitiator;
+    }
+    // Find all the requests for the URL we are searching for. Most of the time
+    // there is only 1, but there can be multiple requests for the same URL. The
+    // filtering by the timestamp ensures that we can never pick an initiator
+    // that happened after the initiated event.
+    const matchingRequestIds = data.NetworkRequests.requestIdsByURL.get(initiatorCallFrame.url) ?? [];
+    const matchingRequests = matchingRequestIds.map(id => data.NetworkRequests.byId.get(id))
+        .filter(req => req !== undefined)
+        .filter(req => req.ts < event.ts);
+    // Now we have filtered and have a list of requests that are before the
+    // event, we take the last one - the one closest to the initiated event.
+    // In the case that there are >1 requests, this is an educated guess.
+    return matchingRequests.at(-1);
+}

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/extras/TraceTree.js

@@ -413,8 +413,9 @@ export class BottomUpRootNode extends Node {
                 node.totalTime += totalTimeById.get(id) || 0;
                 totalTimeById.delete(id);
             }
-            // TODO: this may be wrong. See the skipped test in TraceTree.test.ts.
-            if (firstNodeStack.length) {
+            // An item on this stack means that this current node has a caller. Therefore,
+            // in a bottom-up view it has children.
+            if (idStack.length > 0) {
                 node.setHasChildren(true);
             }
         }
@@ -587,7 +588,7 @@ export function generateEventID(event) {
             SamplesIntegrator.nativeGroup(event.callFrame.functionName) :
             event.callFrame.functionName;
         const location = event.callFrame.scriptId || event.callFrame.url || '';
-        return `f:${name}@${location}`;
+        return `f:${name}@${location}:${event.callFrame.lineNumber}:${event.callFrame.columnNumber}`;
     }
     if (Types.Events.isConsoleTimeStamp(event) && event.args.data) {
         return `${event.name}:${event.args.data.name}`;

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/extras/extras.js

@@ -2,6 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 export * as FilmStrip from './FilmStrip.js';
+export * as Initiators from './Initiators.js';
 export * as MainThreadActivity from './MainThreadActivity.js';
 export * as ScriptDuplication from './ScriptDuplication.js';
 export * as StackTraceForEvent from './StackTraceForEvent.js';

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/handlers/LargestImagePaintHandler.js

@@ -43,9 +43,9 @@ export async function finalize() {
     const { traceBounds, navigationsByNavigationId } = metaData();
     const metricScoresByFrameId = pageLoadMetricsData().metricScoresByFrameId;
     for (const [navigationId, navigation] of navigationsByNavigationId) {
-        const lcpMetric = metricScoresByFrameId.get(navigation.args.frame)?.get(navigationId)?.get("LCP" /* MetricName.LCP */);
+        const lcpMetric = metricScoresByFrameId.get(navigation.args.frame)?.get(navigation)?.get("LCP" /* MetricName.LCP */);
         const lcpEvent = lcpMetric?.event;
-        if (!lcpEvent || !Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
+        if (!lcpEvent || !Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
             continue;
         }
         const nodeId = lcpEvent.args.data?.nodeId;

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/handlers/LayoutShiftsHandler.js

@@ -395,7 +395,7 @@ async function buildLayoutShiftsClusters() {
         // Update the cluster's worst layout shift.
         if (worstShiftEvent) {
             cluster.worstShiftEvent = worstShiftEvent;
-            cluster.rawSourceEvent = worstShiftEvent;
+            cluster.rawSourceEvent = worstShiftEvent.rawSourceEvent;
         }
         // layout shifts are already sorted by time ascending.
         // Capture the time range of the cluster.

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/handlers/MetaHandler.js

@@ -47,6 +47,7 @@ let traceBounds = makeNewTraceBounds();
  */
 let navigationsByFrameId = new Map();
 let navigationsByNavigationId = new Map();
+let softNavigationsById = new Map();
 let finalDisplayUrlByNavigationId = new Map();
 let mainFrameNavigations = [];
 // Represents all the threads in the trace, organized by process. This is mostly for internal
@@ -76,6 +77,7 @@ const CHROME_WEB_TRACE_EVENTS = new Set([
 export function reset() {
     navigationsByFrameId = new Map();
     navigationsByNavigationId = new Map();
+    softNavigationsById = new Map();
     finalDisplayUrlByNavigationId = new Map();
     processNames = new Map();
     mainFrameNavigations = [];
@@ -276,6 +278,9 @@ export function handleEvent(event) {
         }
         return;
     }
+    if (Types.Events.isSoftNavigationStart(event)) {
+        softNavigationsById.set(event.args.context.performanceTimelineNavigationId, event);
+    }
     // Update `finalDisplayUrlByNavigationId` to reflect the latest redirect for each navigation.
     if (Types.Events.isResourceSendRequest(event)) {
         if (event.args.data.resourceType !== 'Document') {
@@ -393,6 +398,7 @@ export function data() {
         mainFrameURL,
         navigationsByFrameId,
         navigationsByNavigationId,
+        softNavigationsById,
         finalDisplayUrlByNavigationId,
         threadsInProcess,
         rendererProcessesByFrame: rendererProcessesByFrameId,

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/handlers/NetworkRequestsHandler.js

@@ -13,6 +13,10 @@ let linkPreconnectEvents = [];
 let requestMap = new Map();
 let requestsById = new Map();
 let requestsByTime = [];
+/**
+ * URL => RequestId[]. There can be multiple requests for a single URL.
+ */
+let requestIdsByURL = new Map();
 let networkRequestEventByInitiatorUrl = new Map();
 let eventToInitiatorMap = new Map();
 /**
@@ -61,6 +65,7 @@ export function reset() {
     networkRequestEventByInitiatorUrl = new Map();
     eventToInitiatorMap = new Map();
     webSocketData = new Map();
+    requestIdsByURL = new Map();
     entityMappings = {
         eventsByEntity: new Map(),
         entityByEvent: new Map(),
@@ -476,6 +481,9 @@ export async function finalize() {
         // the captured requests, so here we store all of them together.
         requestsByTime.push(networkEvent);
         requestsById.set(networkEvent.args.data.requestId, networkEvent);
+        const requestsForUrl = requestIdsByURL.get(networkEvent.args.data.url) ?? [];
+        requestsForUrl.push(networkEvent.args.data.requestId);
+        requestIdsByURL.set(networkEvent.args.data.url, requestsForUrl);
         // Update entity relationships for network events
         HandlerHelpers.addNetworkRequestToEntityMapping(networkEvent, entityMappings, request);
         // Establish initiator relationships
@@ -501,7 +509,8 @@ export function data() {
     return {
         byId: requestsById,
         byTime: requestsByTime,
-        eventToInitiator: eventToInitiatorMap,
+        requestIdsByURL,
+        incompleteInitiator: eventToInitiatorMap,
         webSocket: [...webSocketData.values()],
         entityMappings: {
             entityByEvent: entityMappings.entityByEvent,

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/handlers/PageLoadMetricsHandler.js

@@ -4,7 +4,9 @@
 /**
  * This handler stores page load metrics, including web vitals,
  * and exports them in the shape of a map with the following shape:
- * Map(FrameId -> Map(navigationID -> metrics) )
+ * Map(FrameId -> Map(navigation -> metrics) )
+ *
+ * Includes soft navigations.
  *
  * It also exports all markers in a trace in an array.
  *
@@ -50,10 +52,6 @@ export function handleEvent(event) {
     pageLoadEventsArray.push(event);
 }
 function storePageLoadMetricAgainstNavigationId(navigation, event) {
-    const navigationId = navigation.args.data?.navigationId;
-    if (!navigationId) {
-        throw new Error('Navigation event unexpectedly had no navigation ID.');
-    }
     const frameId = getFrameIdForPageLoadEvent(event);
     const { rendererProcessesByFrame } = metaHandlerData();
     // If either of these pieces of data do not exist, the most likely
@@ -77,14 +75,14 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
         const fcpTime = Types.Timing.Micro(event.ts - navigation.ts);
         const classification = scoreClassificationForFirstContentfulPaint(fcpTime);
         const metricScore = { event, metricName: "FCP" /* MetricName.FCP */, classification, navigation, timing: fcpTime };
-        storeMetricScore(frameId, navigationId, metricScore);
+        storeMetricScore(frameId, navigation, metricScore);
         return;
     }
     if (Types.Events.isFirstPaint(event)) {
         const paintTime = Types.Timing.Micro(event.ts - navigation.ts);
         const classification = "unclassified" /* ScoreClassification.UNCLASSIFIED */;
         const metricScore = { event, metricName: "FP" /* MetricName.FP */, classification, navigation, timing: paintTime };
-        storeMetricScore(frameId, navigationId, metricScore);
+        storeMetricScore(frameId, navigation, metricScore);
         return;
     }
     if (Types.Events.isMarkDOMContent(event)) {
@@ -96,7 +94,7 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
             navigation,
             timing: dclTime,
         };
-        storeMetricScore(frameId, navigationId, metricScore);
+        storeMetricScore(frameId, navigation, metricScore);
         return;
     }
     if (Types.Events.isInteractiveTime(event)) {
@@ -108,7 +106,7 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
             navigation,
             timing: ttiValue,
         };
-        storeMetricScore(frameId, navigationId, tti);
+        storeMetricScore(frameId, navigation, tti);
         const tbtValue = Helpers.Timing.milliToMicro(Types.Timing.Milli(event.args.args.total_blocking_time_ms));
         const tbt = {
             event,
@@ -117,7 +115,7 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
             navigation,
             timing: tbtValue,
         };
-        storeMetricScore(frameId, navigationId, tbt);
+        storeMetricScore(frameId, navigation, tbt);
         return;
     }
     if (Types.Events.isMarkLoad(event)) {
@@ -129,10 +127,10 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
             navigation,
             timing: loadTime,
         };
-        storeMetricScore(frameId, navigationId, metricScore);
+        storeMetricScore(frameId, navigation, metricScore);
         return;
     }
-    if (Types.Events.isLargestContentfulPaintCandidate(event)) {
+    if (Types.Events.isAnyLargestContentfulPaintCandidate(event)) {
         const candidateIndex = event.args.data?.candidateIndex;
         if (!candidateIndex) {
             throw new Error('Largest Contentful Paint unexpectedly had no candidateIndex.');
@@ -146,15 +144,15 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
             timing: lcpTime,
         };
         const metricsByNavigation = Platform.MapUtilities.getWithDefault(metricScoresByFrameId, frameId, () => new Map());
-        const metrics = Platform.MapUtilities.getWithDefault(metricsByNavigation, navigationId, () => new Map());
+        const metrics = Platform.MapUtilities.getWithDefault(metricsByNavigation, navigation, () => new Map());
         const lastLCPCandidate = metrics.get("LCP" /* MetricName.LCP */);
         if (lastLCPCandidate === undefined) {
             selectedLCPCandidateEvents.add(lcp.event);
-            storeMetricScore(frameId, navigationId, lcp);
+            storeMetricScore(frameId, navigation, lcp);
             return;
         }
         const lastLCPCandidateEvent = lastLCPCandidate.event;
-        if (!Types.Events.isLargestContentfulPaintCandidate(lastLCPCandidateEvent)) {
+        if (!Types.Events.isAnyLargestContentfulPaintCandidate(lastLCPCandidateEvent)) {
             return;
         }
         const lastCandidateIndex = lastLCPCandidateEvent.args.data?.candidateIndex;
@@ -167,18 +165,21 @@ function storePageLoadMetricAgainstNavigationId(navigation, event) {
         if (lastCandidateIndex < candidateIndex) {
             selectedLCPCandidateEvents.delete(lastLCPCandidateEvent);
             selectedLCPCandidateEvents.add(lcp.event);
-            storeMetricScore(frameId, navigationId, lcp);
+            storeMetricScore(frameId, navigation, lcp);
         }
         return;
     }
     if (Types.Events.isLayoutShift(event)) {
         return;
     }
+    if (Types.Events.isSoftNavigationStart(event)) {
+        return;
+    }
     return Platform.assertNever(event, `Unexpected event type: ${event}`);
 }
-function storeMetricScore(frameId, navigationId, metricScore) {
+function storeMetricScore(frameId, navigation, metricScore) {
     const metricsByNavigation = Platform.MapUtilities.getWithDefault(metricScoresByFrameId, frameId, () => new Map());
-    const metrics = Platform.MapUtilities.getWithDefault(metricsByNavigation, navigationId, () => new Map());
+    const metrics = Platform.MapUtilities.getWithDefault(metricsByNavigation, navigation, () => new Map());
     // If an entry with that metric name is present, delete it so that the new entry that
     // will replace it is added at the end of the map. This way we guarantee the map entries
     // are ordered in ASC manner by timestamp.
@@ -187,8 +188,9 @@ function storeMetricScore(frameId, navigationId, metricScore) {
 }
 export function getFrameIdForPageLoadEvent(event) {
     if (Types.Events.isFirstContentfulPaint(event) || Types.Events.isInteractiveTime(event) ||
-        Types.Events.isLargestContentfulPaintCandidate(event) || Types.Events.isNavigationStart(event) ||
-        Types.Events.isLayoutShift(event) || Types.Events.isFirstPaint(event)) {
+        Types.Events.isAnyLargestContentfulPaintCandidate(event) || Types.Events.isNavigationStart(event) ||
+        Types.Events.isSoftNavigationStart(event) || Types.Events.isLayoutShift(event) ||
+        Types.Events.isFirstPaint(event)) {
         return event.args.frame;
     }
     if (Types.Events.isMarkDOMContent(event) || Types.Events.isMarkLoad(event)) {
@@ -201,20 +203,35 @@ export function getFrameIdForPageLoadEvent(event) {
     Platform.assertNever(event, `Unexpected event type: ${event}`);
 }
 function getNavigationForPageLoadEvent(event) {
-    if (Types.Events.isFirstContentfulPaint(event) || Types.Events.isLargestContentfulPaintCandidate(event) ||
+    if (Types.Events.isFirstContentfulPaint(event) || Types.Events.isAnyLargestContentfulPaintCandidate(event) ||
         Types.Events.isFirstPaint(event)) {
-        const navigationId = event.args.data?.navigationId;
-        if (!navigationId) {
-            throw new Error('Trace event unexpectedly had no navigation ID.');
+        const { navigationsByNavigationId, softNavigationsById } = metaHandlerData();
+        let navigation;
+        if (event.name === "largestContentfulPaint::CandidateForSoftNavigation" /* Types.Events.Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */ &&
+            event.args.data?.performanceTimelineNavigationId) {
+            navigation = softNavigationsById.get(event.args.data.performanceTimelineNavigationId);
+            if (!navigation) {
+                // The most recent soft navigation must have been before the trace started.
+                return null;
+            }
+        }
+        else {
+            const navigationId = event.args.data?.navigationId;
+            if (!navigationId) {
+                throw new Error(`Trace event unexpectedly had no navigation ID: ${JSON.stringify(event, null, 2)}`);
+            }
+            navigation = navigationsByNavigationId.get(navigationId);
         }
-        const { navigationsByNavigationId } = metaHandlerData();
-        const navigation = navigationsByNavigationId.get(navigationId);
         if (!navigation) {
             // This event's navigation has been filtered out by the meta handler as a noise event.
             return null;
         }
         return navigation;
     }
+    if (Types.Events.isSoftNavigationStart(event)) {
+        const { softNavigationsById } = metaHandlerData();
+        return softNavigationsById.get(event.args.context.performanceTimelineNavigationId) ?? null;
+    }
     if (Types.Events.isMarkDOMContent(event) || Types.Events.isInteractiveTime(event) ||
         Types.Events.isLayoutShift(event) || Types.Events.isMarkLoad(event)) {
         const frameId = getFrameIdForPageLoadEvent(event);
@@ -329,7 +346,7 @@ export async function finalize() {
     const allFinalLCPEvents = gatherFinalLCPEvents();
     const mainFrame = metaHandlerData().mainFrameId;
     // Filter out LCP candidates to use only definitive LCP values
-    const allEventsButLCP = pageLoadEventsArray.filter(event => !Types.Events.isLargestContentfulPaintCandidate(event));
+    const allEventsButLCP = pageLoadEventsArray.filter(event => !Types.Events.isAnyLargestContentfulPaintCandidate(event));
     const markerEvents = [...allFinalLCPEvents, ...allEventsButLCP].filter(Types.Events.isMarkerEvent);
     // Filter by main frame and sort.
     allMarkerEvents =

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/helpers/Timing.js

@@ -9,9 +9,16 @@ export const secondsToMilli = (value) => Types.Timing.Milli(value * 1000);
 export const secondsToMicro = (value) => milliToMicro(secondsToMilli(value));
 export const microToMilli = (value) => Types.Timing.Milli(value / 1000);
 export const microToSeconds = (value) => Types.Timing.Seconds(value / 1000 / 1000);
-export function timeStampForEventAdjustedByClosestNavigation(event, traceBounds, navigationsByNavigationId, navigationsByFrameId) {
+export function timeStampForEventAdjustedByClosestNavigation(event, traceBounds, navigationsByNavigationId, softNavigationsById, navigationsByFrameId) {
     let eventTimeStamp = event.ts - traceBounds.min;
-    if (event.args?.data?.navigationId) {
+    if (event.name === "largestContentfulPaint::CandidateForSoftNavigation" /* Types.Events.Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */ &&
+        event.args?.data?.performanceTimelineNavigationId) {
+        const navigationForEvent = softNavigationsById.get(event.args.data.performanceTimelineNavigationId);
+        if (navigationForEvent) {
+            eventTimeStamp = event.ts - navigationForEvent.ts;
+        }
+    }
+    else if (event.args?.data?.navigationId) {
         const navigationForEvent = navigationsByNavigationId.get(event.args.data.navigationId);
         if (navigationForEvent) {
             eventTimeStamp = event.ts - navigationForEvent.ts;

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/insights/Common.js

@@ -6,12 +6,7 @@ import * as Types from '../types/types.js';
 import { getLogNormalScore } from './Statistics.js';
 const GRAPH_SAVINGS_PRECISION = 50;
 export function getInsight(insightName, insightSet) {
-    const insight = insightSet.model[insightName];
-    if (insight instanceof Error) {
-        return null;
-    }
-    // For some reason typescript won't narrow the type by removing Error, so do it manually.
-    return insight;
+    return insightSet.model[insightName];
 }
 export function getLCP(insightSet) {
     const insight = getInsight("LCPBreakdown" /* InsightKeys.LCP_BREAKDOWN */, insightSet);

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/insights/LCPBreakdown.js

@@ -155,13 +155,13 @@ export function generateInsight(data, context) {
     if (!frameMetrics) {
         throw new Error('no frame metrics');
     }
-    const navMetrics = frameMetrics.get(context.navigationId);
+    const navMetrics = frameMetrics.get(context.navigation);
     if (!navMetrics) {
         throw new Error('no navigation metrics');
     }
     const metricScore = navMetrics.get("LCP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP */);
     const lcpEvent = metricScore?.event;
-    if (!lcpEvent || !Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
+    if (!lcpEvent || !Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
         return finalize({ warnings: [InsightWarning.NO_LCP] });
     }
     // This helps calculate the subparts.

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/insights/LCPDiscovery.js

@@ -81,13 +81,13 @@ export function generateInsight(data, context) {
     if (!frameMetrics) {
         throw new Error('no frame metrics');
     }
-    const navMetrics = frameMetrics.get(context.navigationId);
+    const navMetrics = frameMetrics.get(context.navigation);
     if (!navMetrics) {
         throw new Error('no navigation metrics');
     }
     const metricScore = navMetrics.get("LCP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.LCP */);
     const lcpEvent = metricScore?.event;
-    if (!lcpEvent || !Types.Events.isLargestContentfulPaintCandidate(lcpEvent)) {
+    if (!lcpEvent || !Types.Events.isAnyLargestContentfulPaintCandidate(lcpEvent)) {
         return finalize({ warnings: [InsightWarning.NO_LCP] });
     }
     const docRequest = networkRequests.byId.get(context.navigationId);
@@ -99,8 +99,6 @@ export function generateInsight(data, context) {
         return finalize({ lcpEvent });
     }
     const initiatorUrl = lcpRequest.args.data.initiator?.url;
-    // TODO(b/372319476): Explore using trace event HTMLDocumentParser::FetchQueuedPreloads to determine if the request
-    // is discovered by the preload scanner.
     const initiatedByMainDoc = lcpRequest?.args.data.initiator?.type === 'parser' && docRequest.args.data.url === initiatorUrl;
     const imgPreloadedOrFoundInHTML = lcpRequest?.args.data.isLinkPreload || initiatedByMainDoc;
     const imageLoadingAttr = lcpEvent.args.data?.loadingAttr;

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/insights/NetworkDependencyTree.js

@@ -4,6 +4,7 @@
 import * as Common from '../../../core/common/common.js';
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
+import * as Extras from '../extras/extras.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 import { InsightCategory, } from './types.js';
@@ -406,8 +407,8 @@ function candidateRequestsByOrigin(data, mainResource, contextRequests, lcpGraph
         if (!hasValidTiming(request)) {
             return;
         }
-        // Filter out all resources that are loaded by the document. Connections are already early.
-        if (data.NetworkRequests.eventToInitiator.get(request) === mainResource) {
+        const initiator = Extras.Initiators.getNetworkInitiator(data, request);
+        if (initiator === mainResource) {
             return;
         }
         const url = new URL(request.args.data.url);

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/insights/RenderBlocking.js

@@ -130,7 +130,7 @@ export function generateInsight(data, context) {
         });
     }
     const firstPaintTs = data.PageLoadMetrics.metricScoresByFrameId.get(context.frameId)
-        ?.get(context.navigationId)
+        ?.get(context.navigation)
         ?.get("FP" /* Handlers.ModelHandlers.PageLoadMetrics.MetricName.FP */)
         ?.event?.ts;
     if (!firstPaintTs) {

package/build/node_modules/chrome-devtools-frontend/front_end/models/trace/types/TraceEvents.js

@@ -12,6 +12,9 @@ export function isPhaseAsync(phase) {
 export function isFlowPhase(phase) {
     return phase === "s" /* Phase.FLOW_START */ || phase === "t" /* Phase.FLOW_STEP */ || phase === "f" /* Phase.FLOW_END */;
 }
+export function objectIsEvent(obj) {
+    return 'cat' in obj && 'name' in obj && 'ts' in obj;
+}
 export function objectIsCallFrame(object) {
     return ('functionName' in object && typeof object.functionName === 'string') &&
         ('scriptId' in object && (typeof object.scriptId === 'string' || typeof object.scriptId === 'number')) &&
@@ -38,17 +41,30 @@ export function isLegacySyntheticScreenshot(event) {
 export function isScreenshot(event) {
     return event.name === "Screenshot" /* Name.SCREENSHOT */ && 'source_id' in (event.args ?? {});
 }
+export function isSoftNavigationStart(event) {
+    return event.name === "SoftNavigationStart" /* Name.SOFT_NAVIGATION_START */;
+}
 const markerTypeGuards = [
     isMarkDOMContent,
     isMarkLoad,
     isFirstPaint,
     isFirstContentfulPaint,
-    isLargestContentfulPaintCandidate,
+    isAnyLargestContentfulPaintCandidate,
     isNavigationStart,
+    isSoftNavigationStart,
+];
+export const MarkerName = [
+    "MarkDOMContent" /* Name.MARK_DOM_CONTENT */,
+    "MarkLoad" /* Name.MARK_LOAD */,
+    "firstPaint" /* Name.MARK_FIRST_PAINT */,
+    "firstContentfulPaint" /* Name.MARK_FCP */,
+    "largestContentfulPaint::Candidate" /* Name.MARK_LCP_CANDIDATE */,
+    "largestContentfulPaint::CandidateForSoftNavigation" /* Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */,
+    "navigationStart" /* Name.NAVIGATION_START */,
+    "SoftNavigationStart" /* Name.SOFT_NAVIGATION_START */,
 ];
-export const MarkerName = ['MarkDOMContent', 'MarkLoad', 'firstPaint', 'firstContentfulPaint', 'largestContentfulPaint::Candidate'];
 export function isMarkerEvent(event) {
-    if (event.ph === "I" /* Phase.INSTANT */ || event.ph === "R" /* Phase.MARK */) {
+    if (event.ph === "I" /* Phase.INSTANT */ || "n" /* Phase.ASYNC_NESTABLE_INSTANT */ || event.ph === "R" /* Phase.MARK */) {
         return markerTypeGuards.some(fn => fn(event));
     }
     return false;
@@ -58,7 +74,7 @@ const pageLoadEventTypeGuards = [
     isInteractiveTime,
 ];
 export function eventIsPageLoadEvent(event) {
-    if (event.ph === "I" /* Phase.INSTANT */ || event.ph === "R" /* Phase.MARK */) {
+    if (event.ph === "I" /* Phase.INSTANT */ || "n" /* Phase.ASYNC_NESTABLE_INSTANT */ || event.ph === "R" /* Phase.MARK */) {
         return pageLoadEventTypeGuards.some(fn => fn(event));
     }
     return false;
@@ -285,10 +301,13 @@ export function isLayoutInvalidationTracking(event) {
     return event.name === "LayoutInvalidationTracking" /* Name.LAYOUT_INVALIDATION_TRACKING */;
 }
 export function isFirstContentfulPaint(event) {
-    return event.name === 'firstContentfulPaint';
+    return event.name === "firstContentfulPaint" /* Name.MARK_FCP */;
+}
+export function isAnyLargestContentfulPaintCandidate(event) {
+    return event.name === "largestContentfulPaint::Candidate" /* Name.MARK_LCP_CANDIDATE */ || event.name === "largestContentfulPaint::CandidateForSoftNavigation" /* Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */;
 }
-export function isLargestContentfulPaintCandidate(event) {
-    return event.name === "largestContentfulPaint::Candidate" /* Name.MARK_LCP_CANDIDATE */;
+export function isSoftLargestContentfulPaintCandidate(event) {
+    return event.name === "largestContentfulPaint::CandidateForSoftNavigation" /* Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION */;
 }
 export function isLargestImagePaintCandidate(event) {
     return event.name === 'LargestImagePaint::Candidate';
@@ -297,13 +316,13 @@ export function isLargestTextPaintCandidate(event) {
     return event.name === 'LargestTextPaint::Candidate';
 }
 export function isMarkLoad(event) {
-    return event.name === 'MarkLoad';
+    return event.name === "MarkLoad" /* Name.MARK_LOAD */;
 }
 export function isFirstPaint(event) {
-    return event.name === 'firstPaint';
+    return event.name === "firstPaint" /* Name.MARK_FIRST_PAINT */;
 }
 export function isMarkDOMContent(event) {
-    return event.name === 'MarkDOMContent';
+    return event.name === "MarkDOMContent" /* Name.MARK_DOM_CONTENT */;
 }
 export function isInteractiveTime(event) {
     return event.name === 'InteractiveTime';
@@ -369,7 +388,7 @@ export function isPrePaint(event) {
 }
 /** A VALID navigation start (as it has a populated documentLoaderURL) */
 export function isNavigationStart(event) {
-    return event.name === 'navigationStart' && event.args?.data?.documentLoaderURL !== '';
+    return event.name === "navigationStart" /* Name.NAVIGATION_START */ && event.args?.data?.documentLoaderURL !== '';
 }
 export function isDidCommitSameDocumentNavigation(event) {
     return event.name === 'RenderFrameHostImpl::DidCommitSameDocumentNavigation' && event.ph === "X" /* Phase.COMPLETE */;